Re: [PATCH for-5.1 V3 3/7] hw/mips: Add CPU IRQ3 delivery for KVM

loped-by: Jiaxun Yang > --- Reviewed-by: Aleksandar Markovic > hw/mips/mips_int.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c > index 796730b..982ce34 100644 > --- a/hw/mips/mips_int.c > +++ b/hw

Re: [PATCH for-5.1 V3 1/7] configure: Add KVM target support for MIPS64

нед, 3. мај 2020. у 12:23 Huacai Chen је написао/ла: > > Preparing for Loongson-3 virtualization, add KVM target support for > MIPS64 in configure script. > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- Reviewed-by: Aleksandar Markovic > co

Re: [PATCH 00/12] hw/mips/fuloong2e: PoC to fix hang after reboot

нед, 10. мај 2020. у 23:01 Philippe Mathieu-Daudé је написао/ла: > > The PMON firmware behave differently regarding it is run > after a cold/warm reset. A simple bit flip fix the issue, > however we need to know the type of reset to set it. > Currently QEMU only supports COLD reset. > > This

Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name

пон, 11. мај 2020. у 10:12 Aleksandar Markovic је написао/ла: > > пон, 11. мај 2020. у 08:52 chen huacai је написао/ла: > > > > Hi, Philippe and Alexandar, > > > > On Mon, May 11, 2020 at 2:38 PM Philippe Mathieu-Daudé > > wrote: > > > > &

Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name

пон, 11. мај 2020. у 08:52 chen huacai је написао/ла: > > Hi, Philippe and Alexandar, > > On Mon, May 11, 2020 at 2:38 PM Philippe Mathieu-Daudé > wrote: > > > > On 5/11/20 8:21 AM, Aleksandar Markovic wrote: > > > пон, 11. мај 2020. у 03:11 chen huacai је

Re: [PATCH 11/12] hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32

пон, 11. мај 2020. у 08:30 Philippe Mathieu-Daudé је написао/ла: > > On 5/11/20 8:17 AM, Aleksandar Markovic wrote: > > нед, 10. мај 2020. у 23:01 Philippe Mathieu-Daudé је > > написао/ла: > >> > >> Describe some Config registers fields with the registe

Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name

me for backward > > compatibility. > > > > Suggested-by: Aleksandar Markovic > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > docs/system/target-mips.rst | 2 +- > > default-configs/mips64el-softmmu.mak | 2 +- > > hw/isa/vt82c686.c

Re: [PATCH 11/12] hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32

нед, 10. мај 2020. у 23:01 Philippe Mathieu-Daudé је написао/ла: > > Describe some Config registers fields with the registerfields > API. Use the FIELD_DP32() macro to set the BONGENCFG register > bits at reset. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/bonito.c | 21

Re: [PATCH 09/12] hw/pci-host/bonito: Map the different PCI ranges more detailled

нед, 10. мај 2020. у 23:01 Philippe Mathieu-Daudé је написао/ла: > > Better describe the Bonito64 MEM HI/LO and I/O PCI ranges, > add more PCI regions as unimplemented. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/bonito.c | 30 ++ > 1 file changed,

Re: [PATCH 10/12] hw/pci-host/bonito: Better describe the I/O CS regions

нед, 10. мај 2020. у 23:01 Philippe Mathieu-Daudé је написао/ла: > > Better describe the I/O CS regions, add the ROMCS region. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/bonito.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) >

Re: [PATCH 08/12] hw/pci-host/bonito: Map all the Bonito64 I/O range

> > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/bonito.c | 3 +++ > hw/pci-host/Kconfig | 1 + > 2 files changed, 4 insertions(+) > Reviewed-by: Aleksandar Markovic > diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c > index 7ed462ffb5..9761780f44 1006

Re: [PATCH 07/12] hw/pci-host/bonito: Map peripheral using physical address

sertions(+), 2 deletions(-) > Reviewed-by: Aleksandar Markovic > diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c > index 10ead31e4f..7ed462ffb5 100644 > --- a/hw/pci-host/bonito.c > +++ b/hw/pci-host/bonito.c > @@ -647,12 +647,12 @@ static void b

Re: [PATCH 01/12] MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer

PS/fuloong2e. > > Cc: Jiaxun Yang > Signed-off-by: Huacai Chen > Message-Id: <1586337380-25217-3-git-send-email-che...@lemote.com> > [PMD: Added Jiaxun Yang as reviewer] > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 ++ > 1 file changed,

Re: [INFO] Some preliminary performance data

суб, 9. мај 2020. у 14:50 Laurent Desnogues је написао/ла: > > On Sat, May 9, 2020 at 2:38 PM Aleksandar Markovic > wrote: > > > > суб, 9. мај 2020. у 13:37 Laurent Desnogues > > је написао/ла: > > > > > > On Sat, May 9, 2020 at 12:17 PM Aleksanda

Re: [INFO] Some preliminary performance data

суб, 9. мај 2020. у 13:37 Laurent Desnogues је написао/ла: > > On Sat, May 9, 2020 at 12:17 PM Aleksandar Markovic > wrote: > > сре, 6. мај 2020. у 13:26 Alex Bennée је > > написао/ла: > > > > > This is very much driven by how much code generation vs

Re: [INFO] Some preliminary performance data

суб, 9. мај 2020. у 12:16 Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> је написао/ла: > > > > сре, 6. мај 2020. у 13:26 Alex Bennée је написао/ла: > > > > > > Aleksandar Markovic writes: > > > > Some preliminary thoughts > >

[Bug 1877706] Re: [Feature request] qemu does not support for Octeon MIPS64 on X86

Probably not, but there may be a workaround. The closest cpu to Octeon that is supported in QEMU is "MIPS64R2-generic". Please try using switch -cpu MIPS64R2-generic in your QEMU command line. Also, I think you should use qemu-mipsn32 rather than qemu-mips or qemu- mips64. I don't have much

Re: [PATCH for-5.1 V3 0/7] mips: Add Loongson-3 machine support (with KVM)

нед, 3. мај 2020. у 12:21 Huacai Chen је написао/ла: > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while > Loongson-3A R4 is the newest and its ISA is almost the superset of all > others. To reduce

Re: [PATCH V3 09/14] KVM: MIPS: Add more types of virtual interrupts

liver_cb(struct kvm_vcpu *vcpu, unsigned int > priority, > u32 cause) > { > u32 irq = (priority < MIPS_EXC_MAX) ? > - kvm_vz_priority_to_irq[priority] : 0; > + kvm_priority_to_irq[priority] : 0; > > switch (priority) { > case MIPS_EXC_INT_TIMER: > set_gc0_cause(C_TI); > break; > > - case MIPS_EXC_INT_IO: > + case MIPS_EXC_INT_IO_1: > + case MIPS_EXC_INT_IO_2: > case MIPS_EXC_INT_IPI_1: > case MIPS_EXC_INT_IPI_2: > if (cpu_has_guestctl2) > @@ -311,7 +273,7 @@ static int kvm_vz_irq_clear_cb(struct kvm_vcpu *vcpu, > unsigned int priority, >u32 cause) > { > u32 irq = (priority < MIPS_EXC_MAX) ? > - kvm_vz_priority_to_irq[priority] : 0; > + kvm_priority_to_irq[priority] : 0; > > switch (priority) { > case MIPS_EXC_INT_TIMER: > @@ -329,7 +291,8 @@ static int kvm_vz_irq_clear_cb(struct kvm_vcpu *vcpu, > unsigned int priority, > } > break; > > - case MIPS_EXC_INT_IO: > + case MIPS_EXC_INT_IO_1: > + case MIPS_EXC_INT_IO_2: > case MIPS_EXC_INT_IPI_1: > case MIPS_EXC_INT_IPI_2: > /* Clear GuestCtl2.VIP irq if not using Hardware Clear */ > -- > 2.7.0 > Reviewed-by: Aleksandar Markovic

Re: [PATCH V3 13/14] KVM: MIPS: Add more MMIO load/store instructions emulation

*gpr = *(s32 *)run->mmio.data; > - else > + switch (vcpu->mmio_needed) { > + case 1: > *gpr = *(u32 *)run->mmio.data; > + break; > + case 2: > + *gpr = *(s32 *)run->mmio.data; > + break; > + case 3: > + *gpr = (vcpu->arch.gprs[vcpu->arch.io_gpr] & > 0xff) | > + (((*(s32 *)run->mmio.data) & 0xff) << 24); > + break; > + case 4: > + *gpr = (vcpu->arch.gprs[vcpu->arch.io_gpr] & 0x) | > + (((*(s32 *)run->mmio.data) & 0x) << 16); > + break; > + case 5: > + *gpr = (vcpu->arch.gprs[vcpu->arch.io_gpr] & 0xff) | > + (((*(s32 *)run->mmio.data) & 0xff) << 8); > + break; > + case 6: > + case 7: > + *gpr = *(s32 *)run->mmio.data; > + break; > + case 8: > + *gpr = (vcpu->arch.gprs[vcpu->arch.io_gpr] & > 0xff00) | > + *(s32 *)run->mmio.data)) >> 8) & > 0xff); > + break; > + case 9: > + *gpr = (vcpu->arch.gprs[vcpu->arch.io_gpr] & > 0x) | > + *(s32 *)run->mmio.data)) >> 16) & 0x); > + break; > + case 10: > + *gpr = (vcpu->arch.gprs[vcpu->arch.io_gpr] & > 0xff00) | > + *(s32 *)run->mmio.data)) >> 24) & 0xff); > + break; > + default: > + *gpr = *(s32 *)run->mmio.data; > + } > break; > > case 2: > - if (vcpu->mmio_needed == 2) > - *gpr = *(s16 *) run->mmio.data; > - else > + if (vcpu->mmio_needed == 1) > *gpr = *(u16 *)run->mmio.data; > + else > + *gpr = *(s16 *)run->mmio.data; > > break; > case 1: > - if (vcpu->mmio_needed == 2) > - *gpr = *(s8 *) run->mmio.data; > + if (vcpu->mmio_needed == 1) > + *gpr = *(u8 *)run->mmio.data; > else > - *gpr = *(u8 *) run->mmio.data; > + *gpr = *(s8 *)run->mmio.data; > break; > } > > -- > 2.7.0 > Reviewed-by: Aleksandar Markovic

Re: [PATCH V3 00/14] KVM: MIPS: Add Loongson-3 support (Host Side)

нед, 3. мај 2020. у 12:06 Huacai Chen је написао/ла: > > We are preparing to add KVM support for Loongson-3. VZ extension is > fully supported in Loongson-3A R4+, and we will not care about old CPUs > (at least now). We already have a full functional Linux kernel (based > on Linux-5.4.x LTS) and

Re: [PATCH V3 10/14] KVM: MIPS: Add Loongson-3 Virtual IPI interrupt support

нед, 3. мај 2020. у 12:14 Huacai Chen је написао/ла: > > This patch add Loongson-3 Virtual IPI interrupt support in the kernel, > because emulate it in QEMU is too expensive for performance. > Huacei, hi! While, in principle, I support this patch, could you please, just for the sake of

Re: [PATCH V3 08/14] KVM: MIPS: Let indexed cacheops cause guest exit on Loongson-3

lear_c0_guestctl0ext(MIPS_GCTL0EXT_CGI); > + } > > if (cpu_has_guestid) { > write_c0_guestctl1(0); > -- > 2.7.0 > Reviewed-by: Aleksandar Markovic

Re: [PATCH V3 07/14] KVM: MIPS: Use root tlb to control guest's CCA for Loongson-3

s_guestctl2) > clear_c0_guestctl2(0x3f << 10); > > +#ifdef CONFIG_CPU_LOONGSON64 > + /* Control guest CCA attribute */ > + if (cpu_has_csr()) > + csr_writel(csr_readl(0xffec) | 0x1, 0xffec); > +#endif > + > return 0; > } > > -- > 2.7.0 > Reviewed-by: Aleksandar Markovic

Re: [PATCH V3 06/14] KVM: MIPS: Introduce and use cpu_guest_has_ldpte

kvm_restore_gc0_pwsize(cop0); > @@ -2685,8 +2685,8 @@ static int kvm_vz_vcpu_put(struct kvm_vcpu *vcpu, int > cpu) > } > > /* save HTW registers if enabled in guest */ > - if (cpu_guest_has_htw && > - kvm_read_sw_gc0_config3(cop0) & MIPS_CONF3_PW) { > + if (cpu_guest_has_ldpte || (cpu_guest_has_htw && > + kvm_read_sw_gc0_config3(cop0) & MIPS_CONF3_PW)) { > kvm_save_gc0_pwbase(cop0); > kvm_save_gc0_pwfield(cop0); > kvm_save_gc0_pwsize(cop0); > -- > 2.7.0 > Reviewed-by: Aleksandar Markovic

Re: [PATCH V3 05/14] KVM: MIPS: Use lddir/ldpte instructions to lookup gpa_mm.pgd

his can be common with the > * Linux TLB refill handler, however we don't need to handle so many > @@ -512,6 +528,7 @@ void *kvm_mips_build_tlb_refill_exception(void *addr, > void *handler) > build_get_ptep(, K0, K1); > build_update_entries(, K0, K1); > build_tlb_write_entry(, , , tlb_random); > +#endif > > preempt_enable(); > > -- > 2.7.0 > Reviewed-by: Aleksandar Markovic

Re: [PATCH V3 03/14] KVM: MIPS: Increase KVM_MAX_VCPUS and KVM_USER_MEM_SLOTS to 16

hat does not exposed to userspace */ > #define KVM_PRIVATE_MEM_SLOTS 0 > > -- > 2.7.0 > Reviewed-by: Aleksandar Markovic

Re: [PATCH V3 02/14] KVM: MIPS: Fix VPN2_MASK definition for variable cpu_vmbits

ASID cpu_asid_mask(_cpu_data) > #define TLB_IS_GLOBAL(x) ((x).tlb_lo[0] & (x).tlb_lo[1] & ENTRYLO_G) > #define TLB_VPN2(x)((x).tlb_hi & VPN2_MASK) > -- > 2.7.0 > Reviewed-by: Aleksandar Markovic

Re: [PATCH V3 04/14] KVM: MIPS: Add EVENTFD support which is needed by VHOST

пет, 8. мај 2020. у 11:08 Aleksandar Markovic је написао/ла: > > нед, 3. мај 2020. у 12:09 Huacai Chen је написао/ла: > > > > Add EVENTFD support for KVM/MIPS, which is needed by VHOST. Tested on > > Loongson-3 platform. > > > > Signed-off-by: Huacai Ch

Re: [PATCH V3 01/14] KVM: MIPS: Define KVM_ENTRYHI_ASID to cpu_asid_mask(_cpu_data)

ai: Change current_cpu_data to boot_cpu_data for optimization] > Signed-off-by: Huacai Chen > --- > arch/mips/include/asm/kvm_host.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > For what is worth: Reviewed-by: Aleksandar Markovic > diff --git a/arch/mips/includ

Re: [PATCH V3 04/14] KVM: MIPS: Add EVENTFD support which is needed by VHOST

d cleanly into master. But, in general, for what is worth: Reviewed-by: Aleksandar Markovic > arch/mips/kvm/Kconfig | 1 + > arch/mips/kvm/Makefile| 2 +- > arch/mips/kvm/trap_emul.c | 3 +++ > arch/mips/kvm/vz.c| 3 +++ > 4 files changed, 8 insertions(+), 1 deletion(-) >

Re: [PATCH for-5.1 V3 0/7] mips: Add Loongson-3 machine support (with KVM)

сре, 6. мај 2020. у 03:43 Huacai Chen је написао/ла: > > Hi, Aleksandar, > > On Tue, May 5, 2020 at 6:12 PM Aleksandar Markovic > wrote: > > > > > > > > уторак, 05. мај 2020., chen huacai је написао/ла: > >> > >> Hi, Aleksandar, >

Re: [PATCH V3 01/14] KVM: MIPS: Define KVM_ENTRYHI_ASID to cpu_asid_mask(_cpu_data)

чет, 7. мај 2020. у 01:43 Sasha Levin је написао/ла: > > Hi > > [This is an automated email] > > This commit has been processed because it contains a -stable tag. > The stable tag indicates that it's relevant for the following trees: all > > The bot has tested the following trees: v5.6.10,

Re: [PATCH V2] tests/Makefile: Fix description of "make check"

hanged, 1 insertion(+), 1 deletion(-) > > For this version too: Reviewed-by: Aleksandar Markovic > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 03a74b6..5d32239 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -4,7 +4,7 @@ >

Re: [PATCH v2 06/10] mips/malta: Fix create_cps() error handling

it no longer points to NULL for the second > > create_cps() is wrong that way. The last calls treats an error as > fatal. Do that for the prior ones, too. > > Fixes: bff384a4fbd5d0e86939092e74e766ef0f5f592c > Cc: Aleksandar Markovic > Cc: "Philippe Mathieu-Daudé" &g

Re: [PATCH v2 07/10] mips/boston: Fix boston_mach_init() error handling

> Signed-off-by: Markus Armbruster > --- Reviewed-by: Aleksandar Markovic > hw/mips/boston.c | 13 + > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/hw/mips/boston.c b/hw/mips/boston.c > index 98ecd25e8e..2832dfa6ae 100644 > --- a/hw/mips/boston.c

Re: [PATCH v2 08/10] mips/boston: Plug memory leak in boston_mach_init()

> > Thank you, Markus, for spotting this error. Reviewed-by: Aleksandar Markovic I am fine with you selecting this and another mips-related patch in this series in your pull request, that will be result of this series. Truly yours, Aleksandar > diff --git a/hw/mips/boston.c b/hw/mi

Re: [PATCH] tests/Makefile: Fix description of "make check"

уторак, 05. мај 2020., Huacai Chen је написао/ла: > The description of "make check" is out-of-date, so fix it by adding > block and softfloat. > > Signed-off-by: Huacai Chen > --- Reviewed-by: Aleksandar Markovic > tests/Makefile.include | 2 +- > 1

Re: [PATCH for-5.1 V3 0/7] mips: Add Loongson-3 machine support (with KVM)

уторак, 05. мај 2020., chen huacai је написао/ла: > Hi, Aleksandar, > > On Sun, May 3, 2020 at 6:50 PM Aleksandar Markovic > wrote: > > > > нед, 3. мај 2020. у 12:21 Huacai Chen је > написао/ла: > > > > > > Loongson-3 CPU family include Loongs

Re: [PATCH] ppc: Use hard-float in ppc fp_hlper as early as possible. This would increase the performance better than enable hard-float it in soft-float.c; Just using fadd fsub fmul fdiv as a simple b

пон, 4. мај 2020. у 21:31 је написао/ла: > > From: Yonggang Luo > > Just post as an idea to improve PPC fp performance. > With this idea, we have no need to adjust the helper orders. > > Signed-off-by: Yonggang Luo > --- > target/ppc/fpu_helper.c | 44 +

Re: target/mips: Enable Hardware page table walker and CMGCR features for P5600

субота, 25. април 2020., је написао/ла: > Hi, > I have discovered that MIPS hardware page table walker is not enabled > for any CPU currently available. In this patch I have enable it (and > also CMGCR feature) for P5600 which supports both but they are not > enabled. > > Andrea, Just wanted to

Re: [RFC PATCH 2/2] linux-user/mmap: Fix Clang 'type-limit-compare' warning

> +#if TARGET_ABI_BITS < TARGET_LONG_BITS > /* Check if address fits target address space */ > if ((unsigned long)host_addr + new_size > (abi_ulong)-1) { It would be clearer if "#if TARGET_LONG_BITS > TARGET_ABI_BITS" is used, to match the comparison in if() statement. >

Re: [RFC PATCH 2/2] linux-user/mmap: Fix Clang 'type-limit-compare' warning

нед, 3. мај 2020. у 14:49 Aleksandar Markovic је написао/ла: > > нед, 3. мај 2020. у 13:33 Philippe Mathieu-Daudé је > написао/ла: > > > > When building with Clang 10 on Fedora 32, we get: > > > > CC linux-user/mmap.o > > linux-user/mmap.c:720:49

Re: [RFC PATCH 2/2] linux-user/mmap: Fix Clang 'type-limit-compare' warning

нед, 3. мај 2020. у 13:33 Philippe Mathieu-Daudé је написао/ла: > > When building with Clang 10 on Fedora 32, we get: > > CC linux-user/mmap.o > linux-user/mmap.c:720:49: error: result of comparison 'unsigned long' > > 18446744073709551615 is always false >

Re: [PATCH for-5.1 V3 0/7] mips: Add Loongson-3 machine support (with KVM)

нед, 3. мај 2020. у 12:21 Huacai Chen је написао/ла: > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while > Loongson-3A R4 is the newest and its ISA is almost the superset of all > others. To reduce

Re: [INFO] Some preliminary performance data

[correcting some email addresses] нед, 3. мај 2020. у 01:20 Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> је написао/ла: > Hi, all. > > I just want to share with you some bits and pieces of data that I got > while doing some preliminary experimentation for the

[INFO] Some preliminary performance data

Hi, all. I just want to share with you some bits and pieces of data that I got while doing some preliminary experimentation for the GSoC project "TCG Continuous Benchmarking", that Ahmed Karaman, a student of the fourth final year of Electical Engineering Faculty in Cairo, will execute. *User

Re: [PATCH for-5.1 6/7] hw/mips: Add Loongson-3 machine support (with KVM)

Hi. Huacei. Please expand commit message with the description of the machine internal organization (several paragraphs). Also, please include command line for starting the machine. More than one example is better than only one. Specifically, can you explicitly say what is your KVM setup, so

Re: [PATCH for-5.1 1/7] configure: Add KVM target support for MIPS64

пон, 27. апр 2020. у 11:33 Huacai Chen је написао/ла: > > Preparing for Loongson-3 virtualization, add KVM target support for > MIPS64 in configure script. > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- Huacai, hi. I am really glad this series arrived, and salute your

Re: [PATCH for-5.1 5/7] target/mips: Add more CP0 register for save/restore

пон, 27. апр 2020. у 11:36 Huacai Chen је написао/ла: > > Add more CP0 register for save/restore, including: EBase, XContext, > PageGrain, PWBase, PWSize, PWField, PWCtl, Config*, KScratch1~KScratch6. > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- > target/mips/kvm.c |

Re: [PATCH for-5.1 3/7] hw/mips: Add CPU IRQ3 delivery for KVM

уто, 28. апр 2020. у 10:21 chen huacai је написао/ла: > > Hi, Philippe, > > On Mon, Apr 27, 2020 at 5:57 PM Philippe Mathieu-Daudé > wrote: > > > > On 4/27/20 11:33 AM, Huacai Chen wrote: > > > Currently, KVM/MIPS only deliver I/O interrupt via IP2, this patch add > > > IP2 delivery as well,

Re: [PATCH for-5.1 4/7] target/mips: Add Loongson-3 CPU definition

Huacai, Can you please do machine translation of the document? It can be done via translate.google.com (it accepts pdf files, but does not have download feature, and workaround is to "print to pdf"... Thanks in advance! Aleksandar уто, 28. апр 2020. у 10:26 chen huacai је написао/ла: > > Hi,

Re: [PATCH v2 09/36] tcg: Consolidate 3 bits into enum TCGTempKind

сре, 22. апр 2020. у 03:27 Richard Henderson је написао/ла: > > The temp_fixed, temp_global, temp_local bits are all related. > Combine them into a single enumeration. > > Signed-off-by: Richard Henderson > --- > include/tcg/tcg.h | 20 +--- > tcg/optimize.c| 8 +-- > tcg/tcg.c

Re: [PATCH v2 20/36] tcg: Remove movi and dupi opcodes

среда, 22. април 2020., Richard Henderson је написао/ла: > These are now completely covered by mov from a > TYPE_CONST temporary. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Aleksandar Markovic > include/tcg/tcg-opc.h| 3 --- > tcg/aarch64/

Re: [PATCH 3/4] linux-user/arm: Handle invalid arm-specific syscalls correctly

пон, 20. апр 2020. у 23:25 Peter Maydell је написао/ла: > > The kernel has different handling for syscalls with invalid > numbers that are in the "arm-specific" range 0x9f and up: > * 0x9f..0x9f07ff return -ENOSYS if not implemented > * other out of range syscalls cause a SIGILL > (see

Re: [PATCH] tcg/mips: mips sync* encode error

| 0x?? << 6' rather than > > 'OPC_SYNC | 0x?? << 5'. Wrong encode can lead illegal instruction > > errors. These instructions often appear with multi-threaded > > simulation. > > Good catch. > > Reviewed-by: Richard Henderson > > Queued to tcg-for-5.0. >

Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

18:14 Pet, 10.04.2020. Peter Maydell је написао/ла: > But I think some submaintainers don't bother to add r-by tags > for things they review in the process of assembling their > tree because they see it as implicit in the process. > I think that was precisely the case in this patch. May I wish

Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

17:17 Pet, 10.04.2020. Richard Henderson је написао/ла: > > On 4/10/20 2:38 AM, Aleksandar Markovic wrote: > > 17:55 Uto, 07.04.2020. Alex Bennée > <mailto:alex.ben...@linaro.org>> је написао/ла: > >> > >> From: Richard Henderson > <mailto:ri

Re: [PATCH 3/3] MAINTAINERS: Add myself as fulong2e co-maintainer

04:39 Čet, 09.04.2020. Jiaxun Yang је написао/ла: > > On Thu, 9 Apr 2020 10:17:46 +0800 > Huacai Chen wrote: > > > Hi, Aleksandar, > > > > On Wed, Apr 8, 2020 at 11:30 PM Aleksandar Markovic > > wrote: > > > > > > 11:08 Sre, 08.04.202

Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

17:55 Uto, 07.04.2020. Alex Bennée је написао/ла: > > From: Richard Henderson > > All other calls to normalize*Subnormal detect zero input before > the call -- this is the only outlier. This case can happen with > +0.0 + +0.0 = +0.0 or -0.0 + -0.0 = -0.0, so return a zero of > the correct sign.

Re: [PATCH 3/3] MAINTAINERS: Add myself as fulong2e co-maintainer

> Signed-off-by: Huacai Chen > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 642c8e0..3281ff2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1073,6 +1073,7 @@ F: hw/mips/mips_r4k.c > Fulong 2E > M: Ph

Re: [RFC PATCH-for-5.0?] target/mips/translate: Report exception in delay slot as UNPREDICTABLE

11:32 Uto, 07.04.2020. Philippe Mathieu-Daudé је написао/ла: > > On 4/7/20 11:23 AM, Philippe Mathieu-Daudé wrote: > > On 4/7/20 10:35 AM, Peter Maydell wrote: > >> On Tue, 7 Apr 2020 at 00:55, Philippe Mathieu-Daudé > >> wrote: > >>> > >>> Using the BC1ANY4F instruction with a 24Kf core

Re: [PATCH 0/3] target/mips: Add loongson gs464 core

13:37 Pet, 03.04.2020. Jiaxun Yang је написао/ла: > > > 在 星期五, 2020-04-03 18:00:31 Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> 撰写 > > > > 00:02 Pet, 27.03.2020. Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> је написао/ла: &g

Re: [PATCH v4 for-5.0] configure: warn if not using a separate build directory

11:14 Sub, 04.04.2020. Peter Maydell је написао/ла: > > On Fri, 3 Apr 2020 at 23:35, Aleksandar Markovic > wrote: > > But, Eric, while, to some extent I understand your motivation and the idea, there are still features working in in-tree builds only (some coccinele scenarios

Re: [PATCH v4 for-5.0] configure: warn if not using a separate build directory

ory. This will work, but we recommend using a separate" > echo "build directory, especially if you plan to work with the QEMU" > echo "sources rather than just building it once. You can switch to" > echo "a separate build directory like this:" > [instructions go here] > Peter's version is far more superior to Daniel's. I'd better not discuss the reasons, not wanting to waste my time and other's time. For Peter's version: Reviewed-by: Aleksandar Markovic > thanks > -- PMM >

Re: [PATCH v4 for-5.0] configure: warn if not using a separate build directory

16:44 Pet, 03.04.2020. Eric Blake је написао/ла: > > On 4/3/20 9:02 AM, Eric Blake wrote: > > On 4/3/20 8:53 AM, Daniel P. Berrangé wrote: > >> Running configure directly from the source directory is a build > >> configuration that will go away in future. It is also not currently > >> covered by

Re: [PATCH 0/3] target/mips: Add loongson gs464 core

00:02 Pet, 27.03.2020. Aleksandar Markovic је написао/ла: > > 12:05 Sre, 25.03.2020. Jiaxun Yang је написао/ла: > > > > Loongson gs464 core can be found in Loongson-3A1000 processor. > > This patchset add minimal support for that core. > > There are still some i

Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

13:23 Uto, 24.03.2020. Jiaxun Yang је написао/ла: > > Loongson multimedia condition instructions were previously implemented as > write 0 to rd due to lack of documentation. So I just confirmed with Loongson > about their encoding and implemented them correctly. > Hi, Jiaxun, Richard Henderson

Re: [PATCH-for-5.0?] decodetree: Use Python3 floor division operator

20:47 Pon, 30.03.2020. Richard Henderson је написао/ла: > > On 3/30/20 10:14 AM, Richard Henderson wrote: > > On 3/30/20 5:13 AM, Philippe Mathieu-Daudé wrote: > >> This script started using Python2, where the 'classic' division > >> operator returns the floor result. In commit 3d004a371 we

Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

18:31 Pon, 30.03.2020. Jiaxun Yang је написао/ла: > > > > 于 2020年3月31日 GMT+08:00 上午12:22:43, "Philippe Mathieu-Daudé" < phi...@redhat.com> 写到: > >On 3/30/20 6:18 PM, Jiaxun Yang wrote: > >> > >> > >> 于 2020年3月30日 GMT+08:00 下午11:39:44, "Philippe Mathieu-Daudé" > > 写到: > >>> Hi Jiaxun Yang, > >>> >

Re: deprecation of in-tree builds

15:32 Pon, 30.03.2020. Peter Maydell је написао/ла: > > Consensus in the thread seemed to lean towards having > the 'configure/make' runes auto-create a build directory; > if we want to do that we should probably not say anything in > the release notes, because we'll cause people to change >

Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

03:30 Čet, 26.03.2020. Richard Henderson је написао/ла: > > On 3/25/20 3:44 AM, Aleksandar Markovic wrote: > > May I ask you, Richard, to select this patch for your next TCG-for-5.0 queue, > > so that I don't go through a MIPS queue process for just a single patch? > &g

Re: [PATCH v8 00/74] per-CPU locks

11:50 Pet, 27.03.2020. Aleksandar Markovic је написао/ла: > > > > петак, 27. март 2020., Alex Bennée је написао/ла: >> >> >> Aleksandar Markovic writes: >> >> > 21:37 Čet, 26.03.2020. Robert Foley је написао/ла: >> >> >> >&g

Re: [PATCH v1 5/7] fpu/softfloat: avoid undefined behaviour when normalising empty sigs

11:53 Pet, 27.03.2020. Alex Bennée је написао/ла: > > The undefined behaviour checker Alex, what exactly is "undefined behaviour checker"? If this is a test, can you give us a link? Sincerely, Aleksandar > pointed out that a shift of 64 would > lead to undefined behaviour. > > Signed-off-by:

Re: [PATCH v8 00/74] per-CPU locks

петак, 27. март 2020., Alex Bennée је написао/ла: > > Aleksandar Markovic writes: > > > 21:37 Čet, 26.03.2020. Robert Foley је > написао/ла: > >> > >> V7: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg00786.html > >> > >> This

Re: [PATCH 0/3] target/mips: Add loongson gs464 core

12:05 Sre, 25.03.2020. Jiaxun Yang је написао/ла: > > Loongson gs464 core can be found in Loongson-3A1000 processor. > This patchset add minimal support for that core. > There are still some instructions missing, I'm going to work on > them later. > > The corresponding hw board is also missing.

Re: [PATCH v8 00/74] per-CPU locks

21:37 Čet, 26.03.2020. Robert Foley је написао/ла: > > V7: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg00786.html > > This is a continuation of the series created by Emilio Cota. > We are picking up this patch set with the goal to apply > any fixes or updates needed to get this

Re: [PATCH-for-5.0 08/12] hw/mips/boston: Add missing error-propagation code

0x1fc0, 4 * MiB); > if (fw_size == -1) { > error_report("unable to load firmware image '%s'", >machine->firmware); > exit(1); > } > } else if (machine->kernel_filename) { > fit_err = load_fit(_fit_loader, machine->kernel_filename, s); > if (fit_err) { > error_report("unable to load FIT image"); > exit(1); > } > > gen_firmware(memory_region_get_ram_ptr(flash) + 0x7c0, > s->kernel_entry, s->fdt_base, is_64b); > } else if (!qtest_enabled()) { > error_report("Please provide either a -kernel or -bios argument"); > exit(1); > } > } > -- > 2.21.1 > Reviewed-by: Aleksandar Markovic

Re: [PATCH-for-5.0 09/12] hw/mips/mips_malta: Add missing error-propagation code

rq = NULL; > } > @@ -1206,9 +1215,9 @@ static void create_cps(MachineState *ms, MaltaState *s, > static void mips_create_cpu(MachineState *ms, MaltaState *s, > qemu_irq *cbus_irq, qemu_irq *i8259_irq) > { > if ((ms->smp.cpus > 1) &&

Re: [PATCH-for-5.0 07/12] hw/mips/cps: Add missing error-propagation code

object_property_set_int(OBJECT(>gcr), 0x800, "gcr-rev", ); > +if (err) { > +error_propagate(errp, err); > +return; > +} > object_property_set_int(OBJECT(>gcr), gcr_base, "gcr-base", ); > +if (err) { > + error_propagate(errp, err); > +return; > +} > object_property_set_link(OBJECT(>gcr), OBJECT(>gic.mr), "gic", ); > +if (err) { > +error_propagate(errp, err); > +return; > +} > object_property_set_link(OBJECT(>gcr), OBJECT(>cpc.mr), "cpc", ); > +if (err) { > +error_propagate(errp, err); > +return; > +} > object_property_set_bool(OBJECT(>gcr), true, "realized", ); > if (err != NULL) { > error_propagate(errp, err); > return; > } > > memory_region_add_subregion(>container, gcr_base, > sysbus_mmio_get_region(SYS_BUS_DEVICE(>gcr), 0)); > } > -- > 2.21.1 > If you remove the duplicate check that Peter spotted: Reviewed-by: Aleksandar Markovic

Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

12:47 Sre, 25.03.2020. Aleksandar Markovic је написао/ла: > > 12:44 Sre, 25.03.2020. Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> је написао/ла: > > > > 16:59 Uto, 24.03.2020. Richard Henderson је написао/ла: > > > > > > On 3/24/20 5:

Re: [PATCH v1 06/11] configure: disable MTTCG for MIPS guests

12:53 Sre, 25.03.2020. Aleksandar Markovic је написао/ла: > > 20:17 Pon, 23.03.2020. Richard Henderson је написао/ла: > > > > On 3/23/20 9:15 AM, Alex Bennée wrote: > > > While debugging check-acceptance failures I found an instability in > > > the mips6

Re: [PATCH v1 06/11] configure: disable MTTCG for MIPS guests

ses > > > > Which seems to indicate there is some aspect of the MIPS MTTCG fixes > > that has been missed. Ideally we would fix that but I'm afraid I don't > > have time to investigate and am not super familiar with the > > architecture anyway. In lieu of someone tracki

Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

12:44 Sre, 25.03.2020. Aleksandar Markovic је написао/ла: > > 16:59 Uto, 24.03.2020. Richard Henderson је написао/ла: > > > > On 3/24/20 5:22 AM, Jiaxun Yang wrote: > > > Loongson multimedia condition instructions were previously implemented as > > > write

Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

> > 1 file changed, 31 insertions(+), 4 deletions(-) > > Reviewed-by: Richard Henderson > I just have a couple of mon-essential suggestions wrt coding style, but since all that is really of very insignificant nauture, I wouldn't even mention them. Reviewed-by: Aleksandar Markov

Re: [PATCH v1] mips/mips_malta: Allow more than 2G RAM

18:38 Pon, 23.03.2020. Aurelien Jarno је написао/ла: > > Hi, > > Sorry for the delay, I just want to give some more details about the > Debian. > > On 2020-03-14 10:09, Philippe Mathieu-Daudé wrote: > > IIUC today all distributions supporting MIPS ports are building their MIPS > > packages on

Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

19:09 Uto, 24.03.2020. Jiaxun Yang је написао/ла: > > > > 于 2020年3月25日 GMT+08:00 上午12:56:41, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> 写到: > >14:23 Uto, 24.03.2020. Jiaxun Yang је > >написао/ла: > >> > >> Loongson multimedia condi

Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

14:23 Uto, 24.03.2020. Jiaxun Yang је написао/ла: > > Loongson multimedia condition instructions were previously implemented as > write 0 to rd due to lack of documentation. So I just confirmed with Loongson > about their encoding and implemented them correctly. > > Signed-off-by: Jiaxun Yang >

Re: deprecation of in-tree builds

21:14 Ned, 22.03.2020. Peter Maydell > *Everything* is supposed to work in out of tree builds. > If it doesn't that's a bug -- unless people report bugs > we'll never know to fix them. Most developers use out > of tree builds and all our CI is out of tree builds, so > they actually get better

Re: deprecation of in-tree builds

18:21 Ned, 22.03.2020. Peter Maydell је написао/ла: > > On Sun, 22 Mar 2020 at 15:29, Aleksandar Markovic > wrote: > > If the "progress" (in the form of deprecation) is so impotrant, than the authors should devise it so that there is no dammage to existing feature

Re: deprecation of in-tree builds

9:51 PM Sub, 21.03.2020. Peter Maydell је написао/ла: > > AIUI from Paolo, the intention is to deprecate and eventually > stop supporting "in-tree" builds, so that the only option is > building in a separate build directory. I thought we should > probably mention that in the 5.0 changelog, so I

Re: [PATCH-for-5.0 05/11] hw/ide/sii3112: Remove dead assignment

On Saturday, March 21, 2020, Philippe Mathieu-Daudé wrote: > Fix warning reported by Clang static code analyzer: > > CC hw/ide/sii3112.o > hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read > val = 0; > ^ ~ > > Reported-by: Clang Static

Re: [PATCH-for-5.0 00/11] misc: Trivial static code analyzer fixes

12:47 PM Sub, 21.03.2020. Philippe Mathieu-Daudé је написао/ла: > > Fix trivial warnings reported by the Clang static code analyzer. > Philippe, It would be useful and customary for this type of fixes to provide here the environment you used for obtaining the warnings (clang version, configure

Re: [PATCH-for-5.0 01/11] block: Remove dead assignment

12:49 PM Sub, 21.03.2020. Philippe Mathieu-Daudé је написао/ла: > > Fix warning reported by Clang static code analyzer: > > block.c:3167:5: warning: Value stored to 'ret' is never read > ret = bdrv_fill_options(, filename, , _err); > ^

Re: [PATCH-for-5.0 2/4] tests/docker: Install gcrypt devel package in Debian image

8:06 PM Pet, 20.03.2020. Philippe Mathieu-Daudé је написао/ла: > > Apparently Debian Stretch was listing gcrypt as a QEMU dependency, > but this is not the case anymore in Buster, so we need to install > it manually (it it not listed by 'apt-get -s build-dep qemu' in > the common debian10.docker

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

5:58 AM Sub, 21.03.2020. Jiaxun Yang је написао/ла: > > Loongson multimedia condition instructions were previously implemented as > write 0 to rd due to lack of documentation. So I just confirmed with Loongson > about their encoding and implemented them correctly. > > Signed-off-by: Jiaxun Yang

Re: [RFC PATCH for 5.0] configure: disable MTTCG for MIPS guests

sabled all the mips guests as I assume it's a fundamental > synchronisation primitive that is broken but I haven't tested them all > (there are a lot!). > > Signed-off-by: Alex Bennée > Cc: Aleksandar Markovic > Cc: Aurelien Jarno > Cc: Aleksandar Rikalo > Cc: P

Re: [RFC PATCH for 5.0] configure: disable MTTCG for MIPS guests

пет, 20. мар 2020. у 18:08 Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> је написао/ла: > > пет, 20. мар 2020. у 12:45 Alex Bennée је написао/ла: > > > > While debugging check-acceptance failures I found an instability in > > the mips64el te

Re: [RFC PATCH for 5.0] configure: disable MTTCG for MIPS guests

ation primitive that is broken but I haven't tested them all > (there are a lot!). > > Signed-off-by: Alex Bennée > Cc: Aleksandar Markovic > Cc: Aurelien Jarno > Cc: Aleksandar Rikalo > Cc: Philippe Mathieu-Daudé > --- > configure | 6 +++--- > 1 file changed, 3 insertion

Re: [PULL 0/1] Slirp patches

четвртак, 19. март 2020., Marc-André Lureau је написао/ла: > The following changes since commit f57587c7d47b35b2d9b31def3a74d8 > 1bdb5475d7: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-03-17' > into staging (2020-03-19 10:18:07 +) > > are available in the Git

<    1   2   3   4   5   6   7   8   9   10   >