Re: PCIe with Designware RC.

patch https://lists.gnu.org/archive/html/qemu-devel/2023-12/msg02643.html) Hmm, thought I had fixed this a while ago when doing some work with another systems and 64bit PCIe support as well. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer

[PATCH v2] hw/intc/arm_gicv3: ICC_PMR_EL1 high bits should be RAZ

2]: https://lists.nongnu.org/archive/html/qemu-arm/2023-11/msg00737.html Signed-off-by: Ben Dooks Suggested-by: Peter Maydell --- v2: - fixes as suggested by Peter Maydell to include icv_fullprio_mask() --- hw/intc/arm_gicv3_cpuif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] hw/intc/arm_gicv3: ICC_PMR_EL1 high bits should be RAZ

On 14/11/2023 17:14, Peter Maydell wrote: On Tue, 14 Nov 2023 at 16:54, Ben Dooks wrote: The ICC_PMR_ELx bit msak returned from icc_fullprio_mask should technically also remove any bit above 7 as these are marked reserved (read 0) and should therefore should not be written as anything other

[PATCH] hw/intc/arm_gicv3: ICC_PMR_EL1 high bits should be RAZ

The ICC_PMR_ELx bit msak returned from icc_fullprio_mask should technically also remove any bit above 7 as these are marked reserved (read 0) and should therefore should not be written as anything other than 0. Signed-off-by: Ben Dooks --- hw/intc/arm_gicv3_cpuif.c | 2 +- 1 file changed, 1

[PATCH 00/44] Raspberry Pi 4B machine

Hi, is there an git tree with this series or a newer one available please? -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html

[PATCH] riscv: add config for asid size

bits: -cpu rv64,asid-bits=8 or no asids: -cpu rv64,asid-bits=0 Signed-off-by: Ben Dooks --- target/riscv/cpu.c | 42 + target/riscv/cpu.h | 1 + target/riscv/cpu_bits.h | 2 ++ target/riscv/cpu_cfg.h | 1 + target/riscv/csr.c

Re: [PATCH 00/16] i3c: aspeed: Add I3C support

create mode 100644 include/hw/i3c/i3c.h > create mode 100644 include/hw/i3c/mock-target.h > create mode 100644 include/hw/i3c/remote-i3c.h > delete mode 100644 include/hw/misc/aspeed_i3c.h > create mode 100644 tests/qtest/remote-i3c-test.c > > -- > 2.40.0.348.gf938b09366-goog > > -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear.

Re: [PATCH v2] hw/net/can: Add mcp25625 model

On 17/03/2023 14:11, Pavel Pisa wrote: Hello Ben, thanks for update. On Thursday 16 of March 2023 13:41:13 Ben Dooks wrote: From: Ben Dooks Add support for Microchip MCP25625 SPI based CAN controller which is very similar to the MCP2515 (and covered by the same Linux driver). This can

[PATCH v2] hw/net/can: Add mcp25625 model

From: Ben Dooks Add support for Microchip MCP25625 SPI based CAN controller which is very similar to the MCP2515 (and covered by the same Linux driver). This can be added to any machine with SPI support in the machine model file. Example for using this when configured into a machine

Re: [PATCH] hw/net/can: Add mcp25625 model

branches out today and maybe a new patch out for inclusion. > On Tuesday 17 of January 2023 14:32:29 Ben Dooks wrote: > > On 04/01/2023 12:22, Ben Dooks wrote: > > > From: Ben Dooks > > > > > > Add support for Microchip MCP25625 SPI based CAN controll

Re: [PATCH 1/1] hw/riscv/virt.c: add cbom-block-size fdt property

, "riscv"); qemu_fdt_setprop_string(ms->fdt, cpu_name, "status", "okay"); qemu_fdt_setprop_cell(ms->fdt, cpu_name, "reg", You'll need the same for riscv,cboz-block-size as well. -- Ben Dooks http:

Re: out of CI pipeline minutes again

de runner resources to help? -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear.

Re: [PATCH] hw/net/can: Add mcp25625 model

On 04/01/2023 12:22, Ben Dooks wrote: From: Ben Dooks Add support for Microchip MCP25625 SPI based CAN controller which is very similar to the MCP2515 (and covered by the same Linux driver). This can be added to any machine with SPI support in the machine model file. Example for using

Re: [PATCH] hw/net/can: Add mcp25625 model

On 04/01/2023 12:22, Ben Dooks wrote: From: Ben Dooks Add support for Microchip MCP25625 SPI based CAN controller which is very similar to the MCP2515 (and covered by the same Linux driver). This can be added to any machine with SPI support in the machine model file. Example for using

[PATCH] hw/net/can: Add mcp25625 model

From: Ben Dooks Add support for Microchip MCP25625 SPI based CAN controller which is very similar to the MCP2515 (and covered by the same Linux driver). This can be added to any machine with SPI support in the machine model file. Example for using this when configured into a machine

Re: [PATCH] m25p80: Add the is25wp256 SFPD table

> > > > Cc: Michael Walle > > Cc: Tudor Ambarus > > Signed-off-by: Guenter Roeck > > Reviewed-by: Cédric Le Goater If SFDP is a standard, couldn't we have an function to generate it from the flash parameters? -- Ben Dooks, b...@fluff.org, http://www.fluff

Re: add qemu_fdt_setprop_strings

On 21/10/2022 08:00, Andrew Jones wrote: On Fri, Oct 21, 2022 at 06:58:02AM +0100, Ben Dooks wrote: Add a qemu_fdt_setprop_strings to set a string array into a device-tree. Only minor updates from v4 to fix a couple of minor patch issues. Please see the comments I made on patch 1 of the v4

[PATCH v5 4/6] hw/core: use qemu_fdt_setprop_strings()

Change to using the qemu_fdt_setprop_strings() helper in hw/core code. Signed-off-by: Ben Dooks --- hw/core/guest-loader.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/core/guest-loader.c b/hw/core/guest-loader.c index c61ebc4144..7b8e32e06f 100644

[PATCH v5 2/6] hw/core: don't check return on qemu_fdt_setprop_string_array()

/guest-loader.c is the only place where an return is checked). Signed-off-by: Ben Dooks --- hw/core/guest-loader.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/hw/core/guest-loader.c b/hw/core/guest-loader.c index 391c875a29..c61ebc4144 100644 --- a/hw

add qemu_fdt_setprop_strings

Add a qemu_fdt_setprop_strings to set a string array into a device-tree. Only minor updates from v4 to fix a couple of minor patch issues.

[PATCH v5 6/6] hw/arm: change to use qemu_fdt_setprop_strings()

Change to using qemu_fdt_setprop_strings() instead of using \0 separated string arrays. Note, also there were a few places where qemu_fdt_setprop_string() can be used in the same areas. Signed-off-by: Ben Dooks --- v4: - fixed checkpatch errors with string - fixed patch subject --- hw/arm

[PATCH v5 5/6] hw/mips: use qemu_fdt_setprop_strings()

Change to using qemu_fdt_setprop_strings() helper in hw/mips. Signed-off-by: Ben Dooks Reviewed-by: Peter Maydell --- hw/mips/boston.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/mips/boston.c b/hw/mips/boston.c index d2ab9da1a0..759f6daafe 100644 --- a/hw

[PATCH v5 3/6] hw/riscv: use qemu_fdt_setprop_strings() for string arrays

Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify the code. Signed-off-by: Ben Dooks --- v5: fix re-ordering in sifive_u --- hw/riscv/sifive_u.c | 18 +- hw/riscv/spike.c| 7 ++- hw/riscv/virt.c | 25 ++--- 3 files changed, 13

[PATCH v5 1/6] device_tree: add qemu_fdt_setprop_strings() helper

ompat, ARRAY_SIZE(clint_compat)); Signed-off-by: Ben Dooks --- v4: - go back to the non-return call, no-one is using the result v3; - fix return value for the call - add better help text v2: - fix node/path in comment --- include/sysemu/device_tree.h | 19 +++ 1 file changed

[PATCH v4 6/6] hw/arm: change to use qemu_fdt_setprop_strings()

Change to using qemu_fdt_setprop_strings() instead of using \0 separated string arrays. Note, also there were a few places where qemu_fdt_setprop_string() can be used in the same areas. Signed-off-by: Ben Dooks --- v4: - fixed checkpatch errors with string - fixed patch subject --- hw/arm

[PATCH v4 4/6] hw/core: use qemu_fdt_setprop_strings()

Change to using the qemu_fdt_setprop_strings() helper in hw/core code. Signed-off-by: Ben Dooks --- hw/core/guest-loader.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/core/guest-loader.c b/hw/core/guest-loader.c index c61ebc4144..7b8e32e06f 100644

Re: add qemu_fdt_setprop_strings() and use it in most places

On Tue, Aug 09, 2022 at 07:56:34PM +0100, Ben Dooks wrote: > Add a helper for qemu_fdt_setprop_strings() to take a set of strings > to put into a device-tree, which removes several open-coded methods > such as setting an char arr[] = {..} or setting char val[] = &

[PATCH v4 1/6] device_tree: add qemu_fdt_setprop_strings() helper

ompat, ARRAY_SIZE(clint_compat)); Signed-off-by: Ben Dooks --- v4: - go back to the non-return call, no-one is using the result v3; - fix return value for the call - add better help text v2: - fix node/path in comment --- include/sysemu/device_tree.h | 19 +++ 1 file changed

[PATCH v4 2/6] hw/core: don't check return on qemu_fdt_setprop_string_array()

/guest-loader.c is the only place where an return is checked). Signed-off-by: Ben Dooks --- hw/core/guest-loader.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/hw/core/guest-loader.c b/hw/core/guest-loader.c index 391c875a29..c61ebc4144 100644 --- a/hw

add qemu_fdt_setprop_strings() and use it in most places

Add a helper for qemu_fdt_setprop_strings() to take a set of strings to put into a device-tree, which removes several open-coded methods such as setting an char arr[] = {..} or setting char val[] = "str\0str2"; This is for hw/arm, hw/mips and hw/riscv as well as a couple of cores. It is

[PATCH v4 5/6] hw/mips: use qemu_fdt_setprop_strings()

Change to using qemu_fdt_setprop_strings() helper in hw/mips. Signed-off-by: Ben Dooks Reviewed-by: Peter Maydell --- hw/mips/boston.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/mips/boston.c b/hw/mips/boston.c index d2ab9da1a0..759f6daafe 100644 --- a/hw

[PATCH v4 3/6] hw/riscv: use qemu_fdt_setprop_strings() for string arrays

Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify the code. Signed-off-by: Ben Dooks --- hw/riscv/sifive_u.c | 18 +- hw/riscv/spike.c| 7 ++- hw/riscv/virt.c | 32 3 files changed, 15 insertions(+), 42 deletions(-) diff

Re: [PATCH v3 3/5] hw/core: use qemu_fdt_setprop_strings()

On Mon, Aug 01, 2022 at 12:30:22PM +0100, Peter Maydell wrote: > On Wed, 27 Jul 2022 at 23:39, Ben Dooks wrote: > > > > Change to using the qemu_fdt_setprop_strings() helper in > > hw/core code. > > > > Signed-off-by: Ben Dooks > > --- > > Reviewed-

Re: [PATCH v3 5/5] hw/arm: change to use qemu_fdt_setprop_strings()

On Mon, Aug 01, 2022 at 12:37:33PM +0100, Peter Maydell wrote: > On Wed, 27 Jul 2022 at 23:44, Ben Dooks wrote: > > > > Change to using qemu_fdt_setprop_strings() instead of using > > \0 separated string arrays. > > > > Signed-off-by: Ben Dooks > >

Re: [PATCH v7 2/3] target/riscv: Add stimecmp support

; } +static RISCVException sstc(CPURISCVState *env, int csrno) +{ +CPUState *cs = env_cpu(env); +RISCVCPU *cpu = RISCV_CPU(cs); + +if (!cpu->cfg.ext_sstc || !env->rdtime_fn) { +return RISCV_EXCP_ILLEGAL_INST; +} + +if (env->priv == PRV_M) { + return R

Re: [PATCH v3 1/5] device_tree: add qemu_fdt_setprop_strings() helper

On Thu, Jul 28, 2022 at 11:22:27AM +0200, Andrew Jones wrote: > On Wed, Jul 27, 2022 at 11:39:01PM +0100, Ben Dooks wrote: > > Add a helper to set a property from a set of strings > > to reduce the following code: > > > > static const char * const clint_compat

Re: [PATCH v6 3/5] target/riscv: smstateen check for fcsr

p; has_ext(ctx, RVS)) {\eventually meaning +stateen &= sstateen; \ +} \ +if (!(stateen & SMSTATEEN0_FCSR)) { \ +return false; \ +} \ +} \ given the size of that I would have thought an "static inline" function would be easier to write and maintai

Re: add qemu_fdt_setprop_strings() and use it in most places

On Wed, Jul 27, 2022 at 11:39:00PM +0100, Ben Dooks wrote: > Add a helper for qemu_fdt_setprop_strings() to take a set of strings > to put into a device-tree, which removes several open-coded methods > such as setting an char arr[] = {..} or setting char val[] = "str\0str2";

[PATCH v3 4/5] hw/mips: use qemu_fdt_setprop_strings()

Change to using qemu_fdt_setprop_strings() helper in hw/mips. Signed-off-by: Ben Dooks --- hw/mips/boston.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/mips/boston.c b/hw/mips/boston.c index d2ab9da1a0..759f6daafe 100644 --- a/hw/mips/boston.c +++ b/hw/mips

[PATCH v3 2/5] hw/riscv: use qemu_fdt_setprop_strings() for string arrays

Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify the code. Signed-off-by: Ben Dooks --- hw/riscv/sifive_u.c | 18 +- hw/riscv/spike.c| 7 ++- hw/riscv/virt.c | 32 3 files changed, 15 insertions(+), 42 deletions(-) diff

add qemu_fdt_setprop_strings() and use it in most places

Add a helper for qemu_fdt_setprop_strings() to take a set of strings to put into a device-tree, which removes several open-coded methods such as setting an char arr[] = {..} or setting char val[] = "str\0str2"; This is for hw/arm, hw/mips and hw/riscv as well as a couple of cores. It is not fully

[PATCH v3 1/5] device_tree: add qemu_fdt_setprop_strings() helper

ompat, ARRAY_SIZE(clint_compat)); Signed-off-by: Ben Dooks --- v3; - fix return value for the call - add better help text v2: - fix node/path in comment --- include/sysemu/device_tree.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/sysemu/device_tree.h b/incl

[PATCH v3 5/5] hw/arm: change to use qemu_fdt_setprop_strings()

Change to using qemu_fdt_setprop_strings() instead of using \0 separated string arrays. Signed-off-by: Ben Dooks --- hw/arm/boot.c | 8 +++--- hw/arm/virt.c | 28 + hw/arm/xlnx-versal-virt.c | 51 --- 3 files

[PATCH v3 3/5] hw/core: use qemu_fdt_setprop_strings()

Change to using the qemu_fdt_setprop_strings() helper in hw/core code. Signed-off-by: Ben Dooks --- hw/core/guest-loader.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/hw/core/guest-loader.c b/hw/core/guest-loader.c index 391c875a29..203090503e 100644

Re: fu740 target

On 27/07/2022 15:38, Bin Meng wrote: On Wed, Jul 27, 2022 at 10:24 PM Ben Dooks wrote: Is anyone working on adding a sifive-u74 core to the list of supported CPU types? I was looking at full emulation of the Unmatched but at the moment the best we have is sifive-u54 and I think that misses

fu740 target

ome point to add to the current real-board testing we're doing. (I have a basic addition of the type and the two CSRs as a couple of patches if that would help as a start) -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear.

Re: updates for designware pci-host

On 27/07/2022 13:56, Peter Maydell wrote: On Wed, 27 Jul 2022 at 12:15, Ben Dooks wrote: On Wed, Jul 13, 2022 at 05:54:42PM +0100, Ben Dooks wrote: As part of a project we have been looking at using the DesignWare PCIe host. We found a few issues of missing features or small bugs when using

Re: updates for designware pci-host

On 27/07/2022 13:56, Peter Maydell wrote: On Wed, 27 Jul 2022 at 12:15, Ben Dooks wrote: On Wed, Jul 13, 2022 at 05:54:42PM +0100, Ben Dooks wrote: As part of a project we have been looking at using the DesignWare PCIe host. We found a few issues of missing features or small bugs when using

Re: updates for designware pci-host

On Wed, Jul 13, 2022 at 05:54:42PM +0100, Ben Dooks wrote: > As part of a project we have been looking at using the DesignWare > PCIe host. We found a few issues of missing features or small bugs > when using this with a recent Linux kernel (v5.17.x) > > Whilst doing this we al

Re: [PATCH v3 0/8] m25p80: Add SFDP support

ttps://lore.kernel.org/qemu-devel/20200902093107.608000-1-...@kaod.org/ Is there a git branch this could be pulled from to have a look at and test on our setup? -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear.

Re: [PATCH] gpio: designware gpio driver

On 18/07/2022 11:15, Peter Maydell wrote: On Mon, 18 Jul 2022 at 11:05, Ben Dooks wrote: On 13/07/2022 18:20, Ben Dooks wrote: A model for the DesignWare GPIO (v1) block. Is there anyone else who should be reviewing these that was missed off the original list? I'd like to get an idea

Re: [PATCH] gpio: designware gpio driver

On 13/07/2022 18:20, Ben Dooks wrote: A model for the DesignWare GPIO (v1) block. Is there anyone else who should be reviewing these that was missed off the original list? I'd like to get an idea if there is any work to do. I've got a couple more drivers to submit and was waiting on feedback

Re: [PATCH 1/7] pci: designware: add 64-bit viewport limit

On 13/07/2022 17:54, Ben Dooks wrote: Versions 4 and above add support for 64-bit viewport limit. Add support for the DESIGNWARE_PCIE_ATU_UPPER_LIMIT regiser where supported. Signed-off-by: Ben Dooks Whoops, just noticed this was my old ct address. --- hw/pci-host/designware.c

[PATCH 4/7] pci: designware: ignore new bits in ATU CR1

In version 4 and anver ATU CR1 has more bits in it than just the viewport type. Make a guess at masking these out to avoid issues where Linux writes these bits and fails to enable memory ATUs. Signed-off-by: Ben Dooks --- hw/pci-host/designware.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 5/7] pci: designware: move msi to entry 5

The driver should leave irq[0..3] for INT[A..D] but seems to put the MSI IRQ at entry 3 which should also be INT_D. Extend the irqs[] array to 5 entires and put the MSI at entry irqs[4]. Signed-off-by: Ben Dooks --- hw/pci-host/designware.c | 2 +- include/hw/pci-host/designware.h | 2

[PATCH 1/7] pci: designware: add 64-bit viewport limit

Versions 4 and above add support for 64-bit viewport limit. Add support for the DESIGNWARE_PCIE_ATU_UPPER_LIMIT regiser where supported. Signed-off-by: Ben Dooks --- hw/pci-host/designware.c | 22 +- include/hw/pci-host/designware.h | 2 +- 2 files changed, 18

[PATCH 2/7] pci: designware: fix DESIGNWARE_PCIE_ATU_UPPER_TARGET

By inspection DESIGNWARE_PCIE_ATU_UPPER_TARGET should be writing to the upper 32-bits of viewport->target, so fix this by shifting the 32-bit value before the or. Signed-off-by: Ben Dooks --- hw/pci-host/designware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/

[PATCH 3/7] pci: designware: clamp viewport index

. Signed-off-by: Ben Dooks --- hw/pci-host/designware.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c index d213d7324c..6403416634 100644 --- a/hw/pci-host/designware.c +++ b/hw/pci-host/designware.c @@ -345,6 +345,10 @@ static void

updates for designware pci-host

As part of a project we have been looking at using the DesignWare PCIe host. We found a few issues of missing features or small bugs when using this with a recent Linux kernel (v5.17.x) Whilst doing this we also made a start on some tracing events.

[PATCH 6/7] pci: designware: correct host's class_id

This is a host to pcie bridge, so use PCI_CLASS_BRIDGE_HOST for the class. Signed-off-by: Ben Dooks --- hw/pci-host/designware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c index b5d5b2b8a5..a47ae48071 100644 --- a/hw

[PATCH 7/7] pci: designware: add initial tracing events

Add a couple of tracing events for internal driver updates Signed-off-by: Ben Dooks --- hw/pci-host/designware.c | 4 hw/pci-host/trace-events | 4 2 files changed, 8 insertions(+) diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c index a47ae48071..489959513f 100644

[PATCH] gpio: designware gpio driver

A model for the DesignWare GPIO (v1) block. Signed-off-by: Ben Dooks --- hw/gpio/Kconfig | 3 + hw/gpio/designware_gpio.c | 327 ++ hw/gpio/meson.build | 1 + hw/gpio/trace-events | 7 + include/hw/gpio

Re: [PATCH 4/4] hw/riscv: use qemu_fdt_setprop_strings() in sifive_u.c

On Mon, Jun 20, 2022 at 04:47:44PM +1000, Alistair Francis wrote: > On Sun, Jun 19, 2022 at 6:14 AM Ben Dooks wrote: > > > > Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify > > the code. > > > > Signed-off-by: Ben Dooks > > Do you mind updatin

[PATCH 3/4] device_tree: add qemu_fdt_setprop_strings() helper

ompat, ARRAY_SIZE(clint_compat)); Signed-off-by: Ben Dooks -- v2: - fix node/path in comment --- include/sysemu/device_tree.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/sysemu/device_tree.h b/include/sysemu/device_tree.h index 79ce009a22..28b68bacaf 100644 --- a/incl

[v2] pair of device-tree helpers

I've been doing a bit of looking at riscv and dt creation, and was thinking the following two helper functions would be useful so implemented qemu_fdt_setprop_reg64_map() and qemu_fdt_setprop_strings() and then applied them to the hw/riscv/sifive_u.c

[PATCH 1/4] device_tree: add qemu_fdt_setprop_reg64_map helper

); Signed-off-by: Ben Dooks -- v2: - changed qemu_fdt_setprop_reg64 to qemu_fdt_setprop_reg64_map --- include/sysemu/device_tree.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/sysemu/device_tree.h b/include/sysemu/device_tree.h index ef060a9759..79ce009

[PATCH 2/4] hw/riscv: use qemu_fdt_setprop_reg64_map() in sifive_u.c

Use the qemu_fdt_setprop_reg64_map() to replace the code that sets the property manually. Signed-off-by: Ben Dooks -- v2: - changed to qemu_fdt_setprop_reg64_map() from previous --- hw/riscv/sifive_u.c | 41 +++-- 1 file changed, 11 insertions(+), 30

[PATCH 4/4] hw/riscv: use qemu_fdt_setprop_strings() in sifive_u.c

Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify the code. Signed-off-by: Ben Dooks --- hw/riscv/sifive_u.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index 89d7aa2a52..16b18d90bd 100644 --- a/hw

Re: [PATCH 4/4] hw/riscv: use qemu_fdt_setprop_strings() in sifive_u.c

On Fri, Apr 22, 2022 at 10:19:34AM +0800, Bin Meng wrote: > On Mon, Apr 18, 2022 at 5:13 AM Ben Dooks wrote: > > > > Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify > > the code. > > > > Signed-off-by; Ben Dooks > > ; should be replaced to :

Re: [PATCH 4/4] hw/riscv: use qemu_fdt_setprop_strings() in sifive_u.c

On Sat, Apr 16, 2022 at 08:30:34PM +0100, Ben Dooks wrote: > Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify > the code. > > Signed-off-by; Ben Dooks > --- > hw/riscv/sifive_u.c | 20 +++- > 1 file changed, 7 insertions(+), 13 deletions(-) >

[PATCH 2/4] hw/riscv: use qemu_fdt_setprop_reg64() in sifive_u.c

Use the qemu_fdt_setprop_reg64() to replace the code that sets the property manually. Signed-off-by: Ben Dooks --- hw/riscv/sifive_u.c | 41 +++-- 1 file changed, 11 insertions(+), 30 deletions(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index

[PATCH 4/4] hw/riscv: use qemu_fdt_setprop_strings() in sifive_u.c

Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify the code. Signed-off-by; Ben Dooks --- hw/riscv/sifive_u.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index 1fe364cbb0..b00086d86e 100644 --- a/hw

[PATCH 3/4] device_tree: add qemu_fdt_setprop_strings() helper

ompat, ARRAY_SIZE(clint_compat)); Signed-off-by: Ben Dooks --- include/sysemu/device_tree.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/sysemu/device_tree.h b/include/sysemu/device_tree.h index 28352e7fcb..6ad09564d7 100644 --- a/include/sysemu/device_tree.h +++

A couple of new device-tree helpers.

I've been doing a bit of looking at riscv and dt creation, and was thinking the following two helper functions would be useful so implemented qemu_fdt_setprop_reg64() and qemu_fdt_setprop_strings() and then applied them to the hw/riscv/sifive_u.c machine. I thought I should get a review in before

[PATCH 1/4] device_tree: add qemu_fdt_setprop_reg64 helper

Signed-off-by: Ben Dooks --- include/sysemu/device_tree.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/sysemu/device_tree.h b/include/sysemu/device_tree.h index ef060a9759..28352e7fcb 100644 --- a/include/sysemu/device_tree.h +++ b/include/sysemu/device_tree.h

[Qemu-devel] Re: FYI: Qemu support on s5pc110

On Sun, Jun 06, 2010 at 02:03:39PM +0900, Kyungmin Park wrote: Dear all, FYI: My team release the qemu support on s5pc110 at http://en.sourceforge.jp/projects/sfnet_slp-emulator/ Interesting, any plans on merginging it back into qemu? You can find a s5pc110 files at hw directories.