[PATCH v3] tests/functional: Convert most Aspeed machine tests

2024-10-18 Thread Cédric Le Goater
. Signed-off-by: Cédric Le Goater --- Changes in v3: - Removed test_arm_aspeed_emmc_boot from avocado tests - Placed the tests in alphabetical order in the meson.build file - Used LinuxKernelTest instead of QemuSystemTest to inherit from wait_for_console_pattern method - Placed set_machine

Re: [PATCH RFC 0/5] hw/cxl: Type 2 Device RFC

2024-10-17 Thread Cédric Le Goater
Hello, On 5/18/23 04:45, Ira Weiny wrote: Type 2 devices are not yet a reality. Developing core kernel support is difficult without some test device to model against. Define a type 2 device 'cxl-accel'. This device is derived from the type 3 device and retains all that functionality for now.

Re: [PATCH v2] tests/functional: Convert most Aspeed machine tests

2024-10-17 Thread Cédric Le Goater
On 10/17/24 08:06, Thomas Huth wrote: On 16/10/2024 22.38, Cédric Le Goater wrote: This is a simple conversion of the tests with some cleanups and adjustments to match the new test framework. Replace the zephyr image MD5 hashes with SHA256 hashes while at it. The SDK tests depend on a ssh

Re: [PATCH] crypto/hash-afalg: Fix broken build

2024-10-16 Thread Cédric Le Goater
catch this at compile time, nor did CI. Reviewed-by: Cédric Le Goater Thanks, C. --- crypto/hash-afalg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/crypto/hash-afalg.c b/crypto/hash-afalg.c index 06e1e4699c..8c0ce5b520 100644 --- a/crypto/hash-afalg.c

[PATCH v2] tests/functional: Convert most Aspeed machine tests

2024-10-16 Thread Cédric Le Goater
. Signed-off-by: Cédric Le Goater --- Changes in v2: - define class level Asset variables tests/avocado/machine_aspeed.py | 252 - tests/functional/meson.build| 2 + tests/functional/test_arm_aspeed.py | 277 3 files changed, 279

[PATCH] tests/functional: Convert most Aspeed machine tests

2024-10-16 Thread Cédric Le Goater
. Signed-off-by: Cédric Le Goater --- tests/avocado/machine_aspeed.py | 252 -- tests/functional/meson.build| 2 + tests/functional/test_arm_aspeed.py | 269 3 files changed, 271 insertions(+), 252 deletions(-) create mode 100644 tests

Re: [PATCH] hw/sd/sdcard: Allow user creation of eMMCs

2024-10-15 Thread Cédric Le Goater
On 10/15/24 17:20, Daniel P. Berrangé wrote: On Tue, Oct 15, 2024 at 05:17:26PM +0200, Cédric Le Goater wrote: On 10/15/24 17:00, Philippe Mathieu-Daudé wrote: On 15/10/24 10:56, Jan Luebbe wrote: For testing eMMC-specific functionality (such as handling boot partitions), it would be very

Re: [PATCH] hw/sd/sdcard: Allow user creation of eMMCs

2024-10-15 Thread Cédric Le Goater
On 10/15/24 17:00, Philippe Mathieu-Daudé wrote: On 15/10/24 10:56, Jan Luebbe wrote: For testing eMMC-specific functionality (such as handling boot partitions), it would be very useful to attach them to generic VMs such as x86_64 via the sdhci-pci device:   ...   -drive if=none,id=emmc-drive,fi

Re: [PATCH v6] hw/misc/aspeed_hace: Fix SG Accumulative hashing

2024-10-15 Thread Cédric Le Goater
On 10/15/24 02:52, Andrew Jeffery wrote: On Sat, 2024-10-12 at 08:20 +0200, Cédric Le Goater wrote: + Aspeed reviewers. Sorry about that. All good. Seems sensible in concept and from a cursory glance, so if you want to tack it on: Acked-by: Andrew Jeffery Thanks Andrew, Now I wonder, if

Re: [PATCH v4 13/13] ppc/spapr: remove deprecated machine pseries-2.12

2024-10-15 Thread Cédric Le Goater
are now turned useless. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora --- docs/about/deprecated.rst | 8 include/hw/ppc/spapr_cpu_core.h | 1 - target/ppc/cpu.h| 4 hw/ppc/spapr.c | 25 - hw

Re: [PATCH v4 12/13] ppc/spapr: remove deprecated machine pseries-2.12-sxxm

2024-10-15 Thread Cédric Le Goater
On 10/14/24 14:27, Harsh Prateek Bora wrote: Commit 0cac0f1b964 marked pseries-2.12 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.12-sxxm specific code with this patch. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora Reviewed-by

Re: [PATCH] ppc/pnv: Add support for TPM with SPI interface

2024-10-14 Thread Cédric Le Goater
Hello Dan, On 10/14/24 02:08, dan tan wrote: Hi Cédric, Thank you for the review comments. Please see my response below. thank you, --- dan tan power simulation phone:+1.7373.099.138 email:dan...@linux.ibm.com On 2024-09-12 12:20, Cédric Le Goater wrote: Hello Dan, On 9/12/24 18:09, dan

Re: [PATCH v16 04/13] s390x/pci: Avoid creating zpci for VFs

2024-10-14 Thread Cédric Le Goater
Hello Akihiko, On 10/12/24 13:05, Akihiko Odaki wrote: On 2024/10/11 0:44, Cédric Le Goater wrote: Hello Akihiko, Sorry for the late reply. On 9/18/24 17:32, Akihiko Odaki wrote: On 2024/09/18 17:02, Cédric Le Goater wrote: Hello, On 9/13/24 05:44, Akihiko Odaki wrote: VFs are

Re: [PATCH v6] hw/misc/aspeed_hace: Fix SG Accumulative hashing

2024-10-11 Thread Cédric Le Goater
+ Aspeed reviewers. Sorry about that. C. On 10/11/24 07:38, Cédric Le Goater wrote: From: Alejandro Zeise Make the Aspeed HACE module use the new qcrypto accumulative hashing functions when in scatter-gather accumulative mode. A hash context will maintain a "running-hash" as ea

Re: [PATCH v2 00/17] Multifd 🔀 device state transfer support with VFIO consumer

2024-10-11 Thread Cédric Le Goater
Hello Maciej, On 8/27/24 19:54, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" This is an updated v2 patch series of the v1 series located here: https://lore.kernel.org/qemu-devel/cover.1718717584.git.maciej.szmigi...@oracle.com/ Changes from v1: * Extended the QEMU thread-pool with n

Re: [PATCH v3 03/14] ppc/spapr: remove deprecated machine pseries-2.3

2024-10-10 Thread Cédric Le Goater
introduced to disable it by default for legacy machines until pseries-2.3. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/pci-host/spapr.h | 1 - hw/ppc/spapr.c | 15 --- hw/ppc

Re: [PATCH v3 04/14] ppc/spapr: remove deprecated machine pseries-2.4

2024-10-10 Thread Cédric Le Goater
turned useless. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/ppc/spapr.h | 1 - hw/ppc/spapr.c | 38 -- 2 files changed, 4 insertions(+), 35 deletions(-) diff

Re: [PATCH v3 05/14] ppc/spapr: remove deprecated machine pseries-2.5

2024-10-10 Thread Cédric Le Goater
. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/ppc/spapr.h | 1 - hw/ppc/spapr.c | 25 + 2 files changed, 1 insertion(+), 25 deletions(-) diff --git a/include/hw/ppc/spapr.h b

Re: [PATCH v3 13/14] ppc/spapr: remove deprecated machine pseries-2.12

2024-10-10 Thread Cédric Le Goater
are now turned useless. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora --- docs/about/deprecated.rst | 8 include/hw/ppc/spapr_cpu_core.h | 1 - target/ppc/cpu.h| 4 hw/ppc/spapr.c | 25 - hw

Re: [PATCH v3 12/14] ppc/spapr: remove deprecated machine pseries-2.12-sxxm

2024-10-10 Thread Cédric Le Goater
On 10/7/24 17:38, Harsh Prateek Bora wrote: Commit 0cac0f1b964 marked pseries-2.12 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.12-sxxm specific code with this patch. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora --- hw/ppc/spapr.c

Re: [PATCH v3 14/14] ppc/spapr: remove deprecated machine pseries-3.0

2024-10-10 Thread Cédric Le Goater
s/master/about/deprecated.html [2] https://lore.kernel.org/qemu-devel/1d7c210e-d7a6-4233-b555-c99a41f3c...@kaod.org/ While at it, also remove related legacy irq hacks which are now obsolete. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora I induced you in error. This version has

[PATCH v6] hw/misc/aspeed_hace: Fix SG Accumulative hashing

2024-10-10 Thread Cédric Le Goater
hub.com/openbmc/qemu/issues/36 Signed-off-by: Alejandro Zeise [ clg: - Checkpatch fixes - Reworked qcrypto_hash*() error reports in do_hash_operation() ] Signed-off-by: Cédric Le Goater --- Changes in v6: - Reworked qcrypto_hash*() error reports in do_hash_operation() include/hw/misc

Re: [PATCH v16 04/13] s390x/pci: Avoid creating zpci for VFs

2024-10-10 Thread Cédric Le Goater
Hello Akihiko, Sorry for the late reply. On 9/18/24 17:32, Akihiko Odaki wrote: On 2024/09/18 17:02, Cédric Le Goater wrote: Hello, On 9/13/24 05:44, Akihiko Odaki wrote: VFs are automatically created by PF, and creating zpci for them will result in unexpected usage of fids. Currently QEMU

Re: [PATCH v5 05/16] crypto/hash-nettle: Implement new hash API

2024-10-10 Thread Cédric Le Goater
On 10/10/24 13:43, Daniel P. Berrangé wrote: On Thu, Oct 10, 2024 at 11:49:22AM +0100, Daniel P. Berrangé wrote: On Tue, Oct 08, 2024 at 09:57:12AM +0200, Cédric Le Goater wrote: From: Alejandro Zeise Implements the new hashing API in the nettle hash driver. Supports creating/destroying a

Re: [PATCH v5 00/16] hw/misc/aspeed_hace: Fix SG Accumulative Hash Calculations

2024-10-10 Thread Cédric Le Goater
On 10/10/24 13:28, Daniel P. Berrangé wrote: On Tue, Oct 08, 2024 at 09:57:07AM +0200, Cédric Le Goater wrote: Hello, This is a resping of Alejandro's series fixing SG Accumulative Hash Calculations. See [1] for more details. The goal of this patch series is to fix accumulative ha

Re: [PATCH v3] tests/qtest: Add XIVE tests for the powernv10 machine

2024-10-09 Thread Cédric Le Goater
g_assert_cmphex(qw2w2, ==, be32_to_cpu(cl_word)); +g_assert_cmphex(qw3b8, ==, +cl_pair[XIVE_ODD_CL + TM_QW3_HV_PHYS + TM_WORD2]); + +/* Verify that all TIMA valid bits for target thread are cleared */ +word2 = get_tima32(qts, target_pir, TM_QW1_OS + TM_WORD2); +g_asser

Re: [PATCH-for-9.2 v3 0/3] hw/ssi/pnv_spi: Remove PnvXferBuffer and get_seq_index()

2024-10-08 Thread Cédric Le Goater
On 10/8/24 09:43, Nicholas Piggin wrote: On Thu Sep 19, 2024 at 2:50 AM AEST, Chalapathi V wrote: Hello, v3: 1. Update the PowerNV maintainer section to include hw/ssi/pnv_spi* 2. Use of PnvXferBuffer results in a additonal process overhead due to frequent dynamic allocations and hence use an e

Re: [PATCH v5 00/16] hw/misc/aspeed_hace: Fix SG Accumulative Hash Calculations

2024-10-08 Thread Cédric Le Goater
On 10/8/24 09:57, Cédric Le Goater wrote: Hello, This is a resping of Alejandro's series fixing SG Accumulative Hash Calculations. See [1] for more details. arf. [1] https://lore.kernel.org/all/20240807195122.2827364-1-alejandro.ze...@seagate.com/ C. The goal of this patch series

[PATCH v5 12/16] crypto/hash-gnutls: Remove old hash API functions

2024-10-08 Thread Cédric Le Goater
From: Alejandro Zeise Removes old hash implementation in the gnutls hash driver. Signed-off-by: Alejandro Zeise Reviewed-by: Daniel P. Berrangé [ clg: - Fixed spelling in commit log ] Signed-off-by: Cédric Le Goater --- crypto/hash-gnutls.c | 47

[PATCH v5 10/16] crypto/hash-glib: Remove old hash API functions

2024-10-08 Thread Cédric Le Goater
From: Alejandro Zeise Removes old hash implement-ion in the GLib hash driver. Signed-off-by: Alejandro Zeise Reviewed-by: Daniel P. Berrangé [ clg: - Fixed spelling in commit log ] Signed-off-by: Cédric Le Goater --- crypto/hash-glib.c | 53 -- 1

[PATCH v5 08/16] crypto/hash: Implement and use new hash API

2024-10-08 Thread Cédric Le Goater
ts() check in qcrypto_hash_new() - Introduced g_autofree variables in qcrypto_hash_finalize_digest() and qcrypto_hash_finalize_base64() - Re-arrranged code in qcrypto_hash_digestv() and qcrypto_hash_digest() - Checkpatch fixes ] Signed-off-by: Cédric Le Goater

[PATCH v5 01/16] crypto: accumulative hashing API

2024-10-08 Thread Cédric Le Goater
more in line with the hmac API. Signed-off-by: Alejandro Zeise [ clg: - Changed documentation "non-zero on error" -> "-1 on error" ] Signed-off-by: Cédric Le Goater --- crypto/hashpriv.h | 13 + include/crypto/hash.h | 119 ++ 2

[PATCH v5 14/16] crypto/hash-afalg: Remove old hash API functions

2024-10-08 Thread Cédric Le Goater
From: Alejandro Zeise Removes the old hash API functions in the afalg driver, and modifies the hmac function to use the new helper functions. Signed-off-by: Alejandro Zeise Reviewed-by: Daniel P. Berrangé [ clg: - Checkpatch fixes ] Signed-off-by: Cédric Le Goater --- crypto/hash-afalg.c

[PATCH v5 16/16] hw/misc/aspeed_hace: Fix SG Accumulative hashing

2024-10-08 Thread Cédric Le Goater
hub.com/openbmc/qemu/issues/36 Signed-off-by: Alejandro Zeise [ clg: - Checkpatch fixes ] Signed-off-by: Cédric Le Goater --- include/hw/misc/aspeed_hace.h | 4 ++ hw/misc/aspeed_hace.c | 96 +++ 2 files changed, 56 insertions(+), 44 deletions(-) diff --g

[PATCH v5 07/16] crypto/hash-afalg: Implement new hash API

2024-10-08 Thread Cédric Le Goater
qcrypto_afalg_hash_ctx_new() errors in qcrypto_afalg_hash_new() - Freed alg_name in qcrypto_afalg_hash_new() - Reworked qcrypto_afalg_recv_from_kernel() - Split iov changes from original patch ] Signed-off-by: Cédric Le Goater --- crypto/hash-afalg.c | 127

[PATCH v5 04/16] crypto/hash-gnutls: Implement new hash API

2024-10-08 Thread Cédric Le Goater
qcrypto_gnutls_hash_free() ] Signed-off-by: Cédric Le Goater --- crypto/hash-gnutls.c | 78 1 file changed, 78 insertions(+) diff --git a/crypto/hash-gnutls.c b/crypto/hash-gnutls.c index 0636c0727a93..8b0327be82cf 100644 --- a/crypto/hash-gnutls.c +++ b/crypto/hash

[PATCH v5 09/16] tests/unit/test-crypto-hash: accumulative hashing

2024-10-08 Thread Cédric Le Goater
From: Alejandro Zeise Added an accumulative hashing test. Checks for functionality of the new hash create, update, finalize and free functions. Signed-off-by: Alejandro Zeise [ clg: - Improved test_hash_accumulate() with g_autofree variables ] Signed-off-by: Cédric Le Goater --- tests/unit

[PATCH v5 06/16] util/iov: Introduce iov_send_recv_with_flags()

2024-10-08 Thread Cédric Le Goater
[ clg: - Split iov changes from original patch - Checkpatch fixes ] Signed-off-by: Cédric Le Goater --- include/qemu/iov.h | 27 +++ util/iov.c | 25 ++--- 2 files changed, 45 insertions(+), 7 deletions(-) diff --git a/include/qemu/iov.h b

[PATCH v5 13/16] crypto/hash-nettle: Remove old hash API functions

2024-10-08 Thread Cédric Le Goater
From: Alejandro Zeise Removes old hash implementation in the nettle hash driver. Signed-off-by: Alejandro Zeise Reviewed-by: Daniel P. Berrangé [ clg: - Fixed spelling in commit log ] Signed-off-by: Cédric Le Goater --- crypto/hash-nettle.c | 53

[PATCH v5 11/16] crypto/hash-gcrypt: Remove old hash API functions

2024-10-08 Thread Cédric Le Goater
From: Alejandro Zeise Removes old hash implementation in the gcrypt hash driver. Signed-off-by: Alejandro Zeise Reviewed-by: Daniel P. Berrangé [ clg: - Fixed spelling in commit log ] Signed-off-by: Cédric Le Goater --- crypto/hash-gcrypt.c | 67

[PATCH v5 15/16] crypto/hashpriv: Remove old hash API function

2024-10-08 Thread Cédric Le Goater
From: Alejandro Zeise Remove old hash_bytesv function, as it was replaced by the 4 new functions. Signed-off-by: Alejandro Zeise Reviewed-by: Daniel P. Berrangé --- crypto/hashpriv.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/crypto/hashpriv.h b/crypto/hashpriv.h index dcb3ba6cf

[PATCH v5 03/16] crypto/hash-gcrypt: Implement new hash API

2024-10-08 Thread Cédric Le Goater
() - Reworked qcrypto_gcrypt_hash_finalize() - Handled gcry_md_open() errors in qcrypto_gcrypt_hash_new() - Checkpatch fixes ] Signed-off-by: Cédric Le Goater --- crypto/hash-gcrypt.c | 79 1 file changed, 79 insertions(+) diff --git a

[PATCH v5 00/16] hw/misc/aspeed_hace: Fix SG Accumulative Hash Calculations

2024-10-08 Thread Cédric Le Goater
Hello, This is a resping of Alejandro's series fixing SG Accumulative Hash Calculations. See [1] for more details. The goal of this patch series is to fix accumulative hashing support in the Aspeed HACE module. The issue that stemmed this patch was a failure to boot an OpenBMC image using the "a

[PATCH v5 02/16] crypto/hash-glib: Implement new hash API

2024-10-08 Thread Cédric Le Goater
() - Removed superfluous cast (GChecksum *) in qcrypto_glib_hash_free() - Reworked qcrypto_glib_hash_finalize() ] Signed-off-by: Cédric Le Goater --- crypto/hash-glib.c | 67 ++ 1 file changed, 67 insertions(+) diff --git a/crypto/hash-glib.c b/crypto

[PATCH v5 05/16] crypto/hash-nettle: Implement new hash API

2024-10-08 Thread Cédric Le Goater
() ] Signed-off-by: Cédric Le Goater --- crypto/hash-nettle.c | 70 1 file changed, 70 insertions(+) diff --git a/crypto/hash-nettle.c b/crypto/hash-nettle.c index 8b08a9c67531..07e18ce26cba 100644 --- a/crypto/hash-nettle.c +++ b/crypto/hash-nettle.c @@ -1,6

Re: [PATCH v2] tests/qtest: Add XIVE tests for the powernv10 machine

2024-10-03 Thread Cédric Le Goater
On 9/25/24 20:05, Michael Kowal wrote: From: Frederic Barrat These XIVE tests include: - General interrupt IRQ tests that: - enable and trigger an interrupt - acknowledge the interrupt - end of interrupt processing - Test the Pull Thread Context to Odd Thread Reporting Line - Test the

Re: [PATCH v2 00/11] ppc/spapr: remove deprecated machines specific code

2024-10-02 Thread Cédric Le Goater
Hello Harsh On 10/3/24 07:16, Harsh Prateek Bora wrote: Hi Cedric, On 10/2/24 12:26, Cédric Le Goater wrote: Hello Harsh, On 10/1/24 11:28, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log

Re: [PATCH v2 00/11] ppc/spapr: remove deprecated machines specific code

2024-10-01 Thread Cédric Le Goater
Hello Harsh, On 10/1/24 11:28, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing the arch specific code for the now deprecated machine types. v2: Addressed review comments from Cedric v1: <2

Re: [PATCH v2 11/11] ppc/spapr: remove deprecated machine pseries-2.11

2024-10-01 Thread Cédric Le Goater
On 10/1/24 11:29, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.11 specific code with this patch. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora Reviewed

Re: [PATCH v2 10/11] ppc/spapr: remove deprecated machine pseries-2.10

2024-10-01 Thread Cédric Le Goater
On 10/1/24 11:29, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.10 specific code with this patch for now. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora

Re: [PATCH v2 09/11] ppc/spapr: remove deprecated machine pseries-2.9

2024-10-01 Thread Cédric Le Goater
On 10/1/24 11:29, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.9 specific code with this patch for now. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora

Re: [PATCH v2 08/11] ppc/spapr: remove deprecated machine pseries-2.8

2024-10-01 Thread Cédric Le Goater
On 10/1/24 11:29, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.8 specific code with this patch for now. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora

Re: [PATCH v2 07/11] ppc/spapr: remove deprecated machine pseries-2.7

2024-10-01 Thread Cédric Le Goater
backward migration compatibility. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora Nice ! Acked-by: Cédric Le Goater Thanks, C. --- include/hw/pci-host/spapr.h | 4 -- target/ppc/cpu.h| 5 --- hw/ppc/spapr.c | 75

Re: [PATCH v2 06/11] ppc/spapr: remove deprecated machine pseries-2.6

2024-10-01 Thread Cédric Le Goater
On 10/1/24 11:29, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.6 specific code with this patch for now. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora

Re: [PATCH v2 05/11] ppc/spapr: remove deprecated machine pseries-2.5

2024-10-01 Thread Cédric Le Goater
On 10/1/24 11:29, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.5 specific code with this patch for now. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora

Re: [PATCH v2 04/11] ppc/spapr: remove deprecated machine pseries-2.4

2024-10-01 Thread Cédric Le Goater
On 10/1/24 11:29, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.4 specific code with this patch for now. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora

Re: [PATCH v2 03/11] ppc/spapr: remove deprecated machine pseries-2.3

2024-10-01 Thread Cédric Le Goater
On 10/1/24 11:29, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.3 specific code with this patch for now. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora

Re: [PATCH v2 02/11] ppc/spapr: remove deprecated machine pseries-2.2

2024-10-01 Thread Cédric Le Goater
On 10/1/24 11:29, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.2 specific code with this patch for now. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora

Re: [PATCH v2 01/11] ppc/spapr: remove deprecated machine pseries-2.1

2024-10-01 Thread Cédric Le Goater
On 10/1/24 11:29, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.1 specific code with this patch for now. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora

Re: [SPAM] [PATCH v7 0/8] Support GPIO for AST2700

2024-10-01 Thread Cédric Le Goater
On 10/1/24 04:43, Jamin Lin wrote: v1: Support GPIO for AST2700 v2: Fix clear incorrect interrupt status and adds reviewer suggestions v3: Remove nested conditionals and adds reviewer suggestions v4: Add test cases to test GPIO for AST2700 and update commit messages v5: Fix aspeed_gpio-test test

Re: [PATCH v7 0/8] Support GPIO for AST2700

2024-10-01 Thread Cédric Le Goater
On 10/1/24 11:43, Jamin Lin wrote: Hi all, Subject: [PATCH v7 0/8] Support GPIO for AST2700 I don't know why I send this patch series failed to the following email addresses and got the following errors. open list:All patches CC here open list:ASPEED BMCs 2024/10/1 上午 06:43:04 - Server a

Re: [PATCH v6 8/8] hw/gpio/aspeed: Add test case for AST2700

2024-09-30 Thread Cédric Le Goater
On 9/30/24 18:36, Thomas Huth wrote: On 30/09/2024 10.52, Jamin Lin wrote: Add test case to test GPIO output and input pins from A0 to D7 for AST2700. Signed-off-by: Jamin Lin ---   tests/qtest/aspeed_gpio-test.c | 77 --   tests/qtest/meson.build    |  3 ++

Re: [SPAM] [PATCH v6 7/8] aspeed/soc: Support GPIO for AST2700

2024-09-30 Thread Cédric Le Goater
On 9/30/24 10:52, Jamin Lin wrote: Add GPIO model for AST2700 GPIO support. The GPIO controller registers base address is start at 0x14C0_B000 and its address space is 0x1000. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed_ast27x0.c | 13

Re: [SPAM] [PATCH v6 6/8] aspeed/soc: Correct GPIO irq 130 for AST2700

2024-09-30 Thread Cédric Le Goater
Le Goater Thanks, C. --- hw/arm/aspeed_ast27x0.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 761ee11657..99135edc1e 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -87,8 +87,7

Re: [PATCH v3 0/6] Support GPIO for AST2700

2024-09-27 Thread Cédric Le Goater
On 9/27/24 08:29, Jamin Lin wrote: Also, your emails have an invalid "From" field set to "qemu-devel@nongnu.org" when retrieved with the b4 command. I have been fixing them for a while. Could you please tell us how you send the patchsets ? hmm, curious. I wonder what's happening. Thanks, C.

Re: [PATCH v5 6/7] aspeed/soc: Support GPIO for AST2700 and correct irq 130

2024-09-27 Thread Cédric Le Goater
Hello Jamin, On 9/27/24 10:33, Jamin Lin wrote: The register set of GPIO have a significant change since AST2700. Each GPIO pin has their own individual control register and users are able to set one GPIO pin’s direction, interrupt enable, input mask and so on in the same one control register.

Re: [PATCH v3 0/6] Support GPIO for AST2700

2024-09-26 Thread Cédric Le Goater
Hello Jamin, Could you please to add tests in tests/qtest/aspeed_gpio-test.c for this changes ? At least one with the ast2700-evb machine if possible. Will add Thanks for the effort. I appreciate. Also, your emails have an invalid "From" field set to "qemu-devel@nongnu.org" when retrieved w

Re: [PATCH v3 2/6] hw/gpio/aspeed: Support to set the different memory size

2024-09-26 Thread Cédric Le Goater
default and it does not compatible register space for AST2700. Introduce a new class attribute to set the GPIO controller memory size for different ASPEED SOCs. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/gpio/aspeed_gpio.c | 7 ++- include/hw

Re: [RFC 0/1] Introduce vfio-cxl to support CXL type-2 device passthrough

2024-09-26 Thread Cédric Le Goater
Hello Zhi, On 9/21/24 09:14, Zhi Wang wrote: Compute Express Link (CXL) is an open standard interconnect built upon industrial PCI layers to enhance the performance and efficiency of data centers by enabling high-speed, low-latency communication between CPUs and various types of devices such as

Re: [PATCH v3 3/6] hw/gpio/aspeed: Support different memory region ops

2024-09-26 Thread Cédric Le Goater
ed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/gpio/aspeed_gpio.c | 7 ++- include/hw/gpio/aspeed_gpio.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c index 564459ad4f..8725606aec

Re: [PATCH v3 0/6] Support GPIO for AST2700

2024-09-26 Thread Cédric Le Goater
Hello Jamin, On 9/26/24 09:45, Jamin Lin wrote: v1: Support GPIO for AST2700 v2: Fix clear incorrect interrupt status and adds reviewer suggestions v3: remove nested conditionals and adds reviewer suggestions Jamin Lin (6): hw/gpio/aspeed: Fix coding style hw/gpio/aspeed: Support to set t

Re: [PATCH v3 6/6] aspeed/soc: Support GPIO for AST2700

2024-09-26 Thread Cédric Le Goater
On 9/26/24 09:45, Jamin Lin wrote: Add GPIO model for AST2700 GPIO support. The GPIO controller registers base address is start at 0x14C0_B000 and its address space is 0x1000. The AST2700 GPIO controller interrupt is connected to GICINT130_INTC at bit 18. Signed-off-by: Jamin Lin ---> hw/arm

Re: [PATCH v3 1/6] hw/gpio/aspeed: Fix coding style

2024-09-26 Thread Cédric Le Goater
On 9/26/24 09:45, Jamin Lin wrote: Fix coding style issues from checkpatch.pl Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/gpio/aspeed_gpio.c | 6 +++--- include/hw/gpio/aspeed_gpio.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions

Re: [PATCH] MAINTAINERS: Add myself as maintainer of e500 machines

2024-09-26 Thread Cédric Le Goater
On 9/26/24 09:59, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- MAINTAINERS | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index ffacd60f40..0a191a03db 100644 --- a

Re: [PATCH 22/23] hw/usb/hcd-ehci-sysbus: Prefer DEFINE_TYPES() macro

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/usb/hcd-ehci-sysbus.c | 118 +-- 1 file changed, 50 insertions(+), 68 deletions(-) diff --git a/hw/usb/hcd-ehci-sysbus.c b

Re: [PATCH 21/23] hw/rtc/ds1338: Prefer DEFINE_TYPES() macro

2024-09-25 Thread Cédric Le Goater
Sob is missing. Thanks, C. On 9/23/24 11:30, Bernhard Beschow wrote: --- hw/rtc/ds1338.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/hw/rtc/ds1338.c b/hw/rtc/ds1338.c index a5fe221418..6de13caf99 100644 --- a/hw/rtc/ds1338.c +++ b/hw/rtc/ds1338

Re: [PATCH 20/23] hw/i2c/smbus_eeprom: Prefer DEFINE_TYPES() macro

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/i2c/smbus_eeprom.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index

Re: [PATCH 19/23] hw/block/pflash_cfi01: Prefer DEFINE_TYPES() macro

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/block/pflash_cfi01.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c

Re: [PATCH 18/23] hw/sd/sdhci: Prefer DEFINE_TYPES() macro

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sdhci.c | 62 +-- 1 file changed, 26 insertions(+), 36 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd

Re: [PATCH 16/23] hw/net/fsl_etsec/etsec: Prefer DEFINE_TYPES() macro

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/net/fsl_etsec/etsec.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec

Re: [PATCH 17/23] hw/intc: Guard openpic_kvm.c by dedicated OPENPIC_KVM Kconfig switch

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Allows to clearly mark code sections relying on this device type. Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/ppc/e500.c | 2 +- hw/intc/Kconfig | 4 hw/intc/meson.build | 3 +-- 3 files

Re: [PATCH 14/23] hw/gpio/mpc8xxx: Prefer DEFINE_TYPES() macro

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/gpio/mpc8xxx.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/gpio/mpc8xxx.c b/hw/gpio/mpc8xxx.c index 63b7a5c881

Re: [PATCH 15/23] hw/ppc/mpc8544_guts: Prefer DEFINE_TYPES() macro

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/ppc/mpc8544_guts.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/hw/ppc/mpc8544_guts.c b/hw/ppc/mpc8544_guts.c index

Re: [PATCH 13/23] hw/pci-host/ppce500: Prefer DEFINE_TYPES() macro

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/pci-host/ppce500.c | 42 ++ 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/hw/pci-host/ppce500.c b/hw

Re: [PATCH 10/23] hw/i2c/mpc_i2c: Convert DPRINTF to trace events for register access

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/i2c/mpc_i2c.c| 9 + hw/i2c/trace-events | 5 + 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/i2c/mpc_i2c.c b/hw/i2c

Re: [PATCH 11/23] hw/i2c/mpc_i2c: Prefer DEFINE_TYPES() macro

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/i2c/mpc_i2c.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/hw/i2c/mpc_i2c.c b/hw/i2c/mpc_i2c.c index 3d79c15653

Re: [PATCH 05/23] hw/ppc/e500: Add missing device tree properties to i2c controller node

2024-09-25 Thread Cédric Le Goater
tree properties. Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Thanks, C. --- hw/ppc/e500.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 228287b457..e2a4f265a5 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -196,6 +196,8

Re: [PATCH 02/23] hw/ppc/e500: Reduce scope of env pointer

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:29, Bernhard Beschow wrote: The env pointer isn't used outside the for loop, so move it inside. After that, the firstenv pointer is never read, so remove it. Just wondering, have you considered introducing an PowerPCCPU array under the machine state ? This would be an intermediat

Re: [PATCH 01/23] hw/ppc/e500: Do not leak struct boot_info

2024-09-25 Thread Cédric Le Goater
On 9/23/24 11:29, Bernhard Beschow wrote: The struct is allocated once with g_new0() but never free()'d. Fix the leakage by adding an attribute to struct PPCE500MachineState which avoids the allocation. Signed-off-by: Bernhard Beschow --- hw/ppc/e500.h | 8 hw/ppc/e500.c | 17 -

Re: [PATCH 23/23] hw/vfio/platform: Let vfio_start_eventfd_injection() take VFIOPlatformDevice pointer

2024-09-24 Thread Cédric Le Goater
On 9/23/24 11:30, Bernhard Beschow wrote: Avoids one downcast, making the code more type-safe. Signed-off-by: Bernhard Beschow That's a bit unrelated to your e500 series. Anyhow, Reviewed-by: Cédric Le Goater Thanks, C. --- hw/vfio/platform.c | 7 +++ 1 file chang

Re: [PATCH 00/23] E500 Cleanup

2024-09-24 Thread Cédric Le Goater
On 9/23/24 23:25, Bernhard Beschow wrote: Am 23. September 2024 20:23:54 UTC schrieb "Cédric Le Goater" : Hello Bernhard, Hi Cédric, On 9/23/24 11:29, Bernhard Beschow wrote: This series is part of a bigger series exploring data-driven machine creation using device tree blobs

Re: [PATCH 00/23] E500 Cleanup

2024-09-23 Thread Cédric Le Goater
Hello Bernhard, On 9/23/24 11:29, Bernhard Beschow wrote: This series is part of a bigger series exploring data-driven machine creation using device tree blobs on top of the e500 machines [1]. It contains patches to make this exploration easier which are also expected to provide value in themsel

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

2024-09-20 Thread Cédric Le Goater
Hello Clément, Unless I'm wrong this patch has not been queued yet. Is there any reason for this ? I don't think there was a PPC PR yet. We are just starting the QEMU 9.2 cycle [*]. Since this is a fix that applies on older releases, may be we could have a PR in not too long. Thanks, C. [*]

Re: [PATCH] tests/functional: Convert the powernv tests from boot_linux_console.py

2024-09-20 Thread Cédric Le Goater
On 9/20/24 17:03, Thomas Huth wrote: Move the tests into the already existing test_ppc64_powernv.py file. Signed-off-by: Thomas Huth Reviewed-by: Cédric Le Goater Thanks, C. --- Based-on: 20240919185749.71222-1-th...@redhat.com tests/avocado/boot_linux_console.py| 46

Re: [PATCH] tests/qtest: Add XIVE tests for the powernv10 machine

2024-09-18 Thread Cédric Le Goater
Hello, On 9/16/24 20:23, Michael Kowal wrote: From: Frederic Barrat These XIVE tests include: - General interrupt IRQ tests that: - enable and trigger an interrupt - acknowledge the interrupt - end of interrupt processing - Test the Pull Thread Context to Odd Thread Reporting Line - Te

Re: [PATCH v16 04/13] s390x/pci: Avoid creating zpci for VFs

2024-09-18 Thread Cédric Le Goater
Hello, On 9/13/24 05:44, Akihiko Odaki wrote: VFs are automatically created by PF, and creating zpci for them will result in unexpected usage of fids. Currently QEMU does not support multifunction for s390x so we don't need zpci for VFs anyway. Signed-off-by: Akihiko Odaki --- hw/s390x/s390-

Re: [PATCH v16 02/13] hw/ppc/spapr_pci: Do not create DT for disabled PCI device

2024-09-18 Thread Cédric Le Goater
Hello, Adding : Harsh for QEMU/PPC pseries machine, Shivaprasad for KVM/PPC VFIO and IOMMU support. Could you please give us your feedback on these changes ? Thanks, C. On 9/13/24 05:44, Akihiko Odaki wrote: Disabled means it is a disabled SR-IOV VF or it is powered off, and hidden

Re: [PATCH v16 03/13] hw/ppc/spapr_pci: Do not reject VFs created after a PF

2024-09-18 Thread Cédric Le Goater
Adding : Harsh for QEMU/PPC pseries machine, Shivaprasad for KVM/PPC VFIO and IOMMU support. Thanks, C. On 9/13/24 05:44, Akihiko Odaki wrote: A PF may automatically create VFs and the PF may be function 0. Signed-off-by: Akihiko Odaki --- hw/ppc/spapr_pci.c | 4 +++- 1 file changed

Re: [PATCH v2 12/17] migration/multifd: Device state transfer support - send side

2024-09-17 Thread Cédric Le Goater
[ ... ] I as a patch writer always like to do that when it's essential. Normally the case is I don't have enough reviewer resources to help me get a better design, or discuss about it. Right, but we can't keep providing a moving target. See the thread pool discussion for an example. It's hard

[PULL 4/8] vfio/igd: use new BDSM register location and size for gen 11 and later

2024-09-17 Thread Cédric Le Goater
From: Corvin Köhne Intel changed the location and size of the BDSM register for gen 11 devices and later. We have to adjust our emulation for these devices to properly support them. Signed-off-by: Corvin Köhne Reviewed-by: Alex Williamson --- hw/vfio/igd.c | 31 ---

<    1   2   3   4   5   6   7   8   9   10   >