Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Montag, 15. November 2021 12:54:32 CET Stefan Hajnoczi wrote: > On Thu, Nov 11, 2021 at 06:54:03PM +0100, Christian Schoenebeck wrote: > > On Donnerstag, 11. November 2021 17:31:52 CET Stefan Hajnoczi wrote: > > > On Wed, Nov 10, 2021 at 04:53:33PM +0100, Christian Schoenebeck

Re: [PATCH] audio: Add sndio backend

On Samstag, 13. November 2021 21:40:39 CET Brad Smith wrote: > On 11/8/2021 8:03 AM, Christian Schoenebeck wrote: > > On Sonntag, 7. November 2021 06:19:26 CET Brad Smith wrote: > >> audio: Add sndio backend > >> > >> Add a sndio backend. > > > >

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Donnerstag, 11. November 2021 17:31:52 CET Stefan Hajnoczi wrote: > On Wed, Nov 10, 2021 at 04:53:33PM +0100, Christian Schoenebeck wrote: > > On Mittwoch, 10. November 2021 16:14:19 CET Stefan Hajnoczi wrote: > > > On Wed, Nov 10, 2021 at 02:14:43PM +0100, Christian

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Mittwoch, 10. November 2021 16:14:19 CET Stefan Hajnoczi wrote: > On Wed, Nov 10, 2021 at 02:14:43PM +0100, Christian Schoenebeck wrote: > > On Mittwoch, 10. November 2021 11:05:50 CET Stefan Hajnoczi wrote: > > As you are apparently reluctant for changing the virtio sp

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

ce gain is the minimum latency involved per request, and like I said, that can be improved to a certain extent with 9p, but that will take a long time and it could not be eliminated entirely. As you are apparently reluctant for changing the virtio specs, what about introducing those discussed virtio capabalities either as experimental ones without specs changes, or even just as 9p specific device capabilities for now. I mean those could be revoked on both sides at any time anyway. Best regards, Christian Schoenebeck

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Dienstag, 9. November 2021 11:56:35 CET Stefan Hajnoczi wrote: > On Thu, Nov 04, 2021 at 03:41:23PM +0100, Christian Schoenebeck wrote: > > On Mittwoch, 3. November 2021 12:33:33 CET Stefan Hajnoczi wrote: > > > On Mon, Nov 01, 2021 at 09:29:26PM +0100, Christian Schoenebeck

Re: [PATCH] audio: Add sndio backend

On Sonntag, 7. November 2021 06:19:26 CET Brad Smith wrote: > audio: Add sndio backend > > Add a sndio backend. Hi Brad! > sndio is the native API used by OpenBSD, although it has been ported to > other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.). > > The C code is from Ale

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Mittwoch, 3. November 2021 12:33:33 CET Stefan Hajnoczi wrote: > On Mon, Nov 01, 2021 at 09:29:26PM +0100, Christian Schoenebeck wrote: > > On Donnerstag, 28. Oktober 2021 11:00:48 CET Stefan Hajnoczi wrote: > > > On Mon, Oct 25, 2021 at 05:03:25PM +0200, Christian Schoenebeck

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Donnerstag, 28. Oktober 2021 11:00:48 CET Stefan Hajnoczi wrote: > On Mon, Oct 25, 2021 at 05:03:25PM +0200, Christian Schoenebeck wrote: > > On Montag, 25. Oktober 2021 12:30:41 CEST Stefan Hajnoczi wrote: > > > On Thu, Oct 21, 2021 at 05:39:28PM +0200, Christian Schoenebeck

Re: [PATCH] MAINTAINERS: add myself as partial audio reviewer

On Samstag, 4. September 2021 15:13:46 CEST Christian Schoenebeck wrote: > Volunteering as reviewer for some of the audio backends; namely > ALSA, CoreAudio and JACK. > > Signed-off-by: Christian Schoenebeck > --- > MAINTAINERS | 3 +++ > 1 file changed, 3 insertions

Re: [PULL 0/8] 9p queue 2021-10-27

On Mittwoch, 27. Oktober 2021 20:44:52 CEST Richard Henderson wrote: > On 10/27/21 10:29 AM, Christian Schoenebeck wrote: > > On Mittwoch, 27. Oktober 2021 18:48:10 CEST Philippe Mathieu-Daudé wrote: > >> On 10/27/21 18:21, Christian Schoenebeck wrote: > >>> On Mittw

Re: [PULL 0/8] 9p queue 2021-10-27

On Mittwoch, 27. Oktober 2021 18:48:10 CEST Philippe Mathieu-Daudé wrote: > On 10/27/21 18:21, Christian Schoenebeck wrote: > > On Mittwoch, 27. Oktober 2021 17:36:03 CEST Philippe Mathieu-Daudé wrote: > >> Hi Christian, > >> > >> On 10/27/21 16:05, Christian

Re: [PULL 0/8] 9p queue 2021-10-27

On Mittwoch, 27. Oktober 2021 17:36:03 CEST Philippe Mathieu-Daudé wrote: > Hi Christian, > > On 10/27/21 16:05, Christian Schoenebeck wrote: > > On Mittwoch, 27. Oktober 2021 15:18:33 CEST Christian Schoenebeck wrote: > >> The follow

Re: [PULL 0/8] 9p queue 2021-10-27

On Mittwoch, 27. Oktober 2021 15:18:33 CEST Christian Schoenebeck wrote: > The following changes since commit 931ce30859176f0f7daac6bac255dae5eb21284e: > > Merge remote-tracking branch 'remotes/dagrh/tags/pull-virtiofs-20211026' > into staging (2021-10-26 07:38:41 -0700)

[PULL 8/8] 9pfs: use P9Array in v9fs_walk()

Signed-off-by: Christian Schoenebeck Message-Id: <90c65d1c1ca11c1b434bb981b1fc7966f7711c8f.1633097129.git.qemu_...@crudebyte.com> --- hw/9pfs/9p.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 15bb16f466..15b3

[PULL 7/8] 9pfs: make V9fsPath usable via P9Array API

Signed-off-by: Christian Schoenebeck Message-Id: <79a0ddf8375f6c95f0565ef155a1bf1e9387664f.1633097129.git.qemu_...@crudebyte.com> --- fsdev/file-op-9p.h | 2 ++ hw/9pfs/9p.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h index 42f6

[PULL 6/8] 9pfs: make V9fsString usable via P9Array API

Signed-off-by: Christian Schoenebeck Message-Id: --- fsdev/9p-marshal.c | 2 ++ fsdev/9p-marshal.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c index a01bba6908..51881fe220 100644 --- a/fsdev/9p-marshal.c +++ b/fsdev/9p-marshal.c @@ -18,6

[PULL 4/8] 9pfs: introduce P9Array

might have construed a conflict for other projects. Signed-off-by: Christian Schoenebeck Message-Id: --- fsdev/p9array.h | 154 1 file changed, 154 insertions(+) create mode 100644 fsdev/p9array.h diff --git a/fsdev/p9array.h b/fsdev/p9array.

[PULL 1/8] 9pfs: fix wrong I/O block size in Rgetattr

h adds stat_to_iounit() with a similar approach as the existing get_iounit() function. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: --- hw/9pfs/9p.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index

[PULL 3/8] 9pfs: simplify blksize_to_iounit()

Use QEMU_ALIGN_DOWN() macro to reduce code and to make it more human readable. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé Message-Id: --- hw/9pfs/9p.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PULL 2/8] 9pfs: deduplicate iounit code

Remove redundant code that translates host fileystem's block size into 9p client (guest side) block size. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: <129bb71d5119e61d335f1e3107e472e4beea223a.1632758315.git.qemu_...@crudebyte.com> --- hw/9pf

[PULL 0/8] 9p queue 2021-10-27

e on guest due to previously incorrect block size being transmitted to 9p client. * Subsequent patches are cleanup ones intended to reduce code complexity. ---- Christian Schoenebeck (8): 9pfs: fix wrong I/O block size in Rgetattr

[PULL 5/8] fsdev/p9array.h: check scalar type in P9ARRAY_NEW()

Make sure at compile time that the scalar type of the array requested to be created via P9ARRAY_NEW() matches the scalar type of the passed auto reference variable (unique pointer). Suggested-by: Richard Henderson Signed-off-by: Christian Schoenebeck Message-Id: --- fsdev/p9array.h | 6

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Montag, 25. Oktober 2021 12:30:41 CEST Stefan Hajnoczi wrote: > On Thu, Oct 21, 2021 at 05:39:28PM +0200, Christian Schoenebeck wrote: > > On Freitag, 8. Oktober 2021 18:08:48 CEST Christian Schoenebeck wrote: > > > On Freitag, 8. Oktober 2021 16:24:42 CEST Christian

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Freitag, 8. Oktober 2021 18:08:48 CEST Christian Schoenebeck wrote: > On Freitag, 8. Oktober 2021 16:24:42 CEST Christian Schoenebeck wrote: > > On Freitag, 8. Oktober 2021 09:25:33 CEST Greg Kurz wrote: > > > On Thu, 7 Oct 2021 16:42:49 +0100 > > > > > > St

Re: [PATCH 00/11] 9p: Add support for Darwin

ct much of a problem to bring this series through. I will have a closer look on v2 though. I also have to read the old discussions where I was not involved yet. Soft freeze for QEMU 6.2 is close BTW (November 2nd): https://wiki.qemu.org/Planning/6.2 Best regards, Christian Schoenebeck

Re: [PATCH 00/64] Patch Round-up for stable 6.0.1, freeze on 2021-10-26

On Dienstag, 19. Oktober 2021 17:26:38 CEST Greg Kurz wrote: > On Tue, 19 Oct 2021 16:52:37 +0200 > > Christian Schoenebeck wrote: > > On Dienstag, 19. Oktober 2021 16:08:40 CEST Michael Roth wrote: > > > Hi everyone, > > > > > > The following new

Re: [PATCH 00/64] Patch Round-up for stable 6.0.1, freeze on 2021-10-26

f83df00900816476cca41bb536e4d532b297d76e 9pfs: fix crash in v9fs_walk() Best regards, Christian Schoenebeck

Re: [PATCH 0/5] 9pfs: introduce P9Array

On Freitag, 1. Oktober 2021 16:25:22 CEST Christian Schoenebeck wrote: > This is simply a refactored follow-up of the following previous series > ("introduce QArray"): > https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg04530.html > > There was no consensus abo

Re: [PATCH 00/11] 9p: Add support for Darwin

challenging, especially with macOS 11 and higher. But I see that's nothing you were into. > On Thu, Oct 14, 2021 at 7:57 AM Christian Schoenebeck < > > qemu_...@crudebyte.com> wrote: > > On Donnerstag, 14. Oktober 2021 12:48:55 CEST Will Cohen wrote: > > > Man

Re: [PATCH 00/11] 9p: Add support for Darwin

ublish as v2. So the intended use case is macOS being host. Has this been tested, and if yes, using which 9p client and which macOS version? Best regards, Christian Schoenebeck

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Freitag, 8. Oktober 2021 16:24:42 CEST Christian Schoenebeck wrote: > On Freitag, 8. Oktober 2021 09:25:33 CEST Greg Kurz wrote: > > On Thu, 7 Oct 2021 16:42:49 +0100 > > > > Stefan Hajnoczi wrote: > > > On Thu, Oct 07, 2021 at 02:51:55PM +0200, Christian

Re: [PATCH v2 1/3] virtio: turn VIRTQUEUE_MAX_SIZE into a variable

On Donnerstag, 7. Oktober 2021 17:18:03 CEST Stefan Hajnoczi wrote: > On Thu, Oct 07, 2021 at 03:09:16PM +0200, Christian Schoenebeck wrote: > > On Mittwoch, 6. Oktober 2021 16:42:34 CEST Stefan Hajnoczi wrote: > > > On Wed, Oct 06, 2021 at 02:50:07PM +0200, Christian Schoenebeck

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Freitag, 8. Oktober 2021 09:25:33 CEST Greg Kurz wrote: > On Thu, 7 Oct 2021 16:42:49 +0100 > > Stefan Hajnoczi wrote: > > On Thu, Oct 07, 2021 at 02:51:55PM +0200, Christian Schoenebeck wrote: > > > On Donnerstag, 7. Oktober 2021 07:23:59 CEST Stefan Hajnoczi wrote

Re: [PATCH v2 1/3] virtio: turn VIRTQUEUE_MAX_SIZE into a variable

On Mittwoch, 6. Oktober 2021 16:42:34 CEST Stefan Hajnoczi wrote: > On Wed, Oct 06, 2021 at 02:50:07PM +0200, Christian Schoenebeck wrote: > > On Mittwoch, 6. Oktober 2021 13:06:55 CEST Stefan Hajnoczi wrote: > > > On Tue, Oct 05, 2021 at 06:32:46PM +0200, Christian Schoenebeck

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Donnerstag, 7. Oktober 2021 07:23:59 CEST Stefan Hajnoczi wrote: > On Mon, Oct 04, 2021 at 09:38:00PM +0200, Christian Schoenebeck wrote: > > At the moment the maximum transfer size with virtio is limited to 4M > > (1024 * PAGE_SIZE). This series raises this limit to its maximum

Re: [PATCH v2 1/3] virtio: turn VIRTQUEUE_MAX_SIZE into a variable

On Mittwoch, 6. Oktober 2021 13:06:55 CEST Stefan Hajnoczi wrote: > On Tue, Oct 05, 2021 at 06:32:46PM +0200, Christian Schoenebeck wrote: > > On Dienstag, 5. Oktober 2021 17:10:40 CEST Stefan Hajnoczi wrote: > > > On Tue, Oct 05, 2021 at 03:15:26PM +0200, Christian Schoenebeck

Re: [PATCH v2 1/3] virtio: turn VIRTQUEUE_MAX_SIZE into a variable

On Dienstag, 5. Oktober 2021 17:10:40 CEST Stefan Hajnoczi wrote: > On Tue, Oct 05, 2021 at 03:15:26PM +0200, Christian Schoenebeck wrote: > > On Dienstag, 5. Oktober 2021 14:45:56 CEST Stefan Hajnoczi wrote: > > > On Mon, Oct 04, 2021 at 09:38:04PM +0200, Christian

Re: [PATCH v2 1/3] virtio: turn VIRTQUEUE_MAX_SIZE into a variable

On Dienstag, 5. Oktober 2021 14:45:56 CEST Stefan Hajnoczi wrote: > On Mon, Oct 04, 2021 at 09:38:04PM +0200, Christian Schoenebeck wrote: > > Refactor VIRTQUEUE_MAX_SIZE to effectively become a runtime > > variable per virtio user. > > virtio user == virtio device mod

Re: [PATCH v2 2/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Dienstag, 5. Oktober 2021 13:24:36 CEST Michael S. Tsirkin wrote: > On Tue, Oct 05, 2021 at 01:17:59PM +0200, Christian Schoenebeck wrote: > > On Dienstag, 5. Oktober 2021 09:16:07 CEST Michael S. Tsirkin wrote: > > > On Mon, Oct 04, 2021 at 09:38:08PM +0200, Christian

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Dienstag, 5. Oktober 2021 13:19:43 CEST Michael S. Tsirkin wrote: > On Tue, Oct 05, 2021 at 01:10:56PM +0200, Christian Schoenebeck wrote: > > On Dienstag, 5. Oktober 2021 09:38:53 CEST David Hildenbrand wrote: > > > On 04.10.21 21:38, Christian Schoenebeck wrote: > &g

Re: [PATCH v2 2/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Dienstag, 5. Oktober 2021 09:16:07 CEST Michael S. Tsirkin wrote: > On Mon, Oct 04, 2021 at 09:38:08PM +0200, Christian Schoenebeck wrote: > > Raise the maximum possible virtio transfer size to 128M > > (more precisely: 32k * PAGE_SIZE). See previous commit for a > > more

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Dienstag, 5. Oktober 2021 09:38:53 CEST David Hildenbrand wrote: > On 04.10.21 21:38, Christian Schoenebeck wrote: > > At the moment the maximum transfer size with virtio is limited to 4M > > (1024 * PAGE_SIZE). This series raises this limit to its maximum > > theoretical p

Re: virtio 4M limit

On Montag, 4. Oktober 2021 21:59:18 CEST Michael S. Tsirkin wrote: > On Mon, Oct 04, 2021 at 12:44:21PM +0200, Christian Schoenebeck wrote: > > On Sonntag, 3. Oktober 2021 22:27:03 CEST Michael S. Tsirkin wrote: > > > On Sun, Oct 03, 2021 at 08:14:55PM +0200, Christian

[PATCH v2 2/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

VIRTQUEUE_LEGACY_MAX_SIZE macro by an appropriate value supported by them. Signed-off-by: Christian Schoenebeck --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/vhost-user-blk.c | 6 +++--- hw/block/virtio-blk.c | 6 +++--- hw/char/virtio-serial-bus.c| 2 +- hw/input

[PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

users, preserve the old value of 1k for all virtio users unless they explicitly opted in: https://lists.gnu.org/archive/html/qemu-devel/2021-10/msg00056.html Christian Schoenebeck (3): virtio: turn VIRTQUEUE_MAX_SIZE into a variable virtio: increase VIRTQUEUE_MAX_SIZE to 32k virtio-9

[PATCH v2 1/3] virtio: turn VIRTQUEUE_MAX_SIZE into a variable

ing a corresponding value with virtio_init() call. Signed-off-by: Christian Schoenebeck --- hw/9pfs/virtio-9p-device.c | 3 ++- hw/block/vhost-user-blk.c | 2 +- hw/block/virtio-blk.c | 3 ++- hw/char/virtio-serial-bus.c| 2 +- hw/display/virtio-gpu-base.c | 2 +- hw/input/v

[PATCH v2 3/3] virtio-9p-device: switch to 32k max. transfer size

client minus 2 pages). Signed-off-by: Christian Schoenebeck --- hw/9pfs/virtio-9p-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 9013e7df6e..cd5d95dd51 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw

Re: virtio 4M limit

On Sonntag, 3. Oktober 2021 22:27:03 CEST Michael S. Tsirkin wrote: > On Sun, Oct 03, 2021 at 08:14:55PM +0200, Christian Schoenebeck wrote: > > On Freitag, 1. Oktober 2021 13:21:23 CEST Christian Schoenebeck wrote: > > > Hi Michael, > > > > > > while te

[PATCH] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

-240006 Signed-off-by: Christian Schoenebeck --- include/hw/virtio/virtio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index 8bab9cfb75..1f18efa0bc 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio

Re: virtio 4M limit

On Freitag, 1. Oktober 2021 13:21:23 CEST Christian Schoenebeck wrote: > Hi Michael, > > while testing the following kernel patches I realized there is currently a > size limitation of 4 MB with virtio on QEMU side: > https://lore.kernel.org/netdev/cover.1632327421.git.linux_..

Re: [PATCH 1/5] 9pfs: introduce P9Array

On Freitag, 1. Oktober 2021 17:16:47 CEST Daniel P. Berrangé wrote: > On Fri, Oct 01, 2021 at 04:26:17PM +0200, Christian Schoenebeck wrote: > > Implements deep auto free of arrays while retaining common C-style > > squared bracket access. Main purpose of this API is to get rid of

[PATCH 2/5] fsdev/p9array.h: check scalar type in P9ARRAY_NEW()

Make sure at compile time that the scalar type of the array requested to be created via P9ARRAY_NEW() matches the scalar type of the passed auto reference variable (unique pointer). Suggested-by: Richard Henderson Signed-off-by: Christian Schoenebeck --- fsdev/p9array.h | 6 ++ 1 file

[PATCH 4/5] 9pfs: make V9fsPath usable via P9Array API

Signed-off-by: Christian Schoenebeck --- fsdev/file-op-9p.h | 2 ++ hw/9pfs/9p.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h index 42f677cf38..8fd89f0447 100644 --- a/fsdev/file-op-9p.h +++ b/fsdev/file-op-9p.h @@ -18,6 +18,7 @@ #include

[PATCH 5/5] 9pfs: use P9Array in v9fs_walk()

Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index e432c4c007..27c4b8ba78 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -1707,13 +1707,14 @@ static void coroutine_fn

[PATCH 3/5] 9pfs: make V9fsString usable via P9Array API

Signed-off-by: Christian Schoenebeck --- fsdev/9p-marshal.c | 2 ++ fsdev/9p-marshal.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c index a01bba6908..51881fe220 100644 --- a/fsdev/9p-marshal.c +++ b/fsdev/9p-marshal.c @@ -18,6 +18,8

[PATCH 1/5] 9pfs: introduce P9Array

might have construed a conflict for other projects. Signed-off-by: Christian Schoenebeck --- fsdev/p9array.h | 154 1 file changed, 154 insertions(+) create mode 100644 fsdev/p9array.h diff --git a/fsdev/p9array.h b/fsdev/p9array.h new file mode 1

[PATCH 0/5] 9pfs: introduce P9Array

rray* -> *P9Array* * Refactored P9ARRAY_CREATE -> P9ARRAY_NEW and p9array_create_* -> p9array_new_* accordingly * Refactored DECLARE_P9ARRAY_TYPE -> P9ARRAY_DECLARE_TYPE * Refactored DEFINE_P9ARRAY_TYPE -> P9ARRAY_DEFINE_TYPE [No behaviour changes whatsoever] Chr

virtio 4M limit

t? And as I am not too familiar with the virtio protocol, is that current limit already visible to guest side? Because obviously it would make sense if I change my kernel patches so that they automatically limit to whatever QEMU supports instead of causing a hang. Best regards, Christian Schoenebeck

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

On Donnerstag, 30. September 2021 16:01:38 CEST Daniel P. Berrangé wrote: > On Thu, Sep 30, 2021 at 03:55:36PM +0200, Christian Schoenebeck wrote: > > On Donnerstag, 30. September 2021 15:31:10 CEST Daniel P. Berrangé wrote: > > > On Thu, Sep 30, 2021 at 03:20:19PM +0200, Chr

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

On Donnerstag, 30. September 2021 15:31:10 CEST Daniel P. Berrangé wrote: > On Thu, Sep 30, 2021 at 03:20:19PM +0200, Christian Schoenebeck wrote: > > On Mittwoch, 29. September 2021 19:48:38 CEST Daniel P. Berrangé wrote: > > > On Wed, Sep 29, 2021 at 07:32:39PM +0200, Christian

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

On Mittwoch, 29. September 2021 19:48:38 CEST Daniel P. Berrangé wrote: > On Wed, Sep 29, 2021 at 07:32:39PM +0200, Christian Schoenebeck wrote: > > On Dienstag, 28. September 2021 18:41:17 CEST Daniel P. Berrangé wrote: > > > On Tue, Sep 28, 2021 at 06:23:23PM +0200, Christian

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

On Dienstag, 28. September 2021 18:41:17 CEST Daniel P. Berrangé wrote: > On Tue, Sep 28, 2021 at 06:23:23PM +0200, Christian Schoenebeck wrote: > > On Dienstag, 28. September 2021 15:04:36 CEST Daniel P. Berrangé wrote: > > > On Sun, Aug 22, 2021 at 03:16:46PM +0200, Christian

Re: [PATCH v3 0/5] introduce QArray

On Dienstag, 28. September 2021 15:37:45 CEST Alex Bennée wrote: > Christian Schoenebeck writes: > > On Montag, 27. September 2021 12:59:40 CEST Greg Kurz wrote: > >> On Mon, 27 Sep 2021 12:35:16 +0200 > >> > >> Christian Schoenebeck wrote: > >>

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

On Dienstag, 28. September 2021 15:04:36 CEST Daniel P. Berrangé wrote: > On Sun, Aug 22, 2021 at 03:16:46PM +0200, Christian Schoenebeck wrote: > > Implements deep auto free of arrays while retaining common C-style > > squared bracket access. > > > > Signed-of

Re: [PATCH v3 0/5] introduce QArray

On Montag, 27. September 2021 12:59:40 CEST Greg Kurz wrote: > On Mon, 27 Sep 2021 12:35:16 +0200 > > Christian Schoenebeck wrote: > > On Dienstag, 31. August 2021 14:25:04 CEST Christian Schoenebeck wrote: > > > On Dienstag, 31. August 2021 13:58:02 CEST Greg Kurz wrote

Re: [PATCH 0/2] 9pfs: iounit cleanup

On Montag, 27. September 2021 17:44:59 CEST Christian Schoenebeck wrote: > Two pure refactoring code cleanup patches regarding iounit calculation, no > behaviour change. > > Christian Schoenebeck (2): > 9pfs: deduplicate iounit code > 9pfs: simplify blksize_to_iounit() >

Re: [PATCH 1/2] 9pfs: deduplicate iounit code

On Montag, 27. September 2021 18:27:59 CEST Greg Kurz wrote: > On Mon, 27 Sep 2021 17:45:00 +0200 > > Christian Schoenebeck wrote: > > Remove redundant code that translates host fileystem's block > > size into 9p client (guest side) block size. > > > >

[PATCH 1/2] 9pfs: deduplicate iounit code

Remove redundant code that translates host fileystem's block size into 9p client (guest side) block size. Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p.c | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/hw/9pfs/9p.c b/hw

[PATCH 2/2] 9pfs: simplify blksize_to_iounit()

Use QEMU_ALIGN_DOWN() macro to reduce code and to make it more human readable. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index c65584173a

[PATCH 0/2] 9pfs: iounit cleanup

Two pure refactoring code cleanup patches regarding iounit calculation, no behaviour change. Christian Schoenebeck (2): 9pfs: deduplicate iounit code 9pfs: simplify blksize_to_iounit() hw/9pfs/9p.c | 41 +++-- 1 file changed, 19 insertions(+), 22

Re: [PATCH v3 0/5] introduce QArray

On Dienstag, 31. August 2021 14:25:04 CEST Christian Schoenebeck wrote: > On Dienstag, 31. August 2021 13:58:02 CEST Greg Kurz wrote: > > On Thu, 26 Aug 2021 14:47:26 +0200 > > > > Christian Schoenebeck wrote: > > > Patches 1 and 2 introduce include/qemu/qa

Re: [PATCH] 9pfs: fix wrong I/O block size in Rgetattr

On Donnerstag, 23. September 2021 10:40:58 CEST Greg Kurz wrote: > On Wed, 22 Sep 2021 17:55:02 +0200 > > Christian Schoenebeck wrote: > > On Mittwoch, 22. September 2021 17:42:08 CEST Philippe Mathieu-Daudé wrote: > > > On 9/22/21 15:13, Christian Schoenebeck wrote: &g

Re: [PATCH] 9pfs: fix wrong I/O block size in Rgetattr

On Mittwoch, 22. September 2021 17:42:08 CEST Philippe Mathieu-Daudé wrote: > On 9/22/21 15:13, Christian Schoenebeck wrote: > > When client sent a 9p Tgetattr request then the wrong I/O block > > size value was returned by 9p server; instead of host file > > system'

[PATCH] 9pfs: fix wrong I/O block size in Rgetattr

h adds stat_to_iounit() with a similar approach as the existing get_iounit() function. Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index c857b31321..708b030474 100644 --- a/h

[PATCH] MAINTAINERS: add myself as partial audio reviewer

Volunteering as reviewer for some of the audio backends; namely ALSA, CoreAudio and JACK. Signed-off-by: Christian Schoenebeck --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5d923a6544..f018c1891a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCH v3 07/28] hw/9pfs: Replace g_memdup() by g_memdup2()

ze = src->size; > -dst->data = g_memdup(src->data, src->size); > +dst->data = g_memdup2(src->data, src->size); > } > > int v9fs_name_to_path(V9fsState *s, V9fsPath *dirpath, src->size is actually just 16 bit (fsdev/file-op-9p.h): struct V9fsPath {

[PULL 3/3] 9pfs: fix crash in v9fs_walk()

html https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg00174.html Fixes: 8d6cb100731c4d28535adbf2a3c2d1f29be3fef4 Signed-off-by: Christian Schoenebeck Cc: qemu-sta...@nongnu.org Reviewed-by: Greg Kurz Message-Id: --- hw/9pfs/coth.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/9pfs/c

[PULL 0/3] 9p queue 2021-09-02

27; requests. * Two code cleanup patches. ---- Christian Schoenebeck (3): hw/9pfs: avoid 'path' copy in v9fs_walk() hw/9pfs: use g_autofree in v9fs_walk() where possible 9pfs: fix crash in v9fs_walk() hw/9pfs/9

[PULL 2/3] hw/9pfs: use g_autofree in v9fs_walk() where possible

Suggested-by: Greg Kurz Signed-off-by: Christian Schoenebeck Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Greg Kurz Message-Id: --- hw/9pfs/9p.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 4d642ab12a..c857b31321 100644

[PULL 1/3] hw/9pfs: avoid 'path' copy in v9fs_walk()

r was that in case of an error the respective 'pathes' element would not be filled. Right now this is not an issue as the v9fs_walk() function returns as soon as any error occurs. Suggested-by: Greg Kurz Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: <7dacbecf2

Re: [PATCH] 9pfs: fix crash in v9fs_walk()

On Mittwoch, 1. September 2021 18:47:21 CEST Greg Kurz wrote: > On Wed, 1 Sep 2021 18:15:10 +0200 > > Christian Schoenebeck wrote: > > v9fs_walk() utilizes the v9fs_co_run_in_worker({...}) macro to run the > > supplied fs driver code block on a background worker thread. >

[PATCH] 9pfs: fix crash in v9fs_walk()

html https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg00174.html Fixes: 8d6cb100731c4d28535adbf2a3c2d1f29be3fef4 Signed-off-by: Christian Schoenebeck Cc: qemu-sta...@nongnu.org --- hw/9pfs/coth.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/9pfs/coth.h b/hw/9pfs/coth.h index c512899

Re: 9pfs: Twalk crash

On Mittwoch, 1. September 2021 17:41:02 CEST Greg Kurz wrote: > On Wed, 01 Sep 2021 16:21:06 +0200 > > Christian Schoenebeck wrote: > > On Mittwoch, 1. September 2021 14:49:37 CEST Christian Schoenebeck wrote: > > > > > And it triggered, however I am not sur

Re: 9pfs: Twalk crash

On Mittwoch, 1. September 2021 14:49:37 CEST Christian Schoenebeck wrote: > > > And it triggered, however I am not sure if some of those functions I > > > asserted above are indeed allowed to be executed on a different thread > > > than main thread: > > >

Re: 9pfs: Twalk crash

x55a93717aee0 > > > > elem = 0x0 > > > > > > So this is v->elems[pdu->idx]... what's the value of pdu->idx ? > > > > In that originally posted core dump it was 113: > > > > #0 virtio_pdu_vunmarshal (pdu=0x55a93717cde8, offset=7, > > fmt=0x55a9352766d1 > > "ddw", ap=0x7f38a9ad9cd0) at ../hw/9pfs/virtio-9p-device.c:146 > > 146 ret = v9fs_iov_vunmarshal(elem->out_sg, elem->out_num, offset, > > 1, fmt, ap); > > [Current thread is 1 (Thread 0x7f3bddd2ac40 (LWP 7811))] > > (gdb) p pdu->idx > > $1 = 113 > > Ok, so it is a valid index (not over MAX_REQ). So it would mean > that someone cleared the slot in our back ? Yes, the slot is within valid boundaries. Assertion checks for that in virtio-9p-device.c in future wouldn't hurt though. Best regards, Christian Schoenebeck

Re: 9pfs: Twalk crash

On Dienstag, 31. August 2021 12:57:49 CEST Greg Kurz wrote: > On Mon, 30 Aug 2021 17:55:04 +0200 > > Christian Schoenebeck wrote: > > Apparently commit 8d6cb100731c4d28535adbf2a3c2d1f29be3fef4 '9pfs: reduce > > latency of Twalk' has introduced occasional crashe

Re: [PATCH v3 0/5] introduce QArray

On Dienstag, 31. August 2021 13:58:02 CEST Greg Kurz wrote: > On Thu, 26 Aug 2021 14:47:26 +0200 > > Christian Schoenebeck wrote: > > Patches 1 and 2 introduce include/qemu/qarray.h which implements a deep > > auto free mechanism for arrays. See commit log of p

9pfs: Twalk crash

Apparently commit 8d6cb100731c4d28535adbf2a3c2d1f29be3fef4 '9pfs: reduce latency of Twalk' has introduced occasional crashes. My first impression after looking at the backtrace: looks like the patch itself is probably not causing this, but rather unmasked this issue (i.e. increased the chance t

[PATCH v3 5/5] 9pfs: use QArray in v9fs_walk()

Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index b59572fa79..9275c23df0 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -1707,13 +1707,14 @@ static void coroutine_fn

[PATCH v3 3/5] 9pfs: make V9fsString usable via QArray API

Signed-off-by: Christian Schoenebeck --- fsdev/9p-marshal.c | 2 ++ fsdev/9p-marshal.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c index a01bba6908..fbfc2a62cd 100644 --- a/fsdev/9p-marshal.c +++ b/fsdev/9p-marshal.c @@ -18,6 +18,8

[PATCH v3 2/5] qemu/qarray.h: check scalar type in QARRAY_CREATE()

Make sure at compile time that the scalar type of the array requested to be created via QARRAY_CREATE() matches the scalar type of the passed auto reference variable (unique pointer). Suggested-by: Richard Henderson Signed-off-by: Christian Schoenebeck --- include/qemu/qarray.h | 6 ++ 1

[PATCH v3 4/5] 9pfs: make V9fsPath usable via QArray API

Signed-off-by: Christian Schoenebeck --- fsdev/file-op-9p.h | 2 ++ hw/9pfs/9p.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h index 42f677cf38..7630f0e538 100644 --- a/fsdev/file-op-9p.h +++ b/fsdev/file-op-9p.h @@ -18,6 +18,7 @@ #include

[PATCH v3 0/5] introduce QArray

type check by using __builtin_types_compatible_p() instead of a weak check using sizeof() [patch 2]. Christian Schoenebeck (5): qemu/qarray.h: introduce QArray qemu/qarray.h: check scalar type in QARRAY_CREATE() 9pfs: make V9fsString usable via QArray API 9pfs: make V9fsPath usable via QArray API

[PATCH v3 1/5] qemu/qarray.h: introduce QArray

have construed a conflict for other projects. Signed-off-by: Christian Schoenebeck --- include/qemu/qarray.h | 154 ++ 1 file changed, 154 insertions(+) create mode 100644 include/qemu/qarray.h diff --git a/include/qemu/qarray.h b/include/qemu/qarray.

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

On Dienstag, 24. August 2021 17:24:50 CEST Christian Schoenebeck wrote: > On Dienstag, 24. August 2021 16:45:12 CEST Markus Armbruster wrote: > > Christian Schoenebeck writes: > > > On Dienstag, 24. August 2021 10:22:52 CEST Markus Armbruster wrote: > > [...] > > &

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

On Dienstag, 24. August 2021 16:45:12 CEST Markus Armbruster wrote: > Christian Schoenebeck writes: > > On Dienstag, 24. August 2021 10:22:52 CEST Markus Armbruster wrote: > [...] > > >> Please use GPLv2+ unless you have a compelling reason not to. > >> > >

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

On Sonntag, 22. August 2021 15:16:46 CEST Christian Schoenebeck wrote: > Implements deep auto free of arrays while retaining common C-style > squared bracket access. > > Signed-off-by: Christian Schoenebeck > --- > include/qemu/qarray.h | 150 ++

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

On Dienstag, 24. August 2021 10:22:52 CEST Markus Armbruster wrote: > Christian Schoenebeck writes: > > Implements deep auto free of arrays while retaining common C-style > > squared bracket access. > > > > Signed-off-by: Christian Schoenebeck > > You provide s

[PATCH v2 2/5] qemu/qarray.h: check scalar type in QARRAY_CREATE()

Make sure at compile time that the scalar type of the array requested to be created via QARRAY_CREATE() matches the scalar type of the passed auto reference variable (unique pointer). Suggested-by: Richard Henderson Signed-off-by: Christian Schoenebeck --- include/qemu/qarray.h | 6 ++ 1

<    2   3   4   5   6   7   8   9   10   11   >