The current value for the -rtc driftfix option is 'none'. This patch
makes sure that the old machines configuration will work the same way
even after that option changes its default value.
Signed-off-by: Crístian Viana
---
hw/pc_piix.c |4
1 file changed, 4 insertions(+)
di
Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as
the time source. If driftfix is not enabled, Windows is prone to
blue screening.
Signed-off-by: Crístian Viana
---
hw/mc146818rtc.c |2 +-
vl.c | 11 ++-
2 files changed, 11 insertions(+), 2
If a GlobalProperty has already been registered, it won't have its value
overwritten. This is done to enforce that the properties specified in the
command
line will "win" over the ones specified by the machine properties, if set with
the parameter "-M".
Signed-off-by: Cr
The third parameter of unix_listen in the line:
int fd = unix_listen(path, NULL, strlen(path));
makes an unnecessary call to strlen. That parameter will not be used unless
the second parameter is not NULL, which is not the case here.
---
qga/channel-posix.c |2 +-
1 file changed, 1 insertion
If a GlobalProperty has already been registered, it won't have its
value overwritten.
Signed-off-by: Crístian Viana
---
Changes since v4:
- Only register a GlobalProperty if it hasn't already been registered. That
avoids the property values to be overwritten (fix previous known
The current value for the -rtc driftfix option is 'none'. This patch
makes sure that the old machines configuration will work the same way
even after that option changes its default value.
Signed-off-by: Crístian Viana
---
hw/pc_piix.c |4
1 file changed, 4 insertions(+)
di
Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as
the time source. If driftfix is not enabled, Windows is prone to
blue screening.
Signed-off-by: Crístian Viana
---
hw/mc146818rtc.c |2 +-
vl.c | 11 ++-
2 files changed, 11 insertions(+), 2
Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as
the time source. If driftfix is not enabled, Windows is prone to
blue screening.
Signed-off-by: Crístian Viana
---
Anthony,
Could you please try to reproduce the segfault again (as you stated in
http
The current value for the -rtc driftfix option is 'none'. This patch
makes sure that the old machines configuration will work the same way
even after that option changes its default value.
Signed-off-by: Crístian Viana
---
There's a scenario when things don't work the way I
On 30-05-2012 02:41, Peter Maydell wrote:
Nak. This is duplicating a much better patchset from Jim Meyering:
http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg01151.html -- PMM
Sorry, I hadn't seen his patchset. Is it OK for me to proceed with a
similar patch regarding the function "str
Replace some "strcpy" and "strncpy" calls by "pstrcpy" because the former ones
may cause buffer overflow and may also not write a null-terminating character at
the end of the resulting string
Signed-off-by: Crístian Viana
---
According to the file HACKING, the f
hould report. If that field is
set, then that machine will report that version to the guest.
Signed-off-by: Crístian Viana
---
Changes since v4:
- Rewrite commit message
- Replace snprintf calls by pstrcpy/pstrcat.
hw/boards.h |1 +
hw/bt-sdp.c |6 +++--
On 23-05-2012 17:54, Peter Maydell wrote:
The point is that your snprintf is not actually using the full power of
a format string parser, it's just concatenating two strings ("QEMU "
and the version). The simple way to put two strings into a buffer
one after the other is to copy string A and then
On 23-05-2012 13:11, Eric Blake wrote:
pstrcat is more efficient than snprintf() - the former is dedicated to a
single task, while the latter has to parse a format string and decode
that it is doing a single %s expansion. In other words, just because
*printf can do string concatenation doesn't m
Hi Peter,
Thanks for all your tips!
OK, this has been bugging me for the last three versions, and
since I'm complaining about other things anyway: can you reword
this commit message, please, so that it is a standalone paragraph
explaining (a) what the commit does and (b) why it is doing it, rat
switch.
> We should find all these places and stop doing this.
There is a new field on the struct QEmuMachine, hw_version, which may
contain the version that the specific machine should report. If that
field is set, then that machine will report that version to the virtual
machine.
Signed-off-by:
Hi,
I'm trying to change the default value of the parameter "-rtc driftfix="
and something's going wrong. This is a GlobalProperty and, currently, it
is equivalent to setting "-rtc driftfix=none" in the command line. I'm
appending a new GlobalProperty value to all previous QEMUMachine
instanc
On 27-04-2012 20:14, Crístian Viana wrote:
On 27-04-2012 18:23, Peter Maydell wrote:
That appears to contain one of your older versions of this patch, not
v3. (It touches bsd-user/main.c, for example.) -- PMM
You were right, it was an older version. Now the branch is updated and
rebased
On 27-04-2012 18:23, Peter Maydell wrote:
That appears to contain one of your older versions of this patch, not
v3. (It touches bsd-user/main.c, for example.) -- PMM
You were right, it was an older version. Now the branch is updated and
rebased against the current master.
Best regards,
Crísti
On 27-04-2012 14:41, Anthony Liguori wrote:
Can you post a git tree on github so I can look at the difference?
Maybe patch applied it wrong.
git://github.com/cd1/qemu.git, branch qemu-version
Best regards,
Crístian.
On 25-04-2012 16:16, Anthony Liguori wrote:
If you run:
x86_64-softmmu/qemu-system-x86_64
This will SEGV because machine == NULL. It's quite a bit later in
this function when machine gets initialized with the default machine.
You mean running only the binary, without arguments? I got no SEG
On 13-04-2012 22:27, Peter Maydell wrote:
Why 32 ?
In that case, 32 was a estimative I made of the number of characters
that the VERSION string would have based on its original value ("qemu
usb-redir guest " QEMU_VERSION), so the new value wouldn't be much
longer than the original one. I don't
On 13-04-2012 16:26, Eric Blake wrote:
> qemu_get_version returns whatever string got put there by
> qemu_set_version. Am I correct that the user has full control over the
> string passed to qemu_set_version?
Actually, this is not available to the user, the string passed to that
function is suppo
switch.
> We should find all these places and stop doing this.
There is a new field on the struct QEmuMachine, hw_version, which may
contain the version that the specific machine should report. If that
field is set, then that machine will report that version to the virtual
machine.
Signed-off-by:
switch.
> We should find all these places and stop doing this.
There is a new field on the struct QEmuMachine, hw_version, which may
contain the version that the specific machine should report. If that
field is set, then that machine will report that version to the virtual
machine.
Signed-off-by:
On 05-04-2012 11:48, Peter Maydell wrote:
> This kind of change is definitely wrong -- where we're reporting
> the QEMU version to the *user* we definitely don't want to introduce
> the possibility of lying about it.
>
> (This is distinct from reporting the QEMU version to the *guest*
> via device
switch.
> We should find all these places and stop doing this.
There is a new field on the struct QEmuMachine, hw_version, which may
contain the version that the specific machine should report. If that
field is set, then that machine will report that version to the virtual
machine.
Signed-off-by:
On 21-03-2012 03:02, Paolo Bonzini wrote:
> This piece of code from the previous if:
>
> if (!strcmp(value, "slew")) {
> static GlobalProperty slew_lost_ticks[] = {
> {
> .driver = "mc146818rtc",
> .property = "lost_tick
The current value for the -rtc timedrift option is none. This patch
makes sure that the old machines configuration will work the same way
even after that option changes its default value.
Signed-off-by: Crístian Viana
---
hw/pc_piix.c | 39 +++
1 files
Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as
the time source. If time drift is not enabled, Windows is prone to
blue screening.
Signed-off-by: Crístian Viana
---
hw/mc146818rtc.c |2 +-
vl.c | 10 +-
2 files changed, 6 insertions
Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as
the time source. If time drift is not enabled, Windows is prone to
blue screening.
Signed-off-by: Crístian Viana
---
hw/mc146818rtc.c |2 +-
vl.c |2 +-
2 files changed, 2 insertions(+), 2
The current value for the -rtc timedrift option is none. This patch
makes sure that the old machines configuration will work the same way
even after that option changes its default value.
Signed-off-by: Crístian Viana
---
hw/pc_piix.c | 39 +++
1 files
On 20-03-2012 17:31, Anthony Liguori wrote:
> On 03/20/2012 03:16 PM, Crístian Viana wrote:
>> On 20-03-2012 17:05, Anthony Liguori wrote:
>>> I think we just want to change:
>>>
>>> hw/mc146818rtc.h:
>>> DEFINE_PRO
On 20-03-2012 17:05, Anthony Liguori wrote:
> I think we just want to change:
>
> hw/mc146818rtc.h:
> DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
>lost_tick_policy, LOST_TICK_DISCARD),
>
> I think we just need to change this to LOST_TICK_SLEW. Thi
The current value for the -rtc timedrift option is none. This patch
makes sure that the old machines configuration will work the same way
even after that option changes its default value.
Signed-off-by: Crístian Viana
---
hw/pc_piix.c | 39 +++
1 files
Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as
the time source. If time drift is not enabled, Windows is prone to
blue screening.
Signed-off-by: Crístian Viana
---
vl.c | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/vl.c b
On 09-03-2012 14:27, Eric Blake wrote:
> For starters, you mailed the qemu list. This patch should be sent
> instead to libvir-l...@redhat.com, so that it will actually reach the
> libvirt folks.
>
Oh, sorry, wrong list :-) I'll mail the right one then.
Thanks!
diff --git a/AUTHORS b/AUTHORS
index 954fd1a..b09bd62 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -224,6 +224,7 @@ Patches have also been contributed by:
Peter Robinson
Benjamin Cama
Duncan Rance
+ Crístian Viana
[send patches to get your name here
If there is a disk file with a comma in the name, QEmu expects a double
comma instead of a single one (e.g., the file "virtual,disk.img" needs
to be specified as "virtual,,disk.img" in QEmu's command line). This
patch fixes libvirt to work with that feature. Fix RHBZ #801036.
diff --git a/src/qemu
Hi!
This patch fixes RHBZ #801036 adding support to filenames with comma using
QEmu. As this is my first patch to libvirt, I'm not completely sure if I should
have also changed other parts of the code, or if I have used the wrong memory
allocation functions/macros, or if I shouldn't have creat
40 matches
Mail list logo
