From: "Dr. David Alan Gilbert"
remote_iohub_finalize has never been used.
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
hw/remote/iohub.c | 13 -
include/hw/remote/iohub.h | 1 -
2 files changed, 14 deletions(-)
diff --git a/hw/remote/iohub.c b/hw/remote/iohub.c
i
From: "Dr. David Alan Gilbert"
qemu_clock_get_main_loop_timerlist and timerlist_get_clock have been
unused since they were originally added in
ff83c66ecc ("aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList")
Remove them.
Signed-off-by: Dr. David Alan Gilbert
---
include/qemu/ti
From: "Dr. David Alan Gilbert"
Use the uffd_copy_page, uffd_zero_page and uffd_wakeup helpers
rather than calling ioctl ourselves.
They return -errno on error, and print an error_report themselves.
I think this actually makes postcopy_place_page actually more
consistent in it's callers.
Signed-
From: "Dr. David Alan Gilbert"
uffd_poll_events has been unused since it was added; it's also
just a wrapper around a plain old poll call, so doesn't add anything.
Signed-off-by: Dr. David Alan Gilbert
---
include/qemu/userfaultfd.h | 1 -
util/userfaultfd.c | 28 -
From: "Dr. David Alan Gilbert"
migrate_cap_set has been unused since
18d154f575 ("migration: Remove 'blk/-b' option from migrate commands")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Fabiano Rosas
---
migration/options.c | 20
migration/options.h |
From: "Dr. David Alan Gilbert"
Convert (the currently unused) uffd_wakeup, uffd_copy_page and
uffd_zero_page to return -errno on error rather than -1.
That will make it easier to reuse in postcopy.
Signed-off-by: Dr. David Alan Gilbert
---
util/userfaultfd.c | 21 -
1 file
From: "Dr. David Alan Gilbert"
socket_send_channel_create_sync only use was removed by
d0edb8a173 ("migration: Create the postcopy preempt channel asynchronously")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Fabiano Rosas
---
migration/socket.c | 18 --
mi
From: "Dr. David Alan Gilbert"
migrate_zero_blocks is unused since
eef0bae3a7 ("migration: Remove block migration")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
migration/options.c | 7 ---
migration/options.h | 1 -
2 files changed, 8 deletions(-)
diff --git a/migration/option
From: Fabiano Rosas
The zero-blocks capability was meant to be used along with the block
migration, which has been removed already in commit eef0bae3a7
("migration: Remove block migration").
Setting zero-blocks is currently a noop, but the outright removal of
the capability would cause and error
emoving most of them.
Remove one.
Dave
Dr. David Alan Gilbert (6):
migration: Remove migrate_cap_set
migration: Remove unused migrate_zero_blocks
migration: Remove unused socket_send_channel_create_sync
util/userfaultfd: Return -errno on error
migration/postcopy: Use uffd helpers
util/userfa
From: "Dr. David Alan Gilbert"
qio_channel_socket_dgram_async has been unused since it was originally
added in 2015.
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
include/io/channel-socket.h | 29
io/channel-socket.c | 54 ---
From: "Dr. David Alan Gilbert"
pcie_chassis_find_slot has been unused since it was added.
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
hw/pci/pcie_port.c | 10 --
include/hw/pci/pcie_port.h | 1 -
2 files changed, 11 deletions(-)
diff --git a/hw/pci/pcie_port.c b/hw/
From: "Dr. David Alan Gilbert"
replay_disable_events has been unused since 2019's
c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
include/sysemu/replay.h | 2 --
replay/replay-events.c | 9 -
2 files chang
From: "Dr. David Alan Gilbert"
socket_remote_address hasn't been used since it was added in
17c55decec ("sockets: add helpers for creating SocketAddress from a socket")
inet_connect hasn't been used since 2017's
8ecc2f9eab ("sheepdog: Use SocketAddress and socket_connect()")
Remove them.
S
From: "Dr. David Alan Gilbert"
rocker_fp_ports hasn't been used since it was added back in 2015.
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
hw/net/rocker/rocker.c | 5 -
hw/net/rocker/rocker.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/hw/net/rocker/rocker.c b/hw/net/ro
From: "Dr. David Alan Gilbert"
net_rx_pkt_get_l3_hdr_offset and net_rx_pkt_get_iovec_len haven't
been used since they were added.
Remove them.
Signed-off-by: Dr. David Alan Gilbert
---
hw/net/net_rx_pkt.c | 13 -
hw/net/net_rx_pkt.h | 9 -
2 files changed, 22 deletions(-)
From: "Dr. David Alan Gilbert"
net_hub_port_find is unused since 2018's commit
af1a5c3eb4 ("net: Remove the deprecated "vlan" parameter")
qemu_receive_packet_iov is unused since commit
ffbd2dbd8e ("e1000e: Perform software segmentation for loopback")
in turn it was the last user of qemu_net
From: "Dr. David Alan Gilbert"
qemu_get_exec_dir has been unused since commit:
5bebe03f51 ("util/cutils: Clean up global variable shadowing in
get_relocated_path()")
Remove it, and fix up a comment that pointed to it.
Signed-off-by: Dr. David Alan Gilbert
---
include/qemu/cutils.h | 5 +---
From: "Dr. David Alan Gilbert"
qemu_clock_get_main_loop_timerlist has been unused since it was
originally added in
ff83c66ecc ("aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
include/qemu/timer.h | 10 --
util/qe
From: "Dr. David Alan Gilbert"
qcrypto_der_encode_octet_str_begin and _end have been unused
since they were added in
3b34ccad66 ("crypto: Support DER encodings")
Remove them.
Signed-off-by: Dr. David Alan Gilbert
---
crypto/der.c | 13 -
crypto/der.h | 22 --
From: "Dr. David Alan Gilbert"
serial_set_frequnecy has been unused since it was added in 2009:
038eaf82c8 ("serial: Add interface to set reference oscillator frequency")
It looks like the 'baudbase' is now a property anyway so the wrapper
isn't needed.
Remove it.
Signed-off-by: Dr. David Al
From: "Dr. David Alan Gilbert"
iova_tree_find_address, and iova_tree_foreach have never been
used since the code was originally added by:
eecf5eedbd ("util: implement simple iova tree")
Remove them.
Signed-off-by: Dr. David Alan Gilbert
---
include/qemu/iova-tree.h | 25
From: "Dr. David Alan Gilbert"
handle_vm86_fault has been unused since:
1ade5b2fed ("linux-user/i386: Split out maybe_handle_vm86_trap")
Remove it, and it's local macros.
Signed-off-by: Dr. David Alan Gilbert
---
linux-user/user-internals.h | 1 -
linux-user/vm86.c | 136 ---
From: "Dr. David Alan Gilbert"
co_try_get_from_shres hasn't been used since it was added in
55fa54a789 ("co-shared-resource: protect with a mutex")
(Everyone uses the _locked version)
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
include/qemu/co-shared-resource.h | 7 ---
util/qe
From: "Dr. David Alan Gilbert"
fw_cfg_init_io has been unused since
918a7f706b ("i386: load kernel on xen using DMA")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
hw/nvram/fw_cfg.c | 5 -
include/hw/nvram/fw_cfg.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/hw/n
From: "Dr. David Alan Gilbert"
The last use of sysbus_mmio_unmap was removed by
981b1c6266 ("spapr/xive: rework the mapping the KVM memory regions")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
hw/core/sysbus.c| 10 --
include/hw/sysbus.h | 1 -
2 files changed, 11 dele
From: "Dr. David Alan Gilbert"
vhost_dev_load_inflight and vhost_dev_save_inflight have been
unused since they were added in 2019 by:
5ad204bf2a ("vhost-user: Support transferring inflight buffer between qemu and
backend")
Remove them, and their helper vhost_dev_resize_inflight.
Signed-off-by
From: "Dr. David Alan Gilbert"
mch_mcfg_base has been unused since it was added by
6f1426ab0f ("ich9: APIs for pc guest info")
back in 2013.
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
hw/pci-host/q35.c | 10 --
include/hw/pci-host/q35.h | 2 --
2 files changed, 12
From: "Dr. David Alan Gilbert"
envlist_parse, envlist_parse_set, envlist_parse_unset were added
in 2009 but never used, see:
04a6dfebb6 ("linux-user: Add generic env variable handling")
Remove them.
Signed-off-by: Dr. David Alan Gilbert
---
include/qemu/envlist.h | 2 --
util/envlist.c
From: "Dr. David Alan Gilbert"
socket_send_channel_create_sync only use was removed by
d0edb8a173 ("migration: Create the postcopy preempt channel asynchronously")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
migration/socket.c | 18 --
migration/socket.h | 1 -
2 f
From: "Dr. David Alan Gilbert"
migrate_cap_set has been unused since
18d154f575 ("migration: Remove 'blk/-b' option from migrate commands")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
migration/options.c | 20
migration/options.h | 1 -
2 files changed, 21 del
From: "Dr. David Alan Gilbert"
migrate_zero_blocks is unused since
eef0bae3a7 ("migration: Remove block migration")
Remove it.
That whole zero-blocks capability was just for old-school
block migration anyway.
Remove the capability as well.
Signed-off-by: Dr. David Alan Gilbert
---
migratio
From: "Dr. David Alan Gilbert"
Hi,
This is a set of deadcode removal around migration
found by looking for unused symbols.
Note this does remove the old zero-blocks
capability, but it's been meaningless anyway since block
migration went.
Dave
Dr. David Alan Gilbert (
From: "Dr. David Alan Gilbert"
cursor_get_mono_image has been unused since 2018's
0015ca5cba ("ui: remove support for SDL1.2 in favour of SDL2")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
include/ui/console.h | 1 -
ui/cursor.c | 24
2 files chan
From: "Dr. David Alan Gilbert"
xen_be_copy_grant_refs is unused since 2019's
19f87870ba ("xen: remove the legacy 'xen_disk' backend")
xen_config_dev_console is unused since 2018's
6d7c06c213 ("Remove broken Xen PV domain builder")
Remove them.
Signed-off-by: Dr. David Alan Gilbert
---
hw
From: "Dr. David Alan Gilbert"
blk_by_public last use was removed in 2017 by
c61791fc23 ("block: add aio_context field in ThrottleGroupMember")
blk_activate last use was removed earlier this year by
eef0bae3a7 ("migration: Remove block migration")
blk_add_insert_bs_notifier, blk_op_block_al
From: "Dr. David Alan Gilbert"
aio_task_pool_empty has been unused since it was added in
6e9b225f73 ("block: introduce aio task pool")
Remove it.
Signed-off-by: Dr. David Alan Gilbert
---
block/aio_task.c | 5 -
include/block/aio_task.h | 2 --
2 files changed, 7 deletions(-)
d
On 7/1/24 7:12 PM, Shiyang Ruan wrote:
>
>
> 在 2024/6/25 21:56, Shiyang Ruan 写道:
>>
>>
>> 在 2024/6/22 1:51, Dan Williams 写道:
>>> Shiyang Ruan wrote:
Background:
Since CXL device is a memory device, while CPU consumes a poison page of
CXL device, it always triggers a MCE by inter
Hi there,
I'm not sure if the previous mail has been dropped. I would really appreciate
it if anyone could give me some advice. Thanks a lot!
Best,
Peter
On Wednesday, April 24th, 2024 at AM 2:20, Peter Dave Hello
wrote:
> Hi PMM, Zhao & Daniel,
>
> Thank you for all y
On 6/19/24 2:24 AM, Shiyang Ruan wrote:
>
>
> 在 2024/6/19 7:35, Dave Jiang 写道:
>>
>>
>> On 6/18/24 9:53 AM, Shiyang Ruan wrote:
>>> Background:
>>> Since CXL device is a memory device, while CPU consumes a poison page of
>>> CXL device, it
On 6/18/24 9:53 AM, Shiyang Ruan wrote:
> Background:
> Since CXL device is a memory device, while CPU consumes a poison page of
> CXL device, it always triggers a MCE by interrupt (INT18), no matter
> which-First path is configured. This is the first report. Then
> currently, in FW-First p
eter
On Thursday, April 18th, 2024 at AM 10:08, Zhao Liu wrote:
> Hi Perter HSU,
>
> On Wed, Apr 17, 2024 at 01:07:17PM +, Peter Dave Hello wrote:
>
> > Date: Wed, 17 Apr 2024 13:07:17 +
> > From: Peter Dave Hello h...@peterdavehello.org
> > Subject: Re
On 4/17/24 12:50 AM, Shiyang Ruan wrote:
> Currently driver only traces cxl events, poison creation (for both vmem
> and pmem type) on cxl memdev is silent. OS needs to be notified then it
> could handle poison pages in time. Per CXL spec, the device error event
> could be signaled through FW-
your help again.
From: Peter Dave Hello
Date: Tue, 16 Apr 2024 00:43:29 +0800
Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation
This patch adds a basic zh_TW translation file for Taiwan Traditional
Chinese users.
Signed-off-by: Peter Dave Hello
---
po/LINGUAS | 1 +
p
From: Peter Dave Hello
Date: Tue, 16 Apr 2024 00:43:29 +0800
Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation
This patch adds a basic zh_TW translation file for Taiwan Traditional
Chinese users.
Signed-off-by: Peter Dave Hello
---
po/LINGUAS | 1 +
po/zh_TW.po | 93
le16_to_cpu(payload->handles[i]));
>>> + le16_to_cpu(payload->handles[i-1]));
>> Trivial but needs spaces around the -. e.g. [i - 1]
>>
>> Maybe Dan can fix up whilst applying.
>>
>> Otherwise
>>
>> Reviewed-by: Jonathan Cameron
On 2/9/24 4:54 AM, Shiyang Ruan wrote:
> Currently driver only trace cxl events, poison injection on cxl memdev
> is silent. OS needs to be notified then it could handle poison range
> in time. Per CXL spec, the device error event could be signaled through
> FW-First and OS-First methods.
>
>
Congratulations!
Once it was made clear the problem was in the BIOS, it was easy to find. I've
made the attached patch, but haven't yet tested it.
qemu-8.1.3-dont-screw-up-terminal-settings.patch
Description: Binary data
Fixed by "downgrading" to 7.x series.
Something has changed in 8.x.
Doesn't work for me. Fixed by "downgrading" to the 7.x series.
I just "upgraded" from QEMU 6.1.0 to 8.1.3 only to find that the -serial
telnet/tcp option is no longer working. The following message is printed, and
there's a 'connection refused' with the telnet program. Nmap shows no ports
open.
qemu-system-x86_64: -serial telnet:127.0.0.1:1800,server=on:
had no effect.
Dave
On 10/9/23 08:47, Jonathan Cameron wrote:
> On Fri, 06 Oct 2023 15:15:56 -0700
> Dave Jiang wrote:
>
>> Add a simple _DSM call support for the ACPI0017 device to return fake QTG
>> ID values of 0 and 1 in all cases. This for _DSM plumbing testing from the
>> OS.
Return (Package (0x02)
{
One,
Package (0x02)
{
Zero,
One
}
})
}
}
}
Signed-off-by: Dave Jiang
Signed-off-
On 10/4/23 20:36, Michael S. Tsirkin wrote:
>
> On Wed, Oct 04, 2023 at 04:09:07PM -0700, Dave Jiang wrote:
>> Add a simple _DSM call support for the ACPI0017 device to return a fake QTG
>> ID value of 0 in all cases. The enabling is for _DSM plumbing testing
>>
{ 0x00, 0x00 }
}
})
}
}
}
Signed-off-by: Dave Jiang
Signed-off-by: Jonathan Cameron
--
v3: Fix output assignment to be BE host friendly. Fix typo in comment.
According to the CXL spec, the DSM output should be 1 WORD to indicate
the max suppoted QTG ID and a package of 0 or more WORDs for
On 9/22/23 13:08, Michael Tokarev wrote:
> 04.09.2023 16:28, Jonathan Cameron:
>> From: Dave Jiang
>>
>> According to ACPI spec 6.5 5.2.28.4 System Locality Latency and Bandwidth
>> Information Structure, if the "Entry Base Unit" is 1024 for BW and the
>
Not sure if crash people subscribed to linux-debuggers, let's add more
cc for awareness about this thread.
On Thu, 21 Sept 2023 at 01:45, Stephen Brennan
wrote:
>
> Stephen Brennan writes:
> > Hi Jon,
> >
> > Jon Doron writes:
> >> Hi Stephen,
> >> Like you have said the reason is as I wrote in
ase without a rationale...)
>>
>
> I've +CC'd the kernel CXL maintainers from Intel a few of whom
> have also contributed some of the QEMU CXL code.
> Hopefully someone can ack.
>
>>> Suggested-by: Philippe Mathieu-Daudé
>>> Signed-off-by: Jonat
On 9/18/23 10:00, Jonathan Cameron wrote:
> On Mon, 18 Sep 2023 17:31:38 +0100
> Peter Maydell wrote:
>
>> On Mon, 18 Sept 2023 at 16:04, Jonathan Cameron
>> wrote:
>>>
>>> This has been missing from the start. Assume it should match
>>> with cxl/cxl-component-utils.c as both were part of ear
On 9/4/23 09:18, Jonathan Cameron wrote:
> Description of change in previous patch.
>
> Signed-off-by: Jonathan Cameron
Reviewed-by: Dave Jiang
> ---
> tests/qtest/bios-tables-test-allowed-diff.h | 1 -
> tests/data/acpi/q35/DSDT.cxl| Bin 9655 ->
On 9/4/23 09:18, Jonathan Cameron wrote:
> Addition of QTG in following patch requires an update to the test
> data.
>
> Signed-off-by: Jonathan Cameron
Reviewed-by: Dave Jiang
> ---
> tests/qtest/bios-tables-test-allowed-diff.h | 1 +
> 1 file changed, 1 insertion
On 5/3/23 3:42 AM, Jonathan Cameron wrote:
On Tue, 18 Apr 2023 15:21:36 -0700
Dave Jiang wrote:
s small RFC patch series is really a hack on what I need from qemu rather
than a proper implementation. I'm hoping to get some guidance from the list on
how to implement this correctly for
On 5/3/23 3:42 AM, Jonathan Cameron wrote:
On Tue, 18 Apr 2023 15:21:36 -0700
Dave Jiang wrote:
s small RFC patch series is really a hack on what I need from qemu rather
than a proper implementation. I'm hoping to get some guidance from the list on
how to implement this correctly for
done
done
Linux kernel support:
https://lore.kernel.org/linux-cxl/168088732996.1441063.10107817505475386072.stgit@djiang5-mobl3/T/#t
---
Dave Jiang (3):
hw/acpi: Add support for Generic Port Affinity Structure to SRAT
genport: Add json support for generic port
acpi: add gen
Signed-off-by: Dave Jiang
---
hw/acpi/genport.c | 61 +++
hw/acpi/meson.build |1 +
hw/i386/acpi-build.c| 32 ++-
include/hw/acpi/aml-build.h |4 +--
softmmu/vl.c| 26
e set to 0 for simplicity to enable Linux kernel
side debugging and usage of the new SRAT sub-tables.
Signed-off-by: Dave Jiang
---
hw/acpi/aml-build.c | 21 +
hw/i386/acpi-build.c| 27 +++
include/hw/acpi/aml-build.h |
Add QOM json update for ACPI generic port object to support HMAT
enumeration.
Signed-off-by: Dave Jiang
---
qapi/machine.json |3 ++-
qapi/qom.json | 12
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index
-off-by: Jonathan Cameron
Reviewed-by: Dave Jiang
---
hw/cxl/cxl-component-utils.c | 6 +-
hw/mem/cxl_type3.c | 21 -
2 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/hw/cxl/cxl-component-utils.c b/hw/cxl/cxl-component-utils.c
index
On 3/14/23 9:53 AM, Fan Ni wrote:
Replace the magic number 32 with CXL_RAS_ERR_HEADER_NUM for better code
readability and maintainability.
Signed-off-by: Fan Ni
Reviewed-by: Dave Jiang
---
include/hw/cxl/cxl_device.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
I'm attempting to implement the support of ACPI "generic port" detailed
in the ACPI r6.5 spec in QEMU. The spec section 5.2.16.7 details the
Generi Port Affinity Structure where it ties a Device Handle to a
Proximity Domain. And with section 6.2.28.4 for the HMAT table, the
latency and bandwidt
3,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31]
},
{
"type": "internal",
"header": [ 1, 2, 4]
}
]
}}
...
{ "execute": "cxl-inject-correctable-error",
"arguments": {
"path": "
On 2/17/23 10:29 AM, Jonathan Cameron wrote:
CXL uses PCI AER Internal errors to signal to the host that an error has
occurred. The host can then read more detailed status from the CXL RAS
capability.
For uncorrectable errors: support multiple injection in one operation
as this is needed to r
h big endian. However it is good to avoid making
things worse for that support in the future.
Signed-off-by: Jonathan Cameron
Reviewed-by: Dave Jiang
---
hw/cxl/cxl-component-utils.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/cxl/cxl-comp
On 2/17/23 10:29 AM, Jonathan Cameron wrote:
This infrastructure will be reused for CXL RAS error injection
in patches that follow.
Signed-off-by: Jonathan Cameron
Reviewed-by: Dave Jiang
---
hw/pci/pci-internal.h | 1 -
include/hw/pci/pcie_aer.h | 1 +
2 files changed, 1
On 2/17/23 10:29 AM, Jonathan Cameron wrote:
This enables AER error injection to function as expected.
It is intended as a building block in enabling CXL RAS error injection
in the following patches.
Signed-off-by: Jonathan Cameron
Reviewed-by: Dave Jiang
---
hw/mem/cxl_type3.c | 13
On 2/17/23 10:29 AM, Jonathan Cameron wrote:
Done to avoid fixing ACPI route description of traditional PCI interrupts on q35
and because we should probably move with the times anyway.
Signed-off-by: Jonathan Cameron
Reviewed-by: Dave Jiang
---
hw/pci-bridge/cxl_root_port.c | 61
On 2/17/23 10:29 AM, Jonathan Cameron wrote:
We are missing necessary config write handling for AER emulation in
the CXL root port. Add it based on pcie_root_port.c
Signed-off-by: Jonathan Cameron
Reviewed-by: Dave Jiang
---
hw/pci-bridge/cxl_root_port.c | 3 +++
1 file changed, 3
being set as long as the appropriate per error class bit in the PCIe
Device Control Register is set.
Implement that branch thus enabling routing of ERR_COR, ERR_NONFATAL
and ERR_FATAL under OSes that set these bits appropriately (e.g. Linux)
Signed-off-by: Jonathan Cameron
Reviewed-by: Dave J
On 2/17/23 10:29 AM, Jonathan Cameron wrote:
This register in AER should be both writeable and should
have a default value with a couple of the errors masked
including the Uncorrectable Internal Error used by CXL for
it's error reporting.
Signed-off-by: Jonathan Cameron
Reviewed-by:
On 1/26/23 11:24 AM, Jonathan Cameron wrote:
On Thu, 26 Jan 2023 11:07:37 -0700
Dave Jiang wrote:
Hi Dave,
That was quick!
Add a simple _DSM call support for the ACPI0017 device to return a fake QTG
ID value. Given the current CXL implementation does not involve switches,
I don&#
On 1/26/23 11:24 AM, Jonathan Cameron wrote:
On Thu, 26 Jan 2023 11:07:37 -0700
Dave Jiang wrote:
Hi Dave,
That was quick!
Add a simple _DSM call support for the ACPI0017 device to return a fake QTG
ID value. Given the current CXL implementation does not involve switches,
I don&#
Add a simple _DSM call support for the ACPI0017 device to return a fake QTG
ID value. Given the current CXL implementation does not involve switches,
a faked value of 0 can be returned for the QTG ID. The enabling is for _DSM
plumbing testing from the OS.
Signed-off-by: Dave Jiang
---
hw/acpi
On 1/26/23 11:47 AM, Jonathan Cameron wrote:
On Thu, 26 Jan 2023 11:41:47 -0700
Dave Jiang wrote:
On 1/26/23 11:24 AM, Jonathan Cameron wrote:
On Thu, 26 Jan 2023 11:07:37 -0700
Dave Jiang wrote:
Hi Dave,
That was quick!
Add a simple _DSM call support for the ACPI0017 device to
This patch does not belong in this series. It's not a patch to the
kernel. This is a kernel series.
It would be much more appropriate to put a link to a separately posted
manpage patch in the cover letter.
) and so could generate both
notify_invalidate() and a notify_populate() events.
Hence "fallocate" as an internal mm namespace or operation does not
belong anywhere in core MM infrastructure - it should never get used
anywhere other than the VFS/filesystem layers that implement the
fallocate() syscall or use it directly.
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
ll /nonexistent/libexec/qemu-bridge-helper by default.
Dave
On 12/01/2021 23:53, Paolo Bonzini wrote:
On 12/01/21 18:04, Dave wrote:
Thanks Paola,
We are still in testing and that's the only thing we've uncovered so
far with the new 5.2.0. I will post if the ops guys find anything else.
Thanks Paola,
We are still in testing and that's the only thing we've uncovered so far
with the new 5.2.0. I will post if the ops guys find anything else.
Dave
On 12/01/2021 20:53, Paolo Bonzini wrote:
Il mar 12 gen 2021, 17:48 Dave mailto:d...@0bits.com>>
ha scritto
goes into production.
It would be nicer with the relocatable binary took some fixed paths from
/etc/qemu.conf for the bridge-helper, firmware, bios, qemu-ifup/down.
thanks
Dave
On 12/01/2021 18:48, Paolo Bonzini wrote:
On 12/01/21 15:05, Dave wrote:
Is seem that absolute firmwarepath compilation
share/qemu
/root/qemu/../share/qemu-firmware
So there is no way to have a absolute path for firmware /bios and all
qemu's that we test need to be at the right directory nesting to find
firmware, bios etc or else they all need their own duplicate firmware
files. Firmware path needs to honor the absolute paths i believe.
Comments ?
Dave
This problem occurred with the QEMU 5.0 version that was distributed
with the Ubuntu 20.10 update.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1901440
Title:
Instability in IVSHMEM after updating
Public bug reported:
Updating Ubuntu from 20.08 to 20.10 which updates QEMU from 4.2 to 5.0
results in the virtual machines freezing when the IVSHMEM interface is
active. This workstation typically runs several windows 10 virtual
machines that are accessed locally: two using the spice viewer and
On Mon, Oct 19, 2020 at 05:23:11PM +0200, Andrew Jones wrote:
> On Mon, Oct 19, 2020 at 03:58:40PM +0100, Dave Martin wrote:
> > On Mon, Oct 19, 2020 at 03:18:11PM +0100, Peter Maydell wrote:
> > > On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote:
> > > >
> &g
make sense to get rid of the REG_HIDDEN_GUEST / REG_HIDDEN_USER
distinction, and provide the same visibility for userspace as for MSR/
MRS all the time. This would restore ID_AA64ZFR0_EL1 into the userspace
view, and may also allow a bit of simplification in the code.
Won't this will still break migration from the resulting kernel to a
current kernel that hides ID_AA64ZFR0_EL1? Or have I misunderstood
something.
Cheers
---Dave
andle the
unallocated ID regs at all. At the destination end, modern hosts
should be permissive, i.e., allow any ID reg to be set to 0, but don't
require the setting of any reg that older source hosts might not send.
So, I think that instead of changing the ID_AA64ZFR0_EL1 behaviour,
parhaps we should move all ID_UNALLOCATED() regs (and possibly
ID_HIDDEN(), not sure about that) to have REG_HIDDEN_USER visibility.
Thoughts?
---Dave
HASH;
This seems inconsistent? F_SETFD is for setting flags on a file
descriptor. Won't setting a flag on filp here instead cause the
behaviour to change for all file descriptors across the system that are
open on this struct file? Compare set_close_on_exec().
I don't see any discussion on whether this should be an F_SETFL or an
F_SETFD, though I see F_SETFD was Ted's suggestion originally.
[...]
Cheers
---Dave
usters to the end of the file (i.e. the file
itself is not sparse), while the extent size hint will just add 64kB
extents into the file around the write offset. That demonstrates the
other behavioural advantage that extent size hints have is they
avoid needing to extend the file, which is yet another way to
serialise concurrent IO and create IO pipeline stalls...
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
you what the
device and filesytem are doing in real time (e.g. I use PCP for this
and visualise ithe behaviour in real time via pmchart) gives a lot
of insight into exactly what is changing during transient workload
changes liek starting a benchmark...
> I was running fio with --ramp_time=5 which ignores the first 5 seconds
> of data in order to let performance settle, but if I remove that I can
> see the effect more clearly. I can observe it with raw files (in 'off'
> and 'prealloc' modes) and qcow2 files in 'prealloc' mode. With qcow2 and
> preallocation=off the performance is stable during the whole test.
What does "preallocation=off" mean again? Is that using
fallocate(ZERO_RANGE) prior to the data write rather than
preallocating the metadata/entire file? If so, I would expect the
limiting factor is the rate at which IO can be issued because of the
fallocate() triggered pipeline bubbles. That leaves idle device time
so you're not pushing the limits of the hardware and hence none of
the behaviours above will be evident...
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
.
Thing is, once your writes into sprase image files regularly start
hitting written extents, the performance of (1), (2) and (4) will
trend towards (5) as writes hit already allocated ranges of the file
and the serialisation of extent mapping changes goes away. This
occurs with guest filesystems th
1 - 100 of 441 matches
Mail list logo
