[Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up

This Commit 7747abf11487 misses the curly brackets. Follow Igor's and Eduardo's suggestion, Add a follow-up patch for it. Signed-off-by: Dou Liyang --- hw/core/machine.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index

Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()

Hi Eduardo, At 07/10/2018 06:27 PM, Eduardo Habkost wrote: On Tue, Jul 10, 2018 at 04:15:30PM +0800, Dou Liyang wrote: [...] +if (nb_numa_nodes) machine_numa_finish_cpu_init(machine); -} missing curly brackets, should look like: if (nb_numa_nodes

[Qemu-devel] [PATCH v2 1/2] hw/acpi-build: Add a check for memory-less NUMA nodes

] ACPI: SRAT: Node 2 PXM 2 [mem 0x1-0x13fff] [0.00] ACPI: SRAT: Node 3 PXM 3 [mem 0x14000-0x33fff] hotplug Signed-off-by: Dou Liyang Reviewed-by: Igor Mammedov --- Note to maintainer: update ACPI tables test blobs on commit. --- hw/i386/acpi-build.c | 9 ++--- 1

[Qemu-devel] [PATCH v2 2/2][DO NOT APPLY] tests/acpi-test: update ACPI tables test blobs

Now, QEmu adds a new check for memory-less NUMA nodes in build_srat(). It effects the ACPI test. So, Update ACPI tables test blobs. Signed-off-by: Dou Liyang --- tests/acpi-test-data/pc/SRAT.numamem | Bin 224 -> 224 bytes tests/acpi-test-data/q35/SRAT.numamem | Bin 224 -> 224 bytes 2

Re: [Qemu-devel] [PATCH] hw/acpi-build: Add a check for non-memory NUMA nodes.

Hi Igor, At 07/10/2018 03:52 PM, Igor Mammedov wrote: On Thu, 5 Jul 2018 10:10:38 +0800 Dou Liyang wrote: Currently, Qemu ACPI builder doesn't consider the non-memory NUMA nodes, eg: s/non-memory/memory-less/ throughout subj/commit message Yes, I will do it. -m 4G,slots=4,maxmem

Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()

Hi Igor, At 07/10/2018 03:42 PM, Igor Mammedov wrote: On Wed, 4 Jul 2018 21:22:39 +0800 Dou Liyang wrote: Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA

[Qemu-devel] [PATCH] hw/acpi-build: Add a check for non-memory NUMA nodes.

] ACPI: SRAT: Node 2 PXM 2 [mem 0x1-0x13fff] [0.00] ACPI: SRAT: Node 3 PXM 3 [mem 0x14000-0x33fff] hotplug Signed-off-by: Dou Liyang --- Have done a bootup test in Linux and window 10, 7 --- hw/i386/acpi-build.c | 9 ++--- tests/acpi-test-data/pc

[Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()

need add a new node if memory hotplug is enabled (slots > 0) even nb_numa_nodes=0. So, Remove the check for numa_complete_configuration() to fix this. Fixes 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") Signed-off-by: Dou Liyang --- v1 --> v

Re: [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes

At 07/04/2018 07:52 PM, Dou Liyang wrote: Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly"). The machine_run_board_init() doesn't do NUMA setup if n

[Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes

also check the value of nb_numa_nodes, remove the check from machine_run_board_init() to fix ths bug. Fixes 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") Signed-off-by: Dou Liyang --- hw/core/machine.c | 6 ++ 1 file changed, 2 insertions(+), 4 dele

Re: [Qemu-devel] [RESEND PATCH for-2.12 0/2] ACPI/unit-test: Add a testcase

At 01/12/2018 03:23 PM, Dou Liyang wrote: [...] BTW, I used "make TEST_ACPI_REBUILD_AML=1 check" to create the DSDT file. Is it correct? This sounds correct to me.  Igor, can you confirm? It's will rebuild/update reference tables. I'm for merging it early and tracking/fixing i

Re: [Qemu-devel] [RESEND PATCH for-2.12 0/2] ACPI/unit-test: Add a testcase

[...] BTW, I used "make TEST_ACPI_REBUILD_AML=1 check" to create the DSDT file. Is it correct? This sounds correct to me. Igor, can you confirm? It's will rebuild/update reference tables. I'm for merging it early and tracking/fixing issue Peter saw during this dev cycle. Send an ack

Re: [Qemu-devel] [RESEND PATCH for-2.12 0/2] ACPI/unit-test: Add a testcase

Hi Eduardo, At 12/19/2017 06:09 AM, Eduardo Habkost wrote: On Thu, Dec 14, 2017 at 12:08:53PM +0800, Dou Liyang wrote: These are the patches left over from the pull request: [Qemu-devel] [PULL 0/9] x86 and machine queue, 2017-10-05 because of some errors when tested by "make

[Qemu-devel] [RESEND PATCH for-2.12 1/2] ACPI/unit-test: Add a testcase for RAM allocation in numa node

it is not enough. Add a testcase for this situation to make sure the ACPI table is correct for guest. Suggested-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- tests/acpi-test-data/pc/DSDT.numamem | Bin 0 -> 5150 bytes tests/ac

[Qemu-devel] [RESEND PATCH for-2.12 0/2] ACPI/unit-test: Add a testcase

and retest this patch in v2.11.0 --Update the DSDT.numamem: [1]: http://lists.gnu.org/archive/html/qemu-devel/2017-10/msg01334.html Dou Liyang (2): ACPI/unit-test: Add a testcase for RAM allocation in numa node hw/acpi-build: Make next_base easy to follow hw/i386/acpi-build.c

[Qemu-devel] [RESEND PATCH for-2.12 2/2] hw/acpi-build: Make next_base easy to follow

It may be hard to read the assignment statement of "next_base", so S/next_base += (1ULL << 32) - pcms->below_4g_mem_size; /next_base = mem_base + mem_len; ... for readability. No functionality change. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- hw/i3

Re: [Qemu-devel] [PULL 1/9] hw/acpi-build: Make assignment statement of next_base easy to read

Hi, Igor, At 11/28/2017 11:07 PM, Igor Mammedov wrote: On Thu, 5 Oct 2017 17:36:30 -0300 Eduardo Habkost <ehabk...@redhat.com> wrote: From: Dou Liyang <douly.f...@cn.fujitsu.com> It may be hard to read the assignment statement of "next_base", so S/next_base

Re: [Qemu-devel] [PULL 2/9] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

Hi Igor, At 11/28/2017 11:08 PM, Igor Mammedov wrote: On Thu, 5 Oct 2017 17:36:31 -0300 Eduardo Habkost <ehabk...@redhat.com> wrote: From: Dou Liyang <douly.f...@cn.fujitsu.com> As QEMU supports the memory-less node, it is possible that there is no RAM in the first numa node(al

Re: [Qemu-devel] [PATCH v6] NUMA: Enable adding NUMA node implicitly

Hi Igor, [...] +parse_numa_node(ms, , NULL); I get build break here: numa.c:451:13: error: too few arguments to function ‘parse_numa_node’ parse_numa_node(ms, , NULL); In upstream tree, your commit cc001888b780 ("numa: fixup parsed NumaNodeOptions earlier")

[Qemu-devel] [PATCH v6] NUMA: Enable adding NUMA node implicitly

: switch to SWIOTLB DMA ops, to bounce DMA transfers to 32bit allocated buffers that legacy drivers/hw can handle. [Rewritten by Igor] Reported-by: Thadeu Lima de Souza Cascardo <casca...@canonical.com> Suggested-by: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Dou Liy

Re: [Qemu-devel] [PATCH v5] NUMA: Enable adding NUMA node implicitly

Hi Michael, [...] Seems to cause build failures: /scm/qemu/numa.c:452:13: error: too many arguments to function ‘parse_numa_node’ parse_numa_node(ms, , NULL, NULL); Yes, commit cc001888b780 ("numa: fixup parsed NumaNodeOptions earlier") removed a argument from the function

[Qemu-devel] [PATCH v5] NUMA: Enable adding NUMA node implicitly

: switch to SWIOTLB DMA ops, to bounce DMA transfers to 32bit allocated buffers that legacy drivers/hw can handle. [Rewritten by Igor] Reported-by: Thadeu Lima de Souza Cascardo <casca...@canonical.com> Suggested-by: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Dou Liy

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

Deer Eduardo, At 10/26/2017 04:02 PM, Eduardo Habkost wrote: Hi, Sorry for taking so long to review it: Not matter. It's my honor! On Mon, Oct 23, 2017 at 09:33:42AM +0800, Dou Liyang wrote: [...] + */ +if (ram_slots > 0 && QTAILQ_EMPTY(_opts->head)) { +

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

Hi, Fam At 10/23/2017 09:37 AM, no-re...@patchew.org wrote: Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 1508722422-3861-1-git-send-email-douly.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

Hi Fam, At 10/23/2017 09:37 AM, no-re...@patchew.org wrote: Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id:

[Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

: switch to SWIOTLB DMA ops, to bounce DMA transfers to 32bit allocated buffers that legacy drivers/hw can handle. [Rewritten by Igor] Reported-by: Thadeu Lima de Souza Cascardo <casca...@canonical.com> Suggested-by: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Dou Liy

Re: [Qemu-devel] [PATCH] ACPI/unit-test: Add a testcase for RAM allocation in numa node

Hi Eduardo, Thanks for your reply. At 10/21/2017 03:15 AM, Eduardo Habkost wrote: On Wed, Oct 18, 2017 at 11:50:32AM +0800, Dou Liyang wrote: At 10/18/2017 11:48 AM, Dou Liyang wrote: As QEMU supports the memory-less node, it is possible that there is no RAM in the first numa node(also

Re: [Qemu-devel] [PATCH v3] NUMA: Enable adding NUMA node implicitly

Hi Igor, diff --git a/vl.c b/vl.c index 9bb5058..d083b4d 100644 --- a/vl.c +++ b/vl.c @@ -4665,7 +4665,11 @@ int main(int argc, char **argv, char **envp) default_drive(default_floppy, snapshot, IF_FLOPPY, 0, FD_OPTS); default_drive(default_sdcard, snapshot, IF_SD, 0, SD_OPTS); -

Re: [Qemu-devel] [PATCH v3] NUMA: Enable adding NUMA node implicitly

Hi all, It seems that a month has passed So, Ping... Thanks, dou. At 09/21/2017 05:23 PM, Dou Liyang wrote: Linux and Windows need ACPI SRAT table to make memory hotplug work properly, however currently QEMU doesn't create SRAT table if numa options aren't present on CLI. Which

Re: [Qemu-devel] [PATCH] ACPI/unit-test: Add a testcase for RAM allocation in numa node

At 10/18/2017 11:48 AM, Dou Liyang wrote: As QEMU supports the memory-less node, it is possible that there is no RAM in the first numa node(also be called as node0). eg: ... \ -m 128,slots=3,maxmem=1G \ -numa node -numa node,mem=128M \ But, this makes it hard for QEMU to build a known

[Qemu-devel] [PATCH] ACPI/unit-test: Add a testcase for RAM allocation in numa node

it is not enough. Add a testcase for this situation to make sure the ACPI table is correct for guest. Suggested-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- Changelog: This patch can pass the 'make check' in Peter's machine, Bu

Re: [Qemu-devel] [PULL 0/9] x86 and machine queue, 2017-10-05

Hi Peter, At 10/10/2017 08:56 PM, Peter Maydell wrote: On 10 October 2017 at 13:52, Eduardo Habkost wrote: This shouldn't happen if CONFIG_IASL is not defined. Did you run configure again after removing iasl? I've neither added nor removed iasl from the build systems

Re: [Qemu-devel] [PULL 0/9] x86 and machine queue, 2017-10-05

Hi Peter, At 10/10/2017 05:40 PM, Peter Maydell wrote: On 10 October 2017 at 08:41, Dou Liyang <douly.f...@cn.fujitsu.com> wrote: If we want do the "bios-tables-test", we need iasl support. otherwise, when I run "make V=1 check" without iasl, the test will report err

Re: [Qemu-devel] [PULL 0/9] x86 and machine queue, 2017-10-05

Hi Eduardo, At 10/10/2017 08:52 PM, Eduardo Habkost wrote: This shouldn't happen if CONFIG_IASL is not defined. Did you run configure again after removing iasl? Oops, Yes, the result above is in CONFIG_IASL = iasl. :-( I have been aware of this problem. I am waiting the result of the test

Re: [Qemu-devel] [PULL 0/9] x86 and machine queue, 2017-10-05

Hi Eduardo, I couldn't reproduce the failure too. But, I have some concern below. At 10/06/2017 11:37 PM, Peter Maydell wrote: On 6 October 2017 at 16:27, Eduardo Habkost wrote: On Fri, Oct 06, 2017 at 01:17:42PM +0100, Peter Maydell wrote: This fails tests, I'm afraid:

Re: [Qemu-devel] [PATCH v6 2/4] hw/acpi-build: Make assignment statement of next_base easy to read

Hi Eduardo, At 10/10/2017 10:29 AM, Eduardo Habkost wrote: On Fri, Sep 01, 2017 at 10:10:03AM +0800, Dou Liyang wrote: It may be hard to read the assignment statement of "next_base", so S/next_base += (1ULL << 32) - pcms->below_4g_mem_size; /next_base =

[Qemu-devel] [PATCH v3] NUMA: Enable adding NUMA node implicitly

: switch to SWIOTLB DMA ops, to bounce DMA transfers to 32bit allocated buffers that legacy drivers/hw can handle. [Rewritten by Igor] Reported-by: Thadeu Lima de Souza Cascardo <casca...@canonical.com> Suggested-by: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Dou Liy

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

Hi Igor, At 09/21/2017 03:54 PM, Igor Mammedov wrote: On Thu, 21 Sep 2017 12:19:17 +0800 [...] I've meant something like that: parse_numa_opts() { if (mc->auto_enable_numa_with_memhp == true) { qemu_opts_parse_noisily(qemu_find_opts("numa"), "node", true); } } Oops,

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

Hi Igor, I am sorry I missed some comments you gave to me. my reply is below. At 09/18/2017 05:24 PM, Dou Liyang wrote: [...] ranges where *the guest will attempt to probe for a device that QEMU doesn't *implement and a stub device is required. + * @numa_implicit_add_node0

[Qemu-devel] [PATCH v2] NUMA: Enable adding NUMA node implicitly

* Linux: switch to SWIOTLB DMA ops, to bounce DMA transfers to 32bit allocated buffers that legacy drivers/hw can handle. [Rewritten by Igor] Reported-by: Thadeu Lima de Souza Cascardo <casca...@canonical.com> Suggested-by: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Dou Liy

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

Hi Igor, At 09/18/2017 05:08 PM, Igor Mammedov wrote: On Fri, 15 Sep 2017 16:33:18 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table for transfering NUMA configuration to the guest. So, the maximum memory in SR

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

At 09/18/2017 03:40 PM, Igor Mammedov wrote: On Mon, 18 Sep 2017 11:54:50 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: At 09/15/2017 06:05 PM, Dou Liyang wrote: Hi Daniel, At 09/15/2017 04:40 PM, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

At 09/15/2017 06:05 PM, Dou Liyang wrote: Hi Daniel, At 09/15/2017 04:40 PM, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote: In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table for transfering NUMA configuration to the guest. So

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

Hi Daniel, At 09/15/2017 04:40 PM, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote: In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table for transfering NUMA configuration to the guest. So, the maximum memory in SRAT can be used

[Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

sca...@canonical.com> Suggested-by: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> Cc: Paolo Bonzini <pbonz...@redhat.com> Cc: Richard Henderson <r...@twiddle.net> Cc: Eduardo Habkost <ehabk...@redhat.com> Cc: "Michael

Re: [Qemu-devel] [PATCH] x86/acpi: build SRAT when memory hotplug is enabled

Hi Igor, At 09/11/2017 06:58 PM, Igor Mammedov wrote: > > > > Igor's suggestion to enable NUMA implicitly sounds safer to me. > > > > I agree with Igor too. > > Is anybody doing this? If not, may I make a patch to enable adding NUMA > node implicitly first. let's see what it looks like. As

Re: [Qemu-devel] [PATCH V5 1/3] net/colo-compare.c: Optimize unpredictable tcp options comparison

Hi Chen, At 09/04/2017 02:14 PM, Zhang Chen wrote: When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same, but the two packet's payload is identical. colo just care about packet payload, so we skip the

Re: [Qemu-devel] [PATCH] x86/acpi: build SRAT when memory hotplug is enabled

Hi Eduardo, At 09/04/2017 09:08 PM, Eduardo Habkost wrote: [...] In my opinion, this may also add the hotpluggable memory, and see the following commemts. /* * Entry is required for Windows to enable memory hotplug in OS * and for Linux to enable SWIOTLB when booted with less

Re: [Qemu-devel] [PATCH v5 1/3] hw/acpi-build: Fix SRAT memory building in case of node 0 without RAM

Hi Igor, At 09/04/2017 07:11 PM, Igor Mammedov wrote: [...] +if (mem_base <= HOLE_640K_START && +next_base > HOLE_640K_START) { +mem_len -= next_base - HOLE_640K_START; +if (mem_len > 0) { +numamem = acpi_data_push(table_data, sizeof

Re: [Qemu-devel] [PATCH v5 1/3] hw/acpi-build: Fix SRAT memory building in case of node 0 without RAM

At 09/04/2017 05:39 PM, Igor Mammedov wrote: On Thu, 31 Aug 2017 20:04:26 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: From: Eduardo Habkost <ehabk...@redhat.com> Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example

Re: [Qemu-devel] [PATCH V4 1/3] net/colo-compare.c: Optimize unpredictable tcp options comparison

Hi Chen, At 09/02/2017 12:02 AM, Zhang Chen wrote: On 09/01/2017 05:35 PM, Dou Liyang wrote: Hi chen, At 08/21/2017 04:55 PM, Zhang Chen wrote: When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same

Re: [Qemu-devel] [PATCH] x86/acpi: build SRAT when memory hotplug is enabled

_memory.base, hotplugabble_address_space_size, pcms->numa_nodes - 1, MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED); } Thanks, dou. Once we apply the "Fix SRAT memory building in case of node 0 without RAM" patch from Dou Liyang, no memory affinity

Re: [Qemu-devel] [PATCH V4 1/3] net/colo-compare.c: Optimize unpredictable tcp options comparison

Hi chen, At 08/21/2017 04:55 PM, Zhang Chen wrote: When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same, but the two packet's payload is identical. colo just care about packet payload, so we skip the

[Qemu-devel] [PATCH v6 3/4] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

it is not enough. Add a testcase for this situation to make sure the ACPI table is correct for guest. Suggested-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- tests/acpi-test-data/pc/DSDT.numamem | Bin 0 -> 5104 bytes tests/ac

[Qemu-devel] [PATCH v6 4/4] NUMA: Replace MAX_NODES with nb_numa_nodes in for loop

eep code consistency and reduce the loop times. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> Reviewed-by: Igor Mammedov <imamm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[Qemu-devel] [PATCH v6 0/4]ACPI: NUMA: Fix ACPI SRAT Memory Affinity building

testcase. This patchset fixs an ACPI building bug which caused by no RAM in the first NUAM node. and also add a new testcase for the bug. Dou Liyang (3): hw/acpi-build: Make assignment statement of next_base easy to read ACPI/unit-test: Add a new testcase for RAM allocation in numa node NUMA

[Qemu-devel] [PATCH v6 1/4] hw/acpi-build: Fix SRAT memory building in case of node 0 without RAM

ave no memory. Fix this problem by cut out the 640K hole in the same way the PCI 4G hole does. Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- hw/i386/acpi-build.c | 28 ++-- 1 file changed, 22 inse

[Qemu-devel] [PATCH v6 2/4] hw/acpi-build: Make assignment statement of next_base easy to read

It may be hard to read the assignment statement of "next_base", so S/next_base += (1ULL << 32) - pcms->below_4g_mem_size; /next_base = mem_base + mem_len; ... for readability. No functionality change. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- hw/i3

Re: [Qemu-devel] [PATCH v5 1/3] hw/acpi-build: Fix SRAT memory building in case of node 0 without RAM

Hi, Eduardo At 09/01/2017 05:36 AM, Eduardo Habkost wrote: On Thu, Aug 31, 2017 at 08:04:26PM +0800, Dou Liyang wrote: From: Eduardo Habkost <ehabk...@redhat.com> Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ...

Re: [Qemu-devel] [PATCH v4 1/2] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

Hi Eduardo, At 08/31/2017 06:38 PM, Dou Liyang wrote: Hi Eduardo, [...] +continue; } Now the nodes will be out of order, if node 0 has no RAM. Why? Because the code parsed the other node with RAM first, then parsed the node 0. Why not implement this in the same

[Qemu-devel] [PATCH v5 1/3] hw/acpi-build: Fix SRAT memory building in case of node 0 without RAM

ave no memory. Fix this problem by cut out the 640K hole in the same way the PCI 4G hole does. Also do some cleanup. Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- hw/i386/acpi-build.c | 30 +++---

[Qemu-devel] [PATCH v5 2/3] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

it is not enough. Add a testcase for this situation to make sure the ACPI table is correct for guest. Suggested-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- tests/acpi-test-data/pc/DSDT.numamem | Bin 0 -> 5104 bytes tests/ac

[Qemu-devel] [PATCH v5 0/3] hw/acpi-build: Fix ACPI SRAT Memory Affinity building

no RAM in the first NUAM node. and also add a new testcase for the bug. Dou Liyang (2): ACPI/unit-test: Add a new testcase for RAM allocation in numa node NUMA: Replace MAX_NODES with nb_numa_nodes in for loop Eduardo Habkost (1): hw/acpi-build: Fix SRAT memory building in case of node 0 without RA

[Qemu-devel] [PATCH v5 3/3] NUMA: Replace MAX_NODES with nb_numa_nodes in for loop

eep code consistency and reduce the loop times. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> Reviewed-by: Igor Mammedov <imamm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [Qemu-devel] [PATCH v4 1/2] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

Hi Eduardo, [...] +continue; } Now the nodes will be out of order, if node 0 has no RAM. Why? Because the code parsed the other node with RAM first, then parsed the node 0. Why not implement this in the same way the PCI 4GB hole is already implemented. e.g.:

[Qemu-devel] [PATCH v5 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

it is not enough. Add a testcase for this situation to make sure the ACPI table is correct for guest. Suggested-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- v4 --> v5: - rewrite the testcase. - Drop the SLIT date tests/ac

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

Hi Igor, At 08/24/2017 08:33 PM, Igor Mammedov wrote: > test_acpi_one(" -numa node -numa node,mem=128", ); > > but, the DSDT didn't match the default one. because, if we support > NUMA, the DSDT will give us "_PXM" to map the CPU to node. Ok, looks like you'll have to include your variant of

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

Hi Igor, At 08/24/2017 01:47 AM, Igor Mammedov wrote: On Wed, 23 Aug 2017 21:35:29 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: Hi Igor, At 08/23/2017 08:45 PM, Igor Mammedov wrote: On Wed, 23 Aug 2017 20:12:51 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: Hi Igo

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

Hi Eduardo, At 08/24/2017 01:25 AM, Eduardo Habkost wrote: On Wed, Aug 23, 2017 at 09:35:29PM +0800, Dou Liyang wrote: Hi Igor, At 08/23/2017 08:45 PM, Igor Mammedov wrote: On Wed, 23 Aug 2017 20:12:51 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: Hi Igor, At 08/23/2017 04

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

Hi Igor, At 08/23/2017 08:45 PM, Igor Mammedov wrote: On Wed, 23 Aug 2017 20:12:51 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: Hi Igor, At 08/23/2017 04:40 PM, Igor Mammedov wrote: On Tue, 22 Aug 2017 11:24:10 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: As Q

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

Hi Igor, At 08/23/2017 04:40 PM, Igor Mammedov wrote: On Tue, 22 Aug 2017 11:24:10 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: As QEMU supports the memory-less node, it is possible that there is no RAM in the first numa node(also be called as node0). eg: ... \ -m 128,s

Re: [Qemu-devel] [PATCH v4 0/2] hw/acpi-build: Fix ACPI SRAT Memory Affinity building

Hi Michael, At 08/23/2017 10:48 AM, Michael S. Tsirkin wrote: On Tue, Aug 22, 2017 at 11:24:08AM +0800, Dou Liyang wrote: V3 --> v4: -add a new testcase. This patchset fixs an ACPI building bug which caused by no RAM in the first NUAM node. and also add a new testcase for the bug. tha

[Qemu-devel] [PATCH] NUMA: Replace MAX_NODES with nb_numa_nodes in for loop

eep code consistency and reduce the loop times. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/numa.c b/numa.c index e32af04..5f2916d 100644 --- a/numa.c +++ b/numa.c @@ -567,7 +567,

[Qemu-devel] [PATCH v4 1/2] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

ith the first node which has memory on it. Add a new function for each node. Also do some cleanup. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- hw/i386/acpi-build.c | 78 +--- 1 file changed, 50 insertions(+), 28 deletions(-) diff -

[Qemu-devel] [PATCH v4 0/2] hw/acpi-build: Fix ACPI SRAT Memory Affinity building

V3 --> v4: -add a new testcase. This patchset fixs an ACPI building bug which caused by no RAM in the first NUAM node. and also add a new testcase for the bug. Dou Liyang (2): hw/acpi-build: Fix SRAT memory building when there is no memory in node0 ACPI/unit-test: Add a new testc

[Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

it is not enough. Add a testcase for this situation to make sure the ACPI table is correct for guest. Suggested-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- tests/acpi-test-data/pc/DSDT.numamem | Bin 0 -> 6463 bytes tests/ac

Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

Hi, Igor [...] Ok, I will do it right now. see commit 6b9c1dd2c for example of adding test case, currently test has base SRAT tables that is reused by all tests. When you create testcase that produces different SRAT table, 'make check' will print warnings that ables do not match you can add

Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

Hi Eduardo, At 08/19/2017 12:48 AM, Eduardo Habkost wrote: On Thu, Aug 17, 2017 at 01:58:40PM +0800, Dou Liyang wrote: Hi Igor, I tested this patch with following guests: 1. RHEL 6.5 with Linux 2.6.32 2. RHEL 7.0 with Linux 3.10.0 3. Fedora 23 with Linux 4.13.0-rc5 4. window 2003 service 5

Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

Hi Igor, I tested this patch with following guests: 1. RHEL 6.5 with Linux 2.6.32 2. RHEL 7.0 with Linux 3.10.0 3. Fedora 23 with Linux 4.13.0-rc5 4. window 2003 service 5. window 7 6. window 10 Thanks, dou. At 08/16/2017 09:45 AM, Dou Liyang wrote: Currently, Using the fisrt node

Re: [Qemu-devel] [PATCH v2] hw/acpi: Select an node with memory for mapping memory hole to

Hi Igor, At 08/16/2017 05:18 PM, Igor Mammedov wrote: On Wed, 16 Aug 2017 09:26:51 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxm

[Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

ith the first node which has memory on it. Add a new function for each node. Also do some cleanup. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- V3 --> V2 -Modify the title V2 --> V1: -Fix a coding style problem Replace for (node = 0; node < pcms->nu

[Qemu-devel] [PATCH v2] hw/acpi: Select an node with memory for mapping memory hole to

ith the first node which has memory on it. Add a new function for each node. Also do some cleanup. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- V2 --> V1: -Fix a coding style problem Replace for (node = 0; node < pcms->numa_nodes && pcms-&g

Re: [Qemu-devel] [PATCH] numa: Add a check whether the node0 has memory or not

Hi Igor, At 08/15/2017 04:04 PM, Igor Mammedov wrote: On Tue, 15 Aug 2017 09:26:46 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: Hi Eduardo, At 08/14/2017 08:44 PM, Eduardo Habkost wrote: On Mon, Aug 14, 2017 at 06:11:11PM +0800, Dou Liyang wrote: Currently, Using the fisr

[Qemu-devel] [PATCH] hw/acpi: Select an node with memory for mapping memory hole to

ith the first node which has memory on it. Add a new function for each node. Also do some cleanup. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- hw/i386/acpi-build.c | 76 +--- 1 file changed, 48 insertions(+), 28 deletions(-) diff -

Re: [Qemu-devel] [PATCH] numa: Add a check whether the node0 has memory or not

Hi Eduardo, At 08/14/2017 08:44 PM, Eduardo Habkost wrote: On Mon, Aug 14, 2017 at 06:11:11PM +0800, Dou Liyang wrote: Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0

Re: [Qemu-devel] [PATCH] numa: Add a check whether the node0 has memory or not

I'm sorry, forgot to cc Michael S. Tsirkin At 08/14/2017 06:11 PM, Dou Liyang wrote: Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1

[Qemu-devel] [PATCH] numa: Add a check whether the node0 has memory or not

ation found" and the NUMA topology is wrong. This is because when QEMU builds ACPI SRAT, it regards node0 as the default node to deal with the memory hole(640K-1M). this means the node0 must have some memory(>1M) firstly. Add a check in parse_numa_opts to avoid this situation. Signed-off-b

Re: [Qemu-devel] Memory Hotplug : Does QEmu support cold-plugged memory?

Hi Igor, At 06/05/2017 04:45 PM, Igor Mammedov wrote: On Mon, 5 Jun 2017 15:53:02 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: Hi all, I want to boot up a system with some removable memory. So, i used '-object' and '-device' to cold-plug memory in QEmu as following : ./

[Qemu-devel] Memory Hotplug : Does QEmu support cold-plugged memory?

Hi all, I want to boot up a system with some removable memory. So, i used '-object' and '-device' to cold-plug memory in QEmu as following : ./x86_64-softmmu/qemu-system-x86_64 \ ... -object memory-backend-ram,id=mem3,size=128M \ -device pc-dimm,id=dimm3,memdev=mem3 \

Re: [Qemu-devel] [PATCH v4 2/2] block/qapi: reduce the execution time of qmp_query_blockstats

Hi, Max At 02/01/2017 11:02 AM, Max Reitz wrote: On 15.01.2017 09:01, Dou Liyang wrote: In order to reduce the execution time, this patch optimize the qmp_query_blockstats(): Remove the next_query_bds function. Remove the bdrv_query_stats function. Remove some judgement sentence. The original

[Qemu-devel] [PATCH v3] vl: Move the cpu_synchronize_all_post_init() after generic devices initialization

e CPUs may be ignored to synchronize. The patch moves the cpu_synchronize_all_post_init func after generic devices initialization to make sure that all the CPUs can be included. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- Change log: v2-> v3: 1. Rebase the patch. 2. Rewrite the lo

Re: [Qemu-devel] [PATCH v2] vl: Ensure the cpu_synchronize_all_post_init() in the appropriate location

Hi, Alex Sorry for late reply. At 01/27/2017 10:03 PM, Alex Bennée wrote: Dou Liyang <douly.f...@cn.fujitsu.com> writes: At the Qemu initialization, we call the cpu_synchronize_all_post_init() to synchronize All CPU states to KVM in the ./vl.c::main(). Currently, it is called bef

Re: [Qemu-devel] [PATCH v4 0/2] block/qapi: refactor and optimize the qmp_query_blockstats()

Hi, Markus Here is the non-RFC patch. Any suggestions are welcome. :) Thanks, Liyang. At 01/15/2017 04:01 PM, Dou Liyang wrote: Change log v3 -> v4: 1. Develop these into the non-RFC patches. 2. Fix some comments. 3. do declarations first. Change log v2 -> v3: 1.

Re: [Qemu-devel] [RFC 05/13] pc: move pcms->possible_cpus init out of pc_cpus_init()

At 01/19/2017 01:13 AM, Igor Mammedov wrote: possible_cpus could be initialized earlier then cpu objects, s/then/than/ i.e. when -smp is parsed so move init code to possible_cpu_arch_ids() [...]

Re: [Qemu-devel] [PATCH 0/3] cpu: numa: Fix the mapping initialization of VCPUs and NUMA nodes

Hi, Eduardo At 01/19/2017 01:06 AM, Eduardo Habkost wrote: On Wed, Jan 18, 2017 at 09:26:36PM +0800, Dou Liyang wrote: Hi, All ** ERROR:/tmp/qemu-test/src/tests/vhost-user-test.c:668:test_migrate: assertion failed: (qdict_haskey(rsp, "return")) GTester: last r

Re: [Qemu-devel] [PATCH 0/3] cpu: numa: Fix the mapping initialization of VCPUs and NUMA nodes

Hi, Igor, At 01/18/2017 09:46 PM, Igor Mammedov wrote: On Wed, 18 Jan 2017 20:40:04 +0800 Dou Liyang <douly.f...@cn.fujitsu.com> wrote: As we fixed a bug(Bug 1) in below links, Named "Method-A": https://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg03354.html Then,

[Qemu-devel] [PATCH v2] vl: Ensure the cpu_synchronize_all_post_init() in the appropriate location

atch moves the numa_post_machine_init func in the appropriate location to make sure that all the CPUs has already been created when it is called. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- Change log v1-> v2: 1. Split it from https://lists.nongnu.org/archive/html/qemu-devel/2017

Re: [Qemu-devel] [PATCH 0/3] cpu: numa: Fix the mapping initialization of VCPUs and NUMA nodes

Hi, All ** ERROR:/tmp/qemu-test/src/tests/vhost-user-test.c:668:test_migrate: assertion failed: (qdict_haskey(rsp, "return")) GTester: last random seed: R02Sf52546c4daff8087416f43fa7c146db8 ftruncate: Permission denied ftruncate: Permission denied qemu-system-aarch64:

Re: [Qemu-devel] [PATCH 1/3] cpu: Make the mapping of CPUs and NUMA nodes in cpu_common_realizefn

Hi, Eduardo At 01/18/2017 08:56 PM, Eduardo Habkost wrote: On Wed, Jan 18, 2017 at 08:40:05PM +0800, Dou Liyang wrote: Current default way of seting the CPUState::numa_node might be wrong in case on cold/hot-plug CPUs. Making the users confused why the NUMA info is different beetween

[Qemu-devel] [PATCH 3/3] cpu: make the function of cpu_common_map_numa_node more efficiently

Current function does some unnecessary operations, such as it makes the assert() in the loop, and the loop was not stopped in time. This patch moves the assert() out the loop and stops the loop in time. Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- qom/cpu.c | 3 ++- 1 file c

  1   2   >