nt, int
> > format, int wsize,
> > case 8:
> > v = ldq_p(buf + i);
> > break;
> > +default:
> > + v = ldub_p(buf + i);
> > +break;
> > }
> >
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Thu, Sep 19, 2024 at 12:26:33AM +0100, d...@treblig.org wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > socket_remote_address hasn't been used since it was added in
> > 17c55decec ("sockets
* Yichen Wang (yichen.w...@bytedance.com) wrote:
> On Fri, Oct 11, 2024 at 10:14 AM Dr. David Alan Gilbert
> wrote:
> >
> > * Yichen Wang (yichen.w...@bytedance.com) wrote:
> > > From: Hao Xiang
> >
> > Please split the cpuid stuff out into a separate p
ationThread, 1);
> - thread->name = name;
> -thread->thread_id = thread_id;
> -
> -WITH_QEMU_LOCK_GUARD(&migration_threads_lock) {
> -QLIST_INSERT_HEAD(&migration_threads, thread, node);
> -}
> -
> -return thread;
> -}
> -
> -void migration_threads_remove(MigrationThread *thread)
> -{
> -QEMU_LOCK_GUARD(&migration_threads_lock);
> -if (thread) {
> -QLIST_REMOVE(thread, node);
> -g_free(thread);
> -}
> -}
> -
> -MigrationThreadInfoList *qmp_query_migrationthreads(Error **errp)
> -{
> -MigrationThreadInfoList *head = NULL;
> -MigrationThreadInfoList **tail = &head;
> -MigrationThread *thread = NULL;
> -
> -QEMU_LOCK_GUARD(&migration_threads_lock);
> -QLIST_FOREACH(thread, &migration_threads, node) {
> -MigrationThreadInfo *info = g_new0(MigrationThreadInfo, 1);
> -info->name = g_strdup(thread->name);
> -info->thread_id = thread->thread_id;
> -
> -QAPI_LIST_APPEND(tail, info);
> -}
> -
> -return head;
> -}
> diff --git a/migration/meson.build b/migration/meson.build
> index 66d3de86f0..28a680e5e2 100644
> --- a/migration/meson.build
> +++ b/migration/meson.build
> @@ -29,7 +29,6 @@ system_ss.add(files(
>'savevm.c',
>'socket.c',
>'tls.c',
> - 'threadinfo.c',
> ), gnutls, zlib)
>
> if get_option('replication').allowed()
> --
> 2.45.0
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
only has effect if the @mapped-ram capability is enabled.
> # (Since 9.1)
> @@ -1270,7 +1293,8 @@
> '*vcpu-dirty-limit': 'uint64',
> '*mode': 'MigMode',
> '*zero-page-detection':
d having this much extra code for each one?
Dave
>
> Thanks,
>
> --
> Peter Xu
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
> build currently breaks when compiling with "--enable-werror". Remove
> the unused functions to get it going again.
>
> Fixes: 95b9c27c81 ("linux-user: Remove unused handle_vm86_fault")
> Signed-off-by: Thomas Huth
Sorry about that - thanks for the f
* Michael Tokarev (m...@tls.msk.ru) wrote:
> 19.09.2024 01:51, d...@treblig.org wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > net_rx_pkt_get_l3_hdr_offset and net_rx_pkt_get_iovec_len haven't
> > been used since they were added.
> >
> >
r = qdict_haskey(qdict, "virt") ? &filter_addr : NULL;
> +
I'm a bit confused about the format of the parameter you're trying to use;
can you add an example in the commit message please.
> env = mon_get_cpu_env(mon);
> if (!env) {
> moni
* Peter Xu (pet...@redhat.com) wrote:
> The QMP command was added in 671326201d ("migration: Introduce interface
> query-migrationthreads", v8.0). Add the HMP version of it.
>
> Cc: Markus Armbruster
> Cc: Dr. David Alan Gilbert
> Signed-off-by: Peter Xu
&g
* Peter Xu (pet...@redhat.com) wrote:
> On Thu, Sep 19, 2024 at 02:46:25PM +0100, d...@treblig.org wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Use the uffd_copy_page, uffd_zero_page and uffd_wakeup helpers
> > rather than calling ioctl ourselves.
>
* Bernhard Beschow (shen...@gmail.com) wrote:
>
>
> Am 18. September 2024 00:51:32 UTC schrieb d...@treblig.org:
> >From: "Dr. David Alan Gilbert"
> >
> >mch_mcfg_base has been unused since it was added by
> > 6f1426ab0f ("ich9: APIs
; Jag
>
> > On Sep 18, 2024, at 1:00 PM, Dr. David Alan Gilbert
> > wrote:
> >
> > Hi Jag,
> > One of my scripts noticed that 'remote_iohub_finalize' in
> > hw/remote/iohub.c is unused; before I go and delete it as deadcode,
> > is that actu
* d...@treblig.org (d...@treblig.org) wrote:
> From: "Dr. David Alan Gilbert"
>
> qemu_clock_get_main_loop_timerlist has been unused since it was
> originally added in
> ff83c66ecc ("aio / timers: Split QEMUClock into QEMUClock and
> QEMUTimerList")
* Fabiano Rosas (faro...@suse.de) wrote:
> Markus Armbruster writes:
>
> > Peter Xu writes:
> >
> >> On Wed, Sep 18, 2024 at 07:52:56AM +0200, Markus Armbruster wrote:
> >>> d...@treblig.org writes:
> >>>
> >>> > From: "
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Thu, Sep 19, 2024 at 01:00:34AM +0100, d...@treblig.org wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > qio_channel_socket_dgram_async has been unused since it was originally
> > added in 2015.
> &
Hi Jag,
One of my scripts noticed that 'remote_iohub_finalize' in
hw/remote/iohub.c is unused; before I go and delete it as deadcode,
is that actually just a missing call somewhere?
Dave
--
-Open up your eyes, open up your mind, open up your code -------
/ Dr. David Al
l;
> +}
> +
> /**
> * qdict_get_try_bool(): Try to get a bool mapped by 'key'
> *
> diff --git a/system/cpus.c b/system/cpus.c
> index 5e3a988a0a..25d7d7c93f 100644
> --- a/system/cpus.c
> +++ b/system/cpus.c
> @@ -792,7 +792,34 @@ int vm_stop_fo
;
> +bool nested;
>
> -env = mon_get_cpu_env(mon);
> -if (!env) {
> -monitor_printf(mon, "No CPU available\n");
> +if (!cs) {
> +monitor_printf(mon, "Unable to get CPUState. Internal error\n");
I wouldn't bother saying &
malloc_trim() you propose interact with this one?
>
> The above usage is automatic, while this proposal requires that
> an external mgmt app monitor QEMU and tell it to free memory.
> I'm wondering if the latter is really desirable, or whether QEMU
> can call this itself when reasonable ?
>
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o-https://fstop138.berrange.com :|
> |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
ector;
> +u16 guest_intr_status;
> +u16 host_es_selector;
> +u16 host_cs_selector;
> +u16 host_ss_selector;
> +u16 host_ds_selector;
> + u16 host_fs_selector;
> +u16 host_gs_selector;
> +u16 ho
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Markus Armbruster (arm...@redhat.com) wrote:
> >> Philippe Mathieu-Daudé writes:
> >>
> >> > Hi Daniel, Dave, Markus & Thomas.
> >> >
* Pierrick Bouvier (pierrick.bouv...@linaro.org) wrote:
> On 6/17/24 13:56, Dr. David Alan Gilbert wrote:
> > * Pierrick Bouvier (pierrick.bouv...@linaro.org) wrote:
> > > On 6/14/24 15:00, Dr. David Alan Gilbert wrote:
> > > > * Pierrick Bouvier (pierrick.bouv...@l
* Pierrick Bouvier (pierrick.bouv...@linaro.org) wrote:
> On 6/14/24 15:00, Dr. David Alan Gilbert wrote:
> > * Pierrick Bouvier (pierrick.bouv...@linaro.org) wrote:
> > > Hi Dave,
> > >
> > > On 6/12/24 14:02, Dr. David Alan Gilbert wrote:
> > > &
* Martin Joerg (martin.jo...@gmail.com) wrote:
> Signed-off-by: Martin Joerg
Thanks!
(Trivial please take that).
Reviewed-by: Dr. David Alan Gilbert
> ---
> hmp-commands-info.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hmp-commands-info
* Pierrick Bouvier (pierrick.bouv...@linaro.org) wrote:
> Hi Dave,
>
> On 6/12/24 14:02, Dr. David Alan Gilbert wrote:
> > * Alex Bennée (alex.ben...@linaro.org) wrote:
> > > From: Pierrick Bouvier
> > >
> > > This plugin uses the new time control i
> +time_handle = qemu_plugin_request_time_control();
> +g_assert(time_handle);
> +
> +qemu_plugin_register_vcpu_tb_trans_cb(id, vcpu_tb_trans);
> +qemu_plugin_register_vcpu_init_cb(id, vcpu_init);
> +qemu_plugin_register_vcpu_exit_cb(id, vcpu_exit);
> +qemu_plugin_register_atexit_cb(id, plugin_exit, NULL);
> +
> +return 0;
> +}
> diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile
> index 0b64d2c1e3..449ead1130 100644
> --- a/contrib/plugins/Makefile
> +++ b/contrib/plugins/Makefile
> @@ -27,6 +27,7 @@ endif
> NAMES += hwprofile
> NAMES += cache
> NAMES += drcov
> +NAMES += ips
>
> ifeq ($(CONFIG_WIN32),y)
> SO_SUFFIX := .dll
> --
> 2.39.2
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
or host memory addresses).
It's also hopelessly cryptic.
From an HMP point, a 'info debug ' seems good to me,
possibly with some options as to whether to recurse or perhaps
add flags to 'info qtree' to also call it.
Dave
> -- PMM
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
mp-target.c
> index 1eb72ac1bf..0466474354 100644
> --- a/monitor/hmp-target.c
> +++ b/monitor/hmp-target.c
> @@ -36,11 +36,6 @@
> #include "qapi/error.h"
> #include "qemu/cutils.h"
>
> -#if defined(TARGET_S390X)
> -#include "hw/s390x/storage-keys.h"
> -#include "hw/s390x/storage-attributes.h"
> -#endif
> -
> /* Make devices configuration available for use in hmp-commands*.hx
> templates */
> #include CONFIG_DEVICES
>
> --
> 2.41.0
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
fo_ramblock() in commit ca411b7c8a ("qapi: introduce
> x-query-ramblock QMP command")
>
> and hmp_info_irq() in commit 91f2fa7045 ("qapi: introduce
> x-query-irq QMP command").
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
* Dr. David Alan Gilbert (d...@treblig.org) wrote:
> A bunch of structs that are currently unused,
> found with a simple script and a bit of eyeballing.
>
> The only one I'm that suspicious of is the SPARC
> one, where the patch which removed the use is a bit
> confu
* Peter Xu (pet...@redhat.com) wrote:
> Hey, Dave!
Hey!
> On Wed, Jun 05, 2024 at 12:31:56AM +0000, Dr. David Alan Gilbert wrote:
> > * Michael Galaxy (mgal...@akamai.com) wrote:
> > > One thing to keep in mind here (despite me not having any hardware to
> > > t
* Markus Armbruster (arm...@redhat.com) wrote:
> Philippe Mathieu-Daudé writes:
>
> > Hi Daniel, Dave, Markus & Thomas.
> >
> > On 4/6/24 06:58, Markus Armbruster wrote:
> >> "Dr. David Alan Gilbert" writes:
> >>> * Daniel P. Berrangé
provide good support and work together.
> > > > >
> > > > We are happy to provide the necessary review and maintenance work for
> > > > RDMA
> > > > if the community needs it.
> > > >
> > > > CC'ing Chuan Zheng.
r/monitor-internal.h
> >> @@ -168,7 +168,6 @@ extern bool qmp_dispatcher_co_shutdown;
> >> extern QmpCommandList qmp_commands, qmp_cap_negotiation_commands;
> >> extern QemuMutex monitor_lock;
> >> extern MonitorList mon_list;
> >> -ext
ckr.com/photos/dberrange :|
> |: https://libvirt.org -o-https://fstop138.berrange.com :|
> |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
* Thomas Huth (th...@redhat.com) wrote:
> On 31/05/2024 16.02, Dr. David Alan Gilbert wrote:
> > * Thomas Huth (th...@redhat.com) wrote:
> > > On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote:
> > > > We are trying to unify all qemu-system-FOO to a single binary.
>
> - env = mon_get_cpu_env(mon);
> -if (!env) {
> -monitor_printf(mon, "No CPU available\n");
> +CPUState *cs = mon_get_cpu(mon);
> +if (!cs) {
> +monitor_printf(mon, "Unable to get CPUState. Internal error\n");
> return;
> }
>
> -if (!(env->cr[0] & CR0_PG_MASK)) {
> -monitor_printf(mon, "PG disabled\n");
> +if (!init_iterator(mon, &state)) {
> return;
> }
> -if (env->cr[4] & CR4_PAE_MASK) {
> -#ifdef TARGET_X86_64
> -if (env->hflags & HF_LMA_MASK) {
> -if (env->cr[4] & CR4_LA57_MASK) {
> -tlb_info_la57(mon, env);
> -} else {
> -tlb_info_la48(mon, env, 0, env->cr[3] & 0x3f000ULL);
> -}
> -} else
> -#endif
> -{
> -tlb_info_pae32(mon, env);
> -}
> -} else {
> -tlb_info_32(mon, env);
> -}
> +
> +/**
> + * 'info tlb' visits only leaf PTEs marked present.
> + * It does not check other protection bits.
> + */
> +for_each_pte(cs, &mem_print_tlb, &state, false, false);
> }
>
> static void mem_print(Monitor *mon, CPUArchState *env,
> --
> 2.34.1
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
&& ent2prot(state->ent[height]) == prot
> + && (((state->last_offset[height] + 1) % entries_per_node)
> + == offset)
> + && ((!is_leaf)
> + || (!state->requi
al address
and then use that to associate some security; I think that's closer
to what MTE is isn't it?
I'm not sure the two fit in the same command.
Dave
> Or should it maybe rather be an option to the existing "dump-guest-memory"
> command i
; limited shm size under Gitlab CI. Now that it uses /tmp, enable it.
If it does fail, lets see if we can figure out how, i.e. whether it's the
shm size or something else.
Reviewed-by: Dr. David Alan Gilbert
> Cc: Yury Kotov
> Cc: Dr. David Alan Gilbert
> Signed-off-by: Nicho
* Dr. David Alan Gilbert (d...@treblig.org) wrote:
> This struct is unused since Peter's
> Commit b8ae597f0e6d ("linux-user/sparc: Fix errors in target_ucontext
> structures")
>
> However, hmm, I'm a bit confused since that commit modifies the
> structure and
* BALATON Zoltan (bala...@eik.bme.hu) wrote:
> On Sun, 5 May 2024, BALATON Zoltan wrote:
> > On Sun, 5 May 2024, Dr. David Alan Gilbert wrote:
> > > I think it's use was removed by
> > > Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32,
> >
* Richard Henderson (richard.hender...@linaro.org) wrote:
> On 5/5/24 10:14, Dr. David Alan Gilbert wrote:
> > The structs 'target_fpxreg' and 'target_xmmreg' are unused since
> > Paolo's:
> >
> > Commit 2796f290b546 ("linux-user: i3
This struct is unused since Peter's
Commit b8ae597f0e6d ("linux-user/sparc: Fix errors in target_ucontext
structures")
However, hmm, I'm a bit confused since that commit modifies the
structure and then removes it, was that intentional?
Signed-off-by: Dr. David Alan Gilbert
-
The structs 'target_fpxreg' and 'target_xmmreg' are unused since
Paolo's:
Commit 2796f290b546 ("linux-user: i386/signal: support FXSAVE fpstate on
32-bit emulation")
Signed-off-by: Dr. David Alan Gilbert
---
linux-user/i386/signal.c | 10 --
1 file c
Since 'setup_rt_frame' has never been implemented, this struct
is unused.
Signed-off-by: Dr. David Alan Gilbert
---
linux-user/cris/signal.c | 8
1 file changed, 8 deletions(-)
diff --git a/linux-user/cris/signal.c b/linux-user/cris/signal.c
index 4f532b2903..10948bcf30 10
u,arm-softmmu,aarch64-softmmu,cris-linux-user,i386-linux-user,sparc-linux-user
and 'make check' on x86 linux.
Dave
Dr. David Alan Gilbert (7):
linux-user: cris: Remove unused struct 'rt_signal_frame'
linux-user: i386/signal: Remove unused fp structs
linux-user: sp
As far as I can tell this struct has never been used in this
file (it is used in can_core.c).
Signed-off-by: Dr. David Alan Gilbert
---
net/can/can_host.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/net/can/can_host.c b/net/can/can_host.c
index a3c84028c6..b2fe553f91 100644
--- a
This struct has been unused since
Commit f932093ae165 ("hw/arm/bcm2836: Split out common part of BCM283X
classes")
Signed-off-by: Dr. David Alan Gilbert
---
hw/arm/bcm2836.c | 12
1 file changed, 12 deletions(-)
diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c
index
I think it's use was removed by
Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32,
64}_translate() path for get_phys_page_debug()")
Signed-off-by: Dr. David Alan Gilbert
---
target/ppc/mmu-hash32.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/target/ppc/m
As far as I can tell it was never used.
Signed-off-by: Dr. David Alan Gilbert
---
hw/usb/dev-network.c | 8
1 file changed, 8 deletions(-)
diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
index 2c33e36cad..d00d68b21d 100644
--- a/hw/usb/dev-network.c
+++ b/hw/usb/dev-network.c
ri*
> > +``migrate [-d]`` *uri*
> >Migrate to *uri* (using -d to not wait for completion).
> > -
> > - ``-b``
> > -for migration with full copy of disk
> > ERST
>
> Not this patch's fault, but here goes anyway: -r is undocumented here.
Probably one for Peter I guess.
Dave
> >
> > {
>
> [...]
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
r basically legacy reasons. And for the
> human monitor (HMP) we don't need to keep things around
> for backwards compatibility.
I'm not sure what happens for the (MIPS/SPARC ?) where it's not
a traditional table hierarchy.
The other thing you might want (and I'm
ory_mapping
>
> * tcg/sysemu/excp_helper.c: implements mmu_translate() and
> get_physical_address()
One thing to keep in mind (although I don't know the x86 code) is that
you want the monitor command not to change any state, nor to fail if
there's a particularly scre
* BALATON Zoltan (bala...@eik.bme.hu) wrote:
> On Sun, 24 Mar 2024, Dr. David Alan Gilbert wrote:
> > * Philippe Mathieu-Daudé (phi...@linaro.org) wrote:
> > > Replace qemu_printf() by monitor_printf() / monitor_puts() in monitor.
> > >
> > > S
uot;S"); /* Supervisor */
> +monitor_puts(mon, "S"); /* Supervisor */
> } else {
> -qemu_printf(".");
> +monitor_puts(mon, ".");
> }
> if (env->mmu.mmusr & M68K_MMU_M_040
emory at address 0x%" HWADDR_PRIx "is not RAM",
> > addr);
> > +error_setg(errp, "Memory at address 0x%" HWADDR_PRIx " is not
> > RAM", addr);
> > memory_region_unref(mrs.mr);
> > return NULL;
> >
architecture to implement a second copy of the page table
> > > walking code. But before we can deprecate them we need to be
> > > pretty sure that "info mmu" is what we want to replace them with.
> >
> > An alternative is to just deprecate them, without add
27;detailed',
but rather stick to one or the other as variable names); still:
Reviewed-by: Dr. David Alan Gilbert
> ---
> hmp-commands-info.hx | 6 +++---
> system/qdev-monitor.c | 24 +---
> 2 files changed, 16 insertions(+), 14 deletions(-)
>
> diff
14..fc5f5c57ad 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -398,19 +398,6 @@ SRST
>If called with option off, the emulation returns to normal mode.
> ERST
>
> -{
> -.name = "singlestep",
> -.args_type = "option:s?&quo
* Markus Armbruster (arm...@redhat.com) wrote:
> Improve
>
> (qemu) sync-profile of
> Error: Invalid parameter 'of'
>
> to
>
> Error: invalid parameter 'of', expecting 'on', 'off', or 'reset'
&
r*
> + RAM memory dump starting at *addr*. See xp/ for physical and x/ for
> virtual memory
>
> + *fmt* is a format which tells the command how to format the
> + data. Its syntax is: ``/{count}{format}{size}``
> +ERST
> {
> .name = "gpa2hva",
> .args_type = "addr:l",
> --
> 2.39.2
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
d usage of QMP features, or
> triaging bug reports that include examples of usage, and in both
> cases it is pretty relevant to make unstable features stand out to
> the human via the x- prefix IMHO.
Using x- for events makes sense to me; the semantics of events can be
quite su
* Stefan Hajnoczi (stefa...@gmail.com) wrote:
> On Thu, 7 Sept 2023 at 10:07, Dr. David Alan Gilbert wrote:
> >
> > * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > > On Thu, Sep 07, 2023 at 01:06:39AM +, Dr. David Alan Gilbert wrote:
> > > > * Stefan
* Stefan Hajnoczi (stefa...@redhat.com) wrote:
> On Thu, Sep 07, 2023 at 01:06:39AM +0000, Dr. David Alan Gilbert wrote:
> > * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > > Coroutine HMP commands currently run to completion in a nested event
> > > loop with the Bi
command_co, data);
> +monitor_suspend(&mon->common); /* resumed by handle_hmp_command_co()
> */
> monitor_set_cur(co, &mon->common);
> aio_co_enter(qemu_get_aio_context(), co);
> - AIO_WAIT_WHILE_UNLOCKED(NULL, !data.done);
> }
> -
> -qobject
multiple
> guest physical addresses, or even currently not mapped to any guest
> physical address at all. And it could be present at different physical
> addresses for different vCPUs.
True, but isn't there a similar mechanism for when an MCE happens
in the host memory?
Dave
>
* T.J. Alumbaugh (talum...@google.com) wrote:
> On Tue, May 16, 2023 at 5:03 AM Dr. David Alan Gilbert
> wrote:
> >
> > * T.J. Alumbaugh (talum...@google.com) wrote:
> > > Working Set Reporting supported in virtio-balloon.
> > > - adds working se
uot;microseconds": 435656 } }
> +#
> +##
> +{ 'event': 'WS_EVENT' }
> +
> ##
> # @MemoryInfo:
> #
> diff --git a/qapi/misc.json b/qapi/misc.json
> index 4afaee7fe7..b1da595c80 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -523,6 +523
er the ifdef includes the
SRST/ERST doc section; some ifdef do and some don't; and thus
it depends whether or not you want the command documented
even though it's compiled out.
I think it's probably OK, but maybe worth reconsidering:
Acked-by: Dr. David Alan Gilbert
> SRST
>
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Wed, 5 Apr 2023 at 15:56, Dr. David Alan Gilbert
> wrote:
> >
> > * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > > I think on balance I would go for:
> > > * remove (ie deprecate-and-dr
splitting the 'read'
>part out into its own 'info one-insn-per-tb', for consistency
>(then 'info status' matches the QMP query-status)
If it's pretty obscure, then the qom-set/get is fine; as long
as there is a way to do it, then just make sure in the commit
message you say what the replacement command is.
Dave
> In particular, the fact that messing with this obscure debug
> functionality requires updating the reference-output for a
> bunch of io tests that have no interest at all in it rather
> suggests that even if we did want to expose this to QMP that
> the query-status command is the wrong place to do it.
>
> thanks
> -- PMM
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
ULL, NULL, opaque);
> > +aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd,
> > io_read,
> > + io_write, NULL, NULL, opaque);
> > +aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd,
> >
urrent_accel();
> diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c
> index b4a920df898..cb3530df722 100644
> --- a/tests/qtest/test-hmp.c
> +++ b/tests/qtest/test-hmp.c
> @@ -64,6 +64,7 @@ static const char *hmp_cmds[] = {
> "screendump /dev/null",
>
ns a) above, but we
> > need to document it, and when b) is wanted and implemented someday, we'll
> > need some other flag/cap for it.
>
> As I've mentioned a few times, I think we need to throw away the idea
> of exposing capabilities that mgmt apps need to learn about, and make
> the migration protocol fully bi-directional so src + dst QEMU can
> directly negotiate features. Apps shouldn't have to care about the
> day-to-day improvements in the migration impl to the extent that they
> are today.
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o-https://fstop138.berrange.com :|
> |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote:
> From: "Dr. David Alan Gilbert"
>
> I'm leaving Red Hat next week, so clean up the maintainer entries.
>
> 'virtiofs' is just the device code now, so is pretty small, and
> Stefan is still
From: "Dr. David Alan Gilbert"
I'm leaving Red Hat next week, so clean up the maintainer entries.
'virtiofs' is just the device code now, so is pretty small, and
Stefan is still a maintainer there.
'migration' still has Juan.
For 'HMP' I'll sw
scenario, and now it should be
> working on most cases.
>
> But since there is not enough testing/support nor any reported users for
> this scenario, we should disable this combination before it may cause any
> problems for users.
>
> Suggested-by: Dr. David Alan Gilbert
> Si
* Peter Xu (pet...@redhat.com) wrote:
> On Wed, Mar 22, 2023 at 02:05:06PM +0000, Dr. David Alan Gilbert wrote:
> > * Peter Xu (pet...@redhat.com) wrote:
> > > On Tue, Mar 21, 2023 at 08:24:37PM +0000, Dr. David Alan Gilbert wrote:
> > > > Hi Peter's,
> &g
* Peter Xu (pet...@redhat.com) wrote:
> On Tue, Mar 21, 2023 at 08:24:37PM +0000, Dr. David Alan Gilbert wrote:
> > Hi Peter's,
> > Peter M pointed me to a seg in a migration test in CI; I can reproduce
> > it:
> > * On an s390 host
>
> How easy to repro
t/migration-test.c:1137
#19 0x02aa004131a4 in test_postcopy_common (args=0x3ffc247cf48) at
../tests/qtest/migration-test.c:1162
#20 test_postcopy_preempt () at ../tests/qtest/migration-test.c:1178
Looking at the iov and file it's garbage; so it makes me think this is
something like a flush on a closed file.
Dave
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
oid audio_create_pdos(Audiodev *dev)
> CASE(SPICE, spice, );
> #endif
> CASE(WAV, wav, );
> -
> -case AUDIODEV_DRIVER__MAX:
> -abort();
> };
> }
>
> @@ -2219,9 +2216,6 @@ int audioformat_bytes_per_sample(AudioFormat fmt)
>
;
> bool is_same = (comp & 0x1);
> while (bytes_to_check) {
> +if (d + 2 > dlen) {
> +return -1;
> +}
I agree that's better, so:
Reviewed-by: Dr. David Alan Gilbert
but is it sufficient?
In that bytes_to_check loop
), which is not
> a valid argument
>
> Replace __builtin_ctzll() with our ctz64() wrapper which properly
> handles 0.
>
> Signed-off-by: Matheus Tavares Bernardino
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/xbzrle.c | 5 +++--
> 1 file changed, 3 inser
* Peter Xu (pet...@redhat.com) wrote:
> On Tue, Mar 14, 2023 at 05:15:58PM +0000, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > The RDMA code has return-path handling code, but it's only enabled
> > if postcopy
From: "Dr. David Alan Gilbert"
The RDMA code has return-path handling code, but it's only enabled
if postcopy is enabled; if the 'return-path' migration capability
is enabled, the return path is NOT setup but the core migration
code still tries to use it and breaks.
En
Y_TESTS=1 in your environment.
>
> Suggested-by: Dr. David Alan Gilbert
> Signed-off-by: Peter Maydell
Reviewed-by: Dr. David Alan Gilbert
> ---
> tests/qtest/migration-test.c | 23 ---
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Tue, 14 Mar 2023 at 10:12, Dr. David Alan Gilbert
> wrote:
> >
> > Copying Peter Xu on this one since it's poscopy, especially the newer
> > postcopy preempt.
> >
> > * Peter Maydell (peter.mayd...@lin
s/nptl/futex-internal.h:183
> #1 __pthread_cond_wait_common (abstime=0x0, clockid=0,
> mutex=0x2aa2b37b508, cond=0x2aa2b37b538) at pthread_cond_wait.c:508
> #2 __pthread_cond_wait (cond=cond@entry=0x2aa2b37b538,
> mutex=mutex@entry=0x2aa2b37b508) at pthread_cond_wait.c:647
>
"current migration capabilities");
> return false;
> }
> -migrate_set_block_enabled(true, &local_err);
> -if (local_err) {
> +if (!migrate_cap_set(MIGRATION_CAPABILITY_BLOCK, true, &local_err)) {
> error_propagate(errp, local_err);
> return false;
> }
> --
> 2.39.2
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
he top-level directory.
> + *
> + * Contributions after 2012-01-13 are licensed under the terms of the
> + * GNU GPL, version 2 or (at your option) any later version.
I don't think any of these functions were written by Anthony, and I
think they're all after 2012 aren't they?
* Steven Sistare (steven.sist...@oracle.com) wrote:
> On 3/7/2023 6:32 AM, Dr. David Alan Gilbert wrote:
> > * Steve Sistare (steven.sist...@oracle.com) wrote:
> >> Include CONFIG_DEVICES so that populate_vfio_info is instantiated for
> >> CONFIG_VFIO. Without it, the &
ot;hw/vfio/vfio-common.h"
> @@ -17,7 +18,6 @@ void populate_vfio_info(MigrationInfo *info)
> {
> #ifdef CONFIG_VFIO
> if (vfio_mig_active()) {
> -info->has_vfio = true;
Why this removal?
Dave
> info->vfio = g_malloc0(sizeof(*info->vfio));
> info->vfio->transferred = vfio_mig_bytes_transferred();
> }
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
From: "Dr. David Alan Gilbert"
Thomas found an autoconverge test failure where the
migration completed before the autoconverge had kicked in.
To try and avoid this again:
a) Reduce the usleep in test_migrate_auto_converge
so that it should exit quicker when autoconverge kicks in
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Mon, Mar 06, 2023 at 01:44:38PM +0000, Dr. David Alan Gilbert wrote:
> > * Thomas Huth (th...@redhat.com) wrote:
> > > On 03/03/2023 13.05, Peter Maydell wrote:
> > > > On Fri, 3 Mar 2023 at 11:29, Thomas Huth
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Mon, Mar 06, 2023 at 01:44:38PM +0000, Dr. David Alan Gilbert wrote:
> > * Thomas Huth (th...@redhat.com) wrote:
> > > On 03/03/2023 13.05, Peter Maydell wrote:
> > > > On Fri, 3 Mar 2023 at 11:29, Thomas Huth
EST_QEMU_IMG=./qemu-img
> > > > /home/qemu/qemu-test.fYHKFz/build/tests/qtest/migration-test --tap -k
> ―― ✀
> ―――
> stderr:
> qemu: thread naming not supported on this host
> qemu: thread naming not supported on this host
> qemu: thread naming not supported on this host
> qemu: thread naming not supported on this host
> qemu: thread naming not supported on this host
> qemu: thread naming not supported on this host
> **
> ERROR:../src/tests/qtest/migration-test.c:1841:test_migrate_auto_converge:
> 'got_stop' should be FALSE
>
> (test program exited with status code -6)
>
> Thomas
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
on_with_exec(self):
> > +self.migration_with_exec()
> > +
> > +
> > +@skipUnless('ppc64le' in os.uname()[4], "host != target")
> > +class PPC64(MigrationTest):
> > +"""
> > +:avocado: tags=arch:ppc64
> > +:avocado: tags=machine:pseries
> > +:avocado: tags=cpu:power9_v2.0
> > +"""
> > +
> > +def test_migration_with_tcp_localhost(self):
> > +self.migration_with_tcp_localhost()
> > +
> > +def test_migration_with_unix(self):
> > +self.migration_with_unix()
> > +
> > +def test_migration_with_exec(self):
> > +self.migration_with_exec()
> > +
> > +
> > +@skipUnless('s390x' in os.uname()[4], "host != target")
> > +class S390X(MigrationTest):
> > +"""
> > +:avocado: tags=arch:s390x
> > +:avocado: tags=machine:s390-ccw-virtio
> > +:avocado: tags=cpu:qemu
> > +"""
> > +
> > +def test_migration_with_tcp_localhost(self):
> > +self.migration_with_tcp_localhost()
> > +
> > +def test_migration_with_unix(self):
> > +self.migration_with_unix()
> > +
> > +def test_migration_with_exec(self):
> > +self.migration_with_exec()
> > --
> > 2.35.3
>
> thanks
> -- PMM
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Michael Tokarev (m...@tls.msk.ru) wrote:
> 02.03.2023 11:25, Michael S. Tsirkin wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > In bad9c5a516 ("virtio-rng-pci: fix migration compat for vectors") I
> > fixed the virtio-rng-pci migration compat
1 - 100 of 3016 matches
Mail list logo
