[PULL 07/11] xlnx-zcu102: Register properties as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Alistair Francis Message-Id: <20200921221045.699690-20-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/arm/xlnx-zc

[PULL 06/11] cpu/core: Register core-id and nr-threads as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Message-Id: <20200921221045.699690-18-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/cpu/core.c | 8

[PULL 03/11] cryptodev-vhost-user: Register "chardev" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Gonglei Message-Id: <20200921221045.699690-2-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- backends/cryptodev-vhost-

[PULL 02/11] smp: drop support for deprecated (invalid topologies)

ge-Id: <20200911133202.938754-1-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- docs/system/deprecated.rst | 26 +- hw/core/machine.c | 16 hw/i386/pc.c | 16 3 files changed, 21 insertions(+), 37 deletio

[PULL 08/11] machine: Register "memory-backend" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Message-Id: <20200921221045.699690-21-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/core/mac

[PULL 01/11] qom: simplify object_find_property / object_class_find_property

com> Signed-off-by: Eduardo Habkost --- include/qom/object.h | 48 ++--- hw/arm/armv7m.c | 10 +++--- hw/arm/exynos4210.c | 2 +- hw/arm/highbank.c| 2 +- hw/arm/integratorcp.c| 2 +- hw/arm/real

[PULL 00/11] machine + QOM queue, 2020-09-22

-09-22 QOM cleanups: * Convert instance properties to class properties (Eduardo Habkost) * simplify object_find_property / object_class_find_property (Daniel P. Berrangé) Deprecated feature removal: * Drop support for invalid topol

[PULL 04/11] cryptodev-backend: Register "chardev" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Gonglei Message-Id: <20200921221045.699690-3-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- backends/cryptodev.c | 8

[PULL 05/11] s390x: Register all CPU properties as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: David Hildenbrand Acked-by: Cornelia Huck Message-Id: <20200921221045.699690-13-ehabk...@redhat.com> Signed-off-by: Edua

Re: [PATCH v2 11/38] qapi/common.py: Replace one-letter 'c' variable

On Tue, Sep 22, 2020 at 05:00:34PM -0400, John Snow wrote: > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH v2 09/38] qapi/common.py: Add indent manager

paces from {self!r}") > +self._level -= amount > +return self._level > + > + > +indent = Indentation() Personally, I would keep the push_indent(), pop_indent() API, and introduce an indent() function, to follow the existing API style of plain functions. Something like: indent_prefixes = [] def push_indent(amount=4): """Add `amount` spaces to indentation prefix""" indent_prefixes.push(' '*amount) def pop_indent(): """Revert the most recent push_indent() call""" indent_prefixes.pop() def indent(): """Return the current indentation prefix""" return ''.join(indent_prefixes) What you did is still an improvement, though, so: Reviewed-by: Eduardo Habkost -- Eduardo

[PATCH] MAINTAINERS: Change my role to reviewer of Python scripts

I'm stepping out as maintainer of ./scripts/*.py, but still willing to help review patches for Python code. Signed-off-by: Eduardo Habkost --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3d17cad19aa..242a2a6e82e 100644

Re: [PATCH v2 03/38] qapi: move generator entrypoint into module

gt; +from qapi.doc import gen_doc > +from qapi.error import QAPIError > +from qapi.events import gen_events > +from qapi.introspect import gen_introspect > +from qapi.schema import QAPISchema > +from qapi.types import gen_types > +from qapi.visit import gen_visit Do you plan to change this to use relative imports eventually? In either case: Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH v2 02/38] qapi-gen: Separate arg-parsing from generation

On Tue, Sep 22, 2020 at 05:00:25PM -0400, John Snow wrote: > This is a minor re-work of the entrypoint script. It isolates a > generate() method from the actual command-line mechanism. > > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH v2 06/38] qapi: delint using flake8

on: flake8 will warn on *any* bare except, > but pylint's is context-aware and will suppress the warning if you > re-raise the exception. > > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH v2 05/38] qapi: Remove wildcard includes

es exist in the imported file. > > Remove them and include things explicitly by name instead. > > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH v2 08/38] qapi/common.py: Remove python compatibility workaround

On Tue, Sep 22, 2020 at 05:00:31PM -0400, John Snow wrote: > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH v2 04/38] qapi: Prefer explicit relative imports

ile and -- even though they > are the same file -- they have different module paths, and this causes > cyclic import problems, false positive type mismatch errors, and more. > > It can also be useful when dealing with hierarchical packages, e.g. if > we allow qemu.core.qmp, qemu.qapi.parser, etc. > > Signed-off-by: John Snow Here's the answer to the question I sent on patch 03/38. :) Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH v2 07/38] qapi: add pylintrc

de* of the package. > > Therefore, to run it, you must: > > > pylint scripts/qapi/ --rcfile=scripts/qapi/pylintrc > > Signed-off-by: John Snow Tested-by: Eduardo Habkost This doesn't generate any warnings after this patch, but at the end of your -pt6 branch I got some pylint

Re: [PATCH v2 10/38] qapi/common.py: delint with pylint

UPPERCASE, move them to > the head of the file. Generally, it's nice to be able to audit the code > that runs on import in one central place. > > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH 00/24] qom: Convert some properties to class properties

On Mon, Sep 21, 2020 at 06:10:21PM -0400, Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as it > doesn't require an object to be instantiated. This series > converts a few existing object_property_add*() calls to register > class p

[PATCH] kvm: Correct documentation of kvm_irqchip_*()

quot; part in kvm_irqchip_is_split() doc comment. That macro has nothing to do with existence of explicit user-provided options. Signed-off-by: Eduardo Habkost --- include/sysemu/kvm.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/include/sysemu/kvm.h

[PATCH 3/3] i386/kvm: Delete kvm_allows_irq0_override()

As IRQ routing is always available on x86, kvm_allows_irq0_override() will always return true, so we don't need the function anymore. Signed-off-by: Eduardo Habkost --- target/i386/kvm_i386.h | 1 - hw/i386/fw_cfg.c | 2 +- hw/i386/microvm.c | 2 +- hw/i386/pc.c

[PATCH 1/3] i386/kvm: Require KVM_CAP_IRQ_ROUTING

KVM_CAP_IRQ_ROUTING is available since 2009 (Linux v2.6.30), so it's safe to just make it a requirement on x86. Signed-off-by: Eduardo Habkost --- target/i386/kvm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 9efb07e7c83..d884ff

[PATCH 2/3] i386/kvm: Remove IRQ routing support checks

KVM_CAP_IRQ_ROUTING is always available on x86, so replace checks for kvm_has_gsi_routing() and KVM_CAP_IRQ_ROUTING with asserts. Signed-off-by: Eduardo Habkost --- hw/i386/kvm/apic.c | 5 ++--- hw/i386/kvm/ioapic.c | 33 - target/i386/kvm.c| 7 --- 3

[PATCH 0/3] i386/kvm: Assume IRQ routing is always available

KVM_CAP_IRQ_ROUTING is available since 2019 (Linux v2.6.30), so we can safely assume it's always present and remove some runtime checks. Eduardo Habkost (3): i386/kvm: Require KVM_CAP_IRQ_ROUTING i386/kvm: Remove IRQ routing support checks i386/kvm: Delete kvm_allows_irq0_ove

[PATCH] bios-tables-test: Remove kernel-irqchip=off option

ity of the MSR code. kernel-irqchip=off is for debugging only and there's no need to increase the complexity of the code just to work around an issue that was already fixed in the kernel. Fixes: https://bugs.launchpad.net/bugs/1896263 Signed-off-by: Eduardo Habkost --- tests/qtest/bios-ta

Re: [PATCH] i386: Don't try to set MSR_KVM_ASYNC_PF_EN if kernel-irqchip=off

On Tue, Sep 22, 2020 at 07:26:42PM +0200, Paolo Bonzini wrote: > On 22/09/20 19:22, Eduardo Habkost wrote: > > If it was possible, did KVM break live migration of > > kernel-irqchip=off guests that enabled APF? This would mean my > > patch is replacing a crash with a silen

Re: [Qemu-devel] [PATCH] tests/acpi: speedup acpi tests

On Tue, Sep 22, 2020 at 07:17:24PM +0200, Paolo Bonzini wrote: > On 22/09/20 19:03, Eduardo Habkost wrote: > >> I can remove kernel_irqchip=off once > >> apic irq0 override is assumed. > > [4 years later] > > > > Can we remove it now? I couldn't find

Re: [PATCH] i386: Don't try to set MSR_KVM_ASYNC_PF_EN if kernel-irqchip=off

On Tue, Sep 22, 2020 at 06:42:17PM +0200, Vitaly Kuznetsov wrote: > Eduardo Habkost writes: > > > On Tue, Sep 22, 2020 at 05:38:12PM +0200, Vitaly Kuznetsov wrote: > >> Eduardo Habkost writes: > >> > >> > This addresses the following crash when running

Re: [Qemu-devel] [PATCH] tests/acpi: speedup acpi tests

On Tue, Sep 06, 2016 at 10:22:26PM +0200, Paolo Bonzini wrote: > On 06/09/2016 21:21, Michael S. Tsirkin wrote: > > On Tue, Sep 06, 2016 at 09:11:16PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 06/09/2016 17:51, Michael S. Tsirkin wrote: > Just use "-machine accel=kvm:tcg" and let QEMU do t

Re: [PATCH] i386: Don't try to set MSR_KVM_ASYNC_PF_EN if kernel-irqchip=off

On Tue, Sep 22, 2020 at 05:38:12PM +0200, Vitaly Kuznetsov wrote: > Eduardo Habkost writes: > > > This addresses the following crash when running Linux v5.8 > > with kernel-irqchip=off: > > > > qemu-system-x86_64: error: failed to set MSR 0x4b564d02 to 0x0 >

[PATCH] i386: Don't try to set MSR_KVM_ASYNC_PF_EN if kernel-irqchip=off

el-side fix for the issue too (kernel commit d831de177217 "KVM: x86: always allow writing '0' to MSR_KVM_ASYNC_PF_EN"), but it's nice to simply not trigger the bug if running an older kernel. Fixes: https://bugs.launchpad.net/bugs/1896263 Signed-off-by: Eduardo Habkost -

Re: [PATCH 14/24] i386: Register feature bit properties as class properties

On Mon, Sep 21, 2020 at 06:10:35PM -0400, Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Paolo Bonzini > Cc: Richard Henderson &

Re: [PATCH 13/24] i386: Register most CPU properties as class properties

On Tue, Sep 22, 2020 at 08:41:49AM +0200, Igor Mammedov wrote: > On Mon, 21 Sep 2020 18:10:34 -0400 > Eduardo Habkost wrote: > > > Class properties make QOM introspection simpler and easier, as > > they don't require an object to be instantiated. > > &g

Re: [PATCH 00/24] qom: Convert some properties to class properties

On Tue, Sep 22, 2020 at 09:47:57AM +0800, Li Qiang wrote: > Eduardo Habkost 于2020年9月22日周二 上午6:11写道： > > > > Class properties make QOM introspection simpler and easier, as it > > doesn't require an object to be instantiated. This series > > converts a few existing

Re: [PATCH v2] target/i386: Remove core_id assert check in CPUID 0x8000001E

On Mon, Sep 21, 2020 at 05:47:28PM -0500, Babu Moger wrote: > With x2apic enabled, configurations can have more that 255 cores. > Noticed the device add test is hitting an assert when during cpu > hotplug with core_id > 255. This is due to assert check in the > CPUID 0x801E. > > Remove the ass

[PATCH 22/24] i440fx: Register i440FX-pcihost properties as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: qemu-devel@nongnu.org --- hw/pci-host/i440fx.c | 32 -

[PATCH 23/24] sifive_e: Register "revb" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: qemu-ri...@nongnu.org Cc: qemu-devel@nongnu.org --

[PATCH 19/24] xlnx-zcu102: Register properties as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Alistair Francis Cc: "Edgar E. Iglesias" Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/xln

[PATCH 21/24] vga-pci: Register "big-endian-framebuffer" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Gerd Hoffmann Cc: qemu-devel@nongnu.org --- hw/display/vga-pci.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff

[PATCH 14/24] i386: Register feature bit properties as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- target/i386/cpu.c

[PATCH 20/24] machine: Register "memory-backend" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: qemu-devel@nongnu.org --- hw/core/machine.c | 12 ++-- 1 file changed, 6 insertions(

[PATCH 17/24] cpu/core: Register core-id and nr-threads as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: qemu-devel@nongnu.org --- hw/cpu/core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/cpu/core.c b/h

[PATCH 12/24] s390x: Register all CPU properties as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Cornelia Huck Cc: Thomas Huth Cc: Richard Henderson Cc: David Hildenbrand Cc: Halil Pasic Cc: Christian Borntraeger Cc: qe

[PATCH 24/24] sifive_u: Register "start-in-flash" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: qemu-ri...@nongnu.org Cc: qemu-devel@nongnu.org --

[PATCH 08/24] vexpress-a15: Register "virtualization" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/vexpress.c | 14 -- 1 file changed, 8 insertions(

[PATCH 04/24] rng-random: register "filename" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Laurent Vivier Cc: Amit Shah Cc: qemu-devel@nongnu.org --- backends/rng-random.c | 8 1 file changed, 4 insertions(+), 4 dele

[PATCH 16/24] virt: Register "its" as class property

its=on on virt-2.7 and older. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/virt.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index d1ab660fa60..986b75a6b89

[PATCH 11/24] tmp421: Register properties as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: qemu-devel@nongnu.org --- hw/misc/tmp421.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --

[PATCH 10/24] input-barrier: Register properties as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Gerd Hoffmann Cc: qemu-devel@nongnu.org --- ui/input-barrier.c | 44 ++-- 1 file changed, 22 inser

[PATCH 18/24] arm/cpu64: Register "aarch64" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- target/arm/cpu64.c | 16 ++-- 1 file changed, 6 inser

[PATCH 13/24] i386: Register most CPU properties as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- target/i386/cpu.c

[PATCH 03/24] rng-egd: Register "chardev" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Laurent Vivier Cc: Amit Shah Cc: qemu-devel@nongnu.org --- backends/rng-egd.c | 9 ++--- 1 file changed, 2 insertions(+), 7 dele

[PATCH 07/24] rng: Register "opened" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Laurent Vivier Cc: Amit Shah Cc: qemu-devel@nongnu.org --- backends/rng.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH 02/24] cryptodev-backend: Register "chardev" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: "Gonglei (Arei)" Cc: qemu-devel@nongnu.org --- backends/cryptodev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-

[PATCH 15/24] arm/virt: Register most properties as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/virt.c | 76 +++--

[PATCH 09/24] input-linux: Register properties as class properties

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Gerd Hoffmann Cc: qemu-devel@nongnu.org --- ui/input-linux.c | 27 ++- 1 file changed, 14 insertions(+), 13 dele

[PATCH 05/24] vhost-user: Register "chardev" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org --- backends/vhost-user.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[PATCH 00/24] qom: Convert some properties to class properties

Class properties make QOM introspection simpler and easier, as it doesn't require an object to be instantiated. This series converts a few existing object_property_add*() calls to register class properties instead. Eduardo Habkost (24): cryptodev-vhost-user: Register "chardev

[PATCH 06/24] vexpress: Register "secure" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/vexpress.c | 11 ++- 1 file changed, 6 insertions(

[PATCH 01/24] cryptodev-vhost-user: Register "chardev" as class property

Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: "Gonglei (Arei)" Cc: qemu-devel@nongnu.org --- backends/cryptodev-vhost-user.c | 13 + 1 file changed, 5 insertions(

Re: [PATCH v1 0/3] Remove the limitation of Intel PT CPUID info

I'm not sure yet that's really the plan. > > Thanks, > Luwei Kang > > > -Original Message- > > From: Eduardo Habkost > > Sent: Saturday, September 19, 2020 6:03 AM > > To: Kang, Luwei > > Cc: pbonz...@redhat.com; r...@twiddle.net; qemu-devel@n

Re: Bottleneck problem to merge Python patches

On Sat, Sep 19, 2020 at 01:17:06PM +0200, Philippe Mathieu-Daudé wrote: > Hi Aleksandar, > > (extending the Cc list to broader audience) > > On 9/18/20 10:33 PM, Aleksandar Markovic wrote: > > > > On Friday, August 28, 2020, Ahmed Karaman > > wrote: > > > >

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

On Sat, Sep 19, 2020 at 11:22:12AM +0800, Robert Hoo wrote: > On Fri, 2020-09-18 at 16:42 +0000, Eduardo Habkost wrote: > > ... > > > > > --- > > > > > Changelog > > > > > v3: > > > > > Make the deprecation implementation CPUCla

Re: [PATCH v3 2/2] Mark Icelake-Client CPU models deprecated

On Mon, Sep 21, 2020 at 03:45:12PM +0800, Robert Hoo wrote: > On Fri, 2020-09-18 at 00:20 -0400, Eduardo Habkost wrote: > > On Fri, Sep 18, 2020 at 10:18:56AM +0800, Robert Hoo wrote: > > > On Thu, 2020-09-17 at 14:01 -0400, Eduardo Habkost wrote: > > > > On Wed, Se

Re: [PATCH RFC 22/22] i386: expand Hyper-V features early

On Fri, Sep 04, 2020 at 04:54:31PM +0200, Vitaly Kuznetsov wrote: > To make Hyper-V features appear in e.g. QMP query-cpu-model-expansion we > need to expand and set the corresponding CPUID leaves early. Modify > x86_cpu_get_supported_feature_word() to call newly intoduced Hyper-V > specific kvm_hv

Re: [PATCH RFC 22/22] i386: expand Hyper-V features early

On Fri, Sep 04, 2020 at 04:54:31PM +0200, Vitaly Kuznetsov wrote: > To make Hyper-V features appear in e.g. QMP query-cpu-model-expansion we > need to expand and set the corresponding CPUID leaves early. Modify > x86_cpu_get_supported_feature_word() to call newly intoduced Hyper-V > specific kvm_hv

Re: [PATCH RFC 12/22] i386: always fill Hyper-V CPUID feature leaves from X86CPU data

On Fri, Sep 04, 2020 at 04:54:21PM +0200, Vitaly Kuznetsov wrote: > We have all the required data in X86CPU already and as we are about to > split hyperv_handle_properties() into hyperv_expand_features()/ > hyperv_fill_cpuids() we can remove the blind copy. The functional change > is that QEMU won'

Re: [PATCH RFC 09/22] i386: add reserved FEAT_HYPERV_ECX CPUID leaf

On Fri, Sep 04, 2020 at 04:54:18PM +0200, Vitaly Kuznetsov wrote: > As a preparation to expanding Hyper-V CPU features early, add > reserved FEAT_HYPERV_ECX CPUID leaf. > > Signed-off-by: Vitaly Kuznetsov > --- > target/i386/cpu.c | 5 + > target/i386/cpu.h | 1 + > target/i386/kvm.c | 2 ++

Re: [PATCH RFC 07/22] i386: fill in FEAT_HYPERV_EDX from edx instead of eax

On Fri, Sep 04, 2020 at 04:54:16PM +0200, Vitaly Kuznetsov wrote: > There was a typo which went unnoticed. > > Fixes: e48ddcc6ce13 ("i386/kvm: implement 'hv-passthrough' mode") > Signed-off-by: Vitaly Kuznetsov Similar fix had been submitted at: https://lore.kernel.org/qemu-devel/20190820103030.

Re: [PATCH RFC 04/22] i386: move hyperv_interface_id initialization to x86_cpu_realizefn()

On Fri, Sep 04, 2020 at 04:54:13PM +0200, Vitaly Kuznetsov wrote: > As a preparation to expanding Hyper-V CPU features early, move > hyperv_interface_id initialization to x86_cpu_realizefn(). > > Signed-off-by: Vitaly Kuznetsov > --- > target/i386/cpu.c | 6 ++ > target/i386/cpu.h | 1 + >

Re: [Qemu-devel] [PATCH] i386/kvm: fix FEATURE_HYPERV_EDX value in hyperv_passthrough case

On Tue, Aug 20, 2019 at 06:30:30PM +0800, Zhenyu Wang wrote: > Fix typo to use correct edx value for FEATURE_HYPERV_EDX when > hyperv_passthrough is enabled. > > Signed-off-by: Zhenyu Wang CCing other maintainers (please use ./scripts/get_maintainer.pl to make sure maintainers don't miss patches

Re: [PATCH RFC 06/22] i386: move hyperv_limits initialization to x86_cpu_realizefn()

On Fri, Sep 04, 2020 at 04:54:15PM +0200, Vitaly Kuznetsov wrote: > As a preparation to expanding Hyper-V CPU features early, move > hyperv_limits initialization to x86_cpu_realizefn(). > > Signed-off-by: Vitaly Kuznetsov > --- > target/i386/cpu.c | 5 + > target/i386/cpu.h | 1 + > target

Re: [PATCH RFC 05/22] i386: move hyperv_version_id initialization to x86_cpu_realizefn()

On Fri, Sep 04, 2020 at 04:54:14PM +0200, Vitaly Kuznetsov wrote: > As a preparation to expanding Hyper-V CPU features early, move > hyperv_version_id initialization to x86_cpu_realizefn(). > > Signed-off-by: Vitaly Kuznetsov > --- > target/i386/cpu.c | 4 > target/i386/cpu.h | 1 + > tar

Re: [PATCH RFC 03/22] i386: move hyperv_vendor_id initialization to x86_cpu_realizefn()

On Fri, Sep 04, 2020 at 04:54:12PM +0200, Vitaly Kuznetsov wrote: > As a preparation to expanding Hyper-V CPU features early, move > hyperv_vendor_id initialization to x86_cpu_realizefn(). > > Signed-off-by: Vitaly Kuznetsov > --- > target/i386/cpu.c | 15 ++- > target/i386/cpu.h |

Re: [PATCH] smp: drop support for deprecated (invalid topologies)

On Mon, Sep 14, 2020 at 09:37:20AM +0200, Igor Mammedov wrote: > On Fri, 11 Sep 2020 11:04:47 -0400 > "Michael S. Tsirkin" wrote: > > > On Fri, Sep 11, 2020 at 09:32:02AM -0400, Igor Mammedov wrote: > > > it's was deprecated since 3.1 > > > > > > Support for invalid topologies is removed, the us

Re: [PATCH v1 0/3] Remove the limitation of Intel PT CPUID info

Hi Luwei Kang, I was looking for info on intel-pt and just saw this series, and it was never reviewed or merged (sorry for missing it!). Is this still the approach we want to follow for intel-pt? I'm CCing Jiri Denemark because this might be relevant for a libvirt issue related to intel-pt we we

[PULL 15/17] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros

; identifier InstanceType, lowercase, UPPERCASE; @@ OBJECT_DECLARE_SIMPLE_TYPE(InstanceType, -lowercase, UPPERCASE); Signed-off-by: Eduardo Habkost Reviewed-by: Cédric Le Goater Acked-by: Cornelia Huck Acked-by: Igor Mammedov Acked-by: Paul Durrant Acked

[PULL 11/17] target/riscv: Set instance_align on RISCVCPU TypeInfo

From: Richard Henderson Fix alignment of CPURISCVState.vreg. Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Message-Id: <20200916004638.2444147-6-richard.hender...@linaro.org> Signed-off-by: Eduardo Habkost --- target/riscv/cpu.c | 1 + 1 file changed, 1 insertion(+)

[PULL 08/17] qom: Allow objects to be allocated with increased alignment

qemu_memalloc when required. Signed-off-by: Richard Henderson Message-Id: <20200916004638.2444147-3-richard.hender...@linaro.org> Signed-off-by: Eduardo Habkost --- include/qom/object.h | 5 + qom/object.c | 36 +--- 2 files changed, 38 insertions

[PULL 00/17] QOM queue, 2020-09-18

Armbruster) * Correct object_class_dynamic_cast_assert() documentation (Eduardo Habkost) * Ensure objects using QEMU_ALIGNED are properly aligned (Richard Henderson) QOM cleanups (Eduardo Habkost): * Rename some constants * Simplify parameters of OBJECT_DECLARE* macros * Additional DECLARE_*CHEC

[PULL 01/17] sifive_e: Rename memmap enum constants

: Eduardo Habkost Reviewed-by: Alistair Francis Message-Id: <20200911173447.165713-2-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/riscv/sifive_e.h | 38 - hw/riscv/sifive_e.c | 82 ++--- 2 files changed, 60 inse

Re: [PATCH v6 10/10] i386: Simplify CPUID_8000_001E for AMD

On Mon, Aug 31, 2020 at 01:43:07PM -0500, Babu Moger wrote: > apic_id contains all the information required to build > CPUID_8000_001E. core_id and node_id is already part of > apic_id generated by x86_topo_ids_from_apicid. > > Also remove the restriction on number bits on core_id and > node_id. >

Re: [PATCH v2] qom: simplify object_find_property / object_class_find_property

On Mon, Sep 14, 2020 at 02:56:17PM +0100, Daniel P. Berrangé wrote: > When debugging QEMU it is often useful to put a breakpoint on the > error_setg_internal method impl. > > Unfortunately the object_property_add / object_class_property_add > methods call object_property_find / object_class_proper

[PULL 13/17] scripts/codeconverter: Update to latest version

I'm not documenting every single change in the codeconverter script because most of that code will be deleted once we finish the QOM code conversion. This patch updates the script to the latest version that was used to perform changes in the QOM code. Signed-off-by: Eduardo Habkost Messa

[PULL 06/17] qom: Clean up object_property_get_enum()'s error value

contract. Signed-off-by: Markus Armbruster Reviewed-by: Greg Kurz Reviewed-by: Daniel P. Berrangé Message-Id: <20200917125540.597786-2-arm...@redhat.com> Signed-off-by: Eduardo Habkost --- include/qom/object.h | 6 +++--- qom/object.c | 6 +++--- tests/check-qom-proplist

[PULL 16/17] Use OBJECT_DECLARE_TYPE when possible

This converts existing DECLARE_OBJ_CHECKERS usage to OBJECT_DECLARE_TYPE when possible. $ ./scripts/codeconverter/converter.py -i \ --pattern=AddObjectDeclareType $(git grep -l '' -- '*.[ch]') Signed-off-by: Eduardo Habkost Reviewed-by: Cédric Le Goater Acked-by: Paul

[PULL 02/17] sifive_u: Rename memmap enum constants

. Signed-off-by: Eduardo Habkost Reviewed-by: Alistair Francis Message-Id: <20200911173447.165713-3-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/riscv/sifive_u.h | 34 hw/riscv/sifive_u.c | 156 ++-- 2 files chang

[PULL 14/17] qom: Remove ParentClassType argument from OBJECT_DECLARE_SIMPLE_TYPE

variables for those types. Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200916182519.415636-3-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/authz/list.h| 2 +- include/authz/listfile.h| 2 +- include/authz/pam

[PULL 09/17] target/arm: Set instance_align on CPUARM TypeInfo

From: Richard Henderson Fix alignment of CPUARMState.vfp.zregs. Signed-off-by: Richard Henderson Message-Id: <20200916004638.2444147-4-richard.hender...@linaro.org> Signed-off-by: Eduardo Habkost --- target/arm/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/c

[PULL 10/17] target/ppc: Set instance_align on PowerPCCPU TypeInfo

From: Richard Henderson Fix alignment of CPUPPCState.vsr. Signed-off-by: Richard Henderson Acked-by: David Gibson Message-Id: <20200916004638.2444147-5-richard.hender...@linaro.org> Signed-off-by: Eduardo Habkost --- target/ppc/translate_init.c.inc | 1 + 1 file changed, 1 ins

[PULL 05/17] qom: Correct object_class_dynamic_cast_assert() documentation

object_class_dynamic_cast_assert() is not used by INTERFACE_CHECK, remove misleading mention of that function in the documentation. Message-Id: <20200916193101.511600-2-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/qom/object.h | 2 +- 1 file changed, 1 insertion

[PULL 12/17] target/s390x: Set instance_align on S390CPU TypeInfo

From: Richard Henderson Fix alignment of CPUS390XState.vregs. Signed-off-by: Richard Henderson Message-Id: <20200916004638.2444147-7-richard.hender...@linaro.org> Signed-off-by: Eduardo Habkost --- target/s390x/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/c

[PULL 03/17] sifive: Move QOM typedefs and add missing includes

ros - add missing #include "qom/object.h" lines if necessary Signed-off-by: Eduardo Habkost Reviewed-by: Daniel P. Berrangé Message-Id: <20200831210740.126168-9-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/intc/sifive_plic.h | 6 -- include/hw/ch

[PULL 07/17] qom: Correct error values in two contracts

he exact error value, so do the same here. Signed-off-by: Markus Armbruster Reviewed-by: Greg Kurz Reviewed-by: Daniel P. Berrangé Message-Id: <20200917125540.597786-3-arm...@redhat.com> Signed-off-by: Eduardo Habkost --- include/qom/object.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PULL 04/17] sifive: Use DECLARE_*CHECKER* macros

$ ./scripts/codeconverter/converter.py -i \ --pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]') Signed-off-by: Eduardo Habkost Reviewed-by: Daniel P. Berrangé Message-Id: <20200831210740.126168-12-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost

[PULL 2/4] hw/i386/vmport: Drop superfluous parenthesis around function typedef

off-by: Eduardo Habkost --- include/hw/i386/vmport.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/vmport.h b/include/hw/i386/vmport.h index c380b9c1f0..8f5e27c6f5 100644 --- a/include/hw/i386/vmport.h +++ b/include/hw/i386/vmport.h @@ -4,7 +4,7 @@ #include &

[PULL 3/4] i386: Simplify CPUID_8000_001d for AMD

off-by: Eduardo Habkost --- target/i386/cpu.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 37725bd354..52694a4198 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -395,11 +395,12 @@ stat

[PULL 1/4] i386/kvm: correct the meaning of '0xffffffff' value for hv-spinlocks

e question. In TLFS version 6.0 the mistake was corrected to 'never notify' which sounds logical. Fix QEMU accordingly. Signed-off-by: Vitaly Kuznetsov Message-Id: <20200515114847.74523-1-vkuzn...@redhat.com> Signed-off-by: Eduardo Habkost --- docs/hyperv.txt | 2 +- target/i3

<    8   9   10   11   12   13   14   15   16   17   >