Re: [PATCH v3 0/4] tests/vm/freebsd: Get up-to-date package list from lcitool

2023-07-17 Thread Erik Skultety
On Mon, Jul 17, 2023 at 02:18:34PM +0200, Thomas Huth wrote: > On 11/07/2023 16.49, Philippe Mathieu-Daudé wrote: > > Inspired by this patch from Thomas: > > https://lore.kernel.org/qemu-devel/20230531090415.40421-1-th...@redhat.com/ > > > > Instead of updating the package list manually, use lcito

Re: How do you represent a host gcc and a cross gcc in lcitool?

2023-07-03 Thread Erik Skultety
[...] > > >> >> RiscV guys, > > >> >> > > >> >> It's clear that relying on Debian Sid for the QEMU cross build for > > >> >> RiscV > > >> >> is pretty flakey. Are you guys aware of any other distros that better > > >> >> support cross compiling to a riscv64 target or is Debian still the > > >> >>

Re: [PATCH 0/3] tests/vm/freebsd: Get up-to-date package list from lcitool

2023-06-01 Thread Erik Skultety
On Wed, May 31, 2023 at 10:09:03PM +0200, Philippe Mathieu-Daudé wrote: > Inspired by this patch from Thomas: > https://lore.kernel.org/qemu-devel/20230531090415.40421-1-th...@redhat.com/ > > Instead of updating the package list manually, use lcitool vars file. > > Philippe Mathieu-Daudé (3): >

Re: [PATCH 2/3] tests/vm: Introduce get_qemu_packages_from_lcitool_vars() helper

2023-06-01 Thread Erik Skultety
On Wed, May 31, 2023 at 10:09:05PM +0200, Philippe Mathieu-Daudé wrote: > The 'lcitool variables $OS qemu' command produces a file containing > consistent environment variables helpful to build QEMU on $OS. > In particular the $PKGS variable contains the packages required to > build QEMU. > > Sinc

[PATCH 2/2] tests: lcitool: refresh: Bump container versions

2023-05-31 Thread Erik Skultety
Alpine 3.16 -> 3.18 Fedora 37 -> 38 Signed-off-by: Erik Skultety --- tests/docker/dockerfiles/alpine.docker | 4 ++-- tests/docker/dockerfiles/fedora-win32-cross.docker | 4 ++-- tests/docker/dockerfiles/fedora-win64-cross.docker | 4 ++-- tests/docker/dockerfiles/fedora.

[PATCH 1/2] tests: lcitool: Refresh to latest master

2023-05-31 Thread Erik Skultety
- adds Alpine 3.17 & 3.18 targets, drops 3.15 & 3.16 - adds pipewire-dev mapping Signed-off-by: Erik Skultety --- tests/lcitool/libvirt-ci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci index c8971e90a..6d8b63be

[PATCH 0/2] tests: lcitool: Refresh to latest lcitool changes

2023-05-31 Thread Erik Skultety
- add Alpine 3.17 & 3.18 targets - bump gitlab CI Alpine/Fedora container versions accordingly Erik Skultety (2): tests: lcitool: Refresh to latest master tests: lcitool: refresh: Bump container versions tests/docker/dockerfiles/alpine.docker | 4 ++-- tests/docker/dockerf

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-10 Thread Erik Skultety
On Wed, Mar 09, 2022 at 12:47:26PM +0530, Ani Sinha wrote: > > > On Tue, 8 Mar 2022, Michael S. Tsirkin wrote: > > > On Tue, Mar 08, 2022 at 10:23:20PM +0530, Ani Sinha wrote: > > > On Tue, Mar 8, 2022 at 10:17 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Mar 08, 2022 at 10:15:11

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-10 Thread Erik Skultety
... > On a freshly installed Ubuntu 20.04, the script failed for me with > dependency messages on the apt side. After I updated the packages on > the system, the playbook worked without problems. > > So, my suggestion is to add the "update = yes" here, or add a note in > the documentation asking t

Re: [RFC PATCH 14/15] gitlab-ci: Allow forks to use different set of jobs

2021-04-19 Thread Erik Skultety
On Mon, Apr 19, 2021 at 10:40:53AM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at 01:34:47AM +0200, Philippe Mathieu-Daudé wrote: > > Forks run the same jobs than mainstream, which might be overkill. > > Allow them to easily rebase their custom set, while keeping using > > the mainstrea

Re: [PATCH 0/3] gitlab-pipeline-status script: provide more information on errors

2021-02-23 Thread Erik Skultety
On Tue, Feb 23, 2021 at 11:52:17AM -0300, Wainer dos Santos Moschetta wrote: > Hi Cleber, > > In case you need to send a v2, mind to add the following patch together? > > commit 3c4ed8a78e096e4d7df0398c29887a9d468ae120 (HEAD -> gitlab_runners) > Author: Wainer dos Santos Moschetta > Date:   Tue

Re: [PATCH v5 2/4] Jobs based on custom runners: build environment docs and playbook

2021-02-23 Thread Erik Skultety
On Tue, Feb 23, 2021 at 02:01:53PM +, Alex Bennée wrote: > > Cleber Rosa writes: > > > To run basic jobs on custom runners, the environment needs to be > > properly set up. The most common requirement is having the right > > packages installed. > > > > The playbook introduced here covers th

Re: [PATCH v5 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-02-21 Thread Erik Skultety
> }})'" > + > +- name: Install the gitlab-runner service using its own functionality > + command: /usr/local/bin/gitlab-runner install --user gitlab-runner > --working-directory /home/gitlab-runner I'm pretty sure I pointed this out in previous versions, bu

Re: [PATCH v4 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2020-10-20 Thread Erik Skultety
On Mon, Oct 19, 2020 at 04:54:50PM -0400, Cleber Rosa wrote: > On Mon, Oct 19, 2020 at 12:26:10PM +0200, Erik Skultety wrote: > > On Sun, Oct 18, 2020 at 09:50:02PM -0400, Cleber Rosa wrote: > > > + > > > +- name: Checks the availability of official gitlab-runner b

Re: [PATCH v4 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2020-10-19 Thread Erik Skultety
On Mon, Oct 19, 2020 at 04:41:38PM -0400, Cleber Rosa wrote: > On Mon, Oct 19, 2020 at 12:26:10PM +0200, Erik Skultety wrote: > > On Sun, Oct 18, 2020 at 09:50:02PM -0400, Cleber Rosa wrote: > > > To have the jobs dispatched to custom runners, gitlab-runner must > > >

Re: [PATCH v4 2/4] Jobs based on custom runners: build environment docs and playbook

2020-10-19 Thread Erik Skultety
On Mon, Oct 19, 2020 at 04:25:31PM -0400, Cleber Rosa wrote: > On Mon, Oct 19, 2020 at 12:27:41PM +0200, Erik Skultety wrote: > > ... > > > > > diff --git a/scripts/ci/setup/inventory b/scripts/ci/setup/inventory > > > new file mode 100644 > > > index

Re: [PATCH v4 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2020-10-19 Thread Erik Skultety
On Sun, Oct 18, 2020 at 09:50:02PM -0400, Cleber Rosa wrote: > To have the jobs dispatched to custom runners, gitlab-runner must > be installed, active as a service and properly configured. The > variables file and playbook introduced here should help with those > steps. > > The playbook introduc

Re: [PATCH v4 2/4] Jobs based on custom runners: build environment docs and playbook

2020-10-19 Thread Erik Skultety
... > diff --git a/scripts/ci/setup/inventory b/scripts/ci/setup/inventory > new file mode 100644 > index 00..8bb7ba6b33 > --- /dev/null > +++ b/scripts/ci/setup/inventory > @@ -0,0 +1,2 @@ > +[local] Nit pick, is a group for localhost actually needed? Regards, Erik

Re: [PATCH v2 1/2] GitLab Gating CI: introduce pipeline-status contrib script

2020-07-09 Thread Erik Skultety
On Wed, Jul 08, 2020 at 10:46:56PM -0400, Cleber Rosa wrote: > This script is intended to be used right after a push to a branch. > > By default, it will look for the pipeline associated with the commit > that is the HEAD of the *local* staging branch. It can be used as a > one time check, or with

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

2020-07-09 Thread Erik Skultety
On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > This is a mapping of Peter's "remake-merge-builds" and > "pull-buildtest" scripts, gone through some updates, adding some build > option and removing others. > > The jobs currently cover the machines that the QEMU project owns, and that

Re: [PATCH 0/5] QEMU Gating CI

2020-04-23 Thread Erik Skultety
; > > > To: "Markus Armbruster" > > > > Cc: "Fam Zheng" , "Thomas Huth" , > > > > "Beraldo Leal" , "Erik > > > > Skultety" , "Alex Bennée" > > > > , "Wainer Moschetta" , >

Re: [PATCH v5 3/4] vfio/mdev: add migration_version attribute for mdev (under mdev device node)

2020-04-15 Thread Erik Skultety
read \ >/__ ___\|/_ > | migration_version | | migration_version |-->check migration > - - compatibility > mdev device A mdev device B > > This patch is for mde

Re: [PATCH v5 1/4] vfio/mdev: add migration_version attribute for mdev (under mdev_type node)

2020-04-15 Thread Erik Skultety
read \ >/__ ___\|/_ > | migration_version | | migration_version |-->check migration > - - compatibility > mdev device A mdev device B > > This patch is for mdev

Re: [PATCH 1/5] tests/docker: add CentOS 8 Dockerfile

2020-03-13 Thread Erik Skultety
On Thu, Mar 12, 2020 at 03:36:12PM -0400, Cleber Rosa wrote: > Which is currenly missing, and will be referenced later in the > contributed CI playbooks. > > Signed-off-by: Cleber Rosa > --- > tests/docker/dockerfiles/centos8.docker | 32 + > 1 file changed, 32 insertions

Re: [PATCH v2 0/6] ui: rework -show-cursor option

2020-02-07 Thread Erik Skultety
On Thu, Feb 06, 2020 at 02:20:02PM +0100, Gerd Hoffmann wrote: > On Thu, Feb 06, 2020 at 11:52:05AM +, Peter Maydell wrote: > > On Thu, 6 Feb 2020 at 11:29, Gerd Hoffmann wrote: > > > > > > > > > > This cover letter is missing a description of what the patchset does... > > > > The closest thin

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-16 Thread Erik Skultety
On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > We have this issue reported when using libvirt to hotplug CPUs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > > > Basically, libvirt is not copying die-id from > > query-hotpluggable-cp

Re: [Qemu-devel] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Erik Skultety
On Tue, May 14, 2019 at 11:51:35AM +0200, Cornelia Huck wrote: > On Tue, 14 May 2019 03:47:36 -0400 > Yan Zhao wrote: > > > On Tue, May 14, 2019 at 03:43:44PM +0800, Erik Skultety wrote: > > > On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote: > > > >

Re: [Qemu-devel] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Erik Skultety
On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote: > On Tue, May 14, 2019 at 03:20:40PM +0800, Erik Skultety wrote: > > On Tue, May 14, 2019 at 02:12:35AM -0400, Yan Zhao wrote: > > > On Mon, May 13, 2019 at 09:28:04PM +0800, Erik Skultety wrote: > > > > On F

Re: [Qemu-devel] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Erik Skultety
On Tue, May 14, 2019 at 02:12:35AM -0400, Yan Zhao wrote: > On Mon, May 13, 2019 at 09:28:04PM +0800, Erik Skultety wrote: > > On Fri, May 10, 2019 at 11:48:38AM +0200, Cornelia Huck wrote: > > > On Fri, 10 May 2019 10:36:09 +0100 > > > "Dr. David Alan Gilbert&q

Re: [Qemu-devel] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-13 Thread Erik Skultety
On Fri, May 10, 2019 at 11:48:38AM +0200, Cornelia Huck wrote: > On Fri, 10 May 2019 10:36:09 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > On Thu, 9 May 2019 17:48:26 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Cornelia Huck (coh..

Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities'

2019-04-12 Thread Erik Skultety
On Fri, Apr 12, 2019 at 10:26:45AM +0200, Paolo Bonzini wrote: > On 12/04/19 10:19, Erik Skultety wrote: > >> Since this field is not specific to guest configuration, I don't think > >> it belongs in query-sev-capabilities; QEMU does not care about >1 guest. >

Re: [Qemu-devel] [PATCH v2] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities'

2019-04-12 Thread Erik Skultety
Currently, this limit is not exposed to the application. Add a new > 'sev-max-guest' field in the query-sev-capabilities to provide this > information. > > Cc: Paolo Bonzini > Cc: Markus Armbruster > Cc: Eric Blake > Cc: Daniel P. Berrangé > Cc: Laszlo Ersek >

Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities'

2019-04-12 Thread Erik Skultety
ation. Add a new > >>> 'sev-max-guest' field in the query-sev-capabilities to provide this > >>> information. > >>> > >>> Cc: Paolo Bonzini > >>> Cc: Markus Armbruster > >>> Cc: Eric Blake > >>> Cc: Daniel P. Berrangé

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-28 Thread Erik Skultety
On Thu, Mar 28, 2019 at 04:36:03AM -0400, Zhao Yan wrote: > hi Alex and Dave, > Thanks for your replies. > Please see my comments inline. > > On Thu, Mar 28, 2019 at 06:10:20AM +0800, Alex Williamson wrote: > > On Wed, 27 Mar 2019 20:18:54 + > > "Dr. David Alan Gilbert" wrote: > > > > > * Zhao

[Qemu-devel] Libvirt upstream CI efforts

2019-02-21 Thread Erik Skultety
Hi, I'm starting this thread in order to continue with the ongoing efforts to bring actual integration testing to libvirt. Currently, the status quo is that we build libvirt (along with our unit test suite) using different OS-flavoured VMs in ci.centos.org. Andrea put a tremendous amount of work to

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-31 Thread Erik Skultety
On Wed, Jan 30, 2019 at 06:18:22PM +, Daniel P. Berrangé wrote: > On Wed, Jan 30, 2019 at 02:39:54PM +0100, Erik Skultety wrote: > > > > > though, we need a #ifdef check for existance of PR_CAP_AMBIENT > > > > > > > > > > > An alternative

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-30 Thread Erik Skultety
> > > though, we need a #ifdef check for existance of PR_CAP_AMBIENT > > > > > > > An alternative question I've been playing ever since we exchanged the > > > > last few > > > > emails is that can't we wait until the ioctls are compared against > > > > permissions > > > > in kernel so that upstre

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-30 Thread Erik Skultety
On Tue, Jan 29, 2019 at 06:40:08PM +, Daniel P. Berrangé wrote: > On Tue, Jan 29, 2019 at 05:15:42PM +0100, Erik Skultety wrote: > > On Wed, Jan 23, 2019 at 03:02:28PM +, Singh, Brijesh wrote: > > > > > > > > > On 1/23/19 7:36 AM, Daniel P. Berrangé wr

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-29 Thread Erik Skultety
On Wed, Jan 23, 2019 at 03:02:28PM +, Singh, Brijesh wrote: > > > On 1/23/19 7:36 AM, Daniel P. Berrangé wrote: > > On Wed, Jan 23, 2019 at 02:33:01PM +0100, Erik Skultety wrote: > >> On Wed, Jan 23, 2019 at 01:24:13PM +, Daniel P. Berrangé wrote: > >>>

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Erik Skultety
On Wed, Jan 23, 2019 at 03:02:28PM +, Singh, Brijesh wrote: > > > On 1/23/19 7:36 AM, Daniel P. Berrangé wrote: > > On Wed, Jan 23, 2019 at 02:33:01PM +0100, Erik Skultety wrote: > >> On Wed, Jan 23, 2019 at 01:24:13PM +, Daniel P. Berrangé wrote: > >>>

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Erik Skultety
On Wed, Jan 23, 2019 at 01:24:13PM +, Daniel P. Berrangé wrote: > On Wed, Jan 23, 2019 at 02:22:12PM +0100, Erik Skultety wrote: > > On Wed, Jan 23, 2019 at 01:10:42PM +, Daniel P. Berrangé wrote: > > > On Wed, Jan 23, 2019 at 01:55:06PM +0100, Erik Skultety wrote: >

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Erik Skultety
On Wed, Jan 23, 2019 at 01:10:42PM +, Daniel P. Berrangé wrote: > On Wed, Jan 23, 2019 at 01:55:06PM +0100, Erik Skultety wrote: > > On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote: > > > > > > On 1/18/19 3:39 AM, Erik Skultety wrote: > > >

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Erik Skultety
On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote: > > On 1/18/19 3:39 AM, Erik Skultety wrote: > > Hi, > > this is a summary of a private discussion I've had with guys CC'd on this > > email > > about finding a solution to [1] - basically,

Re: [Qemu-devel] [libvirt] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Erik Skultety
On Fri, Jan 18, 2019 at 10:16:38AM +, Daniel P. Berrangé wrote: > On Fri, Jan 18, 2019 at 10:39:35AM +0100, Erik Skultety wrote: > > Hi, > > this is a summary of a private discussion I've had with guys CC'd on this > > email > > about finding a sol

[Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Erik Skultety
Hi, this is a summary of a private discussion I've had with guys CC'd on this email about finding a solution to [1] - basically, the default permissions on /dev/sev (below) make it impossible to query for SEV platform capabilities, since by default we run QEMU as qemu:qemu when probing for capabili

Re: [Qemu-devel] [PATCH v3] qapi: add query-display-options command

2018-11-22 Thread Erik Skultety
hich display options are supported. > > Use case: commit d4dc4ab1 added rendernode parameter for egl-headless. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Eric Blake > Tested-by: Eric Blake > Tested-by: Erik Skultety > --- FYI I have the first libvirt prototype patches [1

Re: [Qemu-devel] [PATCH] qapi: add query-display-options command

2018-11-21 Thread Erik Skultety
play options are supported. > > Cc: Eric Blake > Cc: Erik Skultety > Signed-off-by: Gerd Hoffmann > --- Direct testing with qemu works, as the necessary data appears in the QAPI schema a can be traversed, so it looks good, but I'm still yet to test traversing with libvirt. Tested-by: Erik Skultety

Re: [Qemu-devel] [PULL 1/3] qapi: Add "rendernode" display option for egl-headless

2018-11-19 Thread Erik Skultety
On Mon, Nov 19, 2018 at 07:10:21AM -0600, Eric Blake wrote: > On 11/16/18 7:29 AM, Gerd Hoffmann wrote: > > From: Erik Skultety > > > > Unlike SPICE, egl-headless doesn't offer a way of specifying the DRM > > node used for OpenGL, hence QEMU always selecting the

[Qemu-devel] [PATCH v2 1/3] qapi: Add "rendernode" display option for egl-headless

2018-11-16 Thread Erik Skultety
Unlike SPICE, egl-headless doesn't offer a way of specifying the DRM node used for OpenGL, hence QEMU always selecting the first one that is available. Thus, add the 'rendernode' option for egl-headless to QAPI. Signed-off-by: Erik Skultety --- qapi/ui.json | 17 ++

[Qemu-devel] [PATCH v2 3/3] help: Provide help for egl-headless

2018-11-16 Thread Erik Skultety
EGL headless has been missing from QEMU's help or man page, we should mention that such a thing exists, especially since projects like libvirt might rely on that. This patch also adds the newly introduced option for egl-headless 'rendernode'. Signed-off-by: Erik Skultety --- qemu

[Qemu-devel] [PATCH v2 0/3] Introduce 'rendernode' option for egl-headless display type

2018-11-16 Thread Erik Skultety
https://bugzilla.redhat.com/show_bug.cgi?id=1648236 Changes since v1: - adjusted the QAPI version and description commentaries for egl-headless Erik Skultety (3): qapi: Add "rendernode" display option for egl-headless ui: Allow specifying 'rendernode' display option for

[Qemu-devel] [PATCH v2 2/3] ui: Allow specifying 'rendernode' display option for egl-headless

2018-11-16 Thread Erik Skultety
lla.redhat.com/show_bug.cgi?id=1648236 Signed-off-by: Erik Skultety --- ui/egl-headless.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/egl-headless.c b/ui/egl-headless.c index 42a41310b0..4cf3bbc0e4 100644 --- a/ui/egl-headless.c +++ b/ui/egl-headless.c @

Re: [Qemu-devel] [PATCH 0/3] Introduce 'rendernode' option for egl-headless display type

2018-11-16 Thread Erik Skultety
On Fri, Nov 16, 2018 at 09:43:52AM +0100, Gerd Hoffmann wrote: > On Thu, Nov 15, 2018 at 09:47:44AM -0600, Eric Blake wrote: > > On 11/15/18 9:15 AM, Erik Skultety wrote: > > > Since QEMU always picks the default DRI device, libvirt doesn't know > > > which

[Qemu-devel] [PATCH 3/3] help: Provide help for egl-headless

2018-11-15 Thread Erik Skultety
EGL headless has been missing from QEMU's help or man page, we should mention that such a thing exists, especially since projects like libvirt might rely on that. This patch also adds the newly introduced option for egl-headless 'rendernode'. Signed-off-by: Erik Skultety --- qemu

[Qemu-devel] [PATCH 2/3] ui: Allow specifying 'rendernode' display option for egl-headless

2018-11-15 Thread Erik Skultety
lla.redhat.com/show_bug.cgi?id=1648236 Signed-off-by: Erik Skultety --- ui/egl-headless.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/egl-headless.c b/ui/egl-headless.c index 42a41310b0..4cf3bbc0e4 100644 --- a/ui/egl-headless.c +++ b/ui/egl-headless.c @

[Qemu-devel] [PATCH 1/3] qapi: Add "rendernode" display option for egl-headless

2018-11-15 Thread Erik Skultety
Unlike SPICE, egl-headless doesn't offer a way of specifying the DRM node used for OpenGL, hence QEMU always selecting the first one that is available. Thus, add rendernode option to QAPI. Signed-off-by: Erik Skultety --- qapi/ui.json | 16 +++- 1 file changed, 15 insertions(

[Qemu-devel] [PATCH 0/3] Introduce 'rendernode' option for egl-headless display type

2018-11-15 Thread Erik Skultety
Since QEMU always picks the default DRI device, libvirt doesn't know which one to put into the mount namespace and relabel it accordingly, hence hitting permission issues, unless admin tweaks the default permissions of the DRI devices. https://bugzilla.redhat.com/show_bug.cgi?id=1648236

Re: [Qemu-devel] [libvirt] [PATCH 2/2] hw/vfio/display: add ramfb support

2018-09-18 Thread Erik Skultety
On Fri, Sep 14, 2018 at 09:16:33AM -0600, Alex Williamson wrote: > On Fri, 14 Sep 2018 16:19:07 +0200 > Erik Skultety wrote: > > > On Fri, Sep 14, 2018 at 12:50:09PM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > Also libvirt man

Re: [Qemu-devel] [libvirt] [PATCH 2/2] hw/vfio/display: add ramfb support

2018-09-14 Thread Erik Skultety
On Fri, Sep 14, 2018 at 12:50:09PM +0200, Gerd Hoffmann wrote: > Hi, > > > > Also libvirt manages hotpluggability per device *class*, not per device > > > *instance*. So a device being hotpluggable or not depending on some > > > device property is a problem for libvirt ... > > > > > > I'm open t

Re: [Qemu-devel] [PATCH v4 3/3] hw/vfio/display: add ramfb support

2018-06-14 Thread Erik Skultety
On Thu, Jun 14, 2018 at 12:36:25AM +0200, Gerd Hoffmann wrote: > On Wed, Jun 13, 2018 at 01:50:47PM -0600, Alex Williamson wrote: > > On Wed, 13 Jun 2018 10:41:49 +0200 > > Gerd Hoffmann wrote: > > > > > So we have a boot display when using a vgpu as primary display. > > > > > > Use vfio-pci-ramfb

Re: [Qemu-devel] [PATCH] vfio/pci: Default display option to "off"

2018-05-30 Thread Erik Skultety
On Tue, May 29, 2018 at 09:24:08AM -0600, Alex Williamson wrote: > [Cc +Erik,libvirt] > > Sorry, should have cc'd libvirt with this initially since display > support is under development. I think "off" is the better > compatibility option, but perhaps the damage is done since it was the > 2.12 def

Re: [Qemu-devel] [PATCH v6 7/9] vfio/display: core & wireup

2018-03-05 Thread Erik Skultety
> diff --git a/hw/vfio/display.c b/hw/vfio/display.c > new file mode 100644 > index 00..3e997f8a44 > --- /dev/null > +++ b/hw/vfio/display.c > @@ -0,0 +1,56 @@ > +/* > + * display support for mdev based vgpu devices > + * > + * Copyright Red Hat, Inc. 2017 Just curious here since I don't r

Re: [Qemu-devel] [libvirt] libvirt/QEMU/SEV interaction

2017-09-18 Thread Erik Skultety
[...] > > > > > c) what existing communicate interface can be used between libvirt > > and qemu > > > to get the measurement ? can we add a new qemu monitor command > > > 'get_sev_measurement' to get the measurement ? (step 10) > > > > Yes, QMP commands seeem most likely. > > > >

Re: [Qemu-devel] [libvirt] libvirt/QEMU/SEV interaction

2017-09-18 Thread Erik Skultety
On Mon, Sep 18, 2017 at 07:41:09AM -0500, Richard Relph wrote: > > > On 9/18/17 4:47 AM, Daniel P. Berrange wrote: > > On Mon, Sep 18, 2017 at 11:43:57AM +0200, Erik Skultety wrote: > > > [...] > > > > > > > > > c) what existing communicate i