> From: peter.crosthwa...@petalogix.com
> >> >
> >> > Forcefully unrealize all children regardless of early-iteration
> >> > errors(if happened). We should keep going with cleanup operation
> >> > rather than report a error immediately.
> >> >
> >> > Signed-off-by: Gonglei
> >> > ---
> >> > hw/co
> >
> > Forcefully unrealize all children regardless of early-iteration
> > errors(if happened). We should keep going with cleanup operation
> > rather than report a error immediately.
> >
> > Signed-off-by: Gonglei
> > ---
> > hw/core/qdev.c | 9 +++--
> > 1 file changed, 3 insertions(+), 6
> > > Subject: [PATCH v4 1/4] qdev: using error_abort instead of using local_err
> > > Importance: High
> > >
> > > From: Gonglei
> > >
> > > This error can not happen normally. If it happens indicates
> > > something very wrong, we should abort QEMU. moreover, The
> > > user can only refer to /
> From: Gonglei (Arei)
> Sent: Tuesday, September 02, 2014 4:04 PM
> Subject: [PATCH v4 1/4] qdev: using error_abort instead of using local_err
> Importance: High
>
> From: Gonglei
>
> This error can not happen normally. If it happens indicates
> something very
> -Original Message-
> From: peter.crosthwa...@petalogix.com
> [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite
> Sent: Tuesday, September 02, 2014 3:00 PM
> To: Gonglei (Arei)
> Cc: Huangweidong (C); Michael S. Tsirkin; Luonengjun;
>
> From: peter.crosthwa...@petalogix.com
> [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite
> Sent: Tuesday, September 02, 2014 6:51 AM
> >> On Mon, Sep 1, 2014 at 3:50 PM, wrote:
> >> > From: Gonglei
> >> >
> >> > At present, this function doesn't have partial cleanup impl
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Monday, September 01, 2014 2:43 PM
> Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function
> Importance: High
>
> Hi,
>
> > +static bool is_same_fw_dev_path(DeviceState *src, DeviceState *dst)
> > +{
> > +bool ret
> -Original Message-
> From: peter.crosthwa...@petalogix.com
> [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite
> Sent: Monday, September 01, 2014 2:08 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org Developers; Huangweidong (C);
> From: peter.crosthwa...@petalogix.com
> [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite
> Sent: Tuesday, August 26, 2014 10:25 AM
> Subject: Re: [Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in
> device_set_realized() to avoid resource leak
>
> On Thu, Aug 21, 2014
Hi, Michael
Do you plan to pick up this patch? Thanks.
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Monday, August 25, 2014 8:21 PM
> To: qemu-devel@nongnu.org
> Cc: m...@redhat.com; Huangweidong (C); knut.om...@oracle.com;
> arm...@r
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Sunday, August 31, 2014 5:58 PM
> Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex
> property
>
> On Sat, Aug 30, 2014 at 06:00:07PM +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > when we rem
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Michael Tokarev
> Sent: Saturday, August 30, 2014 1:26 PM
> To: Liuli (I)
> Cc: qemu-triv...@nongnu.org; qemu-devel@nongnu.org
>
Hi, Gerd
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Thursday, August 28, 2014 4:36 PM
> Subject: Re: [Qemu-devel] USB PCI host bus adapter hot plug
>
> Hi,
>
> > > The last missing bit (beside the make check failures) needed to finally
> > > merge this is turning off hotplug in c
> From: Eric Blake [mailto:ebl...@redhat.com]
> Subject: Re: [Qemu-devel] [PATCH] qmp: using genneric string paring function
> for 'qom-set'
>
> On 08/27/2014 11:19 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
>
> In the subject: s/genneric/generic/, s/paring/parsing/
>
OK.
> > At
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> Subject: Re: [PATCH] qmp: using genneric string paring function for 'qom-set'
>
> Il 28/08/2014 07:19, arei.gong...@huawei.com ha scritto:
> > From: Gonglei
> >
> > At present, 'qom-set' only can set string type property,
> > which will restric
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Thursday, August 28, 2014 4:25 PM
> To: Gonglei (Arei)
> Cc: Alexey Kardashevskiy; qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] USB PCI host bus adapter hot plug
>
> Hi,
>
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Subject: Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take
> effect after rebooting
>
> Hi,
>
> > 1. Does have ready-to-wear interface to get QOM path by qdev id,?
>
> You can simply use the id directly. Try this:
>
> qemu
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Tuesday, August 26, 2014 7:25 PM
> Subject: Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take
> effect after rebooting
>
> Gerd Hoffmann writes:
>
> > On Di, 2014-08-26 at 09:07 +, Go
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Subject: Re: [PATCH v2 2/2] pci: add check for pcie root ports and downstream
> ports
>
> On Thu, Aug 21, 2014 at 05:47:46PM +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > If ARI Forwarding is disabled, according to PCIe spec
Hi, Gerd
Nice to meet you again in maillist. :)
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Tuesday, August 26, 2014 2:36 PM
> Subject: Re: [PATCH v5 0/8] modify boot order of guest, and take effect after
> rebooting
>
> > The patchsets add one qmp inte
Hi, Peter.
Firstly, I appreciate your so careful and useful comments very much.
> -Original Message-
> From: peter.crosthwa...@petalogix.com
> [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite
> Sent: Tuesday, August 26, 2014 10:25 AM
> To: Gonglei (A
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Monday, August 25, 2014 7:51 PM
> Subject: Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init()
> declaration
>
> Knut Omang writes:
>
> > On Mon, 2014-08-25 at 11:48 +0200, Markus Armbruster wrote:
> >> writes:
> >>
> >> >
> -Original Message-
> From: Knut Omang [mailto:knut.om...@oracle.com]
> Sent: Monday, August 25, 2014 7:02 PM
> Subject: Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports
> and
> downstream ports
>
> On Mon, 2014-08-25 at 10:51 +, Gonglei
> From: Knut Omang [mailto:knut.om...@oracle.com]
> Sent: Monday, August 25, 2014 5:51 PM
> Subject: Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports
> and
> downstream ports
>
> On Mon, 2014-08-25 at 09:23 +, Gonglei (Arei) wrote:
> &
> -Original Message-
> From: Knut Omang [mailto:knut.om...@oracle.com]
> Subject: Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports
> and
> downstream ports
>
> On Thu, 2014-08-21 at 17:47 +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > If ARI Forwarding
> -Original Message-
> From: Knut Omang [mailto:knut.om...@oracle.com]
> Sent: Sunday, August 24, 2014 9:32 PM
> To: qemu-devel@nongnu.org
> Cc: Michael S. Tsirkin; Alexey Kardashevskiy; Juan Quintela; Marcel Apfelbaum;
> Markus Armbruster; Paolo Bonzini; Gonglei (Ar
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Monday, August 25, 2014 3:30 PM
> To: Michael Tokarev
> Cc: qemu-devel; Gonglei (Arei); Gabriele Giacone; Gerd Hoffmann;
> 758...@bugs.debian.org
> Subject: Re: [Qemu-devel] [bisected] VNC server can't get all
Ping, please.
Any comments? Thanks.
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Thursday, August 21, 2014 10:11 AM
> To: qemu-devel@nongnu.org
> Cc: m...@redhat.com; Huangweidong (C); pbonz...@redhat.com;
> afaer...@suse.de; i
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Subject: Re: [PATCH v2 4/4] ioh3420: Enable ARI forwarding
>
> On Sun, Aug 24, 2014 at 03:32:20PM +0200, Knut Omang wrote:
> > Signed-off-by: Knut Omang
>
> BTW pcie_cap_is_arifwd_enabled is still unused.
Not yet, but I have posted a patch s
Hi,
Cc'ing qemu-trivial. Please consider receiving, thanks.
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Thursday, August 21, 2014 9:03 PM
> To: qemu-devel@nongnu.org
> Cc: lcapitul...@redhat.com; Huangweidong (C); peter.crosthwa...@x
Hi,
> From: Michael Tokarev [mailto:m...@tls.msk.ru]
> Sent: Saturday, August 23, 2014 4:56 PM
> To: qemu-devel
> Cc: Gerd Hoffmann; Gonglei (Arei); 758...@bugs.debian.org; Gabriele
> Giacone
> Subject: [bisected] VNC server can't get all sent chars correctly
>
>
nongnu.org; xen-de...@lists.xen.org;
> johannes.kra...@googlemail.com; Gonglei (Arei); Stefano Stabellini; Gaowei
> (UVP); Jan Beulich; Anthony Perard
> Subject: Re: [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0
> methods for PCIslots that support hotplug by runtime patching
>
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of zhanghailiang
> Sent: Friday, August 22, 2014 4:24 PM
> To: qemu-devel@nongnu.org
> Cc: qemu-triv...@nongnu.org; riku.voi...@iki
> From: Marcel Apfelbaum [mailto:marce...@redhat.com]
> Sent: Friday, August 22, 2014 2:34 PM
> Subject: Re: [PATCH v2 2/2] pci: add check for pcie root ports and downstream
> ports
>
> On Thu, 2014-08-21 at 17:47 +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > If ARI Forwarding i
> From: Hu Tao [mailto:hu...@cn.fujitsu.com]
> On Thu, Aug 21, 2014 at 05:47:45PM +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > We need to use qbus's parent and get its name.
> >
> > Signed-off-by: Gonglei
> > ---
> > hw/core/qdev.c | 7 +++
> > include/hw/qdev-core
> -Original Message-
> From: peter.crosthwa...@petalogix.com
> [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite
> Sent: Thursday, August 21, 2014 8:54 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org Developers; Huangweidong (C); Luiz Capitu
> -Original Message-
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
> Bonzini
> Sent: Thursday, August 21, 2014 4:59 PM
> To: Gonglei (Arei); qemu-devel@nongnu.org
> Cc: Huangweidong (C); marce...@redhat.com; m...@redhat.com;
> knut.om...@ora
> Subject: Re: [Qemu-devel] [PATCH v2 1/3] qdev: using error_abort instead of
> using local_err
>
> On Thu, Aug 21, 2014 at 12:11 PM, wrote:
> > From: Gonglei
> >
> > This error can not happen normally. If it happens indicates
> > something very wrong, we should abort QEMU. moreover, The
> > us
> -Original Message-
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
> Bonzini
> Sent: Wednesday, August 20, 2014 11:50 PM
> To: qemu-devel@nongnu.org
> Cc: peter.mayd...@linaro.org; Gonglei (Arei); knut.om...@oracle.com;
> m...@redhat.
> From: Marcel Apfelbaum [mailto:marce...@redhat.com]
> Subject: Re: [PATCH 2/2] pci: add check for pcie root ports and downstream
> ports
>
> On Wed, 2014-08-20 at 03:20 +, Gonglei (Arei) wrote:
> > Hi,
> >
> > > > Right now, ARI Forwarding dose not sup
> > static int ioh3420_initfn(PCIDevice *d)
> > {
> > +PCIBridge* br = PCI_BRIDGE(d);
> > PCIEPort *p = PCIE_PORT(d);
> > PCIESlot *s = PCIE_SLOT(d);
> > +uint8_t *exp_cap;
> > int rc;
> > char tmp[100];
> > sprintf(tmp, "pcie_port.%d", s->slot);
> > @@ -121,6 +12
Hi,
> Subject: [PATCH 3/3] ioh3420: Support ARI forwarding
>
>
> Enable the PCIe capability bit that indicates that this port is able to
> support
> and forward requests to > 8 functions for ARI capable devices.
>
> Signed-off-by: Knut Omang
> ---
> hw/pci-bridge/ioh3420.c | 7 +++
> 1 f
Hi,
Command line:
#./qemu-system-x86_64 -enable-kvm -m 2048 -machine q35 -device
ide-drive,bus=ide.2,drive=MacHDD \
-drive id=MacHDD,if=none,file=/mnt/sdb/gonglei/image/redhat_q35.img -monitor
stdio -vnc :10 -readconfig ../docs/q35-chipset.cfg
(qemu) Segmentation fault (core dumped)
Some clews
> On Wed, 2014-08-20 at 06:39 +0200, Knut Omang wrote:
> > On Wed, 2014-08-20 at 02:16 +, Gonglei (Arei) wrote:
> > > > -Original Message-
> > > > From: Michael S. Tsirkin [mailto:m...@redhat.com]
> > > > Sent: Wednesday, August 20, 2014
Hi,
> > Right now, ARI Forwarding dose not support in QEMU.
> I would replace the above sentence with "ARI Forwarding is not supported".
>
OK.
> By the way, there is some support for ARI, I don't know if
> is enabled yet. I'll have a look.
>
MST had pointed out the pcie_ari_init(), but not comp
> -Original Message-
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> Sent: Tuesday, August 19, 2014 11:09 PM
> To: Marcel Apfelbaum; Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; m...@redhat.com; Huangweidong (C);
> afaer...@suse.de; imamm...@redhat.com; peter.cros
Hi,
> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> On Tue, Aug 19, 2014 at 09:08:25PM +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Root ports and downstream ports of switches are the hot
> > pluggable ports in a PCI Express hierarchy.
> > PCI
> -Original Message-
> From: peter.crosthwa...@petalogix.com
> [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite
> Sent: Tuesday, August 19, 2014 9:51 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org Developers; Huangweidong (C); Michael S. Ts
> > ---
> > hw/pci/pcie.c | 6 +-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> > index a123c01..7b46140 100644
> > --- a/hw/pci/pcie.c
> > +++ b/hw/pci/pcie.c
> > @@ -254,7 +254,11 @@ void pcie_cap_slot_hotplug_cb(HotplugHandler
> *hot
> -Original Message-
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> Sent: Tuesday, August 19, 2014 10:03 PM
> To: Peter Crosthwaite; Gonglei (Arei)
> Cc: qemu-devel@nongnu.org Developers; Huangweidong (C); Michael S. Tsirkin;
> Huangpeng (Peter); Igor Mammed
> -Original Message-
> From: peter.crosthwa...@petalogix.com
> On Tue, Aug 19, 2014 at 7:41 PM, wrote:
> > From: Gonglei
> >
> > At present, the local variable local_err is reused at multi-places,
> > Which will cause resource leak in some scenarios.
> >
>
> The problem isn't really the
> > If local_err is not null, the next code logic is useless.
> >
> > Signed-off-by: Gonglei
> > ---
> > hw/core/qdev.c | 5 +
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> > index da1ba48..3e7085e 100644
> > --- a/hw/core/qdev.c
> > +++ b/hw/core/
> -Original Message-
> From: peter.crosthwa...@petalogix.com
> [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite
> Sent: Tuesday, August 19, 2014 11:12 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org Developers; Huangweidong (C); Michael S. Tsi
> -Original Message-
> From: Marcel Apfelbaum [mailto:marcel.apfelb...@gmail.com]
> Sent: Tuesday, August 19, 2014 11:00 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; Huangweidong (C); m...@redhat.com
> Subject: Re: [Qemu-devel] [PATCH] pcihp: fix possible a
> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Wednesday, August 20, 2014 5:19 AM
> To: Gonglei (Arei)
> Cc: Paolo Bonzini; Marcel Apfelbaum; qemu-devel@nongnu.org;
> imamm...@redhat.com; arm...@redhat.com; Huangweidong (C)
> Subjec
Hi,
> -Original Message-
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> Sent: Tuesday, August 19, 2014 4:06 PM
> To: Gonglei (Arei); Marcel Apfelbaum; Michael S. Tsirkin
> Cc: qemu-devel@nongnu.org; imamm...@redhat.com; arm...@redhat.com;
> Huangweidong (C)
> S
> >> Subject: Re: [Question] Why doesn't PCIe hotplug work for Q35 machine?
> >>
> >> On Sun, 2014-08-17 at 13:00 +0200, Michael S. Tsirkin wrote:
> >>> On Fri, Aug 15, 2014 at 07:33:29AM +, Gonglei (Arei) wrote:
> >>>> Hi,
> &
Hi,
> Subject: Re: [Question] Why doesn't PCIe hotplug work for Q35 machine?
>
> On Sun, 2014-08-17 at 13:00 +0200, Michael S. Tsirkin wrote:
> > On Fri, Aug 15, 2014 at 07:33:29AM +, Gonglei (Arei) wrote:
> > > Hi,
> > >
> > > I noticed that th
Hi,
I noticed that the qemu-2.1 release change log says
" PCIe: Basic hot-plug/hot-unplug support for Q35 machine."
And then I made a testing for the hotplugging function of Q35.
But I'm failed, and I got the dmesg log in guest os as below:
[ 159.035250] Pciehp :05:00.0:pcie24: Button presse
Hi,
> Subject: [Qemu-devel] [PATCH 2/3] net: Flush queues when runstate changes
> back to running
>
> When the runstate changes back to running, we definitely need to flush
> queues to get packets flowing again.
>
> Here we implement this in the net layer:
> (1) add a member 'VMChangeStateEntry
> >>> I noticed that QMP's "device_add usb-ehci,id=i2,bus=pci.0" fails on PCI
> >>> hotplug. The same for pci-ohci and this is because their initfn() do
> >>> "dc->hotpluggable = false". So I removed those and now I can hotplug
> USB
> >>> hosts but none of them is able to actually work:
> >>>
>
> Subject: [Qemu-devel] [PATCH] qemu-options.hx: fix a typo of chardev
>
> Change host to port.
>
> Signed-off-by: Liming Wang
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Gonglei
Cc'ing qemu-trivial@
Best regards,
-Gonglei
> diff --git a/
Hi,
Cc'ing Kevin, Stefan and Paolo for more attentions.
Best regards,
-Gonglei
> -Original Message-
> Subject: [Qemu-devel] the whole virtual machine hangs when IO does not come
> back!
>
> Hi,
>
> I tested the reliability of qemu in the IPSAN environment as follows:
> (1) create one
Hi,
> Subject: [Qemu-devel] USB PCI host bus adapter hot plug
>
> Hi!
>
> I noticed that QMP's "device_add usb-ehci,id=i2,bus=pci.0" fails on PCI
> hotplug. The same for pci-ohci and this is because their initfn() do
> "dc->hotpluggable = false". So I removed those and now I can hotplug USB
>
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Sanidhya Kashyap
> Sent: Saturday, August 09, 2014 2:27 PM
> To: qemu list
> Cc: Sanidhya Kashyap; Joel Schopp; Stefan Berger; D
Hi,
> Subject: [Qemu-devel] [patch] qcow2: double free snapshots
>
> In qcow2_open(), if qcow2_read_snapshots() failed, qcow2_open() ->
> qcow2_free_snapshots() will be called, NULL snapshots dereference happened.
> because qcow2_free_snapshots has been performed before in the fail case of
> qcow
Hi,
> Subject: Re: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation,
> add client/server tools
>
> Hello Gonglei,
>
> On 08/08/2014 11:30 AM, Gonglei (Arei) wrote:
> > If you can describe the steps of using example about
> > your ivshmem-client and ivs
Hi,
> Subject: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add
> client/server tools
>
> Here is a patchset containing an update on ivshmem specs documentation and
> importing ivshmem server and client tools.
> These tools have been written from scratch and are not related to what
> Subject: Re: [PATCH v5 0/8] modify boot order of guest, and take effect after
> rebooting
>
> Il 07/08/2014 13:50, Gonglei (Arei) ha scritto:
> > Hi,
> >
> > Ping... please.
> >
> > TBH, I am confused which maintainer can maintain the patch serials ab
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Peter Crosthwaite
> Sent: Thursday, August 07, 2014 7:47 PM
> To: Hu Tao
> Cc: Yasunori Goto; Paolo Bonzini; Yasuaki Isimatu; qe
Hi,
Ping... please.
TBH, I am confused which maintainer can maintain the patch serials about
bootindex.
Gerd is seemingly not in maillist later two weeks.
Markus? Paolo? MST? PMM? Eduardo? Thanks for any help.
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei
> Subject: [Qemu-devel] [PATCH v3 08/10] qtest: check the value returned by
> fopen()
>
> The function fopen() may fail, so check its return value.
>
> Signed-off-by: zhanghailiang
> Signed-off-by: Li Liu
> ---
> qtest.c | 5 +
> tests/bios-tables-test.c | 2 ++
> 2 files
> Subject: [Qemu-devel] [PATCH v3 06/10] slirp: check return value of malloc()
>
> Signed-off-by: zhanghailiang
> ---
> slirp/misc.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/slirp/misc.c b/slirp/misc.c
> index b8eb74c..0109c9f 100644
> --- a/slirp/misc.c
> Subject: [Qemu-devel] [PATCH v3 05/10] util/path: check return value of
> malloc()
>
> Signed-off-by: zhanghailiang
> ---
Reviewed-by: Gonglei
Best regards,
-Gonglei
> util/path.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/util/path.c b/util/path.c
> Subject: [Qemu-devel] [PATCH v3 02/10] monitor: fix access freed memory
>
> The function monitor_fdset_dup_fd_find_remove() references member of
> 'mon_fdset'
> which may be freed in function monitor_fdset_cleanup()
>
> Signed-off-by: zhanghailiang
> ---
Reviewed-by: Gonglei
Best regards,
-
Hi,
> > >
> > >> > Yoda conditions lack readability, and QEMU has a
> > >> > strict compiler configuration for checking a common
> > >> > mistake like "if (dev = NULL)". Make it a written rule.
> >
> > >>
> > >> I know this is my suggested text, but now that I'm re-reading it, I'd
> > >> recommen
Hi,
> >
> > $WHATEVER: don't use 'Yoda conditions'
> >
> > 'Yoda conditions' are not part of idiomatic QEMU coding
> > style, so rewrite them in the more usual order.
>
>
> OK but why stop at these files? How about this
> instead?
>
I just search c files by using key words like "NULL ==" etc.
Hi,
> >
> > $WHATEVER: don't use 'Yoda conditions'
> >
> > 'Yoda conditions' are not part of idiomatic QEMU coding
> > style, so rewrite them in the more usual order.
> >
> > v4:
> > - trivial typo for patch 1/8 suggested by Eric, thanks.
>
> Series: Reviewed-by: Eric Blake
>
> Adding qemu-tri
Hi,
> >> >> >> >> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex
> >> >> command
> >> >> >> >>
> >> >> >> >> On Fri, Jul 25, 2014 at 02:52:50PM +0800,
> arei.gong...@huawei.com
> >> >> wrote:
> >> >> >> >> > From: Gonglei
> >> >> >> >> >
> >> >> >> >> > Adds "set-bootindex id=xx,
Hi,
I' am so sorry for missing cc'ed Eduardo.
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Monday, August 04, 2014 8:46 PM
> To: qemu-devel@nongnu.org
> Subject: [PATCH v5 0/8] modify boot order of guest, and take effect af
Hi, Markus
> >
> >> >> >> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex
> >> command
> >> >> >>
> >> >> >> On Fri, Jul 25, 2014 at 02:52:50PM +0800, arei.gong...@huawei.com
> >> wrote:
> >> >> >> > From: Gonglei
> >> >> >> >
> >> >> >> > Adds "set-bootindex id=xx,bootindex=xx,suf
Hi, Markus
> >> >> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex
> command
> >> >>
> >> >> On Fri, Jul 25, 2014 at 02:52:50PM +0800, arei.gong...@huawei.com
> wrote:
> >> >> > From: Gonglei
> >> >> >
> >> >> > Adds "set-bootindex id=xx,bootindex=xx,suffix=xx" QMP command.
> >> >
Hi,
> >> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex command
> >>
> >> On Fri, Jul 25, 2014 at 02:52:50PM +0800, arei.gong...@huawei.com wrote:
> >> > From: Gonglei
> >> >
> >> > Adds "set-bootindex id=xx,bootindex=xx,suffix=xx" QMP command.
> >> >
> >> > Example QMP command:
Hi,
> >>
> >> > On Thu, Jul 31, 2014 at 05:47:26PM +0800, arei.gong...@huawei.com
> wrote:
> >> > [...]
> >> > > +void modify_boot_device_path(int32_t bootindex, DeviceState *dev,
> >> > > + const char *suffix)
> >> > > +{
> >> > > +FWBootEntry *i, *old_entry = NULL
Hi,
>
> > On Thu, Jul 31, 2014 at 05:47:26PM +0800, arei.gong...@huawei.com wrote:
> > [...]
> > > +void modify_boot_device_path(int32_t bootindex, DeviceState *dev,
> > > + const char *suffix)
> > > +{
> > > +FWBootEntry *i, *old_entry = NULL;
> > > +
> > > +a
Hi,
> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex command
>
> On Fri, Jul 25, 2014 at 02:52:50PM +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Adds "set-bootindex id=xx,bootindex=xx,suffix=xx" QMP command.
> >
> > Example QMP command:
> > -> { "execute": "se
Best regards,
-Gonglei
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Friday, August 01, 2014 10:46 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; chenliang (T); Huangweidong (C);
> m...@redhat.com; a...@ozlabs.ru; hu...@cn.
Hi,
> > >
> > > > +del_boot_device_path(dev);
> > >
> > > You can call this from device_finalize() instead of placing it into each
> > > individual device.
> > >
> > Maybe put this call in device_finalize is not a good idea.
> > I have three reasons:
> >
> > 1. the device's some memory have be
Hi,
> > Yoda conditions lack readability, and QEMU has a
> > strict compiler configuration for checking a common
> > mistake like "if (dev = NULL)". Make it a written rule.
> >
> > Signed-off-by: Gonglei
> > ---
> > CODING_STYLE | 14 ++
> > 1 file changed, 14 insertions(+)
> >
> > d
Hi,
> Subject: Re: [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more
> idiomatic writing style
>
> Andreas Färber writes:
>
> > Am 01.08.2014 05:32, schrieb Gonglei (Arei):
> >> Hi,
> >>
> >>> Subject: Re: [PATCH v2 2/8] usb: a t
Hi,
> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic
> writing
> style
>
> Am 01.08.2014 05:32, schrieb Gonglei (Arei):
> > Hi,
> >
> >> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic
> writing
>
Hi,
> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic
> writing
> style
>
> On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Signed-off-by: Gonglei
> > ---
> > hw/usb/dev-audio.c | 2 +-
> > hw/usb/dev-mtp.c | 4 ++--
> > hw/usb/hcd-
Hi,
> Subject: Re: [PATCH v2 1/8] CODING_STYLE: Section about conditional
> statement
>
> On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Yoda conidtions lack of readability, and QEMU have a
>
> s/conidtions/conditions/
> s/of //
> s/have/has/
>
OK.
> > strict
Hi,
> Subject: Re: [PATCH v2 for-2.2 0/8] about Yoda conditions
>
> On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > $WHATEVER: don't use 'Yoda conditions'
> >
> > 'Yoda conditions' are not part of idiomatic QEMU coding
> > style, so rewrite them in the more usual
Hi,
> Subject: Re: [Qemu-devel] [PATCH for-2.2 0/7] a trivial code change for more
> idiomatic writing style
>
> On Thu, Jul 31, 2014 at 10:39 PM, Peter Maydell
> wrote:
> > On 31 July 2014 13:28, wrote:
> >> From: Gonglei
> >>
> >> Gonglei (7):
> >> usb: a trivial code change for more idio
Hi, PMM
> -Original Message-
> From: Peter Maydell [mailto:peter.mayd...@linaro.org]
> Sent: Thursday, July 31, 2014 8:40 PM
> Subject: Re: [PATCH for-2.2 0/7] a trivial code change for more idiomatic
> writing
> style
>
> On 31 July 2014 13:28, wrote:
> > From: Gonglei
> >
> > Gongle
Hi,
> > Introduce a del_boot_device_path() cleanup fw_cfg content
> > when hot-unplugging devcie refer to bootindex.
>
> s/devcie/device/
>
> sounds odd; maybe:
>
> Introduce del_boot_device_path() to clean up fw_cfg content when
> hot-unplugging a device that refers to a bootindex.
>
OK. Than
Hi,
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Thursday, July 31, 2014 6:37 AM
> Subject: Re: [PATCH v3 5/7] qmp: add set-bootindex command
>
> On 07/25/2014 10:45 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Adds "set-bootindex id=xx,booti
Hi,
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Friday, July 25, 2014 5:52 PM
>
> > +del_boot_device_path(dev);
>
> You can call this from device_finalize() instead of placing it into each
> individual device.
>
Maybe put this call in device_finaliz
Hi, Gerd
> > > > > > > I think it is ok to allow only *changing* the bootindex.
> > > > > > >
> > > > > > Yes, that's no problem.
> > > > >
> > > > > But then yoy always will have a old entry where you can take the
> > > > > suffix
> > > > > from, and you don't need the suffix as parameter for t
601 - 700 of 954 matches
Mail list logo
