Re: [Qemu-devel] [PATCH 1/2] qom: add error handler for object_property_print()

2014-09-23 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 1/2] qom: add error handler for > object_property_print() > > Hi, > > Am 23.09.2014 um 05:25 schrieb arei.gong...@huawei.com: > > From: Gonglei > > > > Avoid the caller of object_property_print() leaking string > > argument's memory, such as qdev_print_props()

Re: [Qemu-devel] [PATCH 0/2] qom: add error handler for security

2014-09-23 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, September 23, 2014 9:23 PM > Subject: Re: [PATCH 0/2] qom: add error handler for security > > Il 23/09/2014 15:21, Gonglei (Arei) ha scritto: > > Thanks, Paolo. I merged those two patches in my next patch s

Re: [Qemu-devel] [PATCH 0/2] qom: add error handler for security

2014-09-23 Thread Gonglei (Arei)
> > > > The PATCH 2 is splited from another patch series, which has been > > reviewed by Paolo. PATCH 1 can avoid possible leaking memory. > > > > Gonglei (2): > > qom: add error handler for object_property_print() > > qom: add error handler for object alias property > > > > qom/object.c | 21

Re: [Qemu-devel] [PATCH v3 00/19] usb: convert device init to realize

2014-09-23 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Tuesday, September 23, 2014 7:02 PM > Subject: Re: [PATCH v3 00/19] usb: convert device init to realize > > On Di, 2014-09-23 at 10:58 +, Gonglei (Arei) wrote: > > Hi, Gred > > > > Would you like to

Re: [Qemu-devel] [PATCH 0/2] usb-serial: only check speed once at realize time

2014-09-23 Thread Gonglei (Arei)
And this one :) Thanks! Best regards, -Gonglei > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 19, 2014 4:08 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luo

Re: [Qemu-devel] [PATCH v3 00/19] usb: convert device init to realize

2014-09-23 Thread Gonglei (Arei)
Hi, Gred Would you like to pick up this patch series? Thanks. Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Friday, September 19, 2014 2:48 PM > To: qemu-devel@nongnu.org > Cc: kra...@redhat.com; Huangweidong (C); arm...@redhat.com; > p

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-23 Thread Gonglei (Arei)
> Subject: Re: [PATCH 0/3] Fix confused output for alias properties > > Il 23/09/2014 05:09, Gonglei (Arei) ha scritto: > > Hi, > > > >>>>>> This doesn't change the fact that ObjectProperty is a generic struct, > >>>>>> and addi

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-23 Thread Gonglei (Arei)
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 23, 2014 5:06 PM > To: Gonglei (Arei) > Cc: Paolo Bonzini; Michael S. Tsirkin; ag...@suse.de; Huangweidong (C); > stefa...@redhat.com; Huangpeng (Peter); qem

Re: [Qemu-devel] [PATCH 0/2] qom: add error handler for security

2014-09-22 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 0/2] qom: add error handler for security > > On 09/22/2014 09:25 PM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > The PATCH 2 is splited from another patch series, which has been > > s/splited/split/ > > 'split' is one of those stupid English word

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
Hi, > This doesn't change the fact that ObjectProperty is a generic struct, > and adding alias-specific fields there is wrong. > >>> > >>> OK, Maybe I should find other ways to attach this purpose and > >>> avoid layering violation. Thanks! > >> > >> Unfortunately I cannot think of any.

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> Subject: Re: [PATCH 0/3] Fix confused output for alias properties > > Il 22/09/2014 15:36, Gonglei (Arei) ha scritto: > >> If the field is called "opaque", it's opaque. > > > > Sorry? > > The field is called "opaque" because no one,

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> Subject: Re: [PATCH 0/3] Fix confused output for alias properties > > Il 22/09/2014 15:13, Gonglei (Arei) ha scritto: > > (I don't add alias-sepecific filed into ObjectProperty > > struct, just add a bool property. ) > > > > diff --git a/include/qom/obj

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > > Bonzini > > Sent: Monday, September 22, 2014 8:07 PM > > To: Gonglei (Arei); Michael S. Tsirkin > > Cc: ag...@suse.de; Huangweidong (C); aligu...@amazon.com; Huangpeng > > (

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Monday, September 22, 2014 8:07 PM > To: Gonglei (Arei); Michael S. Tsirkin > Cc: ag...@suse.de; Huangweidong (C); aligu...@amazon.com; Huangpeng >

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Monday, September 22, 2014 6:04 PM > To: Gonglei (Arei); Michael S. Tsirkin > Cc: Huangweidong (C); aligu...@amazon.com; qemu-devel@nongnu.org; > ag...@suse.de; stefa...@redhat.com

Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names

2014-09-22 Thread Gonglei (Arei)
> From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Monday, September 22, 2014 6:28 PM > Subject: Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event > names > > On Sat, Sep 20, 2014 at 09:32:35AM +0000, Gonglei (Arei) wrote: > > > @@ -3

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Monday, September 22, 2014 5:15 PM > To: Michael S. Tsirkin; Gonglei (Arei) > Cc: ag...@suse.de; Huangweidong (C); aligu...@amazon.com; Huangpeng > (Peter); qemu-devel@nongnu.org; s

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, September 22, 2014 4:34 PM > Subject: Re: [PATCH 0/3] Fix confused output for alias properties > > On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > At present, people have no way

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
Hi, Paolo > -Original Message- > From: Gonglei (Arei) > Sent: Wednesday, September 17, 2014 10:32 AM > To: 'Paolo Bonzini'; Markus Armbruster > Cc: Huangweidong (C); aligu...@amazon.com; Michael S. Tsirkin; > ag...@suse.de; qemu-devel@nongnu.org; stefa...@re

Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names

2014-09-20 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names > > It is easy to typo a blkdebug configuration and waste a lot of time > figuring out why no rules are matching. > > Push the Error** down into add_rule() so we can report an error when the > event name is invalid. >

Re: [Qemu-devel] [PATCH] qom: suppress conscan warning of returning null point

2014-09-19 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] qom: suppress conscan warning of returning null > point > > Conscan complains about g_malloc0() and malloc() return null. > > Error: NULL_RETURNS (CWE-476): > qemu-kvm/qom/object.c:239: returned_null: Function "g_malloc0(gsize)" > returns null. > qemu-kvm/qom

Re: [Qemu-devel] [PATCH v2 0/9] virtio: fix virtio child recount in transports

2014-09-19 Thread Gonglei (Arei)
. What's your opinion? Thanks a lot! Does this patch series can be merged firstly? Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Tuesday, September 09, 2014 2:35 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; pbonz...@redhat.com;

Re: [Qemu-devel] [PATCH 0/2] usb-serial: only check speed once at realize time

2014-09-19 Thread Gonglei (Arei)
> Il 19/09/2014 09:25, arei.gong...@huawei.com ha scritto: > > From: Gonglei > > > > This patch series based on > > [PATCH v3 00/19] usb: convert device init to realize > > > > As Paolo's comments: > > > > usb port speed check could be extracted to a separate > > function usb_check_attach, that i

Re: [Qemu-devel] [PATCH] qemu-socket: Polish errors for connect() and listen() failure

2014-09-19 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] qemu-socket: Polish errors for connect() and > listen() failure > > connect() doesn't "connect to socket", it connects a socket to an > address and, if it's of type SOCK_STREAM, initiates a connection. > Scratch "to". > > listen() does "set socket to listening mode

Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, September 19, 2014 2:06 PM > To: Gonglei (Arei) > Subject: Re: [PATCH v2 00/19] usb: convert device init to realize > > On Do, 2014-09-18 at 20:47 +0800, arei.gong...@huawei.com wrote: > > From: Gonglei >

Re: [Qemu-devel] [PATCH v2 15/19] dev-wacom: convert init to realize

2014-09-18 Thread Gonglei (Arei)
Hi, > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, September 19, 2014 2:02 PM > Subject: Re: [PATCH v2 15/19] dev-wacom: convert init to realize > > > > static const VMStateDescription vmstate_usb_wacom = { > > @@ -357,7 +356,7 @@ static void usb_wacom_class_init(ObjectClass *

Re: [Qemu-devel] [question] virtio-net-device and multi-queue option

2014-09-18 Thread Gonglei (Arei)
> From: Eric Auger [mailto:eric.au...@linaro.org] > Sent: Friday, September 19, 2014 10:23 AM > To: Gonglei (Arei); qemu list; Michael S. Tsirkin > Subject: Re: [Qemu-devel] [question] virtio-net-device and multi-queue option > > On 09/19/2014 03:42 AM, Gonglei (Arei) wrote: &

Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 19, 2014 2:42 AM > Subject: Re: [PATCH v2 00/19] usb: convert device init to realize > > Il 18/09/2014 19:15, Markus Armbruster ha scritto: > > > > Thanks for doing this work. If you can

Re: [Qemu-devel] [question] virtio-net-device and multi-queue option

2014-09-18 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [question] virtio-net-device and multi-queue option > > Hi, > > > I am currently doing some benchmarks using virtio-net-device using > virtio-mmio (non PCI) with qemu_system_arm with KVM. Purpose is to > compare with device passthrough performance. > > I heard about the

Re: [Qemu-devel] [PATCH v2 12/19] dev-serial: convert init to realize

2014-09-18 Thread Gonglei (Arei)
> >>> Can we use qerror_report_err still in realize function? > >>> Just report this error but not propagate to the caller. Thanks! > >> > >> No, I think propagating the error is fine. In fact I suggested checking > >> for the error more aggressively, so that it can better propagate to the > >> ca

Re: [Qemu-devel] [PATCH v2 12/19] dev-serial: convert init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, September 18, 2014 9:31 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: kra...@redhat.com; Huangweidong (C); arm...@redhat.com; Huangpeng > (Peter); Luonengjun > Subject: Re: [PATCH v2 12/19] dev-seria

Re: [Qemu-devel] [PATCH v2 12/19] dev-serial: convert init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, September 18, 2014 8:59 PM > Subject: Re: [PATCH v2 12/19] dev-serial: convert init to realize > > Il 18/09/2014 14:47, arei.gong...@huawei.com ha scritto: > > if (s->cs->be_open && !dev->attached) { > > -usb_device_

Re: [Qemu-devel] [PATCH v3] pci-hotplug-old: avoid lossing error message

2014-09-18 Thread Gonglei (Arei)
> From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Thursday, September 18, 2014 9:01 PM > Subject: Re: [PATCH v3] pci-hotplug-old: avoid lossing error message > > On 09/18/2014 06:58 AM, arei.gong...@huawei.com wrote: > > From: Gonglei > > s/lossing/losing/ in the subject (still) > > > > > W

Re: [Qemu-devel] [PATCH] pci-hotplug-old: avoid lossing error message

2014-09-18 Thread Gonglei (Arei)
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Thursday, September 18, 2014 8:22 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); arm...@redhat.com; m...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] pci-hotplug-

Re: [Qemu-devel] [PATCH v2] pci-hotplug-old: avoid lossing error message

2014-09-18 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Thursday, September 18, 2014 7:09 PM > Subject: Re: [Qemu-devel] [PATCH v2] pci-hotplug-old: avoid lossing error > message > > writes: > > > From: Gonglei > > > > When scsi_bus_legacy_add_drive() produce error, > > we will loss error

Re: [Qemu-devel] [PATCH 14/19] dev-hid: convert init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, September 18, 2014 6:16 PM > Subject: Re: [PATCH 14/19] dev-hid: convert init to realize > > Il 18/09/2014 11:32, arei.gong...@huawei.com ha scritto: > > From: Gonglei > > > > In this way, all the implementations now use > > err

Re: [Qemu-devel] [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, September 18, 2014 6:09 PM > Subject: Re: [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize > > Il 18/09/2014 11:32, arei.gong...@huawei.com ha scritto: > > static void usb_msd_password_cb(void *opaque, int err) > >

Re: [Qemu-devel] [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, September 18, 2014 6:08 PM > Subject: Re: [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize > > Il 18/09/2014 11:32, arei.gong...@huawei.com ha scritto: > > @@ -460,7 +460,7 @@ static void usb_serial_event(void *opaqu

Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and missing error message

2014-09-18 Thread Gonglei (Arei)
> >> > --- > >> > hw/usb/dev-storage.c | 11 ++- > >> > 1 file changed, 6 insertions(+), 5 deletions(-) > >> > > >> > diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c > >> > index 5c51ac0..cabd053 100644 > >> > --- a/hw/usb/dev-storage.c > >> > +++ b/hw/usb/dev-storage.c > >> > @@

Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and missing error message

2014-09-18 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Thursday, September 18, 2014 3:38 PM > Subject: Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and > missing error message > > writes: > > > From: Gonglei > > > > When scsi_bus_legacy_add_drive() return NULL, meanwhile

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-17 Thread Gonglei (Arei)
> but switching all usb over to realize is a bigger project indeed. > Hi, Gerd I want to do this job which converting USB devices from init to realize. So all the implementations can use error_setg instead of error_report for reporting error. Include those devices as below: name "usb-host", bu

Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on qdev_device_help()

2014-09-17 Thread Gonglei (Arei)
> > >> > > >> Doesn't this leak prop_list when local_err && prop_list? > > >> > > > No, it will not happen this situation. > > > > > >> Returning both a value in need of destruction and an error object is at > > >> least highly unusual, and probably plain wrong. > > >> > > >> Should qmp_device_list

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-16 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, September 16, 2014 10:37 PM > Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties > > Il 16/09/2014 16:32, Markus Armbruster ha scritto: > > Paolo Bonzini writes: > > > >> Il 16/09/2014 11:16, Markus Ar

Re: [Qemu-devel] [PATCH] hmp: fix memory leak at hmp_info_block_jobs()

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 16, 2014 11:12 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; kw...@redhat.com; Huangweidong (C); > lcapitul...@redhat.com; stefa...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] hmp:

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Wednesday, September 17, 2014 12:16 AM > To: Gerd Hoffmann > Cc: Gonglei (Arei); Huangweidong (C); qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report > > Gerd Hof

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 16, 2014 10:26 PM > To: Paolo Bonzini > Cc: Gonglei (Arei); qemu-devel@nongnu.org; Huangweidong (C); > kra...@redhat.com > Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_re

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Gonglei (Arei)
> -Original Message- > From: Gonglei (Arei) > Sent: Friday, September 12, 2014 3:31 PM > To: qemu-devel@nongnu.org > Cc: kra...@redhat.com; Huangweidong (C); arm...@redhat.com; Gonglei > (Arei) > Subject: [PATCH v2 0/2] usb: Don't use qerror_report > > F

Re: [Qemu-devel] [PATCH v2 2/3] qom: add AliasProperty struct poniter for alias property in ObjectProperty

2014-09-16 Thread Gonglei (Arei)
> From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, September 16, 2014 8:23 PM > Subject: Re: [PATCH v2 2/3] qom: add AliasProperty struct poniter for alias > property in ObjectProperty > > On 09/15/2014 11:51 PM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > s/poniter/poin

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-16 Thread Gonglei (Arei)
Hi, > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, September 16, 2014 6:46 PM > Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties > > Il 16/09/2014 12:37, Michael S. Tsirkin ha scritto: > > str really should be for free-form strings. > > It makes

Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on qdev_device_help()

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 16, 2014 4:00 PM > To: Gonglei (Arei) > Subject: Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on > qdev_device_help() > > "Gonglei (Arei)" writes: > > &

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 16, 2014 3:21 PM > To: Michael S. Tsirkin > Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties > > "Michael S. Tsirkin" writes: > > > On Mon, Sep 15, 2014 at 05:57:51PM +0200, Paolo Bonzin

Re: [Qemu-devel] [PATCH 0/5] usb: make host adapters hot-pluggable

2014-09-16 Thread Gonglei (Arei)
Hi, > Subject: [Qemu-devel] [PATCH 0/5] usb: make host adapters hot-pluggable > > Hi, > > This series the usb host adapters hot-pluggable. Problem is that we > can NOT hotplug host adapters which are part of a companion setup. The > way this is tackled now is to split the usb host adapter va

Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on qdev_device_help()

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 16, 2014 3:28 PM > Subject: Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on > qdev_device_help() > > writes: > > > From: Gonglei > > > > Normally, qmp_device_list_properties() may return NULL when >

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-15 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Subject: Re: [PATCH 0/3] Fix confused output for alias properties > > On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > At present, people have no way to know they should > > have a specific for

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, September 15, 2014 5:59 PM > > > > > > > > > > > > > > > > > > > > Sorry, I don't understand your meaning. :( > > > > > > > > > > > > > > I applied your patch, and looked at the property types. > > > > > > > > > > > > > Could you t

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> > Subject: RE: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate > > qdev > > properties > > > > > > > > > > > > > > Sorry, I don't understand your meaning. :( > > > > > > > > > > I applied your patch, and looked at the property types. > > > > > > > > > Could you tell me your method lo

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> -Original Message- > From: Gonglei (Arei) > Sent: Monday, September 15, 2014 5:06 PM > To: 'Michael S. Tsirkin' > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; stefa...@redhat.com; > Huangweidong (C); ag...@suse.de; Huangpeng (Peter); r...@twiddle.net

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> > > > > > > > Sorry, I don't understand your meaning. :( > > > > > > I applied your patch, and looked at the property types. > > > > > Could you tell me your method looked at properties type? > > You can use an HMP command, or you can use > -device virtio-net-pci,? OK. Good method. > changes m

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, September 15, 2014 2:41 PM > Subject: Re: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev > properties > > On Mon, Sep 15, 2014 at 05:49:42AM +0000, Gonglei (Arei) wrote: > > > From: M

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-14 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, September 15, 2014 1:36 PM > Subject: Re: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev > properties > > On Mon, Sep 15, 2014 at 01:03:24AM +0000, Gonglei (Arei) wrote: > > > >

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-14 Thread Gonglei (Arei)
> On Tue, Sep 09, 2014 at 02:35:02PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > virtio-net-pci, virtio-net-s390, and virtio-net-ccw all duplicate the > > qdev properties of their VirtIONet child. This approach does not work > > well with string or pointer properties since we m

Re: [Qemu-devel] [PATCH v2 0/9] virtio: fix virtio child recount in transports

2014-09-12 Thread Gonglei (Arei)
Ping... Any comments will be appreciated! Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Tuesday, September 09, 2014 2:35 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; pbonz...@redhat.com; stefa...@redhat.com; > Huangweidong

Re: [Qemu-devel] [PATCH v10 00/30] modify boot order of guest, and take effect after rebooting

2014-09-12 Thread Gonglei (Arei)
> Subject: Re: [PATCH v10 00/30] modify boot order of guest, and take effect > after rebooting > > On Fr, 2014-09-12 at 17:35 +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Sometimes, we want to modify boot order of a guest, but no need to > > shutdown it. We can call dynamic cha

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 12, 2014 4:59 PM > Subject: Re: [PATCH v2 0/2] usb: Don't use qerror_report > > Il 12/09/2014 10:50, Gonglei (Arei) ha scritto: > >> > Any chance

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Friday, September 12, 2014 5:02 PM > To: Gonglei (Arei) > Cc: Kevin Wolf; Benoît Canet; Stefan Hajnoczi; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged &

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
> From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: Friday, September 12, 2014 4:46 PM > To: Gonglei (Arei) > Cc: Markus Armbruster; Benoît Canet; qemu-devel@nongnu.org; Stefan > Hajnoczi > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged >

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 12, 2014 4:35 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); kra...@redhat.com; arm...@redhat.com > Subject: Re: [PATCH v2 0/2] usb: Don't us

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
> From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: Friday, September 12, 2014 4:14 PM > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged > > Am 12.09.2014 um 09:02 hat Gonglei (Arei) geschrieben: > > Hi, > > > > > Subjec

Re: [Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Friday, September 12, 2014 3:11 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; Huangweidong (C); kra...@redhat.com > Subject: Re: [Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report > > wr

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
Hi, > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged > > Benoît Canet writes: > > >> EOF > >> --- > >> If you have feedback or questions, let us know. The process can be > >> tweaked as time goes on so we can continue to improve. > > > > Great mail. > > Yup

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-11 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and > take effect after rebooting > > Am 11.09.2014 um 07:58 schrieb Gonglei (Arei): > >>> ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 > -drive \ > >>> file=/ho

Re: [Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery duringeoi broadcast

2014-09-11 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery > duringeoi broadcast > > Currently, we call ioapic_service() immediately when we find the irq is still > active during eoi broadcast. But for real hardware, there's some dealy between > the EOI writing and irq delivery

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-11 Thread Gonglei (Arei)
> > 主题: RE: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and > take > > effect after rebooting > > > > > > 主题: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and > > > > take effect after rebooting > > > > > > > > From: Gonglei > > > > > > > > Sometimes, we want to modify b

Re: [Qemu-devel] [PATCH v9 05/30] bootindex: rework add_boot_device_path function

2014-09-11 Thread Gonglei (Arei)
Hi, > Subject: Re: [PATCH v9 05/30] bootindex: rework add_boot_device_path > function > > > +static void del_original_boot_device(DeviceState *dev, const char *suffix) > > Hmm, now we have two simliar delete functions. One which deletes all > entries belonging to a device, and one deleting only

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-10 Thread Gonglei (Arei)
> > 主题: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take > > effect after rebooting > > > > From: Gonglei > > > > Sometimes, we want to modify boot order of a guest, but no need to > shutdown > > it. We can call dynamic changing bootindex of a guest, which can be assured > > taki

Re: [Qemu-devel] [PATCH v3 0/3] add check for PCIe root ports and downstream ports

2014-09-09 Thread Gonglei (Arei)
> -Original Message- > From: Gonglei (Arei) > Sent: Thursday, September 04, 2014 8:10 PM > Subject: RE: [PATCH v3 0/3] add check for PCIe root ports and downstream > ports > > Ping... Michael? Thanks! > Ping... again. Thanks! > > Best regards, >

Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property

2014-09-09 Thread Gonglei (Arei)
Hi, > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > > > > Subject: Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom > > > property > > > > > > > > On Fri, Sep 05, 2014 at 04:37:32PM +0800, arei.gong...@huawei.com > wrote: > > > > > From: Gonglei > > > > > > > > > > Add a qom pro

Re: [Qemu-devel] [PATCH v7 08/28] virtio-net: add bootindex to qom property

2014-09-09 Thread Gonglei (Arei)
Hi, > > Subject: Re: [Qemu-devel] [PATCH v7 08/28] virtio-net: add bootindex to qom > > property > > > > On Fri, Sep 05, 2014 at 04:37:16PM +0800, arei.gong...@huawei.com wrote: > > > From: Gonglei > > > > > > Add a qom property with the same name 'bootindex', > > > when we remove it form qdev pr

Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property

2014-09-09 Thread Gonglei (Arei)
Hi, > Subject: RE: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property > > > Subject: Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom > property > > > > On Fri, Sep 05, 2014 at 04:37:32PM +0800, arei.gong...@huawei.com wrote: > > > From: Gonglei > > > > > > Add a qom pro

Re: [Qemu-devel] [PATCH v7 18/28] host-libusb: remove bootindex property from qdev to qom

2014-09-05 Thread Gonglei (Arei)
Hi, > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, September 05, 2014 5:06 PM > Subject: Re: [PATCH v7 18/28] host-libusb: remove bootindex property from > qdev to qom > > > +static void usb_host_instance_init(Object *obj) > > +{ > > +USBDevice *udev = USB_DEVICE(obj); > > +

Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-05 Thread Gonglei (Arei)
Hi, CC'ing Stefan and qemu-stable@ for more attention. :) Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, September 04, 2014 7:42 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); Gonglei (Arei) > Subj

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-04 Thread Gonglei (Arei)
> From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Friday, September 05, 2014 10:22 AM > Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > On Fri, Sep 05, 2014 at 02:07:23AM +0000, Gonglei (Arei) wrote: > [...] > >

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-04 Thread Gonglei (Arei)
> From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Friday, September 05, 2014 10:20 AM > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > On Fri, Sep 05, 2014 at 12:44:56AM +, Gonglei (Arei) wrote: > [...] > > > can we ha

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-04 Thread Gonglei (Arei)
> From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Friday, September 05, 2014 9:55 AM > Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > On Fri, Sep 05, 2014 at 12:37:35AM +0000, Gonglei (Arei) wrote: > > > Subject

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-04 Thread Gonglei (Arei)
> Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > On Thu, Sep 04, 2014 at 03:01:41AM +, Gonglei (Arei) wrote: > > Hi, > > > > > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > > > Sent: Thursday, September 04, 2014 2:1

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-04 Thread Gonglei (Arei)
> Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > On Sat, Aug 30, 2014 at 06:00:07PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > when we remove bootindex form qdev.property to qom.property, > > we can use those functions set/get boo

Re: [Qemu-devel] [PATCH v6 06/27] bootindex: move setting bootindex on reset() instead of realize/init()

2014-09-04 Thread Gonglei (Arei)
> Subject: Re: [PATCH v6 06/27] bootindex: move setting bootindex on reset() > instead of realize/init() > > On Sat, Aug 30, 2014 at 06:00:06PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Only in this way, we can assure the new bootindex take effect > > during vm rebooting. >

Re: [Qemu-devel] [PATCH v3 0/3] add check for PCIe root ports and downstream ports

2014-09-04 Thread Gonglei (Arei)
Ping... Michael? Thanks! Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Monday, September 01, 2014 9:29 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); pbonz...@redhat.com; > afaer...@suse.de; imamm...@redhat.c

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-04 Thread Gonglei (Arei)
Hi, > > I've confirmed that this is a bug, and have posted a patch fix it. > > Please review, thanks! > > [PATCH] virtio-pci: fix virtio-net child refcount in transports > > Best regards, > -Gonglei So, about Gerd's previous question: > When hot-unplugging virtio-net-pci I'd expect we free b

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-04 Thread Gonglei (Arei)
> Subject: RE: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > Hi, > > > > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path > function > > > > > > On Wed, Sep 03, 2014 at 06:45:56AM +, Gonglei (Arei) wrote: >

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-03 Thread Gonglei (Arei)
Hi, > > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > > > On Wed, Sep 03, 2014 at 06:45:56AM +0000, Gonglei (Arei) wrote: > > [...] > > > > > 4. When we hotplug the virtio-net-pci device, only pass > >

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-03 Thread Gonglei (Arei)
Hi, > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Thursday, September 04, 2014 2:13 AM > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > On Wed, Sep 03, 2014 at 06:45:56AM +, Gonglei (Arei) wrote: > [...] > > > > 4.

Re: [Qemu-devel] [PATCH v5 1/4] qdev: using error_abort instead of using local_err

2014-09-03 Thread Gonglei (Arei)
Hi, > Subject: Re: [Qemu-devel] [PATCH v5 1/4] qdev: using error_abort instead of > using local_err > > Am 02.09.2014 14:03, schrieb arei.gong...@huawei.com: > > From: Gonglei > > > > This error can not happen normally. If it happens indicates > > something very wrong, we should abort QEMU. more

Re: [Qemu-devel] [PATCH v5 2/4] qdev: using NULL instead of local_err for qbus_child unrealize

2014-09-03 Thread Gonglei (Arei)
> From: peter.crosthwa...@petalogix.com > [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite > Sent: Wednesday, September 03, 2014 9:09 PM g NULL instead of local_err > for qbus_child unrealize > > On Tue, Sep 2, 2014 at 10:03 PM, wrote: > > From: Gonglei > > > > Forcefully

Re: [Qemu-devel] [PATCH v5 4/4] pcie: don't assert when hotplug a PCIe device with 'function != 0'

2014-09-03 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, September 03, 2014 9:48 PM > Subject: Re: [PATCH v5 4/4] pcie: don't assert when hotplug a PCIe device with > 'function != 0' > > On Tue, Sep 02, 2014 at 08:03:08PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > >

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-03 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Hi, > > > +void set_bootindex(int32_t *bootindex, Visitor *v, > > > + const char *name, Error **errp) > > > +{ > > > +int32_t boot_index; > > > +Error *local_err = NULL; > > > + > > > +visit_type_int32(v, &boot_i

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-03 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Gonglei (Arei) > Sent: Saturday, August 30, 2014 6:00 PM > Subject: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > From: Gonglei > > when we remove bootindex form qdev.property to qom.p

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-02 Thread Gonglei (Arei)
Best regards, -Gonglei > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Wednesday, September 03, 2014 2:25 PM > To: Gonglei (Arei) > Cc: Eduardo Habkost; qemu-devel@nongnu.org; aligu...@amazon.com; > m...@redhat.com; pbonz...@redhat.com

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-02 Thread Gonglei (Arei)
function > > Importance: High > > > > On Mon, Sep 01, 2014 at 06:47:13AM +, Gonglei (Arei) wrote: > > > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > > > Sent: Monday, September 01, 2014 2:43 PM > > > > Subject: Re: [PATCH

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-02 Thread Gonglei (Arei)
Hi, > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Wednesday, September 03, 2014 2:00 AM > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > Importance: High > > On Mon, Sep 01, 2014 at 06:47:13AM +0000, Gonglei (Arei) wrote: > &g

<    1   2   3   4   5   6   7   8   9   10   >