On Tue, 9 Mar 2021 15:17:21 +
Stefan Hajnoczi wrote:
> On Mon, Mar 08, 2021 at 01:31:39PM +0100, Greg Kurz wrote:
> > +g_autofree int *fd = NULL;
> > +size_t fdsize = 0;
> > +int i;
> >
> > /* Read header */
> > io
On Tue, 9 Mar 2021 15:02:48 +
Stefan Hajnoczi wrote:
> On Mon, Mar 08, 2021 at 01:31:38PM +0100, Greg Kurz wrote:
> > A deadlock condition potentially exists if a vhost-user process needs
> > to request something to QEMU on the slave channel while processing a
> &g
ock being held.
Signed-off-by: Greg Kurz
---
tools/virtiofsd/fuse_virtio.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index 523ee64fb7ae..3e13997406bf 100644
--- a/tools/virtiofsd/fuse_virtio.c
+++ b/tools/virtio
as well.
[1] https://github.com/jedisct1/Blogbench
Suggested-by: Stefan Hajnoczi
Signed-off-by: Greg Kurz
---
hw/virtio/vhost-user.c | 59 ++
1 file changed, 54 insertions(+), 5 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.
7;t explicitely violating the protocol per-se so
it seems better to ignore it.
Signed-off-by: Greg Kurz
---
hw/virtio/vhost-user.c | 99 ++
1 file changed, 42 insertions(+), 57 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
ind
clone of "master"
Greg Kurz (4):
vhost-user: Introduce nested event loop in vhost_user_read()
vhost-user: Convert slave channel to QIOChannelSocket
vhost-user: Monitor slave channel in vhost_user_read()
virtiofsd: Release vu_dispatch_lock when stopping queue
hw/virtio/vh
() based on an event that was already handled
by the nested loop.
Signed-off-by: Greg Kurz
---
hw/virtio/vhost-user.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index e395d0d1fd81..7669b3f2a99f 100644
--- a/hw
sus to deliberately put
virtio in the name when this was first introduced, so that
nobody else ever try to use it, as recorded in the commit log.
commit bf7663c4bd8f8f619d6dbb5780025d92ace250a8
Author: Greg Kurz
Date: Tue Jun 24 19:33:21 2014 +0200
cpu: introduce CPUClass::virtio_is_big_e
function is now doing, and it makes callers care more about what the
> function goal is and less about spapr.c internals such as clearing
> the pending dimm unplug state.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
LGTM
Reviewed-by: Greg Kurz
> hw/ppc/spap
spapr_phb_unplug_request().
>
> Signed-off-by: Daniel Henrique Barboza
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 149dc2113f..6ef72ee7bd 100644
> --- a/hw/ppc/
On Fri, 26 Feb 2021 13:33:00 -0300
Daniel Henrique Barboza wrote:
> Hotunplug for all other devices are warning the user when the hotunplug
> is already in progress. Do the same for PCI devices in
> spapr_pci_unplug_request().
>
> Signed-off-by: Daniel Henrique Barboza
> ---
.
>
> We will use the first DRC to simplify the code a bit in the next patch,
> so instead of removing the duplicated assert, let's do it earlier.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr.c | 12 +++-
> 1 file
commit 2a129767ebb1 and it works,
> but it's easier to check the unplug_requested flag instead of looking
> for the existence of the sPAPRDIMMState. It's also compliant with what
> is already done in other unplug_request functions for other devices.
>
> Signed-off-by: Dani
to retrieve the deadline for a QEMUTimer
> object, in ms, to avoid exposing timer internals to the PPC code.
>
> CC: Paolo Bonzini
> Acked-by: Paolo Bonzini
> Signed-off-by: Daniel Henrique Barboza
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr_drc.c | 5 ++---
> inc
On Thu, 25 Feb 2021 18:29:14 -0300
Daniel Henrique Barboza wrote:
> The pSeries machine is using QEMUTimer internals to return the timeout
> in seconds for a timer object, in hw/ppc/spapr.c, function
> spapr_drc_unplug_timeout_remaining_sec().
>
> Create a helper in qemu-timer.c to retrieve the
On Thu, 25 Feb 2021 17:31:22 +0100
Christian Schoenebeck wrote:
> On Montag, 1. Februar 2021 14:37:02 CET qemu_oss--- via wrote:
> > On Montag, 1. Februar 2021 13:26:49 CET Greg Kurz wrote:
> > > > > I agree that a bunch of other things should be documented, but that&
On Wed, 24 Feb 2021 08:29:17 +0800
Jeremy Kerr wrote:
> Hi Alexey,
> > Jeremy or Stephen (cc-ing) do definitely know if there is a better
> > way.
>
> The standard process is to send me an email :)
>
Is this standard process mentioned somewhere ?
> You're wanting to add user 'groug' to the qe
On Tue, 23 Feb 2021 08:18:17 +
Mark Cave-Ayland wrote:
> On 23/02/2021 07:59, Greg Kurz wrote:
>
> > On Tue, 23 Feb 2021 15:51:19 +1100
> > David Gibson wrote:
> >
> >> On Mon, Feb 22, 2021 at 06:18:08PM -0300, Leonardo Augusto Guimarães
> >> Ga
Hi Leo,
Please use my personal gr...@kaod.org address for upstream matters.
On Wed, 17 Feb 2021 16:55:12 -0300
lagar...@linux.ibm.com wrote:
> From: Leonardo Garcia
>
> Currently, as IOMMU is not supported, if a user mistakenly set it and
> tries to mount the vhost-user filesystem (or use any
On Tue, 23 Feb 2021 11:09:05 +
Peter Maydell wrote:
> On Mon, 22 Feb 2021 at 14:43, Greg Kurz wrote:
> > My understanding is that users must be "maintainer" to edit other's
> > patches. Only three 'maintainers' are currently list
On Tue, 23 Feb 2021 14:57:21 +0800
Bin Meng wrote:
> On Mon, Feb 22, 2021 at 10:43 PM Greg Kurz wrote:
> >
> > On Mon, 22 Feb 2021 13:59:34 +
> > Peter Maydell wrote:
> >
> > > On Mon, 22 Feb 2021 at 07:21, Greg Kurz wrote:
> > > >
> >
On Tue, 23 Feb 2021 15:51:19 +1100
David Gibson wrote:
> On Mon, Feb 22, 2021 at 06:18:08PM -0300, Leonardo Augusto Guimarães Garcia
> wrote:
> > On 2/22/21 8:01 AM, Greg Kurz wrote:
> > > On Thu, 18 Feb 2021 10:16:25 -0300
> > > Leonardo Augusto Guimarães Garcia
On Mon, 22 Feb 2021 16:08:04 +0100
Christian Schoenebeck wrote:
[...]
> I did not ever have a kernel crash when I boot a Linux guest with a 9pfs root
> fs and 100 MiB msize.
Interesting.
> Should we ask virtio or 9p Linux client maintainers if
> they can add some info what this is about?
>
to review all
of it. My main concern is that it doesn't impact support of the paths
used in production (i.e. pseries + SLOF + KVM).
Alexey has made a great job of separating VOF from the rest : changes in
hw/ppc/spapr.c are simple enough for me now. So from that perspective:
Acked-by: Greg Kur
On Mon, 22 Feb 2021 13:59:34 +
Peter Maydell wrote:
> On Mon, 22 Feb 2021 at 07:21, Greg Kurz wrote:
> >
> > On Fri, 19 Feb 2021 17:51:02 +0100
> > Thomas Huth wrote:
> >
> > > On 19/02/2021 17.26, Peter Maydell wrote:
> > > > Does anybody u
me. Just one small nit in docs/system/target-ppc.rst.
Reviewed-by: Greg Kurz
> docs/system/ppc/embedded.rst | 10 ++
> docs/system/ppc/powermac.rst | 34 ++
> docs/system/ppc/powernv.rst | 193 +++
> docs/system/ppc/prep.rst | 18
> d
On Sat, 20 Feb 2021 16:38:35 +0100
Christian Schoenebeck wrote:
> On Freitag, 19. Februar 2021 20:01:12 CET Vivek Goyal wrote:
> > On Fri, Feb 19, 2021 at 06:33:46PM +0100, Christian Schoenebeck wrote:
> > > On Freitag, 19. Februar 2021 17:08:48 CET Vivek Goyal wrote:
> > > > On Fri, Sep 25, 2020
This is just an oversight.
Fixes: f518be3aa35b ("target/ppc: Remove "compat" property of server class
POWER CPUs")
Cc: gr...@kaod.org
Signed-off-by: Greg Kurz
---
docs/system/removed-features.rst |6 ++
1 file changed, 6 insertions(+)
diff --git a/docs/system/re
On Thu, 18 Feb 2021 10:16:25 -0300
Leonardo Augusto Guimarães Garcia wrote:
> Hi there,
>
> I would like to edit the wiki page at [0] as it contains some outdated
> information. Could anyone that has access to the wiki please help me
> create a user so that I can edit it?
>
> 0. https://wiki.
On Fri, 19 Feb 2021 17:51:02 +0100
Thomas Huth wrote:
> On 19/02/2021 17.26, Peter Maydell wrote:
> > Does anybody use the ozlabs patchwork install for QEMU patches,
> > either occasionally or on a regular basis ?
> > http://patchwork.ozlabs.org/project/qemu-devel/list/
> > The admins for that sy
n for a long time now and renaming it
> is not worth the trouble. spapr_drc_unplug_request() setting
> drc->unplug_request
> is more natural than spapr_drc_detach_request setting drc->unplug_request.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
Reviewed-by: Greg Kurz
ur intentions
> in both these functions.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr_drc.c | 32
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/hw/ppc/spapr_drc.c b/
On Tue, 16 Feb 2021 13:09:43 -0300
Daniel Henrique Barboza wrote:
>
>
> On 2/16/21 12:50 PM, Greg Kurz wrote:
> > On Thu, 11 Feb 2021 19:52:41 -0300
> > Daniel Henrique Barboza wrote:
> >
> >> When hotunplugging a PCI function we'll branch out the l
On Thu, 11 Feb 2021 19:52:41 -0300
Daniel Henrique Barboza wrote:
> When hotunplugging a PCI function we'll branch out the logic in two cases,
> function zero and non-zero. If non-zero, we'll call spapr_drc_detach() and
> nothing else. If it's function zero, we'll loop it once between all the
> f
e == 1
event_notifier_set() <- fails right away if !e->initialized
Fixes: e34e47eb28c0 ("event_notifier: handle initialization failure better")
Cc: mlevi...@redhat.com
Signed-off-by: Greg Kurz
---
util/event_notifier-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
evice in a
> - * configured state, as suggested by the state diagram from PAPR+
> - * 2.7, 13.4
> - */
> -if (drc->unplug_requested) {
> -uint32_t drc_index = spapr_drc_index(drc);
> -trace_spapr_drc_set_isolation_state_finalizing(drc_index);
I was expecting a change in hw/ppc/trace-events to ditch this trace,
but it is still called by drc_isolate_physical(), so we're good.
Reviewed-by: Greg Kurz
> -spapr_drc_detach(drc);
> -}
> return RTAS_OUT_SUCCESS;
> }
>
gt;
> Reported-by: Peter Xu
> Fixes: b68ba1ca57677acf870d5ab10579e6105c1f5338
> Signed-off-by: Eric Auger
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr_iommu.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c
> index 30352df00
On Wed, 10 Feb 2021 17:40:43 +1100
Alexey Kardashevskiy wrote:
>
>
> On 27/01/2021 12:28, Alexey Kardashevskiy wrote:
> >
> >
> > On 25/01/2021 21:23, Greg Kurz wrote:
> >> On Sat, 23 Jan 2021 13:36:34 +1100
> >> Alexey Kardashevskiy wrote:
>
_open() [Greg]
> * Use De Morgan's Law to simplify the boolean expression in lo_create()
> [Vivek]
> * Add missing errno = -truncfd after lo_inode_open() call in lo_setattr
Good catch !
Reviewed-by: Greg Kurz
> v3:
> * Restructure lo_create() to handle externally-c
need fuse_req_t req, convert
> lo_add_fd_mapping() to use struct lo_data *lo instead.
>
> Signed-off-by: Stefan Hajnoczi
> ---
Reviewed-by: Greg Kurz
> v4:
> * Return positive errno if openat(2) fails in lo_do_open() [Greg]
> ---
> tools/virtiofsd/passthrough_ll.c | 7
On Thu, 4 Feb 2021 09:45:37 +
Stefan Hajnoczi wrote:
> On Thu, Feb 04, 2021 at 09:25:28AM +0100, Greg Kurz wrote:
> > On Wed, 3 Feb 2021 17:00:06 +
> > Stefan Hajnoczi wrote:
> >
> > > On Wed, Feb 03, 2021 at 03:20:14PM +0100, Greg Kurz wrote:
> > &g
On Wed, 3 Feb 2021 17:00:06 +
Stefan Hajnoczi wrote:
> On Wed, Feb 03, 2021 at 03:20:14PM +0100, Greg Kurz wrote:
> > On Wed, 3 Feb 2021 11:37:18 +
> > Stefan Hajnoczi wrote:
> >
> > > lo_do_lookup() finds an existing inode or allocates a new one. It
&g
VuDev::vu_dispatch_rwlock.
Some users already check the return value and assert, some others
don't. Introduce rdlock/wrlock/unlock wrappers that just do the
former and use them everywhere for improved consistency and
robustness.
This is just cleanup. It doesn't fix any actual issue.
Signed-of
fter machine
> creation time.
>
> To start a PEF-capable guest, use the command line options:
> -object pef-guest,id=pef0 -machine confidential-guest-support=pef0
>
> Signed-off-by: David Gibson
> ---
Reviewed-by: Greg Kurz
Just some cosmetic comments i
On Wed, 3 Feb 2021 16:45:10 +0100
Greg Kurz wrote:
> On Wed, 3 Feb 2021 14:47:30 +
> "Dr. David Alan Gilbert" wrote:
>
> > * Greg Kurz (gr...@kaod.org) wrote:
> > > On Wed, 3 Feb 2021 11:37:17 +
> > > Stefan Hajnoczi wrote:
> > >
generic
> kvm_init() code.
>
> Signed-off-by: David Gibson
> Reviewed-by: Cornelia Huck
> ---
Reviewed-by: Greg Kurz
> accel/kvm/kvm-all.c | 14 --
> accel/kvm/sev-stub.c | 4 ++--
> target/i386/kvm/kvm.c | 20
> target/i386
he definition here is a bit fuzzy, because this is essentially
> + * part of a self-sanity-check, rather than a strict mechanism.
> + *
> + * It's not fasible to have a single point in the common machine
s/fasible/feasible
Anyway,
Reviewed-by: Greg Kurz
> + * init path t
On Wed, 3 Feb 2021 10:59:34 -0500
Vivek Goyal wrote:
> On Fri, Jan 29, 2021 at 04:53:12PM +0100, Greg Kurz wrote:
> > pthread_rwlock_rdlock() and pthread_rwlock_wrlock() can fail if a
> > deadlock condition is detected or the current thread already owns
> > the lock. The
On Wed, 3 Feb 2021 10:28:50 -0500
Vivek Goyal wrote:
> On Wed, Feb 03, 2021 at 11:37:19AM +, Stefan Hajnoczi wrote:
>
> [..]
> > @@ -1727,36 +1764,38 @@ static void lo_create(fuse_req_t req, fuse_ino_t
> > parent, const char *name,
> >
> > update_open_flags(lo->writeback, lo->allow_d
On Wed, 3 Feb 2021 11:37:19 +
Stefan Hajnoczi wrote:
> A well-behaved FUSE client does not attempt to open special files with
> FUSE_OPEN because they are handled on the client side (e.g. device nodes
> are handled by client-side device drivers).
>
> The check to prevent virtiofsd from open
On Wed, 3 Feb 2021 14:47:30 +
"Dr. David Alan Gilbert" wrote:
> * Greg Kurz (gr...@kaod.org) wrote:
> > On Wed, 3 Feb 2021 11:37:17 +
> > Stefan Hajnoczi wrote:
> >
> > > Both lo_open() and lo_create() have similar code to open a file. Extract
&
On Wed, 3 Feb 2021 14:57:23 +
Stefan Hajnoczi wrote:
> On Fri, Jan 29, 2021 at 04:53:12PM +0100, Greg Kurz wrote:
> > pthread_rwlock_rdlock() and pthread_rwlock_wrlock() can fail if a
> > deadlock condition is detected or the current thread already owns
> > the lock. The
need fuse_req_t req, convert
> lo_add_fd_mapping() to use struct lo_data *lo instead.
>
> Signed-off-by: Stefan Hajnoczi
> ---
With the s/ENOMEM/-ENOMEM/ change in lo_do_open() suggested by patchew,
Reviewed-by: Greg Kurz
> tools/virtiofsd/passthrough_ll.c | 73
On Wed, 3 Feb 2021 11:37:18 +
Stefan Hajnoczi wrote:
> lo_do_lookup() finds an existing inode or allocates a new one. It
> increments nlookup so that the inode stays alive until the client
> releases it.
>
> Existing callers don't need the struct lo_inode so the function doesn't
> return it
On Mon, 1 Feb 2021 10:30:25 -0500
Programmingkid wrote:
>
>
> > On Feb 1, 2021, at 9:52 AM, Peter Maydell wrote:
> >
> > On Mon, 1 Feb 2021 at 14:49, Dan Streetman wrote:
> >>
> >> On Mon, Feb 1, 2021 at 9:23 AM Programmingkid
> >> wrote:
> >>>
> >>> When trying to build QEMU I see this
This is how linux restarts some system calls after SIGSTOP/SIGCONT.
This is needed to avoid virtiofsd termination when resuming execution
under GDB for example.
Signed-off-by: Greg Kurz
---
This has passed Travis and gitlab CI without errors.
tools/virtiofsd/passthrough_seccomp.c | 1 +
1
On Mon, 1 Feb 2021 17:14:40 +
Stefan Hajnoczi wrote:
> On Thu, Jan 28, 2021 at 06:44:16PM +0100, Greg Kurz wrote:
> > On Wed, 27 Jan 2021 11:21:31 +
> > Stefan Hajnoczi wrote:
> >
> > > A well-behaved FUSE client does not attempt to open special files wit
On Mon, 01 Feb 2021 12:30:52 +0100
Christian Schoenebeck wrote:
> On Montag, 1. Februar 2021 10:24:26 CET Greg Kurz wrote:
> > On Sun, 31 Jan 2021 19:23:52 +0100
> >
> > Christian Schoenebeck wrote:
> > > Hi,
> >
> > Hi Christian,
> >
> &g
On Sat, 30 Jan 2021 15:39:14 +0100
Christian Schoenebeck wrote:
> I already used this github URL for PRs before and will continue to use it in
> foreseeable future.
>
> Signed-off-by: Christian Schoenebeck
> ---
Reviewed-by: Greg Kurz
Unless you're planning to send a P
On Sun, 31 Jan 2021 19:23:52 +0100
Christian Schoenebeck wrote:
> Hi,
>
Hi Christian,
> I started setting up some developer documentation for 9pfs:
>
> https://wiki.qemu.org/Documentation/9p
>
> Still quite a bunch that should be added (e.g. there should be a section
> about
> thread
VuDev::vu_dispatch_rwlock.
Some users already check the return value and assert, some others
don't. Introduce rdlock/wrlock/unlock wrappers that just do the
former and use them everywhere.
Signed-off-by: Greg Kurz
---
tools/virtiofsd/fuse_virtio.c | 42 +++
1 file c
work with < 1GB of RAM");
> +if (machine->ram_size < mc->default_ram_size) {
> +char *sz = size_to_str(mc->default_ram_size);
> +error_report("Invalid RAM size, should be bigger than %s", sz);
> +
On Tue, 26 Jan 2021 13:33:36 -0500
Vivek Goyal wrote:
[...]
> >
> > Also, since pthread_rwlock_wrlock() can fail, I think we should
> > always check it's return value, at least with an assert() like
> > already done elsewhere.
>
> Will check return code of pthread_rwlock_wrlock() and probably
On Fri, 29 Jan 2021 10:39:12 +0100
Philippe Mathieu-Daudé wrote:
> On 1/29/21 10:29 AM, Cédric Le Goater wrote:
> > Any value below will result in a skiboot crash :
> >
> > [0.034949905,3] MEM: Partial overlap detected between regions:
> > [0.034959039,3] MEM: ibm,firmware-stacks
129 >
> [0.035104247,3] .
> [0.035108025,3] .
> [0.035111651,3] .
> [0.035115231,3] OO__)
> [0.035119198,3]<"__/
> [0.035122980,3] ^ ^
>
> Signed-off-by: Cédric Le Goater
> --
On Mon, 25 Jan 2021 13:01:12 -0500
Vivek Goyal wrote:
> Right now slave_read() is called through main event loop and does not
> return error. In next few patches I want to call slave_read() from
> vhost device shutdown path as well and want to know if an error
> happened so that caller can give u
t; of NVGPUs NUMA nodes presented in the guest, instead of just
> spapr->gpu_numa_id.
>
> Reported-by: Cédric Le Goater
> Tested-by: Cédric Le Goater
> Signed-off-by: Daniel Henrique Barboza
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr_numa.c | 4 +++-
> 1 file chan
On Wed, 27 Jan 2021 11:21:31 +
Stefan Hajnoczi wrote:
> A well-behaved FUSE client does not attempt to open special files with
> FUSE_OPEN because they are handled on the client side (e.g. device nodes
> are handled by client-side device drivers).
>
> The check to prevent virtiofsd from open
On Thu, 28 Jan 2021 12:17:31 -0300
Daniel Henrique Barboza wrote:
> The current logic for calculating 'maxdomain' making it a sum of
> numa_state->num_nodes with spapr->gpu_numa_id. spapr->gpu_numa_id is
> used as a index to determine the next available NUMA id that a
> given NVGPU can use.
>
>
On Thu, 28 Jan 2021 12:17:29 -0300
Daniel Henrique Barboza wrote:
> This function is used only in spapr_numa.c.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr.c | 9 -
> hw/ppc/spapr_numa.c| 9 +
> i
On Thu, 28 Jan 2021 12:17:28 -0300
Daniel Henrique Barboza wrote:
> Hi,
>
> Patches 02 and 03 contain fixes for a problem Cedric found out when
> booting TCG guests with multiple NUMA nodes. See patch 03 commit
> message for more info.
>
This paragraph mentions "TCG guests", but I see nothing
to paraphrase with a
comment.
> +spapr->gpu_numa_id = spapr_numa_initial_nvgpu_NUMA_id(machine);
>
This _NUMA_ looks a bit aggressive and not especially informative
to me. Maybe just make it spapr_numa_initial_nvgpu_id() ?
With these fixed,
Reviewed-by: Greg Kurz
>
On Thu, 28 Jan 2021 09:48:35 -0500
Vivek Goyal wrote:
> On Thu, Jan 28, 2021 at 03:31:23PM +0100, Greg Kurz wrote:
> > On Mon, 25 Jan 2021 13:01:11 -0500
> > Vivek Goyal wrote:
> >
> > > dev->slave_mutex needs to be taken when sending messages on slave_fd.
this helper in all the paths which send
> message on slave_fd channel.
>
Does this fix any known bug ?
> Signed-off-by: Vivek Goyal
> ---
LGTM
Reviewed-by: Greg Kurz
> subprojects/libvhost-user/libvhost-user.c | 50 ---
> 1 file changed, 27 insertions(+
On Thu, 28 Jan 2021 15:00:58 +0100
Miklos Szeredi wrote:
> On Thu, Jan 28, 2021 at 1:15 PM Greg Kurz wrote:
> >
> > On Wed, 27 Jan 2021 16:52:56 +0100
> > Miklos Szeredi wrote:
> >
> > > On Wed, Jan 27, 2021 at 4:47 PM Miklos Szeredi
> > > wrote:
On Wed, 27 Jan 2021 16:52:56 +0100
Miklos Szeredi wrote:
> On Wed, Jan 27, 2021 at 4:47 PM Miklos Szeredi wrote:
> >
> > On Wed, Jan 27, 2021 at 4:35 PM Greg Kurz wrote:
> > >
> > > On Wed, 27 Jan 2021 16:22:49 +0100
> > > Miklos Szeredi wrote:
>
On Thu, 28 Jan 2021 08:46:01 +0100
Cédric Le Goater wrote:
> On 1/28/21 1:46 AM, Joel Stanley wrote:
> > On Tue, 26 Jan 2021 at 17:14, Cédric Le Goater wrote:
> >>
> >> and reuse pnv_bmc_set_pnor() to share the setting of the PNOR.
> >>
> >> Signed-off-by: Cédric Le Goater
> >> ---
> >> hw/ppc
On Wed, 27 Jan 2021 15:33:51 +0100
Christian Schoenebeck wrote:
> On Freitag, 15. Januar 2021 14:50:17 CET Christian Schoenebeck wrote:
> > On Freitag, 15. Januar 2021 14:42:24 CET Greg Kurz wrote:
> > > I've already moved my repositories to gitlab for extra CI coverage
On Wed, 27 Jan 2021 16:22:49 +0100
Miklos Szeredi wrote:
> On Wed, Jan 27, 2021 at 4:09 PM Greg Kurz wrote:
> >
> > On Wed, 27 Jan 2021 15:09:50 +0100
> > Miklos Szeredi wrote:
> > > The semantics of O_CREATE are that it can fail neither because the
> >
On Wed, 27 Jan 2021 14:14:30 +
Stefan Hajnoczi wrote:
> On Wed, Jan 27, 2021 at 02:01:54PM +0100, Miklos Szeredi wrote:
> > On Wed, Jan 27, 2021 at 12:21 PM Stefan Hajnoczi
> > wrote:
> > }
> > > @@ -1654,9 +1677,11 @@ static void update_open_flags(int writeback, int
> > > al
On Wed, 27 Jan 2021 15:09:50 +0100
Miklos Szeredi wrote:
> On Wed, Jan 27, 2021 at 2:49 PM Greg Kurz wrote:
> >
> > On Wed, 27 Jan 2021 11:34:52 +0100
> > Miklos Szeredi wrote:
>
> > > Another solution specifically for O_CREAT without O_EXCL would be to
>
On Wed, 27 Jan 2021 11:34:52 +0100
Miklos Szeredi wrote:
> On Wed, Jan 27, 2021 at 11:20 AM Greg Kurz wrote:
> >
> > On Wed, 27 Jan 2021 10:25:28 +0100
> > Miklos Szeredi wrote:
> >
> > > On Tue, Jan 26, 2021 at 6:18 PM Greg Kurz wrote:
> > >
On Wed, 27 Jan 2021 10:25:28 +0100
Miklos Szeredi wrote:
> On Tue, Jan 26, 2021 at 6:18 PM Greg Kurz wrote:
> >
> > On Tue, 26 Jan 2021 10:35:02 +
> > Stefan Hajnoczi wrote:
>
> > The patch looks pretty good to me. It just seems to be missing a change in
&
On Tue, 26 Jan 2021 10:35:02 +
Stefan Hajnoczi wrote:
> A well-behaved FUSE client does not attempt to open special files with
> FUSE_OPEN because they are handled on the client side (e.g. device nodes
> are handled by client-side device drivers).
>
> The check to prevent virtiofsd from open
On Mon, 25 Jan 2021 13:01:10 -0500
Vivek Goyal wrote:
> When we are shutting down virtqueues, virtio_loop() receives a message
> VHOST_USER_GET_VRING_BASE from master. We acquire ->vu_dispatch_rwlock
> and get into the process of shutting down virtqueue. In one of the
> final steps, we are waitin
ian Schoenebeck
Message-Id: <20210118142300.801516-3-gr...@kaod.org>
Signed-off-by: Greg Kurz
---
hw/9pfs/9p.c | 41 ++---
hw/9pfs/9p.h | 4 ++--
2 files changed, 20 insertions(+), 25 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 37c3379b7462
This can only be 0 or 1.
Reviewed-by: Christian Schoenebeck
Message-Id: <20210118142300.801516-2-gr...@kaod.org>
Signed-off-by: Greg Kurz
---
hw/9pfs/9p.c | 4 ++--
hw/9pfs/9p.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
t fid.
Reviewed-by: Christian Schoenebeck
Message-Id: <20210121181510.1459390-1-gr...@kaod.org>
Signed-off-by: Greg Kurz
---
hw/9pfs/9p.c | 46 --
1 file changed, 32 insertions(+), 14 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index b
: <161035859647.1221144.4691749806675653934.st...@bahia.lan>
Signed-off-by: Greg Kurz
---
hw/9pfs/9p-proxy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/9pfs/9p-proxy.c b/hw/9pfs/9p-proxy.c
index 6f598a0f111c..4aa4e0a3baa0 100644
--- a/hw/9pfs/9p-proxy.c
+++ b/hw/9pfs/9p-proxy.c
@@
Use QSLIST instead of open-coding for a slightly improved readability.
No behavioral change.
Reviewed-by: Christian Schoenebeck
Message-Id: <20210122143514.215780-1-gr...@kaod.org>
Signed-off-by: Greg Kurz
---
hw/9pfs/9p.c | 17 -
hw/9pfs/9p.h | 2 +-
2 files chan
laim logic.
----
Greg Kurz (5):
9pfs/proxy: Check return value of proxy_marshal()
9pfs: Convert V9fsFidState::clunked to bool
9pfs: Convert V9fsFidState::fid_list to QSIMPLEQ
9pfs: Improve unreclaim loop
9pfs: Convert reclaim list to QSLIST
hw/9pfs/9p-pro
On Sat, 23 Jan 2021 13:36:34 +1100
Alexey Kardashevskiy wrote:
>
>
> On 23/01/2021 04:01, Greg Kurz wrote:
> > It is currently not possible to perform a strict boot from USB storage:
> >
> > $ qemu-system-ppc64 -accel kvm -nodefaults -nographic -serial stdi
provider hook.
Fixes: 85164ad4ed99 ("pseries: Update SLOF firmware image")
Signed-off-by: Greg Kurz
---
include/hw/pci-host/spapr.h | 2 ++
hw/ppc/spapr.c | 5 +
hw/ppc/spapr_pci.c | 33 ++---
3 files changed, 25 insertions(+), 15 del
Use QSLIST instead of open-coding for a slightly improved readability.
No behavioral change.
Signed-off-by: Greg Kurz
---
hw/9pfs/9p.c | 17 -
hw/9pfs/9p.h | 2 +-
2 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 3864d014b43c
On Fri, 22 Jan 2021 14:09:12 +0100
Christian Schoenebeck wrote:
> On Donnerstag, 21. Januar 2021 19:15:10 CET Greg Kurz wrote:
> > If a fid was actually re-opened by v9fs_reopen_fid(), we re-traverse the
> > fid list from the head in case some other request created a fid that
t fid.
Signed-off-by: Greg Kurz
---
v2: - fix typos in changelog
- drop bogus assert()
---
hw/9pfs/9p.c | 46 --
1 file changed, 32 insertions(+), 14 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index b65f320e6518..3864d014b43c 100644
---
On Thu, 21 Jan 2021 17:35:53 +
"Dr. David Alan Gilbert" wrote:
> * Greg Kurz (gr...@kaod.org) wrote:
> > This is how glibc implements lseek(2) on POWER.
> >
> > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1917692
> > Signed-off-by: Greg Ku
On Mon, 11 Jan 2021 10:49:56 +0100
Greg Kurz wrote:
> This should always successfully write exactly two 32-bit integers.
> Make it clear with an assert(), like v9fs_receive_status() and
> v9fs_receive_response() already do when unmarshalling the same
> header.
>
> Fixes: Co
This is how glibc implements lseek(2) on POWER.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1917692
Signed-off-by: Greg Kurz
---
tools/virtiofsd/passthrough_seccomp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/virtiofsd/passthrough_seccomp.c
b/tools/virtiofsd
On Mon, 18 Jan 2021 15:22:57 +0100
Greg Kurz wrote:
> clone of "master"
>
Drat... this text seems to have leaked from stgit and replaced
the one I had written in git publish:
---
We currently restart the unreclaim loop all over when we detect
that the current iteration y
501 - 600 of 5456 matches
Mail list logo
