Re: [PATCH v3] target/i386: Change wrong XFRM value

2023-04-06 Thread Huang, Kai
On Thu, 2023-04-06 at 02:40 -0400, Yang Zhong wrote: > The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with > FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):{ECX,EDX}, which made > SGX enclave only supported SSE and x87 feature(xfrm=0x3). I don't particularly like the sentence's second

Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory

2023-01-23 Thread Huang, Kai
On Mon, 2023-01-23 at 15:03 +0100, Vlastimil Babka wrote: > On 12/22/22 01:37, Huang, Kai wrote: > > > > I argue that this page pinning (or page migration prevention) is not > > > > tied to where the page comes from, instead related to how the page will > >

Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory

2022-12-22 Thread Huang, Kai
On Thu, 2022-12-22 at 18:15 +, Sean Christopherson wrote: > On Wed, Dec 21, 2022, Chao Peng wrote: > > On Tue, Dec 20, 2022 at 08:33:05AM +0000, Huang, Kai wrote: > > > On Tue, 2022-12-20 at 15:22 +0800, Chao Peng wrote: > > > > On Mon, Dec 19, 2022 at 08:4

Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory

2022-12-21 Thread Huang, Kai
On Wed, 2022-12-21 at 21:39 +0800, Chao Peng wrote: > > On Tue, Dec 20, 2022 at 08:33:05AM +, Huang, Kai wrote: > > > > On Tue, 2022-12-20 at 15:22 +0800, Chao Peng wrote: > > > > > > On Mon, Dec 19, 2022 at 08:48:10AM +, Huang, Kai wrote: > > >

Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory

2022-12-20 Thread Huang, Kai
On Tue, 2022-12-20 at 15:22 +0800, Chao Peng wrote: > On Mon, Dec 19, 2022 at 08:48:10AM +0000, Huang, Kai wrote: > > On Mon, 2022-12-19 at 15:53 +0800, Chao Peng wrote: > > > > > > > > [...] > > > > > > > > > + > > > > &g

Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory

2022-12-19 Thread Huang, Kai
On Mon, 2022-12-19 at 15:53 +0800, Chao Peng wrote: > > > > [...] > > > > > + > > > + /* > > > + * These pages are currently unmovable so don't place them into > > > movable > > > + * pageblocks (e.g. CMA and ZONE_MOVABLE). > > > + */ > > > + mapping = memfd->f_mapping; > > > + mapping_set_une

Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2022-12-13 Thread Huang, Kai
On Fri, 2022-12-02 at 14:13 +0800, Chao Peng wrote: >   > - /* flags is currently not used. */ > + /* 'flags' is currently not used. */ >   if (attrs->flags) >   return -EINVAL; Unintended code change.

Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory

2022-12-13 Thread Huang, Kai
> > memfd_restricted() itself is implemented as a shim layer on top of real > memory file systems (currently tmpfs). Pages in restrictedmem are marked > as unmovable and unevictable, this is required for current confidential > usage. But in future this might be changed. > > I didn't dig full his

Re: [PATCH] target/i386: Switch back XFRM value

2022-10-13 Thread Huang, Kai
On Thu, 2022-10-13 at 02:23 -0400, Yang Zhong wrote: > > > enclave only supported SSE and x87 feature(xfrm=0x3). > > > > Is this true?  Perhaps I am missing something, but it seems env- > > > features[FEAT_XSAVE_XCR0_LO] only includes LBR bit, which is bit 15. > >   We printed the XFRM value from

Re: [PATCH] target/i386: Switch back XFRM value

2022-10-12 Thread Huang, Kai
On Wed, 2022-10-12 at 04:26 -0400, Yang Zhong wrote: > The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with > FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):ECX, which made SGX ^ Nit: both ECX and EDX are wrongly set, but not only ECX. >

Re: [RFC] cpu_map: Remove pconfig from Icelake-Server CPU model

2019-09-30 Thread Huang, Kai
> > > future? > > [Robert Hoo] > > Thanks Eduardo for efforts in resolving this issue, introduced from my > > Icelake CPU > > model patch. > > I've no idea about PCONFIG's detail and plan. Let me sync with Huang, Kai > > and answer >

Re: [PATCH] x86: Add CPUID KVM support for new instruction WBNOINVD

2019-09-30 Thread Huang, Kai
On Mon, 2019-09-30 at 12:23 -0700, Jim Mattson wrote: > On Mon, Sep 30, 2019 at 10:54 AM Eduardo Habkost wrote: > > CCing qemu-devel. > > > > On Tue, Sep 24, 2019 at 01:30:04PM -0700, Jim Mattson wrote: > > > On Wed, Dec 19, 2018 at 1:02 PM Paolo Bonzini wrote: > > > > On 19/12/18 18:39, Jim Mat

Re: [Qemu-devel] kvm bug in __rmap_clear_dirty during live migration

2017-03-15 Thread Huang, Kai
Thanks! Thanks, -Kai On 3/14/2017 5:57 AM, Paolo Bonzini wrote: On 13/03/2017 15:58, fangying wrote: Hi, Huang Kai After weeks of intensive testing, we think the problem is solved and this issue can be closed. Thanks for the update. We got to the same conclusion. Paolo

Re: [Qemu-devel] kvm bug in __rmap_clear_dirty during live migration

2017-02-26 Thread Huang, Kai
On 2/25/2017 2:44 PM, Herongguang (Stephen) wrote: On 2017/2/24 23:14, Paolo Bonzini wrote: On 24/02/2017 16:10, Chris Friesen wrote: On 02/23/2017 08:23 PM, Herongguang (Stephen) wrote: On 2017/2/22 22:43, Paolo Bonzini wrote: Hopefully Gaohuai and Rongguang can help with this too.

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-07 Thread Huang, Kai
On 6/8/2016 6:46 AM, Alex Williamson wrote: On Tue, 7 Jun 2016 17:21:06 +1200 "Huang, Kai" wrote: On 6/7/2016 3:58 PM, Alex Williamson wrote: On Tue, 7 Jun 2016 11:20:32 +0800 Peter Xu wrote: On Mon, Jun 06, 2016 at 11:02:11AM -0600, Alex Williamson wrote: On Mon, 6 Jun 201

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-06 Thread Huang, Kai
On 6/7/2016 3:58 PM, Alex Williamson wrote: On Tue, 7 Jun 2016 11:20:32 +0800 Peter Xu wrote: On Mon, Jun 06, 2016 at 11:02:11AM -0600, Alex Williamson wrote: On Mon, 6 Jun 2016 21:43:17 +0800 Peter Xu wrote: On Mon, Jun 06, 2016 at 07:11:41AM -0600, Alex Williamson wrote: On Mon, 6 Jun

Re: [Qemu-devel] [PATCH] target-i386: add Skylake-Client cpu mode

2016-04-29 Thread Huang, Kai
Hi Guangrong, How about also add SGX to Skylake? Thanks, -Kai On 4/27/2016 8:13 PM, Xiao Guangrong wrote: From: Eduardo Habkost Introduce Skylake-Client cpu mode which inherits the features from Broadwell and supports some additional features that are: MPX, XSAVEC, XSAVES and XGETBV1 Note: