On Thu, Feb 13, 2014 at 09:59:40AM +0100, Kevin Wolf wrote:
Am 12.02.2014 um 18:36 hat Ian Main geschrieben:
This is the sister command to blockdev-add. In Fam's example he uses
the drive_del HMP command to clean up but it would be much nicer to
have a way to do this via QMP.
Signed
() in bdrv_set_backing_hd().
I've been using this patch and testing it for the last few weeks and it
all seems to be working very well. Kevin is waiting on more reviewers for
this rev before it can go in. Can someone else look through this please?
Tested-by: Ian Main im...@redhat.com
Fam Zheng (14
This is the sister command to blockdev-add. In Fam's example he uses
the drive_del HMP command to clean up but it would be much nicer to
have a way to do this via QMP.
Signed-off-by: Ian Main im...@redhat.com
---
v2:
- s/blockdev-delete/blockdev-del
- Fixed example.
blockdev.c | 52
On Sat, Feb 01, 2014 at 11:21:17PM +0800, Fam Zheng wrote:
On Fri, 01/31 19:00, Ian Main wrote:
On Wed, Jan 29, 2014 at 01:07:27PM +0800, Fam Zheng wrote:
This series adds for point-in-time snapshot NBD exporting based on
blockdev-backup (variant of drive-backup with existing device
On Wed, Jan 29, 2014 at 01:07:27PM +0800, Fam Zheng wrote:
This series adds for point-in-time snapshot NBD exporting based on
blockdev-backup (variant of drive-backup with existing device as target).
We get a thin point-in-time snapshot by COW mechanism of drive-backup, and
export it through
On Tue, Jan 28, 2014 at 03:31:36PM +0100, Stefan Hajnoczi wrote:
On Mon, Jan 27, 2014 at 11:48:06AM +0800, Fam Zheng wrote:
This series adds for point-in-time snapshot NBD exporting based on
blockdev-backup (variant of drive-backup with existing device as target).
We get a thin
On Wed, Jan 08, 2014 at 06:07:41PM +0800, Fam Zheng wrote:
This series adds for point-in-time snapshot NBD exporting based on
blockdev-backup (variant of drive-backup with existing device as target).
We get a thin point-in-time snapshot by COW mechanism of drive-backup, and
export it through
On Thu, Dec 12, 2013 at 04:23:36PM +0800, Fam Zheng wrote:
This series adds for point-in-time snapshot NBD exporting based on
blockdev-backup (variant of drive-backup with existing device as target).
We get a thin point-in-time snapshot by COW mechanism of drive-backup, and
export it through
On Wed, Dec 11, 2013 at 10:46:49AM +0800, Fam Zheng wrote:
On 2013年11月28日 16:39, Fam Zheng wrote:
This series adds for point-in-time snapshot NBD exporting based on
blockdev-backup (variant of drive-backup with existing device as target).
We get a thin point-in-time snapshot by COW mechanism
On Fri, Nov 22, 2013 at 01:47:26PM +0800, Fam Zheng wrote:
On 2013年11月20日 10:32, Ian Main wrote:
On Thu, Oct 17, 2013 at 01:36:41PM +0800, Fam Zheng wrote:
This series adds for point-in-time snapshot NBD exporting based on
blockdev-backup (variant of drive-backup with existing device as target
On Thu, Oct 17, 2013 at 01:36:41PM +0800, Fam Zheng wrote:
This series adds for point-in-time snapshot NBD exporting based on
blockdev-backup (variant of drive-backup with existing device as target).
In general this seems to work great. I did a bunch of testing and was
able to mount
On Mon, Jul 29, 2013 at 11:54:38AM +0100, Richard W.M. Jones wrote:
On Mon, Jul 29, 2013 at 06:16:48PM +0800, Fam Zheng wrote:
Ian's patches are in master, on which I already rebased the first. I can
rebase the other one for you if you feel like to test it too.
No that's fine, thanks. I
On Fri, Jul 26, 2013 at 08:58:16AM +0200, Paolo Bonzini wrote:
Il 26/07/2013 03:09, Ian Main ha scritto:
+/* See if we have a backing HD we can use to create our new image
+ * on top of. */
+source = bs-backing_hd;
+if (!source sync == MIRROR_SYNC_MODE_TOP
you want to copy.
V8:
- Fix qcow2 test for SYNC_MODE_NONE by shutting down VM before testing data.
Ian Main (2):
Implement sync modes for drive-backup.
Add tests for sync modes 'TOP' and 'NONE'
block/backup.c| 105 ++
blockdev.c
which again calls backup_do_cow() to write out
the old data so it can be preserved.
Signed-off-by: Ian Main im...@redhat.com
---
block/backup.c| 105 +-
blockdev.c| 25 +++
include/block/block_int.h | 4 +-
qmp
This patch adds tests for sync modes top and none. Test for 'TOP'
is separated out as it requires a backing file. Also added a test
for invalid format.
Signed-off-by: Ian Main im...@redhat.com
---
tests/qemu-iotests/055| 26 +--
tests/qemu-iotests/055.out| 4 +--
tests
This patch adds tests for sync modes top and none. Test for 'TOP'
is separated out as it requires a backing file. Also added a test
for invalid format.
Signed-off-by: Ian Main im...@redhat.com
---
tests/qemu-iotests/055| 6 +++
tests/qemu-iotests/055.out| 4 +-
tests/qemu-iotests
you want to copy.
V8:
- Fix qcow2 test for SYNC_MODE_NONE by shutting down VM before testing data.
V9:
- Make source drive bs for SYNC_MODE_NONE.
- Move SYNC_MODE_NONE test into 056.
Ian Main (2):
Implement sync modes for drive-backup.
Add tests for sync modes 'TOP' and 'NONE'
block
which again calls backup_do_cow() to write out
the old data so it can be preserved.
Signed-off-by: Ian Main im...@redhat.com
---
block/backup.c| 105 +-
blockdev.c| 29 +
include/block/block_int.h | 4 +-
qmp
This patch adds tests for sync modes top and none. Test for 'TOP'
is separated out as it requires a backing file. Also added a test
for invalid format.
Signed-off-by: Ian Main im...@redhat.com
---
tests/qemu-iotests/055| 26 +--
tests/qemu-iotests/055.out| 4 +--
tests
which again calls backup_do_cow() to write out
the old data so it can be preserved.
Signed-off-by: Ian Main im...@redhat.com
---
block/backup.c| 105 +-
blockdev.c| 25 +++
include/block/block_int.h | 4 +-
qmp
you want to copy.
Ian Main (2):
Implement sync modes for drive-backup.
Add tests for sync modes 'TOP' and 'NONE'
block/backup.c| 105 ++
blockdev.c| 25 ++
include/block/block_int.h | 4 +-
qmp
On Wed, Jul 24, 2013 at 12:55:43PM +0200, Kevin Wolf wrote:
Am 23.07.2013 um 00:09 hat Ian Main geschrieben:
This patch adds sync-modes to the drive-backup interface and
implements the FULL, NONE and TOP modes of synchronization.
FULL performs as before copying the entire contents
On Wed, Jul 24, 2013 at 01:19:18PM +0200, Kevin Wolf wrote:
Am 23.07.2013 um 00:09 hat Ian Main geschrieben:
This patch adds tests for sync modes top and none. Also added are tests
for invalid and missing formats.
Signed-off-by: Ian Main im...@redhat.com
---
tests/qemu-iotests/055
On Wed, Jul 24, 2013 at 02:32:53PM -0600, Eric Blake wrote:
On 07/24/2013 04:55 AM, Kevin Wolf wrote:
Unconditionally overriding format for NEW_IMAGE_MODE_EXISTING is
definitely wrong. It's the user's choice which COW format to use for the
backup image. There's no reason why it has to be
On Tue, Jul 23, 2013 at 01:53:51PM +0200, Stefan Hajnoczi wrote:
On Mon, Jul 22, 2013 at 03:09:17PM -0700, Ian Main wrote:
This patch adds sync modes on top of the work that Stefan Hajnoczi has done.
These patches apply on kevin/block.
Hopefully all is in order as this is my first
On Mon, Jul 22, 2013 at 02:07:15PM +0800, Fam Zheng wrote:
On Wed, 07/17 14:36, Paolo Bonzini wrote:
Il 17/07/2013 11:42, Fam Zheng ha scritto:
This option allows overriding backing hd of drive. If the target drive
exists, it's referenced as the backing file and refcount incremented.
On Wed, Jul 17, 2013 at 05:09:05PM +0200, Kevin Wolf wrote:
Am 17.07.2013 um 16:16 hat Paolo Bonzini geschrieben:
Il 17/07/2013 15:48, Kevin Wolf ha scritto:
I understand this is the right thing to do long term, but pre-opening of
the target is not really needed for fleecing.
So
to qcow2 patch not required.
Ian Main (3):
Implement sync modes for drive-backup.
Add tests for sync modes 'TOP' and 'NONE'
Add backing drive while performing backup.
block/backup.c| 107 +
blockdev.c| 36
-by: Ian Main im...@redhat.com
---
block/backup.c | 16
1 file changed, 16 insertions(+)
diff --git a/block/backup.c b/block/backup.c
index 68abd23..d32b3b7 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -323,6 +323,11 @@ static void coroutine_fn backup_run(void *opaque
This patch adds tests for sync modes top and none. Also added are tests
for invalid and missing formats.
Signed-off-by: Ian Main im...@redhat.com
---
tests/qemu-iotests/055| 108 +-
tests/qemu-iotests/055.out| 4 +-
tests/qemu-iotests/group
which again calls backup_do_cow() to write out
the old data so it can be preserved.
Signed-off-by: Ian Main im...@redhat.com
---
block/backup.c| 91 +++
blockdev.c| 36 ---
include/block/block_int.h | 4 ++-
qapi
This patch adds tests for sync modes top and none.
Signed-off-by: Ian Main im...@redhat.com
---
tests/qemu-iotests/055| 67 ---
tests/qemu-iotests/055.out| 4 +--
tests/qemu-iotests/group | 2 +-
tests/qemu-iotests/iotests.py | 5
backup.
- Add patch to default sync mode none to qcow2.
V5:
- Fix qcow2 patch. Forgot to git add final version.
Ian Main (4):
Implement sync modes for drive-backup.
Add tests for sync modes 'TOP' and 'NONE'
Add backing drive while performing backup.
Change default to qcow2 for sync mode
qcow2 supports backing files so it makes sense to default to qcow2
for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing
drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE
breaks tests but that could be fixed if we wanted it.
Signed-off-by: Ian Main im
which again calls backup_do_cow() to write out
the old data so it can be preserved.
Signed-off-by: Ian Main im...@redhat.com
---
block/backup.c| 91 +++
blockdev.c| 25 -
include/block/block_int.h | 4 ++-
qapi
-by: Ian Main im...@redhat.com
---
block/backup.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/block/backup.c b/block/backup.c
index 68abd23..e086e76 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -323,6 +323,10 @@ static void coroutine_fn backup_run(void *opaque
On Thu, Jul 18, 2013 at 01:54:45PM -0600, Eric Blake wrote:
On 07/18/2013 01:06 PM, Ian Main wrote:
On Thu, Jul 18, 2013 at 11:19:43AM -0600, Eric Blake wrote:
On 07/17/2013 02:04 PM, Ian Main wrote:
This patch adds sync-modes to the drive-backup interface and
implements the FULL, NONE
On Fri, Jul 19, 2013 at 01:41:10PM -0600, Eric Blake wrote:
On 07/19/2013 11:03 AM, Ian Main wrote:
This patch adds sync-modes to the drive-backup interface and
implements the FULL, NONE and TOP modes of synchronization.
Signed-off-by: Ian Main im...@redhat.com
---
block/backup.c
On Fri, Jul 19, 2013 at 04:11:13PM -0600, Eric Blake wrote:
On 07/19/2013 03:49 PM, Ian Main wrote:
+++ b/qapi-schema.json
@@ -1807,6 +1807,10 @@
# @format: #optional the format of the new destination, default is to
# probe if @mode is 'existing', else the format of the source
On Thu, Jul 18, 2013 at 11:32:52AM -0600, Eric Blake wrote:
On 07/18/2013 11:27 AM, Eric Blake wrote:
if (!has_format) {
-format = mode == NEW_IMAGE_MODE_EXISTING ? NULL :
bs-drv-format_name;
+format = mode == NEW_IMAGE_MODE_EXISTING ? NULL : qcow2;
Is this
On Thu, Jul 18, 2013 at 11:27:21AM -0600, Eric Blake wrote:
On 07/17/2013 02:04 PM, Ian Main wrote:
qcow2 supports backing files so it makes sense to default to qcow2
for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing
drive and export it via nbd. Defaulting FULL and TOP
qcow2 supports backing files so it makes sense to default to qcow2
for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing
drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE
breaks tests but that could be fixed if we wanted it.
Signed-off-by: Ian Main im
On Thu, Jul 18, 2013 at 11:19:43AM -0600, Eric Blake wrote:
On 07/17/2013 02:04 PM, Ian Main wrote:
This patch adds sync-modes to the drive-backup interface and
implements the FULL, NONE and TOP modes of synchronization.
FULL performs as before copying the entire contents of the drive
On Thu, Jul 18, 2013 at 12:56:51PM -0600, Eric Blake wrote:
On 07/18/2013 12:47 PM, Ian Main wrote:
qcow2 supports backing files so it makes sense to default to qcow2
for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing
drive and export it via nbd. Defaulting FULL and TOP
-by: Ian Main im...@redhat.com
---
block/backup.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/block/backup.c b/block/backup.c
index 68abd23..e086e76 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -323,6 +323,10 @@ static void coroutine_fn backup_run(void *opaque
This patch adds tests for sync modes top and none.
Signed-off-by: Ian Main im...@redhat.com
---
tests/qemu-iotests/055| 67 ---
tests/qemu-iotests/055.out| 4 +--
tests/qemu-iotests/group | 2 +-
tests/qemu-iotests/iotests.py | 5
which again calls backup_do_cow() to write out
the old data so it can be preserved.
Signed-off-by: Ian Main im...@redhat.com
---
block/backup.c| 91 +++
blockdev.c| 25 -
include/block/block_int.h | 4 ++-
qapi
backup.
- Add patch to default sync mode none to qcow2.
Ian Main (4):
Implement sync modes for drive-backup.
Add tests for sync modes 'TOP' and 'NONE'
Add backing drive while performing backup.
Change default to qcow2 for sync mode none.
block/backup.c| 104
qcow2 supports backing files so it makes sense to default to qcow2
for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing
drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE
breaks tests but that could be fixed if we wanted it.
Signed-off-by: Ian Main im
On Mon, Jul 15, 2013 at 10:47:25PM +0200, Paolo Bonzini wrote:
Il 15/07/2013 19:49, Ian Main ha scritto:
OK well, I'll explain here my understanding. I apologize if I explain
more than needed but it might be good to get this out there anyway.
No problem, it's better to be verbose than
On Mon, Jul 15, 2013 at 12:50:39PM +0200, Paolo Bonzini wrote:
Il 08/07/2013 11:21, Fam Zheng ha scritto:
Should the source be bs for MIRROR_SYNC_MODE_NONE? Also in this case
you may want to default the format to qcow2 instead of bs's format.
Maybe not. source only affects when
This patch adds tests for sync modes top and none.
Signed-off-by: Ian Main im...@redhat.com
---
tests/qemu-iotests/055| 67 ---
tests/qemu-iotests/055.out| 4 +--
tests/qemu-iotests/group | 2 +-
tests/qemu-iotests/iotests.py | 5
which again calls backup_do_cow() to write out
the old data so it can be preserved.
Signed-off-by: Ian Main im...@redhat.com
---
block/backup.c| 91 +++
blockdev.c| 25 -
include/block/block_int.h | 4 ++-
qapi
:
- No longer poll, instead use qemu_coroutine_yield().
- Use bdrv_co_is_allocated().
- Much better SYNC_MODE_NONE test.
V3:
- A few style fixes.
- Better commit message explaining how TOP and NONE operate.
- Verified using checkpatch.pl.
Ian Main (2):
Implement sync modes for drive-backup
This patch adds tests for sync modes top and none.
Signed-off-by: Ian Main im...@redhat.com
---
tests/qemu-iotests/055| 67 ---
tests/qemu-iotests/055.out| 4 +--
tests/qemu-iotests/group | 2 +-
tests/qemu-iotests/iotests.py | 5
changes to the topmost drive image and preserves the
point-in-time using CoW.
Signed-off-by: Ian Main im...@redhat.com
---
block/backup.c| 90 +++
blockdev.c| 25 -
include/block/block_int.h | 4 ++-
qapi-schema.json
:
- No longer poll, instead use qemu_coroutine_yield().
- Use bdrv_co_is_allocated().
- Much better SYNC_MODE_NONE test.
Ian Main (2):
Implement sync modes for drive-backup.
Add tests for sync modes 'TOP' and 'NONE'
block/backup.c| 90
On Fri, Jul 05, 2013 at 06:35:26PM -0700, Ian Main wrote:
This patch adds sync modes on top of the work that Stefan Hajnoczi has done.
These patches apply on kevin/block with
'[PATCH] block: add drive_backup HMP command' also applied.
Hopefully all is in order as this is my first QEMU
On Mon, Jul 01, 2013 at 02:16:12PM +0200, Paolo Bonzini wrote:
Il 28/06/2013 04:28, Ian Main ha scritto:
This patch adds sync-modes to the drive-backup interface and
implements the FULL, NONE and TOP modes of synchronization.
FULL performs as before copying the entire contents
tried my best to do a reasonable set of tests but feel that especially
SYNC_MODE_NONE could be better or perhaps that would be out of the scope
of the test framework. Suggestions welcome.
Ian Main (2):
Implement sync modes for drive-backup.
Add tests for sync modes 'TOP' and 'NONE'
block
changes to the topmost drive image and preserves the
point-in-time using CoW.
Signed-off-by: Ian Main im...@redhat.com
---
block/backup.c| 90 +++
blockdev.c| 25 -
include/block/block_int.h | 4 ++-
qapi-schema.json
This patch adds tests for sync modes top and none. I'd be interested in
hearing ideas on how to improve these tests if people feel they are
inadequate. Especially SYNC_MODE_NONE would be hard to test.
Signed-off-by: Ian Main im...@redhat.com
---
tests/qemu-iotests/055 | 63
On Tue, Jun 25, 2013 at 04:36:53PM +0200, Paolo Bonzini wrote:
Il 25/06/2013 16:06, Kevin Wolf ha scritto:
Am 25.06.2013 um 15:49 hat Paolo Bonzini geschrieben:
Il 25/06/2013 15:26, Kevin Wolf ha scritto:
+if (!full) {
+error_setg(errp, -f is not yet implemented);
+
64 matches
Mail list logo
