[Qemu-devel] [PATCH] MAINTAINERS: change Igor Mitsyanko's email address

2013-07-31 Thread Igor Mitsyanko
My email address in samsung.com domain is no longer accessible, change it to my personal gmail address. Signed-off-by: Igor Mitsyanko --- Currently I can't send patches properly with send-email command, I can only use gmail web interface for this. I'm not sure that it would apply clea

Re: [Qemu-devel] [PATCH arm-devs v3 1/1] sd/sd.c: Fix "inquiry" ACMD41

2013-05-27 Thread Igor Mitsyanko
* > + * We don't model init delay so just advance straight to ready > state > + * unless its an enquiry ACMD41 (bits 23:0 == 0). > + */ > + if (req.arg & ACMD41_ENQUIRY_MASK) { > sd->state = sd_ready_state; > +} > > return sd_r3; > > Reviewed-by: Igor Mitsyanko -- Best wishes, Igor Mitsyanko email: i.mitsya...@gmail.com

Re: [Qemu-devel] [PATCH arm-devs v1 1/5] sd/sd.c: Fix "inquiry" ACMD41

2013-05-23 Thread Igor Mitsyanko
On 05/23/2013 03:42 AM, Peter Crosthwaite wrote: > Hi Igor, > > On Wed, May 22, 2013 at 11:37 PM, Igor Mitsyanko > wrote: >> >> On 05/21/2013 10:50 AM, peter.crosthwa...@xilinx.com wrote: >> >> From: Peter Crosthwaite >> >> the SD command ACMD41

Re: [Qemu-devel] [PATCH arm-devs v1 5/5] sd/sdhci:ADMA: fix interrupt

2013-05-22 Thread Igor Mitsyanko
sen & SDHC_NISEN_DMA) { -s->norintsts |= SDHC_NIS_DMA; -} - -sdhci_update_irq(s); -return; -} } /* we have unfinished business - reschedule to continue ADMA */ Reviewed-by: Igor Mitsyanko -- Best wishes, Igor Mitsyanko email: i.mitsya...@gmail.com

Re: [Qemu-devel] [PATCH arm-devs v1 4/5] sd/sdhci.c: Fix bdata_read DPRINT message

2013-05-22 Thread Igor Mitsyanko
read %ub: addr[0x%04x] -> %u(0x%x)\n", size, offset, + ret, ret); return ret; } break; Reviewed-by: Igor Mitsyanko -- Best wishes, Igor Mitsyanko email: i.mitsya...@gmail.com

Re: [Qemu-devel] [PATCH arm-devs v1 1/5] sd/sd.c: Fix "inquiry" ACMD41

2013-05-22 Thread Igor Mitsyanko
that would confirm this change correctness, what about table "Table 4-29: Card State Transition Table" which states that ACMD41 is illegal in "ready" state? -- Best wishes, Igor Mitsyanko email: i.mitsya...@gmail.com

Re: [Qemu-devel] [PATCH arm-devs v1 3/5] sd/sdhci: Fix Buffer Write Ready interrupt

2013-05-22 Thread Igor Mitsyanko
/* Generate Block Gap Event if requested and if not the last block */ Reviewed-by: Igor Mitsyanko -- Best wishes, Igor Mitsyanko email: i.mitsya...@gmail.com

Re: [Qemu-devel] [PATCH arm-devs v1 2/5] sd/sdhci.c: Only reset data_count on new commands

2013-05-22 Thread Igor Mitsyanko
tate *s) static void sdhci_data_transfer(SDHCIState *s) { SDHCIClass *k = SDHCI_GET_CLASS(s); -s->data_count = 0; if (s->trnmod & SDHC_TRNS_DMA) { switch (SDHC_DMA_TYPE(s->hostctl)) { Reviewed-by: Igor Mitsyanko -- Best wishes, Igor Mitsyanko email: i.mitsya...@gmail.com

Re: [Qemu-devel] [PATCH] w32: Fix build with older gcc (unresolved symbol)

2013-05-11 Thread Igor Mitsyanko
On 11.05.2013 10:41, Stefan Weil wrote: Am 10.05.2013 22:14, schrieb Igor Mitsyanko: On 29.03.2013 21:20, Stefan Weil wrote: The cross i586-mingw32msvc-gcc 4.4.4 from Debian Squeeze does not support __sync_val_compare_and_swap by default. Using -march=i686 fixes that and should also result in

Re: [Qemu-devel] [PATCH] w32: Fix build with older gcc (unresolved symbol)

2013-05-10 Thread Igor Mitsyanko
th --build=mingw32 and looks like it defaults to -march=i386 (I have gcc version 4.7.2). Default build on windows is broken without this patch, it should be applied to 1.5 probably. Tested-by: Igor Mitsyanko configure |5 + 1 file changed, 5 insertions(+) diff --git a/configure b/confi

[Qemu-devel] [PATCH V2] osdep.h: include sys/types.h for ssize_t definition

2013-05-10 Thread Igor Mitsyanko
sys/types.h is taken out from "ifdef __OpenBSD__" guard. It should be safe for other systems, according to following survey: http://hacks.owlfolio.org/header-survey/ This fixes build for CONFIG_IOVEC-less systems (mingw). Signed-off-by: Igor Mitsyanko --- include/qemu/osdep.h | 2

[Qemu-devel] [RFC 7/7] pl181.c: convert to async IO SD card interface

2013-05-10 Thread Igor Mitsyanko
Signed-off-by: Igor Mitsyanko --- hw/sd/pl181.c | 302 +- 1 file changed, 192 insertions(+), 110 deletions(-) diff --git a/hw/sd/pl181.c b/hw/sd/pl181.c index 2caacc2..a8a3510 100644 --- a/hw/sd/pl181.c +++ b/hw/sd/pl181.c @@ -20,7 +20,7

[Qemu-devel] [RFC 5/7] sd.c: introduce async read operation

2013-05-10 Thread Igor Mitsyanko
It will only be used if start bit and databusy callbacks were initialized by user of SD card model. Signed-off-by: Igor Mitsyanko --- hw/sd/sd.c | 85 -- 1 file changed, 77 insertions(+), 8 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd

[Qemu-devel] [RFC 6/7] sd.c: introduce async write interface

2013-05-10 Thread Igor Mitsyanko
Signed-off-by: Igor Mitsyanko --- hw/sd/sd.c | 145 - 1 file changed, 133 insertions(+), 12 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 659ec56..615ab61 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -958,6 +958,11 @@ static

[Qemu-devel] [RFC 4/7] sd.c: use callbacks as a flag to use async IO

2013-05-10 Thread Igor Mitsyanko
This is temporary to distinguish between sync and async users. Signed-off-by: Igor Mitsyanko --- hw/sd/sd.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 2e75201..a0bbbaa 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -530,6 +530,10 @@ void sd_set_cb(SDState

[Qemu-devel] [RFC 1/7] sd.c: introduce AIO related members in SD state

2013-05-10 Thread Igor Mitsyanko
New state members will be used for async IO implementation later. Signed-off-by: Igor Mitsyanko --- hw/sd/sd.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 2e0ef3e..1dd1331 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -112,6 +112,10 @@ struct

[Qemu-devel] [RFC 3/7] sd.c: introduce "start bit" and "busy deasserted" callbacks

2013-05-10 Thread Igor Mitsyanko
Start bit callback models arrival of first bit of data on card's DAT line. Busy deasserted callback models releasing of DAT0 line by card when it transitions from a programming state to a writing data state. Both of them will be used for async IO later. Signed-off-by: Igor Mitsyanko ---

[Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking valid data

2013-05-10 Thread Igor Mitsyanko
Initialize it appropriately when various commands are processed. Signed-off-by: Igor Mitsyanko --- hw/sd/sd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 1dd1331..775a55c 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -116,6 +116,7 @@ struct SDState

[Qemu-devel] [RFC 0/7] Convert SD card model to AIO

2013-05-10 Thread Igor Mitsyanko
card model, no need to have another one in controller model. We can avoid intermediate copying from card's buffer to controller's buffer, and read/write directly from card. Tested by running this Fedora image https://fedoraproject.org/wiki/Architectures/ARM/F18/Versatile_Express on ve

Re: [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition

2013-05-10 Thread Igor Mitsyanko
On 05/10/2013 07:24 PM, Peter Maydell wrote: On 10 May 2013 16:16, Igor Mitsyanko wrote: This fixes build for mingw32 Signed-off-by: Igor Mitsyanko --- include/qemu/osdep.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 42545bc

[Qemu-devel] [PATCH V2 0/2] Fix memory migration for exynos 4210 SoC

2013-05-10 Thread Igor Mitsyanko
Fix issues in exynos4210 code which were blocking proper memory migration. V1->V2 PATCH1 now doesn't use memory_region_init_ram_ptr at all. Instead, it converts chipid memory to an mmio region. PATCH3 is dropped until hard freeze is over. It better be sent separately anyway. Igor Mits

[Qemu-devel] [PATCH V2 2/2] exynos4210.c: register rom_mem for memory migration

2013-05-10 Thread Igor Mitsyanko
From: Igor Mitsyanko Even if we do not register newly created RAM MemoryRegion for migration with vmstate_register_ram_global() function, ram_save_setup() still saves this region to snapshot file with empty idstr=="". Consequently this results in error during VM loading in ram_load()

[Qemu-devel] [PATCH V2 1/2] hw/arm/exynos4210.c: convert chipid_and_omr to an mmio region

2013-05-10 Thread Igor Mitsyanko
From: Igor Mitsyanko Exynos SoC was misusing memory_region_init_ram_ptr(): this interface can safely be used only for memory regions which size is a multiple of target page size. Change chipid_and_omr memory to an mmio region to fix this. Signed-off-by: Igor Mitsyanko --- hw/arm/exynos4210.c

[Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition

2013-05-10 Thread Igor Mitsyanko
This fixes build for mingw32 Signed-off-by: Igor Mitsyanko --- include/qemu/osdep.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 42545bc..17946a3 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -163,6 +163,8 @@ int

[Qemu-devel] [PATCH] ui/gtk.c: do not use gdk_display_warp_pointer when GTK ver >3.0

2013-05-10 Thread Igor Mitsyanko
lly change gdk_display_warp_pointer() method usage to gdk_device_warp usage, as suggested by compiler. Signed-off-by: Igor Mitsyanko --- ui/gtk.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index e12f228..841f912 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -331,6 +331,24 @@ s

Re: [Qemu-devel] [PATCH v4] hw/qdev-properties.c: Improve diagnostic for setting property after realize

2013-03-25 Thread Igor Mitsyanko
priate. > > hw/qdev-addr.c |2 +- > hw/qdev-properties-system.c |4 ++-- > hw/qdev-properties.c| 40 +++- > hw/qdev-properties.h | 12 > hw/qdev.c |2 +- > 5 files changed, 43 in

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Igor Mitsyanko
On 03/25/2013 02:37 PM, Gerd Hoffmann wrote: > >>Hi, >> >> [5425.580115] displaysurface_create_from surface=0x7ff315d3df40, >>> 800x600, bpp 16, bswap 0 [5425.580257] displaysurface_free >>> surface=0x7ff3158c33b0 >>> >> >> This is vga=0x314 >> >> Looks like we have some funky interaction betw

Re: [Qemu-devel] [PATCH v3 3/3] hw/arm_gic_common: Use vmstate struct rather than save/load functions

2013-03-22 Thread Igor Mitsyanko
TE_END_OF_LIST() > +} > +}; > + > +static const VMStateDescription vmstate_gic = { > +.name = "arm_gic", > +.version_id = 4, > +.minimum_version_id = 4, > +.pre_save = gic_pre_save, > +.post_load = gic_post_load, I've just fou

Re: [Qemu-devel] [PATCH v3 1/3] vmstate: Add support for two dimensional arrays

2013-03-22 Thread Igor Mitsyanko
n; the only difference is that the type check > has to change for a 2D array. > > Signed-off-by: Peter Maydell > --- > include/migration/vmstate.h | 27 +++ > 1 file changed, 27 insertions(+) > Reviewed-by: Igor Mitsyanko > diff --git a/include/

Re: [Qemu-devel] [PATCH 22/23] gtk: show a window for each graphical QemuConsole

2013-03-20 Thread Igor Mitsyanko
On 03/20/2013 01:43 PM, Gerd Hoffmann wrote: > >> Multihead support: For each graphical console we'll create a gtk >> window, so with multiple graphics cards installed you get a gtk window >> for each. vte tabs are attached to the console #0 window. >> --- >> ui/gtk.c | 40 +++

Re: [Qemu-devel] [PATCH 12/23] console: simplify screendump

2013-03-20 Thread Igor Mitsyanko
| 66 -- >> hw/vga_int.h |2 - >> hw/vmware_vga.c | 26 -- >> hw/xenfb.c |1 - >> include/ui/console.h |3 -- >> ui/console.c | 69 +++ >> 26 files changed, 69 insertions(+), 452 deletions(-) >> >> > Tested-by: Igor Mitsyanko

Re: [Qemu-devel] [PATCH 09/23] console: displaystate init revamp

2013-03-20 Thread Igor Mitsyanko
On 03/20/2013 01:43 PM, Gerd Hoffmann wrote: > >> We have only one DisplayState, so there is no need for the "next" >> linking, rip it. Also consolidate all displaystate initialization >> into init_displaystate(). This function is called by vl.c after >> creating the devices (and thus all QemuCon

Re: [Qemu-devel] [PATCH 07/23] console: switch color_table_rgb to pixman_color_t

2013-03-20 Thread Igor Mitsyanko
On 03/20/2013 01:43 PM, Gerd Hoffmann wrote: > >> Now that all text console rendering uses pixman we can easily >> switch the color tables to use pixman_color_t directly. >> >> Signed-off-by: Gerd Hoffmann >> --- >> ui/console.c | 24 >> 1 file changed, 8 insertions(+

[Qemu-devel] [PATCH 1/2] exynos4210_fimd.c: fix display resize bug introduced after console revamp

2013-03-19 Thread Igor Mitsyanko
function. Signed-off-by: Igor Mitsyanko --- hw/exynos4210_fimd.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/exynos4210_fimd.c b/hw/exynos4210_fimd.c index bf316c6..333456a 100644 --- a/hw/exynos4210_fimd.c +++ b/hw/exynos4210_fimd.c @@ -1243,7 +1243,7

[Qemu-devel] [PATCH 2/2] hw/vmware_vga.c: fix screen resize bug introduced after console revamp

2013-03-19 Thread Igor Mitsyanko
In vmsvga display update function, a pointer to DisplaySurface must be acquired after a call to vmsvga_check_size since this function might replace current DisplaySurface with a new one. Signed-off-by: Igor Mitsyanko --- hw/vmware_vga.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[Qemu-devel] [PATCH 0/2] Fix display resize bugs introduced after recent console revamp

2013-03-19 Thread Igor Mitsyanko
Bad things were happening in display update functions every time a screen has to be resized. Igor Mitsyanko (2): exynos4210_fimd.c: fix display resize bug introduced after console revamp hw/vmware_vga.c: fix screen resize bug introduced after console revamp hw/exynos4210_fimd.c

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm_gic_common: Use vmstate struct rather than save/load functions

2013-03-18 Thread Igor Mitsyanko
On Mar 19, 2013 12:21 AM, "Peter Maydell" wrote: > > On 18 March 2013 19:48, Igor Mitsyanko wrote: > >> On 03/18/2013 09:47 PM, Peter Maydell wrote: > >>> > >>> +VMSTATE_BUFFER_UNSAFE(last_active, GICState, 0, > >>> +

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm_gic_common: Use vmstate struct rather than save/load functions

2013-03-18 Thread Igor Mitsyanko
On 03/18/2013 09:47 PM, Peter Maydell wrote: > >> Update the GIC save/restore to use vmstate rather than hand-rolled >> save/load functions. >> >> Signed-off-by: Peter Maydell >> --- >> hw/arm_gic_common.c | 109 --** >> - >> 1 file changed, 42 i

Re: [Qemu-devel] [PATCH v2 1/2] arm_gic: Fix sizes of state fields in preparation for vmstate support

2013-03-18 Thread Igor Mitsyanko
t;> +uint8_t pending; >> +uint8_t active; >> +uint8_t level; >> +bool model; /* 0 = N:N, 1 = 1:N */ >> +bool trigger; /* nonzero = edge triggered. */ > > Maybe its worth to use true/false in comments too? Reviewed-by: Igor Mitsyanko

Re: [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage

2013-03-15 Thread Igor Mitsyanko
> On 03/15/2013 09:12 PM, Peter Maydell wrote: > >> On 10 March 2013 13:47, Igor Mitsyanko wrote: >> >>> hw/sd.c and hw/onenand.c were wrongly using VMSTATE_BUFFER_UNSAFE for >>> dynamically >>> allocated buffer migration, this was causing memory corr

Re: [Qemu-devel] [PATCH 3/3] memory_region_init_ram_ptr: only allow n*TARGET_PAGE_SIZE memory sizes

2013-03-10 Thread Igor Mitsyanko
On 10.03.2013 18:27, Peter Maydell wrote: On 10 March 2013 22:21, Igor Mitsyanko wrote: Registering memory regions using preallocated memory which size is not a multiple of target page size will result in inconsistency in QEMU memory system. Do not allow to do that at all by checking for that

[Qemu-devel] [PATCH 3/3] memory_region_init_ram_ptr: only allow n*TARGET_PAGE_SIZE memory sizes

2013-03-10 Thread Igor Mitsyanko
Registering memory regions using preallocated memory which size is not a multiple of target page size will result in inconsistency in QEMU memory system. Do not allow to do that at all by checking for that case (and asserting) in memory_region_init_ram_ptr(). Signed-off-by: Igor Mitsyanko

[Qemu-devel] [PATCH 2/3] exynos4210.c: register chipid_mem and rom_mem with vmstate

2013-03-10 Thread Igor Mitsyanko
nd rom_mem for migration. Signed-off-by: Igor Mitsyanko --- hw/exynos4210.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/exynos4210.c b/hw/exynos4210.c index 280d5d4..af741e2 100644 --- a/hw/exynos4210.c +++ b/hw/exynos4210.c @@ -221,6 +221,7 @@ Exyno

[Qemu-devel] [PATCH 1/3] hw/exynos4210.c: set chipid_and_omr array size to TARGET_PAGE_SIZE

2013-03-10 Thread Igor Mitsyanko
During initialization, memory region size is aligned to page size, but size of chipid_and_omr array is less then TARGET_PAGE_SIZE. This could result in errors in some cases, specifically, it could cause errors during VM migration. Signed-off-by: Igor Mitsyanko --- hw/exynos4210.c |2 +- 1

[Qemu-devel] [PATCH 0/3] Fix memory migration for exynos 4210 SoC

2013-03-10 Thread Igor Mitsyanko
First two patches fix issues in exynos4210 code which were blocking proper memory migration. Third patch makes memory_region_init_ram_ptr assert if memory region size is not a multiple of TARGET_PAGE_SIZE. Igor Mitsyanko (3): hw/exynos4210.c: set chipid_and_omr array size to TARGET_PAGE_SIZE

[Qemu-devel] [PATCH] qemu-char.c: fix waiting for telnet connection message

2013-03-10 Thread Igor Mitsyanko
666,server Signed-off-by: Igor Mitsyanko --- qemu-char.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 36295b1..789ee35 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2476,7 +2476,7 @@ static CharDriverState *qemu_chr_open_socket_fd(int

Re: [Qemu-devel] [PATCH 2/2] qemu-char: fix win32 build

2013-03-10 Thread Igor Mitsyanko
+699,8 @@ static int io_channel_send_all(GIOChannel *fd, const void *_buf, int len1) return len1 - len; } +#ifndef _WIN32 + typedef struct FDCharDriver { CharDriverState *chr; GIOChannel *fd_in, *fd_out; This patch fixes build for me. Tested-by: Igor Mitsyanko

[Qemu-devel] [PATCH 3/3] hw/onenand.c: fix migration of dynamically allocated buffer "otp"

2013-03-10 Thread Igor Mitsyanko
VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, not for buffers allocated dynamically. Change to VMSTATE_BUFFER_POINTER_UNSAFE macro, which will do migration right. Signed-off-by: Igor Mitsyanko --- hw/onenand.c |3 ++- 1 files changed, 2 insertions(+), 1

[Qemu-devel] [PATCH 2/3] hw/sd.c: fix migration of dynamically allocated buffer "buf"

2013-03-10 Thread Igor Mitsyanko
VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, not for buffers allocated dynamically. Change to VMSTATE_BUFFER_POINTER_UNSAFE macro, which will do migration right. Signed-off-by: Igor Mitsyanko --- hw/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[Qemu-devel] [PATCH 1/3] vmstate.h: introduce VMSTATE_BUFFER_POINTER_UNSAFE macro

2013-03-10 Thread Igor Mitsyanko
Macro could be used to migrate a dynamically allocated buffer of known size. Signed-off-by: Igor Mitsyanko --- include/migration/vmstate.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index f27276c

[Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage

2013-03-10 Thread Igor Mitsyanko
, should I bump it? Migration was never working for them anyway. Only tested hw/sd.c, by saving/loading a snapshot of VM while it was playing videofile from SD card. Igor Mitsyanko (3): vmstate.h: introduce VMSTATE_BUFFER_POINTER_UNSAFE macro hw/sd.c: fix migration of dynamically allocated

Re: [Qemu-devel] [PATCH 28/28] hw/sd.c: add SD card save/load support

2013-03-07 Thread Igor Mitsyanko
Peter Maydell: From: Igor Mitsyanko This patch updates SD card model to support save/load of card's state. +static const VMStateDescription sd_vmstate = { +.name = "sd-card", +.version_id = 1, +.minimum_version_id = 1, +.fields = (VMStateField[]) { +VMSTATE_

Re: [Qemu-devel] [PATCH v5 02/24] hw/arm: add Faraday a369 SoC platform support

2013-03-01 Thread Igor Mitsyanko
Hi, Kuo-Jung On 02/27/2013 11:15 AM, Kuo-Jung Su wrote: > From: Kuo-Jung Su > > The Faraday A369 EVB is a Faraday SoC platform evalution board used for > Faraday IP functional verification based on the well-known ARM AMBA 2.0 > architecture. > > Signed-off-by: Kuo-Jung Su > --- > hw/arm/Makefi

Re: [Qemu-devel] [PATCH v10 2/3] pl330: Initial version

2013-02-19 Thread Igor Mitsyanko
On 02/19/2013 09:53 PM, Peter Maydell wrote: On 19 February 2013 17:44, Igor Mitsyanko wrote: On 02/19/2013 11:46 AM, Peter Crosthwaite wrote: Device model for Primecell PL330 DMA controller. Signed-off-by: Peter Crosthwaite Signed-off-by: Kirill Batuzov Tested-by: Igor Mitsyanko Is my

Re: [Qemu-devel] [PATCH v9 0/3] Standard SD host controller model

2013-02-07 Thread Igor Mitsyanko
ATCH1: add support for ADMA1 (I havn't tested it though). fixed s->prnsts <-> s->pwrcon typo (thanks to Peter, strange that it even worked before). PATCH2: change header prefix from "target-arm" to "exynos4210" Igor Mitsyanko (1): hw: introduce

Re: [Qemu-devel] [PATCH v3 04/20] arm: add Faraday FTDDRII030 support

2013-02-07 Thread Igor Mitsyanko
On 02/06/2013 01:45 PM, Kuo-Jung Su wrote: From: Kuo-Jung Su The FTDDRII030 is a DDRII SDRAM controller which is responsible for SDRAM initialization. In QEMU we simply emualte the SDRAM enable function, neither timing parameter nor bank setup is handled. Signed-off-by: Kuo-Jung Su --- hw/a

Re: [Qemu-devel] [PATCH v3 01/20] arm: add Faraday a360 SoC platform support

2013-02-07 Thread Igor Mitsyanko
On 02/06/2013 01:45 PM, Kuo-Jung Su wrote: > From: Kuo-Jung Su > > The Faraday A360 EVB is a Faraday SoC platform evaluation board used for > Faraday IP functional verification based on the well-known ARM AMBA 2.0 > architecture. > > Signed-off-by: Kuo-Jung Su > --- > hw/arm/Makefile.objs |

Re: [Qemu-devel] [PATCH v3 02/20] arm: add Faraday a369 SoC platform support

2013-02-07 Thread Igor Mitsyanko
On 02/06/2013 01:45 PM, Kuo-Jung Su wrote: From: Kuo-Jung Su The Faraday A369 EVB is a Faraday SoC platform evalution board used for Faraday IP functional verification based on the well-known ARM AMBA 2.0 architecture. Signed-off-by: Kuo-Jung Su --- hw/arm/Makefile.objs |1 + hw

Re: [Qemu-devel] [PATCH v2 01/20] arm: add Faraday a36x SoC platform support

2013-01-31 Thread Igor Mitsyanko
Hi, Kuo-Jung, please see several comments bellow. On 01/25/2013 12:19 PM, Kuo-Jung Su wrote: From: Kuo-Jung Su The Faraday A360/A369 EVB is a Faraday platform main board used for the Faraday IP functional verification based on the well-known ARM AMBA 2.0 architecture. This main board provides

Re: [Qemu-devel] [PATCH v2 3/4] usb/ehci: Add SysBus EHCI device for Exynos4210

2012-12-17 Thread Igor Mitsyanko
On 12/16/2012 07:49 AM, Andreas Färber wrote: It uses a different capsbase and opregbase than the Xilinx device. Signed-off-by: Liming Wang Signed-off-by: Andreas Färber Cc: Igor Mitsyanko --- hw/usb/hcd-ehci-sysbus.c | 15 +++ hw/usb/hcd-ehci.h|2 ++ 2 Dateien

Re: [Qemu-devel] read memory by virtual address?

2012-12-03 Thread Igor Mitsyanko
On 12/03/2012 08:53 PM, Peter Cheung wrote: > Dear All > I can read memory by a physical > address "cpu_physical_memory_map()", but how can i read it by linear > address or virtual address? > > Thanks > from Peter Hi, Peter, you can use cpu_memory_rw_debug/cpu_get_phys_page_debug for this

Re: [Qemu-devel] [PATCH RFT 4/5] exynos4210: Add EHCI support

2012-12-03 Thread Igor Mitsyanko
C_ID_USB_HOST}, /* int combiner group 29 */ { EXT_GIC_ID_HSMMC0, EXT_GIC_ID_HSMMC1, EXT_GIC_ID_HSMMC2, EXT_GIC_ID_HSMMC3, EXT_GIC_ID_SDMMC }, Reviewed-by: Igor Mitsyanko -- Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsya...@samsung.com

Re: [Qemu-devel] [PATCH RFT 3/5] usb/ehci: Add SysBus EHCI device for Exynos4210

2012-12-03 Thread Igor Mitsyanko
On 12/02/2012 06:57 AM, Andreas Färber wrote: It uses a different capsbase and opregbase than the Xilinx device. Signed-off-by: Liming Wang Signed-off-by: Andreas Färber Cc: Igor Mitsyanko --- hw/usb/hcd-ehci-sysbus.c | 15 +++ hw/usb/hcd-ehci.h|2 ++ 2 Dateien

Re: [Qemu-devel] [PATCH RFT 2/5] usb/ehci: Move capsbase and opregbase into SysBus EHCI class

2012-12-03 Thread Igor Mitsyanko
.class_init= ehci_xlnx_class_init, }; static void ehci_sysbus_register_types(void) Reviewed-by: Igor Mitsyanko -- Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsya...@samsung.com

Re: [Qemu-devel] [PATCH RFT 1/5] usb/ehci: Clean up SysBus and PCI EHCI split

2012-12-03 Thread Igor Mitsyanko
S_DEVICE, .instance_size = sizeof(EHCISysBusState), +.abstract = true, .class_init= ehci_sysbus_class_init, }; +static const TypeInfo ehci_xlnx_type_info = { +.name = "xlnx,ps7-usb", +.parent= TYPE_SYS_BUS_EHCI, +}; + static

Re: [Qemu-devel] [PATCH 2/3] hw/arm_gic: Fix comparison with priority mask register

2012-12-01 Thread Igor Mitsyanko
DPRINTF("Raised pending IRQ %d\n", best_irq); Reviewed-by: Igor Mitsyanko

Re: [Qemu-devel] [PATCH 3/3] hw/arm_gic_common: Correct GICC_PMR reset value for newer GICs

2012-12-01 Thread Igor Mitsyanko
[0] = 0x100; /* The NVIC as a whole is always enabled. */ s->gic.enabled = 1; systick_reset(s); Reviewed-by: Igor Mitsyanko

Re: [Qemu-devel] [PATCH 1/3] hw/arm_boot, exynos4210, highbank: Fix secondary boot GIC init

2012-12-01 Thread Igor Mitsyanko
dings; highbank and exynos4210 will always be v7 CPUs. Signed-off-by: Peter Maydell --- hw/arm_boot.c | 17 ++--- hw/exynos4210.c | 10 +++--- hw/highbank.c |7 +-- 3 files changed, 26 insertions(+), 8 deletions(-) Reviewed-by: Igor Mitsyanko diff --git

Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine

2012-11-21 Thread Igor Mitsyanko
This version of patch doesn't change anything for majority of machines, its just that later we can choose ourself which default block interface to use. So, nothing to review from Exynos point of view, but patch is OK, except realview_pb_a8 part (see bellow): Acked-by: Igor Mitsyanko

Re: [Qemu-devel] [PATCH v7 1/3] hw: introduce standard SD host controller

2012-11-02 Thread Igor Mitsyanko
On 11/02/2012 06:21 AM, Peter Crosthwaite wrote: On Fri, Nov 2, 2012 at 3:21 AM, Igor Mitsyanko wrote: Hi, Peter, I did some testing and noticed significant performance reduction compared to previous version without transfer_timer. For read operation: Testcase (count x blocksize

Re: [Qemu-devel] [PATCH v7 1/3] hw: introduce standard SD host controller

2012-11-01 Thread Igor Mitsyanko
Hi, Peter, I did some testing and noticed significant performance reduction compared to previous version without transfer_timer. For read operation: Testcase (count x blocksize) previous version new version 1000x1Mb 10.9 Mb/s

Re: [Qemu-devel] [RFC] Configure option to turn on all debug printerfy

2012-10-31 Thread Igor Mitsyanko
On 10/31/2012 01:29 PM, Igor Mitsyanko wrote: On 10/31/2012 07:10 AM, Peter Crosthwaite wrote: So in a couple of cases now I have done work on mature device models that include #ifdef'd debug printfery that is broken, and have submitted (trivial) patches to fix. Whats happening is tree

Re: [Qemu-devel] [RFC] Configure option to turn on all debug printerfy

2012-10-31 Thread Igor Mitsyanko
On 10/31/2012 07:10 AM, Peter Crosthwaite wrote: So in a couple of cases now I have done work on mature device models that include #ifdef'd debug printfery that is broken, and have submitted (trivial) patches to fix. Whats happening is tree wide or automated changes (changing types of variables

Re: [Qemu-devel] [PATCH v2] arm_boot: Change initrd load address to "halfway through RAM"

2012-10-30 Thread Igor Mitsyanko
hwaddr dtb_start = TARGET_PAGE_ALIGN(info->initrd_start + + initrd_size); if (load_dtb(dtb_start, info)) { exit(1); } Reviewed-by: Igor Mitsyanko -- Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsya...@samsung.com

Re: [Qemu-devel] [PATCH v6 1/2] pl330: Initial version

2012-10-30 Thread Igor Mitsyanko
On 10/30/2012 05:35 AM, Peter Crosthwaite wrote: Device model for Primecell PL330 dma controller. Signed-off-by: Peter Crosthwaite Signed-off-by: Kirill Batuzov Tested-by: Igor Mitsyanko + +static void pl330_debug_exec(PL330 *s) +{ +uint8_t args[5]; +uint8_t opcode; +uint8_t

Re: [Qemu-devel] [PATCH v5 1/2] pl330: Initial version

2012-10-29 Thread Igor Mitsyanko
Good day, Peter) On 10/29/2012 10:35 AM, Peter Crosthwaite wrote: Device model for Primecell PL330 dma controller. + +static Property pl330_properties[] = { +/* CR0 */ +DEFINE_PROP_UINT8("num_chnls", PL330, num_chnls, 8), +DEFINE_PROP_UINT8("num_periph_req", PL330, num_periph_req, 8

Re: [Qemu-devel] [PATCH v3] hw/qdev-properties.c: Improve diagnostic for setting property after realize

2012-10-28 Thread Igor Mitsyanko
On 10/19/2012 9:57 PM, Peter Maydell wrote: Now we have error_setg() we can improve the error message emitted if you attempt to set a property of a device after the device is realized (the previous message was "permission denied" which was not very informative). Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH V5 3/3] hw/sd.c: add SD card save/load support

2012-10-28 Thread Igor Mitsyanko
This patch updates SD card model to support save/load of card's state. Signed-off-by: Igor Mitsyanko --- hw/sd.c | 89 +++-- 1 file changed, 64 insertions(+), 25 deletions(-) diff --git a/hw/sd.c b/hw/sd.c index b2f211c..3c

Re: [Qemu-devel] [PATCH] configure: use -Wwombat to test whether gcc recognizes -Wno-wombat

2012-10-28 Thread Igor Mitsyanko
uot; +if compile_prog "-Werror $optflag" "" ; then QEMU_CFLAGS="$QEMU_CFLAGS $flag" fi done Reviewed-by: Igor Mitsyanko

[Qemu-devel] [PATCH V5 2/3] vmstate: Add support for saving/loading bitmaps

2012-10-28 Thread Igor Mitsyanko
From: Peter Maydell Add support for saving/loading bitmap.h bitmaps in vmstate. Signed-off-by: Peter Maydell Tested-by: Igor Mitsyanko Reviewed-by: Juan Quintela --- savevm.c | 41 + vmstate.h | 13 + 2 files changed, 54 insertions

[Qemu-devel] [PATCH V5 1/3] hw/sd.c: Fix erase for high capacity cards

2012-10-28 Thread Igor Mitsyanko
Standard capacity cards SDSC use byte unit address while SDHC and SDXC cards use block unit address (512 bytes) when setting ERASE_START and ERASE_END with CMD32 and CMD33, we have to account for this. Signed-off-by: Igor Mitsyanko --- hw/sd.c | 17 + hw/sd.h | 1 + 2 files

[Qemu-devel] [PATCH V5 0/3] SD card model save/load support

2012-10-28 Thread Igor Mitsyanko
ngelog: v4->v5 - use new VMSTATE_BITMAP() macro for wpgroup bitmap; - give a names to SD card mode and state enums and refer to them in comments to .mode and .state SDState members; v3->v4 no change v2->v3 - don't use BITS_TO_LONGS when operating with bitfields; v1->v2 - use

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-27 Thread Igor Mitsyanko
On 10/27/2012 8:51 PM, Blue Swirl wrote: Thanks, applied. On Sun, Oct 14, 2012 at 8:00 PM, Peter Maydell wrote: Disable clang's initializer-overrides warnings, as QEMU makes significant use of the pattern of initializing an array with a range-based default entry like [0 ... 0x1ff] = { GPI

Re: [Qemu-devel] [PATCH V4 00/12] SD save/load support, SD qomification and bug fixes

2012-10-25 Thread Igor Mitsyanko
On 10/25/2012 07:47 PM, Peter Maydell wrote: On 10 August 2012 17:23, Igor Mitsyanko wrote: On 08/10/2012 07:06 PM, Peter Maydell wrote: On 27 July 2012 20:29, Igor Mitsyanko wrote: Igor Mitsyanko (12): hw/sd.c: convert wp_groups in SDState to bitfield hw/sd.c: make sd_wp_addr

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-19 Thread Igor Mitsyanko
On 09/19/2012 11:57 AM, Jan Kiszka wrote: On 2012-09-19 06:40, Peter Crosthwaite wrote: On Wed, Sep 19, 2012 at 2:32 PM, Edgar E. Iglesias wrote: On Wed, Sep 19, 2012 at 02:25:48PM +1000, Peter Crosthwaite wrote: Ping for PMM, This is the root case of your block on the SDHCI series - this is

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-19 Thread Igor Mitsyanko
On 09/19/2012 04:12 PM, Avi Kivity wrote: On 09/19/2012 02:46 PM, Edgar E. Iglesias wrote: On Wed, Sep 19, 2012 at 10:55:30AM +0300, Avi Kivity wrote: On 09/19/2012 07:40 AM, Peter Crosthwaite wrote: On Wed, Sep 19, 2012 at 2:32 PM, Edgar E. Iglesias wrote: On Wed, Sep 19, 2012 at 02:25:48PM

Re: [Qemu-devel] [PATCH v6 2/4] exynos4210: Added SD host controller model

2012-09-17 Thread Igor Mitsyanko
e.org/gmane.comp.emulators.qemu/169524, and the decision was to use runtime loop detection? Regards, Peter On Mon, 2012-08-06 at 16:29 +0400, Igor Mitsyanko wrote: On 08/06/2012 02:56 PM, Peter Maydell wrote: On 6 August 2012 04:25, Peter A. G. Crosthwaite wrote: +static uint64_t +exynos4210_sdhci_readfn

[Qemu-devel] [PATCH] arch_init.c: add missing '%' symbols before PRIu64 in debug printfs

2012-09-05 Thread Igor Mitsyanko
'%' symbols were missing in front of PRIu64 macros in DPRINTF() messages in arch_init.c, this caused compilation warnings when compiled with DEBUG_ARCH_INIT defined. Signed-off-by: Igor Mitsyanko --- arch_init.c |8 1 files changed, 4 insertions(+), 4 deletions(-) di

Re: [Qemu-devel] [PATCH 06/11] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-08-15 Thread Igor Mitsyanko
This patch broke master build, it causes compilation error with gcc 4.6.1: /home/mackross/eclipse_linux_cdt_space/qemu_exynos4/savevm.c: In function ‘xbzrle_encode_buffer’: /home/mackross/eclipse_linux_cdt_space/qemu_exynos4/savevm.c:2476:13: error: overflow in implicit constant conversion [-We

Re: [Qemu-devel] ARM patches for QEMU 1.2: final call

2012-08-10 Thread Igor Mitsyanko
On 08/10/2012 08:21 PM, Peter Maydell wrote: Last call for any ARM related patches to go into 1.2. My current queue looks like this: 59cbd70 hw/sd.c: make sd_wp_addr() return bool 8b4cc14 hw/sd.c: make sd_dataready() return bool 025caa6 hw/sd.c: convert binary variables to bool 38d24e6 hw/sd.c:

[Qemu-devel] [PATCH 1/3] exynos4210: drop "All rights reserved" line from files license

2012-08-10 Thread Igor Mitsyanko
It has been noted that "All rights reserved" statement conflicts with GPL, remove it. Signed-off-by: Igor Mitsyanko --- hw/exynos4210.c |2 +- hw/exynos4210.h |2 +- hw/exynos4210_combiner.c |3 +-- hw/exynos4210_fimd.c |3 +-- hw/exynos

[Qemu-devel] [PATCH 2/3] exynos4210.c: register chipid_mem and rom_mem with vmstate

2012-08-10 Thread Igor Mitsyanko
id_mem and rom_mem for migration to avoid this problem. Signed-off-by: Igor Mitsyanko --- hw/exynos4210.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/exynos4210.c b/hw/exynos4210.c index a3a06f7..94d2e41 100644 --- a/hw/exynos4210.c +++ b/hw/exynos4210.c @@ -20

[Qemu-devel] [PATCH 3/3] hw/exynos4210.c: set chipid_and_omr array size to TARGET_PAGE_SIZE

2012-08-10 Thread Igor Mitsyanko
, specifically, it could cause segfault during VM saving. Setting chipid_and_omr aray size to TARGET_PAGE_SIZE helps us to avoid any problems. Signed-off-by: Igor Mitsyanko --- hw/exynos4210.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210.c b/hw/exynos4210

[Qemu-devel] [PATCH 0/3 RESEND] Exynos4210: license and RAM vmstate fixes

2012-08-10 Thread Igor Mitsyanko
bably a bug too, but still.. Igor Mitsyanko (3): exynos4210: drop "All rights reserved" line from files license exynos4210.c: register chipid_mem and rom_mem with vmstate hw/exynos4210.c: set chipid_and_omr array size to TARGET_PAGE_SIZE hw/exynos4210.c |6 -- hw/exyno

Re: [Qemu-devel] [PATCH] vmstate: Add support for saving/loading bitmaps

2012-08-10 Thread Igor Mitsyanko
On 08/10/2012 08:30 PM, Peter Maydell wrote: On 10 August 2012 17:22, Igor Mitsyanko wrote: On 08/09/2012 03:54 PM, Peter Maydell wrote: --- a/vmstate.h +++ b/vmstate.h @@ -139,6 +139,7 @@ extern const VMStateInfo vmstate_info_uint64; extern const VMStateInfo vmstate_info_timer; extern

Re: [Qemu-devel] [PATCH V4 00/12] SD save/load support, SD qomification and bug fixes

2012-08-10 Thread Igor Mitsyanko
On 08/10/2012 07:06 PM, Peter Maydell wrote: On 27 July 2012 20:29, Igor Mitsyanko wrote: Igor Mitsyanko (12): hw/sd.c: convert wp_groups in SDState to bitfield hw/sd.c: make sd_wp_addr() accept 64 bit address argument hw/sd.c: introduce wrapper for conversion address to wp group

Re: [Qemu-devel] [PATCH] vmstate: Add support for saving/loading bitmaps

2012-08-10 Thread Igor Mitsyanko
sfully tested this patch with migration from 32bit to 64bit little endian host and vice versa. Haven’t tested with bigendian-littleendian migration since I don't have a bigendian machine at my disposal. Tested-by: Igor Mitsyanko

[Qemu-devel] [PATCH] exec.c: fix dirty bitmap reallocation

2012-08-10 Thread Igor Mitsyanko
ween real dirty page number and value in ram_list.dirty_pages variable, which in turn could (and will) result in errors during VM migration. Zero initialize new dirty bitmap bytes to fix this problem. Signed-off-by: Igor Mitsyanko --- exec.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-08-09 Thread Igor Mitsyanko
On 08/08/2012 08:25 PM, Andreas Färber wrote: Am 31.01.2012 15:01, schrieb Mitsyanko Igor: On 01/31/2012 05:15 PM, Andreas Färber wrote: Am 31.01.2012 00:53, schrieb Anthony Liguori: On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012 19:55, schrieb Juan Quintela: Please send in any

Re: [Qemu-devel] [PATCH v5 09/15] hw: Added generic FIFO API.

2012-08-06 Thread Igor Mitsyanko
On 08/07/2012 10:10 AM, Peter Crosthwaite wrote: + +extern const VMStateDescription vmstate_fifo8; + +#define VMSTATE_FIFO8(_field, _state) { \ +.name = (stringify(_field)), \ +.size = sizeof(Fifo8),

  1   2   3   >