[Qemu-devel] [PATCH 2/3] sdl2 uses surface relative coordinates

This patch fixes mouse positioning with -device usb-tablet and fullscreen or resized window. Fixes: 46522a82236ea0cf9011b89896d2d8f8ddaf2443 Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 30 -- 1 file changed, 4 insertions(+), 26 deletions(-) diff --git a/ui

[Qemu-devel] [PATCH v4] SDL2 various fixes

Hi, here is a respin of the three remaining patches, with checkpatch errors corrected. Also added the Fixes: line for "sdl2 uses surface relative coordinates", and an explaining comment to "sdl2: Ignore UI hotkeys". Regards, Jindrich

[Qemu-devel] [PATCH 3/3] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held

. Signed-off-by: Jindrich Makovicka --- include/ui/sdl2.h | 1 + ui/sdl2.c | 32 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h index b29cf803c9..51084e6320 100644 --- a/include/ui/sdl2.h +++ b/include/ui

[Qemu-devel] [PATCH 1/3] sdl2: Do not hide the cursor on auxilliary windows

Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 17 + 1 file changed, 17 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 53dd447fd2..290b57b1b3 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -463,6 +463,10 @@ static void handle_mousemotion(SDL_Event *ev) int max_x

[Qemu-devel] [PATCH 5/8] sdl2 uses surface relative coordinates

This patch fixes mouse positioning with -device usb-tablet and fullscreen or resized window. Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 677c22282d..51721d764e

[Qemu-devel] [PATCH 7/8] sdl2: Do not leave grab when fullscreen

Prevents displaying of a doubled mouse pointer when moving the pointer to the screen edges when fullscreen. Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index cdc599be48..6feb637739 100644 --- a/ui

[Qemu-devel] [PATCH 8/8] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held

. Signed-off-by: Jindrich Makovicka --- include/ui/sdl2.h | 1 + ui/sdl2.c | 25 - 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h index b29cf803c9..51084e6320 100644 --- a/include/ui/sdl2.h +++ b/include/ui/sdl2.h

[Qemu-devel] [PATCH 6/8] sdl2: Fix dead keyboard after fullsceen

Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 51721d764e..cdc599be48 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -418,6 +418,7 @@ static void handle_keyup(SDL_Event *ev) sdl2_reset_keys(scon

[Qemu-devel] [PATCH 4/8] sdl2: Do not hide the cursor on auxilliary windows

Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 17 + 1 file changed, 17 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 9cf4b1772b..677c22282d 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -465,6 +465,10 @@ static void handle_mousemotion(SDL_Event *ev) int max_x

[Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden

With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN blocks all subsequent display updates. Instead of trying to override the change, just update the scon->hidden flag. Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deleti

[Qemu-devel] [PATCH v3] SDL2 various fixes

Hi, here is an identical patchset with Signed-off-by. Regards, Jindrich

[Qemu-devel] [PATCH 3/8] sdl2: Use the same pointer show/hide logic for absolute and relative mode

Also use a proper enum parameter for SDL_ShowCursor Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index dfbd0de791..9cf4b1772b 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -169,10

[Qemu-devel] [PATCH 2/8] sdl2: Do not quit the emulator when an auxilliary window is closed

Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 774904cbf2..dfbd0de791 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -566,9 +566,14 @@ static void handle_windowevent(SDL_Event *ev

[Qemu-devel] [PATCH 8/8] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held

When SDL2 windows change focus while a key is held, the window that receives the focus also receives a new KeyDown event, without an autorepeat flag. This means that if a WM places the qemu console over the main window after Ctrl-Alt-2, the console closes immediately after opening. Then, the main w

[Qemu-devel] [PATCH 7/8] sdl2: Do not leave grab when fullscreen

Prevents displaying of a doubled mouse pointer when moving the pointer to the screen edges when fullscreen. --- ui/sdl2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index cdc599be48..6feb637739 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -451,8 +45

[Qemu-devel] [PATCH 6/8] sdl2: Fix dead keyboard after fullsceen

--- ui/sdl2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 51721d764e..cdc599be48 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -418,6 +418,7 @@ static void handle_keyup(SDL_Event *ev) sdl2_reset_keys(scon); return; } +sdl2_

[Qemu-devel] [PATCH 2/8] sdl2: Do not quit the emulator when an auxilliary window is closed

--- ui/sdl2.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 774904cbf2..dfbd0de791 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -566,9 +566,14 @@ static void handle_windowevent(SDL_Event *ev) update_displaychangelistener(&scon->dc

[Qemu-devel] [PATCH 4/8] sdl2: Do not hide the cursor on auxilliary windows

--- ui/sdl2.c | 17 + 1 file changed, 17 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 9cf4b1772b..677c22282d 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -465,6 +465,10 @@ static void handle_mousemotion(SDL_Event *ev) int max_x, max_y; struct sdl2_console *scon =

[Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden

With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN blocks all subsequent display updates. Instead of trying to override the change, just update the scon->hidden flag. --- ui/sdl2.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c

[Qemu-devel] [PATCH 5/8] sdl2 uses surface relative coordinates

This patch fixes mouse positioning with -device usb-tablet and fullscreen or resized window. --- ui/sdl2.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 677c22282d..51721d764e 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@

[Qemu-devel] [PATCH 3/8] sdl2: Use the same pointer show/hide logic for absolute and relative mode

Also use a proper enum parameter for SDL_ShowCursor --- ui/sdl2.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index dfbd0de791..9cf4b1772b 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -169,10 +169,10 @@ static void sdl_hide_curs

[Qemu-devel] [PATCH] SDL2 various fixes

Hi, here is a revised patchset: - sdl2: Do not hide the cursor on auxilliary windows split into two - sdl2: Only accept the hotkeys on the main window reworked, also with a more descriptive commit message - sdl2: Do not quit the emulator when an auxilliary window is closed added m

[Qemu-devel] [PATCH 7/7] sdl2: Do not leave grab when fullscreen

--- ui/sdl2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 3823f0a834..811c21da27 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -451,8 +451,9 @@ static void handle_mousemotion(SDL_Event *ev) SDL_GetWindowSize(scon->real_window, &scr_w, &

[Qemu-devel] [PATCH 5/7] sdl2 uses surface relative coordinates

--- ui/sdl2.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index fa54353430..092eab37dc 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -276,32 +276,8 @@ static void sdl_send_mouse_event(struct sdl2_console *scon, int dx, int dy

[Qemu-devel] [PATCH 6/7] sdl2: Fix dead keyboard after fullsceen

--- ui/sdl2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 092eab37dc..3823f0a834 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -418,6 +418,7 @@ static void handle_keyup(SDL_Event *ev) sdl2_reset_keys(scon); return; } +sdl2_

[Qemu-devel] [PATCH 4/7] sdl2: Only accept the hotkeys on the main window

--- ui/sdl2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 685e4fabec..fa54353430 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -349,7 +349,7 @@ static void handle_keydown(SDL_Event *ev) } gui_key_modifier_pressed = mod_state; -if (gui

[Qemu-devel] [PATCH 2/7] sdl2: Do not quit the emulator when an auxilliary window is closed

--- ui/sdl2.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 7f51933234..aa37b39547 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -566,9 +566,13 @@ static void handle_windowevent(SDL_Event *ev) update_displaychangelistener(&scon->dcl

[Qemu-devel] [PATCH 3/7] sdl2: Do not hide the cursor on auxilliary windows

--- ui/sdl2.c | 41 ++--- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index aa37b39547..685e4fabec 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -169,10 +169,10 @@ static void sdl_hide_cursor(void) return; }

[Qemu-devel] SDL2 various fixes

recently added terminals in multiple windows, and some issues with fullscreen mode and window scaling. I am using MATE desktop 1.18 and SDL 2.0.6. Regards, -- Jindrich Makovicka

[Qemu-devel] [PATCH 1/7] sdl2: Fix broken display updating after the window is hidden

With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN blocks all subsequent display updates. --- ui/sdl2.c | 5 - 1 file changed, 5 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 53dd447fd2..7f51933234 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -576,11 +576,6 @@ static vo

Re: [Qemu-devel] [PATCH] smoother sdl display & mouse

ld always get the low CPU load, unless they were > actaully interacting with the mouse/keyboard in which case it would > tune itself for interactive response. Sounds reasonable. Updated patch attached. -- Jindrich Makovicka diff -ur kvm-33.orig/qemu/sdl.c kvm-33/qemu/sdl.c --- kvm-33.orig/qemu/sdl

[Qemu-devel] [PATCH] smoother sdl display & mouse

it is possible to tune the refresh rate via the -sdl-decimate option. Please cc:, I am not a subscriber. Regards, -- Jindrich Makovicka diff -ur kvm-27.orig/qemu/sdl.c kvm-27/qemu/sdl.c --- kvm-27.orig/qemu/sdl.c 2007-06-03 10:27:40.0 +0200 +++ kvm-27/qemu/sdl.c 2007-06-05 22:28