[PATCH 1/2] python/machine: Add debug logging to key state changes

2022-10-24 Thread John Snow
ake a tastier soup. Signed-off-by: John Snow --- python/qemu/machine/machine.py | 18 ++ 1 file changed, 18 insertions(+) diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py index 37191f433b2..c467f951d5d 100644 --- a/python/qemu/machine/machine.py +++ b/p

Re: [PATCH] tests/avocado: raspi2_initrd: Wait for guest shutdown message before stopping

2022-10-20 Thread John Snow
'BCM2835') > exec_command_and_wait_for_pattern(self, 'cat /proc/iomem', > '/soc/cprman@7e101000') > -exec_command(self, 'halt') > +exec_command_and_wait_for_pattern(self, 'halt', 'reboot: System > halted') > # Wait for VM to shut down gracefully > self.vm.wait() LGTM! Already staged, but just for formality's sake: Reviewed-by: John Snow

Re: has anybody looked at the long-standing intermittent raspi2 avocado test failure?

2022-10-19 Thread John Snow
On Tue, Oct 18, 2022 at 6:23 AM Peter Maydell wrote: > > If you run this single avocado test: > > while ./build/x86/tests/venv/bin/avocado run > build/x86/tests/avocado/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_initrd > ; do true; done > > then on my machine it will fail within 4 or 5

Re: [PATCH] vmstate-static-checker:remove this redundant return

2022-10-13 Thread John Snow
ot;Name"] + "\", \"" + d["Name"] + "\"") > -return > > > def main(): > -- > 2.30.0.windows.2 > This can go through the trivial branch. Reviewed-by: John Snow

Re: [PATCH v2 20/39] tests/qtest: {ahci, ide}-test: Use relative path for temporary files for win32

2022-09-23 Thread John Snow
On Thu, Sep 22, 2022 at 4:03 PM Marc-André Lureau wrote: > > Hi > > On Tue, Sep 20, 2022 at 1:50 PM Bin Meng wrote: >> >> From: Bin Meng >> >> These test cases uses "blkdebug:path/to/config:path/to/image" for >> testing. On Windows, absolute file paths contain the delimiter ':' >> which causes t

Re: Maximum QMP reply size

2022-09-23 Thread John Snow
On Wed, Sep 7, 2022 at 7:54 AM Markus Armbruster wrote: > > John Snow writes: > > > Hi, I suspect I have asked this before, but I didn't write it down in > > a comment, so I forget my justification... > > > > In the QMP lib, we need to set a buffering limi

Maximum QMP reply size

2022-09-06 Thread John Snow
Hi, I suspect I have asked this before, but I didn't write it down in a comment, so I forget my justification... In the QMP lib, we need to set a buffering limit for how big a QMP message can be -- In practice, I found that the largest possible response was the QAPI schema reply, and I set the cod

Re: [qemu-web PATCH] Add signing pubkey for python-qemu-qmp package

2022-08-23 Thread John Snow
On Tue, Aug 23, 2022, 5:16 AM Andrea Bolognani wrote: > On Thu, Aug 18, 2022 at 12:53:58PM -0400, John Snow wrote: > > Add the pubkey currently used for signing PyPI releases of qemu.qmp to a > > stable location where it can be referenced by e.g. Fedora RPM specfiles. > > &g

Python test QMP Server implementation / version reply

2022-08-19 Thread John Snow
Hi Eric: Once upon a time I mentioned writing a QMP server implementation in Python. Now that the dust of the fork has (mostly) settled, I've rebased and uploaded that WIP here: https://gitlab.com/jsnow/python-qemu-qmp/-/commits/create_server/ Tracking issue: https://gitlab.com/qemu-project/pyth

[qemu-web PATCH] Add signing pubkey for python-qemu-qmp package

2022-08-18 Thread John Snow
...@redhat.com > pubkey > gpg --armor --export js...@redhat.com >> pubkey Signed-off-by: John Snow --- assets/keys/python-qemu-qmp.1.txt | 288 ++ 1 file changed, 288 insertions(+) create mode 100644 assets/keys/python-qemu-qmp.1.txt diff --git a/assets/k

Re: [RFC PATCH] tests/avocado: apply a band aid to aspeed-evb login

2022-08-11 Thread John Snow
e login prompt has appeared so we don't accidentally spaff the > shell commands to a confused getty in the guest. > > Signed-off-by: Alex Bennée > Cc: Cédric Le Goater > Cc: John Snow > --- > tests/avocado/machine_aspeed.py | 2 ++ > 1 file changed, 2 insertions(

Re: [PATCH V9 41/46] python/machine: QEMUMachine reopen_qmp_connection

2022-07-26 Thread John Snow
gt; None: > """ > Perform any cleanup that needs to happen before the VM exits. > -- > 1.8.3.1 > With applied fixup: Reviewed-by: John Snow

Re: [PATCH V9 40/46] python/machine: QEMUMachine full_args

2022-07-26 Thread John Snow
t; return self._args > > +@property > +def full_args(self) -> List[str]: > +"""Returns the full list of arguments used to launch QEMU.""" > +return list(self._qemu_full_args) > + > def _pre_launch(self) -> None: > if self._console_set: > self._remove_files.append(self._console_address) > -- > 1.8.3.1 > Reviewed-by: John Snow Acked-by: John Snow

Python package qemu.qmp v0.0.1 released

2022-07-22 Thread John Snow
cular order: Luiz, Hanna, Kevin, Vladimir, Kashyap, Eduardo, Cleber, Daniel, Niteesh, Willian, Beraldo, Wainer, Thomas, Eric, Paolo, Stefan, Andrea, and Victor. Thanks to my friends outside of work for their help, too; thanks Mike J.! Enjoy! --John Snow [1] https://gitlab.com/qemu-project/python-qemu-qmp/-/milestones

Re: [PATCH] util: Fix broken build on Haiku

2022-07-18 Thread John Snow
On Mon, Jul 18, 2022 at 1:20 PM Thomas Huth wrote: > > A recent commit moved some Haiku-specific code parts from oslib-posix.c > to cutils.c, but failed to move the corresponding header #include > statement, too, so "make vm-build-haiku.x86_64" is currently broken. > Fix it by moving the header #i

Re: [PATCH v4 00/12] Improve reliability of VM tests

2022-07-18 Thread John Snow
On Mon, Jul 18, 2022 at 4:17 AM Thomas Huth wrote: > > On 08/07/2022 17.34, John Snow wrote: > > Note: patches 10-12 are included for testing simplicity, they shouldn't > > be merged. They will be included in a forthcoming block PR. > > > > V4: > > >

Re: [PATCH v4 00/12] Improve reliability of VM tests

2022-07-12 Thread John Snow
On Fri, Jul 8, 2022 at 11:35 AM John Snow wrote: > > Note: patches 10-12 are included for testing simplicity, they shouldn't > be merged. They will be included in a forthcoming block PR. Patches 1-9 are fully reviewed. Whose tree should this go in? > > V4: > > - Addre

Re: [PATCH v2 01/11] acpi/tests/bits: initial commit of test scripts that are run by biosbits

2022-07-12 Thread John Snow
On Tue, Jul 12, 2022, 11:38 AM Ani Sinha wrote: > > > On Tue, 12 Jul 2022, John Snow wrote: > > > On Tue, Jul 12, 2022, 3:17 AM Ani Sinha wrote: > > > > > > > > > > > On Mon, 11 Jul 2022, John Snow wrote: > > > > > > > On

Re: [PATCH v2 01/11] acpi/tests/bits: initial commit of test scripts that are run by biosbits

2022-07-12 Thread John Snow
On Tue, Jul 12, 2022, 3:17 AM Ani Sinha wrote: > > > On Mon, 11 Jul 2022, John Snow wrote: > > > On Sun, Jul 10, 2022 at 1:01 PM Ani Sinha wrote: > > > > > > This is initial commit of cpuid, acpi and smbios python test scripts > for > > > bios

Re: [PATCH RESEND] python/machine: Fix AF_UNIX path too long on macOS

2022-07-12 Thread John Snow
On Mon, Jul 11, 2022, 9:46 PM Peter Delevoryas wrote: > On Mon, Jul 11, 2022 at 04:56:28PM -0400, John Snow wrote: > > On Thu, Jul 7, 2022 at 2:46 PM Peter Delevoryas wrote: > > > > > > On Wed, Jul 06, 2022 at 05:52:48PM -0700, Peter Delevoryas wrote: > > >

[RFC PATCH v3 5/7] tests: add 'check-venv' as a dependency of 'make check'

2022-07-11 Thread John Snow
ests, 'make check-venv-avocado'. Signed-off-by: John Snow --- tests/Makefile.include | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/Makefile.include b/tests/Makefile.include index d8af6a38112..d484a335be5 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -1

[RFC PATCH v3 7/7] iotests: self-bootstrap testing venv

2022-07-11 Thread John Snow
ll miss certain triggers to refresh the venv. It will miss when new dependencies are added to either python/setup.cfg or tests/setup.cfg. It can be coaxed into updating by running 'make check', 'make check-block', 'make check-venv', etc. Signed-off-by: John Snow --- tests

[RFC PATCH v3 1/7] tests: create optional tests/venv dependency groups

2022-07-11 Thread John Snow
see the subsequent commit "tests: Remove spurious pip warnings on Ubuntu20.04" for more information. Signed-off-by: John Snow --- tests/Makefile.include | 21 ++--- tests/requirements.txt | 6 -- tests/setup.cfg| 20 tests/setup.py | 1

[RFC PATCH v3 4/7] tests/vm: add venv pre-requisites to VM building recipes

2022-07-11 Thread John Snow
NetBSD needs "py37-pip" in order to create virtual environments. Signed-off-by: John Snow --- tests/vm/netbsd | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index 45aa9a7fda7..53fe508e487 100755 --- a/tests/vm/netbsd +++ b/tests/vm/netbsd @@ -

[RFC PATCH v3 3/7] tests: Remove spurious pip warnings on Ubuntu20.04

2022-07-11 Thread John Snow
ror does not seem to show up for the "qemu" package because we install that package in editable mode. (I think, but did not test, that installing an empty package in editable mode caused more problems than it fixed.) Signed-off-by: John Snow --- tests/mkvenv.py | 3 ++- 1 file change

[RFC PATCH v3 6/7] iotests: use tests/venv for running tests

2022-07-11 Thread John Snow
H. If the venv directory isn't found, raise a friendly exception that tries to give the human operator a friendly clue as to what's gone wrong. The subsequent commit attempts to address this shortcoming by teaching iotests how to invoke the venv bootstrapper in this circumstance instead.

[RFC PATCH v3 2/7] tests: pythonize test venv creation

2022-07-11 Thread John Snow
lly better. But, even if I did write it more generically here; iotests wouldn't be able to use it anyway, because importing it would mean more sys.path hacking. So... eh? Signed-off-by: John Snow --- tests/Makefile.include | 16 ++-- tests/mkvenv.py| 186 +++

[RFC PATCH v3 0/7] tests: run python tests under a venv

2022-07-11 Thread John Snow
as much of this forward as I can to try and get some testing in for RC phase to determine what problems might exist that I haven't noticed yet. --js John Snow (7): tests: create optional tests/venv dependency groups tests: pythonize test venv creation tests: Remove spurious pip warnings on Ubu

Re: [PATCH] iotests: fix source directory location

2022-07-11 Thread John Snow
On Fri, May 27, 2022, 12:29 PM Kevin Wolf wrote: > Am 26.05.2022 um 16:21 hat John Snow geschrieben: > > On Thu, May 26, 2022, 3:54 AM Daniel P. Berrangé > > wrote: > > > > > On Wed, May 25, 2022 at 08:25:12PM -0400, John Snow wrote: > > > > If you i

Re: [PATCH] python: QEMUMachine: enable qmp accept timeout by default

2022-07-11 Thread John Snow
On Mon, Jul 11, 2022 at 5:16 PM John Snow wrote: > > On Fri, Jun 24, 2022 at 3:53 PM Vladimir Sementsov-Ogievskiy > wrote: > > > > I've spent much time trying to debug hanging pipeline in gitlab. I > > started from and idea that I have problem in code in my ser

Re: [PATCH] python: QEMUMachine: enable qmp accept timeout by default

2022-07-11 Thread John Snow
the native asyncio interfaces I've been writing to help manage this, but in the meantime I think this is probably a reasonable concession and a more useful default. ...I think. Willing to take it for now and re-investigate when the other fixes make it to the tree. Reviewed-by: John Snow

Re: [PATCH RESEND] python/machine: Fix AF_UNIX path too long on macOS

2022-07-11 Thread John Snow
On Thu, Jul 7, 2022 at 2:46 PM Peter Delevoryas wrote: > > On Wed, Jul 06, 2022 at 05:52:48PM -0700, Peter Delevoryas wrote: > > On Wed, Jul 06, 2022 at 09:46:48AM -0700, Peter Delevoryas wrote: > > > On Wed, Jul 06, 2022 at 09:02:14AM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Jul 05, 2022

Re: [PATCH v2 10/11] pytest: add pytest to the meson build system

2022-07-11 Thread John Snow
On Sun, Jul 10, 2022 at 1:01 PM Ani Sinha wrote: > > Integrate the pytest framework with the meson build system. This will make > meson > run all the pytests under the pytest directory. > > Signed-off-by: Ani Sinha > --- > tests/Makefile.include | 4 +++- > tests/meson.build| 1 + >

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-11 Thread John Snow
On Sun, Jul 10, 2022 at 1:01 PM Ani Sinha wrote: > > This change adds python based test environment that can be used to run pytest > from within a virtual environment. A bash script sets up a virtual environment > and then runs the python based tests from within that environment. > All dependent p

Re: [PATCH v2 01/11] acpi/tests/bits: initial commit of test scripts that are run by biosbits

2022-07-11 Thread John Snow
On Sun, Jul 10, 2022 at 1:01 PM Ani Sinha wrote: > > This is initial commit of cpuid, acpi and smbios python test scripts for > biosbits to execute. No change has been made to them from the original code > written by the biosbits author Josh Triplett. They are required to be > installed > into th

Re: [PATCH] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type

2022-07-11 Thread John Snow
On Mon, Jul 11, 2022 at 4:30 PM John Snow wrote: > > On Mon, Jul 11, 2022 at 5:57 AM Thomas Huth wrote: > > > > 'returns-whitelist' has been renamed to 'command-returns-exceptions' in > > commit b86df3747848 ("qapi: Rename pragma *-whitelist to *

Re: [PATCH] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type

2022-07-11 Thread John Snow
# > # {'return': {}} is a QMPMessage, > # {} is the QMPReturnValue. > -- > 2.31.1 > May I cajole you to send a MR to https://gitlab.com/qemu-project/python-qemu-qmp ? (Sorry for the duplicated effort while the library isn't 100% split out of the tree yet.) In this case, for qemu.git: Reviewed-by: John Snow

Re: [PATCH] Replace 'whitelist' with 'allow'

2022-07-11 Thread John Snow
On Mon, Jul 11, 2022 at 5:53 AM Thomas Huth wrote: > > Let's use more inclusive language here and avoid terms > that are frowned upon nowadays. > > Signed-off-by: Thomas Huth Reviewed-by: John Snow > --- > docs/devel/submitting-a-patch.rst | 2 +- > docs/too

[PATCH v4 11/12] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-07-08 Thread John Snow
Do not merge: Staged in Hanna's branch. Signed-off-by: John Snow --- tests/qemu-iotests/108 | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108 index 9e923d6a59f..54e935acf28 100755 --- a/tests/qemu-iotests/108 +++ b/tests/qemu-iotest

[PATCH v4 03/12] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-07-08 Thread John Snow
The old CentOS image didn't work anymore because it was already EOL at the beginning of 2022. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé --- tests/vm/centos | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/vm/centos b/

[PATCH v4 06/12] tests/vm: remove ubuntu.i386 VM test

2022-07-08 Thread John Snow
ed to support this VM test anymore. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé --- tests/vm/Makefile.include | 3 +-- tests/vm/ubuntu.i386 | 40 --- 2 files changed, 1 insertion(+), 42 deletions(-) delete mode 1

[PATCH v4 01/12] qga: treat get-guest-fsinfo as "best effort"

2022-07-08 Thread John Snow
eturn stub information for these failed lookups. This allows test-qga to pass under docker tests, which are in turn used by the CentOS VM tests. Signed-off-by: John Snow --- qga/commands-posix.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/qga/commands-posix.c

[PATCH v4 02/12] tests/vm: use 'cp' instead of 'ln' for temporary vm images

2022-07-08 Thread John Snow
If the initial setup fails, you've permanently altered the state of the downloaded image in an unknowable way. Use 'cp' like our other test setup scripts do. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé --- tests/vm/centos | 2 +- 1

[PATCH v4 05/12] tests/vm: upgrade Ubuntu 18.04 VM to 20.04

2022-07-08 Thread John Snow
ation. (The checksum for the 18.04 image was already incorrect at the time of writing.) Just like the centos.aarch64 test, this test currently seems very flaky when run as a TCG test. Signed-off-by: John Snow Reviewed-by: Daniel P. Berrangé --- tests/vm/ubuntu.aarch64 | 10 +++--- 1 file ch

[PATCH v4 12/12] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-08 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Do not merge: this is a copy of Vladimir's fix that will be taken in through the iotests tree. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow --- tests/qemu-iotests/tests/copy-before-write | 5 + 1 file changed, 5 inser

[PATCH v4 09/12] tests/vm: Remove docker cross-compile test from CentOS VM

2022-07-08 Thread John Snow
our current CI infrastructure. Signed-off-by: John Snow Reviewed-by: Daniel P. Berrangé --- tests/vm/centos | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/vm/centos b/tests/vm/centos index 3a527c47b3d..097a9ca14d3 100755 --- a/tests/vm/centos +++ b/tests/vm/centos @@ -28,7 +28,6 @@

[PATCH v4 07/12] tests/vm: remove duplicate 'centos' VM test

2022-07-08 Thread John Snow
This is listed twice by accident; we require genisoimage to run the test, so remove the unconditional entry. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé --- tests/vm/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v4 08/12] tests/vm: add 1GB extra memory per core

2022-07-08 Thread John Snow
vided, can still override it. Signed-off-by: John Snow Reviewed-by: Daniel P. Berrangé --- tests/vm/basevm.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index d7d0413df35..4fd9af10b7f 100644 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -9

[PATCH v4 10/12] tests/qemu-iotests: hotfix for 307, 223 output

2022-07-08 Thread John Snow
Do not merge; staged in Hanna's branch. Signed-off-by: John Snow --- tests/qemu-iotests/223.out | 4 ++-- tests/qemu-iotests/307.out | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/223.out b/tests/qemu-iotests/223.out index 06479415312..26fb34

[PATCH v4 00/12] Improve reliability of VM tests

2022-07-08 Thread John Snow
rking reliably under TCG - Upgrade ubuntu.aarch64 to 20.04 after fixing centos.aarch64 - Fix the Haiku build test, if possible. - Ensure I can reliably run and pass "make vm-build-all". (Remove VMs from this recipe if necessary.) John Snow (11): qga: treat get-guest-fsinfo as "best eff

Re: [PATCH v3 10/13] tests/vm: Remove docker cross-compile test from CentOS VM

2022-07-07 Thread John Snow
On Thu, Jul 7, 2022 at 4:33 AM Daniel P. Berrangé wrote: > > On Thu, Jul 07, 2022 at 12:03:07AM -0400, John Snow wrote: > > The fedora container has since been split apart, so there's no suitable > > nearby target that would support "test-mingw" as it requires b

Re: [PATCH v3 09/13] tests/vm: upgrade Ubuntu 18.04 VM to 20.04

2022-07-07 Thread John Snow
On Thu, Jul 7, 2022 at 7:05 AM Richard Henderson wrote: > > On 7/7/22 09:33, John Snow wrote: > > 18.04 has fallen out of our support window, so move ubuntu.aarch64 > > forward to ubuntu 20.04, which is now our oldest supported Ubuntu > > release. > > Ah. Squash wi

Re: [PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort"

2022-07-07 Thread John Snow
On Thu, Jul 7, 2022 at 4:40 AM Marc-André Lureau wrote: > > Hi > > On Thu, Jul 7, 2022 at 8:10 AM John Snow wrote: >> >> In some container environments, there may be references to block devices >> witnessable from a container through /proc/self/mountinfo that refere

[PATCH v3 13/13] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-06 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Do not merge: this is a copy of Vladimir's fix that will be taken in through the iotests tree. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow --- tests/qemu-iotests/tests/copy-before-write | 5 + 1 file changed, 5 inser

[PATCH v3 03/13] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-07-06 Thread John Snow
The old CentOS image didn't work anymore because it was already EOL at the beginning of 2022. Signed-off-by: John Snow Reviewed-by: Thomas Huth --- tests/vm/centos | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/vm/centos b/tests/vm/centos index be4f6f

[PATCH v3 10/13] tests/vm: Remove docker cross-compile test from CentOS VM

2022-07-06 Thread John Snow
our current CI infrastructure. Signed-off-by: John Snow --- tests/vm/centos | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/vm/centos b/tests/vm/centos index 3a527c47b3d..097a9ca14d3 100755 --- a/tests/vm/centos +++ b/tests/vm/centos @@ -28,7 +28,6 @@ class CentosVM(basevm.BaseVM):

[PATCH v3 12/13] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-07-06 Thread John Snow
Do not merge: Staged in Hanna's branch. Signed-off-by: John Snow --- tests/qemu-iotests/108 | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108 index 9e923d6a59f..54e935acf28 100755 --- a/tests/qemu-iotests/108 +++ b/tests/qemu-iotest

[PATCH v3 05/13] tests/vm: update sha256sum for ubuntu.aarch64

2022-07-06 Thread John Snow
This checksum changes weekly; use a fixed point image and update the checksum so we don't have to re-download it quite so much. Note: Just like the centos.aarch64 test, this test currently seems very flaky when run as a TCG test. Signed-off-by: John Snow --- tests/vm/ubuntu.aarch6

[PATCH v3 09/13] tests/vm: upgrade Ubuntu 18.04 VM to 20.04

2022-07-06 Thread John Snow
18.04 has fallen out of our support window, so move ubuntu.aarch64 forward to ubuntu 20.04, which is now our oldest supported Ubuntu release. Signed-off-by: John Snow --- tests/vm/ubuntu.aarch64 | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm

[PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort"

2022-07-06 Thread John Snow
eturn stub information for these failed lookups. This allows test-qga to pass under docker tests, which are in turn used by the CentOS VM tests. Signed-off-by: John Snow --- qga/commands-posix.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/com

[PATCH v3 02/13] tests/vm: use 'cp' instead of 'ln' for temporary vm images

2022-07-06 Thread John Snow
If the initial setup fails, you've permanently altered the state of the downloaded image in an unknowable way. Use 'cp' like our other test setup scripts do. Signed-off-by: John Snow Reviewed-by: Thomas Huth --- tests/vm/centos | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v3 11/13] tests/qemu-iotests: hotfix for 307, 223 output

2022-07-06 Thread John Snow
Do not merge; staged in Hanna's branch. Signed-off-by: John Snow --- tests/qemu-iotests/223.out | 4 ++-- tests/qemu-iotests/307.out | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/223.out b/tests/qemu-iotests/223.out index 06479415312..26fb34

[PATCH v3 00/13] Improve reliability of VM tests

2022-07-06 Thread John Snow
x the Haiku build test, if possible. - Ensure I can reliably run and pass "make vm-build-all". (Remove VMs from this recipe if necessary.) John Snow (12): qga: treat get-guest-fsinfo as "best effort" tests/vm: use 'cp' instead of 'ln' for temporary vm i

[PATCH v3 08/13] tests/vm: add 1GB extra memory per core

2022-07-06 Thread John Snow
vided, can still override it. Signed-off-by: John Snow --- tests/vm/basevm.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index d7d0413df35..4fd9af10b7f 100644 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -99,6 +99,11 @@ def __init__(

[PATCH v3 07/13] tests/vm: remove duplicate 'centos' VM test

2022-07-06 Thread John Snow
This is listed twice by accident; we require genisoimage to run the test, so remove the unconditional entry. Signed-off-by: John Snow Reviewed-by: Thomas Huth --- tests/vm/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/Makefile.include b/tests/vm

[PATCH v3 06/13] tests/vm: remove ubuntu.i386 VM test

2022-07-06 Thread John Snow
ed to support this VM test anymore. Signed-off-by: John Snow Reviewed-by: Thomas Huth --- tests/vm/Makefile.include | 3 +-- tests/vm/ubuntu.i386 | 40 --- 2 files changed, 1 insertion(+), 42 deletions(-) delete mode 100755 tests/vm/ubuntu.i386 diff --

Re: [PULL v2 0/9] Block jobs & NBD patches

2022-07-01 Thread John Snow
On Wed, Jun 29, 2022 at 7:18 PM Richard Henderson wrote: > > On 6/29/22 13:45, Vladimir Sementsov-Ogievskiy wrote: > > The following changes since commit ad4c7f529a279685da84297773b4ec8080153c2d: > > > >Merge tag 'pull-semi-20220628' of https://gitlab.com/rth7680/qemu into > > staging (2022-0

Re: [PATCH v2 02/10] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-07-01 Thread John Snow
On Fri, Jul 1, 2022 at 4:05 AM Hanna Reitz wrote: > > On 16.06.22 16:26, John Snow wrote: > > In certain container environments we may not have FUSE at all, so skip > > the test in this circumstance too. > > > > Signed-off-by: John Snow > > --- > > tes

Re: [PATCH v2 0/3] python/qemu/machine: fix potential hang in QMP accept

2022-06-30 Thread John Snow
On Thu, Jun 30, 2022 at 8:34 AM wrote: > > From: Marc-André Lureau > > Hi, > > As reported earlier by Richard Henderson ("virgl avocado hang" thread), > avocado > tests may hang when QEMU exits before the QMP connection is established. > > v2: > - use a socketpair() for QMP (instead of async co

Re: [PATCH 2/2] python/qemu/machine: accept QMP connection asynchronously

2022-06-30 Thread John Snow
On Thu, Jun 30, 2022 at 4:23 AM Daniel P. Berrangé wrote: > > On Wed, Jun 29, 2022 at 07:54:08PM -0400, John Snow wrote: > > On Tue, Jun 28, 2022 at 10:17 AM Daniel P. Berrangé > > wrote: > > > > > > On Tue, Jun 28, 2022 at 05:49:39PM +0400, marc

Re: [PATCH 2/2] python/qemu/machine: accept QMP connection asynchronously

2022-06-29 Thread John Snow
On Tue, Jun 28, 2022 at 10:17 AM Daniel P. Berrangé wrote: > > On Tue, Jun 28, 2022 at 05:49:39PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > QMP accept is currently synchronous. If qemu dies before the connection > > is established, it will wait there. Instead t

Re: [PATCH 0/2] python/qemu/machine: fix potential hang in QMP accept

2022-06-28 Thread John Snow
On Tue, Jun 28, 2022 at 9:49 AM wrote: > > From: Marc-André Lureau > > Hi, > > As reported earlier by Richard Henderson ("virgl avocado hang" thread), > avocado > tests may hang when QEMU exits before the QMP connection is established. > > My proposal to fix the problem here is to do both accept

Re: [PATCH] iotests/297: Have mypy ignore unused ignores

2022-06-21 Thread John Snow
nt_casts = True > warn_unused_configs = True > -warn_unused_ignores = True > +warn_unused_ignores = False > -- > 2.35.3 > I'm away for the week, but: Acked-By: John Snow 🙂 >

Re: [PATCH v2 00/10] Improve reliability of VM tests

2022-06-17 Thread John Snow
On Thu, Jun 16, 2022 at 10:27 AM John Snow wrote: > > This patch series attempts to improve the reliability of several of the > VM test targets. In particular, both CentOS 8 tests are non-functional > because CentOS 8 was EOL at the beginning of this calendar year, with > repositor

Re: [PATCH V8 38/39] python/machine: add QEMUMachine accessors

2022-06-17 Thread John Snow
On Wed, Jun 15, 2022, 11:27 AM Steve Sistare wrote: > Provide full_args() to return all command-line arguments used to start a > vm, some of which are not otherwise visible to QEMUMachine clients. This > is needed by the cpr test, which must start a vm, then pass all qemu > command-line argument

Re: [PATCH v2 03/10] qga: treat get-guest-fsinfo as "best effort"

2022-06-17 Thread John Snow
On Fri, Jun 17, 2022, 5:49 AM Daniel P. Berrangé wrote: > On Thu, Jun 16, 2022 at 06:35:44PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Thu, Jun 16, 2022 at 6:27 PM John Snow wrote: > > > > > In some container environments, there may be references

Re: [PATCH v2 03/10] qga: treat get-guest-fsinfo as "best effort"

2022-06-16 Thread John Snow
On Thu, Jun 16, 2022 at 10:36 AM Marc-André Lureau wrote: > > Hi > > On Thu, Jun 16, 2022 at 6:27 PM John Snow wrote: >> >> In some container environments, there may be references to block devices >> witnessable from a container through /proc/self/mountinfo that

[PATCH v2 07/10] tests/vm: update sha256sum for ubuntu.aarch64

2022-06-16 Thread John Snow
This checksum changes weekly; use a fixed point image and update the checksum so we don't have to re-download it quite so much. Note: Just like the centos.aarch64 test, this test currently seems very flaky when run as a TCG test. Signed-off-by: John Snow --- tests/vm/ubuntu.aarch6

[PATCH v2 02/10] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-16 Thread John Snow
In certain container environments we may not have FUSE at all, so skip the test in this circumstance too. Signed-off-by: John Snow --- tests/qemu-iotests/108 | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108 index 9e923d6a59f..54e935acf28

[PATCH v2 10/10] tests/vm: add 512MB extra memory per core

2022-06-16 Thread John Snow
rride it. Signed-off-by: John Snow --- tests/vm/basevm.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index d7d0413df35..69200ca5f1e 100644 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -99,6 +99,12 @@ def __init__(self, args, config

[PATCH v2 01/10] tests/qemu-iotests: hotfix for 307, 223 output

2022-06-16 Thread John Snow
Fixes: 58a6fdcc Signed-off-by: John Snow Tested-by: Daniel P. Berrangé Reviewed-by: Daniel P. Berrangé --- tests/qemu-iotests/223.out | 4 ++-- tests/qemu-iotests/307.out | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/223.out b/tests/qemu-iotests

[PATCH v2 05/10] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-06-16 Thread John Snow
The old CentOS image didn't work anymore because it was already EOL at the beginning of 2022. Signed-off-by: John Snow Reviewed-by: Thomas Huth --- tests/vm/centos | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/vm/centos b/tests/vm/centos index be4f6f

[PATCH v2 09/10] tests/vm: remove duplicate 'centos' VM test

2022-06-16 Thread John Snow
This is listed twice by accident; we require genisoimage to run the test, so remove the unconditional entry. Signed-off-by: John Snow --- tests/vm/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index

[PATCH v2 08/10] tests/vm: remove ubuntu.i386 VM test

2022-06-16 Thread John Snow
ed to support this VM test anymore. Signed-off-by: John Snow --- tests/vm/Makefile.include | 3 +-- tests/vm/ubuntu.i386 | 40 --- 2 files changed, 1 insertion(+), 42 deletions(-) delete mode 100755 tests/vm/ubuntu.i386 diff --git a/tests/vm/Makefile.incl

[PATCH v2 04/10] tests/vm: use 'cp' instead of 'ln' for temporary vm images

2022-06-16 Thread John Snow
If the initial setup fails, you've permanently altered the state of the downloaded image in an unknowable way. Use 'cp' like our other test setup scripts do. Signed-off-by: John Snow Reviewed-by: Thomas Huth --- tests/vm/centos | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 00/10] Improve reliability of VM tests

2022-06-16 Thread John Snow
xt version? next series?); - Try to get centos.aarch64 working reliably under TCG - Upgrade ubuntu.aarch64 to 20.04 after fixing centos.aarch64 - Fix the Haiku build test, if possible. - Ensure I can reliably run and pass "make vm-build-all". (Remove VMs from this recipe if necess

[PATCH v2 03/10] qga: treat get-guest-fsinfo as "best effort"

2022-06-16 Thread John Snow
eturn stub information for these failed lookups. This allows test-qga to pass under docker tests, which are in turn used by the CentOS VM tests. Signed-off-by: John Snow --- qga/commands-posix.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/qga/commands-posix.c

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-15 Thread John Snow
On Wed, Jun 15, 2022 at 11:33 AM Daniel P. Berrangé wrote: > > On Wed, Jun 15, 2022 at 09:41:32AM -0400, John Snow wrote: > > On Tue, Jun 14, 2022 at 10:30 AM John Snow wrote: > > > > > > On Tue, Jun 14, 2022 at 4:59 AM Daniel P. Berrangé > > > wrote: >

Re: [PATCH] tests/vm: allow running tests in an unconfigured source tree

2022-06-15 Thread John Snow
configure? (Like, just run mkvenv directly?) Or ... actually, uh. what's the problem with running check-venv, actually? I guess because of build system magic that requires a call to configure and we can't do that for the Cirrus CI? > > Cc: John Snow > Si

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-15 Thread John Snow
On Tue, Jun 14, 2022 at 10:30 AM John Snow wrote: > > On Tue, Jun 14, 2022 at 4:59 AM Daniel P. Berrangé > wrote: > > > > On Tue, Jun 14, 2022 at 06:46:35AM +0200, Thomas Huth wrote: > > > On 14/06/2022 03.50, John Snow wrote: > > > > In certain cont

Re: [PATCH 4/5] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-06-14 Thread John Snow
On Tue, Jun 14, 2022 at 5:09 AM Daniel P. Berrangé wrote: > > On Mon, Jun 13, 2022 at 09:50:43PM -0400, John Snow wrote: > > The old CentOS image didn't work anymore because it was already EOL at > > the beginning of 2022. > > > > Signed-off-by: John Sno

Re: [PATCH 3/5] tests/vm: use 'cp' instead of 'ln' for temporary vm images

2022-06-14 Thread John Snow
On Tue, Jun 14, 2022 at 12:40 AM Thomas Huth wrote: > > On 14/06/2022 03.50, John Snow wrote: > > If the initial setup fails, you've permanently altered the state of the > > downloaded image in an unknowable way. Use 'cp' like our other test > > setup scrip

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-14 Thread John Snow
On Tue, Jun 14, 2022 at 4:59 AM Daniel P. Berrangé wrote: > > On Tue, Jun 14, 2022 at 06:46:35AM +0200, Thomas Huth wrote: > > On 14/06/2022 03.50, John Snow wrote: > > > In certain container environments we may not have FUSE at all, so skip > > > the

[PATCH 4/5] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-06-13 Thread John Snow
The old CentOS image didn't work anymore because it was already EOL at the beginning of 2022. Signed-off-by: John Snow --- tests/vm/centos | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/vm/centos b/tests/vm/centos index be4f6ff2f14..f5bbdecf62d 100755

[PATCH 3/5] tests/vm: use 'cp' instead of 'ln' for temporary vm images

2022-06-13 Thread John Snow
If the initial setup fails, you've permanently altered the state of the downloaded image in an unknowable way. Use 'cp' like our other test setup scripts do. Signed-off-by: John Snow --- tests/vm/centos | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm

[PATCH 0/5] Update CentOS VM tests

2022-06-13 Thread John Snow
quot;offset": OFFSET}] wrote 65535/65535 bytes at offset 983040 63.999 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) -[{ "start": 0, "length": 4096, "depth": 0, "present": true, "zero": false, "data": true, "offset"

[PATCH 1/5] tests/qemu-iotests: hotfix for 307, 223 output

2022-06-13 Thread John Snow
Fixes: 58a6fdcc Signed-off-by: John Snow --- tests/qemu-iotests/223.out | 4 ++-- tests/qemu-iotests/307.out | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/223.out b/tests/qemu-iotests/223.out index 06479415312..26fb347c5da 100644 --- a/tests/qemu

[PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-13 Thread John Snow
In certain container environments we may not have FUSE at all, so skip the test in this circumstance too. Signed-off-by: John Snow --- tests/qemu-iotests/108 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108 index 9e923d6a59f..e401c5e9933

Re: CentOS 8 cloud images not working under VM tests

2022-06-13 Thread John Snow
On Mon, Jun 13, 2022 at 12:36 PM John Snow wrote: > > On Mon, Jun 13, 2022 at 2:05 AM Thomas Huth wrote: > > > > On 11/06/2022 01.28, John Snow wrote: > > > This test doesn't appear to work for me: > > > > > > def build_image(self, img): > &g

Re: CentOS 8 cloud images not working under VM tests

2022-06-13 Thread John Snow
On Mon, Jun 13, 2022 at 2:05 AM Thomas Huth wrote: > > On 11/06/2022 01.28, John Snow wrote: > > This test doesn't appear to work for me: > > > > def build_image(self, img): > > cimg = > > self._download_with_cache("https://cloud.centos.or

<    4   5   6   7   8   9   10   11   12   13   >