[Qemu-devel] [PATCH] linux-user/syscall.c: remove forward declarations

2012-12-25 Thread John Spencer
instead use the correct headers that define these functions. Requested-by: Stefan Weil Signed-off-by: John Spencer --- linux-user/syscall.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index e99adab..3167a87 100644

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-12 Thread John Spencer
On 12/12/2012 04:18 AM, Scott Wood wrote: QEMU is sometimes used in embedded contexts, where graphical support is unnecessary. The ability to turn off graphics support not only saves some space, but it eliminates the dependency on pixman. Signed-off-by: Scott Wood --- There are undoubtedly some

Re: [Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c

2012-12-10 Thread John Spencer
On 12/10/2012 06:49 PM, Stefan Weil wrote: Am 10.12.2012 07:59, schrieb John Spencer: +#include This is a workaround for a missing declaration of function syscall in musl's unistd.h. See my comment to patch 1 for more information. thanks for noticing! fixed in musl: http://git

[Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c

2012-12-09 Thread John Spencer
Signed-off-by: John Spencer --- linux-user/syscall.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 31d5276..fabbcd7 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -39,6 +39,7 @@ #include #include

Re: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-09 Thread John Spencer
On 12/10/2012 07:37 AM, Stefan Weil wrote: Am 10.12.2012 07:16, schrieb John Spencer: Your patch is not shown here because you had attached it to your email. Please use "git send-email" to send patches.See also http://wiki.qemu.org/Contribute/SubmitAPatch. thanks, resent with git

[Qemu-devel] [PATCH 1/4] fix implicit declaration of syscall() in linux-user/mmap.c

2012-12-09 Thread John Spencer
on glibc, this header is getting pulled in automatically via another header, however on musl we need to include it explicitly. linux-user/mmap.c:705:9: warning: implicit declaration of function 'syscall' linux-user/mmap.c:705:9: warning: nested extern declaration of 'syscall'

[Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-09 Thread John Spencer
. Signed-off-by: John Spencer --- linux-user/syscall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index fabbcd7..665316e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -28,6 +28,7 @@ #include #include

[Qemu-devel] [PATCH 2/4] fix build error on ARM due to wrong glibc check

2012-12-09 Thread John Spencer
the test for glibc < 2 "succeeds" wrongly for any non-glibc C library, and breaks the build on musl libc. we must first test if __GLIBC__ is defined at all, before using it unconditionally. Signed-off-by: John Spencer --- user-exec.c |2 +- 1 files changed, 1 insertions(+)

[Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-09 Thread John Spencer
>From 3d9bc5e06ae64806003f8999b4b7ead42bd19c5d Mon Sep 17 00:00:00 2001 From: John Spencer Date: Mon, 10 Dec 2012 07:02:49 +0100 Subject: [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() this declaration is wrong: the correct prototype on linux is: int setgroups(siz

[Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c

2012-12-09 Thread John Spencer
>From 5d410e6e92bbd3ab3a4fadec41a3d87cb9b0feea Mon Sep 17 00:00:00 2001 From: John Spencer Date: Mon, 10 Dec 2012 06:58:48 +0100 Subject: [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c Signed-off-by: John Spencer --- linux-user/syscall.c |1 + 1 files chan

[Qemu-devel] [PATCH 2/4] fix build error on ARM due to wrong glibc check

2012-12-09 Thread John Spencer
>From ae02bfc600bf8c4c8502e70bdf8dfcd332ebef02 Mon Sep 17 00:00:00 2001 From: John Spencer Date: Mon, 10 Dec 2012 06:54:03 +0100 Subject: [PATCH 2/4] fix build error on ARM due to wrong glibc check the test for glibc < 2 "succeeds" wrongly for any non-glibc C library, and bre

[Qemu-devel] [PATCH 1/4] fix implicit declaration of syscall() in linux-user/mmap.c

2012-12-09 Thread John Spencer
>From f293c406dd2fe751244f2beef4782ccec65fd307 Mon Sep 17 00:00:00 2001 From: John Spencer Date: Mon, 10 Dec 2012 06:49:57 +0100 Subject: [PATCH 1/4] fix implicit declaration of syscall() in linux-user/mmap.c on glibc, this header is getting pulled in automatically via another header, howe