RE: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2019-09-20 Thread Justin Terry (VM)
: qemu-devel@nongnu.org; Justin Terry (VM) > Cc: Daniel P . Berrangé ; Fam Zheng > ; Thomas Huth ; Paolo Bonzini > ; Alex Bennée ; Richard > Henderson ; Eduardo Habkost ; > Stefan Weil > Subject: Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries > > On 9/20/19 1:33 PM, Phi

Re: [Qemu-devel] [PATCH for 4.1] Fix broken build with WHPX enabled

2019-07-15 Thread Justin Terry (VM) via Qemu-devel
why its not a simple "9 bytes" as indicated below. Thanks, Justin > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Friday, July 12, 2019 7:35 AM > To: Stefan Weil ; qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Eduardo Habkost > ; Like Xu ; Richard &g

Re: [Qemu-devel] [PATCH 0/3] WHPX introduce changes for Windows Insider SDK 17110

2019-01-23 Thread Justin Terry (VM) via Qemu-devel
17, 2019 12:38 PM > To: Justin Terry (VM) ; qemu-devel@nongnu.org > Cc: pbonz...@redhat.com; ehabk...@redhat.com; r...@twiddle.net > Subject: Re: [Qemu-devel] [PATCH 0/3] WHPX introduce changes for > Windows Insider SDK 17110 > > Am 14.03.2018 um 15:52 schrieb Justin Terry (V

Re: [Qemu-devel] Problem building QEMU with whpx support

2018-07-09 Thread Justin Terry (VM) via Qemu-devel
, June 21, 2018 2:44 PM To: qemu-devel@nongnu.org; Justin Terry (VM) Subject: Problem building QEMU with whpx support Hi Justin, We are trying to use QEMU on Windows Hyper-V environment with whpx enabled for better performance. We were unable to build QEMU with WHPX support. We used Ubuntu 18.04

Re: [Qemu-devel] [PATCH 2/2] WHPX: register for unrecognized MSR exits

2018-06-18 Thread Justin Terry (VM) via Qemu-devel
hypervisor itself. -Justin > -Original Message- > From: Paolo Bonzini > Sent: Wednesday, June 13, 2018 9:28 AM > To: Justin Terry (VM) ; qemu-devel@nongnu.org > Cc: r...@twiddle.net; ehabk...@redhat.com > Subject: Re: [PATCH 2/2] WHPX: register for unrecognized MSR exits

[Qemu-devel] [PATCH 1/2] WHPX workaround bug in OSVW handling

2018-06-05 Thread Justin Terry (VM) via Qemu-devel
Terry (VM) --- target/i386/whpx-all.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 6b42096698..99501bac57 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -964,6 +964,16 @@ static int

[Qemu-devel] [PATCH 2/2] WHPX: register for unrecognized MSR exits

2018-06-05 Thread Justin Terry (VM) via Qemu-devel
kernel to probe the MSR with a write/read/check sequence it does often without failing the access. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 41 ++--- 1 file changed, 38 insertions(+), 3 deletions(-) diff --git a/target/i386/whpx-all.c b/t

Re: [Qemu-devel] [PATCH v3 2/3] WHPX: dynamically load WHP libraries

2018-06-04 Thread Justin Terry (VM) via Qemu-devel
> Sent: Friday, May 25, 2018 7:02 AM > To: qemu-devel@nongnu.org > Cc: Lucian Petrut ; apilotti > ; Justin Terry (VM) > > Subject: [PATCH v3 2/3] WHPX: dynamically load WHP libraries > > From: Lucian Petrut > > We're currently linking against import libraries of the

Re: [Qemu-devel] [PATCH] WHPX Add signature CPUID

2018-05-16 Thread Justin Terry (VM) via Qemu-devel
> ; open list:All patches CC here de...@nongnu.org>; Justin Terry (VM) ; Richard > Henderson > Subject: Re: [Qemu-devel] [PATCH] WHPX Add signature CPUID > > On 16/05/2018 01:55, Alessandro Pilotti wrote: > > Hi Paolo, > > > > The main reason for different signatu

Re: [Qemu-devel] [PATCH] WHPX Add signature CPUID

2018-05-15 Thread Justin Terry (VM) via Qemu-devel
Thanks for the patch Lucian. Looks good to me! -Justin > -Original Message- > From: petrutlucia...@gmail.com > Sent: Tuesday, May 15, 2018 4:38 AM > Cc: Lucian Petrut ; apilotti > ; Justin Terry (VM) > ; Paolo Bonzini ; Richard > Henderson ; Eduardo Habkost ; >

Re: [Qemu-devel] Cannot launch QEMU with -accel whpx

2018-04-26 Thread Justin Terry (VM) via Qemu-devel
the machine) > qemu-system-x86_64.exe -accel whpx … Let me know if that wasn’t the issue. Thanks, Justin From: Wang Wenchao Sent: Thursday, April 26, 2018 3:47 AM To: Justin Terry (VM) Cc: qemu-devel@nongnu.org Subject: Cannot launch QEMU with -accel whpx Hi, Justin, We are interested in WH

Re: [Qemu-devel] [PATCH] WHPX fixes an issue with CPUID 1 not returning CPUID_EXT_HYPERVISOR

2018-04-16 Thread Justin Terry (VM) via Qemu-devel
nal Message- > From: Eduardo Habkost > Sent: Monday, April 16, 2018 9:33 AM > To: Paolo Bonzini > Cc: Justin Terry (VM) ; qemu-devel@nongnu.org; > r...@twiddle.net > Subject: Re: [PATCH] WHPX fixes an issue with CPUID 1 not returning > CPUID_EXT_HYPERVISOR > > On T

Re: [Qemu-devel] [PATCH] WHPX fixes an issue with CPUID 1 not returning CPUID_EXT_HYPERVISOR

2018-03-28 Thread Justin Terry (VM) via Qemu-devel
Hey Eduardo Responses inline. Thanks! > -Original Message- > From: Eduardo Habkost > Sent: Wednesday, March 28, 2018 10:51 AM > To: Justin Terry (VM) > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; r...@twiddle.net > Subject: Re: [PATCH] WHPX fixes an issue with CPU

[Qemu-devel] [PATCH] WHPX fixes an issue with CPUID 1 not returning CPUID_EXT_HYPERVISOR

2018-03-26 Thread Justin Terry (VM) via Qemu-devel
Implements the CPUID trap for CPUID 1 to include the CPUID_EXT_HYPERVISOR flag in the ECX results. This was preventing some older linux kernels from booting when trying to access MSR's that dont make sense when virtualized. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c

[Qemu-devel] [PATCH 2/3] WHPX fix WHvSetPartitionProperty in PropertyCode

2018-03-14 Thread Justin Terry (VM) via Qemu-devel
opertyCode parameter from the WHV_PARTITION_PROPERTY struct as it is now passed to the function directly. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index

[Qemu-devel] [PATCH 3/3] WHPX improve vcpu_post_run perf

2018-03-14 Thread Justin Terry (VM) via Qemu-devel
This removes the additional call to WHvGetVirtualProcessorRegisters in whpx_vcpu_post_run now that the WHV_VP_EXIT_CONTEXT is returned in all WHV_RUN_VP_EXIT_CONTEXT structures. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 41 +++-- 1 file

[Qemu-devel] [PATCH 1/3] WHPX fix WHvGetCapability out WrittenSizeInBytes

2018-03-14 Thread Justin Terry (VM) via Qemu-devel
This fixes a breaking change to WHvGetCapability to include the 'out' WrittenSizeInBytes introduced in Windows Insider SDK 17110. This specifies on return the safe length to read into the WHV_CAPABILITY structure passed to the call. Signed-off-by: Justin Terry (VM) ---

[Qemu-devel] [PATCH 0/3] WHPX introduce changes for Windows Insider SDK 17110

2018-03-14 Thread Justin Terry (VM) via Qemu-devel
17110+) is expected to work on all Windows Insider Builds (17115+). Thanks, Justin Terry Justin Terry (VM) (3): WHPX fix WHvGetCapability out WrittenSizeInBytes WHPX fix WHvSetPartitionProperty in PropertyCode WHPX improve vcpu_post_run perf configure | 4 +++- target/i386/whpx-

[Qemu-devel] [PATCH 6/8] Fix WHPX issue leaking tpr values

2018-02-26 Thread Justin Terry (VM) via Qemu-devel
expected. The fix is to use a local variable to store the temporary tpr and only update the array if the local tpr value is different than the vp context. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target

[Qemu-devel] [PATCH 7/8] WHXP Removes the use of WHvGetExitContextSize

2018-02-26 Thread Justin Terry (VM) via Qemu-devel
: Justin Terry (VM) --- target/i386/whpx-all.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 47a6935288..24387bebad 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -32,7 +32,6 @@ struct

[Qemu-devel] [PATCH 4/8] Fix WHPX additional lock acquisition

2018-02-26 Thread Justin Terry (VM) via Qemu-devel
The code already is holding the qemu_mutex for the IO thread. We do not need to additionally take the lock again in this case. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index

[Qemu-devel] [PATCH 3/8] Remove unnecessary WHPX __debugbreak();

2018-02-26 Thread Justin Terry (VM) via Qemu-devel
Minor code cleanup. The calls to __debugbreak() are not required and should no longer be used to prevent unnecessary breaks. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 12 1 file changed, 12 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx

[Qemu-devel] [PATCH 5/8] Fix WHPX typo in 'mmio'

2018-02-26 Thread Justin Terry (VM) via Qemu-devel
Renames the usage of 'memio' to 'mmio' in the emulator callbacks. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 74a8f4d599..7e58d5f68c

[Qemu-devel] [PATCH 2/8] Resolves WHPX breaking changes in SDK 17095

2018-02-26 Thread Justin Terry (VM) via Qemu-devel
1. Fixes the changes required to the WHvTryMmioEmulation, WHvTryIoEmulation, and WHvEmulatorCreateEmulator based on the new VpContext forwarding. 2. Removes the WHvRunVpExitReasonAlerted case. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 26 ++ 1 file

[Qemu-devel] [PATCH 8/8] WHPX improve interrupt notification registration

2018-02-26 Thread Justin Terry (VM) via Qemu-devel
Improves the usage of the InterruptNotification registration by skipping the additional call to WHvSetVirtualProcessorRegisters if we have already registered for the window exit. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 7 +++ 1 file changed, 3 insertions(+), 4

[Qemu-devel] [PATCH 1/8] Fixing WHPX casing to match SDK

2018-02-26 Thread Justin Terry (VM) via Qemu-devel
Fixes an issue where the SDK that was releases had a different casing for the *.h and *.lib files causing a build break if linked directly from Windows Kits. Signed-off-by: Justin Terry (VM) --- configure | 10 +- target/i386/whpx-all.c | 4 ++-- 2 files changed, 7

[Qemu-devel] [PATCH 0/8] WHPX updates based on the 17095 insider sdk.

2018-02-26 Thread Justin Terry (VM) via Qemu-devel
ified to improve performance and changes are required to QEMU to maintain ability to build on such platforms. The rest of the changes are around improvements/fixes to the accelerator to increase performance and correctness. Thanks, Justin Terry Justin Terry (VM) (8): Fixing WHPX casing to matc

Re: [Qemu-devel] [PATCH v2 0/4] Updates based on feedback.

2018-01-30 Thread Justin Terry (VM) via Qemu-devel
forward. Thanks, Justin > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, January 30, 2018 11:34 AM > To: Justin Terry (VM) ; qemu-devel@nongnu.org > Cc: crosthwaite.pe...@gmail.com; r...@twiddle.net; ehabk...@redhat.com > Subject:

Re: [Qemu-devel] [PATCH v2 0/4] Updates based on feedback.

2018-01-29 Thread Justin Terry (VM) via Qemu-devel
Hi All, Is there any additional feedback I can address here to help out the process? Please let me know. Thanks again, Justin > -Original Message- > From: Justin Terry (VM) > Sent: Monday, January 22, 2018 1:08 PM > To: qemu-devel@nongnu.org > Cc: pbonz...@redhat.com;

Re: [Qemu-devel] [PATCH v2 0/4] Updates based on feedback.

2018-01-25 Thread Justin Terry (VM) via Qemu-devel
ation scenarios. Was there a specific set of things you were wondering that I could investigate or provide clarity on? Thanks, Justin > -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Thursday, January 25, 2018 3:02 AM > To: Justin Terry (VM)

[Qemu-devel] [PATCH v2 4/4] Add the WHPX acceleration enlightenments

2018-01-22 Thread Justin Terry (VM) via Qemu-devel
Implements the WHPX accelerator cpu enlightenments to actually use the whpx-all accelerator on Windows platforms. Signed-off-by: Justin Terry (VM) --- cpus.c| 66 ++- include/sysemu/hw_accel.h | 13 ++ target/i386/helper.c

[Qemu-devel] [PATCH v2 2/4] Add the WHPX vcpu API

2018-01-22 Thread Justin Terry (VM) via Qemu-devel
Adds support for the Windows Hypervisor Platform accelerator (WHPX) stubs and introduces the whpx.h sysemu API for managing the vcpu scheduling and management. Signed-off-by: Justin Terry (VM) --- accel/stubs/Makefile.objs | 9 + accel/stubs/whpx-stub.c | 48

[Qemu-devel] [PATCH v2 0/4] Updates based on feedback.

2018-01-22 Thread Justin Terry (VM) via Qemu-devel
Updates based on review feedback. 1. Fixes style issues and properly ran the scripts/checkpatch pre submission. 2. Added migration blockers for CPUID, dirty memory tracking, and XSAVE/XRSTOR. 3. Fixed some bugs around register states when using bios vs efi. Justin Terry (VM) (4): Add the

[Qemu-devel] [PATCH v2 3/4] Introduce the WHPX impl

2018-01-22 Thread Justin Terry (VM) via Qemu-devel
Adds support for vCPU management. 3. Adds support for MMIO/PortIO. 4. Registers the WHPX ACCEL_CLASS. Signed-off-by: Justin Terry (VM) --- target/i386/Makefile.objs |1 + target/i386/whpx-all.c| 1366 + 2 files changed, 1367 insertions(+) create

[Qemu-devel] [PATCH v2 1/4] Add the Windows Hypervisor Platform accelerator.

2018-01-22 Thread Justin Terry (VM) via Qemu-devel
Introduces the configure support for the new Windows Hypervisor Platform that allows for hypervisor acceleration from usermode components on the Windows platform. Signed-off-by: Justin Terry (VM) --- configure | 48 +++- qemu-options.hx | 8

Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator

2018-01-22 Thread Justin Terry (VM) via Qemu-devel
Perfect. Thanks Paolo. Will submit the Patch V2 with your requested changes today. Justin > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, January 18, 2018 12:16 AM > To: Justin Terry (VM) > Cc: qemu-devel@nongnu.org qemu-devel

Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator

2018-01-22 Thread Justin Terry (VM) via Qemu-devel
> Sent: Wednesday, January 17, 2018 11:05 PM > To: Justin Terry (VM) ; Paolo Bonzini > > Cc: qemu-devel@nongnu.org qemu-devel > Subject: Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor > Platform accelerator > > Am 18.01.2018 um 00:41 schrieb Justin Terry (VM)

Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator

2018-01-17 Thread Justin Terry (VM) via Qemu-devel
ni [mailto:pbonz...@redhat.com] > Sent: Friday, January 12, 2018 12:48 PM > To: Justin Terry (VM) > Cc: qemu-devel@nongnu.org qemu-devel > Subject: Re: [PATCH 0/4] Implements the Windows Hypervisor Platform > accelerator > > > > Hello QEMU Community! > > > > Over the

Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator

2018-01-16 Thread Justin Terry (VM) via Qemu-devel
give me a pointer on where you keep the wiki code so I can add the descriptions there? Thanks, Justin > -Original Message- > From: Stefan Weil [mailto:s...@weilnetz.de] > Sent: Friday, January 12, 2018 2:06 PM > To: Justin Terry (VM) ; qemu-devel@nongnu.org > Cc: pbonz...@r

Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator

2018-01-16 Thread Justin Terry (VM) via Qemu-devel
...@weilnetz.de] Sent: Friday, January 12, 2018 1:57 PM To: Justin Terry (VM) ; qemu-devel@nongnu.org Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; crosthwaite.pe...@gmail.com Subject: Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator Am 12.01.2018 um 21:22

[Qemu-devel] [PATCH 4/4] Add the WHPX acceleration enlightenments

2018-01-12 Thread Justin Terry (VM) via Qemu-devel
Implements the WHPX accelerator cpu enlightenments to actually use the whpx-all accelerator on Windows platforms. Signed-off-by: Justin Terry (VM) --- cpus.c| 66 ++- include/sysemu/hw_accel.h | 13 ++ target/i386/helper.c

[Qemu-devel] [PATCH 2/4] Add the WHPX vcpu API

2018-01-12 Thread Justin Terry (VM) via Qemu-devel
Adds support for the Windows Hypervisor Platform accelerator (WHPX) stubs and introduces the whpx.h sysemu API for managing the vcpu scheduling and management. Signed-off-by: Justin Terry (VM) --- accel/stubs/Makefile.objs | 9 + accel/stubs/whpx-stub.c | 48

[Qemu-devel] [PATCH 3/4] Introduce the WHPX impl

2018-01-12 Thread Justin Terry (VM) via Qemu-devel
Adds support for vCPU management. 3. Adds support for MMIO/PortIO. 4. Registers the WHPX ACCEL_CLASS. Signed-off-by: Justin Terry (VM) --- target/i386/Makefile.objs |1 + target/i386/whpx-all.c| 1395 + 2 files changed, 1396 insertions(+) create

[Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator

2018-01-12 Thread Justin Terry (VM) via Qemu-devel
of the documentation for this new API will be visible at https://docs.microsoft.com/en-us/virtualization under the 'Windows Hypervisor Platform' section. Here you will see the requirements, API, and examples. Thank you for your feedback. Justin Terry (VM) (4): Add the Windows Hypervis

[Qemu-devel] [PATCH 1/4] Add the Windows Hypervisor Platform accelerator.

2018-01-12 Thread Justin Terry (VM) via Qemu-devel
Introduces the configure support for the new Windows Hypervisor Platform that allows for hypervisor acceleration from usermode components on the Windows platform. Signed-off-by: Justin Terry (VM) --- configure | 48 +++- qemu-options.hx | 8