[Qemu-devel] [PATCH 11/18] migration: introduce capability localhost

2013-08-21 Thread Lei Li
Introduce migration capability localhost. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |3 +++ migration.c | 12 qapi-schema.json |8 +++- 3 files changed, 22 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 06/18] bugfix: wrong error set by ram_control_load_hook()

2013-08-21 Thread Lei Li
It should set negative error value if there has been an error. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- savevm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 1522d95..f10e031 100644 --- a/savevm.c +++ b/savevm.c @@ -649,7 +649,7

[Qemu-devel] [PATCH 12/18] arch_init: factor out ram_save_blocks()

2013-08-21 Thread Lei Li
Factor out ram_save_blocks(), which will be used to send ram blocks hooked by save_page in ram_save_setup stage in coming patch. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 25 +++-- 1 files changed, 15 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 15/18] migration: adjust migration_thread for local migration

2013-08-21 Thread Lei Li
the device states in qemu_save_device_state stage. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- migration.c | 73 -- 1 files changed, 45 insertions(+), 28 deletions(-) diff --git a/migration.c b/migration.c index 2f85358..2471664 100644

[Qemu-devel] [PATCH 14/18] arch_init: skip migration_bitmap_sync for local migration

2013-08-21 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index cbbb4db..e6069eb 100644 --- a/arch_init.c +++ b/arch_init.c @@ -375,6 +375,11 @@ static void migration_bitmap_sync(void

[Qemu-devel] [PATCH 16/18] migration-local: implementation of incoming part

2013-08-21 Thread Lei Li
Implementation of incoming part of localhost migration. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |2 + include/migration/qemu-file.h |8 ++-- migration-local.c | 99 + 3 files changed, 105

[Qemu-devel] [PATCH 17/18] migration: add prefix for local migration to incoming migration

2013-08-21 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- migration.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/migration.c b/migration.c index 2471664..17cf2fd 100644 --- a/migration.c +++ b/migration.c @@ -81,6 +81,9 @@ void qemu_start_incoming_migration(const char

[Qemu-devel] [PATCH 13/18] arch_init: adjust ram_save_setup() for migrate_is_localhost

2013-08-21 Thread Lei Li
Send all the ram blocks hooked by save_page, which will copy ram page and MADV_DONTNEED the page just copied. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index

[Qemu-devel] [PATCH 18/18] hmp: better fomat for info migrate_capabilities

2013-08-21 Thread Lei Li
As we have more and more capabilities, better to display in lines. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- hmp.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hmp.c b/hmp.c index c45514b..3544219 100644 --- a/hmp.c +++ b/hmp.c @@ -226,13 +226,12 @@ void

[Qemu-devel] [PATCH 10/18] migration-local: implementation of outgoing part

2013-08-21 Thread Lei Li
Implementation of outgoing part for localhost migration. The integration of migration thread and corresponding adjustment will be in coming patches. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |2 + migration-local.c | 85

[Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local()

2013-08-21 Thread Lei Li
Introduce read/write backend of QEMUFileLocal used by localhost migration. The unix domain socket will be replaced by PIPE with vmsplice mechanism. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- Makefile.objs |1 + migration-local.c | 211

[Qemu-devel] [Bug 1213797] Re: Guest hang after live migration

2013-08-19 Thread Lei Li
Hi, qemu-kvm no longer exists as it has been merged into qemu. You might want to have a try with the lastest upstream/master qemu tree, or pre-release versions of it. :) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1210212] Re: qemu core dumps with -serial mon:vc

2013-08-11 Thread Lei Li
Hi, This problem has been solved by commit 7b7ab18d0b9769b5f39e663fa55caed461b1202e: Author: Michael Roth mdr...@linux.vnet.ibm.com Date: Tue Jul 30 13:04:22 2013 -0500 chardev: fix CHR_EVENT_OPENED events for mux chardevs Patch link: http://patchwork.ozlabs.org/patch/263458/ ** Changed

Re: [Qemu-devel] [PATCH 0/12 RFC v2] Localhost migration

2013-08-05 Thread Lei Li
On 07/26/2013 05:41 PM, Paolo Bonzini wrote: Il 25/07/2013 22:18, Lei Li ha scritto: Hi, This patch series tries to add localhost migration support to Qemu. When doing localhost migration, the host memory will balloon up during the period, might consume double memories for some time. So we

Re: [Qemu-devel] [PATCH] savevm: set right return value for qemu_file_rate_limit

2013-08-05 Thread Lei Li
PING? any comments? On 07/24/2013 11:48 PM, Lei Li wrote: In the logic of ram_save_iterate(), it checks the ret of qemu_file_rate_limit(f) by ret 0 if there has been an error. But now it will never return negative value because qemu_file_rate_limit() return 1 if qemu_file_get_error(). Also

Re: [Qemu-devel] [PATCH 04/12] arch_init: introduce ram_page_save()

2013-08-04 Thread Lei Li
On 08/03/2013 03:40 AM, Michael R. Hines wrote: On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 07/12] savevm: introduce qemu_savevm_local()

2013-08-04 Thread Lei Li
On 08/03/2013 03:48 AM, Michael R. Hines wrote: On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/sysemu/sysemu.h |1 + savevm.c| 55 +++ 2 files changed, 56 insertions(+), 0

Re: [Qemu-devel] [PATCH 09/12] migration-local: implementation of outgoing part

2013-08-04 Thread Lei Li
On 08/03/2013 03:45 AM, Michael R. Hines wrote: On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- Makefile.objs |1 + include/migration/migration.h | 15 migration-local.c | 158

Re: [Qemu-devel] [PATCH 11/12] migration-local: add option to commandline for incoming-local

2013-08-04 Thread Lei Li
On 08/03/2013 03:46 AM, Michael R. Hines wrote: On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qemu-options.hx |9 + vl.c| 14 ++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b

Re: [Qemu-devel] [PATCH 12/12] hmp: add hmp_localhost_migration interface

2013-08-04 Thread Lei Li
On 08/03/2013 03:47 AM, Michael R. Hines wrote: On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- hmp-commands.hx | 17 + hmp.c | 13 + hmp.h |1 + 3 files changed, 31 insertions(+), 0 deletions

Re: [Qemu-devel] [PATCH 05/12] arch_init: introduce ram_save_local()

2013-08-04 Thread Lei Li
On 08/03/2013 03:42 AM, Michael R. Hines wrote: On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index

[Qemu-devel] [PATCH 0/12 RFC v2] Localhost migration

2013-07-25 Thread Lei Li
, as Anthony has suggested using a flag or a capability, which one would you prefer or any ideas? Your comments are very welcome! TODO: - Integrate to the current implement of migration closely? - Introduce a mechanism to exchange a PIPE via SCM_RIGHTS. - benchmark/evaluation. Lei Li (12

[Qemu-devel] [PATCH 03/12] rename is_active to is_block_active

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- block-migration.c |2 +- include/migration/vmstate.h |2 +- savevm.c| 16 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/block-migration.c b/block-migration.c index

[Qemu-devel] [PATCH 02/12] savevm: export qemu_save_device_state()

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/sysemu/sysemu.h |1 + savevm.c|7 ++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 2fb71af..5b90027 100644 --- a/include/sysemu/sysemu.h

[Qemu-devel] [PATCH 07/12] savevm: introduce qemu_savevm_local()

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/sysemu/sysemu.h |1 + savevm.c| 55 +++ 2 files changed, 56 insertions(+), 0 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 5b90027

[Qemu-devel] [PATCH 04/12] arch_init: introduce ram_page_save()

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index a8b91ee..a418071 100644 --- a/arch_init.c +++ b/arch_init.c @@ -699,6

[Qemu-devel] [PATCH 08/12] savevm: adjust is_ram check in register_savevm_live()

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- savevm.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index c183369..e826f64 100644 --- a/savevm.c +++ b/savevm.c @@ -1484,7 +1484,8 @@ int register_savevm_live(DeviceState *dev, se-vmsd

[Qemu-devel] [PATCH 12/12] hmp: add hmp_localhost_migration interface

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- hmp-commands.hx | 17 + hmp.c | 13 + hmp.h |1 + 3 files changed, 31 insertions(+), 0 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 915b0d1..ed21970 100644 --- a/hmp

[Qemu-devel] [PATCH 05/12] arch_init: introduce ram_save_local()

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index a418071..7eeb52f 100644 --- a/arch_init.c +++ b/arch_init.c @@ -757,6 +757,38 @@ static int

[Qemu-devel] [PATCH 10/12] migration-local: implementation of incoming part

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |6 + migration-local.c | 39 ++ migration-unix.c | 47 + 3 files changed, 92 insertions(+), 0 deletions

[Qemu-devel] [PATCH 09/12] migration-local: implementation of outgoing part

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- Makefile.objs |1 + include/migration/migration.h | 15 migration-local.c | 158 + migration-unix.c | 13 qapi-schema.json | 14

[Qemu-devel] [PATCH 01/12] migration: export MIG_STATE_xxx flags

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |9 + migration.c |8 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index e2acec6..a821c80

[Qemu-devel] [PATCH 06/12] arch_init: add save_local_setup to savevm_ram_handlers

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c |1 + include/migration/vmstate.h |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 7eeb52f..5c25005 100644 --- a/arch_init.c +++ b/arch_init.c @@ -973,6

[Qemu-devel] [PATCH 11/12] migration-local: add option to commandline for incoming-local

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qemu-options.hx |9 + vl.c| 14 ++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8355f9b..a975e83 100644 --- a/qemu-options.hx +++ b/qemu-options.hx

Re: [Qemu-devel] [PATCH] savevm: set right return value for qemu_file_rate_limit

2013-07-24 Thread Lei Li
() as function buffered_rate_limit() did return negative for this situation. On 07/21/2013 08:56 PM, Lei Li wrote: Commit 1964a397063967acc5ce71a2a24ed26e74824ee1 refactors rate limiting to QEMUFile, but set the return value for qemu_file_rate_limit to 1 in the case of qemu_file_get_error. It is wrong

[Qemu-devel] [PATCH] savevm: set right return value for qemu_file_rate_limit

2013-07-21 Thread Lei Li
in ram_save_iterate. As qemu_file_rate_limit is called manually to determine if it has to exit, add the defination of the meaning of the return values as well. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- savevm.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 2/4] Revert chardev: Make the name of memory device consistent

2013-06-27 Thread Lei Li
On 06/27/2013 10:22 PM, Markus Armbruster wrote: This reverts commit 6a85e60cb994bd95d1537aafbff65816f3de4637. Commit 51767e7 qemu-char: Add new char backend CirMemCharDriver introduced a memory ring buffer character device driver named memory. Commit 3949e59 qemu-char: Saner naming of memchar

Re: [Qemu-devel] [PATCH 0/7 RFC] Localhost live migration

2013-06-18 Thread Lei Li
On 06/17/2013 08:57 PM, Stefan Hajnoczi wrote: On Sun, Jun 16, 2013 at 11:37:26PM +0800, Lei Li wrote: 2) Use different mechanism than current live migration. The very basic work flow like: qemu on the source (the source and destination are both on localhost

Re: [Qemu-devel] [PATCH 0/7 RFC] Localhost live migration

2013-06-18 Thread Lei Li
On 06/17/2013 12:01 AM, Anthony Liguori wrote: Lei Li li...@linux.vnet.ibm.com writes: Hi, This patch series tries to add localhost live migration support to Qemu. It is just a draft version which is far from completing and I am still working on, send it out to have your suggestions and make

Re: [Qemu-devel] [PATCH 1/7] migration: export MIG_STATE_xxx flags

2013-06-18 Thread Lei Li
On 06/17/2013 12:01 AM, Anthony Liguori wrote: Lei Li li...@linux.vnet.ibm.com writes: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |8 migration.c |8 2 files changed, 8 insertions(+), 8 deletions(-) diff

Re: [Qemu-devel] [PATCH 2/7] savevm: export qemu_save_device_state()

2013-06-18 Thread Lei Li
On 06/17/2013 12:02 AM, Anthony Liguori wrote: Lei Li li...@linux.vnet.ibm.com writes: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/sysemu/sysemu.h |1 + savevm.c|2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/sysemu

Re: [Qemu-devel] [PATCH 3/7] arch_init: add ram_madvise_free()

2013-06-18 Thread Lei Li
On 06/17/2013 12:04 AM, Anthony Liguori wrote: Lei Li li...@linux.vnet.ibm.com writes: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 13 + include/migration/migration.h |3 +++ 2 files changed, 16 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [PATCH 4/7] migration-local: implementation of outgoing part

2013-06-18 Thread Lei Li
On 06/17/2013 12:07 AM, Anthony Liguori wrote: Lei Li li...@linux.vnet.ibm.com writes: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- Makefile.objs |1 + include/migration/migration.h | 15 + migration-local.c | 116

[Qemu-devel] [PATCH 2/7] savevm: export qemu_save_device_state()

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/sysemu/sysemu.h |1 + savevm.c|2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 2fb71af..5b90027 100644 --- a/include/sysemu/sysemu.h

[Qemu-devel] [PATCH 1/7] migration: export MIG_STATE_xxx flags

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |8 migration.c |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index e2acec6..8866c3c

[Qemu-devel] [PATCH 0/7 RFC] Localhost live migration

2013-06-16 Thread Lei Li
pages that already copied. After that, will replace to vmsplice mechanism instead of copying pages. TODO: - Working on the completing of ram copy and MADV_DONTNEED part. - Introduce a mechanism to exchange a PIPE via SCM_RIGHTS. - benchmark/evaluation. Lei Li (7): migration: export MIG_STATE_xxx

[Qemu-devel] [PATCH 4/7] migration-local: implementation of outgoing part

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- Makefile.objs |1 + include/migration/migration.h | 15 + migration-local.c | 116 + migration-unix.c | 13 + qapi-schema.json | 14

[Qemu-devel] [PATCH 3/7] arch_init: add ram_madvise_free()

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 13 + include/migration/migration.h |3 +++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 872020e..fc66bd2 100644 --- a/arch_init.c +++ b

[Qemu-devel] [PATCH 5/7] migration-local: implementation of incoming part

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |6 + migration-local.c | 39 ++ migration-unix.c | 47 + 3 files changed, 92 insertions(+), 0 deletions

[Qemu-devel] [PATCH 7/7] hmp: add hmp_localhost_migration interface

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- hmp-commands.hx | 17 + hmp.c | 13 + hmp.h |1 + 3 files changed, 31 insertions(+), 0 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 915b0d1..ed21970 100644 --- a/hmp

[Qemu-devel] [PATCH 6/7] migration-local: add option to command line for -incoming-local

2013-06-16 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qemu-options.hx |9 + vl.c| 14 ++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index bf94862..bb1a88a 100644 --- a/qemu-options.hx +++ b/qemu-options.hx

[Qemu-devel] [PATCH 0/2] Trivial fixes for migration

2013-05-27 Thread Lei Li
This small series improves the document migration.txt and remove a duplicated setting of bandwidth_limit. Lei Li (2): docs: Fix typo and update file in migration migration: Remove duplicate bandwidth_limit set docs/migration.txt | 17 + migration.c|1 - 2 files

[Qemu-devel] [PATCH 1/2] docs: Fix typo and update file in migration

2013-05-27 Thread Lei Li
This patch fix some typo and update the file that already moved. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- docs/migration.txt | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/docs/migration.txt b/docs/migration.txt index 0719a55..0e0a1d4 100644

[Qemu-devel] [PATCH 2/2] migration: Remove duplicate bandwidth_limit set

2013-05-27 Thread Lei Li
bandwidth_limit is double set in migrate_init(), remove one. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- migration.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index bfbc345..058f9e6 100644 --- a/migration.c +++ b/migration.c

Re: [Qemu-devel] [PATCH] linux-user: Fix typo in comment

2013-05-27 Thread Lei Li
On 05/20/2013 07:10 PM, Stefan Weil wrote: Am 20.05.2013 11:20, schrieb Lei Li: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- linux-user/syscall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 30e93bc..72c6866

[Qemu-devel] [PATCH] migration: Remove double set of bandwidth_limit in migrate_init

2013-05-24 Thread Lei Li
bandwidth_limit is double set in migrate_init(), so remove one. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- migration.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index bfbc345..058f9e6 100644 --- a/migration.c +++ b/migration.c

Re: [Qemu-devel] [for 1.5? Qemu-devel] [PATCH 2/3] chardev: Make the name of ringbuf device consistent

2013-05-21 Thread Lei Li
On 05/20/2013 11:15 PM, Paolo Bonzini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 20/05/2013 17:05, Eric Blake ha scritto: On 05/20/2013 04:59 AM, Paolo Bonzini wrote: Il 20/05/2013 12:43, Paolo Bonzini ha scritto: Il 20/05/2013 08:51, Lei Li ha scritto: Now we have ringbuf char

[Qemu-devel] [PATCH 2/2] chardev: Get filename for new qapi backend

2013-05-21 Thread Lei Li
This patch sets the filename when the new qapi backend init from opts. The previous patch and discussions as link below: http://patchwork.ozlabs.org/patch/243896/ If anyone who have better idea to fix this please let me know your suggestions. Signed-off-by: Lei Li li...@linux.vnet.ibm.com

[Qemu-devel] [PATCH 0/2 v2] Chardev related fixes

2013-05-21 Thread Lei Li
This series tries to fix the consistency of char devices ringbuf and a regression of chardev filename. Changes since v1: - Rename the struct related to new qapi ringbuf to memory, and fix the wrong description in qemu-option from Paolo. Lei Li (2): chardev: Make the name of memory device

[Qemu-devel] [PATCH 1/2] chardev: Make the name of memory device consistent

2013-05-21 Thread Lei Li
-off-by: Lei Li li...@linux.vnet.ibm.com --- qapi-schema.json |6 +++--- qemu-char.c | 16 qemu-options.hx |6 +++--- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 9302e7d..664b31f 100644 --- a/qapi

Re: [Qemu-devel] [PATCH 1/2] chardev: Make the name of memory device consistent

2013-05-21 Thread Lei Li
On 05/21/2013 06:34 PM, Paolo Bonzini wrote: Il 21/05/2013 12:27, Lei Li ha scritto: Now we have memory char device, but the backend name of it is a little confusion. We actually register it by 'memory', but the description in qemu-option, the name of open functions and the new api backend

[Qemu-devel] [PATCH 0/3] Chardev related fixes

2013-05-20 Thread Lei Li
This series tries to fix the consistency of char devices udp and ringbuf and a regression of chardev filename. Lei Li (3): chardev: Make consistent with udp device for new qapi backend chardev: Make the name of ringbuf device consistent chardev: Get filename for new qapi backend qapi

[Qemu-devel] [PATCH 1/3] chardev: Make consistent with udp device for new qapi backend

2013-05-20 Thread Lei Li
When register and open a chardev udp, the backend name should be udp not dgram, and we do not have backend dgram in the chardev list. This patch makes the new qapi udp backend consistent with the original udp device. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qapi-schema.json |8

[Qemu-devel] [PATCH 2/3] chardev: Make the name of ringbuf device consistent

2013-05-20 Thread Lei Li
'. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qapi-schema.json |2 +- qemu-char.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 9302e7d..61f6b34 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3321,7

[Qemu-devel] [PATCH 3/3] chardev: Get filename for new qapi backend

2013-05-20 Thread Lei Li
This patch sets the filename when the new qapi backend init from opts. The previous patch and discussions as link below: http://patchwork.ozlabs.org/patch/243896/ If anyone who have better idea to fix this please let me know your suggestions. Signed-off-by: Lei Li li...@linux.vnet.ibm.com

[Qemu-devel] [PATCH] linux-user: Fix typo in comment

2013-05-20 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- linux-user/syscall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 30e93bc..72c6866 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8236,7 +8236,7

Re: [Qemu-devel] [PATCH] chardev: Get filename for new qapi backend

2013-05-17 Thread Lei Li
On 05/15/2013 03:26 PM, Lei Li wrote: On 05/15/2013 01:39 PM, Gerd Hoffmann wrote: On 05/15/13 05:52, Lei Li wrote: This patch add the filename when the new qapi backend init from opts. Commit 2c5f488293c7d0cd095635c74157c2526e2c4947 add support for qapi-based chardev initialization, but miss

Re: [Qemu-devel] [PATCH] ui/input.c: replace magic numbers with macros

2013-05-16 Thread Lei Li
)); keycodes[keycodes_size++] = keycode; Looks good to me. Reviewed-by: Lei Li li...@linux.vnet.ibm.com -- Lei

Re: [Qemu-devel] [PATCH] ps2: add support of auto-repeat

2013-05-16 Thread Lei Li
On 05/16/2013 12:30 PM, Amos Kong wrote: Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, but ps2 backend doesn't process it and no auto-repeat implementation. This patch adds support of auto-repeat feature. Guest ps2 driver sets autorepeat to fastest possible in reset, period:

Re: [Qemu-devel] [PATCH] ps2: add support of auto-repeat

2013-05-16 Thread Lei Li
On 05/16/2013 03:35 PM, Amos Kong wrote: On Thu, May 16, 2013 at 03:23:21PM +0800, Lei Li wrote: On 05/16/2013 12:30 PM, Amos Kong wrote: Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, but ps2 backend doesn't process it and no auto-repeat implementation. This patch adds

Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-05-15 Thread Lei Li
On 05/14/2013 07:35 PM, Gerd Hoffmann wrote: On 04/25/13 07:29, Lei Li wrote: +/* Sending the current led state message to the client */ +if (ledstate != current_led_state(vs)) { +vnc_led_state_change(vs); +} This check never becomes true as the vnc modifier/led state just

Re: [Qemu-devel] [PATCH] chardev: Get filename for new qapi backend

2013-05-15 Thread Lei Li
On 05/15/2013 01:39 PM, Gerd Hoffmann wrote: On 05/15/13 05:52, Lei Li wrote: This patch add the filename when the new qapi backend init from opts. Commit 2c5f488293c7d0cd095635c74157c2526e2c4947 add support for qapi-based chardev initialization, but miss the filename of the char device

Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-05-15 Thread Lei Li
On 05/15/2013 02:44 PM, Gerd Hoffmann wrote: On 05/15/13 08:05, Lei Li wrote: On 05/14/2013 07:35 PM, Gerd Hoffmann wrote: On 04/25/13 07:29, Lei Li wrote: +/* Sending the current led state message to the client */ +if (ledstate != current_led_state(vs

Re: [Qemu-devel] [PATCH] chardev: Get filename for new qapi backend

2013-05-15 Thread Lei Li
On 05/15/2013 01:39 PM, Gerd Hoffmann wrote: On 05/15/13 05:52, Lei Li wrote: This patch add the filename when the new qapi backend init from opts. Commit 2c5f488293c7d0cd095635c74157c2526e2c4947 add support for qapi-based chardev initialization, but miss the filename of the char device

[Qemu-devel] [PATCH] vnc: Make ledstate comparison before modifiers updated

2013-05-15 Thread Lei Li
The ledstate should be compared before modifiers updated, otherwise the ledstate would be the same as current_led_state. Reported-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- ui/vnc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff

[Qemu-devel] [PATCH] chardev: Get filename for new qapi backend

2013-05-14 Thread Lei Li
) compat_monitor0: filename=(null) Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qemu-char.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 30a2ddf..a9f618a 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3276,6 +3276,7 @@ CharDriverState

[Qemu-devel] [Bug 1179357] Re: Assigned ID could not be used for net-client name

2013-05-14 Thread Lei Li
Yes, I agree with that this is a bug. The id of virtio-net-device should be 'id1' not 'virtio-net-device.0'. ** Changed in: qemu Status: New = Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- ui/vnc.c | 45 + ui/vnc.h |4 +++- 2 files changed, 48 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index f574962..44189d7 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1522,6

[Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED state

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- docs/vnc-ledstate-Pseudo-encoding.txt | 40 + 1 files changed, 40 insertions(+), 0 deletions(-) create mode 100644 docs/vnc-ledstate-Pseudo-encoding.txt diff --git a/docs/vnc-ledstate-Pseudo-encoding.txt b

[Qemu-devel] [PATCH 1/3] vnc: Add SCROLL lock key to kbd_leds

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- ui/vnc.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 8ee66b7..f574962 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1525,10 +1525,11 @@ static void press_key(VncState *vs, int keysym) static

[Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu VNC server

2013-04-24 Thread Lei Li
Hi guys, This patch series tries to add support for LED state extension to Qemu VNC server. The proposal has been sent few days ago as link below: http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html The previous version as link:

Re: [Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu VNC server

2013-04-24 Thread Lei Li
On 04/24/2013 10:54 PM, Eric Blake wrote: On 04/24/2013 04:12 AM, Lei Li wrote: Hi guys, This patch series tries to add support for LED state extension to Qemu VNC server. The proposal has been sent few days ago as link below: http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html

Re: [Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED state

2013-04-24 Thread Lei Li
On 04/24/2013 10:57 PM, Eric Blake wrote: On 04/24/2013 04:12 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- docs/vnc-ledstate-Pseudo-encoding.txt | 40 + 1 files changed, 40 insertions(+), 0 deletions(-) create mode 100644 docs/vnc

Re: [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension

2013-04-24 Thread Lei Li
On 04/24/2013 07:44 PM, Gerd Hoffmann wrote: Hi, +case VNC_ENCODING_LED_STATE: +vs-features |= VNC_FEATURE_LED_STATE_MASK; +break; I think it with the client supporting the led state extension it is probably a good idea to turn off the lock state sync logic

[Qemu-devel] [PATCH 1/4] vnc: Add SCROLL lock key to kbd_leds

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- ui/vnc.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 8ee66b7..f574962 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1525,10 +1525,11 @@ static void press_key(VncState *vs, int keysym) static

[Qemu-devel] [PATCH 0/4 v4] Support for LED state extension to Qemu VNC server

2013-04-24 Thread Lei Li
Anthony includes: - Use Pseudo-encoding for led state; - Get rid of send_ext_leds_state_ack; - Add document for the led state Pseudo-encoding. Lei Li (4): vnc: Add SCROLL lock key to kbd_leds vnc: Support for LED state extension vnc: Adjust lock state sync logic

[Qemu-devel] [PATCH 3/4] vnc: Adjust lock state sync logic with VNC_FEATURE_LED_STATE

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- ui/vnc.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 44189d7..9ffa75b 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1613,7 +1613,11 @@ static void do_key_event(VncState *vs, int down, int

[Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- ui/vnc.c | 45 + ui/vnc.h |3 +++ 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index f574962..44189d7 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1522,6

[Qemu-devel] [PATCH 4/4] doc: document the Pseudo-encoding of LED state

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- docs/vnc-ledstate-Pseudo-encoding.txt | 50 + 1 files changed, 50 insertions(+), 0 deletions(-) create mode 100644 docs/vnc-ledstate-Pseudo-encoding.txt diff --git a/docs/vnc-ledstate-Pseudo-encoding.txt b

[Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension

2013-04-19 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- ui/vnc.c | 48 ui/vnc.h |4 +++- 2 files changed, 51 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index f574962..e22cca1 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1522,6

[Qemu-devel] [PATCH 0/3 RFC v2] Support for LED state extension to Qemu VNC server

2013-04-19 Thread Lei Li
Hi guys, This patch series tries to add support for LED state extension to Qemu VNC server. The proposal has been sent few days ago as link below: http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html Hi Anthony, This series has not been completely tested, it takes longer than

[Qemu-devel] [PATCH 1/3] vnc: Add SCROLL lock key to kbd_leds

2013-04-19 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- ui/vnc.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 8ee66b7..f574962 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1525,10 +1525,11 @@ static void press_key(VncState *vs, int keysym) static

[Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED state

2013-04-19 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- docs/vnc-ledstate-Pseudo-encoding.txt | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) create mode 100644 docs/vnc-ledstate-Pseudo-encoding.txt diff --git a/docs/vnc-ledstate-Pseudo-encoding.txt b

Re: [Qemu-devel] [PATCH 2/2] vnc: Support for LED state extension

2013-04-18 Thread Lei Li
On 04/17/2013 09:52 PM, Anthony Liguori wrote: Lei Li li...@linux.vnet.ibm.com writes: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- ui/vnc.c | 50 ++ ui/vnc.h |3 ++- 2 files changed, 52 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH] chardev: remove the headers of Memory chardev driver

2013-04-17 Thread Lei Li
Memory chardev driver is no longer used, and Commit: 4bf0bb8014ac2ac61b1004f5d92b2a4594d48017 has droped it but the headers, so clean it up. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/sysemu/char.h |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 0/2 RFC] Support for LED state extension to Qemu VNC server

2013-04-15 Thread Lei Li
Hi guys, This patch series tries to add support for LED state extension to Qemu VNC server. The proposal has been sent few days ago as link below: http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html This is just an initial implementation, and has not been completely tested. To

[Qemu-devel] [PATCH 2/2] vnc: Support for LED state extension

2013-04-15 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- ui/vnc.c | 50 ++ ui/vnc.h |3 ++- 2 files changed, 52 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index fa7ab94..b9b3766 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1529,6

[Qemu-devel] [PATCH 1/2] vnc: Add SCROLL lock key to kbd_leds

2013-04-15 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- ui/vnc.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 5ddb696..fa7ab94 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1532,10 +1532,11 @@ static void press_key(VncState *vs, int keysym) static

Re: [Qemu-devel] weird behaviour of numlock key

2013-04-14 Thread Lei Li
On 04/12/2013 06:29 PM, Nikola Ciprich wrote: Hi Nikola, Hello Lei, thanks for Your reply. I am working on this problem. And the proposal already send as the refference link below, you might want to take a look. I'll gladly have a look..

Re: [Qemu-devel] weird behaviour of numlock key

2013-04-12 Thread Lei Li
On 04/12/2013 04:45 PM, Nikola Ciprich wrote: Hi guys, I'm trying to figure out the reason of strange problem we're having. When I start some VM under qemu-kvm, and connect using VNC, numlock behaves in a funny way. First press of the numeric keyboard behaves like numlock is enabled (or

<    1   2   3   4   5   >