Re: [RFC PATCH 4/6] Convert query-block/info_block to coroutine

; João Silva; Lin Ma; Dario Faggioli; Eric Blake Subject: Re: [RFC PATCH 4/6] Convert query-block/info_block to coroutine On 5/23/23 23:39, Fabiano Rosas wrote: > From: Lin Ma > > Sometimes the query-block performs time-consuming I/O(say waiting for > the fstat of NFS complete), So let's m

Re: [RFC PATCH 4/6] Convert query-block/info_block to coroutine

tz; Markus Armbruster; João Silva; Lin Ma; Claudio Fontana; Dario Faggioli; Eric Blake Subject: [RFC PATCH 4/6] Convert query-block/info_block to coroutine From: Lin Ma Sometimes the query-block performs time-consuming I/O(say waiting for the fstat of NFS complete), So let's make this QMP ha

[PATCH v2] scsi-generic: replace logical block count of response of READ CAPACITY

blk /dev/sda NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT sda 8:00 4G 0 disk └─sda1 8:10 2G 0 part Signed-off-by: Lin Ma Reviewed-by: Philippe Mathieu-Daudé --- hw/scsi/scsi-generic.c | 18 -- hw/scsi/trace-events | 1 + 2 files changed, 17 insertions(+)

[PATCH] scsi-generic: replace logical block count of response of READ CAPACITY

blk /dev/sda NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT sda 8:00 4G 0 disk └─sda1 8:10 2G 0 part Signed-off-by: Lin Ma --- hw/scsi/scsi-generic.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c in

[PATCH 3/3] tests: add postcopy-uffd-usermode-only capability into migration-test

Signed-off-by: Lin Ma --- tests/qtest/migration-test.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index cc5e83d98a..0cd4f49bed 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration

[PATCH 2/3] migration: postcopy-uffd-usermode-only documentation

Signed-off-by: Lin Ma --- docs/devel/migration.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index 2401253482..dfdd3f20b4 100644 --- a/docs/devel/migration.rst +++ b/docs/devel/migration.rst @@ -639,6 +639,15 @@ postcopy

[PATCH 1/3] migration: introduce postcopy-uffd-usermode-only capability

to userfaultd or the API will fail with EPERM. So add a capability to pass UFFD_USER_MODE_ONLY to support it. Signed-off-by: Lin Ma --- migration/migration.c| 9 + migration/migration.h| 1 + migration/postcopy-ram.c | 22 +++--- qapi/migration.json | 8

[PATCH 0/3] Postcopy migration: Add userfaultfd- user-mode-only capability

userfaultfd: add user-mode only option to unprivileged_userfaultfd sysctl knob This patch set adds a migration capability to pass UFFD_USER_MODE_ONLY for postcopy migration. Lin Ma (3): migration: introduce postcopy-uffd-usermode-only capability migration: postcopy-uffd-usermode-only

Question about virtio-scsi max_segments setting

Hi all, We know that the seg_max of virtio-scsi respects to virtqueue size: scsiconf->seg_max is set to virtqueue size - 2. Some of my scsi HBAs have max_segments as low as 64 in host(max_sectors_kb is 256). When I use scsi lun passthrough disk in guest, In case of default virtqueue size(256),

[REBASE] [PATCH v5] qga: Correct loop count in qmp_guest_get_vcpus()

uot;}, {"props": {"core-id": 0, "thread-id": 0, "socket-id": 1}, "vcpus-count": 1, "qom-path": "/machine/peripheral/cpu1", "type": "host-x86_64-cpu"}, {"props": {"core-id": 0, "thread-i

[PATCH v5] qga: Correct loop count in qmp_guest_get_vcpus()

uot;}, {"props": {"core-id": 0, "thread-id": 0, "socket-id": 1}, "vcpus-count": 1, "qom-path": "/machine/peripheral/cpu1", "type": "host-x86_64-cpu"}, {"props": {"core-id": 0, "thread-i

[PATCH v4] qga: Correct loop count in qmp_guest_get_vcpus()

uot;}, {"props": {"core-id": 0, "thread-id": 0, "socket-id": 1}, "vcpus-count": 1, "qom-path": "/machine/peripheral/cpu1", "type": "host-x86_64-cpu"}, {"props": {"core-id": 0, "thread-i

[PATCH v3] qga: Correct loop count in qmp_guest_get_vcpus()

uot;}, {"props": {"core-id": 0, "thread-id": 0, "socket-id": 1}, "vcpus-count": 1, "qom-path": "/machine/peripheral/cpu1", "type": "host-x86_64-cpu"}, {"props": {"core-id": 0, "thread-i

[PATCH v2] qga: Correct loop count in qmp_guest_get_vcpus()

uot;}, {"props": {"core-id": 0, "thread-id": 0, "socket-id": 1}, "vcpus-count": 1, "qom-path": "/machine/peripheral/cpu1", "type": "host-x86_64-cpu"}, {"props": {"core-id": 0, "thread-i

Re: [PATCH] qga: Correct loop count in qmp_guest_get_vcpus()

On 2020-11-19 14:46, Marc-André Lureau wrote: Hi On Thu, Nov 19, 2020 at 12:48 PM Lin Ma wrote: The guest-get-vcpus returns incorrect vcpu info in case we hotunplug vcpus(not the last one). e.g.: A VM has 4 VCPUs: cpu0 + 3 hotunpluggable online vcpus(cpu1, cpu2 and cpu3). Hotunplug cpu2

[PATCH] qga: Correct loop count in qmp_guest_get_vcpus()

d": 0, "socket-id": 0}, "vcpus-count": 1, "qom-path": "/machine/unattached/device[0]", "type": "host-x86_64-cpu"} ]} Before: ./qmp-shell -N /tmp/qmp-ga.sock Welcome to the QMP low-level shell! Connected (QEMU) guest-get-v

[PATCH] qga: Correct loop count in qmp_guest_get_vcpus()

d": 0, "socket-id": 0}, "vcpus-count": 1, "qom-path": "/machine/unattached/device[0]", "type": "host-x86_64-cpu"} ]} Before: ./qmp-shell -N /tmp/qmp-ga.sock Welcome to the QMP low-level shell! Connected (QEMU) guest-get-v

Re: The issue about adding multipath device's targets into qemu-pr-helper's namespace

On 2020-07-14 13:30, Lin Ma wrote: Hi all, I have a namespace question about passthrough disk(multipath device). In case of enabling namespace and cgroups in qemu.conf, The target(s) of the multipath device won't be added into qemu-pr-helper's namespace under certain situation, It causes

The issue about adding multipath device's targets into qemu-pr-helper's namespace

Hi all, I have a namespace question about passthrough disk(multipath device). In case of enabling namespace and cgroups in qemu.conf, The target(s) of the multipath device won't be added into qemu-pr-helper's namespace under certain situation, It causes the PERSISTENT RESERVE command failure

Re: Questions about online resizing a lun passthrough disk with virtio-scsi

On 2020-07-09 12:00, Paolo Bonzini wrote: On 09/07/20 13:52, Lin Ma wrote: It's not recommended however, because block_resize will report the change to the guest directly with a CAPACITY HAS CHANGED unit attention condition. Got it, The 'block_resize' is the recommended or necessary step

Re: Questions about online resizing a lun passthrough disk with virtio-scsi

On 2020-07-08 15:11, Paolo Bonzini wrote: On 08/07/20 16:44, lma wrote: Is the 'block_resize' mandatory to notify guest os after online resizing a lun passed through disk? I'm curious it because I found there're couple of ways can make guest os realize the disk capacity change. e.g: * run

回复: [PATCH v2 3/3] scsi-disk: Add support for the GET LBA STATUS 16 command

> -邮件原件- > 发件人: Stefan Hajnoczi > 发送时间: 2020年6月22日 20:14 > 收件人: Lin Ma > 抄送: qemu-devel@nongnu.org; f...@euphon.net; kw...@redhat.com; > mre...@redhat.com; pbonz...@redhat.com > 主题: Re: [PATCH v2 3/3] scsi-disk: Add support for the GET LBA STATUS 16 > command &

Re: [PATCH v2 3/3] scsi-disk: Add support for the GET LBA STATUS 16 command

On 2020-06-25 21:25, Lin Ma wrote: > From: Stefan Hajnoczi > Sent: Monday, June 22, 2020 8:14 PM > ... >> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c >> index 387503e11b..9e3002ddaf 100644 >> --- a/hw/scsi/scsi-disk.c >> +++ b/hw/scsi/scsi-disk.c >

Re: [PATCH v2 1/3] block: Add bdrv_co_get_lba_status

On 2020-06-25 20:59, Lin Ma wrote: > From: Stefan Hajnoczi > Sent: Monday, June 22, 2020 6:25 PM > ... >> diff --git a/block/io.c b/block/io.c >> index df8f2a98d4..2064016b19 100644 >> --- a/block/io.c >> +++ b/block/io.c >> @@ -2208,6 +2208,49 @@ int corou

[PATCH v2 0/3] Add Support for GET LBA STATUS 16 command in scsi emulation

ion of the completion condition RTP=0 descriptor LBA: 0x0400 blocks: 32 deallocated Lin Ma (3): block: Add bdrv_co_get_lba_status block: Add GET LBA STATUS support scsi-disk: Add support for the GET LBA STATUS 16 command block/block-backend.c | 38 ++ bl

[PATCH v2 3/3] scsi-disk: Add support for the GET LBA STATUS 16 command

Signed-off-by: Lin Ma --- hw/scsi/scsi-disk.c| 90 ++ include/block/accounting.h | 1 + include/scsi/constants.h | 1 + 3 files changed, 92 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 387503e11b..9e3002ddaf 100644

[PATCH v2 1/3] block: Add bdrv_co_get_lba_status

The get lba status wrapper based on the bdrv_block_status. The following patches will add GET LBA STATUS 16 support for scsi emulation layer. Signed-off-by: Lin Ma --- block/io.c| 43 +++ include/block/block_int.h | 5 + 2 files changed

[PATCH v2 2/3] block: Add GET LBA STATUS support

Signed-off-by: Lin Ma --- block/block-backend.c | 38 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 40 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index 6936b25c83..6d08dd5e0d 100644 --- a/block/block-backend.c

[PATCH v2 3/3] scsi-disk: Add support for the GET LBA STATUS 16 command

Signed-off-by: Lin Ma --- hw/scsi/scsi-disk.c| 90 ++ include/block/accounting.h | 1 + include/scsi/constants.h | 1 + 3 files changed, 92 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 387503e11b..9e3002ddaf 100644

[PATCH v2 1/3] block: Add bdrv_co_get_lba_status

The get lba status wrapper based on the bdrv_block_status. The following patches will add GET LBA STATUS 16 support for scsi emulation layer. Signed-off-by: Lin Ma --- block/io.c| 43 +++ include/block/block_int.h | 5 + 2 files changed

[PATCH v2 2/3] block: Add GET LBA STATUS support

Signed-off-by: Lin Ma --- block/block-backend.c | 38 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 40 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index 6936b25c83..6d08dd5e0d 100644 --- a/block/block-backend.c

[PATCH v2 0/3] Add Support for GET LBA STATUS 16 command in scsi emulation

ion of the completion condition RTP=0 descriptor LBA: 0x0400 blocks: 32 deallocated Lin Ma (3): block: Add bdrv_co_get_lba_status block: Add GET LBA STATUS support scsi-disk: Add support for the GET LBA STATUS 16 command block/block-backend.c | 38 ++ bl

Re: [question] Partial sector issue while discard in qcow2 image

Hi Kevin, Thanks for the explanation! Lin From: Kevin Wolf Sent: Tuesday, June 2, 2020 7:06 PM To: Lin Ma Cc: qemu-devel@nongnu.org ; pbonz...@redhat.com Subject: Re: [question] Partial sector issue while discard in qcow2 image Am 02.06.2020 um 09:45 hat

[question] Partial sector issue while discard in qcow2 image

Hi all, During woring to add GET LBA STATUS support in qemu scsi emulation layer, I encountered an unmap issue with qcow2 image, It's likely about how to unmap partial clusters. e.g.: With these default values: * the default value of s->qdev.blocksize: 512 * the default value of

[PATCH 2/4] block: Add GET LBA STATUS support

Signed-off-by: Lin Ma --- block/block-backend.c | 38 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 40 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index 6936b25c83..feb1f38b98 100644 --- a/block/block-backend.c

[PATCH 4/4] scsi-disk: Add support for the GET LBA STATUS 16 command

Signed-off-by: Lin Ma --- hw/scsi/scsi-disk.c | 92 include/scsi/constants.h | 1 + 2 files changed, 93 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 387503e11b..2d2c6b4b82 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi

[PATCH 3/4] block: Add block accounting code for GET LBA STATUS

Signed-off-by: Lin Ma --- include/block/accounting.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/block/accounting.h b/include/block/accounting.h index 878b4c3581..645014fb0b 100644 --- a/include/block/accounting.h +++ b/include/block/accounting.h @@ -38,6 +38,7 @@ enum

[PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

:~ # dd if=/dev/zero of=/dev/sda bs=512 seek=1024 count=256 guest:~ # sg_unmap -l 1024 -n 32 /dev/sda guest:~ # sg_get_lba_status /dev/sda -l 1024 No indication of the completion condition RTP=0 descriptor LBA: 0x0400 blocks: 32 deallocated Lin Ma (4): block: Add bdrv_co_get_lba_status

[PATCH 1/4] block: Add bdrv_co_get_lba_status

The get lba status wrapper based on the bdrv_block_status. The following patches will add GET LBA STATUS 16 support for scsi emulation layer. Signed-off-by: Lin Ma --- block/io.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/block/io.c b/block

Re: [Question] About GET LBA STATUS(16) support in qemu scsi emulation layer

information, Lin From: Stefan Hajnoczi Sent: Tuesday, March 10, 2020 5:24 PM To: Lin Ma Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; h...@suse.de; Eric Blake; Jon Maloy; qemu-bl...@nongnu.org Subject: Re: [Question] About GET LBA STATUS(16) support in qemu scsi

Re: [Question] About GET LBA STATUS(16) support in qemu scsi emulation layer

in vm to get the lba status? If it doesn't make sense, That could explain why qemu scsi emulation layer lack of this support for a long time and no user complains. Thanks, Lin From: Stefan Hajnoczi Sent: Friday, March 6, 2020 9:01 PM To: Lin Ma Cc: qemu-devel

[Question] About GET LBA STATUS(16) support in qemu scsi emulation layer

Hi all, I'm not familiar with scsi, I'm curious why there is no GET LBA STATUS(16) support in qemu scsi emulation layer. So far, There is only one subcommand of SERVICE ACTION was implemented: The READ CAPACITY(16) e.g. static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf)

[Qemu-devel] 回复: 回复: 答复: migrate_set_speed has no effect if the guest is using hugepages.

Hi Dave, May I ask that do you have any update about the fix? Thanks, Lin > -邮件原件- > 发件人: Qemu-devel 代 > 表 Lin Ma > 发送时间: 2019年7月15日 17:43 > 收件人: Dr. David Alan Gilbert > 抄送: qemu-devel@nongnu.org > 主题: [Qemu-devel] 回复: 答复: migrate_set_speed has no effect if

[Qemu-devel] 回复: 答复: migrate_set_speed has no effect if the guest is using hugepages.

> -邮件原件- > 发件人: Dr. David Alan Gilbert > 发送时间: 2019年7月12日 20:34 > 收件人: Lin Ma > 抄送: qemu-devel@nongnu.org > 主题: Re: 答复: [Qemu-devel] migrate_set_speed has no effect if the guest is > using hugepages. > > * Lin Ma (l...@suse.com) wrote: > > > > &g

[Qemu-devel] migrate_set_speed has no effect if the guest is using hugepages.

Hi all, When I live migrate a qemu/kvm guest, If the guest is using huge pages, I found that the migrate_set_speed command had no effect during stage 2. It was caused by commit 4c011c3 postcopy: Send whole huge pages I'm wondering that is it by design or is it a bug waiting for fix? Thanks,

Re: [Qemu-devel] About pt-br keyboard layout

On 4/26/19 7:48 PM, Gerd Hoffmann wrote: So -k must match the *hosts* keyboard layout. So, that means, If I launch qemu with -k pt-br on a host, I need to ensure the keyboard layout must be pt-br as well onthathypervisorhost,Then when I connected to this vnc server(qemu) throughvncviewer on

Re: [Qemu-devel] About pt-br keyboard layout

On 4/26/19 4:38 PM, Gerd Hoffmann wrote: On Fri, Apr 26, 2019 at 04:09:12PM +0800, Lin Ma wrote: Hi all, While I launch qemu with vnc + pt-br keyboard layout on my pc, If I type shift + 6 in iPXE shell or grub shell via my usual 105-key keyboard, shift + 6 would be mapped to "(apost

[Qemu-devel] About pt-br keyboard layout

Hi all, While I launch qemu with vnc + pt-br keyboard layout on my pc, If I type shift + 6 in iPXE shell or grub shell via my usual 105-key keyboard, shift + 6 would be mapped to "(apostrophe), But IIUC the correct character should be ¨(diaeresis) in pt-br layout. I'm wondering that is it

[Qemu-devel] [PATCH v3] net: Fix a potential segfault

If user forgets to provide any backend types for '-netdev' in qemu CLI, It triggers seg fault. e.g. Expected: $ qemu -netdev id=net0 qemu-system-x86_64: Parameter 'type' is missing Actual: $ qemu -netdev id=net0 Segmentation fault (core dumped) Signed-off-by: Lin Ma --- net/net.c | 4 +++- 1

[Qemu-devel] [PATCH v2] net: Fix a potential segfault

If user forgets to provide any backend types for '-netdev' in qemu CLI, It triggers seg fault. e.g. Expected: $ qemu -netdev id=net0 qemu-system-x86_64: Parameter 'type' is missing Actual: $ qemu -netdev id=net0 Segmentation fault (core dumped) Signed-off-by: Lin Ma --- net/net.c | 9

[Qemu-devel] [PATCH] net: Fix a potential segfault

Signed-off-by: Lin Ma --- net/net.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index efb9eaf779..f89790be4a 100644 --- a/net/net.c +++ b/net/net.c @@ -1093,9 +1093,12 @@ static int net_client_init(QemuOpts *opts, bool is_netdev, Error

Re: [Qemu-devel] [PATCH] raw: Disable probing if image format is given by driver-specific options

On 01/23/2018 12:45 AM, Max Reitz wrote: On 2018-01-22 08:21, Lin Ma wrote: If the user specifies image format through driver-specific options, The format probing should be prohibited and the warning message should not be printed. e.g.: $ qemu-system-x86_64 ... -drive file.file.filename=disk0

[Qemu-devel] [PATCH] raw: Disable probing if image format is given by driver-specific options

' and probing guessed raw. Automatically detecting the format is dangerous for raw images, ... Signed-off-by: Lin Ma <l...@suse.com> --- blockdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/blockdev.c b/blockdev.c index 29d569a24e..ef4c167235 100644 --- a/blockdev.c

[Qemu-devel] [PATCH] build: Fix typo in scripts/git-submodule.sh

Signed-off-by: Lin Ma <l...@suse.com> --- scripts/git-submodule.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh index bc7224a..807ca0b 100755 --- a/scripts/git-submodule.sh +++ b/scripts/git-submodule.sh @@ -28,7

[Qemu-devel] [PATCH] configure: add the missing help output for optional features

Signed-off-by: Lin Ma <l...@suse.com> --- configure | 12 1 file changed, 12 insertions(+) diff --git a/configure b/configure index 6c21975..2603e10 100755 --- a/configure +++ b/configure @@ -1335,6 +1335,12 @@ Advanced options (experts only): --with-vss-sdk=SDK-path

Re: [Qemu-devel] 答复： Re: [RFC] virtio-fc: draft idea of virtual fibre channel HBA

Hi Hannes, >>> Hannes Reinecke <h...@suse.de> 2017/2/16 星期四 下午 5:56 >>> >On 02/16/2017 09:39 AM, Paolo Bonzini wrote: >> >> >> On 16/02/2017 08:16, Lin Ma wrote: >>>> What are the benefits of having FC access from the guest? >>&

Re: [Qemu-devel] 答复： Re: [RFC] virtio-fc: draft idea of virtual fibre channel HBA

>>> Paolo Bonzini <pbonz...@redhat.com> 2/16/2017 4:39 下午 >>> > > >On 16/02/2017 08:16, Lin Ma wrote: >>> What are the benefits of having FC access from the guest? >> >> Actually, I havn't dug it too much, Just thought that from virtuali

[Qemu-devel] 答复： Re: [PATCH v2 RESEND] Makefile: Fix owner and group for qemu-version.h.tmp

>>> Paolo Bonzini <pbonz...@redhat.com> 2017/2/13 星期一 下午 6:07 >>> > > >On 13/02/2017 10:51, Lin Ma wrote: >> By commit 67a1de0d, When we perform 'git pull && make && sudo make install', >> In 'make' stage a qemu-version.h.tmp will b

[Qemu-devel] 答复： Re: [PATCH] trace: fix trace-events-all dependencies in Makefile.objs

Yeah, I just noticed, Thank you. >>> "Daniel P. Berrange" <berra...@redhat.com> 2017/2/13 星期一 下午 5:38 >>> On Mon, Feb 13, 2017 at 05:27:09PM +0800, Lin Ma wrote: > It causes that file trace-events-all isn't generated during build, make > install report

[Qemu-devel] [PATCH v2 RESEND] Makefile: Fix owner and group for qemu-version.h.tmp

sion.h.tmp can't be overwritten because of permission issue. This patch uses 'cp' instead of 'mv' to keep the qemu-version.h.tmp file, So during the 'sudo make install' stage, new qemu-version.h.tmp's owner and group wont be set to privileged user/group. Signed-off-by: Lin Ma <l...@suse.com> Rev

[Qemu-devel] 答复： [PATCH] trace: fix trace-events-all dependencies in Makefile.objs

Oops, I didn't notice that the issue was fixed already, Sorry about that. Lin >>> Lin Ma <l...@suse.com> 2017/2/13 星期一 下午 5:27 >>> It causes that file trace-events-all isn't generated during build, make install reports 'No such file or directory'. The patch fixes it.

[Qemu-devel] [PATCH] trace: fix trace-events-all dependencies in Makefile.objs

It causes that file trace-events-all isn't generated during build, make install reports 'No such file or directory'. The patch fixes it. Signed-off-by: Lin Ma <l...@suse.com> --- trace/Makefile.objs | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/trace/Makefile.

[Qemu-devel] [PATCH v2] qmp: Fix argument name in error message of device-list-properties

The argument is called "typename", not "name". [Thanks to Markus for correcting the commit message] Signed-off-by: Lin Ma <l...@suse.com> --- qmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qmp.c b/qmp.c index 0028f0b..886059e 1006

[Qemu-devel] [PATCH] qmp: set accurate parameter name for error msg of device-list-properties

Signed-off-by: Lin Ma <l...@suse.com> --- qmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qmp.c b/qmp.c index 0028f0b..812db6c 100644 --- a/qmp.c +++ b/qmp.c @@ -531,7 +531,7 @@ DevicePropertyInfoList *qmp_device_list_properties(const char *typename,

[Qemu-devel] 答复： [PATCH] Makefile: Fix owner and group for qemu-version.h.tmp

Oops, Sorry that I forgot to add 'V2' in email's title. Thank Fam Zheng to review the patch. Lin >>> Lin Ma <l...@suse.com> 2017/1/17 星期二 下午 12:33 >>> By commit 67a1de0d, When we perform 'git pull && make && sudo make install', In 'make' stag

[Qemu-devel] [PATCH] Makefile: Fix owner and group for qemu-version.h.tmp

sion.h.tmp can't be overwritten because of permission issue. This patch uses 'cp' instead of 'mv' to keep the qemu-version.h.tmp file, So during the 'sudo make install' stage, new qemu-version.h.tmp's owner and group wont be set to privileged user/group. Signed-off-by: Lin Ma <l...@suse.com> --- M

[Qemu-devel] [PATCH] Makefile: Fix owner and group for qemu-version.h.tmp

sion.h.tmp can't be overwrited because of permission issue. This patch uses 'cp' instead of 'mv' to keep the qemu-version.h.tmp file, So during the 'sudo make install' stage, new qemu-version.h.tmp's owner and group wont be set to privileged user/group. Signed-off-by: Lin Ma <l...@suse.com> --- M

[Qemu-devel] [PATCH] tests: Ignore test-char binary

Commit ea3af47d added test for chardev unit tests, but didn't add the name of generated binary in .gitignore. Signed-off-by: Lin Ma <l...@suse.com> --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index c0d7857..99f2aac

[Qemu-devel] 答复： Re: About vNVDIMM question in TCG

You've been very helpful, haozhong, Thanks for your comments, I appreciate. >>> Haozhong Zhang <haozhong.zh...@intel.com> 2016/11/21 星期一 上午 10:55 >>> On 11/20/16 10:58 -0700, Lin Ma wrote: >Hi Guangrong, > >I'm interested in vNVDIMM on qemu. I'd like to give it a

[Qemu-devel] About vNVDIMM question in TCG

Hi Guangrong, I'm interested in vNVDIMM on qemu. I'd like to give it a try on my laptop. Because I dont have skylake server hardware, So I want to expose cpu flags clflushopt, clwb and pcommit to guest for NVDIMM drivers on TCG. I saw clflushopt and clwb feature flags in cpuinfo of guest, but

Re: [Qemu-devel] 答复： [PATCH] smbios: Add 1 terminator if there is any string field defined in given table.

>>> "Daniel P. Berrange" berra...@redhat.com> 2016/11/8 星期二 上午 12:31 >> ( mailto:berra...@redhat.com) .. >> > >Code identation is this patch looks totally mangled. > How about this one: (From the code style's perspective, it should be no big problem)

[Qemu-devel] 答复： [PATCH] smbios: Add 1 terminator if there is any string field defined in given table.

Ping. >>> Lin Ma <l...@suse.com> 2016/9/6 星期二 下午 4:28 >>> If user specifies binary file on command line to load smbios entries, then will get error messages while decoding them in guest. Reproducer: 1. dump a smbios table to a binary file from host or guest.(says table 1)

[Qemu-devel] 答复： Re: [PATCH v4 5/5] object: Add 'help' option for all available backends and properties

>>> Markus Armbruster <arm...@redhat.com> 2016/11/4 星期五 上午 3:50 >>> >Lin Ma <l...@suse.com> writes: > >> '-object help' prints available user creatable backends. >> '-object $typename,help' prints relevant properties. >> >>

[Qemu-devel] 答复： Re: [PATCH v4 4/5] backends: add description for enum class properties

>>> Markus Armbruster <arm...@redhat.com> 2016/11/4 星期五 上午 3:58 >>> >Lin Ma <l...@suse.com> writes: > >> Signed-off-by: Lin Ma <l...@suse.com> >> --- >> backends/hostmem.c | 4 >> crypto/secret.c| 4 >>

[Qemu-devel] 答复： Re: [PATCH v4 2/5] qapi: auto generate enum value strings

>>> Markus Armbruster <arm...@redhat.com> 2016/11/4 星期五 上午 3:17 >>> >Lin Ma <l...@suse.com> writes: > >> Automatically generate enum value strings that containing the acceptable >> values. >> (Borrowed Daniel's code.) >> >> Sign

[Qemu-devel] 答复： Re: [PATCH v4 1/5] qom: Add interface check in object_class_is_abstract

>>> Markus Armbruster <arm...@redhat.com> 2016/11/4 星期五 上午 2:18 >>> >Lin Ma <l...@suse.com> writes: > >> Signed-off-by: Lin Ma <l...@suse.com> >> --- >> qom/object.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(

[Qemu-devel] 答复： [PATCH v4 5/5] object: Add 'help' option for all available backends and properties

ping... >>> Lin Ma <l...@suse.com> 2016/10/20 星期四 下午 7:28 >>> '-object help' prints available user creatable backends. '-object $typename,help' prints relevant properties. Signed-off-by: Lin Ma <l...@suse.com> --- include/qom/object_interf

[Qemu-devel] 答复： [PATCH v4 3/5] qapi: add test case for the generated enum value str

ping... >>> Lin Ma <l...@suse.com> 2016/10/20 星期四 下午 7:28 >>> Signed-off-by: Lin Ma <l...@suse.com> --- tests/test-qmp-commands.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c index 81cbe

[Qemu-devel] 答复： [PATCH v4 2/5] qapi: auto generate enum value strings

ping... >>> Lin Ma <l...@suse.com> 2016/10/20 星期四 下午 7:28 >>> Automatically generate enum value strings that containing the acceptable values. (Borrowed Daniel's code.) Signed-off-by: Lin Ma <l...@suse.com> --- scripts/qapi-types.py | 2 ++ scripts/qapi.py| 9

[Qemu-devel] 答复： [PATCH v4 4/5] backends: add description for enum class properties

ping... >>> Lin Ma <l...@suse.com> 2016/10/20 星期四 下午 7:28 >>> Signed-off-by: Lin Ma <l...@suse.com> --- backends/hostmem.c | 4 crypto/secret.c| 4 crypto/tlscreds.c | 4 net/filter.c | 4 4 files changed, 16 insertions(+) diff --git a

[Qemu-devel] 答复： [PATCH v4 1/5] qom: Add interface check in object_class_is_abstract

ping... >>> Lin Ma <l...@suse.com> 2016/10/20 星期四 下午 7:28 >>> Signed-off-by: Lin Ma <l...@suse.com> --- qom/object.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 7a05e35..4096645 100644 --- a/qom/object.

[Qemu-devel] 答复： [PATCH v4 0/5] object: Add 'help' option for all available backends and properties

ping... >>> Lin Ma <l...@suse.com> 2016/10/20 星期四 下午 7:28 >>> V3->V4: * drop the code about manually define interface 'user-creatable' as abstract. * add test case for the generated enum value str. * split the code about adding descriptions to class properties into

[Qemu-devel] [PATCH v4 4/5] backends: add description for enum class properties

Signed-off-by: Lin Ma <l...@suse.com> --- backends/hostmem.c | 4 crypto/secret.c| 4 crypto/tlscreds.c | 4 net/filter.c | 4 4 files changed, 16 insertions(+) diff --git a/backends/hostmem.c b/backends/hostmem.c index 4256d24..25f303d 100644 --- a/ba

[Qemu-devel] [PATCH v4 1/5] qom: Add interface check in object_class_is_abstract

Signed-off-by: Lin Ma <l...@suse.com> --- qom/object.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 7a05e35..4096645 100644 --- a/qom/object.c +++ b/qom/object.c @@ -747,7 +747,11 @@ ObjectClass *object_get_class(Object *obj)

[Qemu-devel] [PATCH v4 5/5] object: Add 'help' option for all available backends and properties

'-object help' prints available user creatable backends. '-object $typename,help' prints relevant properties. Signed-off-by: Lin Ma <l...@suse.com> --- include/qom/object_interfaces.h | 2 ++ qemu-options.hx | 7 +- qom/object_interfaces.c

[Qemu-devel] [PATCH v4 0/5] object: Add 'help' option for all available backends and properties

ype machine. V1->V2: * Output the acceptable values of enum types by "-object TYPE-NAME,help" Lin Ma (5): qom: Add interface check in object_class_is_abstract qapi: auto generate enum value strings qapi: add test case for the generated enum value str backends: add descript

[Qemu-devel] [PATCH v4 2/5] qapi: auto generate enum value strings

Automatically generate enum value strings that containing the acceptable values. (Borrowed Daniel's code.) Signed-off-by: Lin Ma <l...@suse.com> --- scripts/qapi-types.py | 2 ++ scripts/qapi.py | 9 + 2 files changed, 11 insertions(+) diff --git a/scripts/qapi-types.py b/s

[Qemu-devel] [PATCH v4 3/5] qapi: add test case for the generated enum value str

Signed-off-by: Lin Ma <l...@suse.com> --- tests/test-qmp-commands.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c index 81cbe54..9cd61b2 100644 --- a/tests/test-qmp-commands.c +++ b/tests/test-qmp-commands.c @@

Re: [Qemu-devel] 答复： Re: [PATCH v3 2/3] qapi: auto generate enum value strings

>>> Markus Armbruster <arm...@redhat.com> 2016/10/11 星期二 下午 2:56 >>> >Eric Blake <ebl...@redhat.com> writes: > >> On 10/10/2016 10:09 AM, Lin Ma wrote: >>> >>> >>>>>> Eric Blake <ebl...@redhat.com> 2016/9/27

[Qemu-devel] 答复： Re: [PATCH v3 2/3] qapi: auto generate enum value strings

>>> Eric Blake <ebl...@redhat.com> 2016/9/27 星期二 上午 4:17 >>> >On 09/26/2016 05:38 AM, Daniel P. Berrange wrote: >> On Mon, Sep 26, 2016 at 06:16:26PM +0800, Lin Ma wrote: >>> Automatically generate enum value strings that containing the acceptable >&

[Qemu-devel] 答复： Re: [PATCH v3 3/3] object: Add 'help' option for all available backends and properties

>>> "Daniel P. Berrange" <berra...@redhat.com> 2016/9/26 星期一 下午 6:41 >>> >On Mon, Sep 26, 2016 at 06:16:27PM +0800, Lin Ma wrote: >> '-object help' prints available user creatable backends. >> '-object $typename,help' prints relevant proper

[Qemu-devel] 答复： Re: [PATCH v3 1/3] qom: make base type user-creatable abstract

>>> "Daniel P. Berrange" <berra...@redhat.com> 2016/9/26 星期一 下午 6:37 >>> >On Mon, Sep 26, 2016 at 06:16:25PM +0800, Lin Ma wrote: >> Signed-off-by: Lin Ma <l...@suse.com> >> --- >> qom/object_interfaces.c | 1 + >> 1 file change

[Qemu-devel] [PATCH v3 0/3] object: Add 'help' option for all available backends and properties

)', because host_memory_backend_init needs to access an instance of type machine. V1->V2: * Output the acceptable values of enum types by "-object TYPE-NAME,help" Lin Ma (3): qom: make base type user-creatable abstract qapi: auto generate enum value strings object: Add 'help' option

[Qemu-devel] [PATCH v3 3/3] object: Add 'help' option for all available backends and properties

'-object help' prints available user creatable backends. '-object $typename,help' prints relevant properties. Signed-off-by: Lin Ma <l...@suse.com> --- backends/hostmem.c | 4 crypto/secret.c | 4 crypto/tlscreds.c | 4 inclu

[Qemu-devel] [PATCH v3 1/3] qom: make base type user-creatable abstract

Signed-off-by: Lin Ma <l...@suse.com> --- qom/object_interfaces.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c index bf59846..9288242 100644 --- a/qom/object_interfaces.c +++ b/qom/object_interfaces.c @@ -217,6 +217,7 @@ stati

[Qemu-devel] [PATCH v3 2/3] qapi: auto generate enum value strings

Automatically generate enum value strings that containing the acceptable values. (Borrowwed Daniel's code.) Signed-off-by: Lin Ma <l...@suse.com> --- scripts/qapi-types.py | 2 ++ scripts/qapi.py | 9 + 2 files changed, 11 insertions(+) diff --git a/scripts/qapi-types.py b/s

[Qemu-devel] [PATCH] iothread: check iothread->ctx before aio_context_unref to avoid assertion

if iothread->ctx is set to NULL, aio_context_unref triggers the assertion: g_source_unref: assertion 'source != NULL' failed. The patch fixes it. Signed-off-by: Lin Ma <l...@suse.com> --- iothread.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/iothread.c b/iothread.c inde

[Qemu-devel] [PATCH] maint: Add module_block.h to .gitignore

Commit 0c0c1fd9 generated module_block.h automatically, Add it to .gitignore to avoid checking in it by 'git add .'. Signed-off-by: Lin Ma <l...@suse.com> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index c91d018..97aca6c 100644 --- a/.git

Re: [Qemu-devel] 答复： Re: [PATCH v2] object: Add 'help' option for all available backends and properties

>>> Markus Armbruster 2016/9/20 星期二 上午 1:13 >>> >Andreas Färber writes: > >> Hi Lin and Markus, >> >> Am 19.09.2016 um 13:58 schrieb Markus Armbruster: >[...] >>> You're messing with struct EnumProperty because you want more help than >>> what

[Qemu-devel] 答复： Re: [PATCH v2] object: Add 'help' option for all available backends and properties

>>> "Daniel P. Berrange" <berra...@redhat.com> 2016/9/12 星期一 下午 11:56 >>> >On Sun, Sep 11, 2016 at 01:53:01PM +0800, Lin Ma wrote: >> '-object help' prints available user creatable backends. >> '-object $typename,help' prints relevant proper

  1   2   >