On Tue, 30 Jan 2024 at 10:12, Daniel P. Berrangé wrote:
>
> On Tue, Jan 30, 2024 at 09:56:15AM +0200, Manos Pitsidianakis wrote:
> > Check if a file argument is a cover letter patch produced by
> > git-format-patch --cover-letter; It is initialized with subject suffix &quo
Check if a file argument is a cover letter patch produced by
git-format-patch --cover-letter; It is initialized with subject suffix "
*** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they
exist, warn the user.
Signed-off-by: Manos Pitsidianakis
---
script
ppropriate.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Manos Pitsidianakis
---
include/hw/block/block.h | 4 ++--
hw/block/block.c | 25 +++--
hw/block/m25p80.c| 3 ++-
hw/block/pflash_cfi01.c | 4 ++--
hw/block/pflash_cfi02.c | 2 +-
5 files c
Add a simple method to return some kind of human readable identifier for
use in error messages.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Manos Pitsidianakis
---
include/hw/qdev-core.h | 14 ++
hw/core/qdev.c | 8
2 files changed, 22 insertions(+)
diff --git
et_human_name
(thanks Phil Mathieu-Daudé )
Manos Pitsidianakis (2):
hw/core/qdev.c: add qdev_get_human_name()
hw/block/block.c: improve confusing blk_check_size_and_read_all()
error
include/hw/block/block.h | 4 ++--
include/hw/qdev-core.h | 14 ++
On Tue, 30 Jan 2024 03:26, Gurchetan Singh wrote:
On Mon, Jan 29, 2024 at 7:46 AM Manos Pitsidianakis <
manos.pitsidiana...@linaro.org> wrote:
When the Rutabaga GPU device frees resources, it calls
rutabaga_resource_unref for that resource_id. However, when the generic
VirtIOGPU fun
-by: Manos Pitsidianakis
---
hw/xen/trace-events | 11 +
hw/xen/xen-mapcache.c | 54 +++
2 files changed, 35 insertions(+), 30 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 67a6c41926..a65dc0e55f 100644
--- a/hw/xen
ormat.
> Use error_printf() & friends to print additional information.
This commit changes fprintfs that report warnings and errors to the
appropriate report functions.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Manos Pitsidianakis
---
hw/xen/xen-hvm-common.c | 12 ++--
hw/xen/xe
that report guest errors are logged with
LOG_GUEST_ERROR.
Signed-off-by: Manos Pitsidianakis
---
hw/arm/trace-events | 7 +++
hw/arm/z2.c | 27 ---
2 files changed, 15 insertions(+), 19 deletions(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
index
that report guest errors are logged with
LOG_GUEST_ERROR.#
Signed-off-by: Manos Pitsidianakis
---
hw/arm/strongarm.c | 82 -
hw/arm/trace-events | 3 ++
2 files changed, 55 insertions(+), 30 deletions(-)
diff --git a/hw/arm/strongarm.c b/hw/arm
-by: Manos Pitsidianakis
---
hw/xen/trace-events | 10 +-
hw/xen/xen-hvm-common.c | 35 ++-
2 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index a65dc0e55f..d1b27f6c11 100644
--- a/hw/xen/trace
This series changes some printfs to use the trace event framework.
Additionally, it converts some error/warning reporting fprintfs to
error_report/warn_report.
v2 -> v3
:
- addressed Peter Maydells's review
v1 -> v2
:
- addressed Alex's review
Manos Pitsidianakis (6):
or warnings are converted to error_report and
warn_report calls.
Signed-off-by: Manos Pitsidianakis
---
hw/arm/trace-events | 5 +
hw/arm/xen_arm.c| 23 +++
2 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
index
ted with that resource_id is then leaked.
This commit overrides the resource_destroy class method introduced in
the previous commit to fix this.
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu-rutabaga.c | 51
1 file changed, 39 insertions(+), 12 deleti
for implementations in the future.
Reviewed-by: Marc-André Lureau
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index f8a675eb30..2b73ae585b 100644
--- a/hw
-by: Manos Pitsidianakis
---
include/hw/virtio/virtio-gpu.h | 3 +++
hw/display/virtio-gpu.c| 25 ++---
2 files changed, 25 insertions(+), 3 deletions(-)
diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index 584ba2ed73..b28e7ef0d2 100644
to be destroyed as well.
This series adds a resource_destroy class method that the Rutabaga
device can override and do its own bookkeeping.
v1 -> v2 differences:
- addressed review comments re: using the Error API for the
resource_destroy method.
Manos Pitsidianakis (3):
hw/display/vir
On Fri, 26 Jan 2024 at 17:22, Philippe Mathieu-Daudé wrote:
>
> Hi Manos,
>
> On 26/1/24 15:41, Manos Pitsidianakis wrote:
> > When destroying/unrefing resources, devices such as virtio-gpu-rutabaga
> > need to do their own bookkeeping (free rutabaga resources
On Fri, 26 Jan 2024 at 20:09, Alex Bennée wrote:
>
> Manos Pitsidianakis writes:
>
> > When destroying/unrefing resources, devices such as virtio-gpu-rutabaga
> > need to do their own bookkeeping (free rutabaga resources that are
> > associated with the
ted with that resource_id is then leaked.
This commit overrides the resource_destroy class method introduced in
the previous commit to fix this.
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu-rutabaga.c | 31 ---
1 file changed, 20 insertions(+), 11 deleti
-by: Manos Pitsidianakis
---
hw/display/virtio-gpu.c| 19 ---
include/hw/virtio/virtio-gpu.h | 2 ++
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 2b73ae585b..96420ba74f 100644
--- a/hw/display/virtio
for implementations in the future.
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index f8a675eb30..2b73ae585b 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw
that need to be destroyed as well.
This series adds a resource_destroy class method that the Rutabaga
device can override and do its own bookkeeping.
Manos Pitsidianakis (3):
hw/display/virtio-gpu.c: use reset_bh class method
virtio-gpu.c: add resource_destroy class method
virtio-gpu-rutabaga.c
c_exit(cpu);
+};
return ret;
}
--
2.41.0
Reviewed-by: Manos Pitsidianakis
", 0x%"HWADDR_PRIx") = %d (%s)",
+ bcontainer, iova, iotlb->addr_mask + 1, ret,
+ strerror(-ret));
+}
+}
}
}
-rcu_read_unlock();
-out:
if (ret) {
vfio_set_migration_error(ret);
}
--
2.41.0
Reviewed-by: Manos Pitsidianakis
but there's
no check if a resetting is taking place before starting another. Is this
single threaded code so it's not necessary?
As for the patch:
Reviewed-by: Manos Pitsidianakis
qemu_log_mask(LOG_GUEST_ERROR, "translation "
--
2.41.0
Reviewed-by: Manos Pitsidianakis
rcu_read_unlock();
+WITH_RCU_READ_LOCK_GUARD() {
+rb = qemu_ram_block_from_host(res->iov[i].iov_base, false,
);
+}
if (!rb || rb->fd < 0) {
g_free(list);
--
2.41.0
Reviewed-by: Manos Pitsidianakis
ppropriate.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Manos Pitsidianakis
---
hw/block/block.c | 25 +++--
hw/block/m25p80.c| 3 ++-
hw/block/pflash_cfi01.c | 4 ++--
hw/block/pflash_cfi02.c | 2 +-
include/hw/block/block.h | 4 ++--
5 files c
Add a simple method to return some kind of human readable identifier for
use in error messages.
Signed-off-by: Manos Pitsidianakis
---
hw/core/qdev.c | 8
include/hw/qdev-core.h | 14 ++
2 files changed, 22 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core
ckend name, the device id and device type name where appropriate.
Version 2:
- Assert dev is not NULL on qdev_get_human_name
(thanks Phil Mathieu-Daudé )
Manos Pitsidianakis (2):
hw/core/qdev.c: add qdev_get_human_name()
hw/block/block.c: improve confusing blk_check_size_and_read_all()
error
On Tue, 23 Jan 2024 10:13, Philippe Mathieu-Daudé wrote:
Hi Manos,
On 23/1/24 09:09, Manos Pitsidianakis wrote:
Add a simple method to return some kind of human readable identifier for
use in error messages.
Signed-off-by: Manos Pitsidianakis
---
hw/core/qdev.c | 10
ppropriate.
Signed-off-by: Manos Pitsidianakis
---
hw/block/block.c | 25 +++--
hw/block/m25p80.c| 3 ++-
hw/block/pflash_cfi01.c | 4 ++--
hw/block/pflash_cfi02.c | 2 +-
include/hw/block/block.h | 4 ++--
5 files changed, 22 insertions(+), 16 deletion
ckend name, the device id and device type name where appropriate.
Manos Pitsidianakis (2):
hw/core/qdev.c: add qdev_get_human_name()
hw/block/block.c: improve confusing blk_check_size_and_read_all()
error
hw/block/block.c | 25 +++--
hw/block/m25p80.c| 3 ++-
Add a simple method to return some kind of human readable identifier for
use in error messages.
Signed-off-by: Manos Pitsidianakis
---
hw/core/qdev.c | 10 ++
include/hw/qdev-core.h | 15 +++
2 files changed, 25 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core
or warnings are converted to error_report and
warn_report calls.
Signed-off-by: Manos Pitsidianakis
---
hw/arm/trace-events | 5 +
hw/arm/xen_arm.c| 23 +++
2 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
index
-by: Manos Pitsidianakis
---
hw/xen/trace-events | 11 +
hw/xen/xen-mapcache.c | 54 +++
2 files changed, 35 insertions(+), 30 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 67a6c41926..1b748dba09 100644
--- a/hw/xen
This series changes some printfs to use the trace event framework.
Additionally, it converts some error/warning reporting fprintfs to
error_report/warn_report.
Differences from v1
:
- addressed Alex's review
Manos Pitsidianakis (5):
hw/arm/z2: convert DPRINTF to trace events and guest
-by: Manos Pitsidianakis
---
hw/xen/trace-events | 10 +-
hw/xen/xen-hvm-common.c | 35 ++-
2 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 1b748dba09..dd5b5a7f35 100644
--- a/hw/xen/trace
that report guest errors are logged with
LOG_GUEST_ERROR.
Signed-off-by: Manos Pitsidianakis
---
hw/arm/strongarm.c | 55 ++---
hw/arm/trace-events | 10 +
hw/arm/z2.c | 27 +++---
3 files changed, 45 insertions(+), 47
ormat.
> Use error_printf() & friends to print additional information.
This commit changes fprintfs that report warnings and errors to the
appropriate report functions.
Signed-off-by: Manos Pitsidianakis
---
hw/xen/xen-hvm-common.c | 12 ++--
hw/xen/xen-mapcache.c | 5 ++---
2 files ch
-by: Manos Pitsidianakis
---
hw/xen/trace-events | 10 +-
hw/xen/xen-hvm-common.c | 35 ++-
2 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 1b748dba09..dd5b5a7f35 100644
--- a/hw/xen/trace
-by: Manos Pitsidianakis
---
hw/xen/trace-events | 11 +
hw/xen/xen-mapcache.c | 54 +++
2 files changed, 35 insertions(+), 30 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 67a6c41926..1b748dba09 100644
--- a/hw/xen
ormat.
> Use error_printf() & friends to print additional information.
This commit changes fprintfs that report warnings and errors to the
appropriate report functions.
Signed-off-by: Manos Pitsidianakis
---
hw/xen/xen-hvm-common.c | 12 ++--
hw/xen/xen-mapcache.c | 5 ++---
2 files ch
-by: Manos Pitsidianakis
---
hw/arm/strongarm.c | 49 +++--
hw/arm/trace-events | 18 +
2 files changed, 39 insertions(+), 28 deletions(-)
diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c
index fef3638aca..3ff748e826 100644
--- a/hw/arm
-by: Manos Pitsidianakis
---
hw/arm/trace-events | 8
hw/arm/z2.c | 26 +-
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
index cdc1ea06a8..a262ad2e6a 100644
--- a/hw/arm/trace-events
+++ b/hw/arm
-by: Manos Pitsidianakis
---
hw/arm/trace-events | 7 +++
hw/arm/xen_arm.c| 26 +++---
2 files changed, 22 insertions(+), 11 deletions(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
index a6a67d5f16..e3f5d677d7 100644
--- a/hw/arm/trace-events
+++ b/hw/arm
This series changes some printfs to use the trace event framework.
Additionally, it converts some error/warning reporting fprintfs to
error_report/warn_report.
Manos Pitsidianakis (6):
hw/arm/z2: convert DPRINTF to tracepoints
hw/arm/strongarm.c: convert DPRINTF to tracepoints
hw/arm
+
> 1 file changed, 1 insertion(+)
Hello Volker!
I don't have the slightest clue on how migration works, but if this is
enough to prevent those bugs from happening, it sounds good to me.
Reviewed-by: Manos Pitsidianakis
On Fri, 24 Nov 2023 12:25, Kevin Wolf wrote:
Am 23.11.2023 um 15:56 hat Manos Pitsidianakis geschrieben:
On Thu, 23 Nov 2023 16:35, "Michael S. Tsirkin" wrote:
> On Thu, Nov 23, 2023 at 11:40:26AM +, Daniel P. Berrangé wrote:
> > There has been an explosion of intere
On Thu, 23 Nov 2023 16:35, "Michael S. Tsirkin" wrote:
On Thu, Nov 23, 2023 at 11:40:26AM +, Daniel P. Berrangé wrote:
There has been an explosion of interest in so called "AI" (LLM)
code generators in the past year or so. Thus far though, this is
has not been matched by a broadly accepted
On Thu, 23 Nov 2023 12:15, Michael Tokarev wrote:
21.11.2023 12:38, Manos Pitsidianakis :
In the minimal pixman API stub that is used when the real pixman
dependency is missing a NULL dereference happens when
virtio-gpu-rutabaga allocates a pixman image with bits = NULL and
rowstride_bytes
BIOS_SIZE, errp)) {
+return;
+}
memory_region_add_subregion(get_system_memory(), (uint32_t)(-BIOS_SIZE),
>bios);
if (s->bios_name) {
--
2.41.0
Reviewed-by: Manos Pitsidianakis
h", s->flash_size,
errp)) {
return;
}
--
Reviewed-by: Manos Pitsidianakis
+ !memory_region_init_ram_from_fd(mr, owner, arg3, arg4, arg5, arg6, arg7,
)
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
, )
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
, )
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
Commit message missing but indeed there's not much to say
Reviewed-by: Manos Pitsidianakis
opagate(errp, local_err);
}
static bool
--
Reviewed-by: Manos Pitsidianakis
hieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote:
In preparation of having HostMemoryBackendClass::alloc() handlers
return a boolean, have them use g_autofree.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
--
include/exec/memory.h | 4 +++-
Reviewed-by: Manos Pitsidianakis
, owner, name, size, );
-if (err) {
-error_propagate(errp, err);
+if (!memory_region_init_ram_nomigrate(mr, owner, name, size, errp)) {
return;
}
/* This will assert if owner is neither NULL nor a DeviceState.
--
2.41.0
Reviewed-by: Manos Pitsidianakis
On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote:
Following the example documented since commit e3fe3988d7 ("error:
Document Error API usage rules"), have cpu_exec_realizefn()
return a boolean indicating whether an error is set or not.
Signed-off-by: Philippe Mathieu-Daudé
---
,9 @@ void memory_region_init_ram_flags_nomigrate(MemoryRegion
*mr,
mr->size = int128_zero();
object_unparent(OBJECT(mr));
error_propagate(errp, err);
+return false;
}
+return true;
}
void memory_region_init_resizeable_ram(MemoryRegion *mr,
--
2.41.0
Revie
;
+return memory_region_init_ram_flags_nomigrate(mr, owner, name,
+ size, 0, errp);
}
bool memory_region_init_ram_flags_nomigrate(MemoryRegion *mr,
--
2.41.0
Reviewed-by: Manos Pitsidianakis
, in that scenario pixman calculates a
new stride value based on given width, height and format size.
This commit adds a helper function that performs the same logic as
pixman.
Signed-off-by: Manos Pitsidianakis
---
include/ui/pixman-minimal.h | 48 +++--
1 file changed, 46
the same property.
To resolve the error, remove the duplicate property from
vhost-user-input-pci.
Signed-off-by: Leo Yan
---
Reviewed-by: Manos Pitsidianakis
.
Signed-off-by: Leo Yan
Reviewed-by: Manos Pitsidianakis
On Thu, 16 Nov 2023 10:54, Philippe Mathieu-Daudé wrote:
On 16/11/23 09:48, Manos Pitsidianakis wrote:
On Thu, 16 Nov 2023 10:42, Philippe Mathieu-Daudé
wrote:
On 16/11/23 08:33, Manos Pitsidianakis wrote:
On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé
wrote:
---
Notes:
Requires
On Thu, 16 Nov 2023 10:42, Philippe Mathieu-Daudé wrote:
On 16/11/23 08:33, Manos Pitsidianakis wrote:
On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé
wrote:
---
Notes:
Requires patch
<20231109162034.2108018-1-manos.pitsidiana...@linaro.org>
This is the 'Based-on: ' tag I
On Wed, 15 Nov 2023 22:27, Volker Rümelin wrote:
Cc: qemu-devel
Hi Manos,
it's easy to trigger a segmentation fault with the virtio-sound device.
The basic problem is that in function virtio_snd_realize() there is no
code in the errror paths to undo the previous steps.
Thank you for the
On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé wrote:
---
Notes:
Requires patch <20231109162034.2108018-1-manos.pitsidiana...@linaro.org>
This is the 'Based-on: ' tag I guess.
There is
prerequisite-patch-id: 484ec9f7f6109c10d4be0484fe8e3c2550c415f4
At the end of the patch, added
resources made in steps
1-3.
Reported-by: Volker Rümelin
Fixes: 2880e676c000 ("Add virtio-sound device stub")
Signed-off-by: Manos Pitsidianakis
---
Notes:
Requires patch <20231109162034.2108018-1-manos.pitsidiana...@linaro.org>
hw/audio/v
Hello Leo,
On Mon, 13 Nov 2023 03:16, Leo Yan wrote:
vhost-user-input is in the input folder. On the other hand, the folder
'hw/virtio' maintains other virtio stubs (e.g. I2C, RNG, GPIO, etc).
This patch moves vhost-user-input into the virtio folder for better code
organization. No
On Fri, 10 Nov 2023 13:23, "Daniel P. Berrangé" wrote:
On Fri, Nov 10, 2023 at 11:18:39AM +, Peter Maydell wrote:
On Fri, 10 Nov 2023 at 11:02, Manos Pitsidianakis
wrote:
>
> On Fri, 10 Nov 2023 12:21, Peter Maydell wrote:
> >This kind of thing is why Coverity's unu
On Fri, 10 Nov 2023 13:20, "Daniel P. Berrangé" wrote:
Your approach to the problem:
if (!AUD_register_card("OMAP EAC", >codec.card, _fatal)) {
exit(1);
}
is adding dead-code because the exit(1) will never be reachable. So while
it lets you squelch the unused result warning, it is
On Fri, 10 Nov 2023 12:21, Peter Maydell wrote:
This kind of thing is why Coverity's unused-result warning has a
lot of false positives. We shouldn't introduce extra code like
this to work around the fact that the tooling doesn't understand
our error-handling convention (i.e. error_fatal, and
On Fri, 10 Nov 2023 01:23, "Michael S. Tsirkin" wrote:
On Thu, Nov 09, 2023 at 06:03:15PM +, Peter Maydell wrote:
On Thu, 9 Nov 2023 at 17:53, Michael S. Tsirkin wrote:
>
> On Thu, Nov 09, 2023 at 04:25:04PM +, Peter Maydell wrote:
> > On Thu, 9 Nov 2023 at 16:2
This commit adds QEMU_WARN_UNUSED_RESULT, a macro for the gcc function
attribute `warn_unused_result`. The utility of this attribute is to
ensure functions that return values that need to be inspected are not
ignored by the caller.
Signed-off-by: Manos Pitsidianakis
---
include/qemu/compiler.h
Ignoring the return value by accident is easy to miss as a bug. Such a
bug was spotted by Coverity CID 1523899. Now, future instances of this
type of bug will produce a warning when using GCC.
Signed-off-by: Manos Pitsidianakis
---
audio/audio.h | 2 +-
hw/arm/omap2.c | 8 +++-
hw
g/qemu-devel/20231109162034.2108018-1-manos.pitsidiana...@linaro.org/
Manos Pitsidianakis (2):
Add QEMU_WARN_UNUSED_RESULT attribute
Add warn_unused_result attr to AUD_register_card
audio/audio.h | 2 +-
hw/arm/omap2.c | 8 +++-
hw/input/tsc210x.c | 8 +++-
i
AUD_register_card might fail. Even though errp was passed as an
argument, the call's return value was not checked for failure.
Signed-off-by: Manos Pitsidianakis
---
hw/audio/virtio-snd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/audio/virtio-snd.c b/hw/audio
Hello Peter,
If you want me to, I can roll a new version, otherwise I have attached
an updated version of just this patch, adding an if check.
Thanks,
Manos
v14-0001-Add-virtio-sound-device-stub.patch
Description: Binary data
Subsystem: Red Hat, Inc. Device [1af4:1100]
>
> Signed-off-by: Volker Rümelin
> ---
Reviewed-by: Manos Pitsidianakis
On Tue, 7 Nov 2023 at 02:44, Michael S. Tsirkin wrote:
>
> On Mon, Oct 23, 2023 at 03:03:17PM +0300, Manos Pitsidianakis wrote:
> > This patch series adds an audio device implementing the recent virtio
> > sound spec (1.2) and a corresponding PCI wrapper device.
>
>
&
On Fri, 27 Oct 2023 09:08, Thomas Huth wrote:
Add virtio-gpu.rst to the corresponding section in MAINTAINERS, so that
the maintainers gets CC:-ed on corresponding patches.
Signed-off-by: Thomas Huth
---
Reviewed-by: Manos Pitsidianakis
recording stops in QEMU's audio backend, the buffer is
returned to the guest by notifying it.
Signed-off-by: Manos Pitsidianakis
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
---
hw/audio/trace-events | 3 +-
hw/audio/virtio-snd.c | 262 --
2 files changed
Respond to the VIRTIO_SND_R_PCM_INFO control request with the parameters
of each requested PCM stream.
Based-on:
https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471
Signed-off-by: Igor Skalkin
Signed-off-by: Anton Yakovlev
Signed-off-by: Manos Pitsidianakis
-by: Anton Yakovlev
Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
---
hw/audio/trace-events | 1 +
hw/audio/virtio-snd.c | 48 ++-
2 files changed, 48 insertions(+), 1 deletion(-)
diff --git a/hw/audio/trace-events b/hw
/5a2f350eec5d157b90d9c7b40a8e603f4da92471
Signed-off-by: Igor Skalkin
Signed-off-by: Anton Yakovlev
Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
---
hw/audio/trace-events | 1 +
hw/audio/virtio-snd.c | 49 +--
2 files changed, 48 insertions(+), 2
-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
---
hw/audio/trace-events | 2 +
hw/audio/virtio-snd.c | 288 +-
include/hw/audio/virtio-snd.h | 47 ++
3 files changed, 332 insertions(+), 5 deletions(-)
diff --git
Handles the PCM prepare control request. It initializes a PCM stream
when the guests asks for it.
Based-on:
https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471
Signed-off-by: Igor Skalkin
Signed-off-by: Anton Yakovlev
Signed-off-by: Manos Pitsidianakis
Reviewed
This commit adds basic documentation for using virtio-snd.
Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
---
MAINTAINERS| 1 +
docs/system/device-emulation.rst | 1 +
docs/system/devices/virtio-snd.rst | 49
Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
---
hw/audio/trace-events | 1 +
hw/audio/virtio-snd.c | 34 ++
2 files changed, 35 insertions(+)
diff --git a/hw/audio/trace-events b/hw/audio/trace-events
index db48ff04fe
virtio_snd_process_cmdq() to handle each message.
The handler is process_cmd() which replies with VIRTIO_SND_S_NOT_SUPP.
Based-on:
https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471
Signed-off-by: Igor Skalkin
Signed-off-by: Anton Yakovlev
Signed-off-by: Manos Pitsidianakis
rnel.org/qemu-devel/cover.1686238728.git.manos.pitsidiana...@linaro.org/
[^v1]:
https://lore.kernel.org/qemu-devel/20230526204845.673031-1-manos.pitsidiana...@linaro.org/
Manos Pitsidianakis (11):
Add virtio-sound device stub
Add virtio-sound-pci device
virtio-sound: handle control message
+++ b/MAINTAINERS
@@ -2282,6 +2282,13 @@ F: hw/virtio/virtio-mem-pci.h
F: hw/virtio/virtio-mem-pci.c
F: include/hw/virtio/virtio-mem.h
+virtio-snd
+M: Gerd Hoffmann
+R: Manos Pitsidianakis
+S: Supported
+F: hw/audio/virtio-snd.c
+F: include/hw/audio/virtio-snd.h
+
nvme
M: Keith Busch
M
win):
-audio driver=coreaudio,model=virtio
etc.
Based-on:
https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471
Signed-off-by: Igor Skalkin
Signed-off-by: Anton Yakovlev
Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
---
MAINTAIN
201 - 300 of 659 matches
Mail list logo
