Re: CPR/liveupdate: test results using prior bug fix

2024-05-17 Thread Michael Galaxy
OK, acknowledged. Thanks, All. - Michael On 5/16/24 13:07, Steven Sistare wrote: On 5/16/2024 1:24 PM, Michael Galaxy wrote: On 5/14/24 08:54, Michael Tokarev wrote: On 5/14/24 16:39, Michael Galaxy wrote: Steve, OK, so it does not look like this bugfix you wrote was included in 8.2.4

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-16 Thread Michael Galaxy
These are very compelling results, no? (40gbps cards, right? Are the cards active/active? or active/standby?) - Michael On 5/14/24 10:19, Yu Zhang wrote: Hello Peter and all, I did a comparison of the VM live-migration speeds between RDMA and TCP/IP on our servers and plotted the results to

Re: CPR/liveupdate: test results using prior bug fix

2024-05-16 Thread Michael Galaxy
On 5/14/24 08:54, Michael Tokarev wrote: On 5/14/24 16:39, Michael Galaxy wrote: Steve, OK, so it does not look like this bugfix you wrote was included in 8.2.4 (which was released yesterday). Unfortunately, that means that anyone using CPR in that release will still (eventually) encounter

Re: CPR/liveupdate: test results using prior bug fix

2024-05-14 Thread Michael Galaxy
, the relevant commits for a possible 8.2.5 ? - Michael On 5/13/24 20:15, Michael Galaxy wrote: Hi Steve, Thanks for the response. It looks like literally *just today* 8.2.4 was released. I'll go check it out. - Michael On 5/13/24 15:10, Steven Sistare wrote: Hi Michael,   No surprise

Re: CPR/liveupdate: test results using prior bug fix

2024-05-13 Thread Michael Galaxy
.  They are all symptoms of "the possibility of ram and device state being out of sync" as mentioned in the commit. I am not familiar with the process for maintaining old releases for qemu. Perhaps someone on this list can comment on 8.2.3. - Steve On 5/13/2024 2:22 PM, Michael Galaxy wrote: Hi

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-13 Thread Michael Galaxy
: On Tue, May 07, 2024 at 01:50:43AM +, Gonglei (Arei) wrote: Hello, -Original Message- From: Peter Xu [mailto:pet...@redhat.com] Sent: Monday, May 6, 2024 11:18 PM To: Gonglei (Arei) Cc: Daniel P. Berrangé ; Markus Armbruster ; Michael Galaxy ; Yu Zhang ; Zhijian Li (Fujitsu) ; Jinpu Wang

CPR/liveupdate: test results using prior bug fix

2024-05-13 Thread Michael Galaxy
Hi Steve, We found that this specific change in particular ("migration: stop vm for cpr") fixes a bug that we've identified in testing back-to-back live updates in a lab environment. More specifically, *without* this change (which is not available in 8.2.2, but *is* available in 9.0.0)

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-02 Thread Michael Galaxy
Yu Zhang / Jinpu, Any possibility (at your lesiure, and within the disclosure rules of your company, IONOS) if you could share any of your performance information to educate the group? NICs have indeed changed, but not everybody has 100ge mellanox cards at their disposal. Some people don't.

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-04-29 Thread Michael Galaxy
Reviewed-by: Michael Galaxy Thanks Yu Zhang and Peter. - Michael On 4/29/24 15:45, Yu Zhang wrote: Hello Michael and Peter, We are very glad at your quick and kind reply about our plan to take over the maintenance of your code. The message is for presenting our plan and working together

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-04-29 Thread Michael Galaxy
Hi All (and Peter), My name is Michael Galaxy (formerly Hines). Yes, I changed my last name (highly irregular for a male) and yes, that's my real last name: https://www.linkedin.com/in/mrgalaxy/) I'm the original author of the RDMA implementation. I've been discussing with Yu Zhang

Re: [PATCH V3] migration: simplify notifiers

2023-07-13 Thread Michael Galaxy
the global notifier list in a new function migration_call_notifiers, and make it externally visible so future live update code can call it. Tested-by: Michael Galaxy Reviewed-by: Michael Galaxy No functional change. Signed-off-by: Steve Sistare --- hw/net/virtio-net.c | 6 +++--- hw

Re: [PATCH V4 0/2] migration file URI

2023-07-13 Thread Michael Galaxy
Tested-by: Michael Galaxy Reviewed-by: Michael Galaxy On 6/30/23 09:25, Steve Sistare wrote: Add the migration URI "file:filename[,offset=offset]". Fabiano Rosas has submitted the unit tests in the series migration: Test the new "file:" migration Steve Sistare (2):

Re: [PATCH V4] migration: simplify blockers

2023-07-13 Thread Michael Galaxy
for multiple modes. No functional change. Tested-by: Michael Galaxy Reviewed-by: Michael Galaxy Signed-off-by: Steve Sistare --- backends/tpm/tpm_emulator.c | 10 ++ block/parallels.c| 6 ++ block/qcow.c | 6 ++ block/vdi.c | 6

Re: [PATCH V9 00/46] Live Update

2023-07-13 Thread Michael Galaxy
 Good morning, On 7/10/23 10:10, Steven Sistare wrote: On 6/12/2023 10:59 AM, Michael Galaxy wrote: Hi Steve, On 6/7/23 12:37, Steven Sistare wrote: On 6/7/2023 11:55 AM, Michael Galaxy wrote: Another option could be to expose "-migrate-mode-disable" (instead of enable) and just

Re: [PATCH V9 00/46] Live Update

2023-06-12 Thread Michael Galaxy
Hi Steve, On 6/7/23 12:37, Steven Sistare wrote: On 6/7/2023 11:55 AM, Michael Galaxy wrote: Another option could be to expose "-migrate-mode-disable" (instead of enable) and just enable all 3 modes by default, since we are already required to switch from "normal" mo

Re: [PATCH V9 00/46] Live Update

2023-06-07 Thread Michael Galaxy
serve the capability to completely prevent a running QEMU from using these modes before the VM starts up. - Michael On 6/6/23 17:15, Michael Galaxy wrote: Hi Steve, In the current design you have, we have to specify both the command line parameter "-migrate-mode-enable cpr-reboot" *

Re: [PATCH V9 00/46] Live Update

2023-06-06 Thread Michael Galaxy
Hi Steve, In the current design you have, we have to specify both the command line parameter "-migrate-mode-enable cpr-reboot" *and* issue the monitor command "migrate_set_parameter mode cpr-${mode}". Is it possible to opt-in to the CPR mode just once over the monitor instead of having to

Re: [PATCH V9 00/46] Live Update

2023-04-14 Thread Michael Galaxy
questions and we were able to fix those issues. We will continue our testing throughout the year with more heavily-loaded workloads, but all in all we would very much be interested in seeing further reviews on this patch series from others. * *--- Tested-by: Michael Galaxy On 12/7/22 09:

Re: [PATCH V9 00/46] Live Update

2023-04-07 Thread Michael Galaxy
Hey Steven, Have you done any "back-to-back" live update testing before? I am still doing extensive testing on this myself. I am running into a bug that I have not yet diagnosed. It involves the following: 1. Perform a live update (I'm using kexec + PMEM-based live updates). => VM comes