[Stable-7.2.12 18/19] target/i386: disable jmp_opt if EFLAGS.RF is 1

2024-05-27 Thread Michael Tokarev
8225bff7c5db504f50e54ef66b079854635dba70) Signed-off-by: Michael Tokarev diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 20be036e1c..f8578ad1ea 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -6946,7 +6946,7 @@ static void i386_tr_init_disas_context

[Stable-7.2.12 07/19] tests/avocado: update sunxi kernel from armbian to 6.6.16

2024-05-27 Thread Michael Tokarev
-peter.mayd...@linaro.org (cherry picked from commit dcc5c018c7e6acddf81951bcbdf1019b9ab45f56) Signed-off-by: Michael Tokarev (Mjt: drop changes for tests which does not exists in 7.2) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py index ec07c64291..b54693869b 100644

[Stable-7.2.12 19/19] target/i386: no single-step exception after MOV or POP SS

2024-05-27 Thread Michael Tokarev
icked from commit f0f0136abba688a6516647a79cc91e03fad6d5d7) Signed-off-by: Michael Tokarev (Mjt: context fixup for v8.1.0-1189-gad75a51e84af "tcg: Rename cpu_env to tcg_env") diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index f8578ad1ea..0d47b61603 100644 -

[Stable-7.2.12 15/19] ui/gtk: Fix mouse/motion event scaling issue with GTK display backend

2024-05-27 Thread Michael Tokarev
off-by: hikalium Acked-by: Marc-André Lureau Message-Id: <20240512111435.30121-3-hikal...@hikalium.com> (cherry picked from commit 37e91415018db3656b46cdea8f9e4d47b3ff130d) Signed-off-by: Michael Tokarev diff --git a/ui/gtk.c b/ui/gtk.c index 283c41a1a1..8d740fae83 100644 --- a/ui/gtk.c ++

[Stable-7.2.12 08/19] .gitlab-ci.d/cirrus.yml: Shorten the runtime of the macOS and FreeBSD jobs

2024-05-27 Thread Michael Tokarev
), or since there is still a similar target with the opposite endianness (like xtensa/xtensael, microblaze/microblazeel etc.). Message-ID: <20240429100113.53357-1-th...@redhat.com> Signed-off-by: Thomas Huth (cherry picked from commit a88a04906b966ffdcda23a5a456abe10aa8c826e) Signed-off-by: M

[Stable-7.2.12 00/19] Patch Round-up for stable 7.2.12, freeze on 2024-06-07

2024-05-27 Thread Michael Tokarev
: gitlab-ci: Remove job building EDK2 firmware binaries 02 7bc1286b81d4 Palmer Dabbelt: gitlab/opensbi: Move to docker:stable 03 04f6fb897a5a Michael Tokarev: linux-user: do_setsockopt: fix SOL_ALG.ALG_SET_KEY 04 ae6d91a7e9b7 Zhu Yangyang: nbd/server: do not poll within a coroutine context 05

[Stable-7.2.12 04/19] nbd/server: do not poll within a coroutine context

2024-05-27 Thread Michael Tokarev
1200629-5-ebl...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy (cherry picked from commit ae6d91a7e9b77abb029ed3fa9fad461422286942) Signed-off-by: Michael Tokarev diff --git a/nbd/client.c b/nbd/client.c index 30d5383cb1..15503d0928 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -596,13 +

[Stable-7.2.12 01/19] gitlab-ci: Remove job building EDK2 firmware binaries

2024-05-27 Thread Michael Tokarev
e this job to avoid wasting maintenance and CI ressources. Reported-by: Palmer Dabbelt Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20230310133247.39268-1-phi...@linaro.org> Signed-off-by: Thomas Huth (cherry picked from commit 690ceb71936f9037f6e11580709e26b62d83c17c) Signed-off-by:

[Stable-7.2.12 02/19] gitlab/opensbi: Move to docker:stable

2024-05-27 Thread Michael Tokarev
commit 7bc1286b81d4e8380b3083beed1771c67ce87af3) Signed-off-by: Michael Tokarev diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml index 04ed5a3ea1..9a651465d8 100644 --- a/.gitlab-ci.d/opensbi.yml +++ b/.gitlab-ci.d/opensbi.yml @@ -42,9 +42,9 @@ docker-opensbi: extends: .opensbi_job_rules stage: containers -

[Stable-7.2.12 11/19] target/i386: Give IRQs a chance when resetting HF_INHIBIT_IRQ_MASK

2024-05-27 Thread Michael Tokarev
Signed-off-by: Ruihan Li Message-ID: <20240415064518.4951-4-lrh2...@pku.edu.cn> Signed-off-by: Paolo Bonzini (cherry picked from commit 6a5a63f74ba5c5355b7a8468d3d814bfffe928fb) Signed-off-by: Michael Tokarev (Mjt: context fixup due to missing-in-7.2 v8.1.0-1189-gad75a51e84 "tcg: Ren

Re: [PULL 10/10] hw/loongarch/virt: Fix FDT memory node address width

2024-05-24 Thread Michael Tokarev
23.05.2024 04:46, Song Gao wrote: From: Jiaxun Yang Higher bits for memory nodes were omitted at qemu_fdt_setprop_cells. Cc: qemu-sta...@nongnu.org Signed-off-by: Jiaxun Yang Reviewed-by: Song Gao Message-Id: <20240520-loongarch-fdt-memnode-v1-1-5ea9be939...@flygoat.com> Signed-off-by: Song

Re: [PULL 01/10] target/loongarch/kvm: Fix VM recovery from disk failures

2024-05-24 Thread Michael Tokarev
23.05.2024 04:46, Song Gao wrote: vmstate does not save kvm_state_conter, which can cause VM recovery from disk to fail. Cc: qemu-sta...@nongnu.org Signed-off-by: Song Gao Acked-by: Peter Xu Message-Id: <20240508024732.3127792-1-gaos...@loongson.cn> --- target/loongarch/machine.c | 6 --

Re: [PATCH v3 1/3] qemu-keymap: Free xkb allocations

2024-05-22 Thread Michael Tokarev
22.05.2024 14:35, Peter Maydell wrote: ... This is surely a sanitizer bug. We're unconditionally about to exit() the program here, where everything is freed, so nothing is leaked. https://lists.nongnu.org/archive/html/qemu-devel/2024-05/msg00658.html fwiw. /mjt -- GPG Key transition (from

Re: [PATCH] hw/loongarch/virt: Fix FDT memory node address width

2024-05-21 Thread Michael Tokarev
21.05.2024 00:06, Jiaxun Yang wrpte: Higher bits for memory nodes were omitted at qemu_fdt_setprop_cells. Signed-off-by: Jiaxun Yang --- This should be stable backported, otherwise DT boot is totally broken. Please add Cc: qemu-stable@ for changes which needs to be back-ported. I don't read

Re: [PATCH v2 3/3] migration/colo: Tidy up bql_unlock() around bdrv_activate_all()

2024-05-16 Thread Michael Tokarev
16.05.2024 06:45, Li Zhijian wrote: Make the code more tight. Suggested-by: Michael Tokarev Reviewed-by: Peter Xu Reviewed-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Michael Tokarev /mjt --- V2: Collected reviewed-by tags This change/comment suggested by "Michael To

Re: [PULL 00/11] Ui patches

2024-05-15 Thread Michael Tokarev
14.05.2024 16:17, marcandre.lur...@redhat.com wrote: UI: small fixes and improvements Bernhard Beschow (1): ui/sdl2: Allow host to power down screen Dongwon Kim

Re: CPR/liveupdate: test results using prior bug fix

2024-05-14 Thread Michael Tokarev
14.05.2024 16:54, Michael Tokarev пишет: On 5/14/24 16:39, Michael Galaxy wrote: Steve, OK, so it does not look like this bugfix you wrote was included in 8.2.4 (which was released yesterday). Unfortunately, that means that anyone using CPR in that release will still (eventually) encounter

Re: CPR/liveupdate: test results using prior bug fix

2024-05-14 Thread Michael Tokarev
On 5/14/24 16:39, Michael Galaxy wrote: Steve, OK, so it does not look like this bugfix you wrote was included in 8.2.4 (which was released yesterday). Unfortunately, that means that anyone using CPR in that release will still (eventually) encounter the bug like I did. 8.2.4 is basically a

[ANNOUNCE] QEMU 8.2.4 Stable released

2024-05-13 Thread Michael Tokarev
and helped with the stable series! /mjt Changelog (stable-8.2-hash master-hash Author Name: Commmit-Subject): 1332b8dd43 Michael Tokarev: Update version for 8.2.4 release 07d46408cb e88a856efd Philippe Mathieu-Daudé: target/sh4: Fix SUBV opcode dc5390a0ca c365e6b070 Philippe Mathieu-Daudé: target

Re: [Stable-8.2.4 00/16] Patch Round-up for stable 8.2.4 (planned for 2024-05-10)

2024-05-10 Thread Michael Tokarev
07.05.2024 11:45, Michael Tokarev wrote: 07.05.2024 11:41, Michael Tokarev wrote: The following patches are queued for QEMU stable v8.2.4:    https://gitlab.com/qemu-project/qemu/-/commits/staging-8.2 The release is planned for 2024-05-12, to address a few issues encountered with v8.2.3

Re: [PULL 05/26] hw/remote/vfio-user: Fix config space access byte order

2024-05-10 Thread Michael Tokarev
08.05.2024 20:44, Philippe Mathieu-Daudé wrote: From: Mattias Nissler PCI config space is little-endian, so on a big-endian host we need to perform byte swaps for values as they are passed to and received from the generic PCI config space access machinery. Is this a material for stable?

Re: [PATCH v3] target/i386: Fix CPUID encoding of Fn8000001E_ECX

2024-05-10 Thread Michael Tokarev
09.05.2024 17:11, Daniel P. Berrangé wrote: On Thu, May 09, 2024 at 04:54:16PM +0300, Michael Tokarev wrote: 03.05.2024 20:46, Babu Moger wrote: diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 08c7de416f..46235466d7 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -81,6 +81,7

Re: [PATCH v3] target/i386: Fix CPUID encoding of Fn8000001E_ECX

2024-05-09 Thread Michael Tokarev
03.05.2024 20:46, Babu Moger wrote: Observed the following failure while booting the SEV-SNP guest and the guest fails to boot with the smp parameters: "-smp 192,sockets=1,dies=12,cores=8,threads=2". qemu-system-x86_64: sev_snp_launch_update: SNP_LAUNCH_UPDATE ret=-5 fw_error=22 'Invalid

Re: [PATCH v8] virtio-pci: fix use of a released vector

2024-05-08 Thread Michael Tokarev
09.05.2024 04:43, Cindy Lu wrote: https://gitlab.com/qemu-project/qemu/-/issues/2321 https://gitlab.com/qemu-project/qemu/-/issues/2334 So something's not right here. I have checked the stack, seems there is a crash while set the vector to NO_VECTOER? #0 kvm_virtio_pci_vq_vector_release

Re: [PATCH v8] virtio-pci: fix use of a released vector

2024-05-08 Thread Michael Tokarev
15.04.2024 12:34, Michael S. Tsirkin wrote: From: Cindy Lu During the booting process of the non-standard image, the behavior of the called function in qemu is as follows: 1. vhost_net_stop() was triggered by guest image. This will call the function virtio_pci_set_guest_notifiers() with

Re: [PATCH] hw/loongarch/virt: Fix memory leak

2024-05-07 Thread Michael Tokarev
07.05.2024 05:22, Song Gao wrote: for (i = 1; i < nb_numa_nodes; i++) { MemoryRegion *nodemem = g_new(MemoryRegion, 1); -ramName = g_strdup_printf("loongarch.node%d.ram", i); +g_autofree char *ramName = g_strdup_printf("loongarch.node%d.ram", i); Can't this be

Re: [Stable-8.2.4 00/16] Patch Round-up for stable 8.2.4 (planned for 2024-05-10)

2024-05-07 Thread Michael Tokarev
07.05.2024 11:41, Michael Tokarev wrote: The following patches are queued for QEMU stable v8.2.4: https://gitlab.com/qemu-project/qemu/-/commits/staging-8.2 The release is planned for 2024-05-12, to address a few issues encountered with v8.2.3 release, - a bit wrong tarball with some

[Stable-8.2.4 14/16] hw/arm/npcm7xx: Store derivative OTP fuse key in little endian

2024-05-07 Thread Michael Tokarev
g Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell (cherry picked from commit eb656a60fd93262b1e519b3162888bf261df7f68) Signed-off-by: Michael Tokarev diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.c index 15ff21d047..8753812c37 100644 --- a/hw/arm/npcm7xx.c +++ b/hw/arm/npcm7xx.c @@ -

[Stable-8.2.4 04/16] migration/colo: Fix bdrv_graph_rdlock_main_loop: Assertion `!qemu_in_coroutine()' failed.

2024-05-07 Thread Michael Tokarev
rnel.org/r/20240417025634.1014582-1-lizhij...@fujitsu.com Signed-off-by: Peter Xu (cherry picked from commit 2cc637f1ea08d2a1b19fc5b1a30bc609f948de93) Signed-off-by: Michael Tokarev (Mjt: fixup bql_lock() => qemu_mutex_lock_iothread() for v8.2.0-444-g195801d700c0 "system/cpus: rename qemu_mutex_lock_ioth

[Stable-8.2.4 09/16] target/loongarch/cpu.c: typo fix: expection

2024-05-07 Thread Michael Tokarev
Fixes: 1590154ee437 ("target/loongarch: Fix qemu-system-loongarch64 assert failed with the option '-d int'") Fixes: ef9b43bb8e2d (in stable-8.2) Signed-off-by: Michael Tokarev Reviewed-by: Richard Henderson (cherry picked from commit 0cbb322f70e8a87e4acbffecef5ea8f9448f3513)

[Stable-8.2.4 13/16] hw/dmax/xlnx_dpdma: fix handling of address_extension descriptor fields

2024-05-07 Thread Michael Tokarev
d3c6369a96 ("introduce xlnx-dpdma") Signed-off-by: Alexandra Diupina Message-id: 20240428181131.23801-1-adiup...@astralinux.ru [PMM: adjusted commit message] Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell (cherry picked from commit 4b00855f0ee2e2eee8fd2500ffef27c108be6dc3) Signed-off

[Stable-8.2.4 12/16] hw/ufs: Fix buffer overflow bug

2024-05-07 Thread Michael Tokarev
ted-by: Zheyu Ma Signed-off-by: Jeuk Kim (cherry picked from commit f2c8aeb1afefcda92054c448b21fc59cdd99db30) Signed-off-by: Michael Tokarev diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c index eccdb852a0..bac78a32bb 100644 --- a/hw/ufs/ufs.c +++ b/hw/ufs/ufs.c @@ -126,6 +126,10 @@ st

[Stable-8.2.4 10/16] tests/avocado: update sunxi kernel from armbian to 6.6.16

2024-05-07 Thread Michael Tokarev
-peter.mayd...@linaro.org (cherry picked from commit dcc5c018c7e6acddf81951bcbdf1019b9ab45f56) Signed-off-by: Michael Tokarev diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py index 3f0180e1f8..b132b4f8f3 100644 --- a/tests/avocado/boot_linux_console.py +++ b/tests

[Stable-8.2.4 11/16] .gitlab-ci.d/cirrus.yml: Shorten the runtime of the macOS and FreeBSD jobs

2024-05-07 Thread Michael Tokarev
), or since there is still a similar target with the opposite endianness (like xtensa/xtensael, microblaze/microblazeel etc.). Message-ID: <20240429100113.53357-1-th...@redhat.com> Signed-off-by: Thomas Huth (cherry picked from commit a88a04906b966ffdcda23a5a456abe10aa8c826e) Signed-off-by: M

[Stable-8.2.4 01/16] target/riscv/kvm: change KVM_REG_RISCV_FP_F to u32

2024-05-07 Thread Michael Tokarev
ed-off-by: Alistair Francis (cherry picked from commit 49c211ffca00fdf7c0c29072c224e88527a14838) Signed-off-by: Michael Tokarev diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index c1675158fe..2eef2be86a 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -72,6

[Stable-8.2.4 06/16] nbd/server: do not poll within a coroutine context

2024-05-07 Thread Michael Tokarev
1200629-5-ebl...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy (cherry picked from commit ae6d91a7e9b77abb029ed3fa9fad461422286942) Signed-off-by: Michael Tokarev diff --git a/nbd/client.c b/nbd/client.c index 29ffc609a4..c89c750467 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -596,13 +

[Stable-8.2.4 07/16] nbd/server: Mark negotiation functions as coroutine_fn

2024-05-07 Thread Michael Tokarev
ed-off-by: Eric Blake (cherry picked from commit 4fa333e08dd96395a99ea8dd9e4c73a29dd23344) Signed-off-by: Michael Tokarev diff --git a/nbd/server.c b/nbd/server.c index 9fbac7d409..3d8ddfef06 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -195,8 +195,9 @@ static inline void set_be_option_rep(NBDOptio

[Stable-8.2.4 08/16] backends/cryptodev-builtin: Fix local_error leaks

2024-05-07 Thread Michael Tokarev
Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: zhenwei pi Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev (cherry picked from commit 06479dbf3d7d245572c4b3016e5a1d923ff04d66) Signed-off-by: Michael Tokarev diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-built

[Stable-8.2.4 15/16] target/sh4: Fix ADDV opcode

2024-05-07 Thread Michael Tokarev
0240430163125.77430-2-phi...@linaro.org> (cherry picked from commit c365e6b0705788866a65e7b8206bd4c5332595cd) Signed-off-by: Michael Tokarev diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 5aa10d3946..d8dcfc3a20 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@

[Stable-8.2.4 05/16] linux-user: do_setsockopt: fix SOL_ALG.ALG_SET_KEY

2024-05-07 Thread Michael Tokarev
linux-user: Add support for setsockopt() option SOL_ALG" Signed-off-by: Michael Tokarev Message-Id: <20240331100737.2724186-2-...@tls.msk.ru> Signed-off-by: Richard Henderson (cherry picked from commit 04f6fb897a5aeb3e356a7b889869c9962f9c16c7) Signed-off-by: Michael Tokarev diff --

[Stable-8.2.4 16/16] target/sh4: Fix SUBV opcode

2024-05-07 Thread Michael Tokarev
u/-/issues/2318 Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Message-Id: <20240430163125.77430-3-phi...@linaro.org> (cherry picked from commit e88a856efd1d3c3ffa8e53da4831eff8da290808) Signed-off-by: Michael Tokarev diff --git a/target/sh4/

[Stable-8.2.4 00/16] Patch Round-up for stable 8.2.4 (planned for 2024-05-12)

2024-05-07 Thread Michael Tokarev
to u64 03 10f86d1b8450 Daniel Henrique Barboza: target/riscv/kvm: change timer regs size to u64 04 2cc637f1ea08 Li Zhijian: migration/colo: Fix bdrv_graph_rdlock_main_loop: Assertion `!qemu_in_coroutine()' failed. 05 04f6fb897a5a Michael Tokarev: linux-user: do_setsockopt: fix

[Stable-8.2.4 03/16] target/riscv/kvm: change timer regs size to u64

2024-05-07 Thread Michael Tokarev
Henrique Barboza Reviewed-by: Andrew Jones Message-ID: <20231208183835.2411523-4-dbarb...@ventanamicro.com> Signed-off-by: Alistair Francis (cherry picked from commit 10f86d1b845087d14b58d65dd2a6e3411d1b6529) Signed-off-by: Michael Tokarev diff --git a/target/riscv/kvm/kvm-cpu.c b/target/ris

[Stable-8.2.4 02/16] target/riscv/kvm: change KVM_REG_RISCV_FP_D to u64

2024-05-07 Thread Michael Tokarev
-by: Andrew Jones Signed-off-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones Message-ID: <20231208183835.2411523-3-dbarb...@ventanamicro.com> Signed-off-by: Alistair Francis (cherry picked from commit 450bd6618fda3d2e2ab02b2fce1c79efd5b66084) Signed-off-by: Michael Tokarev diff --git a/

Re: [PULL 00/12] qemu-sparc queue 20240506

2024-05-06 Thread Michael Tokarev
06.05.2024 14:44, Mark Cave-Ayland wrote: Mark Cave-Ayland (1): hw/sparc64: set iommu_platform=on for virtio devices attached to the sun4u machine Richard Henderson (7): linux-user/sparc: Add more hwcap bits for sparc64 target/sparc: Fix FEXPAND target/sparc: Fix

Re: [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw]

2024-05-06 Thread Michael Tokarev
06.05.2024 15:38, Yoshinori Sato wrote: [...] Does this mean you changed it like this? I think this is fine. Yes, the main part is exactly like this, and there's no questions here. My question was more about was the testsuite changes which comes with the same patch, and parts of the Makefile

Re: [PATCH] qemu-keymap: Free xkb allocations

2024-05-05 Thread Michael Tokarev
01.05.2024 10:55, Akihiko Odaki wrote: This fixes LeakSanitizer complaints with xkbcommon 1.6.0. Signed-off-by: Akihiko Odaki --- qemu-keymap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qemu-keymap.c b/qemu-keymap.c index 8c80f7a4ed65..7a9f38cf9863 100644 --- a/qemu-keymap.c

Re: [PATCH] Fixes: Indentation using TABs and improve formatting

2024-05-04 Thread Michael Tokarev
04.05.2024 21:58, Tanmay wrote: Hi, I have attached a patch file that fixes indentation and formatting for some files as listed in https://gitlab.com/qemu-project/qemu/-/issues/373 . it is sort of good you posted this patch to stable@. It

Re: [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw]

2024-05-04 Thread Michael Tokarev
06.04.2024 08:37, Richard Henderson wrote: Zack's recent patches, tidied a little bit, and with test cases added. These fixes ended up in stable-8.2, but not in stable-7.2. This is because in 7.2, the context is a bit different. Later, a couple other fixes in this area come from Philippe (Fix

[PATCH v2] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)

2024-05-03 Thread Michael Tokarev
At the very least it is better to have sporadic CI failures here than no riscv64 coverage at all. Signed-off-by: Michael Tokarev --- v2: drop a TODO comment which turned out to be confused, replacing it with the description why debian riscv64 were unusable. .gitlab-ci.d/container-cross.yml

Re: [PATCH] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)

2024-05-02 Thread Michael Tokarev
02.05.2024 23:41, Richard Henderson wrote: On 5/2/24 13:08, Michael Tokarev wrote: This thing works now with sid/unstable, this is what this patch is about. It worked when first introduced, then failed, then worked... Sid is too unstable for our usage as a gating test. unstable can

Re: [PATCH] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)

2024-05-02 Thread Michael Tokarev
02.05.2024 23:05, Richard Henderson wrote: On 5/2/24 12:40, Michael Tokarev wrote: Revert "gitlab-ci: Disable the riscv64-debian-cross-container by default" This reverts commit f51f90c65ed7706c3c4f7a889ce3d6b7ab75ef6a. Hopefully it wont be very unstable. Since riscv64 is now

Re: [PATCH] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)

2024-05-02 Thread Michael Tokarev
https://gitlab.com/mjt0k/qemu/-/jobs/6768635797 fwiw. /mjt -- GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24. New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0 8044

[PATCH] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)

2024-05-02 Thread Michael Tokarev
sid. Also, debian-ports part of the archive isn't needed anymore. Signed-off-by: Michael Tokarev --- .gitlab-ci.d/container-cross.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab-ci.d/container-cross.yml b/.gitlab-ci.d/container-cross.yml index e3103940a0..dbffed3f21 100644 --- a/.g

[PULL v2 6/9] backends/cryptodev-builtin: Fix local_error leaks

2024-04-29 Thread Michael Tokarev
Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: zhenwei pi Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- backends/cryptodev-builtin.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c index

[PULL v2 0/9] Trivial patches for 2024-04-29

2024-04-29 Thread Michael Tokarev
pl: forbid strerrorname_np() Li Zhijian (1): backends/cryptodev-builtin: Fix local_error leaks Michael Tokarev (1): target/loongarch/cpu.c: typo fix: expection Philippe Mathieu-Daudé (2): scripts/checkpatch: Avoid author email mangled by qemu-*@nongnu.org scripts/checkpatch:

Re: [PULL 1/1] hw/ufs: Fix buffer overflow bug

2024-04-29 Thread Michael Tokarev
29.04.2024 06:25, Jeuk Kim wrote: From: Jeuk Kim It fixes the buffer overflow vulnerability in the ufs device. The bug was detected by sanitizers. ... Resolves: #2299 Fixes: 329f16624499 ("hw/ufs: Support for Query Transfer Requests") Reported-by: Zheyu Ma Signed-off-by: Jeuk Kim Cc:

[PULL 6/9] backends/cryptodev-builtin: Fix local_error leaks

2024-04-29 Thread Michael Tokarev
Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: zhenwei pi Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- backends/cryptodev-builtin.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-built

[PULL 4/9] scripts/checkpatch: Avoid author email mangled by qemu-*@nongnu.org

2024-04-29 Thread Michael Tokarev
y: Michael Tokarev Signed-off-by: Michael Tokarev --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 7026895074..12e9028b10 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1573,7 +157

[PULL 0/9] Trivial patches for 2024-04-29

2024-04-29 Thread Michael Tokarev
Daniel Henrique Barboza (2): target/riscv/kvm: remove sneaky strerrorname_np() instance checkpatch.pl: forbid strerrorname_np() Li Zhijian via (1): backends/cryptodev-builtin: Fix local_error leaks Michael Tokarev (1): target/loongarch/cpu.c: typo fix: expection Philippe

[PULL 2/9] target/s390x/cpu_models: Rework the output of "-cpu help"

2024-04-29 Thread Michael Tokarev
put already. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- target/s390x/cpu_models.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 8e

[PULL 9/9] checkpatch.pl: forbid strerrorname_np()

2024-04-29 Thread Michael Tokarev
-by: Daniel Henrique Barboza Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- scripts/checkpatch.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts

[PULL 5/9] scripts/checkpatch: Do not use mailmap

2024-04-29 Thread Michael Tokarev
From: Philippe Mathieu-Daudé The .mailmap file fixes mistake we already did. Do not use it when running checkpatch.pl, otherwise we might commit the very same mistakes. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael Tokarev Signed-off-by: Michael

[PULL 1/9] target/i386/cpu: Remove "x86" prefix from the CPU list

2024-04-29 Thread Michael Tokarev
e CPU entries. Let's simply remove this now and use two spaces at the beginning of the lines for the indentation of the entries instead, like most other target architectures are doing it for their CPU help output already. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Mic

[PULL 8/9] target/riscv/kvm: remove sneaky strerrorname_np() instance

2024-04-29 Thread Michael Tokarev
-reg-list) Signed-off-by: Daniel Henrique Barboza Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- target/riscv/kvm/kvm-cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PULL 3/9] target/ppc/cpu_init: Remove "PowerPC" prefix from the CPU list

2024-04-29 Thread Michael Tokarev
-off-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- target/ppc/cpu_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index 6d82f24c87..c11a69fd90 100644 ---

[PULL 7/9] target/loongarch/cpu.c: typo fix: expection

2024-04-29 Thread Michael Tokarev
Fixes: 1590154ee437 ("target/loongarch: Fix qemu-system-loongarch64 assert failed with the option '-d int'") Signed-off-by: Michael Tokarev Reviewed-by: Richard Henderson --- target/loongarch/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/loongar

Re: [PATCH v2] migration/colo: Fix bdrv_graph_rdlock_main_loop: Assertion `!qemu_in_coroutine()' failed.

2024-04-28 Thread Michael Tokarev
17.04.2024 05:56, Li Zhijian via wrote: --- a/migration/colo.c +++ b/migration/colo.c @@ -835,6 +835,16 @@ static void *colo_process_incoming_thread(void *opaque) return NULL; } +/* Make sure all file formats throw away their mutable metadata */ +bql_lock(); +

Re: [PATCH v2] migration/colo: Fix bdrv_graph_rdlock_main_loop: Assertion `!qemu_in_coroutine()' failed.

2024-04-28 Thread Michael Tokarev
17.04.2024 05:56, Li Zhijian via wrote: bdrv_activate_all() should not be called from the coroutine context, move it to the QEMU thread colo_process_incoming_thread() with the bql_lock protected. The backtrace is as follows: #4 0x561af7948362 in bdrv_graph_rdlock_main_loop () at

Re: [PATCH v2 1/1] target/riscv/kvm: fix timebase-frequency when using KVM acceleration

2024-04-27 Thread Michael Tokarev
27.04.2024 18:17, Andrew Jones : I wrote instructions [2] for how to cross-compile without a full environment/container once. It might be better for quick, local testing. [2] https://lore.kernel.org/qemu-riscv/20230726120706.335340-2-ajo...@ventanamicro.com/ I just extracted a few packages

Re: [PATCH v2 1/1] target/riscv/kvm: fix timebase-frequency when using KVM acceleration

2024-04-27 Thread Michael Tokarev
27.04.2024 09:59, Michael Tokarev wrote: 27.04.2024 09:23, Andrew Jones wrote: ... It's possible to cross-compile qemu, so it'd be good to add that to the CI for riscv until we can add native compiling. Yes, definitely.  Qemu is already being cross-compiled on all "other" arc

Re: [PATCH v2 1/1] target/riscv/kvm: fix timebase-frequency when using KVM acceleration

2024-04-27 Thread Michael Tokarev
27.04.2024 09:23, Andrew Jones wrote: On April 27, 2024 1:44:42 AM GMT+02:00, Michael Tokarev wrote: 14.03.2024 09:15, Yong-Xuan Wang: The timebase-frequency of guest OS should be the same with host machine. The timebase-frequency value in DTS should be got from hypervisor when using KVM

Re: [PATCH v2 1/1] target/riscv/kvm: fix timebase-frequency when using KVM acceleration

2024-04-26 Thread Michael Tokarev
14.03.2024 09:15, Yong-Xuan Wang: The timebase-frequency of guest OS should be the same with host machine. The timebase-frequency value in DTS should be got from hypervisor when using KVM acceleration. This change ended up in stable-8.2 (v8.2.3). Interestingly, this thing compiled not even

Re: [ANNOUNCE] QEMU 8.2.3 Stable released

2024-04-25 Thread Michael Tokarev
24.04.2024 20:39, Michael Tokarev wrote: Hi everyone, The QEMU v8.2.3 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-8.2.3.tar.xz https://download.qemu.org/qemu-8.2.3

Re: [PATCH v2 0/2] riscv,kvm: remove another strerrorname_np()

2024-04-24 Thread Michael Tokarev
24.04.2024 23:24, Daniel Henrique Barboza wrote: Hi, In this new version a small change suggested by Phil was made in patch 2. No other changes made. Applied to trivial-patches tree. Note: checkpatch.pl is nagging quite a bit about the checkpatch.pl change this time, claiming that I'm

[PATCH] target/loongarch/cpu.c: typo fix: expection

2024-04-24 Thread Michael Tokarev
Fixes: 1590154ee437 ("target/loongarch: Fix qemu-system-loongarch64 assert failed with the option '-d int'") Signed-off-by: Michael Tokarev --- target/loongarch/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/loongarch/cpu.c b/target/loongarch/c

[ANNOUNCE] QEMU 8.2.3 Stable released

2024-04-24 Thread Michael Tokarev
and helped with the stable series! /mjt Changelog (stable-8.2-hash master-hash Author Name: Commmit-Subject): 8216663a5c Michael Tokarev: Update version for 8.2.3 release 51da750063 c4f91d7b7b Harsh Prateek Bora: ppc/spapr: Initialize max_cpus limit to SPAPR_IRQ_NR_IPIS. c513ee1b91 2df5c1f5b0 Harsh

[ANNOUNCE] QEMU 7.2.11 Stable released

2024-04-24 Thread Michael Tokarev
and helped with the stable series! /mjt Changelog (stable-7.2-hash master-hash Author Name: Commmit-Subject): c6fe0f315c Michael Tokarev: Update version for 7.2.11 release ab4a60c1b7 c4f91d7b7b Harsh Prateek Bora: ppc/spapr: Initialize max_cpus limit to SPAPR_IRQ_NR_IPIS. 3f481e3305 2df5c1f5b0

Re: [PATCH] Fix incorrect disassembly format for certain RISC-V instructions

2024-04-24 Thread Michael Tokarev
03.04.2024 12:14, Simeon Krastnikov wrote: * The immediate argument to lui/auipc should be an integer in the interval [0x0, 0xf]; e.g., 'auipc 0xf' and not 'auipc -1' * The floating-point rounding mode is the last operand to the function, not the first; e.g., 'fcvt.w.s a0, fa0, rtz'

Re: [PATCH] backends/cryptodev-builtin: Fix local_error leaks

2024-04-24 Thread Michael Tokarev
22.04.2024 11:53, Li Zhijian via wrote: It seems that this error does not need to be propagated to the upper, directly output the error to avoid the leaks Closes: https://gitlab.com/qemu-project/qemu/-/issues/2283 Signed-off-by: Li Zhijian Applied to trivial-patches tree, with

[PATCH 25/27] qemu-img: implement short --help, remove global help() function

2024-04-24 Thread Michael Tokarev
() and unrecognized_option() are now unused, remove them. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 172 - 1 file changed, 39 insertions(+), 133 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 3721cf070b..39dfaa5144

[PATCH 23/27] qemu-img: dd: refresh options/--help

2024-04-24 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 7c20a5772d..b3e521bc09 100644 --- a/qemu-img.c +++ b/qemu-img.c

[PATCH 27/27] qemu-img: extend cvtnum() and use it in more places

2024-04-24 Thread Michael Tokarev
llowed size suffixes from the error message as it makes no sense most of the time (should be in help instead). Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 111 + tests/qemu-iotests/049.out | 9 +-- 2 files c

[PATCH 24/27] qemu-img: measure: refresh options/--help

2024-04-24 Thread Michael Tokarev
Add missing long options and --help output. Also add -s short option for --size (and remove OPTION_SIZE). Signed-off-by: Michael Tokarev --- qemu-img.c | 53 - 1 file changed, 40 insertions(+), 13 deletions(-) diff --git a/qemu-img.c b/qemu

[PATCH 26/27] qemu-img: inline list of supported commands, remove qemu-img-cmds.h include

2024-04-24 Thread Michael Tokarev
also add short description to each command and use it in --help Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 40 ++-- 1 file changed, 34 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 39dfaa5144

[PATCH 01/27] qemu-img: measure: convert img_size to signed, simplify handling

2024-04-24 Thread Michael Tokarev
qemu_opt_set_number() expects signed int64_t. Use int64_t instead of uint64_t for img_size, use -1 as "unset" value instead of UINT64_MAX, and do not require temporary sval for conversion from string. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-

[PATCH 17/27] qemu-img: rebase: refresh options/--help

2024-04-24 Thread Michael Tokarev
-off-by: Michael Tokarev --- qemu-img.c | 55 +- 1 file changed, 46 insertions(+), 9 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 62f9ce4069..47dfa137c1 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3793,26 +3793,61 @@ static int

[PATCH 12/27] qemu-img: info: refresh options/--help

2024-04-24 Thread Michael Tokarev
Add missing long options and --help output. Also add -b short option for --backing-chain, and remove now-unused OPTION_BACKING_CHAIN. While at it, remove unused option_index variable. Signed-off-by: Michael Tokarev --- qemu-img.c | 40 +++- 1 file changed

[PATCH 19/27] qemu-img: resize: refresh options/--help

2024-04-24 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index da10fafffc..688c01722c 100644 --- a/qemu-img.c +++ b/qemu-img.c

[PATCH 14/27] qemu-img: snapshot: allow specifying -f fmt

2024-04-24 Thread Michael Tokarev
For consistency with other commands, and since it already accepts --image-opts, allow specifying -f fmt too. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- docs/tools/qemu-img.rst | 2 +- qemu-img-cmds.hx| 4 ++-- qemu-img.c | 9 ++--- 3 files

[PATCH 21/27] qemu-img: bench: refresh options/--help

2024-04-24 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 64 +- 1 file changed, 54 insertions(+), 10 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 76000c485c..fff537df26 100644 --- a/qemu-img.c

[PATCH 13/27] qemu-img: map: refresh options/--help

2024-04-24 Thread Michael Tokarev
Add missing long options and --help output. While at it, remove unused option_index variable. Signed-off-by: Michael Tokarev --- qemu-img.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 34c4cd86de

[PATCH v3 00/27] qemu-img: refersh options and --help handling, cleanups

2024-04-24 Thread Michael Tokarev
couple cvtnum conversions - dropped "stop printing error twice in a few places" Michael Tokarev (27): qemu-img: measure: convert img_size to signed, simplify handling qemu-img: create: convert img_size to signed, simplify handling qemu-img: global option processing and error print

[PATCH 22/27] qemu-img: bitmap: refresh options/--help

2024-04-24 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index fff537df26..7c20a5772d 100644 --- a/qemu-img.c +++ b/qemu-img.c

[PATCH 18/27] qemu-img: resize: do not always eat last argument

2024-04-24 Thread Michael Tokarev
is when there's an option between filename and size, and size is given as decrement, - in this case -size will be treated as option, not as size. Signed-off-by: Michael Tokarev --- qemu-img.c | 41 +++-- 1 file changed, 27 insertions(+), 14 deletions(-) diff

[PATCH 20/27] qemu-img: amend: refresh options/--help

2024-04-24 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 688c01722c..76000c485c 100644 --- a/qemu-img.c +++ b/qemu-img.c

[PATCH 16/27] qemu-img: snapshot: refresh options/--help

2024-04-24 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 45 - 1 file changed, 36 insertions(+), 9 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 967f6343de..62f9ce4069 100644 --- a/qemu-img.c +++ b/qemu

[PATCH 07/27] qemu-img: check: refresh options/--help

2024-04-24 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 38 ++ 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 08536553c7..1bd88fcf63 100644 --- a/qemu-img.c +++ b/qemu-img.c

[PATCH 05/27] qemu-img: create: refresh options/--help

2024-04-24 Thread Michael Tokarev
Create helper function cmd_help() to display command-specific help text, and use it to print --help for 'create' subcommand. Add missing long options (eg --format) in img_create(). Remove usage of missing_argument()/unrecognized_option() in img_create(). Signed-off-by: Michael Tokarev

[PATCH 11/27] qemu-img: convert: refresh options/--help

2024-04-24 Thread Michael Tokarev
Add missing long options and --help output. convert uses -B for --backing, - why not -b? Signed-off-by: Michael Tokarev --- qemu-img.c | 90 -- 1 file changed, 81 insertions(+), 9 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index

<    1   2   3   4   5   6   7   8   9   10   >