> -Original Message-
> From: Kevin Wolf
> Sent: Friday, 13 January 2023 13:45
> To: Ilya Dryomov
> Cc: Or Ozeri ; qemu-devel@nongnu.org;
> dupad...@redhat.com; to.my.troc...@gmail.com; qemu-
> bl...@nongnu.org; Danny Harnik ; Stefan Hajnoczi
> ; Paolo Bonzini
v5: nit fixes
v4: split to multiple commits
add support for more than just luks-any in layered encryption
nit fixes
v3: further nit fixes suggested by @idryomov
v2: nit fixes suggested by @idryomov
Or Ozeri (3):
block/rbd: Remove redundant stack variable passphrase_len
block/rbd: Add
rbd driver API to enable qemu users to use
this luks-any wildcard format.
Signed-off-by: Or Ozeri
---
block/rbd.c | 19 +++
qapi/block-core.json | 20 ++--
2 files changed, 37 insertions(+), 2 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index
Signed-off-by: Or Ozeri
---
block/rbd.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 3aa6aae0e0..cfec0f2862 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -385,7 +385,6 @@ static int qemu_rbd_encryption_format(rbd_image_t
(via "spec" structs).
This commit extends the qemu rbd driver API to use this new librbd API,
in order to support this new layered encryption feature.
Signed-off-by: Or Ozeri
---
block/rbd.c | 154 ++-
qapi/block-core.json | 11 +++
> -Original Message-
> From: Daniel P. Berrangé
> Sent: Thursday, 12 January 2023 14:50
> To: Or Ozeri
> Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; Danny Harnik
> ; idryo...@gmail.com
> Subject: [EXTERNAL] Re: [PATCH v4 3/3] block/rbd: Add support for layere
rbd driver API to enable qemu users to use
this luks-any wildcard format.
Signed-off-by: Or Ozeri
---
block/rbd.c | 19 +++
qapi/block-core.json | 20 ++--
2 files changed, 37 insertions(+), 2 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index
Add const modifier to passphrases,
and remove redundant stack variable passphrase_len.
Signed-off-by: Or Ozeri
---
block/rbd.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index f826410f40..e575105e6d 100644
--- a/block
(via "spec" structs).
This commit extends the qemu rbd driver API to use this new librbd API,
in order to support this new layered encryption feature.
Signed-off-by: Or Ozeri
---
block/rbd.c | 161 ++-
qapi/block-core.json | 17
v4: split to multiple commits
add support for more than just luks-any in layered encryption
nit fixes
v3: further nit fixes suggested by @idryomov
v2: nit fixes suggested by @idryomov
Or Ozeri (3):
block/rbd: encryption nit fixes
block/rbd: Add luks-any encryption opening option
> -Original Message-
> From: Daniel P. Berrangé
> Sent: 16 November 2022 13:15
> To: Or Ozeri ; qemu-devel@nongnu.org; qemu-
> bl...@nongnu.org; Danny Harnik ;
> idryo...@gmail.com
> Subject: [EXTERNAL] Re: [PATCH v3] block/rbd: Add support for layered
> encryp
> -Original Message-
> From: Daniel P. Berrangé
> Sent: 15 November 2022 19:47
> To: Or Ozeri
> Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; Danny Harnik
> ; idryo...@gmail.com
> Subject: [EXTERNAL] Re: [PATCH v3] block/rbd: Add support for layered
>
I tried casting to non-const and it seems to work. Changed in v3 now.
I did not know that a const modifier could simply be cast out :)
> -Original Message-
> From: Ilya Dryomov
> Sent: 15 November 2022 14:00
> To: Or Ozeri
> Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.or
(via "spec" structs).
This commit extends the qemu rbd driver API to use this new librbd API,
in order to support this new layered encryption feature.
Signed-off-by: Or Ozeri
---
v3: further nit fixes suggested by @idryomov
v2: nit fixes suggested by @idryomov
---
block/rbd.c
(via "spec" structs).
This commit extends the qemu rbd driver API to use this new librbd API,
in order to support this new layered encryption feature.
Signed-off-by: Or Ozeri
---
v2: nit fixes suggested by @idryomov
---
block/rbd.c | 122 +++
> -Original Message-
> From: Ilya Dryomov
> Sent: 11 November 2022 15:01
> To: Or Ozeri
> Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; Danny Harnik
>
> Subject: [EXTERNAL] Re: [PATCH v1] block/rbd: Add support for layered
> encryption
>
&g
(via "spec" structs).
This commit extends the qemu rbd driver API to use this new librbd API,
in order to support this new layered encryption feature.
Signed-off-by: Or Ozeri
---
block/rbd.c | 134 ++-
qapi/block-core.json | 33 ++
The blk_get_max_hw_transfer API was recently added in 6.1.0.
It allows querying an underlying block device its max transfer capability.
This commit changes virtio-blk to use this.
Signed-off-by: Or Ozeri
---
hw/block/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
.
The solution that worked for me was to change the virtio-blk driver to use the
max_transfer
limit queried from the posix host device (given by blk_get_max_hw_transfer).
Or Ozeri (1):
virtio-block: switch to blk_get_max_hw_transfer
hw/block/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1
the change to the ImageInfo struct?-"Kevin Wolf" <kw...@redhat.com> wrote: -----To: "Or Ozeri" <o...@il.ibm.com>From: "Kevin Wolf" <kw...@redhat.com>Date: 07/07/2021 10:52AMCc: qemu-devel@nongnu.org, qemu-bl...@nongnu.org, to.my.troc...@gmail.co
When using the raw format, allow exposing specific info by the underlying
storage.
In particular, this will enable RBD images using the raw format to indicate
a LUKS2 encrypted image in the output of qemu-img info.
Signed-off-by: Or Ozeri
---
block/raw-format.c | 7 +++
1 file changed, 7
header)
rbd_encryption_load: loads encryptor/decryptor to the image IO stack
This commit extends the qemu rbd driver API to support the above.
Signed-off-by: Or Ozeri
---
v2: handle encryption info only for the case where encryption is not loaded
---
block/rbd.c | 361
Should I still leave the encryption format part of the state, and just not report it? or should I also remove it from the state?-"Ilya Dryomov" <idryo...@gmail.com> wrote: -----To: "Or Ozeri" <o...@il.ibm.com>From: "Ilya Dryomov" <idryo...@gma
that the right solution would be adding a qemu utility function (not sure where exactly), but anyways perhaps this, like the changes I previously made to raw_format.c, should be made in different patch.Thanks,Or-"Or Ozeri" <o...@il.ibm.com> wrote: -To: qemu-devel@nongnu.orgFro
header)
rbd_encryption_load: loads encryptor/decryptor to the image IO stack
This commit extends the qemu rbd driver API to support the above.
Signed-off-by: Or Ozeri
---
block/rbd.c | 380 ++-
qapi/block-core.json | 110 -
2 files
header)
rbd_encryption_load: loads encryptor/decryptor to the image IO stack
This commit extends the qemu rbd driver API to support the above.
Signed-off-by: Or Ozeri
---
block/rbd.c | 367 ++-
qapi/block-core.json | 110 -
2 files
header)
rbd_encryption_load: loads encryptor/decryptor to the image IO stack
This commit extends the qemu rbd driver API to support the above.
Signed-off-by: Or Ozeri
---
block/rbd.c | 367 ++-
qapi/block-core.json | 110 -
2 files
structs.Same goes for passphrase (or "key-secret", as it called in qemu). In cryptsetup this is sort-of optional (there are other ways to authenticate othar than a passphrase, like a keyfile or a token).-Ilya Dryomov <idryo...@gmail.com> wrote: -To: Or Ozeri <o...@il
header)
rbd_encryption_load: loads encryptor/decryptor to the image IO stack
This commit extends the qemu rbd driver API to support the above.
Signed-off-by: Or Ozeri
---
block/raw-format.c | 7 +
block/rbd.c | 371 ++-
qapi/block-core.json
header)
rbd_encryption_load: loads encryptor/decryptor to the image IO stack
This commit extends the qemu rbd driver API to support the above.
Signed-off-by: Or Ozeri
---
block/raw-format.c | 7 +
block/rbd.c | 371 ++-
qapi/block-core.json
t clear to me how can I set:bs->drv->format_name="luks2", bs->encrypted=trueOn the root BlockDriverState.Any advice?-"Daniel P. Berrangé" <berra...@redhat.com> wrote: -To: Or Ozeri <o...@il.ibm.com>From: "Daniel P. Berrangé" <berra...@redhat
header)
rbd_encryption_load: loads encryptor/decryptor to the image IO stack
This commit extends the qemu rbd driver API to support the above.
Signed-off-by: Or Ozeri
---
block/rbd.c | 230 ++-
qapi/block-core.json | 61
2 files
32 matches
Mail list logo
