[Qemu-devel] [Bug 1324724] Re: make install fails if running strip

2014-05-30 Thread Peter Chubb
The libexec case doesn't actually work, which is why IO switched to a separate variable. One of the reasons I said the patch is probably wrong. I suspect we need something like $(STRIP) $(addprefix $(DESTDIR)/$(BINDIR), $(notdir ${TOOLS))) And I didn't see the problem on x86_64, only on armhf.

[Qemu-devel] [Bug 1324724] [NEW] make install fails on arm host

2014-05-29 Thread Peter Chubb
Public bug reported: I do: ./configure --target-list=arm-softmmu make sudo make install and see: install -d -m 0755 /usr/local/bin libtool --quiet --mode=install install -c -m 0755 qemu-ga qemu-nbd qemu-img qemu-io fsdev/virtfs-proxy-helper /usr/local/bin strip /usr/local/bin/qemu-ga

[Qemu-devel] [Bug 1324727] [NEW] qemu-system-arm segfaults without KVM on ARM

2014-05-29 Thread Peter Chubb
Public bug reported: I'm running on Odroid-XU, Debian Jessie armhf qemu built from today's head d7d3d6092cb7edc75dc49fb90c86dd5425ab4805 sudo qemu-system-arm -M vexpress-a15 -drive if=none,file=arm.img,cache=writeback,id=foo -device virtio-blk-device,drive=foo -netdev user,id=user.0 -device

Re: [Qemu-devel] [Bug 1273944] Re: multiboot header has 0 in mem_upper field

2014-01-29 Thread Peter Chubb
Peter == Peter Chubb peter.ch...@nicta.com.au writes: This change fixes it. diff --git a/exec.c b/exec.c index 2435d9e..b387d28 100644 --- a/exec.c +++ b/exec.c @@ -1070,7 +1070,7 @@ static void *file_ram_alloc(RAMBlock *block, } /* MAP_POPULATE silently ignores

[Qemu-devel] [Bug 1273944] [NEW] multiboot header has 0 in mem_upper field

2014-01-28 Thread Peter Chubb
Public bug reported: When booting a multiboot image,. mem_upper is now always zero. To test, build qemu from current git head, then do cd tests/multiboot ./run_test.sh You will see the test fail. In each case mem_upper is 0k. git-bisect says the bad commit is

[Qemu-devel] [Bug 1273944] Re: multiboot header has 0 in mem_upper field

2014-01-28 Thread Peter Chubb
This change fixes it. diff --git a/exec.c b/exec.c index 2435d9e..b387d28 100644 --- a/exec.c +++ b/exec.c @@ -1070,7 +1070,7 @@ static void *file_ram_alloc(RAMBlock *block, } /* MAP_POPULATE silently ignores failures */ -for (i = 0; i (memory/hpagesize); i++) { +

Re: [Qemu-devel] [Patch] ARM: Add an L2 cache controller to KZM

2013-08-06 Thread Peter Chubb
OK, this is what I've come up with. Dunno whether it's right or not -- the object model is decoupled from the memory model, so there's no straightforward way to override just a few of the registers. At this stage this is just for comment, as I don't really have that much of a clue about how the

[Qemu-devel] [Patch] Fix typo in qom/object.h

2013-08-06 Thread peter . chubb
There's been a cut-and-paste error, it looks like, in the documentation in qom/object.h. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- include/qom/object.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: qemu/include/qom/object.h

Re: [Qemu-devel] [Patch] ARM: Add an L2 cache controller to KZM

2013-08-05 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 5 August 2013 02:21, Peter Chubb peter.ch...@nicta.com.au Peter wrote: Reads to unassigned memory now return non-zero (since patch 9b8c69243585). This breaks guests runnong on i.MX31 that use the cache controller --- they poll

Re: [Qemu-devel] [Patch] ARM: Add an L2 cache controller to KZM

2013-08-05 Thread Peter Chubb
NICTA Peter Chubb + * + * Based on the PL210 implementation in arm_l2x0.c + * Differences: different Cache ID and aux control register values. * * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU General Public License, @@ -20,46

[Qemu-devel] [Patch] ARM: Add an L2 cache controller to KZM

2013-08-04 Thread Peter Chubb
cache controller. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au diff --git a/hw/arm/kzm.c b/hw/arm/kzm.c index bd6c05c..018fc81 100644 --- a/hw/arm/kzm.c +++ b/hw/arm/kzm.c @@ -33,6 +33,7 @@ * 0x1fffc000-0x1fff RAM EMULATED * 0x2000-0x2fff Reserved

[Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-04 Thread Peter Chubb
When imx_epit.c was last refactored, a common usecase (comparison register zero) broke. This patch fixes that, and simplifies the code yet more. It also fixes a major thinko in the reset path --- the wrong bits in the control register were being cleared. Signed-off-by: Peter Chubb peter.ch

Re: [Qemu-devel] [PATCH qom-next for-1.6 07/15] imx_avic: QOM cast cleanup

2013-07-28 Thread Peter Chubb
Andreas == Andreas Färber afaer...@suse.de writes: Andreas Signed-off-by: Andreas Färber afaer...@suse.de --- Acked-by: Peter Chubb peter.ch...@nicta.com.au -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems

Re: [Qemu-devel] [PATCH qom-next for-1.6 06/14] imx_ccm: QOM cast cleanup

2013-07-28 Thread Peter Chubb
Andreas == Andreas Färber afaer...@suse.de writes: Andreas Signed-off-by: Andreas Färber afaer...@suse.de --- Acked-by: Peter Chubb peter.ch...@nicta.com.au -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems

Re: [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test

2013-06-09 Thread Peter Chubb
. Good catch. I hate hard coded constants, they're so easy to get wrong! Stefan Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Peter Chubb peter.ch...@nicta.com.au -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au

[Qemu-devel] [PATCH] [ARM] Fix rfe instruction

2013-05-30 Thread Peter Chubb
The rfe instruction has been broken since patch 5a839c0d54fac9db0516904db873a4fe01f50f4b because of a typo. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au diff --git a/target-arm/translate.c b/target-arm/translate.c index e5a2e4c..29e8f27 100644 --- a/target-arm/translate.c +++ b/target

Re: [Qemu-devel] [PATCH v2 2/2] i.MX: unify all function and variale name convention in GPT

2013-05-29 Thread Peter Chubb
-static char const *imx_timerg_reg_name(uint32_t reg) +static char const *imx_timer_gpt_reg_name(uint32_t reg) You could just use imc_gpt_xxx in line with the imx_epit_xxx naming from your other patch series. Otherwise this looks good. -- Dr Peter Chubb

Re: [Qemu-devel] [PATCH] i.MX: Improve EPIT timer code.

2013-05-27 Thread Peter Chubb
not that keen on the longer names, though. Maybe s/timer_epit/epit/ throughout. -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA

Re: [Qemu-devel] [PATCH] i.MX: implement a more complete version of the GPT timer.

2013-05-27 Thread Peter Chubb
functional and non-functional changes separate. -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA

Re: [Qemu-devel] [PATCH v2] i.MX: implement a more correct version of EPIT timer.

2013-04-28 Thread Peter Chubb
-by: Peter Chubb peter.ch...@nicta.com.au line. Peter C -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA

Re: [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return statements.

2013-04-15 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 15 April 2013 05:50, Peter Chubb peter.ch...@nicta.com.au Peter wrote: Since patch 81465888c5306cd94abb9847e560796fd13d3c2f target-arm: factor out handling of SRS instruction the SRS instruction has not worked in QEMU

[Qemu-devel] [PATCH v2] target-arm: Reinsert SRS missing return statement.

2013-04-15 Thread Peter Chubb
the generic stuff that it should do for most instructions -- but not SRS. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- target-arm/translate.c |1 + 1 file changed, 1 insertion(+) diff --git a/target-arm/translate.c b/target-arm/translate.c index 35a21be..a1b7b8c 100644 --- a/target-arm

[Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return statements.

2013-04-14 Thread Peter Chubb
that it should not have done. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au diff --git a/target-arm/translate.c b/target-arm/translate.c index 35a21be..c870246 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -6762,6 +6762,7 @@ static void disas_arm_insn(CPUARMState * env

Re: [Qemu-devel] [PATCH] i.MX: implement a more correct version of EPIT timer.

2013-04-09 Thread Peter Chubb
good --- you seem to understand the ptimer interface better than I did when I updated this code. Peter c -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA

Re: [Qemu-devel] [PATCH] hw/imx_avic.c: Avoid format error when target_phys_addr_t is 64 bits

2012-07-10 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter Add a missing cast to avoid gcc complaining about format string Peter errors when printing an expression based on a Peter target_phys_addr_t. Peter Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Peter Chubb

[Qemu-devel] [Patch V10 0/5] i.MX31: Add initial support

2012-06-19 Thread Peter Chubb
Changes since V9: Added MAINTAINERS entry, rebased (and tested) against git tip. Peter C -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA

[Qemu-devel] [Patch V10 5/5] i.MX31: KZM-ARM11-01 evaluation board

2012-06-19 Thread Peter Chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the Freescale i.MX31. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- MAINTAINERS |6 + hw/arm/Makefile.objs |1 hw/kzm.c

[Qemu-devel] [Patch V10 2/5] i.MX31: Clock Control Module

2012-06-19 Thread Peter Chubb
., the ones used to feed the periodic and general purpose timers. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- hw/arm/Makefile.objs |2 hw/imx.h | 10 + hw/imx_ccm.c | 321 +++ 3 files changed, 332 insertions

[Qemu-devel] [Patch V10 1/5] i.MX: UART support

2012-06-19 Thread Peter Chubb
-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- hw/arm/Makefile.objs |1 hw/imx.h | 16 + hw/imx_serial.c | 467 +++ 3 files changed, 484 insertions(+) create

[Qemu-devel] [Patch V10 4/5] i.MX31: Interrupt Controller

2012-06-19 Thread Peter Chubb
Implement the Freescale i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.x Vectors are not implemented. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd

[Qemu-devel] [Patch V10 3/5] i.MX31: Timers

2012-06-19 Thread Peter Chubb
Implement the timers on the Freescale i.MX31 SoC. This is not a complete implementation, but gives enough for Linux to boot and run. In particular external triggers, which are not useful under QEMU, are not implemented. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter

Re: [Qemu-devel] Broken Microblaze timer

2012-06-14 Thread Peter Chubb
achievable is meant to fix this in the cases where the timer is auto-reloaded. xilinx_timer.c always uses the timer in one-shot mode, so it needs to be fixed in there. -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software

Re: [Qemu-devel] Broken Microblaze timer

2012-06-14 Thread Peter Chubb
. So the CPU always gets a look in --- or ought to. -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA

Re: [Qemu-devel] [patch v8 0/5] i.MX31 support

2012-06-06 Thread Peter Chubb
Andreas == Andreas Färber afaer...@suse.de writes: Andreas Hello Peter, Am 06.06.2012 05:47, schrieb Peter Chubb: There are no major changes since last time, just rebased to current tip now that QEMU 1.2 is open. For those who have come into the story late, this is a series of patches

[Qemu-devel] [patch] target-microblaze/translate.c fails to compile with gcc 4.7

2012-06-06 Thread Peter Chubb
; unsigned int size, rev = 0, ex = 0; -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA

[Qemu-devel] [patch V9 0/5] i.MX31: Add initial support

2012-06-06 Thread peter . chubb
Changes since V8: Recovered my stuff-up from backup --- changes that were in V7 are back in! Andreas's comments addressed (except adding MAINTAINER field) Peter Maydell's comments against V6/7 are addressed. Peter C -- Dr Peter Chubb

[Qemu-devel] [patch V9 4/5] i.MX31: Interrupt Controller

2012-06-06 Thread peter . chubb
Implement the Freescale i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.x Vectors are not implemented. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd

[Qemu-devel] [patch V9 3/5] i.MX31: Timers

2012-06-06 Thread peter . chubb
Written by Hans Jiang + * Updated by Peter Chubb + * + * This code is licenced under GPL version 2 or later. See + * the COPYING file in the top-level directory. + * + */ + +#include hw.h +#include qemu-timer.h +#include ptimer.h +#include sysbus.h +#include imx.h + +//#define DEBUG_TIMER 1 +#ifdef

[Qemu-devel] [patch V9 2/5] i.MX31: Clock Control Module

2012-06-06 Thread peter . chubb
., the ones used to feed the periodic and general purpose timers. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/imx.h| 10 + hw/imx_ccm.c| 321 3 files changed, 332 insertions(+), 1

[Qemu-devel] [patch V9 1/5] i.MX: UART support

2012-06-06 Thread peter . chubb
-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- Makefile.target |1 hw/imx.h| 16 + hw/imx_serial.c | 467 3 files changed, 484 insertions(+) create mode

[Qemu-devel] [patch V9 5/5] i.MX31: KZM-ARM11-01 evaluation board

2012-06-06 Thread peter . chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the Freescale i.MX31. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/kzm.c| 156

[Qemu-devel] [patch v8 3/5] i.MX31 support: Timers

2012-06-05 Thread Peter Chubb
Written by Hans Jiang + * Updated by Peter Chubb + * + * This code is licenced under GPL version 2 or later. See + * the COPYING file in the top-level directory. + * + */ + +#include hw.h +#include qemu-timer.h +#include ptimer.h +#include sysbus.h +#include imx.h + +//#define DEBUG_TIMER 1

[Qemu-devel] [patch v8 4/5] i.MX31 support: AVIC

2012-06-05 Thread Peter Chubb
Implement the FreeSCALE i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.0.x Vectors are not implemented. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd

[Qemu-devel] [patch v8 0/5] i.MX31 support

2012-06-05 Thread Peter Chubb
Linux and seL4 nicely. -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA

[Qemu-devel] [patch v8 1/5] i.MX UART support

2012-06-05 Thread Peter Chubb
-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- Makefile.target |1 hw/imx.h| 16 + hw/imx_serial.c | 467 3 files changed, 484 insertions(+) create mode

[Qemu-devel] [patch v8 2/5] i.MX31 support: Clock Control Module

2012-06-05 Thread Peter Chubb
., the ones used to feed the periodic and general purpose timers. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/imx.h| 10 + hw/imx_ccm.c| 321 3 files changed, 332 insertions(+), 1

[Qemu-devel] [patch v8 5/5] i.MX31 support: KZM-ARM11-01 evaluation board

2012-06-05 Thread Peter Chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the FreeScale i.MX31. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/kzm.c| 155

[Qemu-devel] [PATCH v7 0/5] add i.MX31 support

2012-05-01 Thread Peter Chubb
Peter Chubbwww.nicta.com.au peter DOT chubb AT nicta.com.au http://www.ertos.nicta.com.au ERTOS within National ICT Australia From Imagination to Impact Imagining the (ICT) Future

[Qemu-devel] [PATCH v7 5/5] i.MX31: KZM-ARM11-01 evaluation board

2012-05-01 Thread Peter Chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the Freescale i.MX31. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/kzm.c| 155

[Qemu-devel] [PATCH v7 4/5] i.MX31: Interrupt Controller

2012-05-01 Thread Peter Chubb
Implement the Freescale i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.x Vectors are not implemented. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd

[Qemu-devel] [PATCH v7 2/5] i.MX31: Clock Control Module

2012-05-01 Thread Peter Chubb
., the ones used to feed the periodic and general purpose timers. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/imx.h| 10 + hw/imx_ccm.c| 321 3 files changed, 332 insertions(+), 1

[Qemu-devel] [PATCH v7 3/5] i.MX31: Timers

2012-05-01 Thread Peter Chubb
+ * Updated by Peter Chubb + * + * This code is licenced under GPL version 2 or later. See + * the COPYING file in the top-level directory. + * + */ + +#include hw.h +#include qemu-timer.h +#include ptimer.h +#include sysbus.h +#include imx.h + +//#define DEBUG_TIMER 1 +#ifdef DEBUG_TIMER

[Qemu-devel] [PATCH v7 1/5] i.MX: UART support

2012-05-01 Thread Peter Chubb
-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- Makefile.target |1 hw/imx.h| 16 + hw/imx_serial.c | 467 3 files changed, 484 insertions(+) create mode

Re: [Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-24 Thread Peter Chubb
Paolo == Paolo Bonzini pbonz...@redhat.com writes: Paolo Il 23/04/2012 22:54, Peter Chubb ha scritto: Peter What is this calculation supposed to do? It doesn't convert a Peter 10-bit signed twos-complement number into an int32_t, unless Peter I'm confused... Also, it's a rather opaque way

Re: [Qemu-devel] [PATCH v6 0/5] FreeSCALE i.MX31 support

2012-04-24 Thread Peter Chubb
Andreas == Andreas Färber afaer...@suse.de writes: Andreas Am 23.04.2012 01:31, schrieb Peter Chubb: Hi all, Most of the files are unchanged since last time. Andreas Indeed... On v5 I had asked you to shorten the subjects to Andreas conform to our commit message scheme and to make patches

Re: [Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-23 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 23 April 2012 00:31, Peter Chubb peter.ch...@nicta.com.au Peter wrote: Peter Rather than having the *_clk_freq saved and loaded in the Peter vmstate, I think it would be nicer to have a post-load-hook Peter that called

Re: [Qemu-devel] [PATCH v6 5/5] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board

2012-04-23 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 23 April 2012 00:31, Peter Chubb peter.ch...@nicta.com.au Peter wrote: Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the FreeScale i.MX31. +    if (serial_hds[3]) { +        serial_mm_init

[Qemu-devel] [PATCH v6 0/5] FreeSCALE i.MX31 support

2012-04-22 Thread Peter Chubb
(not in this series) against ptimer.c -- Move function prototypes in imx.h into the correct patch. Peter C -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA

[Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-22 Thread Peter Chubb
., the ones used to feed the periodic and general purpose timers. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/imx.h| 10 + hw/imx_ccm.c| 312 3 files changed, 323 insertions(+), 1

[Qemu-devel] [PATCH v6 5/5] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board

2012-04-22 Thread Peter Chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the FreeScale i.MX31. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/kzm.c| 161

[Qemu-devel] [PATCH v6 1/5] i.MX UART support

2012-04-22 Thread Peter Chubb
-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- Makefile.target |1 hw/imx.h| 16 + hw/imx_serial.c | 467 3 files changed, 484 insertions(+) create mode

[Qemu-devel] [PATCH v6 3/5] FreeSCALE i.MX31 support: Timers

2012-04-22 Thread Peter Chubb
Written by Hans Jiang + * Updated by Peter Chubb + * + * This code is licenced under GPL version 2 or later. See + * the COPYING file in the top-level directory. + * + */ + +#include hw.h +#include qemu-timer.h +#include ptimer.h +#include sysbus.h +#include imx.h + +//#define DEBUG_TIMER 1

[Qemu-devel] [PATCH v6 4/5] FreeSCALE i.MX31 support: AVIC

2012-04-22 Thread Peter Chubb
Implement the FreeSCALE i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.0.x Vectors are not implemented. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd

[Qemu-devel] [PATCH] Limit ptimer rate to something achievable

2012-04-19 Thread Peter Chubb
to get at the monitor. Reported-by: Anna Lyons anna.ly...@nicta.com.au Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- hw/ptimer.c | 13 + 1 file changed, 13 insertions(+) Index: qemu-working/hw/ptimer.c

Re: [Qemu-devel] [patch V5 3/5] FreeSCALE i.MX31 support: Timers

2012-04-10 Thread Peter Chubb
Peter == Peter Chubb peter.ch...@nicta.com.au writes: Peter I'm not sure how to make qdev properties work. The timers need Peter to be able to get at the CCM-generated frequencies, which of Peter course are private to the CCM. I've just split the problematic function into two

Re: [Qemu-devel] [patch V5 2/5] Implement i.MX31 Clock Control Module

2012-04-09 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 3 April 2012 02:55, Peter Chubb peter.ch...@nicta.com.au Peter wrote: + +uint32_t imx_timer_frequency(DeviceState *s, IMXClk clock); +void imx_timer_create(const char * const name, + const

Re: [Qemu-devel] [patch V5 3/5] FreeSCALE i.MX31 support: Timers

2012-04-09 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 3 April 2012 02:55, Peter Chubb peter.ch...@nicta.com.au Peter wrote: +/* + * Artificially limit tick rate to something + * achievable under QEMU. Otherwise, QEMU spends all + * its time generating

[Qemu-devel] [patch V5 5/5] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board

2012-04-02 Thread Peter Chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the FreeScale i.MX31. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/kzm.c| 161

[Qemu-devel] [patch V5 0/5] i.MX31 support

2012-04-02 Thread Peter Chubb
with Linux 3.3.0 and a variety of unit tests. DVFS is still not implemented; but apart from that, timer ticks seem to come at around the right rate, and the timer values when read are sane. -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au

[Qemu-devel] [patch V5 2/5] Implement i.MX31 Clock Control Module

2012-04-02 Thread Peter Chubb
., the ones used to feed the periodic and general purpose timers. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/imx.h| 14 ++ hw/imx_ccm.c| 334 3 files changed, 349 insertions(+), 1

[Qemu-devel] [patch V5 4/5] FreeSCALE i.MX31 support: AVIC

2012-04-02 Thread Peter Chubb
Implement the FreeSCALE i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.0.x Vectors are not implemented. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd

[Qemu-devel] [patch V5 1/5] i.MX UART support

2012-04-02 Thread Peter Chubb
-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- Makefile.target |1 hw/imx.h| 16 + hw/imx_serial.c | 467 3 files changed, 484 insertions(+) create mode

[Qemu-devel] [patch V5 3/5] FreeSCALE i.MX31 support: Timers

2012-04-02 Thread Peter Chubb
+ * Updated by Peter Chubb + * + * This code is licenced under GPL version 2 or later. See + * the COPYING file in the top-level directory. + * + */ + +#include hw.h +#include qemu-timer.h +#include ptimer.h +#include sysbus.h +#include imx.h + +//#define DEBUG_TIMER 1 +#ifdef DEBUG_TIMER +# define

Re: [Qemu-devel] [patch V4 2/4] FreeSCALE i.MX31 support: Timers

2012-03-15 Thread Peter Chubb
this looks ok on that front? Yes please! I think there's a bug in there somewhere when using the G timer, as interrupts appear to arrive too far apart in some modes. The scaling is probably wrong somewhere. -- Dr Peter Chubb peter.chubb AT nicta.com.au http

Re: [Qemu-devel] [patch V4 1/4] i.MX UART support

2012-03-15 Thread Peter Chubb
Thanks for your reviewing time and expertise Peter. It's much appreciated. May I add your Reviewed-By: line to the imx-serial patch too? The only change is CamelCasing the typedef. Peter C -- Dr Peter Chubb peter.chubb AT nicta.com.au http

[Qemu-devel] [patch V4 2/4] FreeSCALE i.MX31 support: Timers

2012-03-08 Thread peter . chubb
+ * Updated by Peter Chubb + * + * This code is licenced under GPL version 2 or later. See + * the COPYING file in the top-level directory. + */ + +#include hw.h +#include qemu-timer.h +#include ptimer.h +#include sysbus.h + +//#define DEBUG_TIMER 1 +#ifdef DEBUG_TIMER +# define DPRINTF(fmt, args

[Qemu-devel] [patch V4 0/4] Support for i.MX31 and the Kyoto KZM11 board

2012-03-08 Thread peter . chubb
-- ignores baud rate, and implements only a one character FIFO -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA

[Qemu-devel] [patch V4 4/4] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board

2012-03-08 Thread peter . chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the FreeScale i.MX31. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |1 hw/kzm.c| 159

[Qemu-devel] [patch V4 3/4] FreeSCALE i.MX31 support: AVIC

2012-03-08 Thread peter . chubb
Implement the FreeSCALE i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.0.x Vectors are not implemented. Signed-off-by: Philip O'Sullivan phil...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw

[Qemu-devel] [patch V4 1/4] i.MX UART support

2012-03-08 Thread peter . chubb
-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |1 hw/imx_serial.c | 466 2 files changed, 467 insertions(+) create mode 100644 hw/imx_serial.c Index: qemu-working/hw/imx_serial.c

Re: [Qemu-devel] [PATCH V3 1/4] Implement the FreeScale i.MX UART. This uart is used in a variety of SoCs, including some by Motorola, as well as in the FreeScale i.MX series.

2011-12-05 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 30 November 2011 03:36, Peter Chubb Peter peter.ch...@nicta.com.au wrote: Commit messages should be Peter formatted with a short summary line, then a blank line, then a Peter more detailed description. You've put everything

Re: [Qemu-devel] [PATCH V3 3/4] Implement the FreeSCALE i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.0.x

2011-12-05 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 30 November 2011 03:36, Peter Chubb Peter peter.ch...@nicta.com.au wrote: Signed-off-by: Hans Jang hsj...@ok-labs.com Signed-off-by: Adam Clench ad...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au

Re: [Qemu-devel] [PATCH V3 1/4] Implement the FreeScale i.MX UART. This uart is used in a variety of SoCs, including some by Motorola, as well as in the FreeScale i.MX series.

2011-12-01 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 1 December 2011 16:55, Peter Maydell Peter peter.mayd...@linaro.org wrote: On 30 November 2011 03:36, Peter Chubb peter.ch...@nicta.com.au wrote: Signed-off-by: Hans Jang hsj...@ok-labs.com Peter Is this email address correct

[Qemu-devel] [PATCH V3 0/4] i.MX31 and KZM board support

2011-11-29 Thread Peter Chubb
initialiser and sysbus_register_withprop() instead of calls to sysbus_register() adn vmstate_register() * Fixed bugs in imx_timer.c as noted by PMM and Andreas -- Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au http://www.ertos.nicta.com.au ERTOS within National

[Qemu-devel] [PATCH V3 4/4] Board support for Kyoto Micros KZM-ARM11-01, an evaluation board built around the FreeScale i.MX31.

2011-11-29 Thread Peter Chubb
Signed-off-by: Hans Jang hsj...@ok-labs.com Signed-off-by: Adam Clench ad...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |1 hw/kzm.c| 155 2 files changed, 156 insertions(+) create

[Qemu-devel] [PATCH V3 3/4] Implement the FreeSCALE i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.0.x

2011-11-29 Thread Peter Chubb
Signed-off-by: Hans Jang hsj...@ok-labs.com Signed-off-by: Adam Clench ad...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/imx_avic.c | 378 2 files changed, 379 insertions(+), 1 deletion

[Qemu-devel] [PATCH V3 2/4] Implement the timers on the FreeScale i.MX31 SoC. This is not a complete implementation, but gives enough for Linux to boot and run.

2011-11-29 Thread Peter Chubb
Signed-off-by: Hans Jang hsj...@ok-labs.com Signed-off-by: Adam Clench ad...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/imx_timer.c | 460 2 files changed, 461 insertions(+), 1

[Qemu-devel] [PATCH V3 1/4] Implement the FreeScale i.MX UART. This uart is used in a variety of SoCs, including some by Motorola, as well as in the FreeScale i.MX series.

2011-11-29 Thread Peter Chubb
Signed-off-by: Hans Jang hsj...@ok-labs.com Signed-off-by: Adam Clench ad...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |1 hw/imx_serial.c | 320 2 files changed, 321 insertions(+) create

Re: [Qemu-devel] [PATCH V3 0/4] i.MX31 and KZM board support

2011-11-29 Thread Peter Chubb
Stefan == Stefan Weil s...@weilnetz.de writes: Stefan Am 30.11.2011 04:36, schrieb Peter Chubb: Changes since last patchset: * All files now under GPL version 2 or later (I've talked with OK-Labs and they've agreed). Stefan hw/imx_serial.c is still GPL 2 only. I did not review the Stefan rest

Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support

2011-11-25 Thread Peter Chubb
Andreas == Andreas Färber afaer...@suse.de writes: Andreas Am 23.11.2011 01:51, schrieb Peter Chubb: Peter == Peter Chubb peter.ch...@nicta.com.au writes: Peter All comments received so far have been addressed --- I've added Peter a macro, `scream' that gives at most 10 lines of output

Re: [Qemu-devel] [PATCH V2 1/4] imx.31 and KZM board support: UART support

2011-11-24 Thread Peter Chubb
Thanks Peter, I've fixed the problems you noted, and have asked the OK-Labs folks about Licencing. When I hear back from them I'll roll a new patchset --- I don't expect `GPL v2 or later' to be a problem. -- Peter C -- Dr Peter Chubb http

[Qemu-devel] Who maintains checkpatch.pl now?

2011-11-24 Thread Peter Chubb
not a parameter group. } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) { -- Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au http://www.ertos.nicta.com.au ERTOS within National ICT Australia

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-22 Thread Peter Chubb
Juan == Juan Quintela quint...@redhat.com writes: Juan Peter Chubb pet...@gelato.unsw.edu.au wrote: Juan This is not used. Shouldn't a call like this be needed? Juanvmstate_register(dev-qdev, -1, vmstate_imxg_timer, s); Juan ??? Yes!! Thanks for checking. I've altered the source

Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support

2011-11-22 Thread Peter Chubb
Peter == Peter Chubb peter.ch...@nicta.com.au writes: Peter All comments received so far have been addressed --- I've added Peter a macro, `scream' that gives at most 10 lines of output for OS Peter error reporting. Except I noticed a thinko in the macro. The decrement should be inside

[Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
and implemented enough extra that Linux will boot on the patched QEMU using a ram disk. The i.MX 31 Serial controller is found in most of the i.MX SoCs; the AVIC and timer implementations can also be shared, albeit with fewer chips. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Signed

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-11-21 Thread Peter Chubb
Hi Peter, Here's a fixed patch for the sp804 timer. Properly implement the dual-timer read/write for the sp804 dual timer module. Based on ARM specs at http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html Signed-off-by: Peter Chubb peter.ch...@nicta.com.au Signed

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Andreas == Andreas Färber andreas.faer...@web.de writes: Andreas Hi Peter, Am 21.11.2011 22:58, schrieb Peter Chubb: Hi Peter, Please find appended a patch containing initial support for the FreeScale i.MX31 and the KZM Arm11 evaluation board. Andreas Your patch format is a bit unusual

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
something wrong and the qemu instance dies with a message. It's not as it that'll affect any other guests, each of which will have their own qemu instance. -- Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au http://www.ertos.nicta.com.au ERTOS within National ICT

Re: [Qemu-devel] [PATCH] [ARM] fix function names in error messages in arm_timer.c

2011-11-21 Thread Peter Chubb
Fix names of functions in error messages: as suggested by Andreas Färber, use the C99 standard __func__ macro to get the correct name. This fixes one real bug (the message used to print sp804 instead of icp_pit), the other changes are cosmetic. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 21 November 2011 23:54, Peter Chubb Peter pet...@gelato.unsw.edu.au wrote: Do you have a suggestion for an alternative to hw_error for guest bad behaviour?  It seems to be used historically.  For emulating ARM, causing qemu

  1   2   >