[PULL 4/5] ui/cocoa: Take refresh rate into account

From: Akihiko Odaki Retrieve the refresh rate of the display and reflect it with dpy_set_ui_info() and update_displaychangelistener(), allowing the guest and DisplayChangeListener to consume the information. The information will be used as a hint how often the display should be updated. For

[PULL 2/5] configure: Restrict TCG to emulation

If we don't need to emulate any target, we certainly don't need TCG. This should also help to compile again with ".../configure --enable-tools --disable-system --disable-user" on systems that do not have a TCG backend. Signed-off-by: Philippe Mathieu-Daudé [thuth: Re-arranged the code, remove

[PULL 1/5] hvf: Enable RDTSCP support

From: Cameron Esfahani Pass through RDPID and RDTSCP support in CPUID if host supports it. Correctly detect if CPU_BASED_TSC_OFFSET and CPU_BASED2_RDTSCP would be supported in primary and secondary processor-based VM-execution controls. Enable RDTSCP in secondary processor controls if RDTSCP

Re: [PATCH] linux-user/hppa: Fix segfaults on page zero

On 7/7/22 21:45, Helge Deller wrote: This program: int main(void) { asm("bv %r0(%r0)"); return 0; } produces on real hardware the expected segfault: --- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0x3} --- +++ killed by SIGSEGV +++ Segmentation fault But when run on

Re: [PATCH v2 00/40] PS2 device QOMification - part 2

On 12/7/22 23:52, Mark Cave-Ayland wrote: Here is the follow-on series from part 1 which completes the work to remove the legacy global device init functions for PS2 devices. Now that part 1 has been applied, the hard part to remove the PS2 function callback and argument has been completed and

Re: [PATCH v2] Align Raspberry Pi DMA interrupts with Linux DTS

Hi Andrey, On 12/7/22 12:45, Andrey Makarov wrote: There is nothing in the specs on DMA engine interrupt lines: it should have been in the "BCM2835 ARM Peripherals" datasheet but the appropriate "ARM peripherals interrupt table" (p.113) is nearly empty. All Raspberry Pi models 1-3 (based on

[PULL 0/5] Darwin patches for 2022-07-12

The following changes since commit 8e3d85d36b77f11ad7bded3a2d48c1f0cc334f82: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2022-07-12 14:12:15 +0100) are available in the Git repository at: https://github.com/philmd/qemu.git tags/darwin-20220712 for you to

[PULL 5/5] avocado: Fix BUILD_DIR if it's equal to SOURCE_DIR

From: Peter Delevoryas I like to build QEMU from the root source directory [*], rather than cd'ing into the build directory. This code may as well include a search path for that, so that you can run avocado tests individually without specifying "-p qemu_bin=build/qemu-system-arm" manually. [*]

[PULL 3/5] ui/cocoa: Fix switched_to_fullscreen warning

From: Peter Delevoryas I noticed this error while building QEMU on Mac OS X: [1040/1660] Compiling Objective-C object libcommon.fa.p/ui_cocoa.m.o ../ui/cocoa.m:803:17: warning: variable 'switched_to_fullscreen' set but not used [-Wunused-but-set-variable] static bool

Re: [PATCH] avocado: Fix BUILD_DIR if it's equal to SOURCE_DIR

On 2/7/22 20:56, Peter Delevoryas wrote: I like to build QEMU from the root source directory, rather than cd'ing into the build directory. This code may as well include a search path for that, so that you can run avocado tests individually without specifying "-p qemu_bin=build/qemu-system-arm"

Re: [PATCH] target/avr: Drop avr_cpu_memory_rw_debug()

On Mon, Jun 20, 2022 at 10:01 PM Richard Henderson wrote: > On 3/22/22 02:50, Bin Meng wrote: > > CPUClass::memory_rw_debug() holds a callback for GDB memory access. > > If not provided, cpu_memory_rw_debug() is used by the GDB stub. > > Drop avr_cpu_memory_rw_debug() which does nothing special.

Re: [PATCH 1/3] ui/cocoa: Run qemu_init in the main thread

Hi Akihiko, On 6/7/22 04:13, Akihiko Odaki wrote: This work is based on: https://patchew.org/QEMU/20220317125534.38706-1-philippe.mathieu.da...@gmail.com/ Simplify the initialization dance by running qemu_init() in the main thread before the Cocoa event loop starts. The secondary thread only

Re: [PATCH] configure: Restrict TCG to emulation

On 6/7/22 17:38, Thomas Huth wrote: From: Philippe Mathieu-Daudé If we don't need to emulate any target, we certainly don't need TCG. This should also help to compile again with ".../configure --enable-tools --disable-system --disable-user" on systems that do not have a TCG backend.

Re: [PATCH v4] ui/cocoa: Take refresh rate into account

On 2/7/22 16:25, Akihiko Odaki wrote: Retreieve the refresh rate of the display and reflect it with dpy_set_ui_info() and update_displaychangelistener(), allowing the guest and DisplayChangeListener to consume the information. The information will be used as a hint how often the display should

Re: [PULL 09/18] tests/tcg: compile system emulation tests as freestanding

On 12/7/22 14:49, Paolo Bonzini wrote: System emulation tests do not run in a hosted environment, since they do not link with libc. They should only use freestanding headers (float.h, limits.h, stdarg.h, stddef.h, stdbool.h, stdint.h, stdalign.h, stdnoreturn.h) and should be compiled with

[PULL 12/12] target/mips: Remove GET_TARGET_STRING and FREE_TARGET_STRING

From: Richard Henderson Inline these macros into the only two callers. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20220628111701.677216-9-richard.hender...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/sysemu/mips-semi.c | 27

[PULL 11/12] target/mips: Simplify UHI_argnlen and UHI_argn

From: Richard Henderson With semihosting_get_arg, we already have a check vs argc, so there's no point replicating it -- just check the result vs NULL. Merge copy_argn_to_target into its caller. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 07/12] target/mips: Use semihosting/syscalls.h

From: Richard Henderson This separates guest file descriptors from host file descriptors, and utilizes shared infrastructure for integration with gdbstub. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220628111701.677216-4-richard.hender...@linaro.org>

[PULL 04/12] target/mips: introduce Cavium Octeon CPU model

From: Pavel Dovgalyuk This patch adds Cavium Octeon 68XX vCPU which provides Octeon-specific instructions. Signed-off-by: Pavel Dovgalyuk Message-Id: <165572673785.167724.7604881144978983510.stgit@pasha-ThinkPad-X280> Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu-defs.c.inc | 28

[PULL 09/12] target/mips: Use error_report for UHI_assert

From: Richard Henderson Always log the assert locally. Do not report_fault, but instead include the fact of the fault in the assertion. Don't bother freeing allocated strings before the abort(). Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 02/12] target/mips: implement Octeon-specific BBIT instructions

From: Pavel Dovgalyuk This patch introduces Octeon-specific decoder and implements check-bit-and-jump instructions. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson Message-Id: <165572672705.167724.16667636081912075906.stgit@pasha-ThinkPad-X280> Signed-off-by: Philippe

[PULL 10/12] semihosting: Remove qemu_semihosting_log_out

From: Richard Henderson The function is no longer used. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20220628111701.677216-7-richard.hender...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- include/semihosting/console.h | 13 -

[PULL 05/12] target/mips: Create report_fault for semihosting

From: Richard Henderson The UHI specification does not have an EFAULT value, and further specifies that "undefined UHI operations should not return control to the target". So, log the error and abort. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 01/12] target/mips: introduce decodetree structure for Cavium Octeon extension

From: Pavel Dovgalyuk This patch adds decodetree for Cavium Octeon extension and an instruction set extension flag for using it in CPU models. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson Message-Id: <165572672162.167724.13656301229517693806.stgit@pasha-ThinkPad-X280>

[PULL 08/12] target/mips: Avoid qemu_semihosting_log_out for UHI_plog

From: Richard Henderson Use semihost_sys_write and/or qemu_semihosting_console_write for implementing plog. When using gdbstub, copy the temp string below the stack so that gdb has a guest address from which to perform the log. Signed-off-by: Richard Henderson Reviewed-by: Philippe

[PULL 06/12] target/mips: Drop link syscall from semihosting

From: Richard Henderson We don't implement it with _WIN32 hosts, and the syscall is missing from the gdb remote file i/o interface. Since we can't implement it universally, drop it. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 03/12] target/mips: implement Octeon-specific arithmetic instructions

From: Pavel Dovgalyuk This patch implements several Octeon-specific instructions: - BADDU - DMUL - EXTS/EXTS32 - CINS/CINS32 - POP/DPOP - SEQ/SEQI - SNE/SNEI Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson Message-Id:

[PULL 00/12] MIPS patches for 2022-07-12

The following changes since commit 8e3d85d36b77f11ad7bded3a2d48c1f0cc334f82: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2022-07-12 14:12:15 +0100) are available in the Git repository at: https://github.com/philmd/qemu.git tags/mips-20220712 for you to fetch

Re: [PATCH v5 3/8] target/mips: Use semihosting/syscalls.h

On 28/6/22 13:16, Richard Henderson wrote: This separates guest file descriptors from host file descriptors, and utilizes shared infrastructure for integration with gdbstub. Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 219 + 1 file

Re: [PATCH v5 1/8] target/mips: Create report_fault for semihosting

On 28/6/22 13:16, Richard Henderson wrote: The UHI specification does not have an EFAULT value, and further specifies that "undefined UHI operations should not return control to the target". So, log the error and abort. Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c

Re: [PATCH v5 3/8] target/mips: Use semihosting/syscalls.h

On 28/6/22 13:16, Richard Henderson wrote: This separates guest file descriptors from host file descriptors, and utilizes shared infrastructure for integration with gdbstub. Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 219 + 1 file

Re: [PATCH v3 9/9] tests/style: check qemu/osdep.h is NOT included in all .h/.c.inc files

On 7/7/22 18:37, Daniel P. Berrangé wrote: Since the qemu/osdep.h file must be included as the very first header in all C source files, there is no reason to include it in .h or .c.in files. Signed-off-by: Daniel P. Berrangé --- tests/style.yml | 5 + 1 file changed, 5 insertions(+)

Re: [PATCH] MAINTAINERS: Add myself as Guest Agent reviewer

On 12/7/22 11:27, Konstantin Kostiuk wrote: Signed-off-by: Konstantin Kostiuk --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 450abd0252..b1e73d99f3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2880,6 +2880,7 @@ T: git

Re: [PATCH v5 0/8] target/mips: semihosting cleanup

On 28/6/22 13:16, Richard Henderson wrote: Richard Henderson (8): target/mips: Create report_fault for semihosting target/mips: Drop link syscall from semihosting target/mips: Use semihosting/syscalls.h target/mips: Avoid qemu_semihosting_log_out for UHI_plog target/mips: Use

Re: [PATCH v5 5/8] target/mips: Use error_report for UHI_assert

On 28/6/22 13:16, Richard Henderson wrote: Always log the assert locally. Do not report_fault, but instead include the fact of the fault in the assertion. Don't bother freeing allocated strings before the abort(). Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 39

Re: [PATCH v5 4/8] target/mips: Avoid qemu_semihosting_log_out for UHI_plog

On 28/6/22 13:16, Richard Henderson wrote: Use semihost_sys_write and/or qemu_semihosting_console_write for implementing plog. When using gdbstub, copy the temp string below the stack so that gdb has a guest address from which to perform the log. Signed-off-by: Richard Henderson ---

Re: [PATCH v5 2/8] target/mips: Drop link syscall from semihosting

On 28/6/22 13:16, Richard Henderson wrote: We don't implement it with _WIN32 hosts, and the syscall is missing from the gdb remote file i/o interface. Since we can't implement it universally, drop it. Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 9 - 1

Re: [PATCH v5 7/8] target/mips: Simplify UHI_argnlen and UHI_argn

On 28/6/22 13:17, Richard Henderson wrote: With semihosting_get_arg, we already have a check vs argc, so there's no point replicating it -- just check the result vs NULL. Merge copy_argn_to_target into its caller. Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 44

Re: [PATCH] ui/cocoa: Fix switched_to_fullscreen warning

On 2/7/22 06:43, Peter Delevoryas wrote: I noticed this error while building QEMU on Mac OS X: [1040/1660] Compiling Objective-C object libcommon.fa.p/ui_cocoa.m.o ../ui/cocoa.m:803:17: warning: variable 'switched_to_fullscreen' set but not used [-Wunused-but-set-variable]

Re: [PATCH v3 3/9] tests/style: check for mixups of bool constants with int variables

On 7/7/22 18:37, Daniel P. Berrangé wrote: The 'true' and 'false' constants should only ever be used with the 'bool' type, never 'int'. Signed-off-by: Daniel P. Berrangé --- tests/style.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/style.yml b/tests/style.yml index

Re: [RFC PATCH] docs/devel: fix description of OBJECT_DECLARE_SIMPLE_TYPE

On 12/7/22 12:31, Alex Bennée wrote: Since 30b5707c26 (qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros) we don't need the additional two parameters. Fix the documentation. Signed-off-by: Alex Bennée --- docs/devel/qom.rst | 3 +-- 1 file changed, 1 insertion(+), 2

Re: Error ret=-1 with EINTR in nbd_connect_systemd_socket_activation()

Cc'ing qemu-block@ On 11/7/22 08:38, Motohiro Kawahito wrote: Hi, I’d like to connect to an encrypted QCOW2 file by nbd_connect_systemd_socket_activation(), but I got ret=-1 with EINTR. The arg parameter I used is qemu-nbd --object secret,id=sec0,data=abc123 --image-opts

Re: [PATCH v3 8/9] misc: remove qemu/osdep.h from headers / included source files

On 7/7/22 18:37, Daniel P. Berrangé wrote: Since qemu/osdep.h is guaranteed present in all C source files, there is hno reason for it to be present in header files. Some C source files are not directly directly, but rather included from other source files. These should also not have qemu/osdep.h

Re: [PATCH] scripts: check if .git exists before checking submodule status

On 29/6/22 18:08, Daniel P. Berrangé wrote: Currently we check status of each submodule, before actually checking if we're in a git repo. These status commands will all fail, but we are hiding their output so we don't see it currently. Signed-off-by: Daniel P. Berrangé ---

Re: [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER

On 5/7/22 10:36, Richard Henderson wrote: There is nothing in this environment variable that cannot be done better with -d flags. There is nothing special about TCI that warrants this hack. Moreover, it does not compile -- remove it. Reported-by: Song Gao Signed-off-by: Richard Henderson

Re: [PATCH] tests/docker/dockerfiles: Add debian-loongarch-cross.docker

On 4/7/22 09:08, Richard Henderson wrote: Use the pre-packaged toolchain provided by Loongson via github. Signed-off-by: Richard Henderson --- configure | 5 tests/docker/Makefile.include | 2 ++

Re: [PATCH v3 4/4] target/mips: introduce Cavium Octeon CPU model

On 4/7/22 12:59, Pavel Dovgalyuk wrote: ping This is the only non-reviewed patch in the series. I've been looking for doc/datasheets but no luck (except the Linux kernel comments). What kind of testing are you doing? On 20.06.2022 15:05, Pavel Dovgalyuk wrote: This patch adds Cavium

Re: Why we should avoid new submodules if possible

On Fri, Jul 1, 2022 at 5:37 AM Thomas Huth wrote: > On 29/06/2022 08.28, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 11:30 PM Michael S. Tsirkin wrote: > >> On Tue, Jun 28, 2022 at 05:15:05PM +0100, Daniel P. Berrangé wrote: > >>> FYI, the reason much of this is intentionally NOT under the

Re: [PATCH 1/7] crypto: Introduce ECDSA algorithm API

On 13/6/22 10:45, Lei He wrote: Introduce ECDSA related structures to qapi-crypto. Signed-off-by: lei he --- qapi/crypto.json | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) +## +# @QCryptoAkCipherOptionsECDSA: +# +# Specific parameters for ECDSA

Re: [Phishing Risk] [External] Re: [PATCH 4/7] crypto: Add ECDSA key parser

On 14/6/22 03:43, 何磊 wrote: Hi Philippe, lots of thanks for your review! On Jun 13, 2022, at 10:19 PM, Philippe Mathieu-Daudé wrote: On 13/6/22 10:45, Lei He wrote: Add ECDSA key parser and ECDSA signautre parser. Signed-off-by: lei he --- crypto/ecdsakey-builtin.c.inc | 248

Re: [PATCH 03/11] bsd-user: Implement revoke, access, eaccess and faccessat

On 12/6/22 22:48, Warner Losh wrote: Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/bsd-file.h | 53 +++ bsd-user/freebsd/os-syscall.c | 16 +++ 2 files changed, 69 insertions(+) diff --git a/bsd-user/bsd-file.h

Re: [PATCH v1 7/7] .gitlab: use less aggressive nproc on our aarch64/32 runners

On 13/6/22 19:12, Alex Bennée wrote: Running on all 80 cores of our aarch64 runner does occasionally trigger a race condition which fails the build. However the CI system is not the time and place to play with much heisenbugs so turn down the nproc to "only" use 40 cores in the build.

Re: [PATCH v1 5/7] tests/tcg: disable xtensa-linux-user again

On 13/6/22 19:12, Alex Bennée wrote: From: Paolo Bonzini The move from tests/tcg/configure.sh started enabling the container image for xtensa-linux-user, which fails because the compiler does not have the full set of headers. The cause is the "xtensa*-softmmu)" case in tests/tcg/configure.sh

Re: [PATCH 4/7] crypto: Add ECDSA key parser

On 13/6/22 10:45, Lei He wrote: Add ECDSA key parser and ECDSA signautre parser. Signed-off-by: lei he --- crypto/ecdsakey-builtin.c.inc | 248 ++ crypto/ecdsakey.c | 118 crypto/ecdsakey.h | 66

Re: [PATCH 3/7] crypto: remove "qemu/osdep.h" in rsakey.h

On 13/6/22 10:45, Lei He wrote: Move 'include "qemu/osdep.h"' from rsakey.h to rsakey.c. Signed-off-by: lei he --- crypto/rsakey.c | 1 + crypto/rsakey.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] hw/openrisc: pass random seed to fdt

On 13/6/22 12:58, Jason A. Donenfeld wrote: On 6/13/22, Stafford Horne wrote: On Sun, Jun 12, 2022 at 11:59:49PM +0200, Jason A. Donenfeld wrote: If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to initialize early. Set this using the usual guest random number generation

Re: [PATCH 45/50] lasips2: use qdev gpio for output IRQ

On 22/5/22 20:18, Mark Cave-Ayland wrote: This enables the IRQ to be wired up using qdev_connect_gpio_out() in lasips2_initfn(). Signed-off-by: Mark Cave-Ayland --- hw/input/lasips2.c | 8 include/hw/input/lasips2.h | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-)

Re: [PULL 00/49] MIPS patches for 2022-06-11

On Sat, Jun 11, 2022 at 12:33 PM Philippe Mathieu-Daudé wrote: > The following changes since commit 30796f556790631c86c733ab06756981be0e1def: > > Merge tag 'for_upstream' of git://git.kernel.org/pub/scm/virt/kvm/mst/qemu > into staging (2022-06-10 18:15:34 -0700) > > are available in the Git

Re: [PATCH] hw/mips/boston: Initialize g_autofree pointers

On Sat, Jun 11, 2022 at 5:27 PM Bernhard Beschow wrote: > On Fri, Jun 10, 2022 at 4:04 PM Philippe Mathieu-Daudé > wrote: >> On 5/6/22 17:19, Bernhard Beschow wrote: >> > Fixes compilation due to false positives with -Werror: >> > >> >In file included from /usr/include/glib-2.0/glib.h:114,

Re: [PATCH v4 00/11] QOM'ify PIIX southbridge creation

On 3/6/22 20:50, Bernhard Beschow wrote: Bernhard Beschow (11): hw/southbridge/piix: Aggregate all PIIX southbridge type names hw/isa/piix4: Use object_initialize_child() for embedded struct hw/isa/piix4: Move pci_map_irq_fn' near pci_set_irq_fn hw/isa/piix4: QOM'ify PCI device

Re: [PATCH v2 00/11] hw/acpi/piix4: remove legacy piix4_pm_init() function

On 6/6/22 12:56, Mark Cave-Ayland wrote: On 30/05/2022 12:27, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé This series moves the outstanding logic from piix4_pm_init() into the relevant instance init() and realize() functions, changes the IRQs to use qdev gpios, and then

Re: [PATCH 00/50] PS2 device QOMification - part 1

On Fri, Jun 10, 2022 at 5:43 PM Mark Cave-Ayland wrote: > > On 10/06/2022 16:35, Philippe Mathieu-Daudé wrote: > > > On 7/6/22 17:54, Mark Cave-Ayland wrote: > >> On 22/05/2022 19:17, Mark Cave-Ayland wrote: > >> > >>> This series came about when looking at improving the LASI PS2 device for > >>>

Re: [PULL 54/54] crypto: Introduce RSA algorithm

On 10/6/22 09:59, Michael S. Tsirkin wrote: From: zhenwei pi There are two parts in this patch: 1, support akcipher service by cryptodev-builtin driver 2, virtio-crypto driver supports akcipher service In principle, we should separate this into two patches, to avoid compiling error, merge

Re: [PATCH 00/50] PS2 device QOMification - part 1

On 7/6/22 17:54, Mark Cave-Ayland wrote: On 22/05/2022 19:17, Mark Cave-Ayland wrote: This series came about when looking at improving the LASI PS2 device for the HPPA machine: there were improvements that I was keen to make, but was restricted because the PS2 device(s) weren't QOMified.

Re: [PATCH v4 11/11] target/mips: Remove GET_TARGET_STRING and FREE_TARGET_STRING

On 8/6/22 07:19, Richard Henderson wrote: Inline these macros into the only two callers. Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v4 08/11] target/mips: Use error_report for UHI_assert

On 8/6/22 07:19, Richard Henderson wrote: Always log the assert locally. Do not report_fault, but instead include the fact of the fault in the assertion. Don't bother freeing allocated strings before the abort(). Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 39

Re: [PATCH v4 09/11] semihosting: Remove qemu_semihosting_log_out

On 8/6/22 07:19, Richard Henderson wrote: The function is no longer used. Signed-off-by: Richard Henderson --- include/semihosting/console.h | 13 - semihosting/console.c | 9 - 2 files changed, 22 deletions(-) diff --git a/include/semihosting/console.h

Re: [PATCH v4 01/11] target/mips: Use an exception for semihosting

On 8/6/22 07:19, Richard Henderson wrote: Within do_interrupt, we hold the iothread lock, which is required for Chardev access for the console, and for the round trip for use_gdb_syscalls(). Signed-off-by: Richard Henderson --- target/mips/cpu.h | 3 ++-

Re: [PATCH v4 02/11] target/mips: Add UHI errno values

On 8/6/22 07:19, Richard Henderson wrote: From the Unified Hosting Interface, MD01069 Reference Manual, version 1.1.6, 06 July 2015. Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 40 ++ 1 file changed, 40 insertions(+) Reviewed-by:

Re: [PATCH v4 05/11] target/mips: Drop pread and pwrite syscalls from semihosting

On 8/6/22 07:19, Richard Henderson wrote: We don't implement it with _WIN32 hosts, and the syscalls are missing from the gdb remote file i/o interface. Since we can't implement them universally, drop them. Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 39

Re: [PATCH v4 03/11] target/mips: Create report_fault for semihosting

Hi Richard, On 8/6/22 07:19, Richard Henderson wrote: The UHI specification does not have an EFAULT value, and further specifies that "undefined UHI operations should not return control to the target". So, log the error and abort. Signed-off-by: Richard Henderson ---

Re: [PATCH 0/7] Undeprecate nanoMIPS and fix multiple bugs

On 4/5/22 13:03, Stefan Pejic wrote: This series of patches aims to undeprecate nanoMIPS architecture and fix several issues that were found in recent testings. Dragan Mladjenovic (4): target/mips: Fix emulation of nanoMips EXTRV_S.H instruction target/mips: Fix emulation of nanoMips

Re: [PATCH 7/7] target/mips: Undeprecate nanoMips ISA support in QEMU

On 10/6/22 16:09, Philippe Mathieu-Daudé wrote: On 31/5/22 15:14, Philippe Mathieu-Daudé wrote: On 4/5/22 13:04, Stefan Pejic wrote: nanoMips ISA support in QEMU is actively used by MediaTek and is planned to be maintained and potentially extended by MediaTek in future. Un-orphan nanoMips ISA

Re: [PATCH 5/7] target/mips: Fix handling of unaligned memory access for nanoMips ISA

On 4/5/22 13:04, Stefan Pejic wrote: From: Dragan Mladjenovic nanoMips ISA does not support unaligned memory access. Adjust DisasContext's default_tcg_memop_mask to reflect this. Signed-off-by: Dragan Mladjenovic Signed-off-by: Stefan Pejic --- target/mips/tcg/translate.c | 5 +++-- 1

Re: [PATCH 7/7] target/mips: Undeprecate nanoMips ISA support in QEMU

Cc'ing Vince. On 31/5/22 15:14, Philippe Mathieu-Daudé wrote: Hi Stefan, On 4/5/22 13:04, Stefan Pejic wrote: nanoMips ISA support in QEMU is actively used by MediaTek and is planned to be maintained and potentially extended by MediaTek in future. Un-orphan nanoMips ISA support in QEMU by

Re: [PATCH] hw/mips/boston: Initialize g_autofree pointers

On 5/6/22 17:19, Bernhard Beschow wrote: Fixes compilation due to false positives with -Werror: In file included from /usr/include/glib-2.0/glib.h:114, from qemu/src/include/glib-compat.h:32, from qemu/src/include/qemu/osdep.h:144,

Re: [PATCH v3 0/3] QOM improvements for rtc/mc146818rtc

On 2/6/22 23:18, Bernhard Beschow wrote: Ping Am 29. Mai 2022 18:40:03 UTC schrieb Bernhard Beschow >: >v3: >* "iobase" is now u16 (Philippe) > >v2: >* Explicitly fail with _abort rather than NULL (Mark) >* Explicitly fail with _abort rather than NULL in

Re: [PATCH v4 2/3] target/nios2: Move nios2-semi.c to nios2_softmmu_ss

On 8/6/22 04:38, Richard Henderson wrote: Semihosting is not enabled for nios2-linux-user. Signed-off-by: Richard Henderson --- target/nios2/nios2-semi.c | 5 - target/nios2/meson.build | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v4 1/3] target/nios2: Eliminate nios2_semi_is_lseek

On 8/6/22 04:38, Richard Henderson wrote: Reorg nios2_semi_return_* to gdb_syscall_complete_cb. Use the 32-bit version normally, and the 64-bit version for HOSTED_LSEEK. Signed-off-by: Richard Henderson --- target/nios2/nios2-semi.c | 59 +++ 1 file

Re: [PATCH] qsd: Do not use error_report() before monitor_init

On 9/6/22 14:28, Hanna Reitz wrote: error_report() only works once monitor_init_globals_core() has been called, which is not the case when parsing the --daemonize option. Use fprintf(stderr, ...) instead. Fixes: 2525edd85fec53e23fda98974a15e3b3c8957596 ("qsd: Add --daemonize") Signed-off-by:

Re: [PATCH v2 1/3] target/mips: introduce Cavium Octeon CPU model

Hi Pavel, On 9/6/22 10:23, Pavel Dovgalyuk wrote: This patch adds Cavium Octeon vCPU for providing Octeon-specific instructions. Signed-off-by: Pavel Dovgalyuk -- v2 changes: - vCPU name changed to Octeon68XX (suggested by Richard Henderson) --- target/mips/cpu-defs.c.inc | 28

Re: [PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size

On 9/6/22 23:41, Hao Wu wrote: Creating 1GB image for a simple qtest is unnecessary and could lead to failures. We reduce the image size to 1MB to reduce the test overhead. Signed-off-by: Hao Wu --- tests/qtest/npcm7xx_sdhci-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] avocado/boot_linux_console.py: Update ast2600 test

On 7/6/22 03:19, Joel Stanley wrote: Update the test_arm_ast2600_debian test to - the latest Debian kernel - use the Rainier machine instead of Tacoma Why can't we keep both? Both of which contains support for more hardware and thus exercises more of the hardware Qemu models. "QEMU"

Re: [PATCH] Hexagon (target/hexagon) make VyV operands use a unique temp

On 7/6/22 00:23, Taylor Simpson wrote: VyV operand is only used in the vshuff and vdeal instructions. These instructions write to both VyV and VxV operands. In the case where both operands are the same register, we need a separate location for VyV. We use the existing vtmp field in

Re: [PATCH] Hexagon (target/hexagon) remove unused encodings

On 7/6/22 00:23, Taylor Simpson wrote: Remove encodings guarded by ifdef that is not defined Signed-off-by: Taylor Simpson --- target/hexagon/imported/encode_pp.def | 23 --- 1 file changed, 23 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] hw/mips/boston: Initialize g_autofree pointers

On 5/6/22 17:19, Bernhard Beschow wrote: Fixes compilation due to false positives with -Werror: In file included from /usr/include/glib-2.0/glib.h:114, from qemu/src/include/glib-compat.h:32, from qemu/src/include/qemu/osdep.h:144,

Re: [PATCH] configure: remove reference to removed option

On 6/6/22 12:47, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index b9ccff9067..ac18ed4f3a 100755 --- a/configure +++ b/configure @@ -1035,7 +1035,6 @@ Advanced options (experts only):

Re: [PATCH] microvm: turn off io reservations for pcie root ports

On 3/6/22 10:59, Gerd Hoffmann wrote: The pcie host bridge has no io window on microvm, so io reservations will not work. Signed-off-by: Gerd Hoffmann --- hw/i386/microvm.c | 6 ++ 1 file changed, 6 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] test/tcg/arm: Use -mfloat-abi=soft for test-armv6m-undef

On 4/6/22 05:27, Richard Henderson wrote: GCC11 from crossbuild-essential-armhf from ubuntu 22.04 errors: cc1: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU Signed-off-by: Richard Henderson --- tests/tcg/arm/Makefile.softmmu-target | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] linux-user/x86_64: Fix ELF_PLATFORM

On 3/6/22 23:38, Richard Henderson wrote: We had been using the i686 platform string for x86_64. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1041 Signed-off-by: Richard Henderson --- linux-user/elfload.c | 30 +- 1 file changed, 17 insertions(+), 13

Re: [PATCH 01/28] target/arm: Move stage_1_mmu_idx decl to internals.h

On 4/6/22 06:05, Richard Henderson wrote: Move the decl from ptw.h to internals.h. Provide an inline version for user-only, just as we do for arm_stage1_mmu_idx. Move an endif down to make the definition in helper.c be system only. Signed-off-by: Richard Henderson --- target/arm/internals.h

Re: [PULL 32/33] gitlab: don't run CI jobs in forks by default

Cc'ing qemu-stable@ Thank you Daniel / Thomas / Alex! On 1/6/22 20:05, Alex Bennée wrote: From: Daniel P. Berrangé To preserve CI shared runner credits we don't want to run pipelines on every push. This sets up the config so that pipelines are never created for contributors by default. To

Re: [PATCH 1/1] block: use 'unsigned' for in_flight field on driver state

On 30/5/22 12:39, Denis V. Lunev wrote: This patch makes in_flight field 'unsigned' for BDRVNBDState and MirrorBlockJob. This matches the definition of this field on BDS and is generically correct - we should never get negative value here. Signed-off-by: Denis V. Lunev CC: John Snow CC:

Re: [PATCH] target/ppc: fix vbpermd in big endian hosts

+Mark for commit ef96e3ae96. On 1/6/22 14:53, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst The extract64 arguments are not endian dependent as they are only used for bitwise operations. The current behavior in little-endian hosts is correct; since the indexes in VRB are in

Re: Types?

Hi Kenneth, On 1/6/22 11:28, Kenneth Adam Miller wrote: Hello, I am working on a qemu target under development. and I am wondering how I should differentiate the MachineState from the MachineClass. Look at QOM documentation: https://qemu.readthedocs.io/en/latest/devel/qom.html MachineClass

Re: [PATCH] hw/intc: sifive_plic: Avoid overflowing the addr_config buffer

On 1/6/22 03:36, Alistair Francis wrote: From: Alistair Francis Since commit ad40be27 "target/riscv: Support start kernel directly by KVM" we have been overflowing the addr_config on "M,MS..." configurations, as reported https://gitlab.com/qemu-project/qemu/-/issues/1050. This commit changes

Re: [PATCH v2 1/1] Fix the coredump when memory backend id conflicts with default_ram_id

Cc'ing Igor On Fri, May 20, 2022 at 11:56 AM Li Zhang wrote: > > When no memory backend is specified in machine options, > a default memory device will be added with default_ram_id. > However, if a memory backend object is added in QEMU options > and id is the same as default_ram_id, a coredump

Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support

On 31/5/22 11:19, Cédric Le Goater wrote: On 5/30/22 21:37, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Rebase/respin of Cédric RFC: https://lore.kernel.org/qemu-devel/20220318132824.1134400-1-...@kaod.org/ (sorry it took me so long guys...) Pushed at

Re: [PATCH 7/7] target/mips: Undeprecate nanoMips ISA support in QEMU

Hi Stefan, On 4/5/22 13:04, Stefan Pejic wrote: nanoMips ISA support in QEMU is actively used by MediaTek and is planned to be maintained and potentially extended by MediaTek in future. Un-orphan nanoMips ISA support in QEMU by setting a mainainer from MediaTek and remove deprecation notes

Re: [PATCH] hw/sd/sdhci: Block Size Register bits [14:12] is lost

On 21/3/22 06:56, Lu Gao wrote: Block Size Register bits [14:12] is SDMA Buffer Boundary, it is missed in register write, but it is needed in SDMA transfer. e.g. it will be used in sdhci_sdma_transfer_multi_blocks to calculate boundary_ variables. Missing this field will cause wrong operation

<    1   2   3   4   5   6   7   8   9   10   >