[RFC PATCH] block/export/fuse: Fix build failure on FreeBSD

2022-01-22 Thread Philippe Mathieu-Daudé via
When building on FreeBSD we get: [816/6851] Compiling C object libblockdev.fa.p/block_export_fuse.c.o ../block/export/fuse.c:628:16: error: use of undeclared identifier 'FALLOC_FL_KEEP_SIZE' if (mode & FALLOC_FL_KEEP_SIZE) { ^ ../block/export/fuse.c:632:16: error: use

Re: [PATCH] hw/char/exynos4210_uart: Fix crash on trying to load VM state

2022-01-22 Thread Philippe Mathieu-Daudé via
On 20/1/22 16:16, Peter Maydell wrote: The exynos4210_uart_post_load() function assumes that it is passed the Exynos4210UartState, but it has been attached to the VMStateDescription for the Exynos4210UartFIFO type. The result is a SIGSEGV when attempting to load VM state for any machine type inc

Re: [PATCH] configure: fix parameter expansion of --cross-cc-cflags options

2022-01-22 Thread Philippe Mathieu-Daudé via
On 20/1/22 18:31, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Without this fix, any use of --cross-cc-cflags-* causes a message like: $ ../configure --cross-cc-ppc64le=clang --cross-cc-cflags-ppc64le="-target powerpc64le-unknown-linux-gnu -sysroot ..." ../configure: 1: eval: cross

Re: [PATCH v2] hw/nvme: fix CVE-2021-3929

2022-01-22 Thread Philippe Mathieu-Daudé via
On 21/1/22 07:32, Klaus Jensen wrote: From: Klaus Jensen This fixes CVE-2021-3929 "locally" by denying DMA to the iomem of the device itself. This still allows DMA to MMIO regions of other devices (e.g. doing P2P DMA to the controller memory buffer of another NVMe device). Fixes: CVE-2021-3929

Re: [PATCH] docs: expand firmware descriptor to allow flash without NVRAM

2022-01-22 Thread Philippe Mathieu-Daudé via
+Gerd & David. On 21/1/22 16:34, Daniel P. Berrangé wrote: The current firmware descriptor schema for flash requires that both the executable to NVRAM template paths be provided. This is fine for the most common usage of EDK2 builds in virtualization where the separate _CODE and _VARS files are

[PATCH] hw/remote: Add missing include

2022-01-21 Thread Philippe Mathieu-Daudé via
Currently "qemu/error-report.h" is implicitly included, however if headers in include/ get refactored, we get: hw/remote/proxy-memory-listener.c: In function ‘proxy_memory_listener_commit’: hw/remote/proxy-memory-listener.c:183:9: error: implicit declaration of function ‘error_report’; did yo

[PATCH] target/rx: Remove unused ENV_OFFSET definition

2022-01-21 Thread Philippe Mathieu-Daudé via
Signed-off-by: Philippe Mathieu-Daudé --- target/rx/cpu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/rx/cpu.h b/target/rx/cpu.h index 657db84ef0..58adf9edf6 100644 --- a/target/rx/cpu.h +++ b/target/rx/cpu.h @@ -116,8 +116,6 @@ struct RXCPU { typedef RXCPU ArchCPU; -#define

[PATCH] hw/ppc/vof: Add missing includes

2022-01-21 Thread Philippe Mathieu-Daudé via
vof.h requires "qom/object.h" for DECLARE_CLASS_CHECKERS(), "exec/memory.h" for address_space_read/write(), "exec/address-spaces.h" for address_space_memory and more importantly "cpu.h" for target_ulong. vof.c doesn't need "exec/ram_addr.h". Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/vof.

[PATCH] target/avr: Correct AVRCPUClass docstring

2022-01-21 Thread Philippe Mathieu-Daudé via
There is no 'vr' field in AVRCPUClass. Likely a copy/paste typo from CRISCPUClass ;) Signed-off-by: Philippe Mathieu-Daudé --- target/avr/cpu-qom.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target/avr/cpu-qom.h b/target/avr/cpu-qom.h index 9fa6989c18..14e5b3ce72 100644 --- a/target/avr

[PATCH] meson: Use find_program() to resolve the entitlement.sh script

2022-01-21 Thread Philippe Mathieu-Daudé via
Using ../configure without any particular option generates 31 targets on Darwin, and meson search for the entitlement.sh script 31 times: Program nm found: YES Program scripts/undefsym.py found: YES (/opt/homebrew/opt/python@3.9/bin/python3.9 /Code/qemu/scripts/undefsym.py) Program scripts/

[PATCH] hw/display/tcx: Avoid clearing dirty bitmap in DeviceReset()

2022-01-21 Thread Philippe Mathieu-Daudé via
Commit 2dd285b5f3 ("tcx: make display updates thread safe") converted this model to use the DirtyBitmapSnapshot API, resetting the dirty bitmap in tcx_update_display(). There is no need to do it again in the DeviceReset handler. See more details in commit fec5e8c92b ("vga: make display updates thr

Re: tests/tcg/multiarch/threadcount failing on GitLab

2022-01-21 Thread Philippe Mathieu-Daudé via
On 21/1/22 21:54, John Snow wrote: On Fri, Jan 21, 2022 at 3:53 PM John Snow wrote: lately, I've been seeing this test fail under the clang-user job; see https://gitlab.com/jsnow/qemu/-/jobs/2002782042 make[2]: *** [../Makefile.target:156: run-threadcount] Error 124 make[1]: *** [/builds/jsno

Re: [PATCH 0/2] some simplifications in hw/core/fw-path-provider.c

2022-01-21 Thread Philippe Mathieu-Daudé via
On 21/1/22 21:29, Daniel Henrique Barboza wrote: Hi, These are somes simplifications I found interesting to make while I was investigating Gitlab #720. It isn't clear in the MAINTAINERS file who is responsible for this file, so I'm ccing the QOM maintainers since it's the closest match. Danie

Re: [PATCH] hw/armv7m: Fix broken VMStateDescription

2022-01-21 Thread Philippe Mathieu-Daudé via
On 20/1/22 16:16, Peter Maydell wrote: In commit d5093d961585f02 we added a VMStateDescription to the TYPE_ARMV7M object, to handle migration of its Clocks. However a cut-and-paste error meant we used the wrong struct name in the VMSTATE_CLOCK() macro arguments. The result was that attempting a '

[PATCH v6 5/7] tests/lcitool: Refresh submodule and remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
The previous commit removed all uses of libxml2. Refresh lcitool submodule, update qemu.yml and refresh the generated files by running: $ make lcitool-refresh Note: This refreshment also removes libudev dependency on Fedora and CentOS due to libvirt-ci commit 18bfaee ("mappings: Improve mappin

[PATCH v6 4/7] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-21 Thread Philippe Mathieu-Daudé via
From: Michael Tokarev For a long time, we assumed that libxml2 is necessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in whole QEMU tree, we can drop all libxml2 checks and dependencies too.

[PATCH v6 7/7] tests/lcitool: Install libibumad to cover RDMA on Debian based distros

2022-01-21 Thread Philippe Mathieu-Daudé via
On Debian we also need libibumad to enable RDMA: $ ../configure --enable-rdma ERROR: OpenFabrics librdmacm/libibverbs/libibumad not present. Your options: (1) Fast: Install infiniband packages (devel) from your distro. (2) Cleanest: Install libraries from www.

[PATCH v6 2/7] gitmodules: Correct libvirt-ci submodule URL

2022-01-21 Thread Philippe Mathieu-Daudé via
Correct the libvirt-ci repository URL to avoid this warning when cloning / refreshing the submodule: warning: redirecting to https://gitlab.com/libvirt/libvirt-ci.git/ Fixes: 4ebb040f1fd ("tests: integrate lcitool for generating build env manifests") Reviewed-by: Daniel P. Berrangé Reviewed-b

[PATCH v6 3/7] tests/lcitool: Include local qemu.yml when refreshing cirrus-ci files

2022-01-21 Thread Philippe Mathieu-Daudé via
The script only include the local qemu.yml for Dockerfiles. Since we want to keep the Cirrus-CI generated files in sync, also use the --data-dir option in generate_cirrus(). Fixes: c45a540f4bd (".gitlab-ci.d/cirrus: auto-generate variables with lcitool") Reported-by: Daniel P. Berrangé Reviewed-b

Re: [PATCH v4 4/8] tests: Refresh lcitool submodule

2022-01-21 Thread Philippe Mathieu-Daudé via
On 1/21/22 15:34, Daniel P. Berrangé wrote: > On Fri, Jan 21, 2022 at 07:30:55AM -0700, Warner Losh wrote: >> On Fri, Jan 21, 2022 at 4:47 AM Daniel P. Berrangé >> wrote: >> >>> On Fri, Jan 21, 2022 at 12:40:48PM +0100, Thomas Huth wrote: On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: >>>

[PATCH v6 6/7] tests: Manually remove libxml2 on MSYS2 runners

2022-01-21 Thread Philippe Mathieu-Daudé via
lcitool doesn't support MSYS2 targets, so manually remove this now unnecessary library. Reviewed-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- .cirrus.yml | 1 - .gitlab-ci.d/windows.yml | 2 -- 2 files changed, 3 deletions(-) diff --gi

[PATCH v6 0/7] tests: Refresh lcitool submodule & remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
This is my last respin on this series which is fully reviewed. Refresh lcitool to latest and remove libxml2 (mjt). v6: - update libvirt-ci submodule to remove lttng-ust from FreeBSD runners v5: - update scripts/meson-buildoptions.sh (thuth) - squash libvirt-ci updates (thuth) v4: - Fixed typos

[PATCH v6 1/7] MAINTAINERS: Cover lcitool submodule with build test / automation

2022-01-21 Thread Philippe Mathieu-Daudé via
lcitool is used by build test / automation, we want maintainers to get notified if the submodule is updated. Reviewed-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAIN

[PATCH v5 7/7] tests/lcitool: Install libibumad to cover RDMA on Debian based distros

2022-01-21 Thread Philippe Mathieu-Daudé via
On Debian we also need libibumad to enable RDMA: $ ../configure --enable-rdma ERROR: OpenFabrics librdmacm/libibverbs/libibumad not present. Your options: (1) Fast: Install infiniband packages (devel) from your distro. (2) Cleanest: Install libraries from www.

[PATCH v5 5/7] tests/lcitool: Refresh submodule and remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
The previous commit removed all uses of libxml2. Refresh lcitool submodule, update qemu.yml and refresh the generated files by running: $ make lcitool-refresh Note: This refreshment also removes libudev dependency on Fedora and CentOS due to libvirt-ci commit 18bfaee ("mappings: Improve mappin

[PATCH v5 6/7] tests: Manually remove libxml2 on MSYS2 runners

2022-01-21 Thread Philippe Mathieu-Daudé via
lcitool doesn't support MSYS2 targets, so manually remove this now unnecessary library. Reviewed-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- .cirrus.yml | 1 - .gitlab-ci.d/windows.yml | 2 -- 2 files changed, 3 deletions(-) diff --gi

[PATCH v5 1/7] MAINTAINERS: Cover lcitool submodule with build test / automation

2022-01-21 Thread Philippe Mathieu-Daudé via
lcitool is used by build test / automation, we want maintainers to get notified if the submodule is updated. Reviewed-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAIN

[PATCH v5 0/7] tests: Refresh lcitool submodule & remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
Series fully reviewed. Refresh lcitool to latest and remove libxml2 (mjt). v5: - update scripts/meson-buildoptions.sh (thuth) - squash libvirt-ci updates (thuth) v4: - Fixed typos and cleaned checkpatch.pl (thuth) - Corrected libvirt-ci submodule URL v3: - fix 'refresh' helper to update cirrus-

[PATCH v5 2/7] gitmodules: Correct libvirt-ci submodule URL

2022-01-21 Thread Philippe Mathieu-Daudé via
Correct the libvirt-ci repository URL to avoid this warning when cloning / refreshing the submodule: warning: redirecting to https://gitlab.com/libvirt/libvirt-ci.git/ Fixes: 4ebb040f1fd ("tests: integrate lcitool for generating build env manifests") Reviewed-by: Daniel P. Berrangé Reviewed-b

[PATCH v5 3/7] tests/lcitool: Include local qemu.yml when refreshing cirrus-ci files

2022-01-21 Thread Philippe Mathieu-Daudé via
The script only include the local qemu.yml for Dockerfiles. Since we want to keep the Cirrus-CI generated files in sync, also use the --data-dir option in generate_cirrus(). Fixes: c45a540f4bd (".gitlab-ci.d/cirrus: auto-generate variables with lcitool") Reported-by: Daniel P. Berrangé Reviewed-b

[PATCH v5 4/7] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-21 Thread Philippe Mathieu-Daudé via
From: Michael Tokarev For a long time, we assumed that libxml2 is necessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in whole QEMU tree, we can drop all libxml2 checks and dependencies too.

Re: [PATCH v4 7/8] tests/lcitool: Remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
On 1/21/22 12:47, Thomas Huth wrote: > On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: >> The previous commit removed all uses of libxml2. >> >> Update lcitool's qemu.yml and refresh the generated files by running: >> >>    $ make lcitool-refresh > > Could you merge patch 4/8 and 7/8 so that th

Re: [PATCH v4 2/8] gitmodules: Correct libvirt-ci URL

2022-01-21 Thread Philippe Mathieu-Daudé via
On 1/21/22 11:36, Philippe Mathieu-Daudé wrote: > Correct the libvirt-ci repository URL to avoid this warning when > cloning / refreshing the submodule: > > warning: redirecting to https://gitlab.com/libvirt/libvirt-ci.git/ > > Fixes: 4ebb040f1fd ("tests: integrate lcitool for generating build

[PATCH v4 7/8] tests/lcitool: Remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
The previous commit removed all uses of libxml2. Update lcitool's qemu.yml and refresh the generated files by running: $ make lcitool-refresh Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +- .gitlab-ci.d/cirrus/f

[PATCH v4 3/8] tests/lcitool: Include local qemu.yml when refreshing cirrus-ci files

2022-01-21 Thread Philippe Mathieu-Daudé via
The script only include the local qemu.yml for Dockerfiles. Since we want to keep the Cirrus-CI generated files in sync, also use the --data-dir option in generate_cirrus(). Fixes: c45a540f4bd (".gitlab-ci.d/cirrus: auto-generate variables with lcitool") Reported-by: Daniel P. Berrangé Reviewed-b

[PATCH v4 2/8] gitmodules: Correct libvirt-ci URL

2022-01-21 Thread Philippe Mathieu-Daudé via
Correct the libvirt-ci repository URL to avoid this warning when cloning / refreshing the submodule: warning: redirecting to https://gitlab.com/libvirt/libvirt-ci.git/ Fixes: 4ebb040f1fd ("tests: integrate lcitool for generating build env manifests") Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v4 1/8] MAINTAINERS: Cover lcitool submodule with build test / automation

2022-01-21 Thread Philippe Mathieu-Daudé via
lcitool is used by build test / automation, we want maintainers to get notified if the submodule is updated. Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e4b3a4bcdf4..6d5

[PATCH v4 6/8] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-21 Thread Philippe Mathieu-Daudé via
From: Michael Tokarev For a long time, we assumed that libxml2 is necessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in whole QEMU tree, we can drop all libxml2 checks and dependencies too.

Re: [PATCH v3 5/7] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-21 Thread Philippe Mathieu-Daudé via
On 1/20/22 12:30, Philippe Mathieu-Daudé wrote: > From: Michael Tokarev > > For a long time, we assumed that libxml2 is neecessary for parallels > block format support (block/parallels*). However, this format actually > does not use libxml [*]. Since this is the only user of libxml2 in > while qe

[PATCH v4 5/8] tests/lcitool: Install libibumad to cover RDMA on Debian based distros

2022-01-21 Thread Philippe Mathieu-Daudé via
On Debian we also need libibumad to enable RDMA: $ ../configure --enable-rdma ERROR: OpenFabrics librdmacm/libibverbs/libibumad not present. Your options: (1) Fast: Install infiniband packages (devel) from your distro. (2) Cleanest: Install libraries from www.

[PATCH v4 4/8] tests: Refresh lcitool submodule

2022-01-21 Thread Philippe Mathieu-Daudé via
Refresh lcitool submodule and the generated files by running: $ make lcitool-refresh Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +- .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +- tests/docker/dockerfiles/

Re: [PATCH v1] include: hw: remove ibex_plic.h

2022-01-21 Thread Philippe Mathieu-Daudé via
On 1/21/22 06:50, Alistair Francis wrote: > From: Wilfred Mallawa > > This patch removes the left-over/unused `ibex_plic.h` file. Previously > used by opentitan, which now follows the RISC-V standard and uses the > SiFivePlicState. > > Fixes: 434e7e021 ("hw/intc: Remove the Ibex PLIC") > Signed-

[PATCH v4 8/8] tests: Manually remove libxml2 on MSYS2 runners

2022-01-21 Thread Philippe Mathieu-Daudé via
lcitool doesn't support MSYS2 targets, so manually remove this now unnecessary library. Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- .cirrus.yml | 1 - .gitlab-ci.d/windows.yml | 2 -- 2 files changed, 3 deletions(-) diff --git a/.cirrus.yml b/.cirrus.

[PATCH v4 0/8] tests: Refresh lcitool submodule & remove libxml2

2022-01-21 Thread Philippe Mathieu-Daudé via
Missing review: Patch #2 (new) Refresh lcitool to latest and remove libxml2 (mjt). v4: - Fixed typos and cleaned checkpatch.pl (thuth) - Corrected libvirt-ci submodule URL v3: - fix 'refresh' helper to update cirrus-ci files (danpb) v2: - rebased (testing/next) - include mjt's libxml2 removal p

Re: [PATCH] Update copyright dates to 2022

2022-01-20 Thread Philippe Mathieu-Daudé via
On 1/20/22 13:47, Peter Maydell wrote: > It's a new year; update the copyright strings for our > help/version/about information and for our documentation. > > Signed-off-by: Peter Maydell > --- > For once I remembered to do this in January :-) > > I suppose at some point we should try to arrange

Re: [PATCH v2 4/6] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-20 Thread Philippe Mathieu-Daudé via
On 20/1/22 14:37, Thomas Huth wrote: On 20/01/2022 12.05, Philippe Mathieu-Daudé wrote: From: Michael Tokarev For a long time, we assumed that libxml2 is neecessary for parallels Also "necessary", block format support (block/parallels*). However, this format actually does not use libxml [*

Re: [PATCH v2] qapi: Cleanup SGX related comments and restore @section-size

2022-01-20 Thread Philippe Mathieu-Daudé via
On 20/1/22 10:10, Daniel P. Berrangé wrote: On Wed, Jan 19, 2022 at 06:57:20PM -0500, Yang Zhong wrote: The SGX NUMA patches were merged into Qemu 7.0 release, we need clarify detailed version history information and also change some related comments, which make SGX related comments clearer. Th

Re: [PATCH v2] qapi: Cleanup SGX related comments and restore @section-size

2022-01-20 Thread Philippe Mathieu-Daudé via
On 20/1/22 16:40, Daniel P. Berrangé wrote: On Thu, Jan 20, 2022 at 04:31:14PM +0100, Philippe Mathieu-Daudé wrote: On 20/1/22 10:10, Daniel P. Berrangé wrote: On Wed, Jan 19, 2022 at 06:57:20PM -0500, Yang Zhong wrote: The SGX NUMA patches were merged into Qemu 7.0 release, we need clarify de

Re: "make check-acceptance" takes way too long

2022-01-20 Thread Philippe Mathieu-Daudé via
Cc'ing Beraldo On 20/1/22 16:13, Peter Maydell wrote: On Fri, 30 Jul 2021 at 16:12, Peter Maydell wrote: "make check-acceptance" takes way way too long. I just did a run on an arm-and-aarch64-targets-only debug build and it took over half an hour, and this despite it skipping or cancelling 26

Re: [PATCH v3] qapi: Cleanup SGX related comments and restore @section-size

2022-01-20 Thread Philippe Mathieu-Daudé via
On 20/1/22 23:31, Yang Zhong wrote: The SGX NUMA patches were merged into Qemu 7.0 release, we need clarify detailed version history information and also change some related comments, which make SGX related comments clearer. The QMP command schema promises backwards compatibility as standard. We

Re: [PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-20 Thread Philippe Mathieu-Daudé via
On 18/1/22 19:04, John Snow wrote: On Tue, Jan 18, 2022 at 5:06 AM Daniel P. Berrangé wrote: It would be nice to just have this integrated into 'make check' so we don't need to remember to run a special command. The CI will run it, but 'make check' doesn't. To add it to make check, I need t

[PATCH v3 2/7] tests/lcitool: Include local qemu.yml when refreshing cirrus-ci files

2022-01-20 Thread Philippe Mathieu-Daudé via
The script only include the local qemu.yml for Dockerfiles. Since we want to keep the Cirrus-CI generated files in sync, also use the --data-dir option in generate_cirrus(). Fixes: c45a540f4bd (".gitlab-ci.d/cirrus: auto-generate variables with lcitool") Reported-by: Daniel P. Berrangé Signed-off

[PATCH v3 1/7] MAINTAINERS: Cover lcitool submodule with build test / automation

2022-01-20 Thread Philippe Mathieu-Daudé via
lcitool is used by build test / automation, we want maintainers to get notified if the submodule is updated. Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 893a5567100..fb7

[PATCH v3 3/7] tests: Refresh lcitool submodule

2022-01-20 Thread Philippe Mathieu-Daudé via
Refresh lcitool submodule and the generated files by running: $ make lcitool-refresh Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +- .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +- tests/docker/dockerfiles/

[PATCH v3 4/7] tests/lcitool: Install libibumad to cover RDMA on Debian based distros

2022-01-20 Thread Philippe Mathieu-Daudé via
On Debian we also need libibumad to enable RDMA: $ ../configure --enable-rdma ERROR: OpenFabrics librdmacm/libibverbs/libibumad not present. Your options: (1) Fast: Install infiniband packages (devel) from your distro. (2) Cleanest: Install libraries from www.

[PATCH v3 7/7] tests: Manually remove libxml2 on MSYS2 runners

2022-01-20 Thread Philippe Mathieu-Daudé via
lcitool doesn't support MSYS2 targets, so manually remove this now unnecessary library. Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- .cirrus.yml | 1 - .gitlab-ci.d/windows.yml | 2 -- 2 files changed, 3 deletions(-) diff --git a/.cirrus.yml b/.cirrus.

[PATCH v3 5/7] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-20 Thread Philippe Mathieu-Daudé via
From: Michael Tokarev For a long time, we assumed that libxml2 is neecessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in while qemu tree, we can drop all libxml2 checks and dependencies too

Re: [PATCH v2 5/6] tests/lcitool: Remove libxml2

2022-01-20 Thread Philippe Mathieu-Daudé via
On 1/20/22 12:14, Daniel P. Berrangé wrote: > On Thu, Jan 20, 2022 at 12:05:44PM +0100, Philippe Mathieu-Daudé wrote: >> The previous commit removed all uses of libxml2. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> tests/docker/dockerfiles/alpine.docker| 1 - >> tests/docker/dock

[PATCH v2 4/6] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-20 Thread Philippe Mathieu-Daudé via
From: Michael Tokarev For a long time, we assumed that libxml2 is neecessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in while qemu tree, we can drop all libxml2 checks and dependencies too

Re: [PATCH v2 5/6] tests/lcitool: Remove libxml2

2022-01-20 Thread Philippe Mathieu-Daudé via
On 1/20/22 12:05, Philippe Mathieu-Daudé wrote: > The previous commit removed all uses of libxml2. Here I will amend: Update lcitool's qemu.yml and refresh the generated files by running: $ make lcitool-refresh > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/alp

[PATCH v3 6/7] tests/lcitool: Remove libxml2

2022-01-20 Thread Philippe Mathieu-Daudé via
The previous commit removed all uses of libxml2. Update lcitool's qemu.yml and refresh the generated files by running: $ make lcitool-refresh Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +- .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +-

[PATCH v3 0/7] tests: Refresh lcitool submodule & remove libxml2

2022-01-20 Thread Philippe Mathieu-Daudé via
Refresh lcitool to latest and remove libxml2 (mjt). v3: - fix 'refresh' helper to update cirrus-ci files (danpb) v2: - rebased (testing/next) - include mjt's libxml2 removal patch Michael Tokarev (1): drop libxml2 checks since libxml is not actually used (for parallels) Philippe Mathieu-Daudé

[PATCH v2 6/6] tests: Manually remove libxml2 on MSYS2 targets

2022-01-20 Thread Philippe Mathieu-Daudé via
lcitool doesn't support MSYS2 targets, so manually remove this now unnecessary library. Signed-off-by: Philippe Mathieu-Daudé --- .cirrus.yml | 1 - .gitlab-ci.d/windows.yml | 2 -- 2 files changed, 3 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 02c43a074a1..7552d70974

Re: [PATCH v2 5/6] tests/lcitool: Remove libxml2

2022-01-20 Thread Philippe Mathieu-Daudé via
(+Andrea) On 1/20/22 12:18, Philippe Mathieu-Daudé wrote: > On 1/20/22 12:14, Daniel P. Berrangé wrote: >> On Thu, Jan 20, 2022 at 12:05:44PM +0100, Philippe Mathieu-Daudé wrote: >>> The previous commit removed all uses of libxml2. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> tests/

[PATCH v2 2/6] tests: Refresh lcitool submodule

2022-01-20 Thread Philippe Mathieu-Daudé via
Refresh lcitool submodule and the generated files by running: $ make lcitool-refresh Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/alpine.docker| 3 ++- tests/docker/dockerfiles/centos8.docker | 3 +-- tests/docker/dockerfile

[PATCH v2 5/6] tests/lcitool: Remove libxml2

2022-01-20 Thread Philippe Mathieu-Daudé via
The previous commit removed all uses of libxml2. Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/alpine.docker| 1 - tests/docker/dockerfiles/centos8.docker | 1 - tests/docker/dockerfiles/fedora.docker| 1 - tests/docker/dockerfiles/opensuse-leap.docker

[PATCH v2 0/6] tests: Refresh lcitool submodule & remove libxml2

2022-01-20 Thread Philippe Mathieu-Daudé via
Refresh lcitool to latest and remove libxml2 (mjt). v2: - rebased (testing/next) - include mjt's libxml2 removal patch Supersedes: <20220110124638.610145-1-f4...@amsat.org> Michael Tokarev (1): drop libxml2 checks since libxml is not actually used (for parallels) Philippe Mathieu-Daudé (5):

Re: [PATCH v2 6/6] tests: Manually remove libxml2 on MSYS2 targets

2022-01-20 Thread Philippe Mathieu-Daudé via
Oops, 's/targets/runners/' in Subject... On 1/20/22 12:05, Philippe Mathieu-Daudé wrote: > lcitool doesn't support MSYS2 targets, so manually remove > this now unnecessary library. > > Signed-off-by: Philippe Mathieu-Daudé > --- > .cirrus.yml | 1 - > .gitlab-ci.d/windows.yml | 2 -

[PATCH v2 1/6] MAINTAINERS: Cover lcitool submodule with build test / automation

2022-01-20 Thread Philippe Mathieu-Daudé via
lcitool is used by build test / automation, we want maintainers to get notified if the submodule is updated. Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 893a5567100..fb7

[PATCH v2 3/6] tests/lcitool: Install libibumad to cover RDMA on Debian based distros

2022-01-20 Thread Philippe Mathieu-Daudé via
On Debian we also need libibumad to enable RDMA: $ ../configure --enable-rdma ERROR: OpenFabrics librdmacm/libibverbs/libibumad not present. Your options: (1) Fast: Install infiniband packages (devel) from your distro. (2) Cleanest: Install libraries from www.

Re: [PATCH 1/1] Allow setting up to 8 bytes with the generic loader

2022-01-20 Thread Philippe Mathieu-Daudé via
On 1/20/22 10:27, Petr Tesarik wrote: > The documentation for the generic loader says that "the maximum size of > the data is 8 bytes". However, attempts to set data-len=8 trigger the > following assertion failure: > > ../hw/core/generic-loader.c:59: generic_loader_reset: Assertion `s->data_len >

Re: [PATCH v2] qapi: Cleanup SGX related comments and restore @section-size

2022-01-19 Thread Philippe Mathieu-Daudé via
+Markus for QAPI deprecation On 1/20/22 00:57, Yang Zhong wrote: > The SGX NUMA patches were merged into Qemu 7.0 release, we need > clarify detailed version history information and also change > some related comments, which make SGX related comments clearer. > > The QMP command schema promises b

[PATCH v3 1/2] tpm: CRB: Use ram_device for "tpm-crb-cmd" region

2022-01-19 Thread Philippe Mathieu-Daudé via
From: Eric Auger Representing the CRB cmd/response buffer as a standard RAM region causes some trouble when the device is used with VFIO. Indeed VFIO attempts to DMA_MAP this region as usual RAM but this latter does not have a valid page size alignment causing such an error report: "vfio_listener

[PATCH v3 2/2] hw/vfio/common: Silence ram device offset alignment error traces

2022-01-19 Thread Philippe Mathieu-Daudé via
From: Eric Auger Failing to DMA MAP a ram_device should not cause an error message. This is currently happening with the TPM CRB command region and this is causing confusion. We may want to keep the trace for debug purpose though. Signed-off-by: Eric Auger Tested-by: Stefan Berger Acked-by: A

[PATCH v3 0/2] tpm: CRB: Use ram_device for "tpm-crb-cmd" region

2022-01-19 Thread Philippe Mathieu-Daudé via
This is a respin of Eric's work, but not making tpm_crb.c target specific. Based-on: <2022012836.229419-1-f4...@amsat.org> "exec/cpu: Make host pages variables / macros 'target agnostic'" https://lore.kernel.org/qemu-devel/2022012836.229419-1-f4...@amsat.org/ -- Eric's v2 cover: This se

[PATCH] exec/cpu: Make host pages variables / macros 'target agnostic'

2022-01-19 Thread Philippe Mathieu-Daudé via
"host" pages are related to the *host* not the *target*, thus the qemu_host_page_size / qemu_host_page_mask variables and the HOST_PAGE_ALIGN() / REAL_HOST_PAGE_ALIGN() macros can be moved to "exec/cpu-common.h" which is target agnostic. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/cpu

Re: [PATCH] hw/nvram: use at24 macro

2022-01-19 Thread Philippe Mathieu-Daudé via
On 19/1/22 22:43, Patrick Venture wrote: Use the macro for going from I2CSlave to EEPROMState. Signed-off-by: Patrick Venture --- hw/nvram/eeprom_at24c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 1/2] tpm: CRB: Use ram_device for "tpm-crb-cmd" region

2022-01-19 Thread Philippe Mathieu-Daudé via
On 18/1/22 16:33, Eric Auger wrote: Representing the CRB cmd/response buffer as a standard RAM region causes some trouble when the device is used with VFIO. Indeed VFIO attempts to DMA_MAP this region as usual RAM but this latter does not have a valid page size alignment causing such an error rep

Re: [PATCH 0/2] tests: Refresh lcitool submodule

2022-01-19 Thread Philippe Mathieu-Daudé via
ping? (the testing/next queue this patch was depending on is now merged). On 1/10/22 13:46, Philippe Mathieu-Daudé wrote: > Refresh lcitool to latest. > > Based on Alex's testing/next > Based-on: <20220105135009.1584676-1-alex.ben...@linaro.org> > > Philippe Mathieu-Daudé (2): > MAINTAINERS:

Re: [PATCH 2/2] tests: Refresh lcitool submodule

2022-01-19 Thread Philippe Mathieu-Daudé via
On 1/19/22 18:33, Daniel P. Berrangé wrote: > On Mon, Jan 10, 2022 at 01:46:38PM +0100, Philippe Mathieu-Daudé wrote: >> Refresh lcitool submodule and the generated files by running: >> >> $ make lcitool-refresh >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> tests/docker/dockerfiles/alpi

Re: [RFC PATCH v3 1/3] hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR

2022-01-19 Thread Philippe Mathieu-Daudé via
Hi Peter, Can you take this single patch via your arm tree? Thanks, Phil. On 12/15/21 19:24, Philippe Mathieu-Daudé wrote: > Quoting Peter Maydell: > > "These MEMTX_* aren't from the memory transaction > API functions; they're just being used by gicd_readl() and > friends as a way to indi

Re: [PATCH] configure: Use -mlittle-endian instead of -mlittle for ppc64

2022-01-19 Thread Philippe Mathieu-Daudé via
On 1/19/22 12:13, Paolo Bonzini wrote: > On 1/19/22 10:56, mreza...@redhat.com wrote: >> From: Miroslav Rezanina >> >> GCC options -mlittle and -mlittle-endian are equivalent on ppc64 >> architecture. However, clang supports only -mlittle-endian option. >> >> Use longer form in configure to proper

[PATCH RESEND v2] qapi/block: Cosmetic change in BlockExportType schema

2022-01-19 Thread Philippe Mathieu-Daudé via
ee even if my email From: is "Philippe Mathieu-Daudé via ", the patch contains the correct From: and can be applied... --- qapi/block-export.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/block-export.json b/qapi/block-export.json index f9ce79a974b..f183

[PATCH RESEND] qapi/block: Cosmetic change in BlockExportType schema

2022-01-19 Thread Philippe Mathieu-Daudé via
"Philippe Mathieu-Daudé via ", the patch contains the correct From: and can be applied... --- qapi/block-export.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/block-export.json b/qapi/block-export.json index f9ce79a974b..f183522d0d2 100644 --- a/qapi/block-ex

[PATCH] qapi/block: Cosmetic change in BlockExportType schema

2022-01-19 Thread Philippe Mathieu-Daudé via
From: Philippe Mathieu-Daude From: Philippe Mathieu-Daudé Fix long line introduced in commit bb01ea73110 ("qapi/block: Restrict vhost-user-blk to CONFIG_VHOST_USER_BLK_SERVER"). Suggested-by: Markus Armbruster Acked-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- qapi/block

Re: [PATCH v2 1/2] target/riscv: iterate over a table of decoders

2022-01-19 Thread Philippe Mathieu-Daudé via
On 13/1/22 21:20, Philipp Tomsich wrote: To split up the decoder into multiple functions (both to support vendor-specific opcodes in separate files and to simplify maintenance of orthogonal extensions), this changes decode_op to iterate over a table of decoders predicated on guard functions. Thi

Re: [PATCH v2 2/2] target/riscv: Add XVentanaCondOps custom extension

2022-01-19 Thread Philippe Mathieu-Daudé via
On 13/1/22 21:20, Philipp Tomsich wrote: This adds the decoder and translation for the XVentanaCondOps custom extension (vendor-defined by Ventana Micro Systems), which is documented at https://github.com/ventanamicro/ventana-custom-extensions/releases/download/v1.0.0/ventana-custom-extensions-v

Re: [PATCH] meson.build: Use a function from libfdt 1.5.1 for the library check

2022-01-18 Thread Philippe Mathieu-Daudé via
On 18/1/22 18:05, Thomas Huth wrote: The fdt version test in meson.build uses a function from libfdt v1.4.7, but we require version 1.5.1 nowadays. Thus use a function that has been introduced in that version instead. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/822 Signed-off-by: Tho

Re: [PATCH v2 2/2] python: support recording QMP session to a file

2022-01-18 Thread Philippe Mathieu-Daudé via
On 1/18/22 11:01, Daniel P. Berrangé wrote: > When running QMP commands with very large response payloads, it is often > not easy to spot the info you want. If we can save the response to a > file then tools like 'grep' or 'jq' can be used to extract information. > Signed-off-by: Daniel P. Berrang

[PULL 12/19] hw/dma: Remove CONFIG_USER_ONLY check

2022-01-18 Thread Philippe Mathieu-Daudé via
From: Philippe Mathieu-Daudé DMA API should not be included in user-mode emulation. If so, build should fail. Remove the CONFIG_USER_ONLY check. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <2022084309.28637-6-f4...@amsat.

[PULL 17/19] hw/dma: Use dma_addr_t type definition when relevant

2022-01-18 Thread Philippe Mathieu-Daudé via
From: Philippe Mathieu-Daudé Update the obvious places where dma_addr_t should be used (instead of uint64_t, hwaddr, size_t, int32_t types). This allows to have &dma_addr_t type portable on 32/64-bit hosts. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand Signed-off-by: Ph

[PULL 15/19] hw/dma: Fix format string issues using dma_addr_t

2022-01-18 Thread Philippe Mathieu-Daudé via
Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Signed-off-by: Philippe Mathieu-Daudé Message-Id: <2022084309.28637-10-f4...@amsat.org> --- hw/ide/ahci.c| 2 +- hw/rdma/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/ahci.c b/

[PULL 14/19] hw/scsi: Rename SCSIRequest::resid as 'residual'

2022-01-18 Thread Philippe Mathieu-Daudé via
From: Philippe Mathieu-Daudé The 'resid' field is slightly confusing and could be interpreted as some ID. Rename it as 'residual' which is clearer to review. No logical change. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <202

[PULL 18/19] hw/dma: Let dma_buf_read() / dma_buf_write() propagate MemTxResult

2022-01-18 Thread Philippe Mathieu-Daudé via
From: Philippe Mathieu-Daudé Since commit 292e13142d2, dma_buf_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Pass the previously returned value (the QEMUSGList residual size, which was rarely used) as an optional argument. With this new API, SCSIRequest::residual m

[PULL 19/19] docs/devel: add some clarifying text for aliases

2022-01-18 Thread Philippe Mathieu-Daudé via
From: Alex Bennée We do mention the limitation of single parenthood for memory_region_add_subregion but lets also make it clear how aliases help solve that conundrum. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220110175104.2908956-7-alex.ben...@linaro.org> Si

[PULL 09/19] hw/nvram: Restrict fw_cfg QOM interface to sysemu and tools

2022-01-18 Thread Philippe Mathieu-Daudé via
From: Philippe Mathieu-Daudé fw_cfg QOM interface is required by system emulation and qemu-storage-daemon. User-mode emulation doesn't need it. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand Message-Id: <2022084309.28637-3-f4...@

[PULL 08/19] stubs: Restrict fw_cfg to system emulation

2022-01-18 Thread Philippe Mathieu-Daudé via
fw_cfg_arch_key_name() stub is only required for sysemu. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand Message-Id: <2022084309.28637-2-f4...@amsat.org> --- stubs/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/meson.build b/stubs/

[PULL 06/19] memory: Update description of memory_region_is_mapped()

2022-01-18 Thread Philippe Mathieu-Daudé via
From: David Hildenbrand Let's update the documentation, making it clearer what the semantics of memory_region_is_mapped() actually are. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu Signed-off-by: David Hildenbrand Message-Id: <20211102164317.45658-4-da...@redhat.com> Signed-off-b

[PULL 02/19] memory: Split mtree_info() as mtree_info_flatview() + mtree_info_as()

2022-01-18 Thread Philippe Mathieu-Daudé via
From: Philippe Mathieu-Daudé While mtree_info() handles both ASes and flatviews cases, the two cases share basically no code. Split mtree_info() as mtree_info_flatview() + mtree_info_as() to simplify. Suggested-by: Peter Maydell Reviewed-by: David Hildenbrand Reviewed-by: Peter Xu Reviewed-by

[PULL 03/19] memory: Have 'info mtree' remove duplicated Address Space information

2022-01-18 Thread Philippe Mathieu-Daudé via
From: Philippe Mathieu-Daudé Per Peter Maydell [*]: 'info mtree' monitor command was designed on the assumption that there's really only one or two interesting address spaces, and with more recent developments that's just not the case any more. Similarly about how the FlatView are sorted

<    5   6   7   8   9   10   11   >