Re: [PATCH v2 0/7] accel/tcg: remove implied BQL from cpu_handle_interrupt/exception path

On Fri, 21 Aug 2020 at 06:56, Cornelia Huck wrote: > > > > As the first step in removing the BQL from this path, we will make > > changes to the core/common functions of cpu_handle_interrupt/exception > > to drop the holding of the BQL. The holding of the BQL is pushed down > > to the per-arch imp

Re: [PATCH-for-5.2] exec: Remove MemoryRegion::global_locking field

On Sat, 22 Aug 2020 at 16:13, Philippe Mathieu-Daudé wrote: > > +Robert > > On 8/7/20 12:16 PM, Paolo Bonzini wrote: > > On 07/08/20 12:02, Stefan Hajnoczi wrote: > >> On Thu, Aug 06, 2020 at 05:07:26PM +0200, Philippe Mathieu-Daudé wrote: > >>> Last uses of memory_region_clear_global_locking() h

[PATCH v2 7/7] target: Push BQL on ->cpu_exec_interrupt down into per-arch implementation

g/archive/html/qemu-devel/2020-08/msg00784.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- accel/tcg/c

[PATCH v2 4/7] target: Push BQL on ->do_interrupt down into per-arch implementation

u-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c| 2 -- target/alpha/cpu.c | 2 +- target/alpha/cpu.h | 2 +- target/alpha/helper.c | 9 - target/arm/cpu.c| 2 +- target/arm/cpu.h

[PATCH v2 5/7] accel/tcg: Change BQL critical section in cpu_handle_interrupt

eed to consider? Are we missing anything here? Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index e661635f06..499a8bdc5e 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/t

[PATCH v2 3/7] target/cris: add CRISCPUClass->do_interrupt_locked

of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00784.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off

[PATCH v2 1/7] target: rename all *_do_interupt functions to _do_interrupt_locked

://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- hw/ppc/spapr_events.c | 2 +- target/alpha/cpu.c

[PATCH v2 2/7] target/arm: add ARMCPUClass->do_interrupt_locked

of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00784.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off

[PATCH v2 6/7] target: rename all *_cpu_exec_interrupt functions to *_cpu_exec_interrupt_locked

-devel/2020-08/msg00784.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/alpha/cpu.c | 2

[PATCH v2 0/7] accel/tcg: remove implied BQL from cpu_handle_interrupt/exception path

emu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html This patch series is based on the per-CPU locks patch: https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg05314.html Our most recent WIP tree is here: https://github.com/rf972/qemu/tree/interr

Re: [PATCH 007/147] tests/vm: do not pollute configure with --efi-aarch64

Reviewed-by: Robert Foley On Mon, 10 Aug 2020 at 13:12, Paolo Bonzini wrote: > > Just make EFI_AARCH64 a variable in the makefile that defaults to the efi > firmware included with QEMU. It can be redefined on the "make" command > line. > > Signed-off-by: Paolo

Re: [PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

On Sat, 8 Aug 2020 at 08:00, Paolo Bonzini wrote: > > We are thinking that 2) would be a good option. > > Yes, it is. The only slight complication is that you'd have both > ->do_interrupt and ->do_interrupt_locked so you probably should add some > consistency check, for example > > /* >

Re: [PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

tions? Or are there other solutions that we should consider here? Thanks & Regards, -Rob On Thu, 6 Aug 2020 at 16:04, Robert Foley wrote: > > The comment around documenting the cpu_mutex fields and critical sections > got us thinking and revisiting our locking assumptions in > c

Re: [PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

al, passing all the tests that we tried (so far). :) Thanks, -Rob On Thu, 6 Aug 2020 at 12:11, Robert Foley wrote: > > On Thu, 6 Aug 2020 at 05:22, Paolo Bonzini wrote: > > > > On 05/08/20 21:18, Richard Henderson wrote: > > > On 8/5/20 11:12 AM, Robert Foley wrote:

Re: [PATCH v1 04/21] target/avr: add BQL to do_interrupt and cpu_exec_interrupt

ps://github.com/rf972/qemu/commits/int_core_v1.4 Also, just so you know, based on the initial feedback we are going to substantially change this series. Another version will be sent out in a few days. Thanks & Regards, -Rob > > > On Wed, Aug 5, 2020 at 9:17 PM Robert Foley wrote: &g

Re: [PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

On Thu, 6 Aug 2020 at 05:22, Paolo Bonzini wrote: > > On 05/08/20 21:18, Richard Henderson wrote: > > On 8/5/20 11:12 AM, Robert Foley wrote: > >> This change removes the implied BQL from the cpu_handle_interrupt, > >> and cpu_handle_exception paths. This BQL acq

Re: [PATCH v1 02/21] target/alpha: add BQL to do_interrupt and cpu_exec_interrupt

On Wed, 5 Aug 2020 at 15:18, Richard Henderson wrote: > > On 8/5/20 11:12 AM, Robert Foley wrote: > > @@ -299,8 +299,12 @@ void alpha_cpu_do_interrupt(CPUState *cs) > > { > > AlphaCPU *cpu = ALPHA_CPU(cs); > > CPUAlphaState *env = &cpu->env;

[PATCH v1 21/21] target/xtensa: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/xtensa/exc_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/xtensa

[PATCH v1 16/21] target/rx: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/rx/helper.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/rx

[PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/s390x/excp_helper.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff

[PATCH v1 08/21] target/lm32: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/lm32/helper.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/lm32

[PATCH v1 14/21] target/ppc: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/ppc/excp_helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/ppc

[PATCH v1 20/21] target/unicore32: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/unicore32/helper.c | 3 +++ target/unicore32/softmmu.c | 7 +++ 2 files changed, 10

[PATCH v1 18/21] target/sh4: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/sh4/helper.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

[PATCH v1 19/21] target/sparc: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/sparc/cpu.c | 3 +++ target/sparc/int32_helper.c | 13 - 2 files

[PATCH v1 07/21] target/i386: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/i386/seg_helper.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a

[PATCH v1 13/21] target/openrisc: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/openrisc/interrupt.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target

[PATCH v1 05/21] target/cris: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/cris/helper.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target

[PATCH v1 15/21] target/riscv: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/riscv/cpu_helper.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target

[PATCH v1 09/21] target/m68k: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/m68k/op_helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/m68k

[PATCH v1 11/21] target/mips: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/mips/helper.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/mips

[PATCH v1 12/21] target/nios2: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/nios2/cpu.c| 3 +++ target/nios2/helper.c | 8 +++- 2 files changed, 10 insertions

[PATCH v1 06/21] target/hppa: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/hppa/int_helper.c | 25 +++-- 1 file changed, 19 insertions(+), 6

[PATCH v1 10/21] target/microblaze: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/microblaze/helper.c | 20 1 file changed, 20 insertions(+) diff --git a

[PATCH v1 03/21] target/arm: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/arm/cpu.c| 13 ++--- target/arm/helper.c | 17 - 2 files changed

[PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

This change removes the implied BQL from the cpu_handle_interrupt, and cpu_handle_exception paths. This BQL acquire is being pushed down into the per arch implementation. Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions

[PATCH v1 00/21] accel/tcg: remove implied BQL from cpu_handle_interrupt/exception path

patch series is based on the per-CPU locks patch: https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg05314.html Robert Foley (21): accel/tcg: Change interrupt/exception handling to remove implied BQL target/alpha: add BQL to do_interrupt and cpu_exec_interrupt target/arm: add BQL to

[PATCH v1 02/21] target/alpha: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/alpha/helper.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff

[PATCH v1 04/21] target/avr: add BQL to do_interrupt and cpu_exec_interrupt

reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/avr/helper.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH 2/2] accel/tcg: interrupt/exception handling uses bql_interrupt flag

On Fri, 31 Jul 2020 at 14:02, Paolo Bonzini wrote: > > On 31/07/20 14:51, Robert Foley wrote: > > This change removes the implied BQL from the cpu_handle_interrupt, > > and cpu_handle_exception paths. We can now select per-arch if > > the BQL is needed or not by usin

Re: [PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass

On Fri, 31 Jul 2020 at 13:44, Eduardo Habkost wrote: > > > > +static inline void cpu_class_disable_bql_interrupt(CPUClass *cc) > > +{ > > +cc->bql_interrupt = false; > > +} > > Class data is not supposed to change outside class_init. Why do > you need this function? I don't see it being used

[PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass

The new flag bql_interrupt, allows the CPUClass to determine if the BQL should be held during calls to cpu_exec_interrupt or do_interrupt. This is being added in preparation for changes in cpu_handle_interrupt, which will use this flag. Signed-off-by: Robert Foley --- hw/core/cpu.c | 1

[PATCH 2/2] accel/tcg: interrupt/exception handling uses bql_interrupt flag

the change to remove BQL when it makes sense. Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 80d0e649b2..cde27ee0bf 100644 --- a/accel

[PATCH 0/2] accel/tcg: remove implied BQL from cpu_handle_interrupt/exception path

take advantage of it in later series. This patch series is based on the per-CPU locks patch: https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg05314.html Robert Foley (2): hw/core: Add bql_interrupt flag to CPUClass accel/tcg: interrupt/exception handling uses bql_interrupt flag accel

Re: [PATCH v3 06/16] accel/tcg: better handle memory constrained systems

Reviewed-by: Robert Foley On Fri, 24 Jul 2020 at 02:49, Alex Bennée wrote: > > It turns out there are some 64 bit systems that have relatively low > amounts of physical memory available to them (typically CI system). > Even with swapping available a 1GB translation buffer that fi

Re: tests/vm infrastructure fails to notice that QEMU dying is a failure

On Fri, 17 Jul 2020 at 18:24, John Snow wrote: > > - The real problem, though: Why is QEMU hanging? It might need a longer > timeout, or it might be having problems with the console socket again. > > (CC Robert Foley who has been working on the Console socket draining > prob

[PATCH v1 2/3] python/qemu: Change ConsoleSocket to optionally drain socket.

ocket. Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 92 +-- python/qemu/machine.py| 13 ++--- 2 files changed, 59 insertions(+), 46 deletions(-) diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py index 09986

[PATCH v1 3/3] tests/vm: add shutdown timeout in basevm.py

We are adding the shutdown timeout to solve an issue we now see where the aarch64 VMs timeout on shutdown under TCG. There is a new 3 second timeout in machine.py, which we override in basevm.py when shutting down. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 15 ++- 1 file

[PATCH v1 1/3] python/qemu: Cleanup changes to ConsoleSocket

The changes to console_socket.py and machine.py are to cleanup for pylint and flake8. Reviewed-by: Alex Bennée Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 57 ++- python/qemu/machine.py| 7 +++-- python/qemu/pylintrc | 2

[PATCH v1 0/3] python/qemu: follow-up changes for ConsoleSocket

at all and essentially behaves like a socket. Robert Foley (3): python/qemu: Cleanup changes to ConsoleSocket python/qemu: Change ConsoleSocket to optionally drain socket. tests/vm: add shutdown timeout in basevm.py python/qemu/console_socket.py | 137

Re: [PATCH 2/2] python/qemu: Change ConsoleSocket to optionally drain socket.

On Thu, 16 Jul 2020 at 09:42, Alex Bennée wrote: > > > +self._drain_thread = None > > +socket.socket.__init__(self, socket.AF_UNIX, socket.SOCK_STREAM) > > +self.connect(address) > > +self._drain = drain > > We end up with two variables that represent the fact we h

Re: [PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

On Thu, 16 Jul 2020 at 07:07, Alex Bennée wrote: > > > Robert Foley writes: > > > The changes to console_socket.py and machine.py are to > > cleanup for pylint and flake8. > > > > Signed-off-by: Robert Foley > > -

[PATCH 2/2] python/qemu: Change ConsoleSocket to optionally drain socket.

ocket. Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 81 +-- python/qemu/machine.py| 13 ++ 2 files changed, 54 insertions(+), 40 deletions(-) diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py index 6a746

[PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

The changes to console_socket.py and machine.py are to cleanup for pylint and flake8. Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 58 +-- python/qemu/machine.py| 7 +++-- python/qemu/pylintrc | 2 +- 3 files changed, 34

[PATCH 0/2] python/qemu: follow-up changes for ConsoleSocket

ConsoleSocket for both the draining and non-draining cases, we changed ConsoleSocket to handle the case where it does not drain the socket at all and essentially behaves like a socket. Robert Foley (2): python/qemu: Cleanup changes to ConsoleSocket python/qemu: Change ConsoleSocket to optionally drain

Re: [PULL 10/41] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

Hi, Thanks for the detailed feedback! I will look at making these changes. On Fri, 10 Jul 2020 at 15:20, John Snow wrote: > > > > On 7/7/20 3:08 AM, Alex Bennée wrote: > > From: Robert Foley > > > > > +def recv(self, n=1, sleep_delay_s=0.1): > >

Re: [PATCH v1 10/13] tests/plugins: add -Wno-unknown-warning-option to handle -Wpsabi

Reviewed-by: Robert Foley On Thu, 9 Jul 2020 at 10:13, Alex Bennée wrote: > > Not all compilers support the -Wpsabi (clang-9 in my case). > > Fixes: bac8d222a > Signed-off-by: Alex Bennée > --- > tests/plugin/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH v1 08/13] plugins: expand the bb plugin to be thread safe and track per-cpu

Reviewed-by: Robert Foley On Thu, 9 Jul 2020 at 10:13, Alex Bennée wrote: > > While there isn't any easy way to make the inline counts thread safe > we can ensure the callback based ones are. While we are at it we can > reduce introduce a new option ("idle") to dump a

[PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN.

->tsan_caller_fiber and co->tsan_co_fiber fields are only access from within #ifdef CONFIG_TSAN. Signed-off-by: Robert Foley --- util/coroutine-ucontext.c | 52 +-- 1 file changed, 34 insertions(+), 18 deletions(-) diff --git a/util/coroutine-ucontext.c

Re: [PATCH v1 11/18] tests/vm: switch from optsparse to argparse

Reviewed-by: Robert Foley On Mon, 22 Jun 2020 at 10:41, Alex Bennée wrote: > > optparse has been deprecated since version 3.2 and argparse is the > blessed replacement. Take the opportunity to enhance our help output > showing defaults when called. > > Signed-off-by: Alex Benn

Re: [PATCH v1 12/18] tests/vm: allow us to take advantage of MTTCG

Reviewed-by: Robert Foley On Mon, 22 Jun 2020 at 10:38, Alex Bennée wrote: > > We currently limit TCG guests to -smp 1 but now we have added some > aarch64 guests we can do better when running on x86_64 hardware. > Raise the limit for TCG guests when it is safe to do so. > > S

Re: [PATCH 01/19] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

Hi, On Wed, 17 Jun 2020 at 10:24, Stefan Hajnoczi wrote: > > On Fri, May 22, 2020 at 12:07:37PM -0400, Robert Foley wrote: > > +#define UC_DEBUG 0 > > +#if UC_DEBUG && defined(CONFIG_TSAN) > > +#define UC_TRACE(fmt, ...) fprintf(stderr, "%s:%d:%p &quo

[PATCH v10 70/73] cpu: protect CPU state with cpu->lock instead of the BQL

. Also changed to obtain cpu lock in qemu_cpu_kick() prior to broadcast to avoid missing notification. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota [RF: Adjusted assert, added timed_wait, obtain cpu lock] Signed-off-by: Robert Foley --- cpus.c

[PATCH v10 71/73] cpus-common: release BQL earlier in run_on_cpu

From: "Emilio G. Cota" After completing the conversion to per-CPU locks, there is no need to release the BQL after having called cpu_kick. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-com

[PATCH v10 68/73] xtensa: convert to cpu_has_work_with_iothread_lock

From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Max Filippov Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/xtensa/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tar

[PATCH v10 65/73] s390x: convert to cpu_has_work_with_iothread_lock

From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Cornelia Huck Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/s390x/cpu.c | 4 +++- 1 file

[PATCH v10 63/73] ppc: convert to cpu_has_work_with_iothread_lock

From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: Converted new code related to POWER10] Signed-off-by: Robert Foley --- target/ppc/translate_

[PATCH v10 61/73] cpu: call .cpu_has_work with the CPU lock held

From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- include/hw/core/cpu.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/

[PATCH v10 59/73] accel/tcg: convert to cpu_interrupt_request

From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 15 --- accel/tcg/tcg-all.c | 12 +--- accel/tcg/translate-all.c | 2 +- 3 files c

[PATCH v10 60/73] cpu: convert to interrupt_request

From: "Emilio G. Cota" This finishes the conversion to interrupt_request. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/core/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v10 57/73] unicore32: convert to cpu_interrupt_request

From: "Emilio G. Cota" Cc: Guan Xuetao Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/unicore32/cpu.c | 2 +- target/unicore32/softmmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) di

[PATCH v10 51/73] nios: convert to cpu_interrupt_request

From: "Emilio G. Cota" Cc: Chris Wulff Cc: Marek Vasut Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/nios2/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/cpu.

[PATCH v10 69/73] cpu: rename all_cpu_threads_idle to qemu_tcg_rr_all_cpu_threads_idle

From: "Emilio G. Cota" This function is only called from TCG rr mode, so add a prefix to mark this as well as an assertion. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus.c | 10 ++ 1 file

[PATCH v10 50/73] mips: convert to cpu_interrupt_request

From: "Emilio G. Cota" Cc: Aurelien Jarno Cc: Aleksandar Markovic Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/mips/cpu.c | 7 --- target/mips/kvm.c | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/t

[PATCH v10 56/73] openrisc: convert to cpu_interrupt_request

From: "Emilio G. Cota" Cc: Stafford Horne Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/openrisc/cputimer.c | 2 +- target/openrisc/cpu.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v10 67/73] sparc: convert to cpu_has_work_with_iothread_lock

From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Acked-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sparc/cpu.c | 4 +++- 1 file changed, 3 insertions(+),

[PATCH v10 47/73] hppa: convert to cpu_interrupt_request

From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/hppa/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index

[PATCH v10 66/73] riscv: convert to cpu_has_work_with_iothread_lock

From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Sagar Karandikar Cc: Bastian Koppelmann Reviewed-by: Palmer Dabbelt Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/r

[PATCH v10 54/73] moxie: convert to cpu_interrupt_request

From: "Emilio G. Cota" Cc: Anthony Green Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/moxie/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/moxie/cpu.c b/target/m

[PATCH v10 73/73] cputlb: queue async flush jobs without the BQL

hes ( +- 0.09% ) 7.389068145 seconds time elapsed ( +- 0.13% ) That is, a 1.37% slowdown. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Tested-by: Alex Bennée Signed-off-by: Emilio G. Cota [Updated the speedup chart results for re-based series.] Signed-off-by: Robert Foley ---

[PATCH v10 49/73] m68k: convert to cpu_interrupt_request

From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/m68k/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index

[PATCH v10 62/73] cpu: introduce cpu_has_work_with_iothread_lock

From: "Emilio G. Cota" It will gain some users soon. Suggested-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- include/hw/core/cpu.h | 37 ++--- 1 file c

[PATCH v10 45/73] sh4: convert to cpu_interrupt_request

From: "Emilio G. Cota" Cc: Aurelien Jarno Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sh4/cpu.c| 2 +- target/sh4/helper.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH v10 72/73] cpu: add async_run_on_cpu_no_bql

From: "Emilio G. Cota" Some async jobs do not need the BQL. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 39 ++- include/hw/core/cpu.h | 14 +++

[PATCH v10 43/73] i386/hvf: convert to cpu_request_interrupt

From: "Emilio G. Cota" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/hvf/hvf.c| 8 +--- target/i386/hvf/x86hvf.c | 26 +++--- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/t

[PATCH v10 55/73] sparc: convert to cpu_interrupt_request

From: "Emilio G. Cota" Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/sparc64/sparc64.c | 4 ++-- target/sparc/cpu.c | 2 +- 2 files changed, 3 insert

[PATCH v10 44/73] ppc: convert to cpu_interrupt_request

From: "Emilio G. Cota" Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: Minor adjustment for new code in hvf_inject_interrupts] Signed-off-by: Robert Foley --- hw/ppc/ppc.c| 2 +- target/i386/hv

[PATCH v10 64/73] mips: convert to cpu_has_work_with_iothread_lock

From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Aurelien Jarno Cc: Aleksandar Markovic Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/mips/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletio

[PATCH v10 32/73] cpu: define cpu_interrupt_request helpers

sition; once that is complete, cpu_interrupt_request will be simple again. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/core/cpu.c | 27 +-- include/hw/core/cpu.h | 37

[PATCH v10 58/73] microblaze: convert to cpu_interrupt_request

From: "Emilio G. Cota" Reviewed-by: Edgar E. Iglesias Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/microblaze/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microbla

[PATCH v10 52/73] s390x: convert to cpu_interrupt_request

From: "Emilio G. Cota" Cc: Christian Borntraeger Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Cornelia Huck Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/intc/s390_flic.c | 2 +- target/s

[PATCH v10 41/73] i386/hax-all: convert to cpu_interrupt_request

From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted new code to cpu_interrupt_request] Signed-off-by: Robert Foley --- target/i386/hax-all.c | 34 +++--- 1 file changed, 19 inserti

[PATCH v10 42/73] i386/whpx-all: convert to cpu_interrupt_request

From: "Emilio G. Cota" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/whpx-all.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/target/i386/whpx-all.c b/target

[PATCH v10 38/73] arm: convert to cpu_interrupt_request

From: "Emilio G. Cota" Cc: Peter Maydell Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/arm/cpu.c | 6 +++--- target/arm/helper.c | 16 +++- target/arm/mach

[PATCH v10 29/73] openrisc: convert to cpu_halted

From: "Emilio G. Cota" Cc: Stafford Horne Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/openrisc/sys_

[PATCH v10 53/73] alpha: convert to cpu_interrupt_request

From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/alpha/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/alpha/cpu.c b/target/alpha/c

[PATCH v10 17/73] arm: convert to cpu_halted

From: "Emilio G. Cota" Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/arm/omap1.c| 4 ++-- hw/arm/pxa2xx_gpio.c | 2

[PATCH v10 48/73] lm32: convert to cpu_interrupt_request

From: "Emilio G. Cota" Cc: Michael Walle Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/lm32/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/lm32/cpu.c b/target/lm32/c

[PATCH v10 30/73] cpu-exec: convert to cpu_halted

From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/accel/tcg/cpu-exec.c b

[PATCH v10 37/73] openrisc: use cpu_reset_interrupt

From: Paolo Bonzini Cc: Stafford Horne Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion

  1   2   3   4   5   6   >