On Thu, Feb 20, 2014 at 7:35 AM, Paolo Bonzini wrote:
> Looks like _ is more common than - for device properties:
>
> $ git grep DEFINE_PROP_.*\(\".*_.*\" | wc -l
> 132
> $ git grep DEFINE_PROP_.*\(\".*-.*\" | wc -l
> 77
And more locally, "scsi-id" in scsi-bus.c is the only property in
hw/scsi wi
On Wed, Feb 19, 2014 at 10:11 AM, Andreas Färber wrote:
> HEX64 will conflict with your patches in the pending pull.
I'm not aware of the issue. Is there a better tree for me to work
against than qemu.git master?
> Also I notice that underscores are being used in new properties -
> oversight or
From: Roland Dreier
To make a VM more convincing to my application, it's useful to be able
to add a port WWN and relative target port index to the descriptors
returned for VPD page 83h. Add device properties to allow setting
these, and return them from INQUIRY commands.
Signed-off-by: R
On Fri, Apr 5, 2013 at 1:51 PM, Michael R. Hines
wrote:
> Sorry, I was wrong. ignore the comments about cgroups. That's still broken.
> (i.e. trying to register RDMA memory while using a cgroup swap limit cause
> the process get killed).
>
> But the GIFT flag patch works (my understanding is that
On Fri, Apr 5, 2013 at 1:17 PM, Michael R. Hines
wrote:
> I also removed the IBV_*_WRITE flags on the sender-side and activated
> cgroups with the "memory.memsw.limit_in_bytes" activated and the migration
> with RDMA also succeeded without any problems (both with *and* without GIFT
> also worked).
On Tue, Apr 2, 2013 at 8:51 AM, Michael S. Tsirkin wrote:
>> At the moment registering an MR breaks COW. This breaks memory
>> overcommit for users such as KVM: we have a lot of COW pages, e.g.
>> instances of the zero page or pages shared using KSM.
>>
>> If the application does not care that ad
On Thu, Mar 21, 2013 at 1:51 AM, Michael S. Tsirkin wrote:
>> In that case, no, I don't see any reason for LOCAL_WRITE, since the
>> only RDMA operations that will access this memory are remote reads.
>
> What is the meaning of LOCAL_WRITE then? There are no local
> RDMA writes as far as I can see
On Wed, Mar 20, 2013 at 11:18 PM, Michael S. Tsirkin wrote:
> core/umem.c seems to get the arguments to get_user_pages
> in the reverse order: it sets writeable flag and
> breaks COW for MAP_SHARED if and only if hardware needs to
> write the page.
>
> This breaks memory overcommit for users such
>> I think this change will break the case where userspace tries to
>> register an MR with read-only permission, but intends locally through
>> the CPU to write to the memory.
> Shouldn't it set LOCAL_WRITE then?
We're talking about the permissions for the register MR operation,
right? (That's w
On Fri, Mar 4, 2011 at 8:59 AM, Roland Dreier wrote:
> Actually there is no problem with overflow of unsigned long.
> The C standard says that unsigned arithmetic is simply done
> modulo the size of the integer, so when total_out reaches
> 4GB, things will just wrap around (and th
On Thu, Mar 3, 2011 at 11:34 PM, Michael Tokarev wrote:
>> The fix for this is simple: keep previous_out as a uLong too, which
>> avoids any problems with sign conversion or truncation.
>
> This looks wrong to me. On 32bit x86 uLong is 32bits. Yes
> it's unsigned there, but it's still 32bits. A
From: Roland Dreier
If one leaves a VNC session with tight compression running for long
enough, Qemu crashes. This is because of the computation
bytes = zstream->total_out - previous_out;
in tight_compress_data, where zstream->total_out is a uLong but
previous_out is an int. As s
Check that the cursor dimensions passed from the guest for the
DEFINE_CURSOR command don't overflow the available space in the
cursor.image[] or cursor.mask[] arrays before copying data from the
guest into those arrays.
Signed-off-by: Roland Dreier
---
Hi Anthony,
as far as I can tell
mand don't overflow the available space in the
cursor.image[] or cursor.mask[] arrays before copying data from the
guest into those arrays.
Signed-off-by: Roland Dreier
---
hw/vmware_vga.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/hw/vmware_vga.c b/hw/vmw
> His last patch has the same fix without the printf(). The printf is
> probably something to avoid since a malicious guest could create a
> storm of them. Since libvirt logs stderr by default, the result could
> be pretty nasty.
By the way, are the
fprintf(stderr, "%s: update widt
hold 4096 32-bit
pixels so we don't fail for the case of 64*64*32bpp, and also add error
checking to avoid a crash if an even bigger request is sent by a guest.
Signed-off-by: Roland Dreier
---
hw/vmware_vga.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git
of 64*64*32bpp, and also add error
checking to avoid a crash if an even bigger request is sent by a guest.
Signed-off-by: Roland Dreier
---
hw/vmware_vga.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index f3e3749..d253a2e
64*64*32bpp, and also add error
checking to avoid a crash if an even bigger request is sent by a guest.
Signed-off-by: Roland Dreier
---
hw/vmware_vga.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index f3e3749..d253a2e 1
18 matches
Mail list logo
