Re: [Qemu-devel] [qemu PATCH 4/5] machine: fix some misspelled words

2018-06-08 Thread Ross Zwisler
On Fri, Jun 08, 2018 at 07:38:17AM +0200, Thomas Huth wrote: > On 08.06.2018 00:31, Ross Zwisler wrote: > > Normally this might not be worth fixing, but several of these are strings > > which are displayed to users. > > > > Signed-off-by: Ross Zwisler > &g

Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files

2018-06-08 Thread Ross Zwisler
On Fri, Jun 08, 2018 at 09:59:00AM -0500, Eric Blake wrote: > On 06/07/2018 05:31 PM, Ross Zwisler wrote: > > With a fully built QEMU I currently see the following with "git status": > > > >Untracked files: > > (use "git add ..." to inclu

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Ross Zwisler
On Fri, Jun 08, 2018 at 07:17:51AM +0200, Thomas Huth wrote: > On 08.06.2018 01:09, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2018 at 04:31:08PM -0600, Ross Zwisler wrote: > >> Currently if "make check" detects a mismatch in the ASL generated during > >&g

[Qemu-devel] [qemu PATCH 5/5] nvdimm: make persistence option symbolic

2018-06-07 Thread Ross Zwisler
Replace the "nvdimm-cap" option which took numeric arguments such as "2" with a more user friendly "nvdimm-persistence" option which takes symbolic arguments "cpu" or "mem-ctrl". Signed-off-by: Ross Zwisler Suggested-by: Michael S. Tsirkin

[Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files

2018-06-07 Thread Ross Zwisler
s-job.h qapi/qapi-types-job.c qapi/qapi-types-job.h qapi/qapi-visit-job.c qapi/qapi-visit-job.h These are all generated files. Ignore them. Signed-off-by: Ross Zwisler Cc: Kevin Wolf Cc: Eric Blake Fixes: commit bf42508f24ee ("job: Introduce qapi/job.json&q

[Qemu-devel] [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check"

2018-06-07 Thread Ross Zwisler
so it reflects this name change. Signed-off-by: Ross Zwisler Cc: Peter Maydell Cc: Cornelia Huck Cc: Thomas Huth Cc: Eduardo Habkost Fixes: commit aa78a16d8645 ("hw/i386: Rename 2.13 machine types to 3.0") --- tests/acpi-test-data/q35/SSDT.dimmpxm | Bin 685 -> 685 bytes 1 file ch

[Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-07 Thread Ross Zwisler
. but the testing still exits with good shell status. This is wrong, and makes bisecting such a failure difficult. Signed-off-by: Ross Zwisler --- tests/bios-tables-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 256d463cb8..

[Qemu-devel] [qemu PATCH 4/5] machine: fix some misspelled words

2018-06-07 Thread Ross Zwisler
Normally this might not be worth fixing, but several of these are strings which are displayed to users. Signed-off-by: Ross Zwisler --- hw/core/machine.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index 617e5f8d75..a21269fa39

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-06 Thread Ross Zwisler
On Wed, Jun 06, 2018 at 11:00:33AM -0600, Ross Zwisler wrote: > On Wed, Jun 06, 2018 at 10:50:51AM -0600, Ross Zwisler wrote: > > On Tue, Jun 05, 2018 at 03:21:30PM -0700, Dan Williams wrote: > > > On Tue, Jun 5, 2018 at 3:07 PM, Ross Zwisler > > > wrote: > >

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-06 Thread Ross Zwisler
On Wed, Jun 06, 2018 at 10:50:51AM -0600, Ross Zwisler wrote: > On Tue, Jun 05, 2018 at 03:21:30PM -0700, Dan Williams wrote: > > On Tue, Jun 5, 2018 at 3:07 PM, Ross Zwisler > > wrote: > > > On Tue, Jun 05, 2018 at 09:37:25PM +0300, Michael S. Tsirkin wrote: > > &g

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-06 Thread Ross Zwisler
On Tue, Jun 05, 2018 at 03:21:30PM -0700, Dan Williams wrote: > On Tue, Jun 5, 2018 at 3:07 PM, Ross Zwisler > wrote: > > On Tue, Jun 05, 2018 at 09:37:25PM +0300, Michael S. Tsirkin wrote: > >> On Tue, Jun 05, 2018 at 11:15:00AM -0700, Dan Williams wrote: > >> &g

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Ross Zwisler
On Tue, Jun 05, 2018 at 09:37:25PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 11:15:00AM -0700, Dan Williams wrote: > > On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler > > wrote: > > > On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: > &

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Ross Zwisler
On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: > On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote: > > Add a machine command line option to allow the user to control the Platform > > Capabilities Structure in the virtualized NFIT. This Platfo

Re: [Qemu-devel] [qemu PATCH v4 0/4] support NFIT platform capabilities

2018-05-31 Thread Ross Zwisler
On Fri, May 25, 2018 at 08:51:22PM +0300, Michael S. Tsirkin wrote: > On Mon, May 21, 2018 at 10:31:59AM -0600, Ross Zwisler wrote: > > Changes since v3: > > * Updated the text in docs/nvdimm.txt to make it clear that the value > >being passed in on the command line in

Re: [Qemu-devel] [qemu PATCH v4 0/4] support NFIT platform capabilities

2018-05-29 Thread Ross Zwisler
Ping on this series. Rob, I think I've addressed all your feedback. Can you please verify? Thanks, - Ross On Mon, May 21, 2018 at 10:31:59AM -0600, Ross Zwisler wrote: > Changes since v3: > * Updated the text in docs/nvdimm.txt to make it clear that the value >being pa

[Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-05-21 Thread Ross Zwisler
Add a machine command line option to allow the user to control the Platform Capabilities Structure in the virtualized NFIT. This Platform Capabilities Structure was added in ACPI 6.2 Errata A. Signed-off-by: Ross Zwisler --- docs/nvdimm.txt | 27 +++ hw/acpi

[Qemu-devel] [qemu PATCH v4 2/4] tests/.gitignore: add entry for generated file

2018-05-21 Thread Ross Zwisler
t untracked files present (use "git add" to track) Signed-off-by: Ross Zwisler Fixes: commit ad0df3e0fdac ("block: test blk_aio_flush() with blk->root == NULL") Cc: Kevin Wolf --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b

[Qemu-devel] [qemu PATCH v4 1/4] nvdimm: fix typo in label-size definition

2018-05-21 Thread Ross Zwisler
Signed-off-by: Ross Zwisler Fixes: commit da6789c27c2e ("nvdimm: add a macro for property "label-size"") Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov Cc: Haozhong Zhang Cc: Michael S. Tsirkin Cc: Stefan Hajnoczi --- hw/mem/nvdimm.c | 2 +- include

[Qemu-devel] [qemu PATCH v4 4/4] ACPI testing: test NFIT platform capabilities

2018-05-21 Thread Ross Zwisler
Add testing for the newly added NFIT Platform Capabilities Structure. Signed-off-by: Ross Zwisler Suggested-by: Igor Mammedov --- tests/acpi-test-data/pc/NFIT.dimmpxm | Bin 224 -> 240 bytes tests/acpi-test-data/q35/NFIT.dimmpxm | Bin 224 -> 240 bytes tests/bios-tables-

[Qemu-devel] [qemu PATCH v4 0/4] support NFIT platform capabilities

2018-05-21 Thread Ross Zwisler
abilities Structure, and adds it to the expected NFIT output so that we test for it. Ross Zwisler (4): nvdimm: fix typo in label-size definition tests/.gitignore: add entry for generated file nvdimm, acpi: support NFIT platform capabilities ACPI testing: test NFIT plat

Re: [Qemu-devel] [qemu PATCH v2 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-05-21 Thread Ross Zwisler
On Fri, May 18, 2018 at 04:37:10PM +, Elliott, Robert (Persistent Memory) wrote: > > > ... > > Would it help to show them in hex? > > > > As of ACPI 6.2 Errata A, the following values are valid for the bottom > > two bits: > > > > 0x2 - Memory Controller Flush to NVDIMM Durability on

Re: [Qemu-devel] [qemu PATCH v2 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-05-18 Thread Ross Zwisler
On Fri, May 18, 2018 at 04:37:10PM +, Elliott, Robert (Persistent Memory) wrote: > > > ... > > Would it help to show them in hex? > > > > As of ACPI 6.2 Errata A, the following values are valid for the bottom > > two bits: > > > > 0x2 - Memory Controller Flush to NVDIMM Durability on

Re: [Qemu-devel] [qemu PATCH v2 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-05-18 Thread Ross Zwisler
On Thu, May 17, 2018 at 10:06:37PM +, Elliott, Robert (Persistent Memory) wrote: > > > > -Original Message- > > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > > Ross Zwisler > > Sent: Thursday, May 17, 2018 12:00 AM &

[Qemu-devel] [qemu PATCH v3 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-05-17 Thread Ross Zwisler
Add a machine command line option to allow the user to control the Platform Capabilities Structure in the virtualized NFIT. This Platform Capabilities Structure was added in ACPI 6.2 Errata A. Signed-off-by: Ross Zwisler --- v3: Added brackets around single statement "if" conditional

[Qemu-devel] [qemu PATCH v2 2/4] tests/.gitignore: add entry for generated file

2018-05-16 Thread Ross Zwisler
t untracked files present (use "git add" to track) Signed-off-by: Ross Zwisler Fixes: commit ad0df3e0fdac ("block: test blk_aio_flush() with blk->root == NULL") --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.giti

[Qemu-devel] [qemu PATCH v2 1/4] nvdimm: fix typo in label-size definition

2018-05-16 Thread Ross Zwisler
Signed-off-by: Ross Zwisler Fixes: commit da6789c27c2e ("nvdimm: add a macro for property "label-size"") Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov Cc: Haozhong Zhang Cc: Michael S. Tsirkin Cc: Stefan Hajnoczi --- hw/mem/nvdimm.c | 2 +- include

[Qemu-devel] [qemu PATCH v2 0/4] support NFIT platform capabilities

2018-05-16 Thread Ross Zwisler
ected NFIT output so that we test for it. Thanks to Igor Mammedov for his feedback on v1 of this set. Ross Zwisler (4): nvdimm: fix typo in label-size definition tests/.gitignore: add entry for generated file nvdimm, acpi: support NFIT platform capabilities ACPI testing: test NFIT platform

[Qemu-devel] [qemu PATCH v2 4/4] ACPI testing: test NFIT platform capabilities

2018-05-16 Thread Ross Zwisler
Add testing for the newly added NFIT Platform Capabilities Structure. Signed-off-by: Ross Zwisler Suggested-by: Igor Mammedov --- tests/acpi-test-data/pc/NFIT.dimmpxm | Bin 224 -> 240 bytes tests/acpi-test-data/q35/NFIT.dimmpxm | Bin 224 -> 240 bytes tests/bios-tables-

[Qemu-devel] [qemu PATCH v2 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-05-16 Thread Ross Zwisler
Add a machine command line option to allow the user to control the Platform Capabilities Structure in the virtualized NFIT. This Platform Capabilities Structure was added in ACPI 6.2 Errata A. Signed-off-by: Ross Zwisler --- docs/nvdimm.txt | 18 ++ hw/acpi/nvdimm.c

Re: [Qemu-devel] [PATCH 3/3] nvdimm: platform capabilities command line option

2018-05-15 Thread Ross Zwisler
On Thu, May 10, 2018 at 03:28:48PM +0200, Igor Mammedov wrote: > On Fri, 27 Apr 2018 15:53:14 -0600 > Ross Zwisler wrote: > > > Add a device command line option to allow the user to control the Platform > > Capabilities Structure in the virtualized NFIT. > > >

Re: [Qemu-devel] [PATCH 1/3] nvdimm: fix typo in label-size definition

2018-05-03 Thread Ross Zwisler
On Mon, Apr 30, 2018 at 12:38:58PM +0100, Stefan Hajnoczi wrote: > On Fri, Apr 27, 2018 at 03:53:12PM -0600, Ross Zwisler wrote: > > Signed-off-by: Ross Zwisler > > Fixes: commit da6789c27c2e ("nvdimm: add a macro for property "label-size"") > > Cc: H

[Qemu-devel] [PATCH 2/3] nvdimm, acpi: add NFIT platform capabilities

2018-04-27 Thread Ross Zwisler
Add support for the NFIT Platform Capabilities Structure, newly added in ACPI 6.2 Errata A. Signed-off-by: Ross Zwisler --- hw/acpi/nvdimm.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 59d6e4254c..859b390e07

[Qemu-devel] [PATCH 1/3] nvdimm: fix typo in label-size definition

2018-04-27 Thread Ross Zwisler
Signed-off-by: Ross Zwisler Fixes: commit da6789c27c2e ("nvdimm: add a macro for property "label-size"") Cc: Haozhong Zhang Cc: Michael S. Tsirkin Cc: Stefan Hajnoczi --- hw/mem/nvdimm.c | 2 +- include/hw/mem/nvdimm.h | 2 +- 2 files changed, 2 insertions(+),

[Qemu-devel] [PATCH 3/3] nvdimm: platform capabilities command line option

2018-04-27 Thread Ross Zwisler
Add a device command line option to allow the user to control the Platform Capabilities Structure in the virtualized NFIT. Signed-off-by: Ross Zwisler --- docs/nvdimm.txt | 22 ++ hw/acpi/nvdimm.c| 29 + hw/mem/nvdimm.c

Re: [Qemu-devel] QEMU NVDIMM as type 7 in e820 table

2017-07-31 Thread Ross Zwisler
On Sat, Jul 29, 2017 at 06:49:33PM +0800, Haozhong Zhang wrote: > On 07/28/17 13:45 -0600, Ross Zwisler wrote: > > On Fri, Jul 28, 2017 at 11:11:10AM -0700, Dan Williams wrote: > > > On Fri, Jul 28, 2017 at 11:04 AM, Ross Zwisler > > > wrote: > > > > I'

Re: [Qemu-devel] QEMU NVDIMM as type 7 in e820 table

2017-07-28 Thread Ross Zwisler
On Fri, Jul 28, 2017 at 11:11:10AM -0700, Dan Williams wrote: > On Fri, Jul 28, 2017 at 11:04 AM, Ross Zwisler > wrote: > > I've been using the virtualized NVDIMM support in QEMU for testing, and I > > noticed that the physical addresses used by the virtual NVDIMMs aren&#x

[Qemu-devel] QEMU NVDIMM as type 7 in e820 table

2017-07-28 Thread Ross Zwisler
I've been using the virtualized NVDIMM support in QEMU for testing, and I noticed that the physical addresses used by the virtual NVDIMMs aren't present in the guest's e820 table. Here is the e820 table on my QEMU instance where I have one 32 GiB virtual NVDIMM: [0.00] e820: BIOS-provided

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

2016-09-09 Thread Ross Zwisler
On Fri, Sep 09, 2016 at 10:03:27AM -0400, Theodore Ts'o wrote: > On Fri, Sep 09, 2016 at 11:19:25AM +0200, Jan Kara wrote: > > > > > > 1. make the guest kernel based on your tree, the top commit is > > > > > >10d7902fa0e82b (dax: unmap/truncate on device shutdown) and > > > > > >the config

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

2016-09-08 Thread Ross Zwisler
On Tue, Sep 06, 2016 at 05:06:20PM +0200, Jan Kara wrote: > On Thu 01-09-16 20:57:38, Ross Zwisler wrote: > > On Wed, Aug 31, 2016 at 04:44:47PM +0800, Xiao Guangrong wrote: > > > On 08/31/2016 01:09 AM, Dan Williams wrote: > > > > > > > > Can you post yo

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

2016-09-01 Thread Ross Zwisler
On Wed, Aug 31, 2016 at 04:44:47PM +0800, Xiao Guangrong wrote: > On 08/31/2016 01:09 AM, Dan Williams wrote: > > > > Can you post your exact reproduction steps? This test is not failing for > > me. > > > > Sure. > > 1. make the guest kernel based on your tree, the top commit is >10d7902f

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

2016-08-31 Thread Ross Zwisler
On Wed, Aug 31, 2016 at 04:44:47PM +0800, Xiao Guangrong wrote: > On 08/31/2016 01:09 AM, Dan Williams wrote: > > > > Can you post your exact reproduction steps? This test is not failing for > > me. > > > > Sure. > > 1. make the guest kernel based on your tree, the top commit is >10d7902f

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

2016-08-29 Thread Ross Zwisler
On Mon, Aug 29, 2016 at 03:54:10PM +0800, Xiao Guangrong wrote: > > Hi Ross, > > Sorry for the delay, i just returned back from KVM Forum. > > On 08/20/2016 02:30 AM, Ross Zwisler wrote: > > On Fri, Aug 19, 2016 at 07:59:29AM -0700, Dan Williams wrote: > > >

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

2016-08-19 Thread Ross Zwisler
On Fri, Aug 19, 2016 at 07:59:29AM -0700, Dan Williams wrote: > On Fri, Aug 19, 2016 at 4:19 AM, Xiao Guangrong > wrote: > > > > Hi Dan, > > > > Recently, Redhat reported that nvml test suite failed on QEMU/KVM, > > more detailed info please refer to: > >https://bugzilla.redhat.com/show_bug.cg