Re: [Qemu-devel] [PATCH] rocker: don't queue receive pkts when port is disabled

2015-06-30 Thread Scott Feldman
On Tue, Jun 30, 2015 at 6:47 PM, Fam Zheng f...@redhat.com wrote: On Tue, 06/30 07:41, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com Commit 6e99c63 (net/socket: Drop net_socket_can_send) changed the semantics around .can_receive for sockets to now require the device to flush

Re: [Qemu-devel] (no subject)

2015-06-30 Thread Scott Feldman
On Tue, Jun 30, 2015 at 3:18 AM, Fam Zheng f...@redhat.com wrote: On Tue, 06/30 00:49, Scott Feldman wrote: Hi Fam, Stefan, I'm running a test with rocker device using UDP sockets connections and I'm seeing the socket s-read_poll stay disabled if the device receives a packet when

[Qemu-devel] (no subject)

2015-06-29 Thread Scott Feldman
Hi Fam, Stefan, I'm running a test with rocker device using UDP sockets connections and I'm seeing the socket s-read_poll stay disabled if the device receives a packet when the device's can_receive returns false. Receive is stuck after that; nothing ever re-enables s-read_poll. I see the first

Re: [Qemu-devel] [PATCH v8 0/9] rocker: add new rocker ethernet switch device

2015-03-30 Thread Scott Feldman
2.4 is fine, thanks On Mar 30, 2015 7:52 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Mar 13, 2015 at 09:09:24PM -0700, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com v8: - From Stefan Hajnoczi's net-pull-request v3, merge in these changes: - Squash

Re: [Qemu-devel] [PATCH v8 0/9] rocker: add new rocker ethernet switch device

2015-03-26 Thread Scott Feldman
Ping On Fri, Mar 13, 2015 at 9:09 PM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com v8: - From Stefan Hajnoczi's net-pull-request v3, merge in these changes: - Squash David Ahern's clang struct definition warnings fix - Squash in Jiri's fix for rocker format

Re: [Qemu-devel] [PULL v4 00/11] Net patches

2015-03-13 Thread Scott Feldman
On Thu, Mar 12, 2015 at 12:58 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Mar 12, 2015 at 03:03:45PM +, Peter Maydell wrote: On 12 March 2015 at 14:43, Peter Maydell peter.mayd...@linaro.org wrote: On 12 March 2015 at 14:33, Stefan Hajnoczi stefa...@redhat.com wrote: v4: *

Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

2015-02-17 Thread Scott Feldman
On Tue, Feb 17, 2015 at 1:48 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 16/02/2015 23:37, Scott Feldman wrote: I would just merge the other nine patches for 2.3. I disagree. qmp/hmp is very important to rocker. It would be nearly impossible to debug large/complicated networking

Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

2015-02-16 Thread Scott Feldman
On Mon, Feb 16, 2015 at 5:16 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 16/02/2015 22:47, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com Add QMP/HMP support for rocker devices. This is mostly for debugging purposes to see inside the device's tables and port

Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

2015-02-16 Thread Scott Feldman
On Mon, Feb 16, 2015 at 5:16 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 16/02/2015 22:47, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com Add QMP/HMP support for rocker devices. This is mostly for debugging purposes to see inside the device's tables and port

Re: [Qemu-devel] [PATCH v5 07/10] qmp: add rocker device support

2015-02-04 Thread Scott Feldman
On Tue, Feb 3, 2015 at 7:10 AM, Eric Blake ebl...@redhat.com wrote: On 01/22/2015 01:03 AM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com Add QMP/HMP support for rocker devices. This is mostly for debugging purposes to see inside the device's tables and port configurations

Re: [Qemu-devel] [PATCH v5 03/10] rocker: add register programming guide

2015-02-04 Thread Scott Feldman
On Tue, Feb 3, 2015 at 8:40 AM, Eric Blake ebl...@redhat.com wrote: On 01/22/2015 01:03 AM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com This is the register programming guide for the Rocker device. It's intended for driver writers and device writers. It covers

Re: [Qemu-devel] [PATCH v5 03/10] rocker: add register programming guide

2015-02-04 Thread Scott Feldman
On Mon, Feb 2, 2015 at 8:19 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jan 22, 2015 at 12:03:52AM -0800, sfel...@gmail.com wrote: +SECTION 7: Switch Control += + +This section covers switch-wide register settings. + +Control +--- + +This register is

Re: [Qemu-devel] [PATCH v3 3/9] rocker: add register programming guide

2015-01-16 Thread Scott Feldman
On Mon, Jan 12, 2015 at 3:40 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 11/01/2015 04:57, sfel...@gmail.com wrote: +PCI Configuration Space +--- + +Each switch instance registers as a PCI device with PCI configuration space: + + offset width description

Re: [Qemu-devel] [PATCH v3 6/9] rocker: add new rocker switch device

2015-01-16 Thread Scott Feldman
On Fri, Jan 16, 2015 at 1:15 AM, Jason Wang jasow...@redhat.com wrote: On 01/11/2015 11:57 AM, sfel...@gmail.com wrote: Each port is a netdev and can be paired with using -netdev id=port name. Signed-off-by: Scott Feldman sfel...@gmail.com Signed-off-by: Jiri Pirko j...@resnulli.us

Re: [Qemu-devel] [PATCH v3 7/9] qmp: add rocker device support

2015-01-16 Thread Scott Feldman
On Fri, Jan 16, 2015 at 1:26 AM, Jason Wang jasow...@redhat.com wrote: On 01/11/2015 11:57 AM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com Add QMP/HMP support for rocker devices. This is mostly for debugging purposes to see inside the device's tables and port

Re: [Qemu-devel] [PATCH v3 6/9] rocker: add new rocker switch device

2015-01-14 Thread Scott Feldman
On Mon, Jan 12, 2015 at 4:57 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 11/01/2015 04:57, sfel...@gmail.com wrote: +static const MemoryRegionOps rocker_mmio_ops = { +.read = rocker_mmio_read, +.write = rocker_mmio_write, +.endianness = DEVICE_LITTLE_ENDIAN, +.valid = {

Re: [Qemu-devel] [PATCH v2 01/10] pci: move REDHAT_SDHCI device ID to make room for Rocker

2015-01-07 Thread Scott Feldman
On Wed, Jan 7, 2015 at 2:55 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 07/01/2015 11:39, Peter Maydell wrote: Within the virt team, we have always considered the authoritative source to be qemu.git and Gerd to be the maintainer. Jiri is a Red Hatter but not in the virt team, hence

Re: [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device

2015-01-06 Thread Scott Feldman
On Tue, Jan 6, 2015 at 7:12 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Jan 05, 2015 at 06:24:58PM -0800, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com Rocker is a simulated ethernet switch device. The device supports up to 62 front-panel ports and supports L2

Re: [Qemu-devel] [PATCH v2 04/10] rocker: add register programming guide

2015-01-05 Thread Scott Feldman
5, 2015 at 9:16 PM, Jason Wang jasow...@redhat.com wrote: On 01/06/2015 10:24 AM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com This is the register programming guide for the Rocker device. It's intended for driver writers and device writers. It covers the device's PCI space

Re: [Qemu-devel] [PATCH 00/10] rocker: add new rocker ethernet switch device

2015-01-04 Thread Scott Feldman
On Sun, Jan 4, 2015 at 1:47 AM, Jason Wang jasow...@redhat.com wrote: On 12/30/2014 01:14 PM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com [This is a collaboration between myself and Jiri Pirko]. This patch set adds a new ethernet switch device, called rocker. Rocker

Re: [Qemu-devel] [PATCH 08/10] qmp: add rocker device support

2015-01-04 Thread Scott Feldman
On Fri, Jan 2, 2015 at 3:56 PM, Eric Blake ebl...@redhat.com wrote: On 12/29/2014 10:14 PM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com [your message came through as a top-level thread instead of in-reply-to the 0/10 cover letter; please see if you can fix that before

Re: [Qemu-devel] [PATCH 08/10] qmp: add rocker device support

2015-01-04 Thread Scott Feldman
On Sun, Jan 4, 2015 at 1:16 PM, Scott Feldman sfel...@gmail.com wrote: On Fri, Jan 2, 2015 at 3:56 PM, Eric Blake ebl...@redhat.com wrote: On 12/29/2014 10:14 PM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com In this mail, I'll review just the QMP interface portion: Thanks