On Tue, 24 Oct 2023 at 04:50, Philippe Mathieu-Daudé wrote:
>
> On 24/10/23 12:06, Alex Bennée wrote:
>
> > A pull request is really just a GPG signed tag that you push to a repo.
> > You can use the existing git tooling to create the cover letter for it.
> >
> > I've included my exact steps at
On Mon, 23 Oct 2023 at 12:16, Alex Bennée wrote:
> You seem to have missed a number of tags from previous postings:
>
>
> https://qemu.readthedocs.io/en/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review
>
> (although I notice we only mention Reviewed-by in the
The probing process of the generic pmbus driver generates
faults to determine if functions are available. These faults
were not always cleared resulting in probe failures.
Signed-off-by: Titus Rwantare
Reviewed-by: Patrick Venture
---
hw/i2c/pmbus_device.c | 5 +
1 file changed, 5
VCAP is a register for devices with energy storage capacitors.
Reviewed-by: Benjamin Streb
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 8
include/hw/i2c/pmbus_device.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c
.
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/i2c/pmbus_device.c | 18 +-
tests/qtest/max34451-test.c | 24
2 files changed, 33 insertions(+), 9 deletions(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 481e158380
to scale the voltage readings.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
include/hw/i2c/pmbus_device.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/hw/i2c/pmbus_device.h b/include/hw/i2c/pmbus_device.h
index 7dc00cc4d9..2e95164aa1 100644
--- a/include/hw/i2c
The ADM1266 is a cascadable super sequencer with margin control and
fault recording.
This commit adds basic support for its PMBus commands and models
the identification registers that can be modified in a firmware
update.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/arm
The ADM1266 can have string fields written by the driver, so
it's worth specifically testing.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
tests/qtest/adm1266-test.c | 123 +
tests/qtest/meson.build| 1 +
2 files changed, 124 insertions
PMBus devices may integrate fans whose operation is configurable
over PMBus. This commit allows the driver to read and write the
fan control registers but does not model the operation of fans.
Reviewed-by: Stephen Longfield
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 176
-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 30 +-
include/hw/i2c/pmbus_device.h | 7 +++
2 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index cef51663d0..ea15490720 100644
--- a/hw/i2c
:
- Added fixes to PMBus: page resets and fault clearing
Changes in v2:
- Expanded commit descriptions
- Added the ADM1266 device model that uses new functions
Titus Rwantare (8):
hw/i2c: pmbus add support for block receive
hw/i2c: pmbus: add vout mode bitfields
hw/i2c: pmbus: add
to scale the voltage readings.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
include/hw/i2c/pmbus_device.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/hw/i2c/pmbus_device.h b/include/hw/i2c/pmbus_device.h
index 7dc00cc4d9..2e95164aa1 100644
--- a/include/hw/i2c
VCAP is a register for devices with energy storage capacitors.
Reviewed-by: Benjamin Streb
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 8
include/hw/i2c/pmbus_device.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c
-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 30 +-
include/hw/i2c/pmbus_device.h | 7 +++
2 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index c3d6046784..02647769cd 100644
--- a/hw/i2c
Devices models calling pmbus_send_string can't be relied upon to
send a non-zero pointer. This logs an error and doesn't segfault.
Reviewed-by: Patrick Venture
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/hw/i2c
PMBus devices may integrate fans whose operation is configurable
over PMBus. This commit allows the driver to read and write the
fan control registers but does not model the operation of fans.
Reviewed-by: Stephen Longfield
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 176
The ADM1266 can have string fields written by the driver, so
it's worth specifically testing.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
tests/qtest/adm1266-test.c | 123 +
tests/qtest/meson.build| 1 +
2 files changed, 124 insertions
The ADM1266 is a cascadable super sequencer with margin control and
fault recording.
This commit adds basic support for its PMBus commands and models
the identification registers that can be modified in a firmware
update.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/arm
:
- Expanded commit descriptions
- Added the ADM1266 device model that uses new functions
Titus Rwantare (7):
hw/i2c: pmbus add support for block receive
hw/i2c: pmbus: add vout mode bitfields
hw/i2c: pmbus: add fan support
hw/i2c: pmbus: block uninitialised string reads
hw/i2c
pon to have empty descriptions, some rationale
> would be helpful. For instance, you remove a length check from the send
> string, why did you do that?
>
> Any why is this being added? What's it supporting?
>
> -corey
>
> On Wed, Mar 22, 2023 at 05:55:09PM +, Titus R
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 30 +-
include/hw/i2c/pmbus_device.h | 7 +++
2 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index c3d6046784
Devices models calling pmbus_send_string can't be relied upon to
send a non-zero pointer. This logs an error and doesn't segfault.
Reviewed-by: Patrick Venture
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/hw/i2c
Reviewed-by: Stephen Longfield
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 176 ++
include/hw/i2c/pmbus_device.h | 1 +
2 files changed, 177 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 02647769cd
VCAP is a register for devices with energy storage capacitors.
Reviewed-by: Benjamin Streb
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 8
include/hw/i2c/pmbus_device.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c
, whose bits determine the
formatting of several read commands in PMBus
Fixes:
- String read now handles now logs an error when passed an empty string
This series is in preparation for some additional sensors that exercise
this functionality that will be incoming shortly.
Thanks
Titus Rwantare
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
include/hw/i2c/pmbus_device.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/hw/i2c/pmbus_device.h b/include/hw/i2c/pmbus_device.h
index 7dc00cc4d9..2e95164aa1 100644
--- a/include/hw/i2c/pmbus_device.h
+++ b/include/hw
Makes it more explicit that 16 bit values are being used
Signed-off-by: Titus Rwantare
---
include/qemu/bitops.h | 26 ++
1 file changed, 26 insertions(+)
diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h
index 03213ce952..887b8f8ce8 100644
--- a/include/qemu
This device has the same register layout as the pca9538, but 4 fewer
gpio pins. This commit lowers the number of pins initialised, and reuses
the pca9538 logic.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/pca_i2c_gpio.c | 18
asymmetric 16-bit test values
- add patch to imply I2C devices on NPCM7xx boards
Since v1:
- addressed comments
- fixed typos in commit messages
Titus Rwantare (5):
bitops.h: add deposit16 function
hw/gpio: add PCA953x i2c GPIO expanders
hw/gpio: add PCA9536 i2c gpio expander
hw/i2c: add cano
The PCA6416 is an i2c device with 16 GPIO pins, the PCA9538 has 8 pins.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/Kconfig | 5 +
hw/gpio/meson.build | 1 +
hw/gpio/pca_i2c_gpio.c | 392
Signed-off-by: Titus Rwantare
---
hw/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index b5aed4aff5..548c10d7fc 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -406,6 +406,7 @@ config XLNX_VERSAL
config NPCM7XX
bool
+imply
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Titus Rwantare
---
hw/i2c/core.c | 8 +---
hw/i2c/trace-events | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/i2c/core.c b/hw/i2c/core.c
index bed594fe59..896da359f5 100644
--- a/hw/i2c/core.c
+++ b/hw/i2c
The PCA6416 is an i2c device with 16 GPIOs.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/arm/Kconfig | 1 +
hw/gpio/Kconfig | 4 +
hw/gpio/meson.build | 1 +
hw/gpio/pca_i2c_gpio.c | 388
This device has the same register layout as the pca9538, but 4 fewer
gpio pins. This commit lowers the number of pins initialised, and reuses
the pca9538 logic.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/pca_i2c_gpio.c | 18 ++
include/hw/gpio
The 8-bit expander has different register offsets than the 16-bit one,
making them incompatible.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/pca_i2c_gpio.c | 94 ++
include/hw/gpio/pca_i2c_gpio.h | 7 +++
2 files changed, 101
io_input", 0x0F00, _abort);
We currently use these to test hardware presence and LEDs in simulation.
Thanks
Since v1:
- addressed comments
- fixed typos in commit messages
Titus Rwantare (4):
hw/gpio: add PCA6416 i2c GPIO expander
hw/gpio: add PCA9538 8-bit GPIO expander
hw/gpio: add
Signed-off-by: Titus Rwantare
---
hw/i2c/core.c | 8 +---
hw/i2c/trace-events | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/i2c/core.c b/hw/i2c/core.c
index d4ba8146bf..c583c1497a 100644
--- a/hw/i2c/core.c
+++ b/hw/i2c/core.c
@@ -161,7 +161,8 @@ static int
On Mon, 6 Feb 2023 at 14:27, Corey Minyard wrote:
>
> On Mon, Feb 06, 2023 at 07:49:34PM +, Titus Rwantare wrote:
> > This is a simple i2c device that allows i2c capable devices to have
> > GPIOs.
> >
> > Reviewed-by: Hao Wu
> > Signed-off-by: Titus R
On Mon, 6 Feb 2023 at 13:38, Philippe Mathieu-Daudé wrote:
>
> Hi Titus,
>
> On 6/2/23 20:49, Titus Rwantare wrote:
> > This is a simple i2c device that allows i2c capable devices to have
> > GPIOs.
> >
> > Reviewed-by: Hao Wu
> > Signed-off-by: Ti
On Mon, 6 Feb 2023 at 17:29, Dong, Eddie wrote:
> > -Original Message-
> > From: qemu-devel-bounces+eddie.dong=intel@nongnu.org > devel-bounces+eddie.dong=intel@nongnu.org> On Behalf Of Titus
> > Rwantare
> > Sent: Monday, February 6, 20
On Mon, 6 Feb 2023 at 19:43, Joel Stanley wrote:
>
> On Mon, 6 Feb 2023 at 19:51, Titus Rwantare wrote:
> >
> > This is a simple i2c device that allows i2c capable devices to have
> > GPIOs.
>
> Nice.
>
> In Linux this is supported by a driver called pca953x.
This is a simple i2c device that allows i2c capable devices to have
GPIOs.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/arm/Kconfig | 1 +
hw/gpio/meson.build | 1 +
hw/gpio/pca_i2c_gpio.c | 362
hw/gpio
The 8-bit expander has different register offsets than the 16-bit one,
making them incompatible.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/pca_i2c_gpio.c | 98 ++
include/hw/gpio/pca_i2c_gpio.h | 7 +++
2 files changed, 105
This device has the same register layout as the pca9538, but 4 fewer
gpio pins. This commit lowers the number of pins intialised, and reuses
the pca9539 logic.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/pca_i2c_gpio.c | 22 ++
include/hw/gpio
io_input", 0x0F00, _abort);
We currently use these to test hardware presence and LEDs in simulation.
Thanks
Titus Rwantare (3):
hw/gpio: add PCA6414 i2c GPIO expander
hw/gpio: add PCA9538 8-bit GPIO expander
hw/gpio: add PCA9536 i2c gpio expander
hw/arm/Kconfig
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/peci/peci-client.c | 63 ++
hw/peci/peci-core.c| 44 +++--
include/hw/peci/peci.h | 23 +++
3 files changed, 128 insertions(+), 2 deletions(-)
diff --git
This allows BMC firmware for npcm7xx BMCs to talk to a PECI client
in qemu.
Signed-off-by: Titus Rwantare
Reviewed-by: Patrick Venture
Reviewed-by: Peter Delevoryas
---
MAINTAINERS| 1 +
hw/arm/Kconfig | 1 +
hw/arm/npcm7xx.c | 9 ++
hw
On Fri, 9 Sept 2022 at 12:48, Peter Delevoryas wrote:
>
> On Tue, Sep 06, 2022 at 10:05:52PM +, Titus Rwantare wrote:
> > Signed-off-by: Titus Rwantare
> > Reviewed-by: Hao Wu
> > ---
...
> > +++ b/include/hw/peci/peci.h
> > @@ -112,6 +112
On Fri, 9 Sept 2022 at 12:58, Peter Delevoryas wrote:
> > +/*
> > + * PECI Client device
> > + * Copyright 2021 Google LLC
> > + *
> > + * SPDX-License-Identifier: GPL-2.0-or-later
>
> Not sure, but I think the SPDX license identifier is supposed to be in
> the first line? Maybe not though. I
On Fri, 9 Sept 2022 at 12:54, Peter Delevoryas wrote:
>
> On Tue, Sep 06, 2022 at 10:05:49PM +, Titus Rwantare wrote:
...
> >
> > This is something that can also be extended as other parameters arise that
> > need
> > to differ between platforms. So far you can
are hard coded, see hw/peci/peci-client.c. I'd like to
gauge interest in what potential users would like to be adjustable at runtime.
I've not written QEMU models that read config files at runtime, something I'd
appreciate guidance on.
Thanks all
Changes in v2:
- rename EndPt to EndPoint
Titus Rwa
config space is exposed due to Intel posting
various platform configuration in PCI config space.
Commands implemented:
- Ping
- GetDIB
- GetTemp
- GetPkgConfig (partial)
Commands not implemented:
- RdIAMSR
- RdPCIConfig
- RdPCIConfigLocal
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
Reviewed
This allows BMC firmware for npcm7xx BMCs to talk to a PECI client
in qemu.
Signed-off-by: Titus Rwantare
Reviewed-by: Patrick Venture
---
MAINTAINERS| 3 +-
hw/arm/Kconfig | 1 +
hw/arm/npcm7xx.c | 9 ++
hw/peci/meson.build
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/peci/peci-client.c | 63 ++
hw/peci/peci-core.c| 44 +++--
include/hw/peci/peci.h | 23 +++
3 files changed, 128 insertions(+), 2 deletions(-)
diff --git
are hard coded, see hw/peci/peci-client.c. I'd like to
gauge interest in what potential users would like to be adjustable at runtime.
I've not written QEMU models that read config files at runtime, something I'd
appreciate guidance on.
Thanks all
Titus Rwantare (3):
hw/peci: add initial suppor
config space is exposed due to Intel posting
various platform configuration in PCI config space.
Commands implemented:
- Ping
- GetDIB
- GetTemp
- GetPkgConfig (partial)
Commands not implemented:
- RdIAMSR
- RdPCIConfig
- RdPCIConfigLocal
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
Reviewed
ot;raa228000"
> #define TYPE_RAA229004 "raa229004"
> +#define ISL_MAX_IC_DEVICE_ID_LEN 16
>
> struct ISLState {
> PMBusDevice parent;
> +
> +uint8_t ic_device_id[ISL_MAX_IC_DEVICE_ID_LEN];
> +uint8_t ic_device_id_len;
> };
>
> OBJECT_DECLARE_SIMPLE_TYPE(ISLState, ISL69260)
> --
> 2.37.0
>
Reviewed-by: Titus Rwantare
and is issued.
> + */
> +void pmbus_idle(PMBusDevice *pmdev);
> +
> extern const VMStateDescription vmstate_pmbus_device;
>
> #define VMSTATE_PMBUS_DEVICE(_field, _state) { \
> --
> 2.37.0
>
Reviewed-by: Titus Rwantare
On Wed, 29 Jun 2022 at 21:52, Peter Delevoryas wrote:
>
> From: Peter Delevoryas
>
> This adds the ISL69259, using all the same functionality as the existing
> ISL69260 but overriding the IC_DEVICE_ID.
>
> Signed-off-by: Peter Delevoryas
> ---
> hw/sensor/isl_pmbus_vr.c | 28
On Wed, 29 Jun 2022 at 23:30, Cédric Le Goater wrote:
>
> On 6/30/22 06:51, Peter Delevoryas wrote:
> > From: Peter Delevoryas
> >
> > This adds the ISL69259, using all the same functionality as the existing
> > ISL69260 but overriding the IC_DEVICE_ID.
> >
> > Signed-off-by: Peter Delevoryas
>
On Tue, 28 Jun 2022 at 20:36, Peter Delevoryas
wrote:
>
> When a pmbus device switches pages, it should clears its output buffer so
> that the next transaction doesn't emit data from the previous page.
>
> Fixes: 3746d5c15e70570b ("hw/i2c: add support for PMBus”)
> Signed-off-by: Peter Delevoryas
On Tue, 28 Jun 2022 at 20:36, Peter Delevoryas
wrote:
>
> Signed-off-by: Peter Delevoryas
> ---
> --- a/hw/i2c/pmbus_device.c
> +++ b/hw/i2c/pmbus_device.c
> @@ -984,6 +984,11 @@ static uint8_t pmbus_receive_byte(SMBusDevice *smd)
> }
> break;
>
> +case PMBUS_IC_DEVICE_ID:
You can take them through the aspeed branch.
Thanks.
-Titus
On Mon, 27 Jun 2022 at 09:33, Cédric Le Goater wrote:
>
> Hello Titus,
>
> On 6/27/22 17:46, Jae Hyun Yoo wrote:
> > Hello,
> >
> > I'm sending a series to add Qualcomm BMC machines that are equipped with
> > Aspeed AST2600 SoC. Also,
fan_pwm2rpm, MAX31785State,
> +MAX31785_TOTAL_NUM_PAGES),
> + VMSTATE_UINT64(mfr_location, MAX31785State),
> +VMSTATE_UINT64(mfr_date, MAX31785State),
> +VMSTATE_UINT64(mfr_serial, MAX31785State),
> +VMSTATE_END_OF_LIST()
> +}
> +};
> +
There's missing indentation here for example.
Thanks,
Titus Rwantare
d to read from all pages\n",
>__func__);
> -pmbus_cml_error(pmdev);
> } else if (pmdev->page > pmdev->num_pages - 1) {
> qemu_log_mask(LOG_GUEST_ERROR,
> "%s: page %d is out of range\n",
> --
> 2.25.1
>
Please also update the stale comment just above, since this is now
specified behaviour.
Reviewed-by: Titus Rwantare
returns
Shengtan Mao (1):
hw/i2c: Added linear mode translation for pmbus devices
Titus Rwantare (8):
hw/i2c: pmbus: add registers
hw/i2c: pmbus: fix error returns and guard against out of range
accesses
hw/i2c: pmbus: add PEC unsupported warning
hw/i2c: pmbus: refactor uint handling
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index c7ec8e5499..ff644c1d4a 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c/pmbus_device.c
@@ -307,6 +307,11 @@ static uint8_t
- add the VOUT_MIN and STATUS_MFR registers
Signed-off-by: Titus Rwantare
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i2c/pmbus_device.c | 24
include/hw/i2c/pmbus_device.h | 3 +++
2 files changed, 27 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
Reviewed-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 3 +
hw/arm/Kconfig | 1 +
hw/sensor/Kconfig| 5 +
hw/sensor/isl_pmbus_vr.c | 211 +
hw/sensor
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
Reviewed-by: Philippe Mathieu-Daudé
---
hw/sensor/isl_pmbus_vr.c | 50 ++
include/hw/sensor/isl_pmbus_vr.h | 1 +
tests/qtest/isl_pmbus_vr-test.c | 72
3 files changed, 123
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Titus Rwantare
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i2c/pmbus_device.c | 18 ++
include/hw/i2c/pmbus_device.h | 20 +++-
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/hw
This change cleans up the inputs to pmbus_receive uint, the length of
received data is contained in PMBusDevice state and doesn't need to be
passed around.
Signed-off-by: Titus Rwantare
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i2c/pmbus_device.c | 18 +-
1 file changed, 9
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
Reviewed-by: Philippe Mathieu-Daudé
---
hw/sensor/isl_pmbus_vr.c | 18 ++
include/hw/sensor/isl_pmbus_vr.h | 1 +
tests/qtest/isl_pmbus_vr-test.c | 8
add self to MAINTAINERS for the PMBus subsystem and related sensors,
and set PMBus as maintained.
Signed-off-by: Titus Rwantare
Reviewed-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fa8adc2618
Signed-off-by: Titus Rwantare
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i2c/pmbus_device.c | 47 ---
include/hw/i2c/pmbus_device.h | 2 ++
2 files changed, 45 insertions(+), 4 deletions(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
Yes, fixed.
On Fri, 4 Mar 2022 at 16:02, Philippe Mathieu-Daudé
wrote:
>
> On 2/3/22 02:50, Titus Rwantare wrote:
> > Signed-off-by: Titus Rwantare
> > ---
> > hw/i2c/pmbus_device.c | 5 +
> > 1 file changed, 5 insertions(+)
> >
> > d
02:50, Titus Rwantare wrote:
> > Signed-off-by: Titus Rwantare
> > ---
> > hw/i2c/pmbus_device.c | 41 -
> > 1 file changed, 40 insertions(+), 1 deletion(-)
>
> > static uint8_t pmbus_receive_byte(SMBusDevice *sm
On Fri, 4 Mar 2022 at 13:43, Corey Minyard wrote:
>
> On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote:
> > v2:
> > - split PMBus commit with updates into individual fixes
> > - renamed isl_pmbus[.ch] adding _vr for voltage regulators
> >
>
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
MAINTAINERS | 3 +
hw/arm/Kconfig | 1 +
hw/sensor/Kconfig| 5 +
hw/sensor/isl_pmbus_vr.c | 211 +
hw/sensor/meson.build| 1 +
include/hw
add self to MAINTAINERS for the PMBus subsystem and related sensors,
and set PMBus as maintained.
Signed-off-by: Titus Rwantare
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fa8adc2618..3601984b5d 100644
--- a/MAINTAINERS
+++ b
Shengtan Mao (1):
hw/i2c: Added linear mode translation for pmbus devices
Titus Rwantare (8):
hw/i2c: pmbus: add registers
hw/i2c: pmbus: guard against out of range accesses
hw/i2c: pmbus: add PEC unsupported warning
hw/i2c: pmbus: refactor uint handling
hw/i2c: pmbus: update MAINTAINERS
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus_vr.c | 50
include/hw/sensor/isl_pmbus_vr.h | 1 +
tests/qtest/isl_pmbus_vr-test.c | 78 ++--
3 files changed, 126 insertions(+), 3 deletions(-)
diff --git a/hw
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 07a45c99f9..93c746bab3 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c
This change cleans up the inputs to pmbus_receive uint, the length of
received data is contained in PMBusDevice state and doesn't need to be
passed around.
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 93c746bab3..6eeb0731d7 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c/pmbus_device.c
@@ -307,6 +307,11 @@ static uint8_t
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus_vr.c | 18 ++
include/hw/sensor/isl_pmbus_vr.h | 1 +
tests/qtest/isl_pmbus_vr-test.c | 8
3 files changed, 27 insertions
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 18 ++
include/hw/i2c/pmbus_device.h | 20 +++-
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c
- add the VOUT_MIN and STATUS_MFR registers
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 24
include/hw/i2c/pmbus_device.h | 3 +++
2 files changed, 27 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 24f8f522d9
The rename is from feedback in v1 by Peter. I did this in a separate
patch as it's easier to merge, compared to editing the 4 commits
affected by this.
Titus
On Tue, 1 Mar 2022 at 16:43, Corey Minyard wrote:
>
> On Tue, Mar 01, 2022 at 04:23:07PM -0800, Titus Rwantare wrote:
> >
Signed-off-by: Titus Rwantare
---
MAINTAINERS | 6 +-
hw/arm/Kconfig| 2 +-
hw/sensor/Kconfig | 2 +-
hw/sensor/{isl_pmbus.c => isl_pmbus_vr.c} | 77 ++---
hw/sensor/meson.bu
[.ch] adding _vr for voltage regulators
Shengtan Mao (1):
hw/i2c: Added linear mode translation for pmbus devices
Titus Rwantare (8):
hw/i2c: pmbus: add registers
hw/i2c: pmbus: guard against out of range accesses
hw/i2c: pmbus: add PEC unsupported warning
hw/i2c: pmbus: refactor uint
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus.c | 18 ++
include/hw/sensor/isl_pmbus.h | 1 +
tests/qtest/isl_pmbus-test.c | 8
3 files changed, 27 insertions(+)
diff
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
MAINTAINERS | 3 +
hw/arm/Kconfig| 1 +
hw/sensor/Kconfig | 5 +
hw/sensor/isl_pmbus.c | 210 ++
hw/sensor/meson.build | 1 +
include/hw/sensor/isl_pmbus.h
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus.c | 50 ++
include/hw/sensor/isl_pmbus.h | 1 +
tests/qtest/isl_pmbus-test.c | 78 +--
3 files changed, 126 insertions(+), 3 deletions(-)
diff --git a/hw
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 07a45c99f9..93c746bab3 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 18 ++
include/hw/i2c/pmbus_device.h | 20 +++-
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c
Signed-off-by: Titus Rwantare
---
MAINTAINERS | 10 ++
hw/i2c/pmbus_device.c | 18 +-
2 files changed, 19 insertions(+), 9 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index fa8adc2618..3601984b5d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3135,6
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 93c746bab3..6eeb0731d7 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c/pmbus_device.c
@@ -307,6 +307,11 @@ static uint8_t
- add the VOUT_MIN and STATUS_MFR registers
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 24
include/hw/i2c/pmbus_device.h | 3 +++
2 files changed, 27 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 24f8f522d9
On Thu, 27 Jan 2022 at 11:39, Peter Maydell wrote:
>
> On Thu, 6 Jan 2022 at 23:19, Titus Rwantare wrote:
> >
> > +static uint8_t isl_pmbus_read_byte(PMBusDevice *pmdev)
> > +{
> > +qemu_log_mask(LOG_GUEST_ERROR,
> > + "%s: re
1 - 100 of 153 matches
Mail list logo
