Re: [PATCH] MAINTAINERS: Remove me as a reviewer for the build and test/avocado

2021-11-23 Thread Willian Rampazzo
On Tue, Nov 23, 2021 at 7:37 AM Philippe Mathieu-Daudé wrote: > > On 11/22/21 20:11, Willian Rampazzo wrote: > > Remove me as a reviewer for the Build and test automation and the > > Integration Testing with the Avocado Framework and add Beraldo > > Leal. > > T

Re: [NOTFORMERGE PATCH 5/5] tests/avocado: Test NetBSD 9.2 on the Jazz Magnum machine

2021-11-22 Thread Willian Rampazzo
gt; + > +# Press cursor control 'Down' to select the "Run a program" menu > +exec_command(self, '\x1b[B') > + > +program = 'scsi(0)cdrom(2)fdisk(0)boot scsi(0)cdrom(2)fdisk(0)netbsd' > +exec_command(self, program) > +wait_for_console_pattern(self, 'NetBSD/arc Bootstrap, Revision 1.1') > + > +# Terminal type? [vt100] > +console_pattern = 'erase ^H, werase ^W, kill ^U, intr ^C, status ^T' > +wait_for_console_pattern(self, console_pattern) > + > +# (I)nstall, (S)hell or (H)alt > +exec_command_and_wait_for_pattern(self, '', 'Erase is backspace.') > +exec_command(self, 'S') > +interrupt_interactive_console_until_pattern(self, '#') > + > +exec_command_and_wait_for_pattern(self, 'ifconfig', 'address: ' + > mac) > +interrupt_interactive_console_until_pattern(self, '#') > + > +exec_command(self, 'ifconfig sn0 10.0.2.3/24') > +interrupt_interactive_console_until_pattern(self, '#') > + > +exec_command_and_wait_for_pattern(self, 'ping -c 3 10.0.2.2', > +'3 packets transmitted, 3 packets received, 0.0% packet > loss') > + > +exec_command_and_wait_for_pattern(self, 'shutdown -r now', > + 'rebooting...') Nice! Except for the nvram.bin.xz, Reviewed-by: Willian Rampazzo

[PATCH] MAINTAINERS: Remove me as a reviewer for the build and test/avocado

2021-11-22 Thread Willian Rampazzo
Remove me as a reviewer for the Build and test automation and the Integration Testing with the Avocado Framework and add Beraldo Leal. Signed-off-by: Willian Rampazzo --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH 5/7] python/machine: handle "fast" QEMU terminations

2021-11-19 Thread Willian Rampazzo
f-by: John Snow Nitpick: double signed-off-by > > Signed-off-by: John Snow > --- > python/qemu/machine/machine.py | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 7/7] python/aqmp: fix send_fd_scm for python 3.6.x

2021-11-19 Thread Willian Rampazzo
d and only go > fishing for forbidden details when we absolutely have to. > > Reported-by: Thomas Huth > Signed-off-by: John Snow > --- > python/qemu/aqmp/qmp_client.py | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH] tests/avocado: ppc: Add smoke tests for MPC7400 and MPC7450 families

2021-11-19 Thread Willian Rampazzo
One more comment, sorry. On Fri, Nov 19, 2021 at 10:54 AM Fabiano Rosas wrote: > > These tests ensure that our emulation for these cpus is not completely > broken and we can at least run OpenBIOS on them. > > $ make check-avocado AVOCADO_TESTS=../tests/avocado/ppc_74xx.py > > Signed-off-by: Fabia

Re: [PATCH] tests/avocado: ppc: Add smoke tests for MPC7400 and MPC7450 families

2021-11-19 Thread Willian Rampazzo
> + > +from avocado import skip You are not using this import in the file. No need to import it here. Removing the unused import, the code looks good to me, so: Reviewed-by: Willian Rampazzo

Re: [PATCH 4/7] python/machine: move more variable initializations to _pre_launch

2021-11-19 Thread Willian Rampazzo
On Thu, Nov 18, 2021 at 5:51 PM John Snow wrote: > > No need to clear them only to set them later. > > Signed-off-by: John Snow > --- > python/qemu/machine/machine.py | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 3/7] python/machine: add instance disambiguator to default nickname

2021-11-19 Thread Willian Rampazzo
ult nickname to foolproof this in all cases. > > Signed-off-by: John Snow > --- > python/qemu/machine/machine.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 2/7] python/machine: remove _remove_monitor_sockfile property

2021-11-19 Thread Willian Rampazzo
igned-off-by: John Snow > --- > python/qemu/machine/machine.py | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 1/7] python/machine: add @sock_dir property

2021-11-19 Thread Willian Rampazzo
ore unique directory to put sockfiles in by default. > > Signed-off-by: John Snow > --- > python/qemu/machine/machine.py | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [qemu-web PATCH] remove deployment phase from CI

2021-11-18 Thread Willian Rampazzo
t; --- > .gitlab-ci.yml | 24 > 1 file changed, 24 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH] gitlab-ci/cirrus: Increase timeout to 80 minutes

2021-11-16 Thread Willian Rampazzo
's increase the timeout on the gitlab side a little bit, so > that these jobs are not marked as failing just because of the delay. > > Signed-off-by: Thomas Huth > --- > .gitlab-ci.d/cirrus.yml | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Willian Rampazzo

Re: [PATCH v1 6/6] gitlab-ci: Split custom-runners.yml in one file per runner

2021-11-16 Thread Willian Rampazzo
ners/centos-stream-8-x86_64.yml > create mode 100644 .gitlab-ci.d/custom-runners/ubuntu-18.04-s390x.yml > create mode 100644 .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml > Reviewed-by: Willian Rampazzo

Re: [PATCH v1 3/6] tests/vm: don't build using TCG by default

2021-11-16 Thread Willian Rampazzo
ned-off-by: Alex Bennée > --- > tests/vm/Makefile.include | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v1 2/6] tests/vm: sort the special variable list

2021-11-16 Thread Willian Rampazzo
deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH] gitlab: skip cirrus jobs on master and stable branches

2021-11-16 Thread Willian Rampazzo
erges to the stable branches. > > User forks meanwhile should be allowed to run Cirrus CI jobs freely. > > Signed-off-by: Daniel P. Berrangé > --- > .gitlab-ci.d/cirrus.yml | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Willian Rampazzo

Re: [PATCH v2 1/1] Jobs based on custom runners: add CentOS Stream 8

2021-11-12 Thread Willian Rampazzo
e > create mode 100755 scripts/ci/org.centos/stream/8/x86_64/test-avocado > create mode 100644 scripts/ci/org.centos/stream/README > Maybe it is too late, but just for the records: Reviewed-by: Willian Rampazzo Tested-by: Willian Rampazzo CI job on a custom VM runner: https://gitlab.com/willianrampazzo/qemu/-/jobs/1778451942

Re: [PATCH] tests/avocado: Remove p7zip binary availability check

2021-11-08 Thread Willian Rampazzo
> > Signed-off-by: Philippe Mathieu-Daudé > --- > Based-on: <20211105155354.154864-1-willi...@redhat.com> > --- > tests/avocado/boot_linux_console.py | 7 --- > 1 file changed, 7 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v2 1/2] tests/acceptance: introduce new check-avocado tartget

2021-11-08 Thread Willian Rampazzo
On Mon, Nov 8, 2021 at 6:49 AM Philippe Mathieu-Daudé wrote: > > On 11/8/21 10:24, Daniel P. Berrangé wrote: > > On Mon, Nov 08, 2021 at 08:59:51AM +0100, Thomas Huth wrote: > >> On 05/11/2021 16.53, Willian Rampazzo wrote: > >>> This introduces a new `make` ta

[PATCH v2 0/2] tests/acceptance: rename tests acceptance to tests avocado

2021-11-05 Thread Willian Rampazzo
deprecate warning message when it is used. (Suggested-by: Philippe Mathieu-Daudé) - Remove unrelated changes. Signed-off-by: Willian Rampazzo Willian Rampazzo (2): tests/acceptance: introduce new check-avocado tartget tests/acceptance: rename tests acceptance to tests avocado .gitlab-ci.d

Re: [PATCH] docs/about/deprecated: Remove empty 'related binaries' section

2021-11-05 Thread Willian Rampazzo
too. > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/about/deprecated.rst | 3 --- > 1 file changed, 3 deletions(-) > Reviewed-by: Willian Rampazzo

[PATCH v2 2/2] tests/acceptance: rename tests acceptance to tests avocado

2021-11-05 Thread Willian Rampazzo
files and the documentation. [1] https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg06553.html For the Orange Pi PC documentation: Reviewed-by: Niek Linnenbank Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Willian Rampazzo --- .gitlab-ci.d/buildtest

[PATCH v2 1/2] tests/acceptance: introduce new check-avocado tartget

2021-11-05 Thread Willian Rampazzo
release and leave the warning to force people to move to the new `check-avocado` target. Later, the `check-acceptance` target can be removed. The intent is to avoid a direct impact during the current soft freeze. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Willian Rampazzo --- docs

Re: [PATCH 1/1] tests/acceptance: rename tests acceptance to tests avocado

2021-11-04 Thread Willian Rampazzo
On Thu, Nov 4, 2021 at 9:50 AM Philippe Mathieu-Daudé wrote: > > On 11/3/21 22:14, Willian Rampazzo wrote: > > In the discussion about renaming the `tests/acceptance` [1], the > > conclusion was that the folders inside `tests` are related to the > > framework running th

[PATCH 1/1] tests/acceptance: rename tests acceptance to tests avocado

2021-11-03 Thread Willian Rampazzo
files and the documentation. [1] https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg06553.html Signed-off-by: Willian Rampazzo --- .gitlab-ci.d/buildtest-template.yml | 2 +- .gitlab-ci.d/buildtest.yml| 56 +-- MAINTAINERS

[PATCH 0/1] tests/acceptance: rename tests acceptance to tests avocado

2021-11-03 Thread Willian Rampazzo
files and the documentation. [1] https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg06553.html GitLab pipeline with new naming: https://gitlab.com/willianrampazzo/qemu/-/pipelines/401431592 Signed-off-by: Willian Rampazzo Willian Rampazzo (1): tests/acceptance: rename tests acceptance to

Re: [qemu-web PATCH] remove deployment phase from CI

2021-11-03 Thread Willian Rampazzo
- > .gitlab-ci.yml | 24 > 1 file changed, 24 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 5/6] docker: update 'python' dockerfile to use Fedora registry

2021-11-03 Thread Willian Rampazzo
deletion(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 4/6] docker: update Fedora-based cross-compiler containers to Fedora 34

2021-11-03 Thread Willian Rampazzo
a-cris-cross.docker | 2 +- > tests/docker/dockerfiles/fedora-win32-cross.docker | 2 +- > tests/docker/dockerfiles/fedora-win64-cross.docker | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 3/6] docker: update fedora container to Fedora 34

2021-11-03 Thread Willian Rampazzo
le changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v4 2/6] tests/acceptance: Make pick_default_qemu_bin() more generic

2021-11-01 Thread Willian Rampazzo
@ class Test(QemuBaseTest): > def setUp(self): > self._vms = {} > > -super(Test, self).setUp() > +super(Test, self).setUp('qemu-system-') If you need to change something else in this patch, consider using PEP3135: super().setUp('qemu-system-') Anyway, Reviewed-by: Willian Rampazzo > > self.machine = self.params.get('machine', > > default=self._get_unique_tag_val('machine')) > -- > 2.31.1 >

Re: [PATCH v4 4/6] tests/acceptance: Share useful helpers from virtiofs_submounts test

2021-11-01 Thread Willian Rampazzo
/acceptance/avocado_qemu/__init__.py | 57 ++ > tests/acceptance/virtiofs_submounts.py| 59 +-- > 2 files changed, 59 insertions(+), 57 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v4 6/6] tests/acceptance: Rename avocado_qemu.Test -> QemuSystemTest

2021-11-01 Thread Willian Rampazzo
tches, you don't need this change here. > > self.machine = self.params.get('machine', > > default=self._get_unique_tag_val('machine')) > @@ -515,11 +512,11 @@ def default_kernel_params(self): > return self._info.get('kernel_params', None) > > > -class LinuxTest(Test, LinuxSSHMixIn): > +class LinuxTest(QemuSystemTest, LinuxSSHMixIn): > """Facilitates having a cloud-image Linux based available. > > For tests that indend to interact with guests, this is a better choice If you touch this patch again, please, s/indend/intend/ So far, looks good to me Reviewed-by: Willian Rampazzo

Re: [PATCH v4 3/6] tests/acceptance: Introduce QemuUserTest base class

2021-11-01 Thread Willian Rampazzo
ldpath in self._ldpath]) > +bin_args = " ".join(args) > +return process.run("%s %s %s %s" % (self.qemu_bin, qemu_args, > + bin_path, bin_args)) > + > + > class LinuxSSHMixIn: > """Contains utility methods for interacting with a guest via SSH.""" Besides some Python related suggestions, the code looks good. Reviewed-by: Willian Rampazzo > > -- > 2.31.1 >

Re: [PATCH v4 1/6] tests/acceptance: Extract QemuBaseTest from Test

2021-11-01 Thread Willian Rampazzo
; -def fetch_asset(self, name, > -asset_hash=None, algorithm=None, > -locations=None, expire=None, > -find_only=False, cancel_on_missing=True): > -return super(Test, self).fetch_asset(name, > -asset_hash=asset_hash, > -algorithm=algorithm, > -locations=locations, > -expire=expire, > -find_only=find_only, > -cancel_on_missing=cancel_on_missing) > - > > class LinuxSSHMixIn: > """Contains utility methods for interacting with a guest via SSH.""" > -- > 2.31.1 > Except for one (or two, if you consider the first) small comment, looks good to me, so Reviewed-by: Willian Rampazzo

Re: [PATCH v4 5/6] tests/acceptance: Add bFLT loader linux-user test

2021-11-01 Thread Willian Rampazzo
B TIME : 0.54 s > > Reviewed-by: Willian Rampazzo > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/load_bflt.py | 54 +++ > 1 file changed, 54 insertions(+) > create mode 100644 tests/acceptance/load_bflt.py > > d

Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

2021-10-26 Thread Willian Rampazzo
er-template.yml | 11 ++- > .gitlab-ci.d/edk2.yml | 11 ++- > .gitlab-ci.d/opensbi.yml| 11 ++- > 3 files changed, 30 insertions(+), 3 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v1 09/28] tests/docker: split PARTIAL into PARTIAL and VIRTUAL images

2021-10-26 Thread Willian Rampazzo
ile.include | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v1 05/28] tests/docker: Add debian-nios2-cross image

2021-10-26 Thread Willian Rampazzo
sh | 87 +++ > .../dockerfiles/debian-toolchain.docker | 36 > 4 files changed, 149 insertions(+) > create mode 100755 > tests/docker/dockerfiles/debian-nios2-cross.d/build-toolchain.sh > create mode 100644 tests/docker/dockerfiles/debian-toolchain.docker > Reviewed-by: Willian Rampazzo

Re: [PATCH v1 06/28] tests/docker: Add debian-microblaze-cross image

2021-10-26 Thread Willian Rampazzo
ed, 95 insertions(+) > create mode 100755 > tests/docker/dockerfiles/debian-microblaze-cross.d/build-toolchain.sh > Reviewed-by: Willian Rampazzo

Re: [PATCH v1 04/28] gitlab-ci: Remove special casing for hexagon testing

2021-10-26 Thread Willian Rampazzo
Id: <20211014224435.2539547-5-richard.hender...@linaro.org> > --- > .gitlab-ci.d/buildtest.yml | 4 > .gitlab-ci.d/container-cross.yml | 27 +++ > 2 files changed, 3 insertions(+), 28 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 16/16] tests/acceptance/ppc_prep_40p.py: unify tags

2021-10-06 Thread Willian Rampazzo
On Wed, Oct 6, 2021 at 4:17 PM Willian Rampazzo wrote: > > On Fri, Sep 24, 2021 at 4:01 PM Cleber Rosa wrote: > > > > The arch and machine tags apply to all tests, so let's define them > > only once. > > > > Signed-off-by: Cleber Rosa > >

Re: [PATCH 16/16] tests/acceptance/ppc_prep_40p.py: unify tags

2021-10-06 Thread Willian Rampazzo
8 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 13/16] tests/acceptance/boot_xen.py: use class attribute

2021-10-06 Thread Willian Rampazzo
On Fri, Sep 24, 2021 at 3:59 PM Cleber Rosa wrote: > > Rather than defining a single use variable, let's just use the class > attribute directly. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/boot_xen.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletio

Re: [PATCH 09/16] tests/acceptance/boot_xen.py: merge base classes

2021-10-06 Thread Willian Rampazzo
the opportunity to add some future improvements in a clearer > fashion. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/boot_xen.py | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 10/16] tests/acceptance/boot_xen.py: unify tags

2021-10-06 Thread Willian Rampazzo
changed, 5 insertions(+), 21 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 11/16] tests/acceptance/boot_xen.py: fetch kernel during test setUp()

2021-10-06 Thread Willian Rampazzo
; Signed-off-by: Cleber Rosa > --- > tests/acceptance/boot_xen.py | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 03/16] Acceptance Tests: add mechanism for listing tests

2021-10-06 Thread Willian Rampazzo
On Fri, Sep 24, 2021 at 3:57 PM Cleber Rosa wrote: > > It is helpful to know the tests that would be executed with a "make > check-acceptance" without executing them. Let's introduce a "make > list-acceptance" rule for that purpose. > > Signed-off-by: Cleber Rosa > --- > tests/Makefile.include

Re: [PATCH 01/16] Acceptance Tests: bump Avocado requirement to 91.0

2021-10-06 Thread Willian Rampazzo
s/requirements.txt b/tests/requirements.txt > index a21b59b443..40af24c664 100644 > --- a/tests/requirements.txt > +++ b/tests/requirements.txt > @@ -1,5 +1,5 @@ > # Add Python module requirements, one per line, to be installed > # in the tests/venv Python virtual environment. For more info, > # refer to: https://pip.pypa.io/en/stable/user_guide/#id1 > -avocado-framework==88.1 > +avocado-framework==91.0 > pycdlib==1.11.0 > -- > 2.31.1 > Apart from a tiny documentation change, the code is welcome as it allows using the new Avocado runner. Reviewed-by: Willian Rampazzo

Re: [RFC PATCH] .github: move repo lockdown to the v2 configuration

2021-10-04 Thread Willian Rampazzo
qemu-project/qemu.git. > +The project does not process merge requests filed on GitHub. > + > +QEMU welcomes contributions of code (either fixing bugs or > adding new > +functionality). However, we get a lot of patches, and so we have > some > +guidelines about contributing on the project website: > +https://www.qemu.org/contribute/ > + lock-pull: true > + close-pull: true > -- > 2.30.2 > > Besides the "issues" comment, it looks good to me. Reviewed-by: Willian Rampazzo

Re: [PATCH v3] nbd/server: Add --selinux-label option

2021-09-30 Thread Willian Rampazzo
On Thu, Sep 30, 2021 at 5:55 AM Vladimir Sementsov-Ogievskiy wrote: > > 9/30/21 11:47, Richard W.M. Jones wrote: > > Under SELinux, Unix domain sockets have two labels. One is on the > > disk and can be set with commands such as chcon(1). There is a > > different label stored in memory (called t

Re: [PATCH 4/6] avocado_qemu: tweak ssh connect method

2021-09-27 Thread Willian Rampazzo
On Mon, Sep 27, 2021 at 11:12 AM Philippe Mathieu-Daudé wrote: > > On 9/20/21 22:49, Willian Rampazzo wrote: > > The current implementation will crash if the connection fails as the > > `time` module is not imported. This fixes the import problem and tweaks > >

Re: [PATCH 05/16] Acceptance Tests: add standard clean up at test tearDown()

2021-09-24 Thread Willian Rampazzo
Hi, Cleber, On Fri, Sep 24, 2021 at 3:57 PM Cleber Rosa wrote: > > The avocado.Test class, used as the basis of the avocado_qemu.Test > class, performs a clean of temporary directories up as part of its own > tearDown() implementation. > > But the avocado_qemu.Test class is currently missing the

[PATCH v3 1/3] tests/Makefile: allow control over tags during check-acceptance

2021-09-23 Thread Willian Rampazzo
tests should run based on the tags defined. This also makes the check-acceptance command flexible to restrict tests based on tags while running on CI. e.g.: AVOCADO_TAGS="foo bar baz" make check-acceptance Signed-off-by: Willian Rampazzo Tested-by: Wainer dos Santos Moschetta R

[PATCH v3 3/3] tests/Makefile: add AVOCADO_TESTS option to make check-acceptance

2021-09-23 Thread Willian Rampazzo
Add the possibility of running all the tests from a single file, or multiple files, running a single test within a file or multiple tests within multiple files using `make check-acceptance` and the AVOCADO_TESTS environment variable. Suggested-by: Daniel P. Berrangé Signed-off-by: Willian

[PATCH v3 2/3] docs/devel/testing: add instruction to run a single acceptance test

2021-09-23 Thread Willian Rampazzo
Add instructions to the Acceptance tests section about running a single test file or a test within the test file. Signed-off-by: Willian Rampazzo --- docs/devel/testing.rst | 28 1 file changed, 28 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel

[PATCH v3 0/3] tests/Makefile: improvements on make check-acceptance

2021-09-23 Thread Willian Rampazzo
implementation patch to the series. Changes from V1: - Rename TESTFILES to AVOCADO_TEST_FILES on patch 2 - Add Suggested-by tag on patch 2 Willian Rampazzo (3): tests/Makefile: allow control over tags during check-acceptance docs/devel/testing: add instruction to run a single acceptance test

Re: [PATCH 2/2] tests/Makefile: add TESTFILES option to make check-acceptance

2021-09-23 Thread Willian Rampazzo
On Thu, Sep 23, 2021 at 6:42 AM Daniel P. Berrangé wrote: > > On Thu, Sep 23, 2021 at 11:34:18AM +0200, Philippe Mathieu-Daudé wrote: > > On 9/22/21 21:46, Willian Rampazzo wrote: > > > On Wed, Sep 22, 2021 at 4:08 PM Philippe Mathieu-Daudé > > > wrote: > > &

Re: [PATCH 1/2] docs/devel/testing: add instruction to run a single acceptance test

2021-09-23 Thread Willian Rampazzo
On Thu, Sep 23, 2021 at 5:27 AM Daniel P. Berrangé wrote: > > On Wed, Sep 22, 2021 at 04:03:23PM -0300, Willian Rampazzo wrote: > > Add instructions to the Acceptance tests section about running a > > single test file or a test within the test file. > > > > S

[PATCH v2 1/2] docs/devel/testing: add instruction to run a single acceptance test

2021-09-22 Thread Willian Rampazzo
Add instructions to the Acceptance tests section about running a single test file or a test within the test file. Signed-off-by: Willian Rampazzo --- docs/devel/testing.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index

[PATCH v2 2/2] tests/Makefile: add AVOCADO_TEST_FILES option to make check-acceptance

2021-09-22 Thread Willian Rampazzo
Add the possibility of running all the tests from a single file, or multiple files, running a single test within a file or multiple tests within multiple files using `make check-acceptance` and the AVOCADO_TEST_FILES environment variable. Suggested-by: Daniel P. Berrangé Signed-off-by: Willian

[PATCH v2 0/2] docs/devel/testing: improvements on make check-acceptance

2021-09-22 Thread Willian Rampazzo
Changes from V1: - Rename TESTFILES to AVOCADO_TEST_FILES on patch 2 - Add Suggested-by tag on patch 2 Willian Rampazzo (2): docs/devel/testing: add instruction to run a single acceptance test tests/Makefile: add AVOCADO_TEST_FILES option to make check-acceptance docs/devel/testing.rst | 41

Re: [PATCH 2/2] tests/Makefile: add TESTFILES option to make check-acceptance

2021-09-22 Thread Willian Rampazzo
On Wed, Sep 22, 2021 at 4:08 PM Philippe Mathieu-Daudé wrote: > > On 9/22/21 21:03, Willian Rampazzo wrote: > > Add the possibility of running all the tests from a single file, or > > multiple files, running a single test within a file or multiple tests > > within multiple

[PATCH 2/2] tests/Makefile: add TESTFILES option to make check-acceptance

2021-09-22 Thread Willian Rampazzo
Add the possibility of running all the tests from a single file, or multiple files, running a single test within a file or multiple tests within multiple files using `make check-acceptance` and the TESTFILES environment variable. Signed-off-by: Willian Rampazzo --- docs/devel/testing.rst | 27

[PATCH 0/2] docs/devel/testing: improvements on make check-acceptance

2021-09-22 Thread Willian Rampazzo
Willian Rampazzo (2): docs/devel/testing: add instruction to run a single acceptance test tests/Makefile: add TESTFILES option to make check-acceptance docs/devel/testing.rst | 41 + tests/Makefile.include | 5 - 2 files changed, 45 insertions(+), 1

Re: [PATCH v3] tests/acceptance: allow control over tags during check-acceptance

2021-09-22 Thread Willian Rampazzo
Ping? Any good soul to send a pull request? On Tue, Jul 13, 2021 at 6:03 PM Willian Rampazzo wrote: > > Although it is possible to run a specific test using the avocado > command-line, a user may want to use a specific tag while running the > ``make check-acceptance`` during the de

[PATCH 1/2] docs/devel/testing: add instruction to run a single acceptance test

2021-09-22 Thread Willian Rampazzo
Add instructions to the Acceptance tests section about running a single test file or a test within the test file. Signed-off-by: Willian Rampazzo --- docs/devel/testing.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index

Re: [RFC PATCH] tests/docker: add a debian-native image and make available

2021-09-22 Thread Willian Rampazzo
\ > +liblzo2-dev \ > + libgcrypt20-dev \ > +libfdt-dev \ > +librdmacm-dev \ > +libsasl2-dev \ > +libsnappy-dev \ > +libvte-dev \ > +netcat-openbsd \ > +ninja-build \ > +openssh-client \ > +python3-numpy \ > +python3-opencv \ > +python3-venv > + > +ENV QEMU_CONFIGURE_OPTS $QEMU_CONFIGURE_OPTS > +ENV DEF_TARGET_LIST "none" > -- > 2.30.2 > Overall, looks good to me, Acked-by: Willian Rampazzo

Re: [PATCH 2/6] avocado_qemu: standardize supper() call following PEP3135

2021-09-20 Thread Willian Rampazzo
Ouch, s/supper/super/ in the email title. On Mon, Sep 20, 2021 at 5:52 PM Willian Rampazzo wrote: > > PEP3135 states when calling super(), there is no need to use arguments. > This changes the calls on avocado_qemu to standardize according to > PEP3135 and avoid warnings from linters

[PATCH 6/6] avocado_qemu: fix inheritance order on LinuxTest class

2021-09-20 Thread Willian Rampazzo
Class hierarchy on Python is defined from right to left. Although the current code is not harmful, let's fix it to avoid problems in the future. Signed-off-by: Willian Rampazzo --- tests/acceptance/avocado_qemu/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH 5/6] avocado_qemu: explicitly return None to avoid R1710

2021-09-20 Thread Willian Rampazzo
The linter is complaining the `pick_default_qemu_bin` is not explicitly returning None. Fix it to explicitly return None and avoid R1710 inconsistent-return-statements. Signed-off-by: Willian Rampazzo --- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 4/6] avocado_qemu: tweak ssh connect method

2021-09-20 Thread Willian Rampazzo
The current implementation will crash if the connection fails as the `time` module is not imported. This fixes the import problem and tweaks the connection to wait progressively when the connection fails. Signed-off-by: Willian Rampazzo --- tests/acceptance/avocado_qemu/__init__.py | 4 ++-- 1

[PATCH 3/6] avocado_qemu: fix import module based on isort

2021-09-20 Thread Willian Rampazzo
Signed-off-by: Willian Rampazzo --- tests/acceptance/avocado_qemu/__init__.py | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py index d2077d63cd..edb9ed7485 100644 --- a

[PATCH 1/6] Acceptance Tests: add standard clean up at test tearDown()

2021-09-20 Thread Willian Rampazzo
). Reported-by: Peter Maydell Signed-off-by: Cleber Rosa [willianr: respin to new Python super format] Signed-off-by: Willian Rampazzo --- v2 - adjust super call to conform with PEP3135 --- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/acceptan

[PATCH 0/6] avocado_qemu: small fixes and tweaks

2021-09-20 Thread Willian Rampazzo
://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05117.html for completeness. Cleber Rosa (1): Acceptance Tests: add standard clean up at test tearDown() Willian Rampazzo (5): avocado_qemu: standardize supper() call following PEP3135 avocado_qemu: fix import module based on isort

[PATCH 2/6] avocado_qemu: standardize supper() call following PEP3135

2021-09-20 Thread Willian Rampazzo
PEP3135 states when calling super(), there is no need to use arguments. This changes the calls on avocado_qemu to standardize according to PEP3135 and avoid warnings from linters. Signed-off-by: Willian Rampazzo --- tests/acceptance/avocado_qemu/__init__.py | 4 ++-- 1 file changed, 2

Re: [PATCH 0/2] Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry

2021-09-20 Thread Willian Rampazzo
On Mon, Sep 20, 2021 at 10:59 AM Peter Maydell wrote: > > On Tue, 3 Aug 2021 at 20:35, Cleber Rosa wrote: > > > > This is a reply to an issue[1] reported by Peter, and while at it, an > > update of the MAINTAINERS entry so other people now the status and > > where to go for help with regards to t

[PATCH v2] Acceptance Tests: add standard clean up at test tearDown()

2021-09-20 Thread Willian Rampazzo
). Reported-by: Peter Maydell Signed-off-by: Cleber Rosa [willianr: respin to new Python super format] Signed-off-by: Willian Rampazzo --- v2 - adjust super call to conform with PEP3135 --- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/acceptan

Re: how do I run a single acceptance test?

2021-09-20 Thread Willian Rampazzo
Hi, Peter, On Mon, Sep 20, 2021 at 7:56 AM Peter Maydell wrote: > > Hi; I'm trying to bisect a problem that's causing an acceptance > test failure, but docs/devel/testing.rst doesn't have any info about > how to run just one acceptance test rather than the whole lot > via 'make check-acceptance'.

Re: [PATCH 1/2] python: Update for pylint 2.10

2021-09-16 Thread Willian Rampazzo
/qemu/machine/machine.py | 7 ++- > python/setup.cfg | 1 + > 2 files changed, 7 insertions(+), 1 deletion(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 2/2] python: pylint 2.11 support

2021-09-16 Thread Willian Rampazzo
+), 1 deletion(-) > Reviewed-by: Willian Rampazzo

Re: [RFC 1/1] docs/deve/ci-plan: define a high-level plan for the QEMU GitLab CI

2021-09-15 Thread Willian Rampazzo
On Wed, Sep 15, 2021 at 11:07 AM Daniel P. Berrangé wrote: > > On Wed, Sep 15, 2021 at 10:51:56AM -0300, Willian Rampazzo wrote: > > On Wed, Sep 15, 2021 at 6:00 AM Daniel P. Berrangé > > wrote: > > > > > > On Tue, Sep 14, 2021 at 03:48:30PM -0300, Willian

Re: [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus

2021-09-15 Thread Willian Rampazzo
> Signed-off-by: Daniel P. Berrangé > --- > .gitlab-ci.d/cirrus.yml | 2 +- > .gitlab-ci.d/cirrus/build.yml | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 2/2] gitlab: Add cross-riscv64-system, cross-riscv64-user

2021-09-15 Thread Willian Rampazzo
On Tue, Sep 14, 2021 at 3:58 PM Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > .gitlab-ci.d/crossbuilds.yml | 14 ++ > 1 file changed, 14 insertions(+) > Reviewed-by: Willian Rampazzo

Re: [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure

2021-09-15 Thread Willian Rampazzo
> 1 file changed, 16 insertions(+) > Reviewed-by: Willian Rampazzo

Re: [RFC 1/1] docs/deve/ci-plan: define a high-level plan for the QEMU GitLab CI

2021-09-15 Thread Willian Rampazzo
On Wed, Sep 15, 2021 at 6:00 AM Daniel P. Berrangé wrote: > > On Tue, Sep 14, 2021 at 03:48:30PM -0300, Willian Rampazzo wrote: > > This adds a high-level plan for the QEMU GitLab CI based on use cases. > > The idea is to have a base for evolving the QEMU CI.

Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure

2021-09-14 Thread Willian Rampazzo
On Tue, Sep 14, 2021 at 4:18 PM Peter Maydell wrote: > > On Mon, 13 Sept 2021 at 11:19, Peter Maydell wrote: > > > > Currently we define a lot of jobs for our custom runners: > > for both aarch64 and s390x we have > > - all-linux-static > > - all > > - alldbg > > - clang (manual) > > - tci >

[RFC 1/1] docs/deve/ci-plan: define a high-level plan for the QEMU GitLab CI

2021-09-14 Thread Willian Rampazzo
This adds a high-level plan for the QEMU GitLab CI based on use cases. The idea is to have a base for evolving the QEMU CI. It sets high-level characteristics for the QEMU CI use cases, which helps guide its development. Signed-off-by: Willian Rampazzo --- docs/devel/ci-plan.rst | 77

[RFC 0/1] docs/deve/ci-plan: define a high-level plan for the QEMU GitLab CI

2021-09-14 Thread Willian Rampazzo
the implementation details during the KVM Forum. Willian Rampazzo (1): docs/deve/ci-plan: define a high-level plan for the QEMU GitLab CI docs/devel/ci-plan.rst | 77 ++ docs/devel/ci.rst | 1 + 2 files changed, 78 insertions(+) create mode 100644

Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure

2021-09-13 Thread Willian Rampazzo
for s390x and aarch64 hosts from > the ad-hoc CI to gitlab. > > Signed-off-by: Peter Maydell > --- > .gitlab-ci.d/custom-runners.yml | 20 ++++ > 1 file changed, 8 insertions(+), 12 deletions(-) > Reviewed-by: Willian Rampazzo

[PATCH v2 1/1] docs: add definitions of terms for CI/testing

2021-08-31 Thread Willian Rampazzo
"Flaky tests", "Gating", and "Continuous Integration". Signed-off-by: Willian Rampazzo Reviewed-by: Philippe Mathieu-Daudé --- docs/devel/ci-definitions.rst | 121 ++ docs/devel/ci.rst | 1 + 2 files changed, 122 inserti

[PATCH v2 0/1] docs: add definitions of terms for CI/testing

2021-08-31 Thread Willian Rampazzo
"Flaky tests", "Gating", and "Continuous Integration". Signed-off-by: Willian Rampazzo - Changes from v1: - Add Philippe R-b - Remove reference to Daniel's document split patch. Willian Rampazzo (1): docs: add definitions of terms for CI/testing docs/de

Re: [PATCH v2 0/2] hw/arm/raspi: Remove deprecated raspi2/raspi3 aliases

2021-08-27 Thread Willian Rampazzo
Hi, Phil, On Thu, Aug 26, 2021 at 1:49 PM Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 7/9/21 6:00 PM, Peter Maydell wrote: > > On Fri, 9 Jul 2021 at 16:33, Peter Maydell wrote: > >> > >> On Thu, 8 Jul 2021 at 15:55, Philippe Mathieu-Daudé > >> wrote: > >>> > >>> Since v1: > >>> - rename

Re: [PATCH v3 1/2] tests: Remove uses of deprecated raspi2/raspi3 machine names

2021-08-27 Thread Willian Rampazzo
| 2 +- > tests/acceptance/boot_linux_console.py | 6 ++-- > 7 files changed, 32 insertions(+), 32 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 1/2] docs: split the CI docs into two files

2021-08-24 Thread Willian Rampazzo
40 ++ > docs/devel/ci-runners.rst | 117 > docs/devel/ci.rst | 159 +- > 3 files changed, 159 insertions(+), 157 deletions(-) > create mode 100644 docs/devel/ci-jobs.rst > create mode 100644 docs/devel/ci

[PATCH 1/2] docs: split the CI docs into two files

2021-08-20 Thread Willian Rampazzo
From: Daniel P. Berrangé This splits the CI docs into one file talking about job setup and usage and another file describing provisioning of custom runners. Signed-off-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210812180403.4129067-2-berra...@redhat.com> --- doc

[PATCH 2/2] docs: add definitions of terms for CI/testing

2021-08-20 Thread Willian Rampazzo
"Flaky tests", "Gating", and "Continuous Integration". The first patch was borrowed from 20210812180403.4129067-1-berra...@redhat.com. Signed-off-by: Willian Rampazzo --- docs/devel/ci-definitions.rst | 121 ++ docs/devel/ci.rst

[PATCH 0/2] docs: add definitions of terms for CI/testing

2021-08-20 Thread Willian Rampazzo
"Flaky tests", "Gating", and "Continuous Integration". The first patch was borrowed from 20210812180403.4129067-1-berra...@redhat.com. Signed-off-by: Willian Rampazzo Daniel P. Berrangé (1): docs: split the CI docs into two files Willian Rampazzo (1): docs: a

Re: [PATCH] build: remove redundant 'check-build' make target

2021-08-10 Thread Willian Rampazzo
- > .gitlab-ci.d/buildtest.yml | 9 - > .gitlab-ci.d/crossbuild-template.yml | 6 +++--- > tests/Makefile.include | 3 --- > 3 files changed, 3 insertions(+), 15 deletions(-) > Reviewed-by: Willian Rampazzo

  1   2   3   4   5   >