Re: [PATCH 4/5 v4] KVM: VMX: Fill in conforming vmx_x86_ops via macro

2020-11-10 Thread Xu, Like
On 2020/11/11 3:02, Krish Sadhukhan wrote: On 11/9/20 5:49 PM, Like Xu wrote: Hi Krish, On 2020/11/10 9:23, Krish Sadhukhan wrote: @@ -1192,7 +1192,7 @@ void vmx_set_host_fs_gs(struct vmcs_host_state *host, u16 fs_sel, u16 gs_sel,   }   }   -void vmx_prepare_switch_to_guest(struct kvm_vc

Re: [PATCH] target/i386: add -cpu,lbr=true support to enable guest LBR

2020-09-28 Thread Xu, Like
Hi Eduardo, On 2020/9/28 23:41, Eduardo Habkost wrote: On Mon, Sep 28, 2020 at 10:51:03PM +0800, Xu, Like wrote: Hi Eduardo, Thanks for your detailed review. On 2020/9/25 6:05, Eduardo Habkost wrote: I've just noticed this on my review queue (apologies for the long delay). Comments

Re: [PATCH] target/i386: add -cpu,lbr=true support to enable guest LBR

2020-09-28 Thread Xu, Like
Hi Eduardo, Thanks for your detailed review. On 2020/9/25 6:05, Eduardo Habkost wrote: I've just noticed this on my review queue (apologies for the long delay). Comments below: On Sun, Jul 26, 2020 at 11:32:20PM +0800, Like Xu wrote: The LBR feature would be enabled on the guest if: - the KV

Re: [Qemu-devel] [PATCH v1 2/5] vl.c: add -smp, dies=* command line support

2019-01-14 Thread Xu, Like
> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, January 15, 2019 4:52 AM > To: Like Xu > Cc: qemu-devel@nongnu.org; Xu, Like ; > imamm...@redhat.com; drjo...@redhat.com; Michael S. Tsirkin > ; Marcelo Tosatti ; Marcel > A

Re: [Qemu-devel] [PATCH v1 1/5] cpu: introduce die, the new cpu toppolgy emulation level

2019-01-14 Thread Xu, Like
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, January 15, 2019 4:08 AM > To: Like Xu ; qemu-devel@nongnu.org > Cc: drjo...@redhat.com; Peter Crosthwaite > ; Eduardo Habkost ; > Michael S. Tsirkin ; Xu, Like ; > Marcelo Tosatti ;