Re: [PATCH v2] target/arm/cpu: adjust virtual time for arm cpu

2020-06-04 Thread Ying Fang
On 6/3/2020 4:26 PM, Andrew Jones wrote: On Wed, Jun 03, 2020 at 10:02:08AM +0800, Ying Fang wrote: Virtual time adjustment was implemented for virt-5.0 machine type, but the cpu property was enabled only for host-passthrough and max cpu model. Let's add it for arm cpu which has the g

[PATCH v2] target/arm/cpu: adjust virtual time for arm cpu

2020-06-02 Thread Ying Fang
Virtual time adjustment was implemented for virt-5.0 machine type, but the cpu property was enabled only for host-passthrough and max cpu model. Let's add it for arm cpu which has the gernic timer feature enabled. Signed-off-by: Ying Fang --- v2: - move kvm_arm_add_vcpu_properties

Re: [PATCH] target/arm/cpu: adjust virtual time for cortex series cpu

2020-06-02 Thread Ying Fang
On 2020/6/1 20:41, Peter Maydell wrote: On Sat, 30 May 2020 at 10:22, Ying Fang wrote: Virtual time adjustment was implemented for virt-5.0 machine type, but the cpu property was enabled only for host-passthrough and max cpu model. Let's add it for arm cortex series cpu which ha

Re: About the kvm-no-adjvtime CPU property

2020-06-02 Thread Ying Fang
On 2020/6/1 20:29, Andrew Jones wrote: On Mon, Jun 01, 2020 at 08:07:31PM +0800, Ying Fang wrote: On 2020/6/1 16:07, Andrew Jones wrote: On Sat, May 30, 2020 at 04:56:26PM +0800, Ying Fang wrote: About the kvm-no-adjvtime CPU property Hi Andrew, To adjust virutal time, a new kvm cpu

Re: About the kvm-no-adjvtime CPU property

2020-06-01 Thread Ying Fang
On 2020/6/1 16:07, Andrew Jones wrote: On Sat, May 30, 2020 at 04:56:26PM +0800, Ying Fang wrote: About the kvm-no-adjvtime CPU property Hi Andrew, To adjust virutal time, a new kvm cpu property kvm-no-adjvtime was introduced to 5.0 virt machine types. However the cpu property was enabled

[PATCH] target/arm/cpu: adjust virtual time for cortex series cpu

2020-05-30 Thread Ying Fang
Virtual time adjustment was implemented for virt-5.0 machine type, but the cpu property was enabled only for host-passthrough and max cpu model. Let's add it for arm cortex series cpu which has the gernic timer feature enabled. Signed-off-by: Ying Fang diff --git a/target/arm/cpu.c b/targe

About the kvm-no-adjvtime CPU property

2020-05-30 Thread Ying Fang
About the kvm-no-adjvtime CPU property Hi Andrew, To adjust virutal time, a new kvm cpu property kvm-no-adjvtime was introduced to 5.0 virt machine types. However the cpu property was enabled only for host-passthrough and max cpu model. As for other cpu model like cortex-a57, cortex-a53, cortex-a

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-04 Thread Ying Fang
Hi, Ike. I think this tricky bug was fixed by Paolo last month. Please try patch https://git.qemu.org/?p=qemu.git;a=commitdiff;h=5710a3e09f9b85801e5ce70797a4a511e5fc9e2c. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs

Re: [RFC PATCH 0/4] async: fix hangs on weakly-ordered architectures

2020-04-08 Thread Ying Fang
On 2020/4/8 23:05, Paolo Bonzini wrote: On 08/04/20 11:12, Ying Fang wrote: On 2020/4/7 22:07, Paolo Bonzini wrote: ARM machines and other weakly-ordered architectures have been suffering for a long time from hangs in qemu-img and qemu-io.  For QEMU binaries these are mitigated by the

Re: [PATCH 5/5] async: use explicit memory barriers

2020-04-08 Thread Ying Fang
and therefore it is even weaker than C11 ATOMIC_RELAXED; on x86, ATOMIC_RELAXED compiles to a locked operation. Analyzed-by: Ying Fang Signed-off-by: Paolo Bonzini --- util/aio-posix.c | 16 ++-- util/aio-win32.c | 17 ++--- util/async.c | 16 --

Re: [RFC PATCH 0/4] async: fix hangs on weakly-ordered architectures

2020-04-08 Thread Ying Fang
On 2020/4/7 22:07, Paolo Bonzini wrote: ARM machines and other weakly-ordered architectures have been suffering for a long time from hangs in qemu-img and qemu-io. For QEMU binaries these are mitigated by the timers that sooner or later fire in the main loop, but these will not happen for the

Re: [PATCH v2] util/async: Add memory barrier to aio_ctx_prepare

2020-04-02 Thread Ying Fang
On 2020/4/2 16:47, Paolo Bonzini wrote: On 02/04/20 04:44, Ying Fang wrote: Normal VM runtime is not affected by this hang since there is always some timer timeout or subsequent io worker come and notify the main thead. To fix this problem, a memory barrier is added to aio_ctx_prepare and it

[PATCH v2] util/async: Add memory barrier to aio_ctx_prepare

2020-04-01 Thread Ying Fang
tx_prepare and it is proved to have the hang fixed in our test. This hang is not observed on the x86 platform however it can be easily reproduced on the aarch64 platform, thus it is architecture related. Not sure if this is revelant to Commit eabc977973103527bbb8fed69c91cfaa6691f8ab Signed-off-b

[PATCH] util/async: Add memory barrier to aio_ctx_prepare

2020-04-01 Thread Ying Fang
tx_prepare and it is proved to have the hang fixed in our test. This hang is not observed on the x86 platform however it can be easily reproduced on the aarch64 platform, thus it is architecture related. Not sure if this is revelant to Commit eabc977973103527bbb8fed69c91cfaa6691f8ab Signed-off-b

[PATCH v2 2/4] acpi/cppc: Add ACPI CPPC registers

2020-02-12 Thread Ying Fang
The Continuous Performance Control Package is used to describe the ACPI CPPC registers. Signed-off-by: Heyi Guo Signed-off-by: Ying Fang --- hw/arm/virt-acpi-build.c| 74 - hw/arm/virt.c | 1 + include/hw/acpi/acpi-defs.h | 32

[PATCH v2 3/4] arm: Add the cpufreq device model

2020-02-12 Thread Ying Fang
same value, since we don't support guest performance scaling. Performance counters are also not emulated and they simply return 1 if readed, and guest should fallback to use the desired performance value as the current performance. Signed-off-by: Heyi Guo Signed-off-by: Ying Fang --- hw

[PATCH v2 4/4] arm: Create the cpufreq device

2020-02-12 Thread Ying Fang
Add the cpufreq device to arm64 virt machine Signed-off-by: Heyi Guo Signed-off-by: Ying Fang --- default-configs/aarch64-softmmu.mak | 1 + hw/acpi/Kconfig | 4 hw/arm/virt.c | 13 + 3 files changed, 18 insertions(+) diff --git a

[PATCH v2 1/4] acpi: Add aml_generic_register

2020-02-12 Thread Ying Fang
The generic register descriptor describes the localtion of a fixed width register within any of the ACPI-defined address space. This is needed to declare the ACPI CPPC registers. Signed-off-by: Heyi Guo Signed-off-by: Ying Fang --- hw/acpi/aml-build.c | 22

[PATCH v2 0/4] arm64: Add the cpufreq device to show cpufreq info to guest

2020-02-12 Thread Ying Fang
work. Ying Fang (4): acpi: Add aml_generic_register acpi/cppc: Add ACPI CPPC registers arm: Add the cpufreq device model arm: Create the cpufreq device default-configs/aarch64-softmmu.mak | 1 + hw/acpi/Kconfig | 4 + hw/acpi/Makefile.objs | 1 + hw

[PATCH 2/4] acpi/cppc: Add ACPI CPPC registers

2020-02-12 Thread Ying Fang
The Continuous Performance Control Package is used to describe the ACPI CPPC registers. Signed-off-by: Heyi Guo Signed-off-by: Ying Fang --- hw/arm/virt-acpi-build.c| 74 - hw/arm/virt.c | 1 + include/hw/acpi/acpi-defs.h | 32

[PATCH 3/4] arm: Add the cpufreq device model

2020-02-12 Thread Ying Fang
same value, since we don't support guest performance scaling. Performance counters are also not emulated and they simply return 1 if readed, and guest should fallback to use the desired performance value as the current performance. Signed-off-by: Heyi Guo Signed-off-by: Ying Fang --- hw

[PATCH 1/4] acpi: Add aml_generic_register

2020-02-12 Thread Ying Fang
The generic register descriptor describes the localtion of a fixed width register within any of the ACPI-defined address space. This is needed to declare the ACPI CPPC registers. Signed-off-by: Heyi Guo Signed-off-by: Ying Fang --- hw/acpi/aml-build.c | 22

[PATCH 0/4] arm64: Add the cpufreq device to show cpufreq info to guest

2020-02-12 Thread Ying Fang
work. Ying Fang (4): acpi: add aml_generic_register acpi/cppc: add ACPI CPPC registers arm_virt: add the cpufreq device model arm_virt: create the cpufreq device default-configs/aarch64-softmmu.mak | 1 + hw/acpi/Kconfig | 4 + hw/acpi/Makefile.objs

[PATCH 4/4] arm: Create the cpufreq device

2020-02-12 Thread Ying Fang
Add the cpufreq device to arm64 virt machine Signed-off-by: Heyi Guo Signed-off-by: Ying Fang --- default-configs/aarch64-softmmu.mak | 1 + hw/acpi/Kconfig | 4 hw/arm/virt.c | 13 + 3 files changed, 18 insertions(+) diff --git a

[Qemu-devel] [PATCH] xhci: Fix memory leak in xhci_kick_epctx

2019-08-27 Thread Ying Fang
qemu_clock_run_all_timers util/qemu-timer.c:692 #10 0xbbdab9a3 in main_loop_wait util/main-loop.c:524 #11 0xbb6ff5e7 in main_loop vl.c:1806 #12 0xbb1e1453 in main vl.c:4488 Signed-off-by: Ying Fang --- hw/usb/hcd-xhci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw

[Qemu-devel] [PATCH] qmp: Fix memory leak in migrate_params_test_apply

2019-08-27 Thread Ying Fang
0xdfd278d7 in os_host_main_loop_wait util/main-loop.c:241 #20 0xdfd278d7 in main_loop_wait util/main-loop.c:517 #21 0xdf67b5e7 in main_loop vl.c:1806 #22 0xdf15d453 in main vl.c:4488 Cc: zhanghailiang Signed-off-by: Ying Fang --- migration/migration.c | 2 ++ 1 file

[Qemu-devel] [PATCH] qmp: Fix memory leak in migrate_params_test_apply

2019-08-27 Thread Ying Fang
0xdfd278d7 in os_host_main_loop_wait util/main-loop.c:241 #20 0xdfd278d7 in main_loop_wait util/main-loop.c:517 #21 0xdf67b5e7 in main_loop vl.c:1806 #22 0xdf15d453 in main vl.c:4488 Cc: zhanghailiang Signed-off-by: Ying Fang --- migration/migration.c | 6 ++ 1 file

[Qemu-devel] [PATCH] xhci: Fix memory leak in xhci_address_slot

2019-08-27 Thread Ying Fang
) Cc: zhanghailiang Signed-off-by: Ying Fang --- hw/usb/hcd-xhci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index f578264948..471759cd4c 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -2161,6 +2161,7 @@ static TRBCCode xhci_address_slot

Re: [Qemu-devel] [PATCH] vnc: fix update stalls

2019-03-05 Thread Ying Fang
his more much likely to happen. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1662260 > Reported-by: Ying Fang > Signed-off-by: Gerd Hoffmann Reviewed-by: Ying Fang > --- > ui/vnc.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/ui/vnc.c b/ui/vnc.c &

[Qemu-devel] [BUG] VNC: client won't send FramebufferUpdateRequest if job in flight is aborted

2019-03-04 Thread Ying Fang
Hi Gerd, Daniel. We noticed that if VncSharePolicy was configured with VNC_SHARE_POLICY_FORCE_SHARED mode and multiple vnc clients opened vnc connections, some clients could go blank screen at high probability. This problem can be reproduced when we regularly reboot suse12sp3 in graphic mode bo

Re: [Qemu-devel] [RFC] Questions on the I/O performance of emulated host cdrom device

2019-01-15 Thread Ying Fang
On 2019/1/16 4:15, John Snow wrote: > > > On 1/8/19 10:20 PM, Ying Fang wrote: >> >> >> On 2019/1/8 20:46, Kevin Wolf wrote: >>> Am 29.12.2018 um 07:33 hat Ying Fang geschrieben: >>>> Hi. >>>> Recently one of our customer complained

Re: [Qemu-devel] [RFC] Questions on the I/O performance of emulated host cdrom device

2019-01-08 Thread Ying Fang
On 2019/1/8 20:46, Kevin Wolf wrote: > Am 29.12.2018 um 07:33 hat Ying Fang geschrieben: >> Hi. >> Recently one of our customer complained about the I/O performance of QEMU >> emulated host cdrom device. >> I did some investigation on it and there was still some p

Re: [Qemu-devel] [RFC] Questions on the I/O performance of emulated host cdrom device

2019-01-06 Thread Ying Fang
ping On 2018/12/29 14:33, Ying Fang wrote: > Hi. > Recently one of our customer complained about the I/O performance of QEMU > emulated host cdrom device. > I did some investigation on it and there was still some point I could not > figure out. So I had to ask for your help. &

Re: [Qemu-devel] [PATCH v4] vhost: Don't abort when vhost-user connection is lost during migration

2017-12-07 Thread Ying Fang
On 2017/12/7 0:34, Michael S. Tsirkin wrote: > On Wed, Dec 06, 2017 at 09:30:27PM +0800, Ying Fang wrote: >> >> On 2017/12/1 22:39, Michael S. Tsirkin wrote: >>> On Fri, Dec 01, 2017 at 01:58:32PM +0800, fangying wrote: >>>> QEMU will abort when vhost-user p

Re: [Qemu-devel] [PATCH v4] vhost: Don't abort when vhost-user connection is lost during migration

2017-12-06 Thread Ying Fang
On 2017/12/1 22:39, Michael S. Tsirkin wrote: > On Fri, Dec 01, 2017 at 01:58:32PM +0800, fangying wrote: >> QEMU will abort when vhost-user process is restarted during migration >> when vhost_log_global_start/stop is called. The reason is clear that >> vhost_dev_set_log returns -1 because network

Re: [Qemu-devel] [PATCH v3] vhost: Cancel migration when vhost-user process restarted during migration

2017-11-29 Thread Ying Fang
On 2017/11/29 17:42, Dr. David Alan Gilbert wrote: > * Ying Fang (fangyi...@huawei.com) wrote: >> >> On 2017/11/28 18:18, Dr. David Alan Gilbert wrote: >>> * fangying (fangyi...@huawei.com) wrote: >>>> QEMU will abort when vhost-user process is

Re: [Qemu-devel] [PATCH v3] vhost: Cancel migration when vhost-user process restarted during migration

2017-11-28 Thread Ying Fang
se network connection is temporarily >> lost. To handle this situation, let's cancel migration here. >> >> Signed-off-by: Ying Fang > > I thought we had agreed not to use migrate_fd_cancel here - that's for > cancelling not erroring. > > Dave We can no

Re: [Qemu-devel] QEMU abort when network serivce is restarted during live migration with vhost-user as the network backend

2017-11-15 Thread Ying Fang
在 2017/11/16 3:39, Dr. David Alan Gilbert 写道: > * Yori Fang (fangyi...@huawei.com) wrote: >> >> >> 在 2017/11/14 19:40, Marc-André Lureau 写道: >>> Hi >>> >>> On Tue, Nov 14, 2017 at 8:09 AM, fangying wrote: Hi all, We have a vm running migration with vhost-user as network backend, we

<    1   2