Hi Paolo,
I have a question before I do a new v12 rebase:
Since patch 5,6,7 fixed CPUID encoding way, should I add the compat
options for older machines to be compatible with past encoding behavior?
Thanks,
Zhao
On Wed, Apr 24, 2024 at 11:49:08PM +0800, Zhao Liu wrote:
> Date: Wed, 24 Apr 2
Hi Stefan,
> QEMU uses clock_gettime(CLOCK_MONOTONIC) on Linux hosts. The man page
> says:
>
> All CLOCK_MONOTONIC variants guarantee that the time returned by
> consecutive calls will not go backwards, but successive calls
> may—depending on the architecture—return identical (not-i
> I'm failing to see what real world technical problems QEMU faces
> with a parameter being set to '1' by a mgmt app, when QEMU itself
> treats all omitted values as being '1' anyway.
>
> If we're trying to faithfully model the real world, then restricting
> the topology against machine types thou
gt; This effectively reverts
>
> commit 54c4ea8f3ae614054079395842128a856a73dbf9
> Author: Zhao Liu
> Date: Sat Mar 9 00:01:37 2024 +0800
>
> hw/core/machine-smp: Deprecate unsupported "parameter=1" SMP
> configurations
>
> but is not done as a
Hi Daniel,
> Please describe it in terms of a QAPI definition, as that's what we're
> striving for with all QEMU public interfaces. Once the QAPI design is
> agreed, then the -object mapping is trivial, as -object's JSON format
> supports arbitrary QAPI structures.
Thank you for your guidance!
I
ate.c | 12 +---
> 4 files changed, 10 insertions(+), 14 deletions(-)
Reviewed-by: Zhao Liu
is.
>
> Signed-off-by: Paolo Bonzini
> ---
> hw/intc/ioapic-stub.c | 29 +
> .gitlab-ci.d/buildtest.yml | 2 +-
> hw/intc/meson.build| 2 +-
> target/i386/Kconfig| 1 +
> 4 files changed, 32 insertions(+), 2 deletions(-)
> create mode 100644 hw/intc/ioapic-stub.c
Reviewed-by: Zhao Liu
6818rtc.h | 2 +-
> hw/i386/monitor.c| 46
> hw/rtc/mc146818rtc.c | 12 ++
> hw/i386/meson.build | 1 +
> 4 files changed, 50 insertions(+), 11 deletions(-)
> create mode 100644 hw/i386/monitor.c
Reviewed-by: Zhao Liu
> hw/i386/x86-cpu.c | 97
> hw/i386/x86.c | 1052 +
> hw/i386/meson.build |4 +-
> 5 files changed, 1113 insertions(+), 1053 deletions(-)
> create mode 100644 hw/i386/x86-common.c
> cre
+
> hw/i386/meson.build | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Zhao Liu
de these fields of MachineClass because they are
> already set to the right value in the superclass.
>
> Signed-off-by: Paolo Bonzini
> ---
> include/hw/i386/x86.h | 4
> hw/i386/pc.c | 3 ---
> hw/i386/x86.c | 6 +++---
> 3 files changed, 3 insertions(+), 10 deletions(-)
Reviewed-by: Zhao Liu
f("%x\n", y);
> }
>
> which prints 5//5 on real hardware and 5//
> on QEMU.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Paolo Bonzini
> ---
> target/i386/tcg/translate.c | 17 +
> 1 file changed, 1 insertion(+), 16 deletions(-)
Awesome!
Reviewed-by: Zhao Liu
cg/i386/test-i386.c | 25 +
> 1 file changed, 25 insertions(+)
Reviewed-by: Zhao Liu
ini
> ---
> target/i386/tcg/decode-new.h | 1 +
> target/i386/tcg/translate.c | 30 --
> target/i386/tcg/decode-new.c.inc | 24 +---
> target/i386/tcg/emit.c.inc | 5 +
> 4 files changed, 27 insertions(+), 33 deletions(-)
Reviewed-by: Zhao Liu
ke no sense if you
> cannot enable XSAVE in the first place.
>
> Signed-off-by: Paolo Bonzini
> ---
> target/i386/cpu.c | 4
> 1 file changed, 4 insertions(+)
Reviewed-by: Zhao Liu
e changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Zhao Liu
Hi Daniel & Shaoqin,
Since x86 also needs to implement PMU filter feature, though it uses
the different KVM ioctl, we can still make the QEMU API as general as
possible.
To move forward with both ARM and x86, I'd like to discuss my API
thinking with you. ;-)
On Mon, Apr 15, 2024 at 06:29:25PM +0
On Wed, May 08, 2024 at 04:23:00PM +0200, Philippe Mathieu-Daudé wrote:
> Date: Wed, 8 May 2024 16:23:00 +0200
> From: Philippe Mathieu-Daudé
> Subject: Re: [PATCH] scripts/simpletrace: Mark output with unstable
> timestamp as WARN
>
> On 8/5/24 15:55, Zhao Liu wrot
On Wed, May 08, 2024 at 02:05:04PM -0400, Stefan Hajnoczi wrote:
> Date: Wed, 8 May 2024 14:05:04 -0400
> From: Stefan Hajnoczi
> Subject: Re: [PATCH] scripts/simpletrace: Mark output with unstable
> timestamp as WARN
>
> On Wed, 8 May 2024 at 00:19, Zhao Liu wrote:
> &g
Hi Philippe,
On Wed, May 08, 2024 at 03:09:39PM +0200, Philippe Mathieu-Daudé wrote:
> Date: Wed, 8 May 2024 15:09:39 +0200
> From: Philippe Mathieu-Daudé
> Subject: Re: [PATCH] scripts/simpletrace: Mark output with unstable
> timestamp as WARN
>
> On 8/5/24 06:32, Zhao Liu
)-pre(8497404908625808) pid=3289596 type=0xc008ae67
arg=0x7ffeefb5aa60
This would help to identify unusual events.
And skip them without updating Formatter2.last_timestamp_ns to avoid
time back.
Signed-off-by: Zhao Liu
---
scripts/simpletrace.py | 11 +++
1 file change
Hi Salil,
On Fri, May 03, 2024 at 07:59:32PM +, Salil Mehta wrote:
> Date: Fri, 3 May 2024 19:59:32 +
> From: Salil Mehta
> Subject: RE: [PATCH V8 3/8] hw/acpi: Update ACPI GED framework to support
> vCPU Hotplug
>
> Hello,
>
> Sorry, I missed this earlie
MSR_KVM_SYSTEM_TIME_NEW and MSR_KVM_WALL_CLOCK_NEW are bound to
kvmclock2 (KVM_FEATURE_CLOCKSOURCE2).
Add the save/load support for these 2 MSRs just like kvmclock MSRs.
Signed-off-by: Zhao Liu
---
target/i386/cpu.h | 2 ++
target/i386/kvm/kvm.c | 16
2 files changed, 18
The KVM_X86_DISABLE_EXITS_HTL typo has been fixed in commit
77d361b13c19 ("linux-headers: Update to kernel mainline commit
b357bf602").
Drop the related workaround.
Signed-off-by: Zhao Liu
---
target/i386/kvm/kvm.c | 4
1 file changed, 4 deletions(-)
diff --git a/target/i386/k
Add feature definitions for KVM_CPUID_FEATURES in CPUID (
CPUID[4000_0001].EAX and CPUID[4000_0001].EDX), to get rid of lots of
offset calculations.
Signed-off-by: Zhao Liu
---
v2: Fixed a typo.
v1: Changed the prefix from CPUID_FEAT_KVM_* to CPUID_KVM_*. (Xiaoyao)
---
hw/i386/kvm/clock.c
Update the comment to match the X86ConfidentialGuestClass
implementation.
Reported-by: Xiaoyao Li
Signed-off-by: Zhao Liu
Reviewed-by: Pankaj Gupta
---
target/i386/confidential-guest.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/confidential-guest.h b
MSR_KVM_SYSTEM_TIME and MSR_KVM_WALL_CLOCK are attached with the (old)
kvmclock feature (KVM_FEATURE_CLOCKSOURCE).
So, just save/load them only when kvmclock (KVM_FEATURE_CLOCKSOURCE) is
enabled.
Signed-off-by: Zhao Liu
---
target/i386/kvm/kvm.c | 12
1 file changed, 8 insertions
://lore.kernel.org/qemu-devel/20240329101954.3954987-1-zhao1@linux.intel.com/
[3]:
https://lore.kernel.org/qemu-devel/2815f0f1-9e20-4985-849c-d74c6cdc9...@intel.com/
Thanks and Best Regards,
Zhao
---
Zhao Liu (6):
target/i386/kvm: Add feature bit definitions for KVM CPUID
target/i386/kvm: Remove local
These 2 MSRs have been already defined in kvm_para.h (standard-headers/
asm-x86/kvm_para.h).
Remove QEMU local definitions to avoid duplication.
Reviewed-by: Xiaoyao Li
Signed-off-by: Zhao Liu
---
target/i386/kvm/kvm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/target/i386/kvm
Hi Tejus,
(Also +Paolo/Daniel)
On Tue, Apr 30, 2024 at 06:14:52AM +, Tejus GK wrote:
> Date: Tue, 30 Apr 2024 06:14:52 +
> From: Tejus GK
> Subject: Re: [PATCH v11 19/21] i386: Add cache topology info in CPUCacheInfo
>
>
>
> On 24 Apr 2024, at 9:1
Hi Xiaoyao,
On Sat, Apr 27, 2024 at 07:05:41AM +0800, Xiaoyao Li wrote:
> Date: Sat, 27 Apr 2024 07:05:41 +0800
> From: Xiaoyao Li
> Subject: Re: [PATCH 6/6] target/i386/confidential-guest: Fix comment of
> x86_confidential_guest_kvm_type()
>
> On 4/26/2024 6:07 PM, Zhao Liu
Hi Zide,
On Fri, Apr 26, 2024 at 10:23:27AM -0700, Chen, Zide wrote:
> Date: Fri, 26 Apr 2024 10:23:27 -0700
> From: "Chen, Zide"
> Subject: Re: [PATCH 1/6] target/i386/kvm: Add feature bit definitions for
> KVM CPUID
>
> On 4/26/2024 3:07 AM, Zhao Liu wrote:
>
MSR_KVM_SYSTEM_TIME_NEW and MSR_KVM_WALL_CLOCK_NEW are bound to new
kvmclock (KVM_FEATURE_CLOCKSOURCE2).
Add the save/load support for these 2 MSRs.
Signed-off-by: Zhao Liu
---
target/i386/cpu.h | 2 ++
target/i386/kvm/kvm.c | 16
2 files changed, 18 insertions(+)
diff
MSR_KVM_SYSTEM_TIME and MSR_KVM_WALL_CLOCK are attached with the (old)
kvmclock feature (KVM_FEATURE_CLOCKSOURCE).
So, just save/load them only when kvmclock (KVM_FEATURE_CLOCKSOURCE) is
enabled.
Signed-off-by: Zhao Liu
---
target/i386/kvm/kvm.c | 12
1 file changed, 8 insertions
MSR_KVM_SYSTEM_TIME_NEW and MSR_KVM_WALL_CLOCK_NEW are bound to
kvmclock2 (KVM_FEATURE_CLOCKSOURCE2).
Add the save/load support for these 2 MSR just like kvmclock MSRs.
Signed-off-by: Zhao Liu
---
target/i386/cpu.h | 2 ++
target/i386/kvm/kvm.c | 16
2 files changed, 18
These 2 MSRs have been already defined in the kvm_para header
(standard-headers/asm-x86/kvm_para.h).
Remove QEMU local definitions to avoid duplication.
Reviewed-by: Xiaoyao Li
Signed-off-by: Zhao Liu
---
target/i386/kvm/kvm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/target/i386
The KVM_X86_DISABLE_EXITS_HTL typo has been fixed in commit
77d361b13c19 ("linux-headers: Update to kernel mainline commit
b357bf602").
Drop the related workaround.
Signed-off-by: Zhao Liu
---
target/i386/kvm/kvm.c | 4
1 file changed, 4 deletions(-)
diff --git a/target/i386/k
consolidated them
all in one series and was able to tackle them in one go!
[1]:
https://lore.kernel.org/qemu-devel/20240329101954.3954987-1-zhao1@linux.intel.com/
[2]:
https://lore.kernel.org/qemu-devel/2815f0f1-9e20-4985-849c-d74c6cdc9...@intel.com/
Thanks and Best Regards,
Zhao
---
Zhao Liu
Update the comment to match the X86ConfidentialGuestClass
implementation.
Suggested-by: Xiaoyao Li
Signed-off-by: Zhao Liu
---
target/i386/confidential-guest.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/confidential-guest.h b/target/i386/confidential
Add feature definiations for KVM_CPUID_FEATURES in CPUID (
CPUID[4000_0001].EAX and CPUID[4000_0001].EDX), to get rid of lots of
offset calculations.
Signed-off-by: Zhao Liu
---
v2: Changed the prefix from CPUID_FEAT_KVM_* to CPUID_KVM_*. (Xiaoyao)
---
hw/i386/kvm/clock.c | 5 ++---
target
On Fri, Apr 26, 2024 at 03:43:15PM +0800, Zhao Liu wrote:
> Date: Fri, 26 Apr 2024 15:43:15 +0800
> From: Zhao Liu
> Subject: Re: [PULL v2 00/63] First batch of i386 and build system patch for
> QEMU 9.1
>
> Hi Paolo,
>
> On Fri, Apr 26, 2024 at 07:21:12AM +0200, Paolo
Hi Paolo,
On Fri, Apr 26, 2024 at 07:21:12AM +0200, Paolo Bonzini wrote:
> Date: Fri, 26 Apr 2024 07:21:12 +0200
> From: Paolo Bonzini
> Subject: Re: [PULL v2 00/63] First batch of i386 and build system patch for
> QEMU 9.1
>
> On Wed, Apr 24, 2024 at 8:49 PM Richard Henderson
> wrote:
> >
> >
On Wed, Apr 24, 2024 at 01:13:01PM +0200, Paolo Bonzini wrote:
> Date: Wed, 24 Apr 2024 13:13:01 +0200
> From: Paolo Bonzini
> Subject: Re: [PATCH for-9.1 09/19] target/i386: move 60-BF opcodes to new
> decoder
>
> On Thu, Apr 11, 2024 at 5:05 PM Zhao Liu wrote:
> &g
On Thu, Apr 25, 2024 at 08:04:46PM +0800, Xiaoyao Li wrote:
> Date: Thu, 25 Apr 2024 20:04:46 +0800
> From: Xiaoyao Li
> Subject: Re: [PATCH for-9.1 0/7] target/i386/kvm: Cleanup the kvmclock
> feature name
>
> On 4/25/2024 6:29 PM, Zhao Liu wrote:
> > On Thu, Apr 25,
On Thu, Apr 25, 2024 at 10:06:11AM +0200, Philippe Mathieu-Daudé wrote:
> Date: Thu, 25 Apr 2024 10:06:11 +0200
> From: Philippe Mathieu-Daudé
> Subject: Re: [PATCH v11 00/21] i386: Introduce smp.modules and clean up
> cache topology
>
> Hi Zhao,
>
> On 24/4/
On Thu, Apr 25, 2024 at 04:40:10PM +0800, Xiaoyao Li wrote:
> Date: Thu, 25 Apr 2024 16:40:10 +0800
> From: Xiaoyao Li
> Subject: Re: [PATCH for-9.1 0/7] target/i386/kvm: Cleanup the kvmclock
> feature name
>
> On 4/25/2024 3:17 PM, Zhao Liu wrote:
> > Hi Xiaoyao,
>
Hi Xiaoyao,
On Wed, Apr 24, 2024 at 11:57:11PM +0800, Xiaoyao Li wrote:
> Date: Wed, 24 Apr 2024 23:57:11 +0800
> From: Xiaoyao Li
> Subject: Re: [PATCH for-9.1 0/7] target/i386/kvm: Cleanup the kvmclock
> feature name
>
> On 3/29/2024 6:19 PM, Zhao Liu wrote:
> > Fro
redhat.com/
Regards,
Zhao
---
v1:
https://lore.kernel.org/qemu-devel/20240419065712.1225038-1-zhao1@linux.intel.com/
Changes since v1:
* Picked Phili's stubs cleanup and rebased on it.
* Fixed typos.
---
Philippe Mathieu-Daudé (1):
target/s390x: Remove KVM stubs in cpu_models
As error.h suggested, the best practice for callee is to return
something to indicate success / failure.
So make kvm_s390_get_host_cpu_model() return boolean and check the
returned boolean in get_max_cpu_model() instead of accessing @err.
Signed-off-by: Zhao Liu
---
target/s390x/cpu_models.c
As error.h suggested, the best practice for callee is to return
something to indicate success / failure.
So make kvm_s390_apply_cpu_model() return boolean and check the
returned boolean in apply_cpu_model() instead of accessing @err.
Signed-off-by: Zhao Liu
Reviewed-by: Thomas Huth
---
target
As error.h suggested, the best practice for callee is to return
something to indicate success / failure.
With returned boolean, there's no need to check @err.
Suggested-by: Thomas Huth
Signed-off-by: Zhao Liu
Reviewed-by: Thomas Huth
---
target/s390x/cpu_models.c | 14 +++---
1
Use @errp to fetch error information directly and drop the local
variable @err.
Signed-off-by: Zhao Liu
Reviewed-by: Thomas Huth
---
target/s390x/cpu_models_sysemu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/s390x/cpu_models_sysemu.c b/target/s390x
Use @errp to fetch error information directly and drop the local
variable @err.
Signed-off-by: Zhao Liu
Reviewed-by: Thomas Huth
---
target/s390x/cpu_models.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index
Use @errp to fetch error information directly and drop the local
variable @err.
Suggested-by: Thomas Huth
Signed-off-by: Zhao Liu
Reviewed-by: Thomas Huth
---
target/s390x/cpu_models.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/s390x/cpu_models.c b/target
From: Philippe Mathieu-Daudé
Since the calls are elided when KVM is not available,
we can remove the stubs (which are never compiled).
Inspired-by: Thomas Huth >
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Zhao Liu
Signed-off-by: Zhao Liu
---
target/s390x/cpu_models.h |
been implemented in QEMU, to avoid
possible misunderstanding, split topology types of CPUID[0x1F] from the
definitions of CPUID[0xB] and introduce CPUID[0x1F]-specific topology
types.
Signed-off-by: Zhao Liu
Tested-by: Yongwei Ma
Acked-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
T
Introduce module-id to be consistent with the module-id field in
CpuInstanceProperties.
Following the legacy smp check rules, also add the module_id validity
into x86_cpu_pre_plug().
Tested-by: Yongwei Ma
Co-developed-by: Zhuocheng Ding
Signed-off-by: Zhuocheng Ding
Signed-off-by: Zhao Liu
t topology
structure.
Fixes: 7e3482f82480 ("i386: Helpers to encode cache information consistently")
Suggested-by: Robert Hoo
Signed-off-by: Zhao Liu
Reviewed-by: Xiaoyao Li
Tested-by: Babu Moger
Tested-by: Yongwei Ma
Acked-by: Michael S. Tsirkin
---
Changes since v3:
* Changed the de
encoded
into CPUID[0x801D].EAX[bits 25:14].
Tested-by: Yongwei Ma
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
Reviewed-by: Babu Moger
---
Changes since v7:
* Renamed max_processor_ids_for_cache() to max_thread_ids_for_cache().
* Dropped Michael/Babu's ACKed/Tested tags since the code c
From: Zhuocheng Ding
After i386 supports module level, it's time to add the test for module
level's parsing.
Signed-off-by: Zhuocheng Ding
Co-developed-by: Zhao Liu
Signed-off-by: Zhao Liu
Reviewed-by: Yanan Wang
Tested-by: Babu Moger
Tested-by: Yongwei Ma
Acked-by: Michael
ding of CPUID[4].EAX[bits 31:26] into a
helper to make the code cleaner.
Tested-by: Yongwei Ma
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
---
Changes since v7:
* Renamed max_processor_ids_for_cache() to max_thread_ids_for_cache().
(Xiaoyao)
* Dropped Michael/Babu's ACKed/Tested tags s
Module is a level above the core, thereby supporting numa
configuration on the module level can bring user more numa flexibility.
This is the natural further support for module level.
Add module level support in numa configuration.
Tested-by: Yongwei Ma
Signed-off-by: Zhao Liu
Tested-by: Babu
y: Yongwei Ma
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
---
Changes since v7:
* Mapped x86 module to smp module instead of cluster.
* Dropped Michael/Babu's ACKed/Tested tags since the code change.
* Re-added Yongwei's Tested tag For his re-testing.
Changes since v3:
* New pa
g Ding
Co-developed-by: Zhuocheng Ding
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
---
Changes since v7:
* Mapped x86 module to the smp module instead of cluster.
* Dropped Michael/Babu's ACKed/Tested tags since the code change.
* Re-added Yongwei's Tested tag For his re-testing
by
"apicid_bitwidth_for_count(topo_info->modules_per_die)", is always 0 for
now, so we can directly add APIC ID related helpers to support module
level parsing.
In addition, update topology structure in test-x86-topo.c.
Tested-by: Yongwei Ma
Co-developed-by: Zhuocheng Ding
Signed-off-
.
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
Tested-by: Yongwei Ma
Acked-by: Michael S. Tsirkin
---
Changes since v3:
* Fixed cache topology uninitialization bugs for some AMD CPUs. (Babu)
* Moved the CPUTopoLevel enumeration definition to the previous 0x1f
rework patch.
Changes since v1
l topology example in description of "-smp".
Additionally, add the missed drawers and books options in previous
example.
Tested-by: Yongwei Ma
Co-developed-by: Zhuocheng Ding
Signed-off-by: Zhuocheng Ding
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
Reviewed-by: Babu Moger
3, appendix.E.4.15 Function 8000_001Dh--Cache Topology
Information
Tested-by: Yongwei Ma
Signed-off-by: Zhao Liu
Reviewed-by: Babu Moger
Tested-by: Babu Moger
Reviewed-by: Xiaoyao Li
---
Changes since v7:
* Moved this patch after CPUID[4]'s similar change ("i386/cpu: Use APIC
ID o
Tested-by: Yongwei Ma
Signed-off-by: Zhao Liu
Reviewed-by: Xiaoyao Li
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Babu Moger
---
Changes since v9:
* Polished the commit message. ( Xiaoyao)
Changes since v8:
* Added Philippe's reviewed-by tag.
Changes since v7:
* Renamed cpus_
af
with specific topology level.
Tested-by: Yongwei Ma
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
Reviewed-by: Xiaoyao Li
---
Changes since v10:
* Combined ecx and edx encoding into the single line. (Xiaoyao)
* Fixed the comment in encode_topo_cpuid1f(). (Xiaoyao)
Changes si
Signed-off-by: Zhuocheng Ding
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
---
Changes since v7:
* Mapped x86 module to smp module instead of cluster.
* Re-wrote the commit message to explain the reason why we needs module
level.
* Dropped Michael/Babu's ACKed/Tested tags since
of addressable IDs for logical
processors sharing cache")
[3]: d65af288a84d ("i386: Update new x86_apicid parsing rules with die_offset
support")
Fixes: 7e3482f82480 ("i386: Helpers to encode cache information consistently")
Suggested-by: Robert Hoo
Tested-by: Y
is is also in preparation for the follow-up to decouple CPUID[0x1F]
subleaf with specific topology level.
Tested-by: Yongwei Ma
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
Reviewed-by: Xiaoyao Li
---
Changes since v10:
* Rebased on commit 88daa112d4eda.
Changes since v7:
* New comm
pu-topology.txt
Suggested-by: Xiaoyao Li
Tested-by: Yongwei Ma
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
---
Changes since v8:
* Add the reason of why a new module level is needed in commit message.
(Markus).
* Add the description about how Linux kernel supports x86 module level.
(D
p_config().
(Yanan)
* Renamed test-x86-cpuid.c to test-x86-topo.c. (Yanan)
* Split the intel's l1 cache topology fix into a new separate patch.
(Yanan)
* Combined module_id and APIC ID for module level support into one
patch. (Yanan)
* Made cache_into_passthrough case of cpuid 0x04 lea
Add "modules" parameter parsing support in -smp.
Suggested-by: Xiaoyao Li
Tested-by: Yongwei Ma
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
Acked-by: Markus Armbruster
---
Changes since v9:
* Rebased on the SMP changes about unsupported "parameter=1"
configurations.
Add module-id in CpuInstanceProperties, to locate the CPU with module
level.
Suggested-by: Xiaoyao Li
Tested-by: Yongwei Ma
Signed-off-by: Zhao Liu
Tested-by: Babu Moger
Acked-by: Markus Armbruster
---
Changes since v10:
* Rebased on commit 88daa112d4eda.
Changes since v7:
* New commit to
Hi maintainers,
Ping. Do you like this diea?
Thanks,
Zhao
On Fri, Mar 29, 2024 at 06:19:47PM +0800, Zhao Liu wrote:
> Date: Fri, 29 Mar 2024 18:19:47 +0800
> From: Zhao Liu
> Subject: [PATCH for-9.1 0/7] target/i386/kvm: Cleanup the kvmclock feature
> name
> X-Mailer: git-se
Hi Lei,
On Wed, Apr 24, 2024 at 03:29:12AM -0400, Lei Wang wrote:
> Date: Wed, 24 Apr 2024 03:29:12 -0400
> From: Lei Wang
> Subject: [PATCH] target/i386: Introduce SapphireRapids-v3 to add missing
> features
> X-Mailer: git-send-email 2.39.3
>
> Add the missing features(ss, tsc-adjust, cldemot
c
> --- /dev/null
> +++ b/target/i386/cpu-apic.c
Nit: New file needs a MAINTAINER entry ;-).
Others LGTM,
Reviewed-by: Zhao Liu
On Fri, Apr 19, 2024 at 11:08:22AM +0200, Philippe Mathieu-Daudé wrote:
> Date: Fri, 19 Apr 2024 11:08:22 +0200
> From: Philippe Mathieu-Daudé
> Subject: Re: [PATCH 3/6] target/s390x/cpu_models: Make
> kvm_s390_get_host_cpu_model() return boolean
>
> On 19/4/24 10:44, Zhao
Hi Anthony,
On Thu, Apr 18, 2024 at 12:52:14PM +0200, Anthony Harivel wrote:
> Date: Thu, 18 Apr 2024 12:52:14 +0200
> From: Anthony Harivel
> Subject: Re: [PATCH v5 3/3] Add support for RAPL MSRs in KVM/Qemu
>
> > The package energy consumption includes core part and uncore part, where
> > unco
On Fri, Apr 19, 2024 at 09:39:53AM +0200, Thomas Huth wrote:
> Date: Fri, 19 Apr 2024 09:39:53 +0200
> From: Thomas Huth
> Subject: Re: [PATCH 2/6] target/s390x/cpu_model: Drop local @err in
> s390_realize_cpu_model()
>
> On 19/04/2024 08.57, Zhao Liu wrote:
> > From
Hi Thomas,
On Fri, Apr 19, 2024 at 09:50:46AM +0200, Thomas Huth wrote:
> Date: Fri, 19 Apr 2024 09:50:46 +0200
> From: Thomas Huth
> Subject: Re: [PATCH 3/6] target/s390x/cpu_models: Make
> kvm_s390_get_host_cpu_model() return boolean
>
> On 19/04/2024 08.57, Zhao Liu wro
> > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
> > index 052540a866ac..a0e4acb707d7 100644
> > --- a/target/s390x/cpu_models.c
> > +++ b/target/s390x/cpu_models.c
> > @@ -560,16 +560,15 @@ S390CPUModel *get_max_cpu_model(Error **errp)
> > }
> > if (kvm_enabled())
From: Zhao Liu
Hi list,
This series is the followup of Thomas' suggestion in previous
ERRP_GUARD() cleanup[1]. And based on Thomas' thoughts, I tried to clean
up as many of the other related places (in s390x/cpu_models.c).
[1]:
https://lore.kernel.org/qemu-devel/6e7eff95-cfd3
From: Zhao Liu
Use @errp to fetech error information directly and drop the local
virable @err.
Signed-off-by: Zhao Liu
---
target/s390x/cpu_models_sysemu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/s390x/cpu_models_sysemu.c b/target/s390x
From: Zhao Liu
Use @errp to fetech error information directly and drop the local
virable @err.
Suggested-by: Thomas Huth
Signed-off-by: Zhao Liu
---
target/s390x/cpu_models.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/s390x/cpu_models.c b/target/s390x
From: Zhao Liu
Use @errp to fetech error information directly and drop the local
virable @err.
Signed-off-by: Zhao Liu
---
target/s390x/cpu_models.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index a0e4acb707d7
From: Zhao Liu
As error.h suggested, the best practice for callee is to return
something to indicate success / failure.
So make kvm_s390_get_host_cpu_model() return boolean and check the
returned boolean in get_max_cpu_model() instead of accessing @err.
Additionally, since now
From: Zhao Liu
As error.h suggested, the best practice for callee is to return
something to indicate success / failure.
With returned boolean, there's no need to check @err.
Suggested-by: Thomas Huth
Signed-off-by: Zhao Liu
---
target/s390x/cpu_models.c | 14 +++---
1 file ch
From: Zhao Liu
As error.h suggested, the best practice for callee is to return
something to indicate success / failure.
So make kvm_s390_apply_cpu_model() return boolean and check the
returned boolean in apply_cpu_model() instead of accessing @err.
Signed-off-by: Zhao Liu
---
target/s390x
Hi Philippe,
On Thu, Apr 18, 2024 at 02:06:15PM +0200, Philippe Mathieu-Daudé wrote:
[snip]
> > diff --git a/include/hw/cxl/cxl_component.h b/include/hw/cxl/cxl_component.h
> > index 5012fab6f763..945ee6ffd045 100644
> > --- a/include/hw/cxl/cxl_component.h
> > +++ b/include/hw/cxl/cxl_component
From: Zhao Liu
Use warn_report_once() to get rid of the static local variable "notified".
Signed-off-by: Zhao Liu
---
Note: After cleaning up similar uses in x86, only icount-common.c and
virtio-mem.c still have "only once" usage with static variables.
Howeve
From: Zhao Liu
As error.h suggested, the best practice for callee is to return
something to indicate success / failure.
With returned boolean, there's no need to dereference @errp to check
failure case.
Suggested-by: Markus Armbruster
Signed-off-by: Zhao Liu
---
hw/cxl/cxl-c
From: Zhao Liu
As error.h suggested, the best practice for callee is to return
something to indicate success / failure.
So make ct3_load_cdat() return boolean, and this is the preparation for
cxl_doe_cdat_init() returning boolean.
Suggested-by: Markus Armbruster
Signed-off-by: Zhao Liu
From: Zhao Liu
Hi list,
This series is the followup of the previous fix [1] to improve the error
handling.
As error.h suggested, the best practice for callee is to return
something to indicate success / failure instead of dereferencing @errp.
Thus make cxl_doe_cdat_init() as well as
From: Zhao Liu
As error.h suggested, the best practice for callee is to return
something to indicate success / failure.
So make ct3_build_cdat() return boolean, and this is the preparation for
cxl_doe_cdat_init() returning boolean.
Suggested-by: Markus Armbruster
Signed-off-by: Zhao Liu
Hi Perter HSU,
On Wed, Apr 17, 2024 at 01:07:17PM +, Peter Dave Hello wrote:
> Date: Wed, 17 Apr 2024 13:07:17 +
> From: Peter Dave Hello
> Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation
>
> Hi all,
>
> Thank you all for the feedback. I've updated the patch to address mo
Hi Daniel,
On Wed, Apr 17, 2024 at 01:27:03PM +0100, Daniel P. Berrangé wrote:
> Date: Wed, 17 Apr 2024 13:27:03 +0100
> From: "Daniel P. Berrangé"
> Subject: Re: [PATCH v5 3/3] Add support for RAPL MSRs in KVM/Qemu
>
> On Wed, Apr 17, 2024 at 06:07:02PM +0800, Zhao
301 - 400 of 1132 matches
Mail list logo