Re: [PATCH] hostmem: Apply merge property after the memory region is initialized

2024-09-16 Thread Zhenyu Zhang
\ -object memory-backend-ram,id=mem-memN0,size=4096M,merge=off Tested-by: Zhenyu Zhang On Mon, Sep 16, 2024 at 7:31 AM Gavin Shan wrote: > > The semantic change has been introduced by commit 5becdc0ab0 ("hostmem: > simplify the code for merge and dump proper

Re: [PATCH v3] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

2024-06-16 Thread Zhenyu Zhang
Zhenyu, > >>> Hello Philippe, > >>> On 12/6/24 04:05, Zhenyu Zhang wrote: > >>>> diff --git a/hw/arm/virt.c b/hw/arm/virt.c > >>>> index 3c93c0c0a6..3cefac6d43 100644 > >>>> --- a/hw/arm/virt.c > >>>> +++ b/hw/arm/v

[PATCH v3] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

2024-06-11 Thread Zhenyu Zhang
e capable of DMA coherent by default. Signed-off-by: Zhenyu Zhang --- v3: Add comments explaining why we add 'dma-coherent' property (Peter) --- hw/arm/virt.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 3c93c0c0a6..3cefac6d43 1

[PATCH v2] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

2024-06-11 Thread Zhenyu Zhang
l devices are capable of DMA coherent by default. Signed-off-by: Zhenyu Zhang --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 3c93c0c0a6..0680b792bc 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -270,6 +270,7 @@ static void crea

Re: [PATCH RFC] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

2024-06-07 Thread Zhenyu Zhang
On Thu, Jun 6, 2024 at 7:57 PM Peter Maydell wrote: > > On Thu, 6 Jun 2024 at 11:48, Zhenyu Zhang wrote: > > > > Multiple warning messages and corresponding backtraces are observed when > > Linux > > guest is booted on the host with Fujitsu CPUs. One

Re: [PATCH RFC] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

2024-06-07 Thread Zhenyu Zhang
On Fri, Jun 7, 2024 at 6:17 PM Peter Maydell wrote: > > On Thu, 6 Jun 2024 at 22:18, Robin Murphy wrote: > > > > On 2024-06-06 6:13 pm, Jonathan Cameron wrote: > > > On Thu, 6 Jun 2024 12:56:59 +0100 > > > Peter Maydell wrote: > > > > >

[PATCH RFC] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

2024-06-06 Thread Zhenyu Zhang
ctice. So lets add 'dma-coherent' property to their device-tree nodes to avoid the unexpected warnings in the Linux guest. Signed-off-by: Zhenyu Zhang --- hw/arm/boot.c| 1 + hw/arm/virt.c| 4 hw/core/sysbus-fdt.c | 1 + 3 files changed, 6 insertions(+) diff --git a/hw

Re: [PATCH v1 2/2] memory-device: reintroduce memory region size check

2024-01-17 Thread Zhenyu Zhang
m,id=dimm1,memdev=mem1 \ -smp 4 \ -cpu 'host' \ -accel kvm \ -monitor stdio -> memory size 0x1ff0 must be equal to or larger than page size 0x2000 Tested-by: Zhenyu Zhang On Wed, Jan 17, 2024 at 9:56 PM David Hildenbrand wrote: > > We used to check that the memory

Re: [PATCH v1 0/6] hw/arm/virt: Support dirty ring

2023-02-16 Thread Zhenyu Zhang
| | 66 | 73 | | 67 | 76 | | 67 | 76 | | 66 | 73 | | 67 |

[PATCH v4] qapi/qom: Memory backend property prealloc-threads doc fix

2022-11-14 Thread Zhenyu Zhang
ept the documentation remained unchanged. Update 'qapi/qom.json' to reflect the change in commit f8d426a6852c. Signed-off-by: Zhenyu Zhang --- v4: Fix the line exceeding 80 characters limitation issue (Gavin) v3: Covers historical descriptions (Markus) v2: T

Re: [PATCH v3] qapi/qom: Memory backend property prealloc-threads doc fix

2022-11-14 Thread Zhenyu Zhang
ammedov wrote: > >>> On Fri, 11 Nov 2022 07:47:16 +0100 > >>> Markus Armbruster wrote: > >>>> Gavin Shan writes: > >>>>> On 11/11/22 11:05 AM, Zhenyu Zhang wrote: > >>>>>> Commit ffac16fab3 "hostmem: introduce "pr

[PATCH v3] qapi/qom: Memory backend property prealloc-threads doc fix

2022-11-10 Thread Zhenyu Zhang
ept the documentation remained unchanged. Update it now. Signed-off-by: Zhenyu Zhang --- v3: Covers historical descriptions (Markus) v2: The property is changed to smp-cpus since 5.0 (Phild) --- qapi/qom.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH v2] qom.json: default the prealloc-threads to smp-cpus

2022-11-09 Thread Zhenyu Zhang
Many thanks for your patient review, I learned a lot. I will send v3 to correct it. On Wed, Nov 9, 2022 at 5:52 PM Markus Armbruster wrote: > > The subject is misleading, I'm afraid. It suggests you're changing the > default. You don't, you just fix its documentation.

[PATCH v2] qom.json: default the prealloc-threads to smp-cpus

2022-11-04 Thread Zhenyu Zhang
Since the amount of prealloc-threads to smp-cpus is defaulted in hostmem, so sync this information. Signed-off-by: Zhenyu Zhang v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg919682.html Changelog = v2: * This property is available since 5.0. (Philippe

Re: [PATCH] qom.json: default the prealloc-threads to smp-cpus

2022-11-04 Thread Zhenyu Zhang
Ok, many thanks for the clarification. I'll post a v2 patch to correct it. On Fri, Nov 4, 2022 at 5:29 PM Philippe Mathieu-Daudé wrote: > > On 4/11/22 02:57, Zhenyu Zhang wrote: > > Hello Philippe > > > > I checked out this modified patch: > > https://www.mai

Re: [PATCH] qom.json: default the prealloc-threads to smp-cpus

2022-11-03 Thread Zhenyu Zhang
Hello Philippe I checked out this modified patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg15.html It should have been merged in 7.1 On Thu, Nov 3, 2022 at 7:00 PM Philippe Mathieu-Daudé wrote: > > On 3/11/22 11:47, Zhenyu Zhang wrote: > > Since the amount of prea

[PATCH] qom.json: default the prealloc-threads to smp-cpus

2022-11-03 Thread Zhenyu Zhang
Since the amount of prealloc-threads to smp-cpus is defaulted in hostmem, so sync this information. Signed-off-by: Zhenyu Zhang --- qapi/qom.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/qom.json b/qapi/qom.json index 87fcad2423..ac4cd213a7 100644 --- a/qapi

Re: [PATCH v3 0/5] hw/arm/virt: Improve address assignment for high memory regions

2022-09-21 Thread Zhenyu Zhang
ff[no] [yes] [HIGH_PCIE_MMIO] enabled, highest_gpa=0xff Tested-by: Zhenyu Zhang On Thu, Sep 22, 2022 at 7:13 AM Gavin Shan wrote: > > There are three high memory regions, which are VIRT_HIGH_REDIST2, > VIRT_HIGH_PCIE_ECAM and VIRT_HIGH_PCIE_MMIO. Their base addresses >

Re: [PATCH v2 4/4] virt/hw/virt: Add virt_set_high_memmap() helper

2022-08-16 Thread Zhenyu Zhang
ms->memmap[i].base = region_base; > -vms->memmap[i].size = region_size; > - > - base = region_base + region_size; > -vms->highest_gpa = region_base + region_size - 1; > -} else { > -*region_enabled = false; > -} > -} > +virt_set_high_memmap(vms, base, pa_bits); > > if (device_memory_size > 0) { > ms->device_memory = g_malloc0(sizeof(*ms->device_memory)); > -- > 2.23.0 > -- I respect your work/life balance, no need to reply to this email if it is outside of your normal working hours. Zhenyu Zhang Senior Quality Engineer, Products And Technologies Red Hat Software (Beijing) Co., R&D Branch