Re: [Qemu-devel] [PATCH v2 2/4] qga: Fix an enum conversion warningin commands-win32.c, hit by clang.

On 5/1/19 2:25 AM, Eric Blake wrote: > This adds lots of explicit casts. Are they actually necessary? Without > seeing the actual warning, it seems fishy to have to be this explicit. So here are the warnings, on clang version 9.0.0 (trunk 351977). qga/commands-win32.c:461:24: error: implicit

Re: [Qemu-devel] [PATCH v2 4/4] include/qemu/osdep.h: Move the__USE_MINGW_ANSI_STDIO define up to avoid confliction.

On 5/1/19 2:30 AM, Eric Blake wrote: > Your entire series is missing 'In-Reply-To:' and 'References:' headers, > making each message show up as individual new threads rather than > properly threaded to a 0/4 cover letter. You'll want to fix your sending > habits to avoid that problem in future

[Qemu-devel] [PATCH 3/4] util/cacheinfo.c: Use uintptr_t instead of unsigned long in AArch64 arch_cache_info()

Windows ARM64 uses LLP64 model, which breaks current assumptions. Signed-off-by: driver1998 --- util/cacheinfo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/cacheinfo.c b/util/cacheinfo.c index 3cd080b83d..a815cb0722 100644 --- a/util/cacheinfo.c +++ b/util

[Qemu-devel] [PATCH 1/4] Initial Windows on ARM (AArch64 64-Bit) host support

://github.com/mstorsjo/llvm-mingw. QEMU_PACKED: Remove gcc_struct attribute in Windows non x86 targets This attribute is for x86 only, and it generates an warning on ARM64 Clang/MinGW targets. Signed-off-by: driver1998 --- contrib/libvhost-user/libvhost-user.h | 2 +- include/qemu/compiler.h

[Qemu-devel] [PATCH 2/4] qga: Fix an enum conversion warning in commands-win32.c, hit by clang.

Signed-off-by: driver1998 --- qga/commands-win32.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index d40d61f605..4cdd2950bf 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c

[Qemu-devel] [PATCH 4/4] include/qemu/osdep.h: Move the __USE_MINGW_ANSI_STDIO define up to avoid confliction.

Signed-off-by: driver1998 --- include/qemu/osdep.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 303d315c5d..af2b91f0b8 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -85,17 +85,17 @@ extern int