Re: [PATCH -next] fw_cfg: Constify struct kobj_type

038944 96 7078 1ba6drivers/firmware/qemu_fw_cfg.o > ``` > > Signed-off-by: Hongbo Li Acked-by: Gabriel L. Somlo Thanks, --Gabriel > --- > drivers/firmware/qemu_fw_cfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/f

Re: [PATCH v5 3/3] tests/qtest/bios-tables-test: Update virt SPCR golden reference for RISC-V

the revision 4 format [2]. > > [1]: > https://learn.microsoft.com/en-us/windows-hardware/drivers/serports/serial-port-console-redirection-table > [2]: https://github.com/acpica/acpica/pull/931 > Reviewed-by: Sunil V L Thanks!

Re: [PATCH RESEND v4 0/3] Upgrade ACPI SPCR table to support SPCR table revision 4 format

Hi Jee Heng, On Mon, Aug 26, 2024 at 07:04:11AM +, JeeHeng Sia wrote: > > > > -Original Message- > > From: Sunil V L > > Sent: Friday, August 23, 2024 10:29 PM > > To: JeeHeng Sia > > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; qemu-ri

Re: [PATCH RESEND v4 0/3] Upgrade ACPI SPCR table to support SPCR table revision 4 format

Hi Jee Heng, On Fri, Aug 23, 2024 at 04:31:39AM -0700, Sia Jee Heng wrote: > Update the SPCR table to accommodate the SPCR Table revision 4 [1]. > The SPCR table has been modified to adhere to the revision 4 format [2]. > > Meanwhile, the virt SPCR golden reference file for RISC-V have been update

Re: [PATCH RESEND v4 3/3] tests/qtest/bios-tables-test: Update virt SPCR golden reference for RISC-V

On Fri, Aug 23, 2024 at 04:31:42AM -0700, Sia Jee Heng wrote: > Update the virt SPCR golden reference file for RISC-V to accommodate the > SPCR Table revision 4 [1], utilizing the iasl binary compiled from the > latest ACPICA repository. The SPCR table has been modified to > adhere to the revision

Re: [PATCH RESEND v4 2/3] hw/acpi: Upgrade ACPI SPCR table to support SPCR table revision 4 format

g[]; > } AcpiSpcrData; > > #define ACPI_FADT_ARM_PSCI_COMPLIANT (1 << 0) > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index a3784155cb..68c0f2dbee 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -500,5 +500,5 @@ void build_tpm2(GArray *table_data, BIOSLinker *linker, > GArray *tcpalog, > > void build_spcr(GArray *table_data, BIOSLinker *linker, > const AcpiSpcrData *f, const uint8_t rev, > -const char *oem_id, const char *oem_table_id); > +const char *oem_id, const char *oem_table_id, const char > *name); > #endif Otherwise, LGTM. Reviewed-by: Sunil V L

Re: [PATCH RESEND v4 1/3] qtest: allow SPCR acpi table changes

s-test-allowed-diff.h > index dfb8523c8b..aae973048a 100644 > --- a/tests/qtest/bios-tables-test-allowed-diff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1 +1,2 @@ > /* List of comma-separated changed AML files to ignore */ > +"tests/data/acpi/riscv64/virt/SPCR", Reviewed-by: Sunil V L

Re: [PATCH v3 2/3] hw/acpi: Upgrade ACPI SPCR table to support SPCR table version 4 format

Hi Jee Heng, On Mon, Aug 12, 2024 at 10:22:22PM -0700, Sia Jee Heng wrote: > Update the SPCR table to accommodate the SPCR Table version 4 [1]. > The SPCR table has been modified to adhere to the version 4 format [2]. > > [1]: > https://learn.microsoft.com/en-us/windows-hardware/drivers/serports

Re: [PATCH 3/3] tests/acpi: Add expected ACPI SRAT AML file for RISC-V

iff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1,2 +1 @@ > /* List of comma-separated changed AML files to ignore */ > -"tests/data/acpi/riscv64/virt/SRAT.numamem", Reviewed-by: Sunil V L Thanks, Sunil

Re: [PATCH 2/3] tests/qtest/bios-tables-test.c: Enable numamem testing for RISC-V

; test_data data = { > @@ -2466,6 +2492,8 @@ int main(int argc, char *argv[]) > } else if (strcmp(arch, "riscv64") == 0) { > if (has_tcg && qtest_has_device("virtio-blk-pci")) { > qtest_add_func("acpi/virt", test_acpi_riscv64_virt_tcg); > +qtest_add_func("acpi/virt/numamem", > + test_acpi_riscv64_virt_tcg_numamem); Reviewed-by: Sunil V L Thanks, Sunil

Re: [PATCH 1/3] tests/acpi: Add empty ACPI SRAT data file for RISC-V

+ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1 +1,2 @@ > /* List of comma-separated changed AML files to ignore */ > +"tests/data/acpi/riscv64/virt/SRAT.numamem", Reviewed-by: Sunil V L Thanks, Sunil

[PATCH v4 4/9] acpi/gpex: Create PCI link devices outside PCI root bridge

. So, this change will alter the DSDT for those systems. [1] - ACPI 5.1: 6.2.13.1 Example: Using _PRT to Describe PCI IRQ Routing Signed-off-by: Sunil V L Acked-by: Igor Mammedov --- hw/pci-host/gpex-acpi.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/pci

[PATCH v4 5/9] tests/acpi: update expected DSDT blob for aarch64 and microvm

all PCI root bridges in the system, they should have unique names. So, instead of GSIx, named those devices as LXXY where L means link, XX will have PCI bus number and Y will have the INTx number (ex: L000 or L001). The _PRT entries will also be updated to reflect this name change. 2) PCI link

[PATCH v4 8/9] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

Add basic ACPI table test case for RISC-V. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios

[PATCH v4 7/9] tests/acpi: Add empty ACPI data files for RISC-V

As per process documented (steps 1-3) in bios-tables-test.c, add empty AML data files for RISC-V ACPI tables and add the entries in bios-tables-test-allowed-diff.h. Signed-off-by: Sunil V L Acked-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/data/acpi/riscv64/virt/APIC

[PATCH v4 9/9] tests/acpi: Add expected ACPI AML files for RISC-V

added. Signed-off-by: Sunil V L Acked-by: Alistair Francis Acked-by: Igor Mammedov --- tests/data/acpi/riscv64/virt/APIC | Bin 0 -> 116 bytes tests/data/acpi/riscv64/virt/DSDT | Bin 0 -> 3576 bytes tests/data/acpi/riscv64/virt/FACP | Bin 0 -> 276 bytes t

[PATCH v4 1/9] hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIC

) Signed-off-by: Sunil V L Acked-by: Alistair Francis Acked-by: Igor Mammedov --- hw/riscv/virt-acpi-build.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c index 0925528160..5f5082a35b 100644 --- a/hw/riscv

[PATCH v4 6/9] tests/qtest/bios-tables-test.c: Remove the fall back path

The expected ACPI AML files are moved now under ${arch}/{machine} path. Hence, there is no need to search in old path which didn't have ${arch}. Remove the code which searches for the expected AML files under old path as well. Suggested-by: Igor Mammedov Signed-off-by: Sunil V L Ack

[PATCH v4 3/9] tests/acpi: Allow DSDT acpi table changes for aarch64

so that CI tests don't fail when those ACPI tables are updated in the next patch. This is as per the documentation in bios-tables-tests.c. Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH v4 0/9] RISC-V: ACPI: Namespace updates

e expected DSDT files for those machine so that CI tests don't fail. 2) Added patches to enable ACPI tables tests for RISC-V including a patch to remove the fallback path to search for expected AML files. 3) Rebased and added tags. Sunil V L

[PATCH v4 2/9] hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART

The requirement ACPI_060 in the RISC-V BRS specification [1], requires NS16550 compatible UART to have the HID RSCV0003. So, update the HID for the UART. [1] - https://github.com/riscv-non-isa/riscv-brs/releases/download/v0.0.2/riscv-brs-spec.pdf (Chapter 6) Signed-off-by: Sunil V L

Re: [PATCH v2 0/9] RISC-V: ACPI: Namespace updates

P. Berrangé wrote: > > > > > > > On Fri, Jul 12, 2024 at 02:43:19PM +0200, Igor Mammedov wrote: > > > > > On Mon, 8 Jul 2024 17:17:32 +0530 > > > > > Sunil V L wrote: > > > > > > > > > > > This series ad

Re: [PATCH v3 1/9] hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIC

On Tue, Jul 16, 2024 at 12:24:05PM +0200, Igor Mammedov wrote: > On Mon, 15 Jul 2024 22:41:21 +0530 > Sunil V L wrote: > > > As per the requirement ACPI_080 in the RISC-V Boot and Runtime Services > > (BRS) specification [1], PLIC and APLIC should be in namespace as well. &

[PATCH v3 8/9] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

Add basic ACPI table test case for RISC-V. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios

[PATCH v3 2/9] hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART

: Sunil V L Acked-by: Alistair Francis --- hw/riscv/virt-acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c index 5f5082a35b..36d6a3a412 100644 --- a/hw/riscv/virt-acpi-build.c +++ b/hw/riscv/virt-acpi-build.c

[PATCH v3 3/9] tests/acpi: Allow DSDT acpi table changes for aarch64

so that CI tests don't fail when those ACPI tables are updated in the next patch. This is as per the documentation in bios-tables-tests.c. Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH v3 7/9] tests/acpi: Add empty ACPI data files for RISC-V

As per process documented (steps 1-3) in bios-tables-test.c, add empty AML data files for RISC-V ACPI tables and add the entries in bios-tables-test-allowed-diff.h. Signed-off-by: Sunil V L Acked-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/data/acpi/riscv64/virt/APIC

[PATCH v3 4/9] acpi/gpex: Create PCI link devices outside PCI root bridge

. So, this change will alter the DSDT for those systems. [1] - ACPI 5.1: 6.2.13.1 Example: Using _PRT to Describe PCI IRQ Routing Signed-off-by: Sunil V L --- hw/pci-host/gpex-acpi.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci

[PATCH v3 0/9] RISC-V: ACPI: Namespace updates

ding a patch to remove the fallback path to search for expected AML files. 3) Rebased and added tags. Sunil V L (9): hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIC hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART tests/acpi: Allow DSDT acpi ta

[PATCH v3 5/9] tests/acpi: update expected DSDT blob for aarch64 and microvm

all PCI root bridges in the system, they should have unique names. So, instead of GSIx, named those devices as LXXY where L means link, XX will have PCI bus number and Y will have the INTx number (ex: L000 or L001). The _PRT entries will also be updated to reflect this name change. 2) PCI link

[PATCH v3 1/9] hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIC

: 241575b3189c5d9e60b5e55e78cf0443092713bf) Signed-off-by: Sunil V L Acked-by: Alistair Francis --- hw/riscv/virt-acpi-build.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c index 0925528160..5f5082a35b 100644 --- a/hw/riscv/virt-acpi

[PATCH v3 6/9] tests/qtest/bios-tables-test.c: Remove the fall back path

The expected ACPI AML files are moved now under ${arch}/{machine} path. Hence, there is no need to search in old path which didn't have ${arch}. Remove the code which searches for the expected AML files under old path as well. Suggested-by: Igor Mammedov Signed-off-by: Sunil V L Ack

[PATCH v3 9/9] tests/acpi: Add expected ACPI AML files for RISC-V

added. Signed-off-by: Sunil V L Acked-by: Alistair Francis Acked-by: Igor Mammedov --- tests/data/acpi/riscv64/virt/APIC | Bin 0 -> 116 bytes tests/data/acpi/riscv64/virt/DSDT | Bin 0 -> 3576 bytes tests/data/acpi/riscv64/virt/FACP | Bin 0 -> 276 bytes t

Re: [PATCH v2 2/9] hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART

On Thu, Jul 11, 2024 at 10:41:35AM -0400, Michael S. Tsirkin wrote: > On Thu, Jul 11, 2024 at 03:25:12PM +0200, Igor Mammedov wrote: > > On Mon, 8 Jul 2024 17:17:34 +0530 > > Sunil V L wrote: > > > > > The RISC-V BRS specification [1] requires NS16550 compati

[PATCH v2 3/9] tests/acpi: Allow DSDT acpi table changes for aarch64

so that CI tests don't fail when those ACPI tables are updated in the next patch. This is as per the documentation in bios-tables-tests.c. Signed-off-by: Sunil V L --- tests/qtest/bios-tables-test-allowed-diff.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qtest/bios-t

[PATCH v2 2/9] hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART

The RISC-V BRS specification [1] requires NS16550 compatible UART to have the HID RSCV0003. So, update the HID for the UART. [1] - https://github.com/riscv-non-isa/riscv-brs Signed-off-by: Sunil V L Acked-by: Alistair Francis --- hw/riscv/virt-acpi-build.c | 2 +- 1 file changed, 1 insertion

[PATCH v2 4/9] acpi/gpex: Create PCI link devices outside PCI root bridge

. So, this change will alter the DSDT for those systems. [1] - ACPI 5.1: 6.2.13.1 Example: Using _PRT to Describe PCI IRQ Routing Signed-off-by: Sunil V L --- hw/pci-host/gpex-acpi.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci

[PATCH v2 1/9] hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIC

PLIC and APLIC should be in namespace as well. So, add them using the defined HID. Signed-off-by: Sunil V L Acked-by: Alistair Francis --- hw/riscv/virt-acpi-build.c | 47 ++ 1 file changed, 47 insertions(+) diff --git a/hw/riscv/virt-acpi-build.c b/hw

[PATCH v2 6/9] tests/qtest/bios-tables-test.c: Remove the fall back path

The expected ACPI AML files are moved now under ${arch}/{machine} path. Hence, there is no need to search in old path which didn't have ${arch}. Remove the code which searches for the expected AML files under old path as well. Suggested-by: Igor Mammedov Signed-off-by: Sunil V L ---

[PATCH v2 5/9] tests/acpi: update expected DSDT blob for aarch64 and microvm

all PCI root bridges in the system, they should have unique names. So, instead of GSIx, named those devices as LXXY where L means link, XX will have PCI bus number and Y will have the INTx number (ex: L000 or L001). The _PRT entries will also be updated to reflect this name change. 2) PCI link

[PATCH v2 8/9] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

Add basic ACPI table test case for RISC-V. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios

[PATCH v2 9/9] tests/acpi: Add expected ACPI AML files for RISC-V

added. Signed-off-by: Sunil V L Acked-by: Alistair Francis Acked-by: Igor Mammedov --- tests/data/acpi/riscv64/virt/APIC | Bin 0 -> 116 bytes tests/data/acpi/riscv64/virt/DSDT | Bin 0 -> 3576 bytes tests/data/acpi/riscv64/virt/FACP | Bin 0 -> 276 bytes t

[PATCH v2 0/9] RISC-V: ACPI: Namespace updates

that CI tests don't fail. 2) Added patches to enable ACPI tables tests for RISC-V including a patch to remove the fallback path to search for expected AML files. 3) Rebased and added tags. Sunil V L (9): hw/riscv/virt-acpi-build.c: Add namespace device

[PATCH v2 7/9] tests/acpi: Add empty ACPI data files for RISC-V

As per process documented (steps 1-3) in bios-tables-test.c, add empty AML data files for RISC-V ACPI tables and add the entries in bios-tables-test-allowed-diff.h. Signed-off-by: Sunil V L Acked-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/data/acpi/riscv64/virt/APIC

Re: [PATCH v4 16/16] tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V

On Mon, Jul 08, 2024 at 01:16:49PM +1000, Alistair Francis wrote: > On Thu, Jul 4, 2024 at 12:57 AM Sunil V L wrote: > > > > On Wed, Jul 03, 2024 at 03:53:08PM +0530, Sunil V L wrote: > > > On Tue, Jul 02, 2024 at 03:02:36PM +0100, Jonathan Cameron wrote: > > > &g

Re: [PATCH v4 16/16] tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V

On Wed, Jul 03, 2024 at 03:53:08PM +0530, Sunil V L wrote: > On Tue, Jul 02, 2024 at 03:02:36PM +0100, Jonathan Cameron wrote: > > On Mon, 1 Jul 2024 17:03:43 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jun 27, 2024 at 02:18:03PM +0200, Igo

Re: [PATCH v4 16/16] tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V

On Tue, Jul 02, 2024 at 03:02:36PM +0100, Jonathan Cameron wrote: > On Mon, 1 Jul 2024 17:03:43 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Jun 27, 2024 at 02:18:03PM +0200, Igor Mammedov wrote: > > > On Tue, 25 Jun 2024 20:38:39 +0530 > > > Su

Re: [PATCH v4 06/16] tests/qtest/bios-tables-test.c: Add support for arch in path

On Tue, Jul 02, 2024 at 10:30:02AM +0200, Igor Mammedov wrote: > On Tue, 25 Jun 2024 20:38:29 +0530 > Sunil V L wrote: > > > Since machine name can be common for multiple architectures (ex: virt), > > add "arch" in the path to search for expected AML files. Si

[PATCH v4 05/16] qtest: bios-tables-test: Rename aarch64 tests with aarch64 in them

Existing AARCH64 virt test functions do not have AARCH64 in their name. To add RISC-V virt related test cases, better to rename existing functions to indicate they are ARM only. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables

[PATCH v4 04/16] tests/data/uefi-boot-images: Add RISC-V ISO image

To test ACPI tables, edk2 needs to be booted with a disk image having EFI partition. This image is created using UefiTestToolsPkg. The image is generated using tests/uefi-test-tools source. Signed-off-by: Sunil V L --- .../bios-tables-test.riscv64.iso.qcow2 | Bin 0 -> 16896 by

[PATCH v4 08/16] tests/qtest/bios-tables-test.c: Set "arch" for x86 tests

To search for expected AML files under ${arch}/${machine} path, set this field for X86 related test cases. Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 77 -- 1 file changed, 64 insertions(+), 13 deletions(-) diff

[PATCH v4 03/16] uefi-test-tools: Add support for python based build script

edk2-funcs.sh which is used in this Makefile, was removed in the commit c28a2891f3 ("edk2: update build script"). It is replaced with a python based script. So, update the Makefile and add the configuration file as required to support the python based build script. Signed-off-by: Sunil

[PATCH v4 16/16] tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V

added. Signed-off-by: Sunil V L Acked-by: Alistair Francis Acked-by: Igor Mammedov --- tests/data/acpi/riscv64/virt/APIC | Bin 0 -> 116 bytes tests/data/acpi/riscv64/virt/DSDT | Bin 0 -> 3518 bytes tests/data/acpi/riscv64/virt/FACP | Bin 0 -> 276 bytes t

[PATCH v4 02/16] uefi-test-tools/UefiTestToolsPkg: Add RISC-V support

Enable building the test application for RISC-V with appropriate dependencies updated. Signed-off-by: Sunil V L Acked-by: Gerd Hoffmann Acked-by: Alistair Francis Acked-by: Igor Mammedov --- tests/uefi-test-tools/UefiTestToolsPkg/UefiTestToolsPkg.dsc | 6 +- 1 file changed, 5 insertions

[PATCH v4 00/16] Add support for RISC-V ACPI tests

vel/2024-06/msg03683.html Sunil V L (16): hw/riscv/virt.c: Make block devices default to virtio uefi-test-tools/UefiTestToolsPkg: Add RISC-V support uefi-test-tools: Add support for python based build script tests/data/uefi-boot-images: Add RISC-V ISO image qtest: bios-tables-test: Rename

[PATCH v4 01/16] hw/riscv/virt.c: Make block devices default to virtio

ing a default cdrom device. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis --- hw/riscv/virt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 5676d66d12..e578c6dba7 100644 --- a/hw/riscv/virt.c +++ b/hw/

[PATCH v4 10/16] tests/data/acpi/virt: Move ARM64 ACPI tables under aarch64/${machine} path

Same machine name can be used by different architectures. Hence, create aarch64 folder and move all aarch64 related AML files for virt machine inside. Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov --- tests/data/acpi/{ => aarch64}/virt/APIC | Bin .../data/acpi/{ => a

[PATCH v4 12/16] pc-bios/meson.build: Add support for RISC-V in unpack_edk2_blobs

Update list of images supported in unpack_edk2_blobs to enable RISC-V ACPI table testing. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- pc-bios/meson.build | 2 ++ tests/qtest/meson.build | 3 +++ 2 files changed, 5 insertions(+) diff --git a/pc

[PATCH v4 09/16] tests/data/acpi: Move x86 ACPI tables under x86/${machine} path

To support multiple architectures using same machine name, create x86 folder and move all x86 related AML files for each machine type inside. Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov --- tests/data/acpi/{ => x86}/microvm/APIC | Bin tests/data/acpi/{ => x86}/m

[PATCH v4 07/16] tests/qtest/bios-tables-test.c: Set "arch" for aarch64 tests

To search for expected AML files under ${arch}/${machine} path, set this field for AARCH64 related test cases. Signed-off-by: Sunil V L Acked-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 8 1 file changed, 8 insertions(+) diff --git a/tests

[PATCH v4 15/16] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

Add basic ACPI table test case for RISC-V. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios

[PATCH v4 06/16] tests/qtest/bios-tables-test.c: Add support for arch in path

Since machine name can be common for multiple architectures (ex: virt), add "arch" in the path to search for expected AML files. Since the AML files are still under old path, add support for searching with and without arch in the path. Signed-off-by: Sunil V L Acked-by: Alista

[PATCH v4 13/16] tests/data/acpi/rebuild-expected-aml.sh: Add RISC-V

Update the list of supported architectures to include RISC-V. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/data/acpi/rebuild-expected-aml.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/data/acpi/rebuild-expected

[PATCH v4 14/16] tests/qtest/bios-tables-test: Add empty ACPI data files for RISC-V

As per process documented (steps 1-3) in bios-tables-test.c, add empty AML data files for RISC-V ACPI tables and add the entries in bios-tables-test-allowed-diff.h. Signed-off-by: Sunil V L Acked-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/data/acpi/riscv64/virt/APIC

[PATCH v4 11/16] meson.build: Add RISC-V to the edk2-target list

so that ACPI table test can be supported. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 97e00d6f59..b54b0463a4 100644 --- a/meson.build +++ b

Re: [PATCH v3 14/15] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

On Tue, Jun 25, 2024 at 04:06:58PM +0200, Igor Mammedov wrote: > On Tue, 25 Jun 2024 17:59:33 +0530 > Sunil V L wrote: > > > On Tue, Jun 25, 2024 at 02:05:58PM +0200, Igor Mammedov wrote: > > > On Tue, 25 Jun 2024 13:19:59 +0200 > > > Igor Mammedov wrote: > &

Re: [PATCH v3 14/15] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

On Tue, Jun 25, 2024 at 02:05:58PM +0200, Igor Mammedov wrote: > On Tue, 25 Jun 2024 13:19:59 +0200 > Igor Mammedov wrote: > > > On Fri, 21 Jun 2024 17:29:05 +0530 > > Sunil V L wrote: > > > > > Add basic ACPI table test case for RISC-V. > > > >

[PATCH v3 03/15] tests/data/uefi-boot-images: Add RISC-V ISO image

To test ACPI tables, edk2 needs to be booted with a disk image having EFI partition. This image is created using UefiTestToolsPkg. The image is generated using tests/uefi-test-tools source. Signed-off-by: Sunil V L --- .../bios-tables-test.riscv64.iso.qcow2 | Bin 0 -> 16896 by

[PATCH v3 05/15] tests/qtest/bios-tables-test.c: Add support for arch in path

Since machine name can be common for multiple architectures (ex: virt), add "arch" in the path to search for expected AML files. Since the AML files are still under old path, add support for searching with and without arch in the path. Signed-off-by: Sunil V L --- tests/qtest/bios-tab

[PATCH v3 12/15] tests/data/acpi/rebuild-expected-aml.sh: Add RISC-V

Update the list of supported architectures to include RISC-V. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/data/acpi/rebuild-expected-aml.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/data/acpi/rebuild-expected

[PATCH v3 04/15] qtest: bios-tables-test: Rename aarch64 tests with aarch64 in them

Existing AARCH64 virt test functions do not have AARCH64 in their name. To add RISC-V virt related test cases, better to rename existing functions to indicate they are ARM only. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables

[PATCH v3 06/15] tests/qtest/bios-tables-test.c: Set "arch" for aarch64 tests

To search for expected AML files under ${arch}/${machine} path, set this field for AARCH64 related test cases. Signed-off-by: Sunil V L --- tests/qtest/bios-tables-test.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c

[PATCH v3 13/15] tests/qtest/bios-tables-test: Add empty ACPI data files for RISC-V

As per process documented (steps 1-3) in bios-tables-test.c, add empty AML data files for RISC-V ACPI tables and add the entries in bios-tables-test-allowed-diff.h. Signed-off-by: Sunil V L Acked-by: Alistair Francis Reviewed-by: Igor Mammedov --- tests/data/acpi/riscv64/virt/APIC

[PATCH v3 15/15] tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V

added. Signed-off-by: Sunil V L Acked-by: Alistair Francis Acked-by: Igor Mammedov --- tests/data/acpi/riscv64/virt/APIC | Bin 0 -> 116 bytes tests/data/acpi/riscv64/virt/DSDT | Bin 0 -> 3518 bytes tests/data/acpi/riscv64/virt/FACP | Bin 0 -> 276 bytes t

[PATCH v3 11/15] pc-bios/meson.build: Add support for RISC-V in unpack_edk2_blobs

Update list of images supported in unpack_edk2_blobs to enable RISC-V ACPI table testing. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- pc-bios/meson.build | 2 ++ tests/qtest/meson.build | 3 +++ 2 files changed, 5 insertions(+) diff --git a/pc

[PATCH v3 02/15] uefi-test-tools: Add support for python based build script

edk2-funcs.sh which is used in this Makefile, was removed in the commit c28a2891f3 ("edk2: update build script"). It is replaced with a python based script. So, update the Makefile and add the configuration file as required to support the python based build script. Signed-off-by:

[PATCH v3 01/15] uefi-test-tools/UefiTestToolsPkg: Add RISC-V support

Enable building the test application for RISC-V with appropriate dependencies updated. Signed-off-by: Sunil V L Acked-by: Gerd Hoffmann Acked-by: Alistair Francis --- tests/uefi-test-tools/UefiTestToolsPkg/UefiTestToolsPkg.dsc | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH v3 14/15] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

Add basic ACPI table test case for RISC-V. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis --- tests/qtest/bios-tables-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index f4c4704bab

[PATCH v3 10/15] meson.build: Add RISC-V to the edk2-target list

so that ACPI table test can be supported. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 97e00d6f59..b54b0463a4 100644 --- a/meson.build +++ b

[PATCH v3 07/15] tests/qtest/bios-tables-test.c: Set "arch" for x86 tests

To search for expected AML files under ${arch}/${machine} path, set this field for X86 related test cases. Signed-off-by: Sunil V L --- tests/qtest/bios-tables-test.c | 77 -- 1 file changed, 64 insertions(+), 13 deletions(-) diff --git a/tests/qtest/bios-tables

[PATCH v3 08/15] tests/data/acpi: Move x86 ACPI tables under x86/${machine} path

To support multiple architectures using same machine name, create x86 folder and move all x86 related AML files for each machine type inside. Signed-off-by: Sunil V L --- tests/data/acpi/{ => x86}/microvm/APIC | Bin tests/data/acpi/{ => x86}/microvm/APIC.ioapic2 | Bin

[PATCH v3 09/15] tests/data/acpi/virt: Move ARM64 ACPI tables under aarch64/${machine} path

Same machine name can be used by different architectures. Hence, create aarch64 folder and move all aarch64 related AML files for virt machine inside. Signed-off-by: Sunil V L --- tests/data/acpi/{ => aarch64}/virt/APIC | Bin .../data/acpi/{ => aarch64}/virt/APIC.acpihm

[PATCH v3 00/15] Add support for RISC-V ACPI tests

ted tags. Changes since v1: 1) Addressed feedback from Gerd and Alistair 2) Rebased and added tags received [1]: https://mail.gnu.org/archive/html/qemu-devel/2024-06/msg03683.html Sunil V L (15): uefi-test-tools/UefiTestToolsPkg: Add RISC-V support uefi-test-tools: Add support fo

[PATCH] hw/riscv/virt.c: Make block devices default to virtio

ing a default cdrom device. Signed-off-by: Sunil V L --- hw/riscv/virt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 8675c3a7d1..b0871b7f81 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -1764,6 +1764,8 @@ static void virt_machine_class

Re: [PATCH v2 11/12] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

On Wed, Jun 19, 2024 at 12:12:50PM +0200, Igor Mammedov wrote: > On Fri, 24 May 2024 11:44:10 +0530 > Sunil V L wrote: > > > Add basic ACPI table test case for RISC-V. > > > > Signed-off-by: Sunil V L > > --- > > tests/qtest/bios-tables-test.c | 27

Re: [PATCH v2 06/12] tests/data/acpi/virt: Move ACPI tables under aarch64

On Wed, Jun 19, 2024 at 05:20:50AM -0400, Michael S. Tsirkin wrote: > On Wed, Jun 19, 2024 at 11:17:43AM +0200, Igor Mammedov wrote: > > On Mon, 27 May 2024 20:46:29 +0530 > > Sunil V L wrote: > > > > > On Mon, May 27, 2024 at 12:12:10PM +0200, Philippe Mathieu

Re: [PATCH 3/3] hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART

Hi Igor, On Wed, Jun 05, 2024 at 04:48:14PM +0200, Igor Mammedov wrote: > On Tue, 28 May 2024 13:01:03 +0530 > Sunil V L wrote: > > > RISC-V is going to use new HID RSCV0003 for generi UART. So, update the > > HID. > > where does it come from? > >

Re: [PATCH 1/3] gpex-acpi: Support PCI link devices outside the host bridge

Hi Michael, Thank you very much for the review! On Wed, Jun 05, 2024 at 04:23:36AM -0400, Michael S. Tsirkin wrote: > On Tue, May 28, 2024 at 01:01:01PM +0530, Sunil V L wrote: > > Currently, PCI link devices (PNP0C0F) are always created within the > > scope of the PCI root c

Re: [PATCH v4 0/3] hw/riscv/virt: pflash improvements

On Thu, May 30, 2024 at 04:37:56AM -0700, Andrea Bolognani wrote: > On Mon, Nov 20, 2023 at 08:06:19PM GMT, Sunil V L wrote: > > On Mon, Nov 20, 2023 at 02:29:28PM +, Andrea Bolognani wrote: > > > On Fri, May 26, 2023 at 11:10:12AM +0200, Andrew Jones wrote: > > >

[PATCH 1/3] gpex-acpi: Support PCI link devices outside the host bridge

well. Enable creating link devices outside the scope of PCI root complex based on the flag which gets set currently only for RISC-V. Signed-off-by: Sunil V L --- hw/pci-host/gpex-acpi.c| 29 - hw/riscv/virt-acpi-build.c | 8 +--- include/hw/pci-host/gpex.h

[PATCH 2/3] hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIC

PLIC and APLIC should be in namespace as well. So, add them using the defined HID. Signed-off-by: Sunil V L --- hw/riscv/virt-acpi-build.c | 47 ++ 1 file changed, 47 insertions(+) diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c index

[PATCH 3/3] hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART

RISC-V is going to use new HID RSCV0003 for generi UART. So, update the HID. Signed-off-by: Sunil V L --- hw/riscv/virt-acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c index 47ec78e432..7f80368415 100644

[PATCH 0/3] RISC-V: ACPI: Namespace updates

well to ensure probing order as per BRS spec [1] requirement. 3) BRS spec requires RISC-V to use new ACPI ID for the generic UART. So, update the HID of the UART. [1] - https://github.com/riscv-non-isa/riscv-brs Sunil V L (3): gpex-acpi: Support PCI link devices outside the host bridge hw

Re: [PATCH v2 06/12] tests/data/acpi/virt: Move ACPI tables under aarch64

On Mon, May 27, 2024 at 12:12:10PM +0200, Philippe Mathieu-Daudé wrote: > Hi Sunil, > > On 24/5/24 08:14, Sunil V L wrote: > > Since virt is a common machine name across architectures like ARM64 and > > RISC-V, move existing ARM64 ACPI tables under aarch64 folder so that >

[PATCH v2 03/12] tests/data/uefi-boot-images: Add RISC-V ISO image

To test ACPI tables, edk2 needs to be booted with a disk image having EFI partition. This image is created using UefiTestToolsPkg. The image is generated using tests/uefi-test-tools source. Signed-off-by: Sunil V L --- .../bios-tables-test.riscv64.iso.qcow2 | Bin 0 -> 16896 by

[PATCH v2 07/12] meson.build: Add RISC-V to the edk2-target list

so that ACPI table test can be supported. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index a9de71d450..576c803a8a 100644 --- a/meson.build +++ b/meson.build @@ -93,7 +93,7

[PATCH v2 10/12] tests/qtest/bios-tables-test: Add empty ACPI data files for RISC-V

As per process documented (steps 1-3) in bios-tables-test.c, add empty AML data files for RISC-V ACPI tables and add the entries in bios-tables-test-allowed-diff.h. Signed-off-by: Sunil V L --- tests/data/acpi/virt/riscv64/APIC | 0 tests/data/acpi/virt/riscv64/DSDT | 0

[PATCH v2 12/12] tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V

added. Signed-off-by: Sunil V L --- tests/data/acpi/virt/riscv64/APIC | Bin 0 -> 116 bytes tests/data/acpi/virt/riscv64/DSDT | Bin 0 -> 3518 bytes tests/data/acpi/virt/riscv64/FACP | Bin 0 -> 276 bytes tests/data/acpi/virt/riscv64/MCFG | Bin 0 -&

[PATCH v2 04/12] qtest: bios-tables-test: Rename aarch64 tests with aarch64 in them

Existing AARCH64 virt test functions do not have AARCH64 in their name. To add RISC-V virt related test cases, better to rename existing functions to indicate they are ARM only. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis --- tests/qtest/bios-tables-test.c | 35

[PATCH v2 09/12] tests/data/acpi/rebuild-expected-aml.sh: Add RISC-V

Update the list of supported architectures to include RISC-V. Signed-off-by: Sunil V L Reviewed-by: Alistair Francis --- tests/data/acpi/rebuild-expected-aml.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acpi

  1   2   3   4   5   6   7   8   9   10   >