Re: [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words

2012-03-28 Thread Lee Essen
On 28 Mar 2012, at 15:26, Alon Levy wrote: > Signed-off-by: Alon Levy > --- > scripts/tracetool |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/tracetool b/scripts/tracetool > index 65bd0a1..e7cebf3 100755 > --- a/scripts/tracetool > +++ b/scripts/tracet

Re: [Qemu-devel] [PATCH 1/4] Add socket/xnet libs to configure for Solaris

2012-03-27 Thread Lee Essen
On 27/03/2012 12:31, Andreas Färber wrote: Am 27.03.2012 09:23, schrieb Stefan Hajnoczi: On Sat, Mar 24, 2012 at 04:26:27PM +, Lee Essen wrote: libsocket and libxnet are required for base network functionality used in os_dep.c, qemu-socket.c, qga/commands-posix.c and cutils.c Signed-off

Re: [Qemu-devel] [PATCH 2/4] Enable sigbus_reraise for Solaris

2012-03-27 Thread Lee Essen
On 27/03/2012 08:29, Stefan Hajnoczi wrote: On Sat, Mar 24, 2012 at 04:26:28PM +, Lee Essen wrote: sigbus_reraise is used by the kvm_wait_io_event function and is needed on both Linux and Solaris. This patch adds CONFIG_SOLARIS to the current CONFIG_LINUX only ifdef. Signed-off-by: Lee

[Qemu-devel] [PATCH 2/2] Add support for Solaris dtrace -m32/-m64 flags

2012-03-27 Thread Lee Essen
Solaris requires a -m32/-m64 flag to determin if building for 32bit or 64bit environments. This patch add a CONFIG_DTRACE_FLAGS variable to configure and then makes use of that in the relevant Makefiles and rules.mak Signed-off-by: Lee Essen --- Makefile.objs |2 +- configure |8

[Qemu-devel] [PATCH 1/2] Add support for Solaris dtrace object linking

2012-03-27 Thread Lee Essen
Solaris requires that dtrace is supplied with all objects when generating the dtrace object file. This patch updates the build for each of the utility binaries and the main target generation. Signed-off-by: Lee Essen --- Makefile| 37

Re: [Qemu-devel] Thoughts around dtrace linking...

2012-03-26 Thread Lee Essen
On 26/03/2012 11:14, Stefan Hajnoczi wrote: On Fri, Mar 23, 2012 at 2:11 PM, Lee Essen wrote: On 23 Mar 2012, at 08:08, Stefan Hajnoczi wrote: On Thu, Mar 22, 2012 at 05:00:53PM +, Lee Essen wrote: On 22/03/2012 16:28, Stefan Hajnoczi wrote: On Wed, Mar 21, 2012 at 1:01 PM, Andreas

[Qemu-devel] [PATCH 1/4] Add socket/xnet libs to configure for Solaris

2012-03-24 Thread Lee Essen
libsocket and libxnet are required for base network functionality used in os_dep.c, qemu-socket.c, qga/commands-posix.c and cutils.c Signed-off-by: Lee Essen --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 8b4e3c1..152adaa

[Qemu-devel] [PATCH 4/4] qga/channel-posix: provide Solaris alternative to O_ASYNC

2012-03-24 Thread Lee Essen
Solaris does not support the O_ASYNC option to open, this patch adds the same functionality through the I_SETSIG ioctl. Signed-off-by: Lee Essen --- qga/channel-posix.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/qga/channel-posix.c b/qga/channel

[Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris

2012-03-24 Thread Lee Essen
Dynticks was limited to linux. This patch adds Solaris support and ensures a CLOCK_HIGHRES clock is used which is the optimal setup for Solaris systems. Signed-off-by: Lee Essen --- qemu-timer.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/qemu-timer.c b

[Qemu-devel] [PATCH 2/4] Enable sigbus_reraise for Solaris

2012-03-24 Thread Lee Essen
sigbus_reraise is used by the kvm_wait_io_event function and is needed on both Linux and Solaris. This patch adds CONFIG_SOLARIS to the current CONFIG_LINUX only ifdef. Signed-off-by: Lee Essen --- cpus.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/cpus.c b

Re: [Qemu-devel] [PATCH v2] Basic Illumos support

2012-03-24 Thread Lee Essen
On 24 Mar 2012, at 15:44, Andreas Färber wrote: > Am 24.03.2012 15:51, schrieb Lee Essen: >> On 24 Mar 2012, at 12:56, Blue Swirl wrote: >> >>> On Sat, Mar 17, 2012 at 08:04, Lee Essen wrote: >>>> (third email attempt, apologies if you get duplicates) &

Re: [Qemu-devel] [PATCH v2] Basic Illumos support

2012-03-24 Thread Lee Essen
On 24 Mar 2012, at 12:56, Blue Swirl wrote: > On Sat, Mar 17, 2012 at 08:04, Lee Essen wrote: >> (third email attempt, apologies if you get duplicates) > > The patch does not apply: > git am: > Applying: Basic Illumos support > fatal: corrupt patch at line 19 >

Re: [Qemu-devel] Thoughts around dtrace linking...

2012-03-23 Thread Lee Essen
On 23 Mar 2012, at 08:08, Stefan Hajnoczi wrote: > On Thu, Mar 22, 2012 at 05:00:53PM +0000, Lee Essen wrote: >> On 22/03/2012 16:28, Stefan Hajnoczi wrote: >>> On Wed, Mar 21, 2012 at 1:01 PM, Andreas Färber wrote: >>>> Hi, >>>> >>>> A

Re: [Qemu-devel] Spice bug with qemu_name

2012-03-23 Thread Lee Essen
On 23 Mar 2012, at 10:18, Alon Levy wrote: > On Fri, Mar 23, 2012 at 08:10:36AM +0000, Lee Essen wrote: >> Hi, >> >> I think I've found a bug with the way that spice uses qemu_name. >> >> qemu_name is a char *, that's only set to if "-

[Qemu-devel] Spice bug with qemu_name

2012-03-23 Thread Lee Essen
Hi, I think I've found a bug with the way that spice uses qemu_name. qemu_name is a char *, that's only set to if "-name" is given (and then the arg is strdup'd), otherwise it's not set properly. In ui/spice_core.c spice_server_set_name() is called with qemu_name, which if not set causes a co

Re: [Qemu-devel] Thoughts around dtrace linking...

2012-03-22 Thread Lee Essen
On 22/03/2012 16:28, Stefan Hajnoczi wrote: On Wed, Mar 21, 2012 at 1:01 PM, Andreas Färber wrote: Hi, Am 21.03.2012 11:45, schrieb Lee Essen: I've been trying to find a sensible way to solve the Solaris/Illumos dtrace requirement to pass all the objs to the dtrace command so tha

Re: [Qemu-devel] tracetool: cast const types to avoid compile time warnings

2012-03-22 Thread Lee Essen
On 22/03/2012 08:28, Stefan Hajnoczi wrote: On Wed, Mar 21, 2012 at 05:08:15PM +, Lee Essen wrote: On Solaris/Illumos dtrace will remove the "const" qualifier from any arguments when producing the header file, this results in hundreds of compile-time warnings. I wonder why D

[Qemu-devel] tracetool: cast const types to avoid compile time warnings

2012-03-21 Thread Lee Essen
On Solaris/Illumos dtrace will remove the "const" qualifier from any arguments when producing the header file, this results in hundreds of compile-time warnings. I have put together a patch to tracetool to cast any const argument appropriately to remove the warnings, but I don't know how it beha

Re: [Qemu-devel] Thoughts around dtrace linking...

2012-03-21 Thread Lee Essen
On 21/03/2012 13:01, Andreas Färber wrote: Hi, Am 21.03.2012 11:45, schrieb Lee Essen: I've been trying to find a sensible way to solve the Solaris/Illumos dtrace requirement to pass all the objs to the dtrace command so that the resultant object file contains all the symbols need

[Qemu-devel] Thoughts around dtrace linking...

2012-03-21 Thread Lee Essen
Hi, I've been trying to find a sensible way to solve the Solaris/Illumos dtrace requirement to pass all the objs to the dtrace command so that the resultant object file contains all the symbols needed to properly link the relevant binary. The easiest way to do this is just prior to linking t

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-20 Thread Lee Essen
On 20/03/2012 16:59, Stefan Hajnoczi wrote: On Mon, Mar 19, 2012 at 1:35 PM, Lee Essen wrote: On 19 Mar 2012, at 12:32, Andreas Färber wrote: Am 19.03.2012 13:05, schrieb Lee Essen: In my original (way-too-long) patch for Illumos I included fixes for both of the above, the approach I took

[Qemu-devel] [PATCH v2] tracetool dtrace disabled-events fix

2012-03-20 Thread Lee Essen
If there are "disabled" entries in the trace-events file then linetod_nop() is called if the backend is dtrace, it's currently not present. Also equivalent fix for stap. Signed-off-by: Lee Essen -- diff --git a/scripts/tracetool b/scripts/tracetool index 65bd0a1..a279c2c 10075

[Qemu-devel] [PATCH] tracetool dtrace disabled-events fix

2012-03-20 Thread Lee Essen
If there are "disabled" entries in the trace-events file then linetod_nop() is called if the backend is dtrace, it's currently not present. Signed-off-by: Lee Essen -- diff --git a/scripts/tracetool b/scripts/tracetool index 65bd0a1..d5e5591 100755 --- a/scripts/tracetoo

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Lee Essen
On 19 Mar 2012, at 12:32, Andreas Färber wrote: > Am 19.03.2012 13:05, schrieb Lee Essen: >> On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: >> >>> I'm going to spend some time today reviewing recent tracing patches. >>> I'd prefer to move to a Py

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Lee Essen
On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: > On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen wrote: >> Signed-off-by: Lee Essen >> >> --- >> >> scripts/tracetool |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > I'm going

[Qemu-devel] [PATCH v2] Basic Illumos support

2012-03-17 Thread Lee Essen
e are lots of __linux__ || __sun__ constructs, I wanted to make sure I didn't alter the linux behaviour and this seemed the safest way to do it. Signed-off-by: Lee Essen --- configure|1 + cpus.c |4 +++- qemu-timer.c | 14 +- qga/chann

Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 11:56, Paolo Bonzini wrote: > Il 16/03/2012 10:23, Lee Essen ha scritto: >> +while (mlock(base, (nbytes = step * ps)) == -1) { >> +if (errno != EAGAIN) { >> +return -1; >> +} >> + >> +if (

Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 16:28, Paolo Bonzini wrote: > Il 16/03/2012 14:46, Lee Essen ha scritto: >> It does indeed … this came from the original Joyent code, I must >> admit I did wonder whether gcc would optimise it away. I did consider >> adding something to stop gcc complaini

Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 13:14, Jan Kiszka wrote: > On 2012-03-16 10:23, Lee Essen wrote: >> +#ifdef __sun__ >> +#include >> +#else >> #include >> #include >> +#endif > > As Paolo already said, this should somehow be centralised. Yep, fair point. I&#x

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 12:44, Andreas Färber wrote: > Am 16.03.2012 13:29, schrieb Lee Essen: >> Signed-off-by: Lee Essen >> >> --- >> >> scripts/tracetool |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/scr

[Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Lee Essen
Signed-off-by: Lee Essen --- scripts/tracetool |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 65bd0a1..2e43d05 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -123,7 +123,7 @@ get_argc() # Get the format string

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 12:20, Lee Essen wrote: > > On 16 Mar 2012, at 12:14, Andreas Färber wrote: > >> Am 16.03.2012 13:02, schrieb Lee Essen: >>> >>> target_list="" >>> >>> @@ -442,6 +443,7 @@ SunOS) >>> # have to selec

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 12:14, Andreas Färber wrote: > Am 16.03.2012 13:02, schrieb Lee Essen: >> >> target_list="" >> >> @@ -442,6 +443,7 @@ SunOS) >> # have to select again, because `uname -m` returns i86pc >> # even on an x86_64 box. >>

[Qemu-devel] [PATCH 2/5] use SHELL in Makefiles

2012-03-16 Thread Lee Essen
Use the SHELL macro (set in configure) to ensure tracetool and hxtool are correctly called. Signed-off-by: Lee Essen --- Makefile.objs |6 +++--- Makefile.target |6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 226b01d

[Qemu-devel] [PATCH 1/5] configure to set shell type

2012-03-16 Thread Lee Essen
Adds support to configure for controlling which shell to use, defaults to "sh" as before but adds "bash" for Solaris/Illumos builds. Plus ensures that tracetool is called with a shell. Signed-off-by: Lee Essen -- configure |7 +-- 1 files changed, 5 insert

Re: [Qemu-devel] Illumos/SmarOS support

2012-03-15 Thread Lee Essen
On 15/03/2012 13:12, Andreas Färber wrote: Something went wrong with your reply... While it contains a quote it does not reference the mail you replied to, that way messages get lost among the constant chatter on qemu-devel. Hmmm ... sorry -- I'm having to cut and paste emails between mail clien

[Qemu-devel] Illumos/SmartOS support

2012-03-15 Thread Lee Essen
Resend -- not sure what happened to my first mail... Hi, I've been working on getting the mainline qemu tree working on SmartOS (illumos), the current qemu support seems to be a branch of qemu-kvm and we've been having some problems getting spice working, so moving to the main qemu tree seemed

[Qemu-devel] illumos/SmartOS support

2012-03-15 Thread Lee Essen
Hi, I've been working on getting the mainline qemu tree working on SmartOS (illumos), the current qemu support seems to be a branch of qemu-kvm and we've been having some problems getting spice working, so moving to the main qemu tree seemed sensible. Anyway, couple of questions… 1. Are you h

Re: [Qemu-devel] Illumos/SmarOS support

2012-03-15 Thread lee . essen
On 15/03/2012 11:56, Stefan Hajnoczi wrote: Anyway, couple of questions… 1. Are you happy to accept patches that enable this? - There are a few build related things that don't work … assumption of sh being bash, missing -64 argument to dtrace etc. Sounds good, but have you checked the Joyen

[Qemu-devel] Illumos/SmarOS support

2012-03-15 Thread Lee Essen
Resend from different email -- not sure what happened to my first 2 attempts! Hi, I've been working on getting the mainline qemu tree working on SmartOS (illumos), the current qemu support seems to be a branch of qemu-kvm and we've been having some problems getting spice working, so moving to the