Re: [Qemu-devel] vNVRAM / blobstore design

2013-03-27 Thread mdroth
On Wed, Mar 27, 2013 at 05:30:09PM +0200, Michael S. Tsirkin wrote: On Wed, Mar 27, 2013 at 11:20:43AM -0400, Corey Bryant wrote: On 03/27/2013 11:17 AM, Corey Bryant wrote: On 03/25/2013 06:20 PM, Stefan Berger wrote: On 03/25/2013 06:05 PM, Anthony Liguori wrote: Stefan

Re: [Qemu-devel] [PATCH] Fix some memory leaks in test-visitor-serialization

2013-03-27 Thread mdroth
On Tue, Mar 26, 2013 at 05:46:55PM -0400, Stefan Berger wrote: This patch fixes some of the memory leaks in test-visitor-serialization but not all of them. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- tests/test-visitor-serialization.c | 17 ++--- 1 file

Re: [Qemu-devel] [PATCH 0/2 v7] Add Windows support for time resync by qemu-ga

2013-03-25 Thread mdroth
On Fri, Mar 15, 2013 at 05:29:03PM +0800, Lei Li wrote: This patch series attempts to add Windows implementation for qemu-ga commands guest-get-time and guest-set-time. Thanks, applied to qga branch. The previous thread about the interfaces introduced and the POSIX-specific command

Re: [Qemu-devel] [PATCH 0/2] documentation fixups for the qga schema

2013-03-25 Thread mdroth
On Fri, Mar 15, 2013 at 07:07:49PM +0100, Laszlo Ersek wrote: Laszlo Ersek (2): qga schema: mark optional GuestLogicalProcessor.can-offline with #optional qga schema: document generic QERR_UNSUPPORTED qga/qapi-schema.json | 18 +++--- 1 files changed, 15

Re: [Qemu-devel] [PATCH] qemu-ga: ga_get_fd_handle(): abort if fd_counter overflows

2013-03-25 Thread mdroth
On Fri, Mar 22, 2013 at 04:31:07PM -0400, Luiz Capitulino wrote: Today we reset fd_counter if it wraps, but it's better to abort() instead, as fd_counter should never reach INT64_MAX. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Thanks, applied to qga branch with

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-21 Thread mdroth
On Thu, Mar 21, 2013 at 08:03:11AM +0100, Markus Armbruster wrote: mdroth mdr...@linux.vnet.ibm.com writes: On Wed, Mar 20, 2013 at 02:38:35PM -0400, Luiz Capitulino wrote: On Wed, 20 Mar 2013 13:14:21 -0500 mdroth mdr...@linux.vnet.ibm.com wrote: +handle = s

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-21 Thread mdroth
On Thu, Mar 21, 2013 at 02:24:56PM -0400, Luiz Capitulino wrote: On Thu, 21 Mar 2013 11:13:13 -0500 mdroth mdr...@linux.vnet.ibm.com wrote: Looks like you guys have no *practical* problems to solve. Congrats! Take a vacation! Please report back no later than 275 years from now

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 10:54:51AM -0400, Luiz Capitulino wrote: On Fri, 1 Mar 2013 11:40:27 -0600 Michael Roth mdr...@linux.vnet.ibm.com wrote: Hosts hold on to handles provided by guest-file-open for periods that can span beyond the life of the qemu-ga process that issued them. Since

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 12:58:51PM -0400, Luiz Capitulino wrote: On Wed, 20 Mar 2013 11:03:08 -0500 mdroth mdr...@linux.vnet.ibm.com wrote: On Wed, Mar 20, 2013 at 10:54:51AM -0400, Luiz Capitulino wrote: On Fri, 1 Mar 2013 11:40:27 -0600 Michael Roth mdr...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 01:40:56PM -0400, Luiz Capitulino wrote: On Wed, 20 Mar 2013 12:26:30 -0500 mdroth mdr...@linux.vnet.ibm.com wrote: On Wed, Mar 20, 2013 at 12:58:51PM -0400, Luiz Capitulino wrote: On Wed, 20 Mar 2013 11:03:08 -0500 mdroth mdr...@linux.vnet.ibm.com wrote

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 02:38:35PM -0400, Luiz Capitulino wrote: On Wed, 20 Mar 2013 13:14:21 -0500 mdroth mdr...@linux.vnet.ibm.com wrote: +handle = s-pstate.fd_counter++; +if (s-pstate.fd_counter 0) { +s-pstate.fd_counter = 0

Re: [Qemu-devel] QEMU Migration

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 01:26:22PM +0530, Mrugani Kurtadikar wrote: Hi, We are trying qemu migration. Suppose VM1 is migrated from hostA to hostB. After complete migration, VM1 starts on hostB. But VM1 on hostA remains in suspended mode. We want to identify all live VMs on hostA. We are

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 03:56:18PM -0400, Luiz Capitulino wrote: On Wed, 20 Mar 2013 14:39:55 -0500 mdroth mdr...@linux.vnet.ibm.com wrote: So I wonder if, rather than pursuing option 3, we just introduce an interface that does what we really want and returns handles as UUIDs, then mark

Re: [Qemu-devel] [PATCH 2/2] qga schema: document generic QERR_UNSUPPORTED

2013-03-15 Thread mdroth
On Fri, Mar 15, 2013 at 07:07:51PM +0100, Laszlo Ersek wrote: Part of the wording was shamelessly stolen from Michael Roth's email. :) series: Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com Suggested-by: Michael Roth mdr...@linux.vnet.ibm.com Signed-off-by: Laszlo Ersek

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Berger wrote: On 03/13/2013 07:18 PM, mdroth wrote: On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: On 03/13/2013 04:52 PM, mdroth wrote: Visitors don't have any knowledge of the data structures they're visiting outside of what

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 03:07:50PM +0800, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-win32.c | 33 + 1 file changed, 33 insertions(+) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 7e8ecb3..e24fb4a 100644

Re: [Qemu-devel] [PATCH 2/2] qga: add windows implementation for guest-set-time

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 03:07:51PM +0800, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-win32.c | 33 + 1 file changed, 33 insertions(+) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index e24fb4a..8064c3a 100644

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berger wrote: On 03/14/2013 08:18 AM, mdroth wrote: On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Berger wrote: On 03/13/2013 07:18 PM, mdroth wrote: On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: On 03/13/2013 04:52 PM

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 10:51:49AM -0400, Stefan Berger wrote: On 03/14/2013 10:28 AM, mdroth wrote: On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berger wrote: On 03/14/2013 08:18 AM, mdroth wrote: On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Berger wrote: On 03/13/2013 07:18 PM

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 11:24:03AM -0400, Stefan Berger wrote: On 03/14/2013 11:11 AM, mdroth wrote: On Thu, Mar 14, 2013 at 10:51:49AM -0400, Stefan Berger wrote: On 03/14/2013 10:28 AM, mdroth wrote: On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berger wrote: On 03/14/2013 08:18 AM

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 11:05:52PM +0800, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-win32.c | 29 + 1 file changed, 29 insertions(+) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 7e8ecb3..b395bd5 100644 ---

Re: [Qemu-devel] [PATCH 0/2 v6] Add Windows support for time resync by qemu-ga

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 11:05:51PM +0800, Lei Li wrote: This patch series attempts to add Windows implementation for qemu-ga commands guest-get-time and guest-set-time. The previous thread about the interfaces introduced and the POSIX-specific command implementation has already been

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 05:21:02PM +0100, Paolo Bonzini wrote: Il 13/03/2013 13:34, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Il 13/03/2013 06:59, Liu Ping Fan ha scritto: These series aim to port network backend onto glib, and prepare for moving towards

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 06:10:30PM +0800, li...@linux.vnet.ibm.com wrote: From: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-win32.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 03:07:52PM -0500, mdroth wrote: On Wed, Mar 13, 2013 at 06:10:30PM +0800, li...@linux.vnet.ibm.com wrote: From: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-win32.c | 32 1

Re: [Qemu-devel] [PATCH 2/2] qga: add windows implementation for guest-set-time

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 06:10:31PM +0800, li...@linux.vnet.ibm.com wrote: From: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-win32.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 01:56:24PM -0500, Joel Schopp wrote: Add a sized buffer interface to qapi. Isn't this just a special case of the visit_*_carray() interfaces? We should avoid new interfaces if possible, since it adds to feature disparities between visitor implementations. Cc: Michael

Re: [Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 01:56:23PM -0500, Joel Schopp wrote: This patch adds support functions for operating on in memory sized file buffers. There's been some past refactorings to remove non-migration users of QEMUFile, and AFAIK that's still the case today. QEMUFile satisfies funky

Re: [Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 05:28:56PM -0400, Stefan Berger wrote: On 03/13/2013 05:11 PM, mdroth wrote: On Wed, Mar 13, 2013 at 01:56:23PM -0500, Joel Schopp wrote: This patch adds support functions for operating on in memory sized file buffers. There's been some past refactorings to remove non

Re: [Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 05:41:33PM -0500, mdroth wrote: On Wed, Mar 13, 2013 at 05:28:56PM -0400, Stefan Berger wrote: On 03/13/2013 05:11 PM, mdroth wrote: On Wed, Mar 13, 2013 at 01:56:23PM -0500, Joel Schopp wrote: This patch adds support functions for operating on in memory sized file

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: On 03/13/2013 04:52 PM, mdroth wrote: On Wed, Mar 13, 2013 at 01:56:24PM -0500, Joel Schopp wrote: Add a sized buffer interface to qapi. Isn't this just a special case of the visit_*_carray() interfaces? We should avoid new

Re: [Qemu-devel] [PATCH v2 1/3] qga: introduce guest-get-vcpus / guest-set-vcpus with stubs

2013-03-06 Thread mdroth
On Wed, Mar 06, 2013 at 11:48:14PM +0100, Laszlo Ersek wrote: On 03/06/13 23:32, Eric Blake wrote: On 03/06/2013 02:59 PM, Laszlo Ersek wrote: +## +# @GuestLogicalProcessor: +# +# @logical-id: Arbitrary guest-specific unique identifier of the VCPU. +# +# @online: Whether the VCPU

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Mon, Mar 04, 2013 at 11:19:56PM +0100, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- qga/commands-posix.c | 87 ++ 1 files changed, 87 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c

Re: [Qemu-devel] [PATCH 3/3] qga: implement qmp_guest_set_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Mon, Mar 04, 2013 at 11:19:57PM +0100, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- qga/commands-posix.c | 51 ++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Tue, Mar 05, 2013 at 01:22:03PM -0700, Eric Blake wrote: On 03/05/2013 01:03 PM, mdroth wrote: +buf = g_strdup_printf(/sys/devices/system/cpu/cpu%ld/online, + current); +f = fopen(buf, r); +if (f == NULL

Re: [Qemu-devel] [PATCH 0/3] *** make netlayer re-entrant ***

2013-03-05 Thread mdroth
On Sun, Mar 03, 2013 at 09:21:19PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com This series aim to make netlayer re-entrant, so netlayer can run out of biglock safely. I think most of the locking considerations are still applicable either way, but this series

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Tue, Mar 05, 2013 at 10:34:08PM +0100, Laszlo Ersek wrote: On 03/05/13 21:25, Eric Blake wrote: On 03/04/2013 03:19 PM, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp) { +#if defined(__linux__)

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-05 Thread mdroth
On Fri, Mar 01, 2013 at 11:40:27AM -0600, Michael Roth wrote: Hosts hold on to handles provided by guest-file-open for periods that can span beyond the life of the qemu-ga process that issued them. Since these are issued starting from 0 on every restart, we run the risk of issuing duplicate

Re: [Qemu-devel] [PATCH 0/2 v5] Time resync support by qemu-ga

2013-03-05 Thread mdroth
On Tue, Mar 05, 2013 at 05:39:10PM +0800, Lei Li wrote: This patch series attempts to add time resync support to qemu-ga by introducing qemu-ga commands guest-get-time and guest-set-time. Thanks, applied to qga branch. Right now, when a guest is paused or migrated to a file then loaded

Re: [Qemu-devel] The state of testing

2013-03-04 Thread mdroth
On Mon, Mar 04, 2013 at 05:22:34PM +0100, Gerd Hoffmann wrote: Hi, How are things looking with device emulation, migration, monitor, char, etc? At the moment autotest/virt-test is pretty much the only workable thing for non-trivial devices because libqtest lacks infrastructure for pci

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-03-04 Thread mdroth
On Mon, Mar 04, 2013 at 05:16:29PM +0800, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/commands-posix.c | 16 qga/qapi-schema.json | 13 + 2 files changed, 29 insertions(+) diff

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-04 Thread mdroth
On Mon, Mar 04, 2013 at 05:16:30PM +0800, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 54 qga/qapi-schema.json | 27 ++ 2 files changed, 81 insertions(+) diff --git

Re: [Qemu-devel] [PATCH] qemu-ga: make guest-sync-delimited available during fsfreeze

2013-03-04 Thread mdroth
On Fri, Mar 01, 2013 at 11:53:40AM -0600, Michael Roth wrote: We currently maintain a whitelist of commands that are safe during fsfreeze. During fsfreeze, we disable all commands that aren't part of that whitelist. guest-sync-delimited meets the criteria for being whitelisted, and is also

Re: [Qemu-devel] [PATCH 1/3] two new file wrappers

2013-02-27 Thread mdroth
On Wed, Feb 27, 2013 at 08:46:19AM -0500, Stefan Berger wrote: On 02/26/2013 09:19 PM, Anthony Liguori wrote: jsch...@linux.vnet.ibm.com writes: I think we've moved away from using qemu-file for anything other than migration. Our goal was to use the abstraction of a QEMUFile for writing

Re: [Qemu-devel] [PATCH 2/3] asn1 ber visitors

2013-02-27 Thread mdroth
On Wed, Feb 27, 2013 at 02:03:45PM -0600, Joel Schopp wrote: Thanks for the feedback. On 02/27/2013 02:28 AM, Andreas Färber wrote: Am 27.02.2013 00:03, schrieb jsch...@linux.vnet.ibm.com: These patches implement asn1 ber visitors for encoding and decoding data. Would be good to not be

Re: [Qemu-devel] [PATCH 1/3] two new file wrappers

2013-02-27 Thread mdroth
On Wed, Feb 27, 2013 at 03:56:27PM -0600, mdroth wrote: On Wed, Feb 27, 2013 at 08:46:19AM -0500, Stefan Berger wrote: On 02/26/2013 09:19 PM, Anthony Liguori wrote: jsch...@linux.vnet.ibm.com writes: I think we've moved away from using qemu-file for anything other than migration

Re: [Qemu-devel] [PATCH 2/3] asn1 ber visitors

2013-02-27 Thread mdroth
On Wed, Feb 27, 2013 at 06:24:45PM -0500, Stefan Berger wrote: On 02/27/2013 05:57 PM, mdroth wrote: On Tue, Feb 26, 2013 at 05:03:56PM -0600, jsch...@linux.vnet.ibm.com wrote: These patches implement asn1 ber visitors for encoding and decoding data. References: 20130226230354.982917

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-25 Thread mdroth
On Fri, Feb 22, 2013 at 09:53:11AM +0100, Paolo Bonzini wrote: Il 22/02/2013 00:38, mdroth ha scritto: On Thu, Feb 21, 2013 at 11:12:01PM +0100, Paolo Bonzini wrote: Il 21/02/2013 22:07, mdroth ha scritto: 100% agree. In particular hw/dataplane/event-poll.c should be the first to go

Re: [Qemu-devel] [PATCH 1/9] chardev: add support for qapi-based chardev initialization

2013-02-25 Thread mdroth
On Mon, Feb 25, 2013 at 10:03:33AM +0100, Gerd Hoffmann wrote: This patch add support for a new way to initialize chardev devices. Instead of calling a initialization function with a QemuOpts we will now create a (qapi) ChardevBackend, optionally call a function to fill ChardevBackend from

Re: [Qemu-devel] GTK UI is now the default

2013-02-22 Thread mdroth
On Fri, Feb 22, 2013 at 04:48:47PM +0100, Paolo Bonzini wrote: Il 22/02/2013 16:17, Anthony Liguori ha scritto: FWIW I'd be in favor of making grab-on-hover the default. It really breaks window manager key bindings. If you alt-tab between windows and you happen to end up with the window

Re: [Qemu-devel] 'info help'

2013-02-22 Thread mdroth
On Fri, Feb 22, 2013 at 05:10:29PM +, Serge E. Hallyn wrote: Hi, up to and including 1.3.0, monitor.c:do_info(), if it got no arg or an unknown arg, would do help_cmd(mon, info); That behavior is gone in 1.4.0, so that 'info', 'info help', and 'info whatever' just say unknown argument.

Re: [Qemu-devel] [Bug 1131757] [NEW] QEMU 1.4.0 fails to boot sparc64 linux image

2013-02-22 Thread mdroth
to work for me on both 1.3.0 and 1.4.0: mdroth@loki:~/w/qemu-build2$ sparc64-softmmu/qemu-system-sparc64 -kernel ~/w/qemu-test-images/sparc/sparc-test/vmlinux-2.6.11+tcx -prom-env 'auto-boot?=false' -L pc-bios/ -nographic OpenBIOS for Sparc64 Configuration device id QEMU version 1 machine id 0 kernel

Re: [Qemu-devel] [PATCH] move qemu-ga from bin to libexec dir, use $HELPERS

2013-02-21 Thread mdroth
On Sat, Feb 16, 2013 at 10:28:31PM +0400, Michael Tokarev wrote: This patch does 3 things: 1. Renames HELPERS-y Makefile variable to HELPERS 2. Moves its definition from Makefile to configure 3. Moves qemu-ga binary from TOOLS to HELPERS. The effects are: 1. qemu-ga binary is now

Re: [Qemu-devel] [PATCH] move qemu-ga from bin to libexec dir, use $HELPERS

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 03:39:44PM +0100, Paolo Bonzini wrote: Il 21/02/2013 15:30, Michael Tokarev ha scritto: 21.02.2013 17:35, Paolo Bonzini wrote: Il 16/02/2013 19:28, Michael Tokarev ha scritto: This patch does 3 things: 1. Renames HELPERS-y Makefile variable to HELPERS 2. Moves

Re: [Qemu-devel] [PATCH 3/9] event poll: make epoll work for normal fd

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 08:54:47PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com When event poll can work with normal fd, we can port them onto the event loop. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/dataplane/event-poll.c | 36

Re: [Qemu-devel] [PATCH 5/9] event poll: enable event poll handle more than one event each time

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 08:54:49PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Set handled event count at initialized time for the dedicated thread. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/dataplane/event-poll.c | 31

Re: [Qemu-devel] [PATCH 6/9] virtio net: introduce dataplane for virtio net

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 08:54:50PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com This is a emulation to virtio-blk dataplane, which push the data handling out of biglock. And it is a try to implement this process in userspace, while vhost-net in kernel.

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 06:05:44PM +0100, Paolo Bonzini wrote: Il 21/02/2013 17:33, Stefan Hajnoczi ha scritto: Interesting patch series. I want to share my thoughts on the status of dataplane and what I'm currently working on. There will probably be some overlap that we can coordinate.

Re: [Qemu-devel] [PATCH] dataplane: remove EventPoll in favor of AioContext

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 05:29:55PM +0100, Paolo Bonzini wrote: During the review of the dataplane code, the EventPoll API morphed itself (not concidentially) into something very very similar to an AioContext. Thus, it is trivial to convert virtio-blk-dataplane to use AioContext, and a first

Re: [Qemu-devel] [PATCH] slirp: fixed potential use-after-free of a socket

2013-02-21 Thread mdroth
On Fri, Feb 15, 2013 at 12:00:13PM +0100, Vitaly Chipounov wrote: A socket may still have references to it in various queues at the time it is freed, causing memory corruptions. Signed-off-by: Vitaly Chipounov vitaly.chipou...@epfl.ch --- slirp/socket.c | 29 +

Re: [Qemu-devel] [PATCH] slirp: fixed potential use-after-free of a socket

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 03:47:25PM -0600, mdroth wrote: On Fri, Feb 15, 2013 at 12:00:13PM +0100, Vitaly Chipounov wrote: A socket may still have references to it in various queues at the time it is freed, causing memory corruptions. Signed-off-by: Vitaly Chipounov vitaly.chipou

Re: [Qemu-devel] [PATCH] fix wrong output with 'info chardev' for tcp socket.

2013-02-21 Thread mdroth
On Fri, Feb 22, 2013 at 12:29:44AM +0400, Michael Tokarev wrote: 22.02.2013 00:20, Serge E. Hallyn wrote: The snprintf format isn't taking into account the new 'left' and 'right' variables (for ipv6 []) when placing the ':', which should go immediately before the port. This fixes actual

Re: [Qemu-devel] BUG: RTC issue when Windows guest is idle

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 06:16:10PM +, Matthew Anderson wrote: If this isn't the correct list just let me know, I've run into a bug whereby a Windows guest (tested on Server 2008R2 and 2012) no longer receives RTC ticks when it has been idle for a random amount of time. HPET is disabled

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 11:12:01PM +0100, Paolo Bonzini wrote: Il 21/02/2013 22:07, mdroth ha scritto: 100% agree. In particular hw/dataplane/event-poll.c should be the first to go away, but AioContext provides the functionality that Ping Fan needs. But hw/dataplane/vring.c

Re: [Qemu-devel] [PATCH] qga: cast to int for DWORD type

2013-02-20 Thread mdroth
On Mon, Jan 28, 2013 at 12:49:09PM +0800, Lei Li wrote: This patch fixes a compiler warning when cross-build: qga/service-win32.c: In function 'printf_win_error': qga/service-win32.c:32:5: warning: format '%d' expects argument of type 'int', but argument 3 has type

Re: [Qemu-devel] [PATCH] qemu-ga: fix confusing GAChannelMethod comparison

2013-02-20 Thread mdroth
On Tue, Feb 19, 2013 at 03:12:34PM +0100, Stefan Hajnoczi wrote: In commit 7868e26e5930f49ca942311885776b938dcf3b77 (qemu-ga: add initial win32 support) support was added for qemu-ga on Windows using virtio-serial. Other channel methods (ISA serial and UNIX domain socket) are not supported on

Re: [Qemu-devel] [RFC PATCH 03/10] qemu-ga: Add an configure option to specify path to Windows VSS SDK

2013-02-18 Thread mdroth
On Fri, Feb 15, 2013 at 12:55:49PM +0900, Tomoki Sekiyama wrote: On 2013/02/15 9:47, mdroth wrote: [...] Hi Tomoki, Hi, Did you happen to run into this issue compiling the test program? [mdroth@vm qemu-build]$ ls ~/w/vsssdk/inc/win2003/ vdslun.hvsbackup.hvscoordint.idl

Re: [Qemu-devel] [RFC PATCH 04/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-02-18 Thread mdroth
gotten them all worked out. I've posted what I've gotten so far below, but with those changes applied I'm still running into this one on FC18: [mdroth@vm5 qemu-build]$ rm -rf * ~/w/qemu3.git/configure --enable-guest-agent --cross-prefix=i686-w64-mingw32- --with-vss-sdk=/home/mdroth/w/vsssdk make

Re: [Qemu-devel] [RFC PATCH 03/10] qemu-ga: Add an configure option to specify path to Windows VSS SDK

2013-02-14 Thread mdroth
$vss_win32_sdk + esac + cat $TMPC EOF +#define __MIDL_user_allocate_free_DEFINED__ +#include inc/win2003/vss.h +int main(void) { return VSS_CTX_BACKUP; } +EOF Hi Tomoki, Did you happen to run into this issue compiling the test program? [mdroth@vm qemu-build]$ ls ~/w/vsssdk/inc/win2003

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread mdroth
On Tue, Feb 12, 2013 at 05:56:00PM +0100, Markus Armbruster wrote: Gerd Hoffmann kra...@redhat.com writes: Hi, But why nested discriminators? regular files: type=file serial : type=port, data.type=serial parallel : type=port, data.type=parallel

Re: [Qemu-devel] [PATCH for-1.4 01/12] qmp: Fix design bug and read beyond buffer in memchar-write

2013-02-06 Thread mdroth
On Wed, Feb 06, 2013 at 10:06:03AM +0100, Markus Armbruster wrote: Markus Armbruster arm...@redhat.com writes: Eric Blake ebl...@redhat.com writes: On 02/05/2013 09:22 AM, Markus Armbruster wrote: Command memchar-write takes data and size parameter. Begs the question what happens

Re: [Qemu-devel] [PATCH for-1.4 01/12] qmp: Fix design bug and read beyond buffer in memchar-write

2013-02-06 Thread mdroth
On Wed, Feb 06, 2013 at 09:14:12PM +0100, Markus Armbruster wrote: mdroth mdr...@linux.vnet.ibm.com writes: On Wed, Feb 06, 2013 at 10:06:03AM +0100, Markus Armbruster wrote: Markus Armbruster arm...@redhat.com writes: Eric Blake ebl...@redhat.com writes: On 02/05/2013 09:22 AM

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-02-05 Thread mdroth
On Wed, Jan 30, 2013 at 03:37:25PM +0800, Lei Li wrote: On 01/29/2013 04:24 AM, Anthony Liguori wrote: Eric Blake ebl...@redhat.com writes: On 01/27/2013 11:14 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/qapi/qmp/qerror.h |3 +++

Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-02-01 Thread mdroth
On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit was meant to fix, or if the logic is actually wrong, but it

Re: [Qemu-devel] [PATCH for-1.4] Revert e1000: no need auto-negotiation if link was down

2013-02-01 Thread mdroth
On Fri, Feb 01, 2013 at 03:53:22PM +0800, Amos Kong wrote: On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit

[Qemu-devel] [ANNOUNCE] QEMU 1.3.1 Stable released

2013-01-28 Thread mdroth
Hi everyone, I am pleased to announce that the QEMU v1.3.1 stable release is now available at: http://wiki.qemu.org/download/qemu-1.3.1.tar.bz2 The official stable-1.3 repository has also been updated to v1.3.1: http://git.qemu.org/?p=qemu-stable-1.3.git;a=summary This release includes 29

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.3.1, freeze Monday

2013-01-16 Thread mdroth
On Wed, Jan 16, 2013 at 10:12:38PM +0400, Michael Tokarev wrote: 16.01.2013 20:49, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v1.3.1: https://github.com/mdroth/qemu/commits/stable-1.3-staging The release is planned for 01-25-2013: http

Re: [Qemu-devel] [PATCH] virtio-s390: add a reset function to virtio-s390 devices

2013-01-15 Thread mdroth
On Thu, Jan 10, 2013 at 03:40:25PM +0100, Paolo Bonzini wrote: virtio-s390 devices are not being reset when their bus is. To fix this, add a reset method that forwards to virtio_reset. This is only needed because of the strange modeling of virtio devices; the -vdev link is being handled

Re: [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups

2013-01-14 Thread mdroth
On Fri, Jan 11, 2013 at 11:24:56AM +0100, Markus Armbruster wrote: Markus Armbruster (6): qemu-ga: Document intentional fall through in channel_event_cb() qemu-ga: Drop pointless lseek() from ga_open_pidfile() qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path qemu-ga:

Re: [Qemu-devel] [PATCH] qga: add missing commas in json docs

2013-01-14 Thread mdroth
On Mon, Jan 14, 2013 at 02:54:05PM -0700, Eric Blake wrote: On 01/02/2013 04:14 PM, mdroth wrote: On Wed, Jan 02, 2013 at 09:15:11AM -0700, Eric Blake wrote: * qga/qapi-schema.json: Use valid JSON. Signed-off-by: Eric Blake ebl...@redhat.com Thanks, applied to qga branch Ping. I

Re: [Qemu-devel] [PATCH] qga: add missing commas in json docs

2013-01-14 Thread mdroth
On Mon, Jan 14, 2013 at 02:54:05PM -0700, Eric Blake wrote: On 01/02/2013 04:14 PM, mdroth wrote: On Wed, Jan 02, 2013 at 09:15:11AM -0700, Eric Blake wrote: * qga/qapi-schema.json: Use valid JSON. Signed-off-by: Eric Blake ebl...@redhat.com Thanks, applied to qga branch Ping. I

Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command

2013-01-11 Thread mdroth
On Fri, Jan 11, 2013 at 03:37:26PM +0800, Lei Li wrote: On 01/08/2013 06:04 AM, Eric Blake wrote: On 01/06/2013 03:06 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 12 qga/qapi-schema.json | 17 + 2 files

Re: [Qemu-devel] [PATCH 2/6] qemu-ga: Drop pointless lseek() from ga_open_pidfile()

2013-01-11 Thread mdroth
On Fri, Jan 11, 2013 at 11:24:58AM +0100, Markus Armbruster wrote: After open(), the file offset is already zero, and neither lockf() nor ftruncate() change it. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/main.c | 2 +-

Re: [Qemu-devel] [PATCH 4/6] qemu-ga: Plug fd leak on ga_channel_listen_accept() error path

2013-01-11 Thread mdroth
On Fri, Jan 11, 2013 at 11:25:00AM +0100, Markus Armbruster wrote: Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/channel-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/channel-posix.c

Re: [Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path

2013-01-11 Thread mdroth
On Fri, Jan 11, 2013 at 11:24:59AM +0100, Markus Armbruster wrote: Spotted by Coverity. Also document why we keep it open on success. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/main.c | 2 ++ 1 file changed, 2

Re: [Qemu-devel] [PATCH 1/6] qemu-ga: Document intentional fall through in channel_event_cb()

2013-01-11 Thread mdroth
On Fri, Jan 11, 2013 at 11:24:57AM +0100, Markus Armbruster wrote: For clarity, and to hush up Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/main.c

Re: [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open() error paths

2013-01-11 Thread mdroth
On Fri, Jan 11, 2013 at 11:25:01AM +0100, Markus Armbruster wrote: Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/channel-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/channel-posix.c

Re: [Qemu-devel] [PATCH 6/6] qemu-ga: Handle errors uniformely in ga_channel_open()

2013-01-11 Thread mdroth
On Fri, Jan 11, 2013 at 11:25:02AM +0100, Markus Armbruster wrote: We detect errors in seven places. One reports with g_error(), which Do you mean in several places? I can fix this in tree. calls abort(), the others report with g_critical(). Three of them exit(), three return false.

Re: [Qemu-devel] [PATCH 0/2] qemu-ga: don't leak fds to exec()ed processes

2013-01-10 Thread mdroth
On Tue, Jan 08, 2013 at 07:26:24PM -0200, Luiz Capitulino wrote: Please, check individual patches for details. Luiz Capitulino (2): qemu-ga: ga_open_pidfile(): use qemu_open() qemu-ga: add ga_open_logfile() Thanks, applied to qga branch. qga/main.c | 19 --- 1 file

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-09 Thread mdroth
On Sun, Jan 06, 2013 at 06:06:58PM +0800, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 18 ++ qga/qapi-schema.json | 17 + 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c

Re: [Qemu-devel] [RFC PATCH v4 06/30] qapi: make visit_type_size fallback to type_int

2013-01-09 Thread mdroth
On Wed, Jan 09, 2013 at 01:18:04AM +0100, Andreas Färber wrote: Am 18.12.2012 13:41, schrieb Vasilis Liaskovitis: Currently visit_type_size checks if the visitor's type_size function pointer is NULL. If not, it calls it, otherwise it calls v-type_uint64(). But neither of these

Re: [Qemu-devel] [PATCH v8 0/2] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw

2013-01-08 Thread mdroth
On Wed, Dec 12, 2012 at 12:55:47PM +0900, Tomoki Sekiyama wrote: Hi, This is version 8 of the qemu-ga fsfreeze hook patchset. Thanks, applied to qga branch with some minor clarifications for the help output. *Changes from v7: ( http://patchwork.ozlabs.org/patch/204426/ ) 1/2: Not

Re: [Qemu-devel] Using QEMU guest agent to run programs from guest path]

2013-01-03 Thread mdroth
On Thu, Jan 03, 2013 at 11:06:02AM -0200, Erlon Cruz wrote: On Wed, Jan 2, 2013 at 9:04 PM, mdroth mdr...@linux.vnet.ibm.com wrote: On Mon, Dec 31, 2012 at 06:14:59PM -0200, Erlon Cruz wrote: Hi, I needed to run an external program in a guest machine. Once this must

Re: [Qemu-devel] [RFC] Time resync by qemu-ga

2013-01-02 Thread mdroth
On Fri, Dec 28, 2012 at 12:29:15AM +0800, Lei Li wrote: Hi guys, I am working on the time drift issue as background info here. http://mid.gmane.org/87pq5r5otp@codemonkey.ws As Anthony proposed, one part of the solutions is that we want to add a qemu-ga command to resync the guest

Re: [Qemu-devel] Using QEMU guest agent to run programs from guest path

2013-01-02 Thread mdroth
On Mon, Dec 31, 2012 at 06:14:59PM -0200, Erlon Cruz wrote: Hi, I needed to run an external program in a guest machine. Once this must be triggered by the host, I first thought in qemu-ga. Is that possible? In QEMU help page and in the code I couldn't find such capability. So Im thinking

Re: [Qemu-devel] [PATCH] qga: add missing commas in json docs

2013-01-02 Thread mdroth
On Wed, Jan 02, 2013 at 09:15:11AM -0700, Eric Blake wrote: * qga/qapi-schema.json: Use valid JSON. Signed-off-by: Eric Blake ebl...@redhat.com Thanks, applied to qga branch --- qga/qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-11 Thread mdroth
On Tue, Dec 11, 2012 at 03:14:02PM +, Dietmar Maurer wrote: I'm not sure I like this for two reasons. First, there will be cases where the user doesn't want this to be enabled. Second, we'll be forcing an interval on users. So when should we set the stats-polling-interval? I

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-11 Thread mdroth
On Tue, Dec 11, 2012 at 04:28:40PM -0200, Luiz Capitulino wrote: On Tue, 11 Dec 2012 11:38:08 -0600 mdroth mdr...@linux.vnet.ibm.com wrote: On Tue, Dec 11, 2012 at 03:14:02PM +, Dietmar Maurer wrote: I'm not sure I like this for two reasons. First, there will be cases where

[Qemu-devel] [ANNOUNCE] QEMU 1.2.2 Stable released

2012-12-11 Thread mdroth
Hi everyone, I am pleased to announce that the QEMU v1.2.2 stable release is now available at: http://wiki.qemu.org/download/qemu-1.2.2.tar.bz2 The official stable-1.2 repository has also been updated to v1.2.2: http://git.qemu.org/?p=qemu-stable-1.2.git;a=summary This release includes 43

Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value

2012-12-10 Thread mdroth
On Mon, Dec 10, 2012 at 05:13:45PM +0100, Igor Mammedov wrote: On Fri, 7 Dec 2012 18:09:06 -0200 Eduardo Habkost ehabk...@redhat.com wrote: On Fri, Dec 07, 2012 at 08:00:09PM +0100, Andreas Färber wrote: Am 06.12.2012 22:12, schrieb Igor Mammedov: Signed-off-by: Igor Mammedov

<    1   2   3   >