Re: [Qemu-devel] [RFC PATCH v2 08/12] mc: core logic

2014-02-18 Thread Michael R. Hines
On 02/19/2014 09:07 AM, Li Guang wrote: Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This implements the core logic, all described in the first patch (docs/mc.txt). Signed-off-by: Michael R. Hines --- migration-checkpoin

Re: [Qemu-devel] [RFC PATCH v2 06/12] mc: introduce state machine changes for MC

2014-02-18 Thread Michael R. Hines
On 02/19/2014 09:00 AM, Li Guang wrote: Hi, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This patch sets up the initial changes to the migration state machine and prototypes to be used by the checkpointing code to interact with the state machine so that we can la

Re: [Qemu-devel] [RFC PATCH v2 02/12] mc: timestamp migration_bitmap and KVM logdirty usage

2014-02-18 Thread Michael R. Hines
On 02/18/2014 06:32 PM, Dr. David Alan Gilbert wrote: * mrhi...@linux.vnet.ibm.com (mrhi...@linux.vnet.ibm.com) wrote: From: "Michael R. Hines" We also later export these statistics over QMP for better monitoring of micro-checkpointing as the workload changes. @@ -548,9 +568,11

Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing

2014-02-18 Thread Michael R. Hines
On 02/18/2014 08:45 PM, Dr. David Alan Gilbert wrote: +The Micro-Checkpointing Process +Basic Algorithm +Micro-Checkpoints (MC) work against the existing live migration path in QEMU, and can effectively be understood as a "live migration that never ends". As such, iteration rounds happen at the

Re: [Qemu-devel] [RFC PATCH v2 00/12] mc: fault tolerante through micro-checkpointing

2014-02-18 Thread Michael R. Hines
directory. - Michael mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" Changes since v1: 1. Re-based against Juan's improved migration_bitmap performance changes 2. Overhauled RDMA support to prepare for better usage of RDMA in other parts of the QEMU code base (such as stora

Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress

2014-02-17 Thread Michael R. Hines
On 02/16/2014 10:33 AM, Michael Roth wrote: Quoting Frank (2013-09-12 08:51:56) It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu_rdma_data_init(). From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001 From: Frank Yang Date: Thu, 12 Sep 2013 21:37:56

Re: [Qemu-devel] qemu_rdma_cleanup seg - related to 5a91337?

2014-02-17 Thread Michael R. Hines
On 02/17/2014 05:06 PM, Dr. David Alan Gilbert wrote: * Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: On 02/06/2014 08:26 PM, Dr. David Alan Gilbert wrote: Hi Isaku, I hit a seg in qemu_rdma_cleanup in the code changed by your '[PATCH] rdma: clean up of qemu_rdma_cl

Re: [Qemu-devel] qemu_rdma_cleanup seg - related to 5a91337?

2014-02-16 Thread Michael R. Hines
On 02/06/2014 08:26 PM, Dr. David Alan Gilbert wrote: Hi Isaku, I hit a seg in qemu_rdma_cleanup in the code changed by your '[PATCH] rdma: clean up of qemu_rdma_cleanup()' migration-rdma.c ~ 2241 if (rdma->qp) { rdma_destroy_qp(rdma->cm_id); rdma->qp = NULL; }

Re: [Qemu-devel] [PULL 00/50] migration queue

2014-01-12 Thread Michael R. Hines
On 12/25/2013 12:06 AM, Juan Quintela wrote: Hi Anthony This is the patches in the migration queue. Please pull. This includes: - Eduardo refactorings & tests - Matthew rate limit fix - Zhanghaoyu CANCELLING fixes - My bitmap changes Integration work was done by Orit. Happy Christmas, Juan.

Re: [Qemu-devel] [PATCH] migration: qmp_migrate(): keep working after syntax error

2014-01-02 Thread Michael R. Hines
r *uri, bool has_blk, bool blk, #endif } else { error_set(errp, QERR_INVALID_PARAMETER_VALUE, "uri", "a valid migration protocol"); +s->state = MIG_STATE_ERROR; return; } Reviewed-by: Michael R. Hines

Re: [Qemu-devel] [PATCH 11/17] add argument ram_addr_t to hook_ram_load

2013-12-26 Thread Michael R. Hines
qemu_file_set_error(f, ret); } Reviewed-by: Michael R. Hines

Re: [Qemu-devel] [PATCH 07/17] save_page: replace block_offset with a MemoryRegion

2013-12-26 Thread Michael R. Hines
if (ret != RAM_SAVE_CONTROL_DELAYED) { if (bytes_sent && *bytes_sent > 0) { Reviewed-by: Michael R. Hines

Re: [Qemu-devel] [PATCH v4 resend] rdma: rename 'x-rdma' => 'rdma'

2013-12-18 Thread Michael R. Hines
On 12/18/2013 09:51 PM, Eric Blake wrote: On 12/17/2013 10:43 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As far as we can tell, all known bugs have been fixed: 1. Parallel migrations are working 2. IPv6 migration is working 3. virt-test is working +++ b/qapi-s

Re: [Qemu-devel] [PATCH v2 00/39] bitmap handling optimization

2013-11-24 Thread Michael R. Hines
On 11/25/2013 02:15 PM, Michael R. Hines wrote: On 11/06/2013 09:04 PM, Juan Quintela wrote: Hi [v2] In this version: - fixed all the comments from last versions (thanks Eric) - kvm migration bitmap is synchronized using bitmap operations - qemu bitmap -> migration bitmap is synchronized us

Re: [Qemu-devel] [PATCH v2 00/39] bitmap handling optimization

2013-11-24 Thread Michael R. Hines
On 11/06/2013 11:49 PM, Paolo Bonzini wrote: Il 06/11/2013 15:37, Gerd Hoffmann ha scritto: - vga ram by default is not aligned in a page number multiple of 64, it could be optimized. Kraxel? It syncs the kvm bitmap at least 1 a second or so? bitmap is only 2048 pages (16MB by default). We ne

Re: [Qemu-devel] [PATCH v2 00/39] bitmap handling optimization

2013-11-24 Thread Michael R. Hines
On 11/06/2013 09:04 PM, Juan Quintela wrote: Hi [v2] In this version: - fixed all the comments from last versions (thanks Eric) - kvm migration bitmap is synchronized using bitmap operations - qemu bitmap -> migration bitmap is synchronized using bitmap operations If bitmaps are not properly ali

Re: [Qemu-devel] [PATCH v3 for-1.7 resend] rdma: rename 'x-rdma' => 'rdma'

2013-11-22 Thread Michael R. Hines
On 11/23/2013 12:37 AM, Daniel P. Berrange wrote: On Sat, Nov 23, 2013 at 12:29:51AM +0800, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As far as we can tell, all known bugs have been fixed: 3. Libvirt patches are ready Please stop claiming this. A proof of concept

Re: [Qemu-devel] [PATCH v3 for-1.7] rdma: rename 'x-rdma' => 'rdma'

2013-11-15 Thread Michael R. Hines
On 11/15/2013 02:25 PM, Eric Blake wrote: On 11/15/2013 10:40 AM, Michael R. Hines wrote: This is unrelated to RDMA - accessing the /dev/infiniband device nodes is already supported by libvirt my modifying the configuration file in /etc and that works just fine. http://wiki.qemu.org/Features

Re: [Qemu-devel] [PATCH v3 for-1.7] rdma: rename 'x-rdma' => 'rdma'

2013-11-15 Thread Michael R. Hines
On 11/15/2013 12:06 PM, Daniel P. Berrange wrote: On Wed, Nov 06, 2013 at 01:59:14PM -0500, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As far as we can tell, all known bugs have been fixed: [snip] 3. Libvirt patches are ready [snip] Objections? There was a f

Re: [Qemu-devel] [PATCH v2] rdma: rename 'x-rdma' => 'rdma'

2013-11-06 Thread Michael R. Hines
On 11/05/2013 05:19 PM, Eric Blake wrote: On 10/26/2013 02:03 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As far as we can tell, all known bugs have been fixed: 1. Parallel RDMA migrations are working 2. IPv6 migration is working 3. Libvirt patches are ready 4.

Re: [Qemu-devel] [PATCH v3 0/4] Curling: KVM Fault Tolerance

2013-11-06 Thread Michael R. Hines
On 10/23/2013 01:23 AM, Jules wrote: On 2013-10-22 17:00 -0400,Michael R. Hines wrote: On 10/15/2013 03:26 AM, Jules Wang wrote: v2 -> v3: * add documentation of new option in qapi-schema. * long option name: ft -> fault-tolerant v1 -> v2: * cmdline: migrate cu

Re: [Qemu-devel] [RFC PATCH v1: 11/12] mc: register MC qemu-file functions and expose MC tunable capability

2013-11-06 Thread Michael R. Hines
, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" The capability allows management software to throttle the MC frequency during VM application transience. The qemu-file savevm() functions inform the destination that the incoming traffic is MC-specific traffic and not va

Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' => 'rdma'

2013-10-26 Thread Michael R. Hines
On 10/25/2013 11:14 AM, Paolo Bonzini wrote: Il 25/10/2013 16:03, Michael R. Hines ha scritto: Well, I tried posting libvirt support with this naming scheme, but they didn't accepted. Their reason (Daniel, I think) is valid: experimental implies that it shouldn't be exposed in the

Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' => 'rdma'

2013-10-25 Thread Michael R. Hines
On 10/23/2013 02:25 AM, Paolo Bonzini wrote: Il 22/10/2013 21:20, Eric Blake ha scritto: -# @x-rdma-pin-all: Controls whether or not the entire VM memory footprint is +# @rdma-pin-all: Controls whether or not the entire VM memory footprint is # mlock()'d on demand or all at once. Refe

Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' => 'rdma'

2013-10-25 Thread Michael R. Hines
On 10/22/2013 04:20 PM, Eric Blake wrote: On 10/22/2013 05:59 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As far as we can tell, all known bugs have been fixed, there as been very good participation in testing and running. 1. Parallel RDMA migrations are worki

Re: [Qemu-devel] [PATCH v3 0/4] Curling: KVM Fault Tolerance

2013-10-22 Thread Michael R. Hines
On 10/15/2013 03:26 AM, Jules Wang wrote: v2 -> v3: * add documentation of new option in qapi-schema. * long option name: ft -> fault-tolerant v1 -> v2: * cmdline: migrate curling:tcp:: -> migrate -f tcp:: * sender: use QEMU_VM_FILE_MAGIC_FT as the header of the migration t

Re: [Qemu-devel] [PATCH v3 0/4] Curling: KVM Fault Tolerance

2013-10-22 Thread Michael R. Hines
On 10/15/2013 03:26 AM, Jules Wang wrote: v2 -> v3: * add documentation of new option in qapi-schema. * long option name: ft -> fault-tolerant v1 -> v2: * cmdline: migrate curling:tcp:: -> migrate -f tcp:: * sender: use QEMU_VM_FILE_MAGIC_FT as the header of the migration

Re: [Qemu-devel] [PATCH] rdma: fix multiple VMs parallel migration

2013-10-14 Thread Michael R. Hines
*opaque, */ while (1) { uint64_t wr_id, wr_id_in; -int ret = qemu_rdma_poll(rdma, &wr_id_in, NULL); +int ret = qemu_rdma_poll(rdma, &wr_id_in, NULL, RDMA_WRID_RDMA_WRITE); if (ret < 0) { fprintf(stderr, "rdma migration: polling error! %d\n", ret); goto err; Reviewed-by: Michael R. Hines

Re: [Qemu-devel] [PATCH v3 resend 7/8] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-10-08 Thread Michael R. Hines
On 10/08/2013 12:05 PM, Paolo Bonzini wrote: Il 08/10/2013 16:49, Eric Blake ha scritto: You are now returning a state that older libvirt versions are not expecting. Obviously, we can patch newer libvirt to make migration work again, but should we be thinking about damage control by stating tha

Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: fix multiple VMs parallel migration

2013-09-24 Thread Michael R. Hines
On 09/04/2013 04:10 AM, Frank Yang wrote: On 2013-9-3 13:03, Lei Li wrote: Hi Frank, I failed to apply this patch. Please make sure to use git-send-email, otherwise it's a little hard to review. :) On 08/30/2013 08:39 PM, Frank Yang wrote: When several VMs migrate with RDMA at the same time,

Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress

2013-09-24 Thread Michael R. Hines
igration-rdma.c > @@ -2512,6 +2512,7 @@ static void *qemu_rdma_data_init(const char *host_port, > Error **errp) > } > } > > +qapi_free_InetSocketAddress(addr); > return rdma; > } > Reviewed-by: Michael R. Hines

Re: [Qemu-devel] [PATCH 1/2] rdma: constify ram_chunk_{index, start, end}

2013-09-24 Thread Michael R. Hines
On 09/24/2013 01:38 PM, Juan Quintela wrote: "Michael R. Hines" wrote: On 09/24/2013 12:36 PM, Juan Quintela wrote: "Michael R. Hines" wrote: On 09/20/2013 03:55 AM, Isaku Yamahata wrote: On Wed, Sep 18, 2013 at 10:28:51AM -0400, Michael R. Hines wrote: On 09/03/

Re: [Qemu-devel] [PATCH 1/2] rdma: constify ram_chunk_{index, start, end}

2013-09-24 Thread Michael R. Hines
On 09/24/2013 12:36 PM, Juan Quintela wrote: "Michael R. Hines" wrote: On 09/20/2013 03:55 AM, Isaku Yamahata wrote: On Wed, Sep 18, 2013 at 10:28:51AM -0400, Michael R. Hines wrote: On 09/03/2013 10:32 PM, Isaku Yamahata wrote: Signed-off-by: Isaku Yamahata There's no

Re: [Qemu-devel] [PATCH 2/2] rdma: simplify qemu_rdma_register_and_get_keys()

2013-09-20 Thread Michael R. Hines
On 09/20/2013 12:59 PM, Isaku Yamahata wrote: On Wed, Sep 18, 2013 at 11:01:16AM -0400, Michael R. Hines wrote: The value of chunk_end changes based on whether or not the value of block->is_ram_block is true of false. When is block->is_ram_block set to false? Looking at __qemu_rdma_add

Re: [Qemu-devel] [PATCH 1/2] rdma: constify ram_chunk_{index, start, end}

2013-09-20 Thread Michael R. Hines
On 09/20/2013 03:55 AM, Isaku Yamahata wrote: On Wed, Sep 18, 2013 at 10:28:51AM -0400, Michael R. Hines wrote: On 09/03/2013 10:32 PM, Isaku Yamahata wrote: Signed-off-by: Isaku Yamahata --- migration-rdma.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH v2] migration: ram_handle_compressed

2013-09-20 Thread Michael R. Hines
On 09/20/2013 03:51 AM, Isaku Yamahata wrote: ram_handle_compressed() should be aware of size > TARGET_PAGE_SIZE. migration-rdma can call it with larger size. Signed-off-by: Isaku Yamahata --- changes v1 -> v2: - don't loop --- arch_init.c | 11 ++- 1 file changed, 6 insertions(+),

Re: [Qemu-devel] [PATCH 2/2] rdma: simplify qemu_rdma_register_and_get_keys()

2013-09-18 Thread Michael R. Hines
On 09/03/2013 10:32 PM, Isaku Yamahata wrote: Signed-off-by: Isaku Yamahata --- migration-rdma.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index db5a908..941c07e 100644 --- a/migration-rdma.c +++ b/migrat

Re: [Qemu-devel] [PATCH 1/2] rdma: constify ram_chunk_{index, start, end}

2013-09-18 Thread Michael R. Hines
On 09/03/2013 10:32 PM, Isaku Yamahata wrote: Signed-off-by: Isaku Yamahata --- migration-rdma.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index e71c10a..db5a908 100644 --- a/migration-rdma.c +++ b/migration-rdma.c @@ -5

Re: [Qemu-devel] [PATCH] migration: ram_handle_compressed

2013-09-18 Thread Michael R. Hines
On 09/18/2013 06:07 AM, Isaku Yamahata wrote: ram_handle_compressed() should be aware size > TARGET_PAGE_SIZE migration-rdma can call it with larger size. Signed-off-by: Isaku Yamahata --- arch_init.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [Qemu-stable][PATCH] rdma: fix multiple VMs parallel migration

2013-09-03 Thread Michael R. Hines
No top-posting, please. On 09/03/2013 12:20 AM, Frank Yang wrote: Yes, it depends on low-level implementation. During my earlier test, using one CQ to send and receive may cause packet loss with heavy load: the destination thinks it send READY message successfully but the source still waits for

Re: [Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local()

2013-08-29 Thread Michael R. Hines
On 08/28/2013 02:37 AM, Paolo Bonzini wrote: Il 28/08/2013 05:26, Lei Li ha scritto: RAMBlock structs are not visible outside of exec.c and arch_init.c, how did you do this? Hi Michael, Good catch! Actually this is the 'Known issue' that I listed in the cover letter, and I planed to ask sugges

Re: [Qemu-devel] [PATCH resend 2/3] savevm: fix wrong error set by ram_control_load_hook()

2013-08-23 Thread Michael R. Hines
; Reviewed-By: Michael R. Hines

Re: [Qemu-devel] [PATCH resend 2/3] savevm: fix wrong error set by ram_control_load_hook()

2013-08-23 Thread Michael R. Hines
On 08/23/2013 09:30 AM, Lei Li wrote: It should set negative error value if there has been an error. Signed-off-by: Lei Li --- savevm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 95a11f9..a0be109 100644 --- a/savevm.c +++ b/savevm.c @@

Re: [Qemu-devel] [PATCH 11/18] migration: introduce capability localhost

2013-08-22 Thread Michael R. Hines
On 08/21/2013 11:18 AM, Paolo Bonzini wrote: Il 21/08/2013 09:18, Lei Li ha scritto: } else if (strstart(uri, "unix:", &p)) { +if (s->enabled_capabilities[MIGRATION_CAPABILITY_LOCALHOST]) { +local_start_outgoing_migration(s, p, &local_err); +} unix_sta

Re: [Qemu-devel] [PATCH 10/18] migration-local: implementation of outgoing part

2013-08-22 Thread Michael R. Hines
On 08/21/2013 03:18 AM, Lei Li wrote: Implementation of outgoing part for localhost migration. The integration of migration thread and corresponding adjustment will be in coming patches. Signed-off-by: Lei Li --- include/migration/migration.h |2 + migration-local.c | 85 ++

Re: [Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local()

2013-08-22 Thread Michael R. Hines
On 08/21/2013 03:18 AM, Lei Li wrote: Introduce read/write backend of QEMUFileLocal used by localhost migration. The unix domain socket will be replaced by PIPE with vmsplice mechanism. Signed-off-by: Lei Li --- Makefile.objs |1 + migration-local.c | 211 +++

Re: [Qemu-devel] [PATCH 07/18] arch_init: export RAM_SAVE_xxx flags

2013-08-22 Thread Michael R. Hines
On 08/21/2013 06:49 AM, Paolo Bonzini wrote: Il 21/08/2013 09:18, Lei Li ha scritto: Export RAM_SAVE_xxx flags for localhost migration. Signed-off-by: Lei Li --- arch_init.c | 12 include/migration/migration.h | 14 ++ 2 files changed, 14 inse

Re: [Qemu-devel] [PATCH] rdma: clean up of qemu_rdma_cleanup()

2013-08-22 Thread Michael R. Hines
at it should be destroyed by rdma_destroy_qp(). not ibv_destroy_qp() Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index 3d1266f..e71c10a 100644

Re: [Qemu-devel] [PATCH v2 for-1.6 6/6] rdma: remaining documentation fixes

2013-08-09 Thread Michael R. Hines
On 08/09/2013 04:26 PM, Eric Blake wrote: On 08/09/2013 02:05 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" Was missing 'setup-time' in some of the QMP documentation... Signed-off-by: Michael R. Hines --- qmp-commands.hx | 10 ++ 1 file ch

Re: [Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Michael R. Hines
On 08/08/2013 02:41 PM, Eric Blake wrote: On 08/08/2013 11:05 AM, Orit Wasserman wrote: "ram" is present also when migration completes. expected-downtime, total-time and downtime are no longer part of "ram" data. Signed-off-by: Orit Wasserman --- qmp-commands.hx | 20 ++-- 1

Re: [Qemu-devel] [PATCH for-1.6 4/4] rdma: proper getaddrinfo() handling

2013-08-08 Thread Michael R. Hines
On 08/08/2013 02:12 AM, Orit Wasserman wrote: On 08/07/2013 07:05 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" getaddrinfo() already knows what it's doing, wqand can potentially return multiple addresses. Signed-off-by: Michael R. Hines --- migratio

Re: [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len

2013-08-07 Thread Michael R. Hines
On 08/06/2013 10:26 PM, Isaku Yamahata wrote: RDMAControlHeader::len is remote-provided. So validate the value before use. Isaku Yamahata (3): rdma: use resp.len after validation in qemu_rdma_registration_stop rdma: validate RDMAControlHeader::len rdma: check if RDMAControlHeader::len m

Re: [Qemu-devel] [PATCH v3 For-1.6 1/7] rdma: bugfix: make IPv6 support work

2013-08-07 Thread Michael R. Hines
On 08/07/2013 04:39 AM, Orit Wasserman wrote: On 08/04/2013 05:54 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" RDMA does not use sockets, so we cannot use many of the socket helper functions, but we *do* use inet_parse() which gives RDMA all the necessary deta

Re: [Qemu-devel] [PATCH 0/3] rdma fixes and clean ups

2013-08-03 Thread Michael R. Hines
On 08/03/2013 09:24 PM, Isaku Yamahata wrote: On Fri, Aug 02, 2013 at 09:40:58AM -0400, "Michael R. Hines" wrote: On 08/01/2013 11:56 PM, Isaku Yamahata wrote: Small fixes/clean up to rdma. found through code review. Isaku Yamahata (3): rdma: don't use negative index t

Re: [Qemu-devel] [PATCH 07/12] savevm: introduce qemu_savevm_local()

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- include/sysemu/sysemu.h |1 + savevm.c| 55 +++ 2 files changed, 56 insertions(+), 0 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h

Re: [Qemu-devel] [PATCH 12/12] hmp: add hmp_localhost_migration interface

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 17 + hmp.c | 13 + hmp.h |1 + 3 files changed, 31 insertions(+), 0 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 915b0d1..ed21970

Re: [Qemu-devel] [PATCH 11/12] migration-local: add option to commandline for incoming-local

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- qemu-options.hx |9 + vl.c| 14 ++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8355f9b..a975e83 100644 --- a/qemu-options.hx +++ b

Re: [Qemu-devel] [PATCH 09/12] migration-local: implementation of outgoing part

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- Makefile.objs |1 + include/migration/migration.h | 15 migration-local.c | 158 + migration-unix.c | 13 qapi-schema.json

Re: [Qemu-devel] [PATCH 06/12] arch_init: add save_local_setup to savevm_ram_handlers

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- arch_init.c |1 + include/migration/vmstate.h |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 7eeb52f..5c25005 100644 --- a/arch_init.c +++ b/arch_ini

Re: [Qemu-devel] [PATCH 05/12] arch_init: introduce ram_save_local()

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- arch_init.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index a418071..7eeb52f 100644 --- a/arch_init.c +++ b/arch_init.c @@ -757,6 +757,38 @@

Re: [Qemu-devel] [PATCH 04/12] arch_init: introduce ram_page_save()

2013-08-02 Thread Michael R. Hines
On 07/25/2013 04:18 PM, Lei Li wrote: Signed-off-by: Lei Li --- arch_init.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index a8b91ee..a418071 100644 --- a/arch_init.c +++ b/arch_i

Re: [Qemu-devel] [PATCH 3/7] arch_init: add ram_madvise_free()

2013-08-02 Thread Michael R. Hines
On 06/16/2013 12:04 PM, Anthony Liguori wrote: Lei Li writes: Signed-off-by: Lei Li --- arch_init.c | 13 + include/migration/migration.h |3 +++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 872020e..fc

Re: [Qemu-devel] [PATCH 0/3] rdma fixes and clean ups

2013-08-02 Thread Michael R. Hines
On 08/01/2013 11:56 PM, Isaku Yamahata wrote: Small fixes/clean up to rdma. found through code review. Isaku Yamahata (3): rdma: don't use negative index to array rdma: qemu_rdma_post_send_control uses wrongly RDMA_WRID_MAX rdma: use RDMA_WRID_READY migration-rdma.c | 43 ++

Re: [Qemu-devel] [PATCH 3/3] rdma: use RDMA_WRID_READY

2013-08-02 Thread Michael R. Hines
On 08/01/2013 11:56 PM, Isaku Yamahata wrote: Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index 67069d2..871f9cd 100644 --- a/migration-rdma.c +++ b

Re: [Qemu-devel] [PATCH 2/3] rdma: qemu_rdma_post_send_control uses wrongly RDMA_WRID_MAX

2013-08-02 Thread Michael R. Hines
On 08/01/2013 11:56 PM, Isaku Yamahata wrote: RDMA_WRID_CONTROL should be used. And remove related work around. Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/migration-rdma.c b

Re: [Qemu-devel] [PATCH 1/3] rdma: don't use negative index to array

2013-08-02 Thread Michael R. Hines
On 08/01/2013 11:56 PM, Isaku Yamahata wrote: Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index 4828738..edbae9f 100644 --- a

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-31 Thread Michael R. Hines
On 07/30/2013 11:31 AM, Orit Wasserman wrote: On 07/30/2013 05:57 PM, Michael R. Hines wrote: On 07/30/2013 04:14 AM, Orit Wasserman wrote: On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" When testing with libvirt, a simple IPv6 migration t

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-30 Thread Michael R. Hines
On 07/30/2013 04:14 AM, Orit Wasserman wrote: On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" When testing with libvirt, a simple IPv6 migration test failed because we were not using getaddrinfo() properly. This makes IPv6 migration over RDMA work.

Re: [Qemu-devel] [PATCH v3 2/4] migration: fix spice migration

2013-07-29 Thread Michael R. Hines
On 07/29/2013 11:01 AM, Stefan Hajnoczi wrote: On Mon, Jul 29, 2013 at 10:46:50AM -0400, Michael R. Hines wrote: On 07/29/2013 09:01 AM, Stefan Hajnoczi wrote: Commit 29ae8a4133082e16970c9d4be09f4b6a15034617 ("rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition"

Re: [Qemu-devel] [PATCH v3 2/4] migration: fix spice migration

2013-07-29 Thread Michael R. Hines
t detected this using migration_is_active(). Spice is now notified with MIG_STATE_SETUP and migration_is_active() no longer works. Replace migration_is_active() with migration_in_setup() to fix spice migration. Cc: Michael R. Hines Signed-off-by: Stefan Hajnoczi --- include/migration/migra

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-26 Thread Michael R. Hines
On 07/26/2013 10:30 PM, Andreas Färber wrote: Am 27.07.2013 04:23, schrieb mrhi...@linux.vnet.ibm.com: From: "Michael R. Hines" When testing with libvirt, a simple IPv6 migration test failed because we were not using getaddrinfo() properly. This makes IPv6 migration over RDMA work.

Re: [Qemu-devel] [PATCH v3 resend 4/8] rdma: core logic

2013-07-18 Thread Michael R. Hines
On 07/18/2013 03:30 AM, Marcel Apfelbaum wrote: On Tue, 2013-07-16 at 12:48 -0400, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" Code that does need to be visible is kept well contained inside this file and this is the only new additional file to the entire patch.

Re: [Qemu-devel] [PATCH v3 resend/cleanup 1/8] rdma: update documentation to reflect new unpin support

2013-07-12 Thread Michael R. Hines
On 07/12/2013 01:39 PM, Eric Blake wrote: On 07/12/2013 11:26 AM, Michael R. Hines wrote: On 07/12/2013 01:09 PM, Eric Blake wrote: On 07/12/2013 08:40 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As requested, the protocol now includes memory unpinning support

Re: [Qemu-devel] [PATCH v3 resend/cleanup 1/8] rdma: update documentation to reflect new unpin support

2013-07-12 Thread Michael R. Hines
On 07/12/2013 01:09 PM, Eric Blake wrote: On 07/12/2013 08:40 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As requested, the protocol now includes memory unpinning support. This has been implemented in a non-optimized manner, in such a way that one could devise

Re: [Qemu-devel] [PATCH v2 4/8] rdma: unpin support

2013-07-01 Thread Michael R. Hines
On 07/01/2013 08:04 AM, Paolo Bonzini wrote: Il 28/06/2013 21:59, mrhi...@linux.vnet.ibm.com ha scritto: +/* + * Perform a non-optimized memory unregistration after every transfer + * for demonsration purposes, only if pin-all is not requested. + * + * Potential optimizations: + * 1. Start a new

Re: [Qemu-devel] [PATCH v2 0/8] rdma: core logic w/ unpin example

2013-06-28 Thread Michael R. Hines
27;ll do the same on the libvirt mailing list. - Michael On 06/28/2013 03:59 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This version seems ready to go, if there are no fundamental problems. Changes since v1: - Complete endianness handling of all protocol m

Re: [Qemu-devel] [PATCH v2 1/8] rdma: update documentation to reflect new unpin support

2013-06-28 Thread Michael R. Hines
On 06/28/2013 04:14 PM, Eric Blake wrote: On 06/28/2013 01:59 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As requested, the protocol now includes memory unpinning support. This has been implemented in a non-optimized manner, in such a way that one could devise

Re: [Qemu-devel] [PATCH v12 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP

2013-06-28 Thread Michael R. Hines
Juan Quintela Signed-off-by: Michael R. Hines Usually, Reviewed-by lines are listed _after_ S-o-b lines - signature lines are typically chronological, but the patch has to be signed before a review can have any weight at getting the patch into a pull request :) Hmm, that's not how I understoo

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-28 Thread Michael R. Hines
On 06/28/2013 10:07 AM, Peter Maydell wrote: On 28 June 2013 15:00, Michael R. Hines wrote: On 06/28/2013 09:28 AM, Peter Maydell wrote: Is endianess for the data a big issue when you are assume the migration is happening across identical CPU architectures? Well: * is that a reasonable

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-28 Thread Michael R. Hines
On 06/28/2013 03:33 AM, Paolo Bonzini wrote: Il 28/06/2013 00:44, mrhi...@linux.vnet.ibm.com ha scritto: + * + * This will have a terrible impact on migration performance, so until future + * workload information or LRU information is available, do not attempt to use + * this feature except for

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-28 Thread Michael R. Hines
On 06/28/2013 09:28 AM, Peter Maydell wrote: On 28 June 2013 14:23, Michael R. Hines wrote: I assume from the PACKED annotations (do we really need both, incidentally) that this is shared with either the guest or with another instance of QEMU. Are there definitely no endianness issues to deal

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-28 Thread Michael R. Hines
On 06/27/2013 07:16 PM, Peter Maydell wrote: On 27 June 2013 23:44, wrote: +if test "$rdma" != "no" ; then + cat > $TMPC < +int main(void) { return 0; } +EOF + rdma_libs="-lrdmacm -libverbs" + if compile_prog "-Werror" "$rdma_libs" ; then Do you really need -Werror in your test's CFLAGS? I

Re: [Qemu-devel] [PATCH 1/6] rdma: update documentation to reflect new unpin support

2013-06-28 Thread Michael R. Hines
On 06/27/2013 07:09 PM, Eric Blake wrote: On 06/27/2013 04:44 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As requested, the protocol now includes memory unpinning support. This has been implemented in a non-optimized manner, in such a way that one could devise

Re: [Qemu-devel] [PATCH v12 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP

2013-06-28 Thread Michael R. Hines
Juan Quintela Signed-off-by: Michael R. Hines Usually, Reviewed-by lines are listed _after_ S-o-b lines - signature lines are typically chronological, but the patch has to be signed before a review can have any weight at getting the patch into a pull request :) Hmm, that's not how I und

Re: [Qemu-devel] [PATCH v12 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP

2013-06-28 Thread Michael R. Hines
On 06/27/2013 06:58 PM, Eric Blake wrote: On 06/25/2013 07:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" Using the previous patches, we're now able to timestamp the SETUP state. Once we have this time, let the user know about it in the schema. Reviewed-by

Re: [Qemu-devel] [PATCH v12 04/15] rdma: export throughput w/ MigrationStats QMP

2013-06-28 Thread Michael R. Hines
On 06/27/2013 07:02 PM, Eric Blake wrote: On 06/25/2013 07:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This exposes throughput (in megabits/sec) through QMP. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vin

Re: [Qemu-devel] [PATCH v12 01/15] rdma: add documentation

2013-06-27 Thread Michael R. Hines
On 06/27/2013 06:41 PM, Eric Blake wrote: On 06/25/2013 07:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact information. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed

Re: [Qemu-devel] [PATCH] linux-user: Fix compilation failure

2013-06-27 Thread Michael R. Hines
On 06/27/2013 03:53 PM, Peter Maydell wrote: Fix compilation failures for linux-user targets following recent migration related commits bd2fa51fcd and 43487c67. Signed-off-by: Peter Maydell --- Longer term we should probably try to disentangle migration from user-mode emulators a bit better (eg

Re: [Qemu-devel] [PULL 00/12] migration queue

2013-06-27 Thread Michael R. Hines
On 06/27/2013 03:20 PM, Peter Maydell wrote: On 27 June 2013 11:37, Juan Quintela wrote: Anthony, please pull. - improve error message (Alon) - Make zero pages to work again (Peter Lieven) - First 10 patches of RDMA support Hi; could you adjust your pullrequest scripts to retransmit the patc

Re: [Qemu-devel] [PATCH v12 08/15] rdma: introduce qemu_ram_foreach_block()

2013-06-27 Thread Michael R. Hines
On 06/27/2013 03:24 PM, Peter Maydell wrote: On 26 June 2013 02:35, wrote: --- a/exec.c +++ b/exec.c @@ -2630,3 +2630,12 @@ bool cpu_physical_memory_is_io(hwaddr phys_addr) memory_region_is_romd(mr)); } #endif + +void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaqu

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-26 Thread Michael R. Hines
On 06/26/2013 10:57 AM, Paolo Bonzini wrote: Il 26/06/2013 16:09, Michael R. Hines ha scritto: *This requires some steps:* 1. First, maintain a new data structure: something like "These memory ranges are 'being unpinned'" - block all potential writes to these

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-26 Thread Michael R. Hines
On 06/26/2013 08:39 AM, Paolo Bonzini wrote: Il 26/06/2013 14:37, Michael R. Hines ha scritto: On 06/26/2013 02:37 AM, Paolo Bonzini wrote: Il 26/06/2013 02:31, Michael R. Hines ha scritto: On 06/25/2013 05:06 PM, Paolo Bonzini wrote: Il 25/06/2013 22:56, Michael R. Hines ha scritto: I was

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-26 Thread Michael R. Hines
On 06/26/2013 02:37 AM, Paolo Bonzini wrote: Il 26/06/2013 02:31, Michael R. Hines ha scritto: On 06/25/2013 05:06 PM, Paolo Bonzini wrote: Il 25/06/2013 22:56, Michael R. Hines ha scritto: I was wrong - this does require a protocol extension. This is because the RDMA transfers are

[Qemu-devel] [PATCH v12 00/15] rdma: migration support

2013-06-25 Thread Michael R. Hines
Changes since v11: - Minor state transition fix - Fixed localhost migration - Fixed 0.0.0.0 migration - Drop invalid hunk - Updated tags Michael R. Hines (15): rdma: add documentation rdma: introduce qemu_update_position() rdma: export yield_until_fd_readable() rdma: export throughput w

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Michael R. Hines
On 06/25/2013 05:06 PM, Paolo Bonzini wrote: Il 25/06/2013 22:56, Michael R. Hines ha scritto: I was wrong - this does require a protocol extension. This is because the RDMA transfers are asynchronous, and thus we cannot know in advance that it is safe to unregister the memory associated with

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Michael R. Hines
On 06/25/2013 10:55 AM, Paolo Bonzini wrote: Il 25/06/2013 16:54, Michael R. Hines ha scritto: Do those few lines of code change the protocol? If yes, I'll go against all my previous recommendations and suggest a #define. If no, it is fine to leave it for later, but I would still su

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Michael R. Hines
On 06/25/2013 10:17 AM, Juan Quintela wrote: "Michael R. Hines" wrote: On 06/25/2013 06:13 AM, Paolo Bonzini wrote: Il 25/06/2013 11:49, Juan Quintela ha scritto: mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As described in the previous patch, until now,

Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic

2013-06-25 Thread Michael R. Hines
On 06/25/2013 12:31 PM, Vasilis Liaskovitis wrote: Hi, On Mon, Jun 24, 2013 at 09:58:01PM -0400, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" [...] +/* + * Put in the log file which RDMA device was opened and the details + * associated with that device. + */ +s

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Michael R. Hines
On 06/25/2013 10:55 AM, Paolo Bonzini wrote: Il 25/06/2013 16:54, Michael R. Hines ha scritto: Do those few lines of code change the protocol? If yes, I'll go against all my previous recommendations and suggest a #define. If no, it is fine to leave it for later, but I would still su

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Michael R. Hines
On 06/25/2013 10:17 AM, Juan Quintela wrote: "Michael R. Hines" wrote: On 06/25/2013 06:13 AM, Paolo Bonzini wrote: Il 25/06/2013 11:49, Juan Quintela ha scritto: mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As described in the previous patch, until now,

<    1   2   3   4   5   6   7   8   >