uot;).
Cc: Alex Williamson
Cc: Cédric Le Goater
Signed-off-by: Zhao Liu
Reviewed-by: Cédric Le Goater
Message-ID: <20240311033822.3142585-25-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
hw/vfio/platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/vfio/plat
From: Philippe Mathieu-Daudé
Mechanical patch produced running the command documented
in scripts/coccinelle/cpu_env.cocci_template header.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Message-ID: <20240129164514.73104-8-phi...@linaro.org>
Signed-off-by: Thoma
nongnu.org
Signed-off-by: Zhao Liu
Message-ID: <20240311033822.3142585-12-zhao1@linux.intel.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
block/vdi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/vdi.c b/block/vdi.c
index 3b57becb9f..6363da08ce 100644
--- a/b
n Wolf
Cc: Hanna Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Stefan Hajnoczi
Message-ID: <20240311033822.3142585-10-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/qed.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qed.c b/b
m>
Signed-off-by: Thomas Huth
---
backends/iommufd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/backends/iommufd.c b/backends/iommufd.c
index 1ef683c7b0..62a79fa6b0 100644
--- a/backends/iommufd.c
+++ b/backends/iommufd.c
@@ -43,6 +43,7 @@ static void iommufd_backend_finalize(Object *obj
in the commit message of commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: Alex Williamson
Cc: Cédric Le Goater
Signed-off-by: Zhao Liu
Reviewed-by: Cédric Le Goater
Message-ID: <20240311033822.3142585-24-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
--
c: qemu-bl...@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240311033822.3142585-6-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/nbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nbd.c b/block/nbd.c
index b9d4f935e0..e
message of commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: Alex Williamson
Cc: Cédric Le Goater
Signed-off-by: Zhao Liu
Reviewed-by: Cédric Le Goater
Message-ID: <20240311033822.3142585-23-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
hw/vfio/pci-quirks.
uot;).
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Zhao Liu
Message-ID: <20240311033822.3142585-11-zhao1@linux.intel.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
block/snapshot.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/sn
P_GUARD() right at the beginning of the function, because only then
can it guard the whole function.", so clean up the few spots
disregarding the advice.
Inspired-by: Markus Armbruster
Signed-off-by: Zhao Liu
Reviewed-by: Markus Armbruster
Message-ID: <20240312060337.3240965-1-zhao1@linux.intel.com
the bug that dereferencing
the NULL @errp.
To follow the requirement of @errp, add missing ERRP_GUARD() in
cxl_usp_realize().
Suggested-by: Markus Armbruster
Signed-off-by: Zhao Liu
Reviewed-by: Markus Armbruster
Reviewed-by: Thomas Huth
Message-ID: <20240223085653.1255438-6-zh
ks that need a rebase, and fixed sizeof() in pmu_realize()]
Signed-off-by: Thomas Huth
---
hw/display/ati.c | 2 +-
hw/misc/macio/pmu.c | 3 +--
hw/misc/pvpanic-pci.c | 2 +-
hw/pci-bridge/cxl_root_port.c | 2 +-
hw/ppc/pnv.c | 20 ++--
: <20240223085653.1255438-8-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
hw/intc/ioapic_common.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/intc/ioapic_common.c b/hw/intc/ioapic_common.c
index cb9bf62146..efbe6958c8 100644
--- a/hw/intc/ioapic_common.c
+++ b/h
From: Philippe Mathieu-Daudé
Mechanical patch produced running the command documented
in scripts/coccinelle/cpu_env.cocci_template header.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-ID: <20240129164514.73104-19-phi...@linaro.org>
Signed-off-by: Thoma
the bug that dereferencing
the NULL @errp.
To follow the requirement of @errp, add missing ERRP_GUARD() in
ct3_realize().
Suggested-by: Markus Armbruster
Signed-off-by: Zhao Liu
Reviewed-by: Markus Armbruster
Message-ID: <20240223085653.1255438-4-zhao1@linux.intel.com>
Signed-off-by:
ge-ID: <20240223085653.1255438-2-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
hw/cxl/cxl-host.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c
index 2aa776c79c..c5f5fcfd64 100644
--- a/hw/cxl/cxl-host.c
+++ b/hw/cxl/cx
The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f:
Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging
(2024-03-09 20:12:21 +)
are available in the Git repository at:
https://gitlab.com/thuth/qemu.git tags/pull-request-2024-03-12
for
I agree, though the new code is perfectly valid, it looks nicer if we'd use
a variable here instead.
Thomas
CPU() cast (Paolo)
- Split per targets (Thomas)
Use cpu_env() -- which is fast path -- when possible.
Bulk conversion using Coccinelle spatch (script included).
Philippe Mathieu-Daudé (29):
bulk: Access existing variables initialized to >F when available
hw/core: Declare CPUArchId::
On 12/03/2024 11.26, Zhao Liu wrote:
On Tue, Mar 12, 2024 at 09:50:25AM +0100, Thomas Huth wrote:
Date: Tue, 12 Mar 2024 09:50:25 +0100
From: Thomas Huth
Subject: Re: [PATCH v2 00/29] Cleanup up to fix missing ERRP_GUARD() for
error_prepend()
On 12/03/2024 09.43, Zhao Liu wrote:
Hi Thomas
= PCIE_PORT(d);
CXLUpstreamPort *usp = CXL_USP(d);
CXLComponentState *cxl_cstate = >cxl_cstate;
Reviewed-by: Thomas Huth
g_autofree void *transfer_buf = NULL;
g_autoptr(GError) g_err = NULL;
Reviewed-by: Thomas Huth
VHostVSock *vsock = VHOST_VSOCK(dev);
Reviewed-by: Thomas Huth
On 12/03/2024 09.43, Zhao Liu wrote:
Hi Thomas/Markus/Michael,
For the remaing patches, could you please help me merge them next?
Many thanks!
Yes, I'm currently reviewing the ones that don't have a Reviewed-by yet. I
can pick up the remaining patches if the other maintainers won't pick
H_UNLOCKED
vdi_co_do_create(BlockdevCreateOptions *create_options, size_t block_size,
Error **errp)
{
+ERRP_GUARD();
BlockdevCreateOptionsVdi *vdi_opts;
int ret = 0;
uint64_t bytes = 0;
Reviewed-by: Thomas Huth
@@ -605,6 +606,7 @@ int bdrv_all_goto_snapshot(const char *name,
bool has_devices, strList *devices,
Error **errp)
{
+ERRP_GUARD();
g_autoptr(GList) bdrvs = NULL;
GList *iterbdrvs;
int ret;
Reviewed-by: Thomas Huth
line arguments" section, which may
cause confusion about the contents of this patch.
---
docs/about/deprecated.rst | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Thomas Huth
not quite right...or does it need to be fixed? If so I can tweak
and clean it up with a minor patch. ;-)
Yes, please send a patch to clean it up!
Thanks
Thomas
Algorithm_str(test_data[i].alg),
+ QCryptoCipherMode_str(test_data[i].mode));
}
}
Reviewed-by: Thomas Huth
pher != NULL);
} else {
error_free_or_abort();
Reviewed-by: Thomas Huth
(qcrypto_cipher_alg_to_gcry_alg(alg),
+ GCRYCTL_TEST_ALGO, NULL, NULL) != 0) {
+return false;
+}
+
switch (mode) {
case QCRYPTO_CIPHER_MODE_ECB:
case QCRYPTO_CIPHER_MODE_CBC:
Reviewed-by: Thomas Huth
(-)
Reviewed-by: Thomas Huth
On Mon, Mar 11, 2024 at 01:08:19PM +0100, Philippe Mathieu-Daudé wrote:
> On 11/3/24 12:46, Thomas Weißschuh wrote:
> > Only a small subset of all blockdev drivers make sense for firmware
> > images. Introduce and use a new enum to represent this.
> >
> > This
On 11/03/2024 11.14, Daniel P. Berrangé wrote:
On Mon, Mar 11, 2024 at 09:32:32AM +, Daniel P. Berrangé wrote:
On Fri, Mar 08, 2024 at 09:30:52PM +0100, Thomas Huth wrote:
On 07/12/2023 16.47, Hyman Huang wrote:
Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016).
SM4 (GBT.32907
To make sure that the QAPI description stays valid add a testcase.
Suggested-by: Philippe Mathieu-Daudé
Link:
https://lore.kernel.org/qemu-devel/d9ce0234-4beb-4b90-b14c-76810d3b8...@linaro.org/
Signed-off-by: Thomas Weißschuh
---
docs/meson.build | 5 +
1 file changed, 5 insertions
Only a small subset of all blockdev drivers make sense for firmware
images. Introduce and use a new enum to represent this.
This also reduces the dependency of firmware.json on the global qapi
definitions.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Thomas Weißschuh
---
docs/interop
docs/interop/firmware.json is currently not usable with qapi-gen.py due
to various non-functional issues.
Fix those issue to provide compatibility.
Signed-off-by: Thomas Weißschuh
---
Changes in v3:
- Drop already picked up patches
- Drop include of pragma.json
- Introduce new enums
Only a small subset of all architectures supported by qemu make use of
firmware files. Introduce and use a new enum to represent this.
This also removes the dependency of firmware.json on the global qapi
definitions.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Thomas Weißschuh
---
docs
--quiet according to the docs:
https://docs.gitlab.com/ee/ci/runners/configure_runners.html#git-fetch-extra-flags
Should we include --quite here, too?
Thomas
I know it's too late now for a patch review, but anyway: What about the
other spots that set up a "CPUDebug" struct? Like monitor_disas() or
target_disas() ? Shouldn't we initialize the new struct member there, too?
Thomas
vm.add_source_dir(args.build_qemu)
Reviewed-by: Thomas Huth
tests/vm/basevm.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Thomas Huth
Shutdown requests are normally hardware dependent.
By extending pvpanic to also handle shutdown requests, guests can
submit such requests with an easily implementable and cross-platform
mechanism.
Signed-off-by: Thomas Weißschuh
---
This patch was split out from my earlier pvpanic-shutdown
Am Sat, 9 Mar 2024 10:34:59 +0100
schrieb Angelo Dureghello :
> Add reset support for mcf5208.
>
> Signed-off-by: Angelo Dureghello
> ---
> hw/m68k/mcf5208.c | 44 ++--
> 1 file changed, 42 insertions(+), 2 deletions(-)
Reviewed-by: Thomas Huth
> /* Timers. */
> @@ -265,7 +308,7 @@ static void mcf5208evb_init(MachineState *machine)
> mcf_uart_create_mmap(0xfc064000, pic[27], serial_hd(1));
> mcf_uart_create_mmap(0xfc068000, pic[28], serial_hd(2));
>
> -mcf5208_sys_init(address_space_mem, pic);
> +mcf5208_sys_init(address_space_mem, pic, cpu);
>
> mcf_fec_init(address_space_mem, 0xfc03, pic + 36);
All in all, patch looks fine to me ... if you could update the above two
nits by Monday, I can try to get this merged before the next soft freeze of
QEMU (on Tuesday).
Thanks,
Thomas
be that there is maybe an
endianess issue somewhere in here...
Thomas
diff --git a/crypto/block-luks.c b/crypto/block-luks.c
index fb01ec38bb..f0813d69b4 100644
--- a/crypto/block-luks.c
+++ b/crypto/block-luks.c
@@ -95,12 +95,23 @@ qcrypto_block_luks_cipher_size_map_twofish[] = {
{ 0, 0
+
hw/arm/tosa.c | 1 +
hw/arm/z2.c | 1 +
8 files changed, 24 insertions(+)
Reviewed-by: Thomas Huth
anged, 61 insertions(+), 16 deletions(-)
Reviewed-by: Thomas Huth
On 08/03/2024 09.08, Philippe Mathieu-Daudé wrote:
On 7/3/24 20:43, Thomas Huth wrote:
On 28/02/2024 17.43, Zhao Liu wrote:
Hi Philippe,
+/*
+ * Real ICH9 contains a single SMI output line and doesn't broadcast CPUs.
+ * Virtualized ICH9 allows broadcasting upon negatiation with guest, see
On Fri, Mar 08, 2024 at 04:19:42PM +0100, Markus Armbruster wrote:
> Thomas Weißschuh writes:
>
> > The included files are part of the toplevel QAPI directory and need to
> > be included from there.
> >
> > Signed-off-by: Thomas Weißschuh
> > ---
> >
On 08/03/2024 16.43, Peter Maydell wrote:
On Fri, 8 Mar 2024 at 10:42, Thomas Huth wrote:
Support for these boards has been removed from the Linux kernel
in version 6.3 in 2023, so there are likely no users left for these
boards. Time to mark them as deprecated in QEMU, too!
Signed-off
On 08/03/2024 15.00, Peter Maydell wrote:
On Fri, 8 Mar 2024 at 12:54, Thomas Huth wrote:
I gave it a try, but then we end up again with the problem that I already
mentioned in the discussion about patch 1: CONFIG_ARM_V7M is not set for the
linux-user binaries, so m_helper.c would not get
If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged
helper functions that require additional functions for linking. Use some
stubs functions that call g_assert_not_reached() instead.
Signed-off-by: Thomas Huth
---
target/arm/tcg/m_helper.c | 93
onfig file.
v3:
- Rebase to current master branch
- Make sure that the stubs use g_assert_not_reached() in the second patch
v2:
- Updated a comment
- Avoid #ifdef in cpu-v7m.c, handle it via meson.build instead
Thomas Huth (3):
target/arm: Move v7m-related code from cpu32.c into a separate fil
Now that we made sure that ARM_V7M code only gets compiled if really
needed, we can drop the hard requirement for CONFIG_ARM_V7M in the
Kconfig file.
Signed-off-by: Thomas Huth
---
target/arm/Kconfig | 4
1 file changed, 4 deletions(-)
diff --git a/target/arm/Kconfig b/target/arm/Kconfig
Move the code to a separate file so that we do not have to compile
it anymore if CONFIG_ARM_V7M is not set.
Signed-off-by: Thomas Huth
---
target/arm/tcg/cpu-v7m.c | 290 +
target/arm/tcg/cpu32.c | 261 -
target/arm
ms, , true);
-
-/* Unsupported parameters can be provided with their values as 1 */
-data.config.has_dies = true;
-data.config.dies = 1;
-smp_parse_test(ms, , true);
}
object_unref(obj);
Reviewed-by: Thomas Huth
On 06/03/2024 10.53, Zhao Liu wrote:
From: Zhao Liu
SMPConfiguration initializes its int64_t members as 0 by default.
Can we always rely on that? ... or is this just by luck due to the current
implementation? In the latter case, I'd maybe rather drop this patch again.
Thomas
Therefore
On 04/03/2024 16.22, Peter Maydell wrote:
On Thu, 1 Feb 2024 at 19:12, Thomas Huth wrote:
On 01/02/2024 15.19, Peter Maydell wrote:
On Mon, 29 Jan 2024 at 08:18, Thomas Huth wrote:
If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged
helper functions that require
On 08/03/2024 12.26, Peter Maydell wrote:
On Fri, 8 Mar 2024 at 06:01, Thomas Huth wrote:
If you try to run the configure script on a system without a working
C compiler, you get a very misleading error message:
ERROR: Unrecognized host OS (uname -s reports 'Linux')
We should rather tell
Support for these boards has been removed from the Linux kernel
in version 6.3 in 2023, so there are likely no users left for these
boards. Time to mark them as deprecated in QEMU, too!
Signed-off-by: Thomas Huth
---
docs/about/deprecated.rst | 8
hw/arm/mainstone.c| 1 +
hw
On 08/03/2024 11.12, Zhao Liu wrote:
Hi Thomas,
void s390_realize_cpu_model(CPUState *cs, Error **errp)
{
+ERRP_GUARD();
Error *err = NULL;
I think that function could use an additional clean-up now: Remove the local
"err" variable and use "errp" only in
und
before an attempt to clean it up.
I think this file originate from the Linux kernel repo, so it might be a
good idea to keep it in sync with the version from there?
Thomas
: Christian Borntraeger
Cc: Thomas Huth
Signed-off-by: Cédric Le Goater
---
Reviewed-by: Thomas Huth
time to figure
out what was going wrong.
Fixes: 264b803721 ("configure: remove compiler sanity check")
Signed-off-by: Thomas Huth
---
configure | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 3cd736b139..a036923dee 100755
--- a
On 07/03/2024 22.22, Richard Henderson wrote:
On 3/7/24 07:43, Thomas Huth wrote:
+ /* Fix up legacy names with '+' in it */
+ if (g_str_equal(typename, SPARC_CPU_TYPE_NAME("Sun-UltraSparc-IV+"))) {
+ g_free(typename);
+ typename = g_strdup(SPARC_CPU_TYPE
,
+ICH9_VIRT_SMI_CURRENT,
+#define ICH9_VIRT_SMI_COUNT 2
+};
+
Just quick look here. Shouldn't ICH9_VIRT_SMI_COUNT be defined outside of
enum {}?
Or even better, do it without a #define:
enum {
ICH9_VIRT_SMI_BROADCAST,
ICH9_VIRT_SMI_CURRENT,
ICH9_VIRT_SMI_COUNT
};
Thomas
On 04/03/2024 16.12, Anthony Krowiak wrote:
On 2/29/24 12:30 PM, Thomas Huth wrote:
On 29/02/2024 15.39, Zhao Liu wrote:
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD
For consistency we should drop the names with a "+" in it in the
long run.
Signed-off-by: Thomas Huth
---
docs/about/deprecated.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 8565644da6..7058341f8f 100644
Remove the unnecessary "Sparc" at the beginning of the line and
put the chip information into parentheses so that it is clearer
which part of the line have to be passed to "-cpu" to specify a
different CPU.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2141
Signed
Add some words about how to enable or disable boolean features,
and remove the note about a Linux kernel being available on the
QEMU website (they have been removed long ago already).
Signed-off-by: Thomas Huth
---
docs/system/target-sparc.rst | 8 ++--
1 file changed, 6 insertions(+), 2
provide
backward compatibility for the old names via some simple checks in the
sparc_cpu_class_by_name() function.
Signed-off-by: Thomas Huth
---
qom/object.c | 8
target/sparc/cpu.c | 14 --
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/qom/object.c b
since this character is now not allowed in device names anymore
(and was worked around with an ugly hack in qom/object.c so far).
Thomas Huth (5):
target/sparc/cpu: Rename the CPU models with a "+" in their names
target/sparc/cpu: Avoid spaces by default in the CPU names
target/sparc/
ttps://gitlab.com/qemu-project/qemu/-/issues/2141
Signed-off-by: Thomas Huth
---
target/sparc/cpu.c | 56 +++---
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index 651e49bfeb..ae30cded22 100644
--- a/
docs/interop/firmware.json is currently not usable with qapi-gen.py due
to various non-functional issues.
Fix those issue to provide compatibility.
Signed-off-by: Thomas Weißschuh
---
Changes in v2:
- Add review tag from Philippe
- Add Fixes tag (Philippe)
- Add testcase (Philippe)
- Link to v1
To make sure that the QAPI description stays valid add a testcase.
Suggested-by: Philippe Mathieu-Daudé
Link:
https://lore.kernel.org/qemu-devel/d9ce0234-4beb-4b90-b14c-76810d3b8...@linaro.org/
Signed-off-by: Thomas Weißschuh
---
docs/meson.build | 5 +
1 file changed, 5 insertions
The files included by firmware.json use names that do not satisfy the
generators requirements.
By including pragma.json these errors are suppressed.
Signed-off-by: Thomas Weißschuh
---
docs/interop/firmware.json | 2 ++
1 file changed, 2 insertions(+)
diff --git a/docs/interop/firmware.json b
The included files are part of the toplevel QAPI directory and need to
be included from there.
Signed-off-by: Thomas Weißschuh
---
docs/interop/firmware.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
index
The QAPI generator now validates the alignment and rejects this file.
Signed-off-by: Thomas Weißschuh
---
docs/interop/firmware.json | 384 ++---
1 file changed, 192 insertions(+), 192 deletions(-)
diff --git a/docs/interop/firmware.json b/docs/interop
The doc title did not match the actual definition.
Fixes: 2720ceda05 ("docs: expand firmware descriptor to allow flash without
NVRAM")
Signed-off-by: Thomas Weißschuh
Reviewed-by: Philippe Mathieu-Daudé
---
docs/interop/firmware.json | 2 +-
1 file changed, 1 insertion(+), 1 deletio
ers only equals 1 since we've checked zero case. */
+warn_report("Deprecated CPU topology (considered invalid): "
+"Unsupported drawers parameter mustn't be "
+"specified as 1");
+}
}
drawers = drawers > 0 ? drawers : 1;
Apart from the typos, patch looks fine. I recommend to run "checkpath.pl"
with the --codespell parameter, that helps to avoid those.
Thomas
rse.c | 92 +
1 file changed, 92 insertions(+)
Reviewed-by: Thomas Huth
Xiaoling Song
---
tests/unit/test-smp-parse.c | 103
1 file changed, 103 insertions(+)
Reviewed-by: Thomas Huth
diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
index aea1b2e73a55..0cf611519865 100644
--- a/tests/unit/test-smp-p
F, 0, F, 0),
+.expect_error = "Invalid SMP CPUs 4096. The max CPUs supported "
You could maybe use stringify(MAX_CPUS) in above line
(but it won't work for the 4095 below, so it's maybe not worth the effort)
+"by machine '" SMP_MACHINE_NAME "' is 4095",
},
};
Reviewed-by: Thomas Huth
/pc.c | 19 ---
2 files changed, 12 insertions(+), 11 deletions(-)
Reviewed-by: Thomas Huth
old VM.
- */
-if (!cpu->kvm_no_smi_migration) {
-events.flags |= KVM_VCPUEVENT_VALID_SMM;
-}
Shouldn't it be the other way round, i.e. that the flag is now always set?
pc_compat_2_3[] had:
{ TYPE_X86_CPU, "kvm-no-smi-migration", "on" },
... so I think kvm_no_smi_migration was set to true for the old machines?
Thomas
Reviewed-by: Thomas Huth
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
AcpiBuildState::rsdp is always NULL, remove it,
simplifying acpi_build_update().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/acpi-build.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Thomas Huth
-build.c | 35 ---
hw/i386/pc.c | 1 -
3 files changed, 4 insertions(+), 33 deletions(-)
Reviewed-by: Thomas Huth
ts"
- " or PCI bridges.\n");
-}
acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE);
Thomas
docs/about/deprecated.rst | 2 +-
docs/about/removed-features.rst | 2 +-
include/hw/i386/pc.h| 3 ---
hw/i386/pc.c| 7 ---
hw/i386/pc_piix.c | 23 ---
5 files changed, 2 insertions(+), 35 deletions(-)
Reviewed-by: Thomas Huth
hw/mem/pc-dimm.c | 2 +-
hw/virtio/virtio-md-pci.c | 2 +-
5 files changed, 8 insertions(+), 13 deletions(-)
Reviewed-by: Thomas Huth
| 6 ++
hw/ppc/spapr.c | 2 +-
6 files changed, 7 insertions(+), 10 deletions(-)
Reviewed-by: Thomas Huth
... it would be nice if you could update that, too.
Thanks,
Thomas
/pc.c | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Thomas Huth
now empty, remove it too.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/kvm/kvm-cpu.h | 41 ---
target/i386/kvm/kvm-cpu.c | 3 +--
2 files changed, 1 insertion(+), 43 deletions(-)
delete mode 100644 target/i386/kvm/kvm-cpu.h
Reviewed-by: Thomas Huth
ec-usb-xhci", "force-pcie-endcap", "on" },
-{ "pci-serial", "prog_if", "0" },
-{ "pci-serial-2x", "prog_if", "0" },
-{ "pci-serial-4x", "prog_if", "0" },
-{ "virtio-net-pci", "guest_announce", "off" },
-{ "ICH9-LPC", "memory-hotplug-support", "off" },
I think you could clean up memory-hotplug-support for the ICH9-LPC device
now, too (in a separate patch).
For this patch here:
Reviewed-by: Thomas Huth
On Wed, Mar 06, 2024 at 05:15:34PM +0100, Philippe Mathieu-Daudé wrote:
> On 6/3/24 11:31, Thomas Weißschuh wrote:
> > docs/interop/firmware.json is currently not usable with qapi-gen.py due
> > to various non-functional issues.
> > Fix those issue to provide compatibility.
&
e the exact size of the 2.0 tables.
+ * combinations.
*
* All this is for PIIX4, since QEMU 2.0 didn't support Q35 migration.
I think you could remove this "All this is for ..." sentence now, too?
Thomas
*/
-if (pcmc->legacy_acpi_table_size) {
-/* Sub
--
hw/usb/hcd-xhci-pci.c | 1 -
hw/usb/hcd-xhci.c | 42 --
4 files changed, 8 insertions(+), 38 deletions(-)
Reviewed-by: Thomas Huth
701 - 800 of 18468 matches
Mail list logo
