Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-03 Thread Christian Schoenebeck
On Donnerstag, 3. September 2020 11:35:14 CEST Greg Kurz wrote: > > On the long term that would be possible, however only with a protocol > > change allowing server to send minimum, maximum and recommended msize to > > client. > Hmm... not sure adding a new 9P protocol version for this is the > way

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-03 Thread Greg Kurz
On Thu, 03 Sep 2020 10:20:40 +0200 Christian Schoenebeck wrote: > On Mittwoch, 2. September 2020 18:54:22 CEST Greg Kurz wrote: > > > Well, I can do that of course. But somehow I fear users get lost by just > > > pointing them to "man 1 qemu" in the log message. It already starts that > > > e.g.

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-03 Thread Christian Schoenebeck
On Mittwoch, 2. September 2020 18:54:22 CEST Greg Kurz wrote: > > Well, I can do that of course. But somehow I fear users get lost by just > > pointing them to "man 1 qemu" in the log message. It already starts that > > e.g. on Debian there is no "man qemu", it is "man qemu-system" there > > instea

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-02 Thread Greg Kurz
On Wed, 02 Sep 2020 18:03:12 +0200 Christian Schoenebeck wrote: > On Mittwoch, 2. September 2020 16:10:35 CEST Daniel P. Berrangé wrote: > > > Yeah, I know, but the problem is I don't see how I would squeeze the > > > relevant information into only one log message; and even "what's a good > > > s

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-02 Thread Daniel P . Berrangé
On Wed, Sep 02, 2020 at 06:03:12PM +0200, Christian Schoenebeck wrote: > On Mittwoch, 2. September 2020 16:10:35 CEST Daniel P. Berrangé wrote: > > > Yeah, I know, but the problem is I don't see how I would squeeze the > > > relevant information into only one log message; and even "what's a good >

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-02 Thread Christian Schoenebeck
On Mittwoch, 2. September 2020 16:10:35 CEST Daniel P. Berrangé wrote: > > Yeah, I know, but the problem is I don't see how I would squeeze the > > relevant information into only one log message; and even "what's a good > > starting point" is already questionable. > > > > For that reason my plan w

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-02 Thread Daniel P . Berrangé
On Wed, Sep 02, 2020 at 04:08:48PM +0200, Christian Schoenebeck wrote: > On Mittwoch, 2. September 2020 15:45:03 CEST Daniel P. Berrangé wrote: > > To be clear, I'm not objecting to warning - just that the proposed warning > > doesn't give any useful information about what is considered to be a > >

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-02 Thread Christian Schoenebeck
On Mittwoch, 2. September 2020 15:45:03 CEST Daniel P. Berrangé wrote: > To be clear, I'm not objecting to warning - just that the proposed warning > doesn't give any useful information about what is considered to be a > sensible alternative size, and nor does the commit message. > > Just like to

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-02 Thread Christian Schoenebeck
Hi Eric, do you remember any specific reason why the default 'msize' for the Linux kernel's 9P client was chosen such low as 8 kiB? (see QEMU discussion below). Best regards, Christian Schoenebeck On Mittwoch, 2. September 2020 15:39:34 CEST Greg Kurz wrote: > On Wed, 02 Sep 2020 14:52:33 +0200

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-02 Thread Daniel P . Berrangé
On Wed, Sep 02, 2020 at 03:39:34PM +0200, Greg Kurz wrote: > On Wed, 02 Sep 2020 14:52:33 +0200 > Christian Schoenebeck wrote: > > > On Mittwoch, 2. September 2020 14:25:47 CEST Daniel P. Berrangé wrote: > > > On Wed, Sep 02, 2020 at 01:22:49PM +0200, Christian Schoenebeck wrote: > > > > It is es

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-02 Thread Greg Kurz
On Wed, 02 Sep 2020 14:52:33 +0200 Christian Schoenebeck wrote: > On Mittwoch, 2. September 2020 14:25:47 CEST Daniel P. Berrangé wrote: > > On Wed, Sep 02, 2020 at 01:22:49PM +0200, Christian Schoenebeck wrote: > > > It is essential to choose a reasonable high value for 'msize' to avoid > > > se

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-02 Thread Christian Schoenebeck
On Mittwoch, 2. September 2020 14:25:47 CEST Daniel P. Berrangé wrote: > On Wed, Sep 02, 2020 at 01:22:49PM +0200, Christian Schoenebeck wrote: > > It is essential to choose a reasonable high value for 'msize' to avoid > > severe degraded file I/O performance. This parameter has to be chosen > > on

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-02 Thread Daniel P . Berrangé
On Wed, Sep 02, 2020 at 01:22:49PM +0200, Christian Schoenebeck wrote: > It is essential to choose a reasonable high value for 'msize' to avoid > severe degraded file I/O performance. This parameter has to be chosen > on client/guest side, and a Linux client defaults to an 'msize' of only > 8192 if

[PATCH] 9pfs: log warning if msize <= 8192

2020-09-02 Thread Christian Schoenebeck
It is essential to choose a reasonable high value for 'msize' to avoid severe degraded file I/O performance. This parameter has to be chosen on client/guest side, and a Linux client defaults to an 'msize' of only 8192 if the user did not explicitly specify a value for 'msize'. Unfortunately many u