Re: [PATCH] hmp: Fix loadvm to resume the VM on success instead of failure

2021-05-25 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Commit f61fe11aa6f broke hmp_loadvm() by adding an incorrect negation > when converting from 0/-errno return values to a bool value. The result > is that loadvm resumes the VM now if it failed and keeps it stopped if > it failed. Fix it to restore the old

Re: [PATCH] hmp: Fix loadvm to resume the VM on success instead of failure

2021-05-12 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Commit f61fe11aa6f broke hmp_loadvm() by adding an incorrect negation > when converting from 0/-errno return values to a bool value. The result > is that loadvm resumes the VM now if it failed and keeps it stopped if > it failed. Fix it to restore the old

Re: [PATCH] hmp: Fix loadvm to resume the VM on success instead of failure

2021-05-11 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 06:58:01PM +0200, Kevin Wolf wrote: > Am 11.05.2021 um 18:49 hat Daniel P. Berrangé geschrieben: > > On Tue, May 11, 2021 at 06:31:51PM +0200, Kevin Wolf wrote: > > > Commit f61fe11aa6f broke hmp_loadvm() by adding an incorrect negation > > > when converting from 0/-errno

Re: [PATCH] hmp: Fix loadvm to resume the VM on success instead of failure

2021-05-11 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 06:31:51PM +0200, Kevin Wolf wrote: > Commit f61fe11aa6f broke hmp_loadvm() by adding an incorrect negation > when converting from 0/-errno return values to a bool value. The result > is that loadvm resumes the VM now if it failed and keeps it stopped if > it failed. Fix it

Re: [PATCH] hmp: Fix loadvm to resume the VM on success instead of failure

2021-05-11 Thread Kevin Wolf
Am 11.05.2021 um 18:49 hat Daniel P. Berrangé geschrieben: > On Tue, May 11, 2021 at 06:31:51PM +0200, Kevin Wolf wrote: > > Commit f61fe11aa6f broke hmp_loadvm() by adding an incorrect negation > > when converting from 0/-errno return values to a bool value. The result > > is that loadvm resumes

[PATCH] hmp: Fix loadvm to resume the VM on success instead of failure

2021-05-11 Thread Kevin Wolf
Commit f61fe11aa6f broke hmp_loadvm() by adding an incorrect negation when converting from 0/-errno return values to a bool value. The result is that loadvm resumes the VM now if it failed and keeps it stopped if it failed. Fix it to restore the old behaviour and do it the other way around.