Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 16:33, Philippe Mathieu-Daudé wrote: > > * unrealize() must clean up everything realize() creates. > > Hmm I guess remember someone once said "only for hot-pluggable objects, > else don't bother". But then we make a non-hot-pluggable object as > hot-pluggable and have to fix

Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-13 Thread Philippe Mathieu-Daudé
edhat.com] Sent: Wednesday, February 12, 2020 2:16 PM To: Chenqun (kuhn) ; qemu- de...@nongnu.org; i.mitsya...@gmail.com; peter.mayd...@linaro.org Cc: qemu-triv...@nongnu.org; Zhanghailiang Subject: Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init On 2/12/20 4:36 AM,

Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-13 Thread Markus Armbruster
audé [mailto:phi...@redhat.com] >> > > Sent: Wednesday, February 12, 2020 2:16 PM >> > > To: Chenqun (kuhn) ; qemu- >> > > de...@nongnu.org; i.mitsya...@gmail.com; peter.mayd...@linaro.org >> > > Cc: qemu-triv...@nongnu.org; Zhanghailiang &g

RE: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-12 Thread Chenqun (kuhn)
anghailiang >; Markus Armbruster > >Subject: Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in >exynos4210_uart_init > >On Wed, Feb 12, 2020 at 08:39:55AM +0100, Philippe Mathieu-Daudé wrote: >> Cc'ing Eduardo & Markus. >> >> On 2/12/20 7:44 AM, C

Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-12 Thread Eduardo Habkost
Wednesday, February 12, 2020 2:16 PM > > > To: Chenqun (kuhn) ; qemu- > > > de...@nongnu.org; i.mitsya...@gmail.com; peter.mayd...@linaro.org > > > Cc: qemu-triv...@nongnu.org; Zhanghailiang > > > > > > Subject: Re: [PATCH] hw/char/exynos4210_u

Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-11 Thread Philippe Mathieu-Daudé
Cc: qemu-triv...@nongnu.org; Zhanghailiang Subject: Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init On 2/12/20 4:36 AM, kuhn.chen...@huawei.com wrote: From: Chen Qun It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute&q

RE: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-11 Thread Chenqun (kuhn)
;Subject: Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in >exynos4210_uart_init > >On 2/12/20 4:36 AM, kuhn.chen...@huawei.com wrote: >> From: Chen Qun >> >> It's easy to reproduce as follow: >> virsh qemu-monitor-command vm1 --pretty '{"execute

Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/12/20 4:36 AM, kuhn.chen...@huawei.com wrote: From: Chen Qun It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments":{"typename":"exynos4210.uart"}}' ASAN shows memory leak stack: #1 0xfffd896d71cb in g_malloc0 (/lib6

[PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-11 Thread kuhn.chenqun
From: Chen Qun It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments":{"typename":"exynos4210.uart"}}' ASAN shows memory leak stack: #1 0xfffd896d71cb in g_malloc0 (/lib64/libglib-2.0.so.0+0x571cb) #2 0xaaad270beee3 in tim