Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-15 Thread David Gibson
On Wed, Oct 14, 2020 at 07:15:47AM -0700, Elena Afanasova wrote: > On Tue, 2020-10-13 at 16:32 +1100, David Gibson wrote: > > On Mon, Oct 12, 2020 at 03:45:02PM +0200, Paolo Bonzini wrote: > > > On 12/10/20 12:44, Thomas Huth wrote: > > > > I think this is one of the tasks from: > > > > > > > >

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-14 Thread Elena Afanasova
On Tue, 2020-10-13 at 16:32 +1100, David Gibson wrote: > On Mon, Oct 12, 2020 at 03:45:02PM +0200, Paolo Bonzini wrote: > > On 12/10/20 12:44, Thomas Huth wrote: > > > I think this is one of the tasks from: > > > > > > > > >

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 03:45:02PM +0200, Paolo Bonzini wrote: > On 12/10/20 12:44, Thomas Huth wrote: > > I think this is one of the tasks from: > > > > https://wiki.qemu.org/Contribute/BiteSizedTasks#Compiler-driven_cleanups > > > > It has been added by Paolo in 2016: > > > > > >

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-12 Thread Paolo Bonzini
On 12/10/20 12:44, Thomas Huth wrote: > I think this is one of the tasks from: > > https://wiki.qemu.org/Contribute/BiteSizedTasks#Compiler-driven_cleanups > > It has been added by Paolo in 2016: > > > https://wiki.qemu.org/index.php?title=Contribute/BiteSizedTasks=5368=5367 > > ... so

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-12 Thread Philippe Mathieu-Daudé
700 Subject: [PATCH] hw/net: move allocation to the heap due to very large stack   frame Patch looks fine, but some more details of the motivation would be nice.  I wouldn't have thought that the size of a network packet counted as a "very large" stack frame by userspace standards. Maybe a

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/10/20 8:07 AM, David Gibson wrote: On Fri, Oct 09, 2020 at 07:02:56AM -0700, Elena Afanasova wrote: >From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00 2001 From: Elena Afanasova Date: Fri, 9 Oct 2020 06:41:36 -0700 Subject: [PATCH] hw/net: move allocation to the heap

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-12 Thread Thomas Huth
37c12350d9e55466fdce8a Mon Sep 17 00:00:00 >>>>> 2001 >>>> From: Elena Afanasova >>>> Date: Fri, 9 Oct 2020 06:41:36 -0700 >>>> Subject: [PATCH] hw/net: move allocation to the heap due to very >>>> large stack >>>> frame &

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-11 Thread David Gibson
Elena Afanasova > > > Date: Fri, 9 Oct 2020 06:41:36 -0700 > > > Subject: [PATCH] hw/net: move allocation to the heap due to very large > > > stack > > > frame > > > > Patch looks fine, but some more details of the motivation would be > > nic

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-11 Thread David Gibson
> > 2001 > > > From: Elena Afanasova > > > Date: Fri, 9 Oct 2020 06:41:36 -0700 > > > Subject: [PATCH] hw/net: move allocation to the heap due to very > > > large stack > > > frame > > > > Patch looks fine, but some more details of th

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-10 Thread Li Qiang
: [PATCH] hw/net: move allocation to the heap due to very large stack > > frame > > Patch looks fine, but some more details of the motivation would be > nice. I wouldn't have thought that the size of a network packet > counted as a "very large" stack frame by userspace

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-10 Thread Elena Afanasova
:36 -0700 > > Subject: [PATCH] hw/net: move allocation to the heap due to very > > large stack > > frame > > Patch looks fine, but some more details of the motivation would be > nice. I wouldn't have thought that the size of a network packet > counted as a "very

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-10 Thread David Gibson
On Fri, Oct 09, 2020 at 07:02:56AM -0700, Elena Afanasova wrote: > >From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00 2001 > From: Elena Afanasova > Date: Fri, 9 Oct 2020 06:41:36 -0700 > Subject: [PATCH] hw/net: move allocation to the heap due to very large stack

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-09 Thread Li Qiang
Elena Afanasova 于2020年10月9日周五 下午10:03写道： > > From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00 2001 > From: Elena Afanasova > Date: Fri, 9 Oct 2020 06:41:36 -0700 > Subject: [PATCH] hw/net: move allocation to the heap due to very large stack > frame > &

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-09 Thread Greg Kurz
On Fri, 09 Oct 2020 07:02:56 -0700 Elena Afanasova wrote: > From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00 2001 > From: Elena Afanasova > Date: Fri, 9 Oct 2020 06:41:36 -0700 > Subject: [PATCH] hw/net: move allocation to the heap due to very large stack > fram

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-09 Thread Philippe Mathieu-Daudé
On 10/9/20 4:02 PM, Elena Afanasova wrote: From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00 2001 From: Elena Afanasova Date: Fri, 9 Oct 2020 06:41:36 -0700 Subject: [PATCH] hw/net: move allocation to the heap due to very large stack frame Signed-off-by: Elena Afanasova

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-09 Thread Richard Henderson
On 10/9/20 9:02 AM, Elena Afanasova wrote: > From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00 2001 > From: Elena Afanasova > Date: Fri, 9 Oct 2020 06:41:36 -0700 > Subject: [PATCH] hw/net: move allocation to the heap due to very large stack > frame > >

[PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-09 Thread Elena Afanasova
>From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00 2001 From: Elena Afanasova Date: Fri, 9 Oct 2020 06:41:36 -0700 Subject: [PATCH] hw/net: move allocation to the heap due to very large stack frame Signed-off-by: Elena Afanasova --- hw/net/spapr_llan.c | 5 +++-- 1 f