Re: [PATCH] iotests: Drop deprecated 'props' from object-add

2021-02-19 Thread Kevin Wolf
Am 19.02.2021 um 13:45 hat Alberto Garcia geschrieben: > On Fri 19 Feb 2021 01:21:49 PM CET, Kevin Wolf wrote: > >> log(vm.qmp('object-add', qom_type='throttle-group', id='tg0', > >> - props={ 'x-bps-total': size })) > >> + x_bps_total=size)) > > > > x-bps-total isn't a stable

Re: [PATCH] iotests: Drop deprecated 'props' from object-add

2021-02-19 Thread Alberto Garcia
On Fri 19 Feb 2021 01:21:49 PM CET, Kevin Wolf wrote: >> log(vm.qmp('object-add', qom_type='throttle-group', id='tg0', >> - props={ 'x-bps-total': size })) >> + x_bps_total=size)) > > x-bps-total isn't a stable interface, I'd prefer to use limits. > > My patch from November [1

Re: [PATCH] iotests: Drop deprecated 'props' from object-add

2021-02-19 Thread Alberto Garcia
On Fri 19 Feb 2021 01:04:00 PM CET, Max Reitz wrote: > Two Python syntax nit picks below. >> ret = vm.qmp('object-add', qom_type='throttle-group', id='tg', >> - props={'x-bps-read': 4096}) >> + x_bps_read = 4096) > > To stay consistent, I think there shouldn’

Re: [PATCH] iotests: Drop deprecated 'props' from object-add

2021-02-19 Thread Kevin Wolf
Am 16.02.2021 um 18:16 hat Alberto Garcia geschrieben: > Signed-off-by: Alberto Garcia > diff --git a/tests/qemu-iotests/235 b/tests/qemu-iotests/235 > index 20d16dbf38..f5c73b9c17 100755 > --- a/tests/qemu-iotests/235 > +++ b/tests/qemu-iotests/235 > @@ -57,7 +57,7 @@ vm.add_args('-drive', 'id=s

Re: [PATCH] iotests: Drop deprecated 'props' from object-add

2021-02-19 Thread Max Reitz
On 16.02.21 18:16, Alberto Garcia wrote: Signed-off-by: Alberto Garcia --- tests/qemu-iotests/087 | 8 ++-- tests/qemu-iotests/184 | 18 ++ tests/qemu-iotests/218 | 2 +- tests/qemu-iotests/235 | 2 +- tests/qemu-iotests/245 | 4 ++-- tests/qemu

[PATCH] iotests: Drop deprecated 'props' from object-add

2021-02-16 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- tests/qemu-iotests/087 | 8 ++-- tests/qemu-iotests/184 | 18 ++ tests/qemu-iotests/218 | 2 +- tests/qemu-iotests/235 | 2 +- tests/qemu-iotests/245 | 4 ++-- tests/qemu-iotests/258 | 7 +++ tests/qemu-iotests